Re: [libvirt] [PATCH] qemu: fix cannot get a hot-unplug disk blockdevio settings

2014-11-14 Thread Luyao Huang
On 11/15/2014 06:29 AM, John Ferlan wrote: On 11/13/2014 10:21 PM, Luyao Huang wrote: It would help to put the bz link in here: https://bugzilla.redhat.com/show_bug.cgi?id=1164080 When we try to get a hot-unplug disk blkdevio settings via qemuDomainGetBlockIoTune, libvirt will output a cann

Re: [libvirt] [PATCH] qemu: fix cannot get a hot-unplug disk blockdevio settings

2014-11-14 Thread John Ferlan
On 11/13/2014 10:21 PM, Luyao Huang wrote: It would help to put the bz link in here: https://bugzilla.redhat.com/show_bug.cgi?id=1164080 > When we try to get a hot-unplug disk blkdevio settings via > qemuDomainGetBlockIoTune, libvirt will output a cannot find > device error.Move the check afte

Re: [libvirt] [PATCH v2 4/4] qemu-command: introduce new vgamem attribute for video devices

2014-11-14 Thread Pavel Hrdina
On 11/14/2014 04:25 PM, Gerd Hoffmann wrote: On Fr, 2014-11-14 at 16:13 +0100, Pavel Hrdina wrote: On 11/14/2014 04:06 PM, Gerd Hoffmann wrote: On Fr, 2014-11-14 at 14:54 +0100, Pavel Hrdina wrote: +if (video->vram % 1024) { +virReportError(VIR_ERR_CONFIG_UNSUPPORTED, +

Re: [libvirt] [PATCH 0/2] Add missing check and test for new blkdeviotune parameters

2014-11-14 Thread John Ferlan
On 11/14/2014 04:19 AM, Ján Tomko wrote: > On 11/12/2014 04:16 PM, John Ferlan wrote: >> Found missing 'size_iops_sec' check in qemu_command.c. >> >> Add a test for the new blkdeviotune parameters. >> >> John Ferlan (2): >> qemu: Add checks for blkdeviotune 'size_iops_sec' and adjust error >>

Re: [libvirt] [PATCH v2 00/22] Remove unnecessary curly brackets around one-line bodies

2014-11-14 Thread Martin Kletzander
On Thu, Nov 13, 2014 at 05:09:04PM -0700, Eric Blake wrote: On 11/13/2014 04:52 PM, John Ferlan wrote: On 11/13/2014 09:37 AM, Martin Kletzander wrote: Brackets were removed by the following script in the root directory of libvirt's repository: for i in $(git ls-files | grep '\.[ch]$'); do

[libvirt] [PATCH] drvbhyve: Automatically tear down guest domains on shutdown

2014-11-14 Thread Conrad Meyer
Reboot requires more sophistication and is left as a future work item -- but at least part of the plumbing is in place. --- Looking for feedback. I'm pretty unfamiliar with libvirt; maybe this isn't quite the right way to do this. Sorry. If you want me to rework it in some way, just let me know. I

Re: [libvirt] [PATCH v2 3/4] caps: introduce new qemu capability for vgamem_mb device property

2014-11-14 Thread Pavel Hrdina
On 11/14/2014 04:24 PM, Gerd Hoffmann wrote: On Fr, 2014-11-14 at 16:15 +0100, Pavel Hrdina wrote: On 11/14/2014 04:03 PM, Gerd Hoffmann wrote: On Fr, 2014-11-14 at 14:54 +0100, Pavel Hrdina wrote: +static struct virQEMUCapsStringFlags virQEMUCapsObjectPropsCirrusVga[] = { +{ "vgamem_mb",

Re: [libvirt] [PATCH v2 4/4] qemu-command: introduce new vgamem attribute for video devices

2014-11-14 Thread Gerd Hoffmann
On Fr, 2014-11-14 at 16:13 +0100, Pavel Hrdina wrote: > On 11/14/2014 04:06 PM, Gerd Hoffmann wrote: > > On Fr, 2014-11-14 at 14:54 +0100, Pavel Hrdina wrote: > >> +if (video->vram % 1024) { > >> +virReportError(VIR_ERR_CONFIG_UNSUPPORTED, > >> + "%s",

Re: [libvirt] [PATCH v2 3/4] caps: introduce new qemu capability for vgamem_mb device property

2014-11-14 Thread Gerd Hoffmann
On Fr, 2014-11-14 at 16:15 +0100, Pavel Hrdina wrote: > On 11/14/2014 04:03 PM, Gerd Hoffmann wrote: > > On Fr, 2014-11-14 at 14:54 +0100, Pavel Hrdina wrote: > >> +static struct virQEMUCapsStringFlags > >> virQEMUCapsObjectPropsCirrusVga[] = { > >> +{ "vgamem_mb", QEMU_CAPS_CIRRUS_VGA_VGAMEM }

Re: [libvirt] [PATCH v2 3/4] caps: introduce new qemu capability for vgamem_mb device property

2014-11-14 Thread Pavel Hrdina
On 11/14/2014 04:03 PM, Gerd Hoffmann wrote: On Fr, 2014-11-14 at 14:54 +0100, Pavel Hrdina wrote: +static struct virQEMUCapsStringFlags virQEMUCapsObjectPropsCirrusVga[] = { +{ "vgamem_mb", QEMU_CAPS_CIRRUS_VGA_VGAMEM }, +}; Please don't touch vgamem_mb on cirrus. The only reason we have

Re: [libvirt] [PATCH v2 4/4] qemu-command: introduce new vgamem attribute for video devices

2014-11-14 Thread Pavel Hrdina
On 11/14/2014 04:06 PM, Gerd Hoffmann wrote: On Fr, 2014-11-14 at 14:54 +0100, Pavel Hrdina wrote: +if (video->vram % 1024) { +virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + "%s", _("value for 'vram' must be multiple of 1024")); +goto error

Re: [libvirt] [PATCH v2 0/4] use the 'vram' attribute for QEMU video devices

2014-11-14 Thread Pavel Hrdina
On 11/14/2014 04:00 PM, Gerd Hoffmann wrote: Hi, The 'vgamem_mb' parameter for QXL sets the VGA framebuffer size, but the VGA mode in QXL is used only as fallback if the OS doesn't have any QXL drivers or before the drivers are loaded. The VGA framebuffer is part of the first ram for QXL and

Re: [libvirt] [PATCH v2 4/4] qemu-command: introduce new vgamem attribute for video devices

2014-11-14 Thread Gerd Hoffmann
On Fr, 2014-11-14 at 14:54 +0100, Pavel Hrdina wrote: > +if (video->vram % 1024) { > +virReportError(VIR_ERR_CONFIG_UNSUPPORTED, > + "%s", _("value for 'vram' must be multiple > of 1024")); > +goto error; > +} pci bar size must be a

Re: [libvirt] [PATCH v2 3/4] caps: introduce new qemu capability for vgamem_mb device property

2014-11-14 Thread Gerd Hoffmann
On Fr, 2014-11-14 at 14:54 +0100, Pavel Hrdina wrote: > +static struct virQEMUCapsStringFlags > virQEMUCapsObjectPropsCirrusVga[] = { > +{ "vgamem_mb", QEMU_CAPS_CIRRUS_VGA_VGAMEM }, > +}; Please don't touch vgamem_mb on cirrus. The only reason we have this property in the first place is live

Re: [libvirt] [PATCH v2 0/4] use the 'vram' attribute for QEMU video devices

2014-11-14 Thread Gerd Hoffmann
Hi, > The 'vgamem_mb' parameter for QXL sets the VGA framebuffer size, but the VGA > mode in QXL is used only as fallback if the OS doesn't have any QXL drivers > or before the drivers are loaded. The VGA framebuffer is part of the first ram > for QXL and for that we have 'ram' attribute. The re

[libvirt] [PATCH v2 0/4] use the 'vram' attribute for QEMU video devices

2014-11-14 Thread Pavel Hrdina
There are some changes from the first version. We will not have a new 'vgamem' attribute for video devices because we can use the 'vram' attribute. So far for QEMU the 'vram' is used only to set the secondary ram for QXL which seems to be correct as the secondary ram is used for pixmaps and surface

[libvirt] [PATCH v2 2/4] qxl: fix setting ram and vram values for qemu qxl device

2014-11-14 Thread Pavel Hrdina
QEMU has two different type of QXL display device. The first "qxl-vga" is for primary video device and second "qxl" is for secondary video device. There are also two different ways how to specify those devices on qemu command line, the first one and obsolete is using "-vga" option and the current

[libvirt] [PATCH v2 3/4] caps: introduce new qemu capability for vgamem_mb device property

2014-11-14 Thread Pavel Hrdina
Allow setting vgamem size for video devices. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1076098 Signed-off-by: Pavel Hrdina --- src/qemu/qemu_capabilities.c | 25 ++ src/qemu/qemu_capabilities.h | 3 + tests/qemucapabilitiesdata/caps_1.2

[libvirt] [PATCH v2 4/4] qemu-command: introduce new vgamem attribute for video devices

2014-11-14 Thread Pavel Hrdina
So far we hadn't any option to set video memory size for qemu video devices. There were only vram (ram for QXL) attribute but it was valid only for QXL video device. To provide this feature to users qemu has dedicated device attribute called 'vgamem_mb' to set the video memory size. We will use th

[libvirt] [PATCH v2 1/4] video: cleanup usage of vram attribute and update documentation

2014-11-14 Thread Pavel Hrdina
The vram attribute was introduced to set the video memory but it is usable only for few hypervisors excluding QEMU/KVM. QEMU/KVM has different attribute for this purpose "vgamem_mb" and it will be introduced lately. The correct usage of vram is to set the video memory for other hypervisors or to s

Re: [libvirt] [PATCH] Re-add use of locking with iptables/ip6tables/ebtables

2014-11-14 Thread Martin Kletzander
On Tue, Nov 11, 2014 at 12:42:46PM +, Daniel P. Berrange wrote: A previous commit introduced use of locking with invocation of iptables in the viriptables.c module commit ba95426d6f39aec1da6e069dd7222f7a8c6a5862 Author: Serge Hallyn Date: Fri Nov 1 12:36:59 2013 -0500 util: use -w

Re: [libvirt] [PATCH 2/2] qemu: Add tests for new blkdeviotune arguments

2014-11-14 Thread Ján Tomko
On 11/12/2014 04:16 PM, John Ferlan wrote: > The recent commit to add support for block_set_io_throttle parameters > from version 1.7 of qemu did not add any tests - this adds the tests > > Signed-off-by: John Ferlan > --- > .../qemuxml2argv-blkdeviotune-max.args | 12 + > .../qe

Re: [libvirt] [PATCH 0/2] Add missing check and test for new blkdeviotune parameters

2014-11-14 Thread Ján Tomko
On 11/12/2014 04:16 PM, John Ferlan wrote: > Found missing 'size_iops_sec' check in qemu_command.c. > > Add a test for the new blkdeviotune parameters. > > John Ferlan (2): > qemu: Add checks for blkdeviotune 'size_iops_sec' and adjust error > qemu: Add tests for new blkdeviotune arguments >