On Tue, 2014-11-25 at 08:05 +0100, Martin Kletzander wrote:
On Mon, Nov 24, 2014 at 09:54:43PM +0100, Cédric Bosdonnat wrote:
To get virt-sandbox-service working with AppArmor, virt-aa-helper
needs not to choke on path in /etc/libvirt-sandbox/services.
---
src/security/virt-aa-helper.c | 8
On Tue, 2014-11-25 at 08:42 +0100, Martin Kletzander wrote:
On Mon, Nov 24, 2014 at 09:54:44PM +0100, Cédric Bosdonnat wrote:
Due to a change (or bug?) in ip link implementation, the command
'ip link add vnet0...'
is forced into
'ip link add name vnet0...'
The changed command also
On Tue, 2014-11-25 at 08:48 +0100, Martin Kletzander wrote:
On Mon, Nov 24, 2014 at 09:54:46PM +0100, Cédric Bosdonnat wrote:
The typical case where we had a problem is with such a filesystem
definition as created by virt-sandbox-service:
filesystem type='bind' accessmode='passthrough'
On Tue, Nov 25, 2014 at 09:21:10AM +0100, Cedric Bosdonnat wrote:
On Tue, 2014-11-25 at 08:42 +0100, Martin Kletzander wrote:
On Mon, Nov 24, 2014 at 09:54:44PM +0100, Cédric Bosdonnat wrote:
Due to a change (or bug?) in ip link implementation, the command
'ip link add vnet0...'
is forced
On 11/25/14 06:21, Eric Blake wrote:
Commit 7557ddf added some additional block.* stats to
virDomainListGetStats, but failed to document them in 'man
virsh'. Also, I noticed some inconsistent use of commas.
* tools/virsh.pod (domstats): Tweak commas, add missing stats.
Signed-off-by:
On 11/24/2014 04:23 PM, John Ferlan wrote:
On 11/24/2014 12:48 PM, Laine Stump wrote:
+if (nlmsg_append(nl_msg, ndm, sizeof(ndm), NLMSG_ALIGNTO) 0)
+goto buffer_too_small;
+if (nla_put(nl_msg, NDA_LLADDR, VIR_MAC_BUFLEN, mac) 0)
+goto buffer_too_small;
So if
Hi All,
As I described the 27th of October in the following thread:
https://www.redhat.com/archives/libvir-list/2014-October/msg00840.html
[libvirt] [PATCH v2 0/21] hyperv: hyperv: set of new functionalities
new functionalities has been implemented in the libvirt hyperv driver as a set
of 21
On 11/25/14 06:21, Eric Blake wrote:
I noticed that for an offline domain, 'virsh domstats --block $dom'
was producing just the domain name, with no stats. But the older
'virsh domblkinfo' works just fine on offline domains. Furthermore,
I'm about to make block stats optionally more complex
On Tue, Nov 25, 2014 at 09:27:28AM +0100, Cedric Bosdonnat wrote:
On Tue, 2014-11-25 at 08:48 +0100, Martin Kletzander wrote:
On Mon, Nov 24, 2014 at 09:54:46PM +0100, Cédric Bosdonnat wrote:
The typical case where we had a problem is with such a filesystem
definition as created by
On Mon, 2014-11-24 at 09:21 -0700, Eric Blake wrote:
On 11/24/2014 02:43 AM, Ian Campbell wrote:
I think this change breaks build on FreeBSD:
CC util/libvirt_util_la-virdbus.lo
util/virdbus.c:956:13: error: cast from 'bool *' to 'dbus_bool_t *' (aka
'unsigned int *')
The function virNetworkObjListExport() in network_conf.c had a call to
the public API virNetworkFree() which was causing a link error:
CCLD libvirt_driver_vbox_network_impl.la
./.libs/libvirt_conf.a(libvirt_conf_la-network_conf.o): In function
`virNetworkObjListExport':
-Original Message-
From: Eric Blake [mailto:ebl...@redhat.com]
Sent: Tuesday, November 25, 2014 12:25 AM
To: Martin Kletzander; Chen, Hanxiao/陈 晗霄
Cc: libvir-list@redhat.com
Subject: Re: [libvirt] [PATCH RFC] storage: perform btrfs clone if possible
On 11/24/2014 12:09 AM,
Pushed them all with changes to patch #2 as requested by Martin.
Thanks Martin for your review.
--
Cedric
On Mon, 2014-11-24 at 21:54 +0100, Cédric Bosdonnat wrote:
Hi all,
this patch series fixes a few problems I encountered when getting
virt-sandbox-service
containers with images to
Hey,
On Fri, Nov 21, 2014 at 03:11:36PM +, Zeeshan Ali (Khattak) wrote:
Add binding for virDomainOpenGraphicsFD. If virDomainOpenGraphicsFD is
not available, it means we are dealing with older libvirt so we create
the socket pair ourselves if that is the case.
---
configure.ac
See http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/2942/
--
Started by upstream project libvirt-build build number 3319
Building on master in workspace
http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/ws/
[workspace] $ /bin/sh -xe
This series adds fixes for nwfilter testcases.
Patch 1/2 : Flips result reporting for tests/nwfilterebiptablestest.c in line
with other tests.
Patch 2/2 : Makes nwfilter testcases more resilient to the presence of locking
flags, introduced by Commit dc33e6e4a5a5d42
Prerna Saxena (2):
tests :
Commit dc33e6e4a5a5d42 introduces iptables/ebtables to adding locking
flags if/when these are available. However, the nwfilter testcases
list outputs without taking into account whether locking flags have been passed.
This shows up false testcase failures such as :
2) ebiptablesTearOldRules
Tests run with 'make check' generally report their results as :
Expected:
...
Actual:
...
'nwfilterebiptablestest' reports its outcome in opposite sequence, which
is confusing for an end-user.
This changes 'nwfilterebpitablestest' to report results in a consistent
fashion.
Signed-off-by:
Commit 6fcddfcd refactored job statistics but missed the jobinfo type updated
in qemuDomainGetJobInfo. After this patch, we can use virDomainGetJobInfo to
get jobinfo type again.
Signed-off-by: Wang Rui moon.wang...@huawei.com
---
src/qemu/qemu_domain.c | 1 +
1 file changed, 1 insertion(+)
18.11.2014 16:16, Dmitry Guryanov пишет:
From: Alexander Burluka aburl...@parallels.com
Obtain information about domains using parallels sdk
instead of prlctl. prlsdkLoadDomains functions behaves
as former parallelsLoadDomains with NULL as second
parameter (name) - it fills
Commit 'c264eeaa' didn't do the prerequisite 'make syntax-check' before
pushing. There was a tab in the whitespace for the comment. Replaced
with spaces and aligned.
pushed as build breaker since Jenkins complained loudly
Signed-off-by: John Ferlan jfer...@redhat.com
---
On Tue, Nov 25, 2014 at 05:10:04PM +0530, Prerna Saxena wrote:
Tests run with 'make check' generally report their results as :
Expected:
...
Actual:
...
'nwfilterebiptablestest' reports its outcome in opposite sequence, which
is confusing for an end-user.
This changes 'nwfilterebpitablestest'
On Tue, Nov 25, 2014 at 05:12:48PM +0530, Prerna Saxena wrote:
Commit dc33e6e4a5a5d42 introduces iptables/ebtables to adding locking
flags if/when these are available. However, the nwfilter testcases
list outputs without taking into account whether locking flags have been passed.
This shows up
On 25.11.2014 11:15, Laine Stump wrote:
The function virNetworkObjListExport() in network_conf.c had a call to
the public API virNetworkFree() which was causing a link error:
CCLD libvirt_driver_vbox_network_impl.la
./.libs/libvirt_conf.a(libvirt_conf_la-network_conf.o): In function
See http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/2943/
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
18.11.2014 16:16, Dmitry Guryanov пишет:
From: Alexander Burluka aburl...@parallels.com
Subscribe to events from parallels server. It's
needed for 2 things: to update cached domains list
and to send corresponding libvirt events.
Parallels server sends a lot of different events, in
this patch
18.11.2014 16:17, Dmitry Guryanov пишет:
From: Alexander Burluka aburl...@parallels.com
That function is necessary for proper domain removal
in openstack/nova.
Signed-off-by: Dmitry Guryanov dgurya...@parallels.com
---
src/parallels/parallels_driver.c | 19 +++
1 file
18.11.2014 16:17, Dmitry Guryanov пишет:
This patch replaces code, which creates domains by
running prlctl command.
prlsdkCreateVm/Ct will do prlsdkApplyConfig, because
we send request to the server only once in this case.
But prlsdkApplyConfig will be called also from
parallelsDomainDefineXML
18.11.2014 16:17, Dmitry Guryanov пишет:
First, we don't need to call prlsdkApplyConfig after
creating new VM or containers, because it's done in
functions prlsdkCreateVm and prlsdkCreateCt.
No need to check, if domain exists in the list after
prlsdkAddDomain.
Also organize code, so that we
18.11.2014 16:17, Dmitry Guryanov пишет:
From: Alexander Burluka aburl...@parallels.com
domainCreateWithFlags function is used by OpenStack/Nova to boot
an instance.
Signed-off-by: Dmitry Guryanov dgurya...@parallels.com
---
src/parallels/parallels_driver.c | 10 ++
1 file changed,
18.11.2014 16:17, Dmitry Guryanov пишет:
Get cdrom devices list from parallels server in
prlsdkLoadDomains and add ability to define a domain
with cdroms.
Signed-off-by: Dmitry Guryanov dgurya...@parallels.com
---
src/parallels/parallels_sdk.c | 70 ++-
18.11.2014 16:17, Dmitry Guryanov пишет:
Signed-off-by: Dmitry Guryanov dgurya...@parallels.com
---
src/parallels/parallels_driver.c | 26 ++
src/parallels/parallels_sdk.c| 18 ++
src/parallels/parallels_sdk.h| 2 ++
3 files changed, 46
18.11.2014 16:17, Dmitry Guryanov пишет:
Change domain state using parallels SDK functions instead of
prlctl command.
We don't need to send events from these functions now, becase
events handler will send them. But we still need to update
virDomainObj in privconn-domains.
Signed-off-by: Dmitry
2014-11-25 0:31 GMT+03:00 Vasiliy Tolstov v.tols...@selfip.ru:
If use not specify script in network type ethernet, assume that user
needs simple tap device created with libvirt.
This patch does not need to run external script to create tap device.
Signed-off-by: Vasiliy Tolstov
18.11.2014 16:17, Dmitry Guryanov пишет:
Rewrite code, which applies domain configuration given
to virDomainDefineXML function to the VM of container
registered in PCS.
This code first check if there are unsupported parameters
in domain XML and if yes - reports error. Some of such
parameters
Hi all,
Here are 2 patches: one to get apparmor support for virt-sandbox and
virt-sandbox-service
and 1 to get services with disk image actually start.
The AppArmor support doesn't add any parameter to the user, virt-sandbox, just
uses either
apparmor or selinux depending on the one
On Tue, Nov 25, 2014 at 19:51:45 +0800, Wang Rui wrote:
Commit 6fcddfcd refactored job statistics but missed the jobinfo type updated
in qemuDomainGetJobInfo. After this patch, we can use virDomainGetJobInfo to
get jobinfo type again.
Signed-off-by: Wang Rui moon.wang...@huawei.com
---
On 11/24/2014 06:22 PM, John Ferlan wrote:
On 11/24/2014 12:48 PM, Laine Stump wrote:
When the bridge device for a network has promiscLinks='no', the intent
is to setup the bridge to opportunistically turn off promiscuous mode
and/or flood mode for as many ports/links on the bridge as
On 11/24/2014 06:41 PM, John Ferlan wrote:
On 11/24/2014 12:48 PM, Laine Stump wrote:
In order for the kernel to be able to promiscuous mode on as many
ports of a bridge as possible, at most one attached device can have
learning and unicast_flood enabled (in practice, this one device is
When creating a sandbox with an image file, the /var folder contains
the mounted image. If we mount it before other file systems, how
could we possibly mount them? The new /var won't contain the mounted
image.
---
bin/virt-sandbox-service | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
Implement construction of apparmor security labels. The choice between
selinux and apparmor model isn't exposed to the user, but guessed
depending on what the host supports.
---
bin/virt-sandbox-service | 15 ---
libvirt-sandbox/libvirt-sandbox-builder.c | 32
On 11/11/2014 01:42 PM, Daniel P. Berrange wrote:
A previous commit introduced use of locking with invocation
of iptables in the viriptables.c module
commit ba95426d6f39aec1da6e069dd7222f7a8c6a5862
Author: Serge Hallyn serge.hal...@ubuntu.com
Date: Fri Nov 1 12:36:59 2013 -0500
On 11/25/2014 03:20 PM, Boris Fiuczynski wrote:
On 11/11/2014 01:42 PM, Daniel P. Berrange wrote:
A previous commit introduced use of locking with invocation
of iptables in the viriptables.c module
commit ba95426d6f39aec1da6e069dd7222f7a8c6a5862
Author: Serge Hallyn
On Tue, Nov 25, 2014 at 9:21 AM, Cedric Bosdonnat cbosdon...@suse.com wrote:
On Tue, 2014-11-25 at 08:42 +0100, Martin Kletzander wrote:
On Mon, Nov 24, 2014 at 09:54:44PM +0100, Cédric Bosdonnat wrote:
Due to a change (or bug?) in ip link implementation, the command
'ip link add vnet0...'
On 11/25/2014 02:10 AM, Peter Krempa wrote:
On 11/25/14 06:21, Eric Blake wrote:
I noticed that for an offline domain, 'virsh domstats --block $dom'
was producing just the domain name, with no stats. But the older
'virsh domblkinfo' works just fine on offline domains. Furthermore,
I'm about
On 11/25/14 16:43, Eric Blake wrote:
On 11/25/2014 02:10 AM, Peter Krempa wrote:
On 11/25/14 06:21, Eric Blake wrote:
I noticed that for an offline domain, 'virsh domstats --block $dom'
was producing just the domain name, with no stats. But the older
'virsh domblkinfo' works just fine on
On 11/21/2014 05:12 PM, Eric Blake wrote:
Commit 2aa167ca tried to fix the DBus interaction code to allow
callers to use native types instead of 4-byte bools. But in
fixing the issue, I missed the case of an arrayref; Conrad Meyer
shows the following valid complaint issued by clang:
*
On 11/24/2014 08:42 AM, Peter Krempa wrote:
Also add the example.
---
examples/event-test.py | 13 +++
libvirt-override.c | 60
++
2 files changed, 73 insertions(+)
mode change 100644 = 100755 examples/event-test.py
+++
On 11/25/2014 03:19 AM, Chen, Hanxiao wrote:
I think it makes sense to expose this functionality; although I suspect
it is better if we do so by having the user pass an explicit new flag
value to existing API instead of doing it automatically.
Thanks for your clarification.
But we've
On 11/25/2014 01:59 AM, Peter Krempa wrote:
On 11/25/14 06:21, Eric Blake wrote:
Commit 7557ddf added some additional block.* stats to
virDomainListGetStats, but failed to document them in 'man
virsh'. Also, I noticed some inconsistent use of commas.
* tools/virsh.pod (domstats): Tweak
On 11/17/2014 03:31 PM, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1164627
When try to use attach-device to hotplug a qemu
unsupport sonsole, command will return success,
and add a console in vm's xml.But this doesn't work
in qemu, qemu doesn't support these console.Add
a
This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=907779
A dhcp element can exist in only one IPv4 address and one IPv6
address per network. This patch enforces that in virNetworkUpdate.
---
src/conf/network_conf.c | 31 +++
1 file changed, 31 insertions(+)
Repost of a patch that got lost in the shuffle. The last version
(v3) was based on review comments from Martin Kletzander but needs
additional review.
Here's a link back to the v2 post, which was the last to receive
comments:
Currently, MAC registration occurs during device creation, which is
early enough that, during live migration, you end up with duplicate
MAC addresses on still-running source and target devices, even though
the target device isn't actually being used yet.
This patch proposes to defer MAC
Eric,
On Thu, Aug 21, 2014 at 4:09 PM, Eric W. Biederman
ebied...@xmission.com wrote:
Richard Weinberger rich...@nod.at writes:
Am 21.08.2014 15:12, schrieb Christoph Hellwig:
On Wed, Aug 20, 2014 at 09:53:49PM -0700, Eric W. Biederman wrote:
Richard Weinberger richard.weinber...@gmail.com
[just replying on libvir-list]
Am 26. Nov 2014, 00:15 schrieb Richard Weinberger
richard.weinber...@gmail.com:
I plan to send the pull request to Linus as soon as I have caught my
breath (from all of the conferences this week) that I can be certain I
am thinking clearly and not rushing
On Tue, Nov 25, 2014 at 02:29:26PM +0100, Cédric Bosdonnat wrote:
When creating a sandbox with an image file, the /var folder contains
the mounted image. If we mount it before other file systems, how
could we possibly mount them? The new /var won't contain the mounted
image.
---
On Tue, Nov 25, 2014 at 02:29:25PM +0100, Cédric Bosdonnat wrote:
Implement construction of apparmor security labels. The choice between
selinux and apparmor model isn't exposed to the user, but guessed
depending on what the host supports.
---
bin/virt-sandbox-service | 15
On Tue, Nov 25, 2014 at 04:19:48PM +0100, Richard Weinberger wrote:
On Tue, Nov 25, 2014 at 9:21 AM, Cedric Bosdonnat cbosdon...@suse.com wrote:
On Tue, 2014-11-25 at 08:42 +0100, Martin Kletzander wrote:
On Mon, Nov 24, 2014 at 09:54:44PM +0100, Cédric Bosdonnat wrote:
Due to a change (or
We already did this in virSecretDefFree.
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com
---
src/storage/storage_backend.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c
index 98720f6..440f8b1 100644
---
60 matches
Mail list logo