Re: [libvirt] [PATCH] Update LIBVIRT_CHECK_LIB and LIBVIRT_CHECK_LIB_ALT to use pkg-config

2014-12-04 Thread Pavel Hrdina
On 12/04/2014 11:59 PM, Eric Blake wrote: On 12/04/2014 03:36 PM, Pavel Hrdina wrote: On 12/04/2014 09:41 PM, Eric Blake wrote: On 12/04/2014 01:30 PM, Pavel Hrdina wrote: For example on FreeBSD the "yajl" library is located at "/usr/local/lib" and it's not in default LIBS and therefore the co

Re: [libvirt] [PATCHv2 2/2] security: Add a new func use stat to get process DAC label

2014-12-04 Thread lhuang
On 12/05/2014 12:58 AM, Ján Tomko wrote: On 12/03/2014 11:08 AM, Luyao Huang wrote: When use qemuProcessAttach to attach a qemu process, cannot get a right DAC label. Add a new func to get process label via stat func. Do not remove virDomainDefGetSecurityLabelDef before try to use stat to get p

Re: [libvirt] [PATCH] Update LIBVIRT_CHECK_LIB and LIBVIRT_CHECK_LIB_ALT to use pkg-config

2014-12-04 Thread Eric Blake
On 12/04/2014 03:36 PM, Pavel Hrdina wrote: > On 12/04/2014 09:41 PM, Eric Blake wrote: >> On 12/04/2014 01:30 PM, Pavel Hrdina wrote: >>> For example on FreeBSD the "yajl" library is located at "/usr/local/lib" >>> and it's not in default LIBS and therefore the configure fails that >>> "yajl" not

Re: [libvirt] [PATCH] Update LIBVIRT_CHECK_LIB and LIBVIRT_CHECK_LIB_ALT to use pkg-config

2014-12-04 Thread Pavel Hrdina
On 12/04/2014 09:41 PM, Eric Blake wrote: On 12/04/2014 01:30 PM, Pavel Hrdina wrote: For example on FreeBSD the "yajl" library is located at "/usr/local/lib" and it's not in default LIBS and therefore the configure fails that "yajl" not installed. We can use the "PKG_CHECK_MODULES" to get the

[libvirt] [RESEND PATCH] network: don't allow multiple dhcp sections

2014-12-04 Thread Kyle DeFrancia
This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=907779 A element can exist in only one IPv4 address and one IPv6 address per network. This patch enforces that in virNetworkUpdate. --- Rebased to latest master, hopefully this works better. My original message: https://www.redhat.com/ar

Re: [libvirt] [PATCH] Update LIBVIRT_CHECK_LIB and LIBVIRT_CHECK_LIB_ALT to use pkg-config

2014-12-04 Thread Eric Blake
On 12/04/2014 01:30 PM, Pavel Hrdina wrote: > For example on FreeBSD the "yajl" library is located at "/usr/local/lib" > and it's not in default LIBS and therefore the configure fails that > "yajl" not installed. > > We can use the "PKG_CHECK_MODULES" to get the correct library path in > case the

Re: [libvirt] [PATCH] storage: backend: Log uid/gid when initializing storage file backend

2014-12-04 Thread Eric Blake
On 12/04/2014 12:24 PM, Peter Krempa wrote: > To ease debugging permission problems add uid/gid values to the debug > message when initializing a storage file backend. > --- > src/storage/storage_backend_fs.c | 4 ++-- > src/storage/storage_backend_gluster.c | 4 ++-- > 2 files changed, 4 ins

[libvirt] [PATCH] Update LIBVIRT_CHECK_LIB and LIBVIRT_CHECK_LIB_ALT to use pkg-config

2014-12-04 Thread Pavel Hrdina
For example on FreeBSD the "yajl" library is located at "/usr/local/lib" and it's not in default LIBS and therefore the configure fails that "yajl" not installed. We can use the "PKG_CHECK_MODULES" to get the correct library path in case the library provides pkg-config file definition, otherwise t

Re: [libvirt] [PATCH] networkValidate: Disallow bandwidth in portgroups too

2014-12-04 Thread John Ferlan
On 12/03/2014 12:24 PM, Michal Privoznik wrote: > In one of the previous commits (eafb53fe) we disallowed > network-wide bandwidth to some network types. However, we > forgot about which can have too. > > Signed-off-by: Michal Privoznik > --- > src/network/bridge_driver.c | 11 +++ >

[libvirt] [PATCH] storage: backend: Log uid/gid when initializing storage file backend

2014-12-04 Thread Peter Krempa
To ease debugging permission problems add uid/gid values to the debug message when initializing a storage file backend. --- src/storage/storage_backend_fs.c | 4 ++-- src/storage/storage_backend_gluster.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/storage/sto

Re: [libvirt] question about MigrateSetMaxDowntime

2014-12-04 Thread Peter Krempa
On 12/04/14 17:53, Jim Fehlig wrote: > A user asked me about setting max downtime prior to migration, which I > thought could be done similar to MigrateSetMaxSpeed. I was surprised to > find that it can only be set when migration is in progress > > # virsh migrate-setmaxdowntime test 1000 > error

[libvirt] [RFC] The Quest for Domain-IP Mapping Continues...

2014-12-04 Thread Nehal J Wani
If you remember correctly, about 1.2 years ago, we had... https://www.redhat.com/archives/libvir-list/2013-September/msg00351.html In short, the patch proposed a generalized mechanism for finding out IP addresses, with flags for choosing method(s) (SNOOP|LEASE|AGENT). But since not all methods we

Re: [libvirt] [PATCH 00/11] Post-Copy Live Migration Support

2014-12-04 Thread Laine Stump
On 12/04/2014 05:09 AM, Cristian KLEIN wrote: > On 2014-12-04 10:40, Laine Stump wrote: >> Currently, libvirt does create and activate simultaneously (and also >> qemu does a gratuitous ARP request at some point, although I haven't >> checked if it happens when qemu starts or when the guest CPUs ar

Re: [libvirt] [PATCHv2 2/2] security: Add a new func use stat to get process DAC label

2014-12-04 Thread Ján Tomko
On 12/03/2014 11:08 AM, Luyao Huang wrote: > When use qemuProcessAttach to attach a qemu process, cannot > get a right DAC label. Add a new func to get process label > via stat func. Do not remove virDomainDefGetSecurityLabelDef > before try to use stat to get process DAC label, because > There are

[libvirt] question about MigrateSetMaxDowntime

2014-12-04 Thread Jim Fehlig
A user asked me about setting max downtime prior to migration, which I thought could be done similar to MigrateSetMaxSpeed. I was surprised to find that it can only be set when migration is in progress # virsh migrate-setmaxdowntime test 1000 error: Requested operation is not valid: domain is

Re: [libvirt] [PATCH] Report original error when QMP probing fails with new QEMU

2014-12-04 Thread Jiri Denemark
On Thu, Dec 04, 2014 at 15:33:38 +, Daniel Berrange wrote: > If probing capabilities via QMP fails, we now have a check > that prevents us falling back to -help parsing. Unfortunately > the error message > > "Failed to probe capabilities for /usr/bin/qemu-kvm: >unsupported configuration:

[libvirt] [PATCH] docs: storage: fix rbd pool indentation

2014-12-04 Thread Cole Robinson
--- Pushed as trivial docs/storage.html.in | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/storage.html.in b/docs/storage.html.in index 9933548..f920dae 100644 --- a/docs/storage.html.in +++ b/docs/storage.html.in @@ -551,12 +551,12 @@ myrbdpo

[libvirt] [PATCH] Report original error when QMP probing fails with new QEMU

2014-12-04 Thread Daniel P. Berrange
If probing capabilities via QMP fails, we now have a check that prevents us falling back to -help parsing. Unfortunately the error message "Failed to probe capabilities for /usr/bin/qemu-kvm: unsupported configuration: QEMU 2.1.2 is too new for help parsing" is proving rather unhelpful to th

[libvirt] [PATCH] qemu: process: Avoid uninitialized use two vars when reconnecting to vm

2014-12-04 Thread Peter Krempa
3ecebf07110ca8d3413072557f29137943e848e3 breaks the build as it adds a way to jump to cleanup before the 'cfg' object is retrieved and 'priv' is initialized. --- Notes: Pushed under the build-breaker rule. src/qemu/qemu_process.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) d

Re: [libvirt] [PATCHv2] qemu: process: Refactor reconnecting to qemu processes

2014-12-04 Thread Peter Krempa
On 12/04/14 15:19, Martin Kletzander wrote: > On Thu, Dec 04, 2014 at 02:40:46PM +0100, Peter Krempa wrote: >> Move entering the job into the thread to simplify the program flow. Also >> as the code holds a separate reference to the domain object some >> conditions can be simplified. >> --- >> >> N

[libvirt] [PATCH 0/4] Add auth and adapter to virsh pool-{create|define}-as

2014-12-04 Thread John Ferlan
Recently while reviewing some documentation for iSCSI authentication description I found that virsh pool-{create|define}-as did not provide a mechanism to add the and/or options on the command line - so I figured adding them would be simple. In the course of doing this I also noted a few typos on

[libvirt] [PATCH 4/4] virsh: Add adapter options for pool-{create|define}-as

2014-12-04 Thread John Ferlan
Add the optional adapter options for pool create/define. Results in either: or (on one line) being generated. Signed-off-by: John Ferlan --- tools/virsh-pool.c | 35 +-- tools/virsh.pod| 13 + 2 files changed, 46 insertions(+), 2 deletions(-

[libvirt] [PATCH 2/4] virsh.pod: Fix the pool-define-as and pool-create-as description

2014-12-04 Thread John Ferlan
Properly format the options and provide meaningful descriptions for the various options. Signed-off-by: John Ferlan --- tools/virsh.pod | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 7cde3fd..1b31597

[libvirt] [PATCH 3/4] virsh: Add auth options for pool-{create|define}-as

2014-12-04 Thread John Ferlan
Add 3 new optional options for the pool-create-as and pool-define-as command in order to define the 3 elements required in order to add an auth element, such as: Signed-off-by: John Ferlan --- tools/virsh-pool.c | 28 ++-- tools/virsh.pod| 7 +++ 2 files ch

[libvirt] [PATCH 1/4] docs: Fix a couple of typos on the storage pool html

2014-12-04 Thread John Ferlan
Fix format of the secret XML in the example. The XML had an extraneousof "type='iscsi'" (which is used by the definitions) The world wide node name had a typo in the acronym (wwwn). Signed-off-by: John Ferlan --- docs/formatstorage.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [libvirt] [PATCH] spec: Remove qemu-img dependency from storage driver

2014-12-04 Thread Daniel P. Berrange
On Thu, Dec 04, 2014 at 02:42:31PM +0100, Jiri Denemark wrote: > On Wed, Dec 03, 2014 at 15:58:45 +, Daniel Berrange wrote: > > On Wed, Dec 03, 2014 at 04:52:25PM +0100, Jiri Denemark wrote: > > > Both qemu-img and its stripped down version qcow-create are searched for > > > dynamically with vi

Re: [libvirt] [PATCHv2] qemu: process: Refactor reconnecting to qemu processes

2014-12-04 Thread Martin Kletzander
On Thu, Dec 04, 2014 at 02:40:46PM +0100, Peter Krempa wrote: Move entering the job into the thread to simplify the program flow. Also as the code holds a separate reference to the domain object some conditions can be simplified. --- Notes: Version 2: - fix leak of 'data' when not reconnec

Re: [libvirt] [PATCH] drvbhyve: Automatically tear down guest domains on shutdown

2014-12-04 Thread Conrad Meyer
On Thu, Dec 4, 2014 at 5:18 AM, Michal Privoznik wrote: > On 14.11.2014 17:03, Conrad Meyer wrote: >> >> +status = kev.data; >> +if (WIFSIGNALED(status) && WCOREDUMP(status)) { >> +VIR_ERROR("Guest %s got signal %d and crashed", >> mon->vm->def->name, >> +

Re: [libvirt] [PATCH] spec: Remove qemu-img dependency from storage driver

2014-12-04 Thread Jiri Denemark
On Wed, Dec 03, 2014 at 15:58:45 +, Daniel Berrange wrote: > On Wed, Dec 03, 2014 at 04:52:25PM +0100, Jiri Denemark wrote: > > Both qemu-img and its stripped down version qcow-create are searched for > > dynamically with virFindFileInPath, functions using them report errors > > when the requir

[libvirt] [PATCHv2] qemu: process: Refactor reconnecting to qemu processes

2014-12-04 Thread Peter Krempa
Move entering the job into the thread to simplify the program flow. Also as the code holds a separate reference to the domain object some conditions can be simplified. --- Notes: Version 2: - fix leak of 'data' when not reconnecting src/qemu/qemu_process.c | 161 ++---

[libvirt] [PATCH] util: check for an illegal character in a XML namespace prefix

2014-12-04 Thread Erik Skultety
When user tries to insert element metadata providing a namespace declaration as well, currently we insert the element without any validation check for XML prefix (if provided). The next VM start would then fail with parse error. This patch fixes this issue by adding a call to xmlValidateNCName func

Re: [libvirt] [PATCH 3/3] qemu: make persistent update of graphics device supported

2014-12-04 Thread Ján Tomko
On 11/19/2014 05:50 AM, Wang Rui wrote: > We can change vnc password by using virDomainUpdateDeviceFlags API with > live flag. But it can't be changed with config flag. Error is reported as > below. > > error: Operation not supported: persistent update of device 'graphics' is not > supported > >

Re: [libvirt] [PATCH 1/3] qemu: report properer error number when change graphics failed

2014-12-04 Thread Ján Tomko
On 11/19/2014 05:50 AM, Wang Rui wrote: > Signed-off-by: Wang Rui > --- > src/qemu/qemu_hotplug.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c > index b9a0cee..1c75861 100644 > --- a/src/qemu/qemu_hotplug.c

Re: [libvirt] [PATCHv2 0/9] Let libvirt manage a bridge's FDB

2014-12-04 Thread Laine Stump
On 12/04/2014 04:56 AM, Daniel P. Berrange wrote: > On Thu, Dec 04, 2014 at 03:56:53AM -0500, Laine Stump wrote: >> Maybe the problem is that you're providing a good name based entirely on >> the differences in behavior the guests can see, but what I'm looking for >> is a way to control how that be

Re: [libvirt] [PATCH 0/2] Manage SELinux labels on shared/readonly hostdev's

2014-12-04 Thread John Ferlan
ping... Tks, John On 11/26/2014 01:11 PM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1082521 > > Patch 1 is innocuous and perhaps could have been pushed as trivial... > > For Patch 2 I wasn't sure if I should use the virSecuritySELinuxSetFilecon > or virSecuritySELinuxSe

Re: [libvirt] [PATCH] Fix handling of whitespae in preprocessor macros for API generator

2014-12-04 Thread Michal Privoznik
On 04.12.2014 13:08, Daniel P. Berrange wrote: The apibuild.py script did not handle whitespace in preprocessor macros, so it failed to detect constants declared with '# define' instead of '#define'. Since we now correctly indent our public header files, we have silently lost all constants from l

[libvirt] [PATCH] Fix handling of whitespae in preprocessor macros for API generator

2014-12-04 Thread Daniel P. Berrange
The apibuild.py script did not handle whitespace in preprocessor macros, so it failed to detect constants declared with '# define' instead of '#define'. Since we now correctly indent our public header files, we have silently lost all constants from libvirt-api.xml. This also caused us to not detect

Re: [libvirt] [PATCH v2] automatic create tap device with network type ethernet

2014-12-04 Thread Vasiliy Tolstov
2014-11-28 16:40 GMT+03:00 Vasiliy Tolstov : > If user not specify script in network type ethernet, assume that user > needs simple tap device created with libvirt. > This patch does not need to run external script to create tap device or > add root to qemu process. Any news. But may be this patc

Re: [libvirt] [PATCH] docs: Create html documentation even if XHTML1 DTD is not available to validate

2014-12-04 Thread Michal Privoznik
On 28.11.2014 15:36, Ian Campbell wrote: On a Debian system lacking the w3c-dtd-xhtml package the build fails with: $ make -C docs/ formatcaps.html make: Entering directory '/local/scratch/ianc/devel/libvirt.git/docs' Generating formatcaps.html.tmp I/O error :

Re: [libvirt] [PATCH] drvbhyve: Automatically tear down guest domains on shutdown

2014-12-04 Thread Michal Privoznik
On 14.11.2014 17:03, Conrad Meyer wrote: > Reboot requires more sophistication and is left as a future work item -- > but at least part of the plumbing is in place. > --- > Looking for feedback. I'm pretty unfamiliar with libvirt; maybe this isn't > quite the right way to do this. Sorry. If you wan

Re: [libvirt] [PATCH 00/11] Post-Copy Live Migration Support

2014-12-04 Thread Cristian KLEIN
On 2014-12-04 10:40, Laine Stump wrote: On 12/01/2014 10:59 AM, Cristian Klein wrote: Qemu currently implements pre-copy live migration. VM memory pages are first copied from the source hypervisor to the destination, potentially multiple times as pages get dirtied during transfer, then VCPU stat

Re: [libvirt] [libvirt-perl][PATCH] Fix constants for VIR_DOMAIN_GET_ALL_STATS_*

2014-12-04 Thread Daniel P. Berrange
On Thu, Dec 04, 2014 at 01:16:32PM +0800, Zhe Peng wrote: > Constants of GET_ALL_STATS_* incorrect,this patch fix them in Domain.pm > --- > lib/Sys/Virt/Domain.pm | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) ACK Regards, Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCHv2 0/9] Let libvirt manage a bridge's FDB

2014-12-04 Thread Daniel P. Berrange
On Thu, Dec 04, 2014 at 03:56:53AM -0500, Laine Stump wrote: > On 12/03/2014 12:02 PM, Daniel P. Berrange wrote: > > On Tue, Dec 02, 2014 at 12:08:30PM -0500, Laine Stump wrote: > >> (Everyone - see the request for opinions/ideas towards the bottom) > >> > >> The idea behind these patches is the fo

Re: [libvirt] [PATCH 00/11] Post-Copy Live Migration Support

2014-12-04 Thread Laine Stump
On 12/01/2014 10:59 AM, Cristian Klein wrote: > Qemu currently implements pre-copy live migration. VM memory pages are > first copied from the source hypervisor to the destination, potentially > multiple times as pages get dirtied during transfer, then VCPU state > is migrated. Unfortunately, if th

Re: [libvirt] [PATCH] network: don't allow multiple dhcp sections

2014-12-04 Thread Michal Privoznik
On 25.11.2014 18:09, Kyle DeFrancia wrote: This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=907779 A element can exist in only one IPv4 address and one IPv6 address per network. This patch enforces that in virNetworkUpdate. --- src/conf/network_conf.c | 31 +

Re: [libvirt] [PATCHv2 0/9] Let libvirt manage a bridge's FDB

2014-12-04 Thread Laine Stump
On 12/03/2014 12:02 PM, Daniel P. Berrange wrote: > On Tue, Dec 02, 2014 at 12:08:30PM -0500, Laine Stump wrote: >> (Everyone - see the request for opinions/ideas towards the bottom) >> >> The idea behind these patches is the following: >> >> 1) most virtual machines only have a single MAC address

Re: [libvirt] [PATCH] qemu: Fix virsh freeze when blockcopy storage file is removed

2014-12-04 Thread Michal Privoznik
On 03.12.2014 17:39, Eric Blake wrote: On 12/03/2014 05:56 AM, Erik Skultety wrote: If someone removes blockcopy storage file when still in mirroring phase That's fishy behavior on the part of the user. But since the patch is simple enough, it's still worth protecting ourselves from stupid us

Re: [libvirt] [PATCH] cpu-driver: Fix the cross driver function call

2014-12-04 Thread Daniel Hansel
Hi John, thank you for your comment. As you mentioned this problem is solved (and now pushed) by Pavel. Thanks Pavel for fixing this issue. Kind regards, Daniel On 03.12.2014 15:29, John Ferlan wrote: > > > On 11/20/2014 05:08 AM, Daniel Hansel wrote: >> For Intel and PowerPC the implementati