[libvirt] [PATCH] Fix shadowed variable warning

2015-01-27 Thread Ján Tomko
libvirtd.c: In function 'daemonSetupAccessManager': libvirtd.c:730:18: error: declaration of 'driver' shadows a global declaration [-Werror=shadow] const char **driver = (const char **)config-access_drivers; ^ In file included from libvirtd.c:95:0:

[libvirt] [PATCH v2] conf: Disallow emulatorpin when numatune's in effect

2015-01-27 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1170492 In one of our previous commits (dc8b7ce7) we've done a functional change even though it was intended as pure refactor. The problem is, that the following XML: vcpu placement='static' current='2'6/vcpu cputune emulatorpin cpuset='1-3'/

Re: [libvirt] [PATCH v2] conf: Disallow emulatorpin when numatune's in effect

2015-01-27 Thread Daniel P. Berrange
On Tue, Jan 27, 2015 at 02:25:35PM +0100, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1170492 In one of our previous commits (dc8b7ce7) we've done a functional change even though it was intended as pure refactor. The problem is, that the following XML: vcpu

[libvirt] [PATCH 0/2] Really fix the crash on qemu crash in chardev hotplug

2015-01-27 Thread Ján Tomko
Ján Tomko (2): Always free the device in AttachChrDevice Unify cleanup path in AttachChrDevice src/qemu/qemu_driver.c | 3 +-- src/qemu/qemu_hotplug.c | 40 +--- tests/qemuhotplugtest.c | 1 + 3 files changed, 23 insertions(+), 21 deletions(-) --

[libvirt] [PATCH 2/2] Unify cleanup path in AttachChrDevice

2015-01-27 Thread Ján Tomko
Add a 'crashed' label to reuse the cleanup path on domain crash. --- src/qemu/qemu_hotplug.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index f4eca30..f5490e2 100644 ---

[libvirt] [PATCH 1/2] Always free the device in AttachChrDevice

2015-01-27 Thread Ján Tomko
Do not free it in the caller (qemuDomainAttachDeviceFlags), because it has no way of knowing if it hasn't been cleaned up by qemuProcessStop on monitor EOF. https://bugzilla.redhat.com/show_bug.cgi?id=1161024 --- src/qemu/qemu_driver.c | 3 +-- src/qemu/qemu_hotplug.c | 14 ++

[libvirt] [PATCH] Post-release version bump for new dev cycle

2015-01-27 Thread Peter Krempa
--- Pushed as trivial. configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index f370475..ddbdba5 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public dnl

Re: [libvirt] [PATCH 0/7] qemu: Job handling fixes

2015-01-27 Thread Peter Krempa
On Thu, Jan 22, 2015 at 15:23:03 +0100, Ján Tomko wrote: On 01/22/2015 10:20 AM, Peter Krempa wrote: While reviewing Martin's reference counting series I've noticed a few qemu API impls that don't properly handle jobs. Peter Krempa (7): qemu: Fix job handling in

[libvirt] Release of libvirt-1.2.12

2015-01-27 Thread Daniel Veillard
As planned I pushed the libvirt-1.2.12 release as well as the corresponding python bindings to the server, they are also tagged in git(s): ftp://libvirt.org/libvirt [/python] This is a mixed release, not really a huge feature addition though there should be user noticeable improvement for

Re: [libvirt] [PATCH tck 0/5] Misc. TCK cleanups

2015-01-27 Thread Daniel P. Berrange
On Mon, Jan 26, 2015 at 03:06:48PM -0700, Mike Latimer wrote: While running TCK on qemu, lxc and xen, I've ran into a few issues worth fixing upstream. The patches in this series are mainly focused on fixing minor typos, or safeguarding against failures in non-qemu environments. Depending on

Re: [libvirt] [PATCHv2 2/2] storage: try to perform btrfs clone if possible

2015-01-27 Thread Chen, Hanxiao
-Original Message- From: Ján Tomko [mailto:jto...@redhat.com] Sent: Tuesday, January 27, 2015 8:46 PM To: Chen, Hanxiao/陈 晗霄; libvir-list@redhat.com Subject: Re: [libvirt] [PATCHv2 2/2] storage: try to perform btrfs clone if possible On 01/23/2015 11:22 AM, Chen Hanxiao wrote:

[libvirt] [libvirt-test-API][PATCH V2 06/11] Remove extra space from xml

2015-01-27 Thread jiahu
--- repos/network/xmls/ip-dhcp-host.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/repos/network/xmls/ip-dhcp-host.xml b/repos/network/xmls/ip-dhcp-host.xml index 50e7908..b323218 100644 --- a/repos/network/xmls/ip-dhcp-host.xml +++ b/repos/network/xmls/ip-dhcp-host.xml

[libvirt] [libvirt-test-API][PATCH V2 07/11] Change bridge name as a variable in functions

2015-01-27 Thread jiahu
The function can get ip when domain has a non-default virual network --- utils/ipget.sh | 7 ++- utils/utils.py | 7 +-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/utils/ipget.sh b/utils/ipget.sh index 8d44b14..c2e0983 100755 --- a/utils/ipget.sh +++ b/utils/ipget.sh

[libvirt] [libvirt-test-API][PATCH V2 05/11] Add xml file for host of IPv6 family

2015-01-27 Thread jiahu
Added a new file to store static host of IPv6 --- repos/network/xmls/ipv6-dhcp-host.xml | 1 + 1 file changed, 1 insertion(+) create mode 100644 repos/network/xmls/ipv6-dhcp-host.xml diff --git a/repos/network/xmls/ipv6-dhcp-host.xml b/repos/network/xmls/ipv6-dhcp-host.xml new file mode 100644

[libvirt] [libvirt-test-API][PATCH V2 00/11] Add network_dhcp_leases test case

2015-01-27 Thread jiahu
For checking IPv6 address, libvirt need a IPv6 testing environment, so modified some cases and configuration files, also there are some small changes for other requirements. There are 9 new commits after comparing with the V1: Add global IPv6 default values to network part Add IPv6 section

[libvirt] [libvirt-test-API][PATCH V2 01/11] Add network_dhcp_leases test case

2015-01-27 Thread jiahu
The network_dhcp_leases.py uses DHCPLeases() to validate new API virNetworkGetDHCPLeases of libvirt. --- repos/network/network_dhcp_leases.py | 277 +++ 1 file changed, 277 insertions(+) create mode 100644 repos/network/network_dhcp_leases.py diff --git

[libvirt] [libvirt-test-API][PATCH V2 08/11] Obtain a IPv6 addr on interface

2015-01-27 Thread jiahu
--- kickstart.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kickstart.cfg b/kickstart.cfg index 446adf0..d4b40a8 100644 --- a/kickstart.cfg +++ b/kickstart.cfg @@ -6,7 +6,7 @@ url --url=http://fileshare.englab.nay.redhat.com/pub/redhat/rhel/released/RHEL-6 lang

[libvirt] [libvirt-test-API][PATCH V2 11/11] Add network_dhcp_leases test case to conf

2015-01-27 Thread jiahu
For running the case, should setup testing environment before the case, and clean up the environment after the case. --- cases/basic_network.conf | 100 +++ 1 file changed, 100 insertions(+) diff --git a/cases/basic_network.conf

[libvirt] [libvirt-test-API][PATCH V2 04/11] Add IPv6 section into related network case

2015-01-27 Thread jiahu
Added 4 IPv6 required parameters to case. --- repos/network/define.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/repos/network/define.py b/repos/network/define.py index dd054f7..6e50eb7 100644 --- a/repos/network/define.py +++ b/repos/network/define.py @@ -17,7

[libvirt] [libvirt-test-API][PATCH V2 09/11] Change bridge name as a variable in XML

2015-01-27 Thread jiahu
--- repos/domain/xmls/kvm_linux_guest_install_cdrom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/repos/domain/xmls/kvm_linux_guest_install_cdrom.xml b/repos/domain/xmls/kvm_linux_guest_install_cdrom.xml index cb59e76..1e7999b 100644 ---

[libvirt] [libvirt-test-API][PATCH V2 10/11] Support brige name argument in cases

2015-01-27 Thread jiahu
--- repos/domain/destroy.py | 5 +++-- repos/domain/install_linux_cdrom.py | 5 - 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/repos/domain/destroy.py b/repos/domain/destroy.py index 91e83ea..154ffaf 100644 --- a/repos/domain/destroy.py +++

[libvirt] [libvirt-test-API][PATCH V2 03/11] Add IPv6 section into network template xml

2015-01-27 Thread jiahu
--- repos/network/xmls/network.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/repos/network/xmls/network.xml b/repos/network/xmls/network.xml index 220169b..97e3517 100644 --- a/repos/network/xmls/network.xml +++ b/repos/network/xmls/network.xml @@ -7,4 +7,9 @@ range

[libvirt] [libvirt-test-API][PATCH V2 02/11] Add global IPv6 default values to network part

2015-01-27 Thread jiahu
Added below variables into global.cfg. netip6addr/netip6prefix/netip6start/netip6end --- global.cfg | 9 + 1 file changed, 9 insertions(+) diff --git a/global.cfg b/global.cfg index db8f71e..56677a5 100644 --- a/global.cfg +++ b/global.cfg @@ -195,6 +195,15 @@ defaultnetstart =

Re: [libvirt] [PATCH 1/2] Always free the device in AttachChrDevice

2015-01-27 Thread Ján Tomko
On 01/27/2015 04:27 PM, Michal Privoznik wrote: On 27.01.2015 14:45, Ján Tomko wrote: Do not free it in the caller (qemuDomainAttachDeviceFlags), because it has no way of knowing if it hasn't been cleaned up by qemuProcessStop on monitor EOF.

Re: [libvirt] [PATCH 1/2] Always free the device in AttachChrDevice

2015-01-27 Thread Michal Privoznik
On 27.01.2015 14:45, Ján Tomko wrote: Do not free it in the caller (qemuDomainAttachDeviceFlags), because it has no way of knowing if it hasn't been cleaned up by qemuProcessStop on monitor EOF. https://bugzilla.redhat.com/show_bug.cgi?id=1161024 --- src/qemu/qemu_driver.c | 3 +--

Re: [libvirt] [PATCHv2 2/2] storage: try to perform btrfs clone if possible

2015-01-27 Thread Ján Tomko
On 01/23/2015 11:22 AM, Chen Hanxiao wrote: When creating RAW file, we don't take advantage of clone of btrfs. Try to do a btrfs lightweight copy, or error out. Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- include/libvirt/libvirt-storage.h | 1 +

Re: [libvirt] [PATCHv2 1/2] storage: introduce btrfsCloneFile() for COW copy

2015-01-27 Thread Ján Tomko
On 01/23/2015 11:22 AM, Chen Hanxiao wrote: Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- configure.ac | 12 src/storage/storage_backend.c | 24 2 files changed, 36 insertions(+) diff --git a/configure.ac b/configure.ac

Re: [libvirt] [PATCH] virsh: report 0-length active block-commit job status

2015-01-27 Thread Eric Blake
On 01/19/2015 03:01 PM, John Ferlan wrote: Revisiting, now that the release is done. On 01/12/2015 05:54 PM, Eric Blake wrote: At least with live block commit, it is possible to have a block job that reports 0 status: namely, when the active image contains no sectors that differ from the

Re: [libvirt] Missing libxl_device_nic settings

2015-01-27 Thread Jim Fehlig
Kim Larry wrote: Hi, I was trying to pass ip address to scripts/vif-bridge by putting ip address=/ in guest config xml file, however, I found that libxlMakeNic(which located in libxl/libxl_conf.c:956) doesn't set x_nic-ip. So I patched myself but I'm not so sure about