On 29.01.2015 11:25, Martin Kletzander wrote:
On Wed, Jan 28, 2015 at 06:23:08PM +0100, Michal Privoznik wrote:
There are some interface types (notably 'server' and 'client')
which instead of allowing the default set of elements and
attributes (like the rest do), try to enumerate only the
On 01/29/2015 08:43 AM, Martin Kletzander wrote:
On Wed, Jan 28, 2015 at 05:25:01PM -0500, John Ferlan wrote:
Commit id '540c339a' to fix issues with reference counting and transient
domains moved the qemuDomainObjEndAsyncJob call prior to the attempt to
restart the guest CPU's resulting in
On 29.01.2015 10:07, Ján Tomko wrote:
When compiling without WITH_MACVTAP, we can get:
'unsupported flags (0x1) in function
virNetDevMacVLanCreateWithVPortProfile'
on an attempt to start a domain.
Remove the flag check to reach the more helpful error:
Cannot create macvlan devices on this
On Thu, Jan 29, 2015 at 08:37:37AM +0100, Peter Krempa wrote:
--live and --config can't be specified together when querying the
configuration, but are valid when setting. The man page was hinting that
they are valid always.
---
tools/virsh.pod | 7 ---
1 file changed, 4 insertions(+), 3
When compiling without WITH_MACVTAP, we can get:
'unsupported flags (0x1) in function
virNetDevMacVLanCreateWithVPortProfile'
on an attempt to start a domain.
Remove the flag check to reach the more helpful error:
Cannot create macvlan devices on this platform
On Thu, Jan 29, 2015 at 09:18:03 +0100, Martin Kletzander wrote:
On Thu, Jan 29, 2015 at 08:37:37AM +0100, Peter Krempa wrote:
--live and --config can't be specified together when querying the
configuration, but are valid when setting. The man page was hinting that
they are valid always.
---
On Wed, Jan 28, 2015 at 06:23:08PM +0100, Michal Privoznik wrote:
There are some interface types (notably 'server' and 'client')
which instead of allowing the default set of elements and
attributes (like the rest do), try to enumerate only the elements
they know of. This way it's, however, easy
On Tue, Jan 27, 2015 at 01:37:26PM +, Daniel P. Berrange wrote:
On Tue, Jan 27, 2015 at 02:25:35PM +0100, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1170492
In one of our previous commits (dc8b7ce7) we've done a functional
change even though it was intended as pure
On Tue, Jan 27, 2015 at 02:25:35PM +0100, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1170492
In one of our previous commits (dc8b7ce7) we've done a functional
change even though it was intended as pure refactor. The problem is,
that the following XML:
vcpu
On Sat, Jan 17, 2015 at 13:09:35 +0800, Luyao Huang wrote:
qemuMonitorAttachRNGDev and qemuMonitorDetachRNGDev functions
just do some basic check and then call qemuMonitorJSONAttachRNGDev
and qemuMonitorDelObject to help us.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
See http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/3103/
--
Started by upstream project libvirt-build build number 3538
Building on master in workspace
http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/ws/
[workspace] $ /bin/sh -xe
On Tuesday 27 January 2015 06:53 AM, hong-hua@freescale.com wrote:
Hi Prerna,
Currently, cpu_powerpc.c only support IBM ppc64 CPU models.
Could your please help review the previous patch? With this patch, Freescale
ppc64 CPU modesl could also be recognized.
# virsh cpu-models ppc64
On 01/29/2015 05:48 PM, Peter Krempa wrote:
On Sat, Jan 17, 2015 at 13:09:35 +0800, Luyao Huang wrote:
qemuMonitorAttachRNGDev and qemuMonitorDetachRNGDev functions
just do some basic check and then call qemuMonitorJSONAttachRNGDev
and qemuMonitorDelObject to help us.
Signed-off-by: Luyao
On Wed, Jan 28, 2015 at 05:25:00PM -0500, John Ferlan wrote:
If we get to endjob: because of some error earlier such as perhaps
failure from qemuDomainSaveMemory to open/create the save file and
the attempt to restart the CPU's fails, then we get the error from
that restart attempt displayed to
My commit 08d1ae1 broke syntax-check by adding ATTRIBUTE_UNUSED
to the flags parameter.
Rename the parameter to unused_flags to bypass the check.
---
Pushed as a build fix.
src/util/virnetdevmacvlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Friday 23 January 2015 08:42 AM, Olivia Yin wrote:
Signed-off-by: Olivia Yin hong-hua@freescale.com
---
src/cpu/cpu_map.xml | 38 +-
1 file changed, 37 insertions(+), 1 deletion(-)
diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml
index
On Wed, Jan 28, 2015 at 05:25:01PM -0500, John Ferlan wrote:
Commit id '540c339a' to fix issues with reference counting and transient
domains moved the qemuDomainObjEndAsyncJob call prior to the attempt to
restart the guest CPU's resulting in an error:
error: Failed to save domain rhel70 to
On 28.01.2015 11:30, Peter Krempa wrote:
With the new JSON to argv formatter we are now able to represent the
memory backend definitions in the JSON object format that is reusable
for monitor use (hotplug) and then convert it into the shell string.
This will avoid having two separate instances
On 28.01.2015 11:30, Peter Krempa wrote:
Unlike -device, qemu uses a JSON object to add backend objects via the
monitor rather than the string that would be passed on the commandline.
To be able to reuse code parts that configure backends for various
devices, this patch adds a helper that
On 28.01.2015 11:30, Peter Krempa wrote:
To be able to easily represent nodesets and other data stored in
virBitmaps in libvirt, this patch introduces a set of helpers that allow
to convert the bitmap to and from JSON value objects.
---
src/libvirt_private.syms | 2 +
src/util/virjson.c
On 28.01.2015 11:30, Peter Krempa wrote:
To allow constructing of value objects stepwise explode the helper into
separate steps and allow appending into existing value objects.
---
src/libvirt_private.syms | 2 ++
src/util/virjson.c | 74
On 01/28/2015 05:30 AM, Peter Krempa wrote:
With the new JSON to argv formatter we are now able to represent the
memory backend definitions in the JSON object format that is reusable
for monitor use (hotplug) and then convert it into the shell string.
This will avoid having two separate
See http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/3104/
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
https://bugzilla.redhat.com/show_bug.cgi?id=1170492
In one of our previous commits (dc8b7ce7) we've done a functional
change even though it was intended as pure refactor. The problem is,
that the following XML:
vcpu placement='static' current='2'6/vcpu
cputune
emulatorpin cpuset='1-3'/
On Mon, Jan 26, 2015 at 03:38:04PM +0100, Michal Privoznik wrote:
Up until now there are just two ways how to specify UEFI paths to
libvirt. The first one is editing qemu.conf, the other is editing
qemu_conf.c and recompile which is not that fancy. So, new
configure option is introduced:
I don't see this being used anywhere in this set of patches... I assume
you have some other upcoming patch series that will use it...
NITs
On 01/28/2015 05:30 AM, Peter Krempa wrote:
Adding or reordering test cases is usually a pain due to static test
case names that are then passed to
On 01/28/2015 03:30 AM, Peter Krempa wrote:
This helper easies iterating all key=value pairs stored in a JSON
s/easies/eases/
object. Usually we pick only certain known keys from a JSON object, but
this will allow to walk complete objects and have the callback act on
those.
---
On 01/29/2015 02:23 PM, John Ferlan wrote:
I don't see this being used anywhere in this set of patches... I assume
you have some other upcoming patch series that will use it...
NM - my cscope autorebuild failed sigh... I found the usage in 6/12
John
--
libvir-list mailing list
On 01/28/2015 03:25 PM, John Ferlan wrote:
Rather than have a dummy waitpid loop and return of the failure status
from recvfd, adjust the logic to save the recvfd error fd and then
in priority order:
if waitpid failed, use that
if waitpid succeeded, but the child reported failure, use that
On 01/28/2015 05:24 PM, John Ferlan wrote:
Lots of details here:
...snip...
John Ferlan (7):
qemu: Save/restore error in error path for qemuDomainSaveInternal
qemu: Adjust EndAsyncJob for qemuDomainSaveInternal error path
virfile: Need to check for ENOTCONN from recvfd failure
On 01/28/2015 03:25 PM, John Ferlan wrote:
In the event we're falling into the code that tries to create the file
in a forked environment (VIR_FILE_OPEN_FORK) we pass different mode bits,
but those are never set because the virFileOpenForceOwnerMode has a check
if the OPEN_FORCE_MODE bit is
On 01/29/2015 03:13 PM, Eric Blake wrote:
On 01/28/2015 03:25 PM, John Ferlan wrote:
If we get to endjob: because of some error earlier such as perhaps
failure from qemuDomainSaveMemory to open/create the save file and
the attempt to restart the CPU's fails, then we get the error from
that
On 01/28/2015 03:25 PM, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1158034
In qemuOpenFileAs if we fall into the path where we'll be opening / creating
the file using VIR_FILE_OPEN_FORK, we need to first unlink/delete the file
we created in the first path; otherwise, the
On 01/28/2015 03:25 PM, John Ferlan wrote:
If we're expecting to create a file somewhere and that fails for some
reason during qemuOpenFileAs, then we unlink the path we're attempting
to create leaving no way to determine what the existing privileges,
protections, or labels are that caused the
On 01/28/2015 03:25 PM, John Ferlan wrote:
If we get to endjob: because of some error earlier such as perhaps
failure from qemuDomainSaveMemory to open/create the save file and
the attempt to restart the CPU's fails, then we get the error from
that restart attempt displayed to the user rather
On 01/28/2015 03:25 PM, John Ferlan wrote:
A gnulib change (commit id 'beae0bdc') causes ENOTCONN to be returned
from recvfd which causes us to fall into the throwaway waitpid() call
and return ENOTCONN to the caller, this then gets displayed during
a 'virsh save' when using a root squashed
Hello Michal,
Thank you for taking the time to review my patch, you made some very good
points and helped me discover features of the code base I didn't know.
To answer you question: systemd can still do whatever it wants within the
container this won't change that. Setting of the rlimits
Prerna,
Thank you. I'll update the patch according to the latest implementation.
Best Regards,
Olivia
-Original Message-
From: Prerna Saxena [mailto:pre...@linux.vnet.ibm.com]
Sent: Thursday, January 29, 2015 8:01 PM
To: Yin Olivia-R63875; libvir-list@redhat.com
Subject: Re:
On 01/28/2015 03:14 PM, jiahu wrote:
Added 4 IPv6 required parameters to case.
---
repos/network/define.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/repos/network/define.py b/repos/network/define.py
index dd054f7..6e50eb7 100644
--- a/repos/network/define.py
From: Olivia Yin hong-hua@freescale.com
With this patch, Freescale ppc64 CPU modesl could be recognized.
virsh # cpu-models ppc64
POWERPC_e6500
POWERPC_e5500
power8
power8e
power7+
power7
power6
POWER8_v1.0
POWER7+_v2.1
POWER7_v2.3
POWER7_v2.1
POWER7
virsh # capabilities
capabilities
host
On Fri, Jan 30, 2015 at 06:55:05AM +0100, Martin Kletzander wrote:
Let's save 21 lines just because I've found out a way how to convince
xmllint to do something we thought it can't. The first patch is the
brains of this operation, the second one is just a cleaner guy; best
served with '-w'.
On Thu, Jan 29, 2015 at 04:12:15PM +0100, Michal Privoznik wrote:
On 29.01.2015 11:25, Martin Kletzander wrote:
On Wed, Jan 28, 2015 at 06:23:08PM +0100, Michal Privoznik wrote:
There are some interface types (notably 'server' and 'client')
which instead of allowing the default set of elements
Recent commit 5568 added 'interface-options' to all interface types
rendering the definition useless. Moreover the usage was redundant and
this patch aims to fix that.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
docs/schemas/domaincommon.rng | 37
After recent change, the indentation for interface definition in the
Relax-NG schema is off. This whitespace-only patch fixes that in order
for the previous patch to be cleaner and more readable.
To be viewed with '-w' (ignoring whitespaces).
Signed-off-by: Martin Kletzander mklet...@redhat.com
Let's save 21 lines just because I've found out a way how to convince
xmllint to do something we thought it can't. The first patch is the
brains of this operation, the second one is just a cleaner guy; best
served with '-w'.
Martin Kletzander (2):
schema: Remove unnecessary interface-options
---
docs/formatdomain.html.in | 49 +++
docs/schemas/domaincommon.rng | 89
+
src/conf/domain_conf.c| 92
+++
src/conf/domain_conf.h| 33
46 matches
Mail list logo
