On 02/06/2015 08:04 PM, Eric Blake wrote:
On 02/06/2015 11:13 AM, Erik Skultety wrote:
Add a check for invalid security models in per-device configuration as well
as a
check for seclabel duplicates in per-device configuration
Erik Skultety (6):
security: Add check for valid security
On 09.02.2015 14:19, Ján Tomko wrote:
On Mon, Feb 09, 2015 at 10:58:29AM +0100, Michal Privoznik wrote:
Instead of verbose string to enum conversion (if STREQ() else if
STREQ() else if STREQ() ...) lets use awesome VIR_ENUM_* macros.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
On Mon, Feb 09, 2015 at 09:47:47AM -0500, Laine Stump wrote:
On 02/09/2015 08:19 AM, Ján Tomko wrote:
On Mon, Feb 09, 2015 at 10:58:29AM +0100, Michal Privoznik wrote:
Instead of verbose string to enum conversion (if STREQ() else if
STREQ() else if STREQ() ...) lets use awesome VIR_ENUM_*
Jihoon Kim wrote:
From: Ji-hoon Kim re...@me.com
Currently libxlMakeNic() does not set ip address when creating NIC,
this patch makes it to set ip address.
FYI, Marek recently sent a patch to do the same
https://www.redhat.com/archives/libvir-list/2015-February/msg00139.html
I like
On Fri, Feb 06, 2015 at 04:32:21PM +0100, Peter Krempa wrote:
As the RNG device is using an -object as backend refactor the code to
use the JSON to commandline generator so that we can reuse the code
later in hotplug.
---
src/qemu/qemu_command.c | 108
On Mon, Feb 09, 2015 at 03:20:28PM +, Serge Hallyn wrote:
Hi,
'virsh vcpuinfo' in 1.2.12 returns an empty line for VMs using tcg. I
assume this is due to commit b07f3d821dfb11 which explicitly sets
nvcpupids to 0 now. Is 'virsh vcpuinfo' returning nothing just an
unfortunate but
On Mon, Feb 09, 2015 at 16:51:24 +0100, Ján Tomko wrote:
On Fri, Feb 06, 2015 at 04:32:15PM +0100, Peter Krempa wrote:
When adding devices to the definition it's useful to check whether the
devices don't reside on a conflicting address. This patch adds a helper
that iterates all device info
Hi,
'virsh vcpuinfo' in 1.2.12 returns an empty line for VMs using tcg. I
assume this is due to commit b07f3d821dfb11 which explicitly sets
nvcpupids to 0 now. Is 'virsh vcpuinfo' returning nothing just an
unfortunate but expected side-effect, or is it a bug and it should
return info anyway?
The enum converters are defined in the domain_conf.h (so
accessible widely across the code), but on the symbol layer, only
virDomainNetTypeToString was exposed. However, FromString variant
is going to be needed shortly.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
The type of interface to attach is held in the variable 'typ'.
Depending on interface type selected by user, the variable is set
either to 1 (network), or 2 (bridge). Lets use already existing
enum from domain_conf.h instead: virDomainNetType.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
On Mon, Feb 09, 2015 at 04:02:04PM +0100, Ján Tomko wrote:
On Mon, Feb 09, 2015 at 09:47:47AM -0500, Laine Stump wrote:
On 02/09/2015 08:19 AM, Ján Tomko wrote:
On Mon, Feb 09, 2015 at 10:58:29AM +0100, Michal Privoznik wrote:
Instead of verbose string to enum conversion (if STREQ() else
Our hotplug code supports macvtap insertion to guests. However, we
somehow forgot about 'attach-interface' (which tries to build XML from
passed arguments and use virDomainAttachDeviceFlags()).
New type is accessible under 'direct' type, to keep the same type as
used in domain XML.
Signed-off-by:
On Thu, Feb 05, 2015 at 03:36:17PM -0700, Jim Fehlig wrote:
Marek Marczykowski-Górecki wrote:
Do not silently ignore its value. LibXL support only one address, so
refuse multiple IPs.
Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com
---
src/libxl/libxl_conf.c
On Sat, Feb 07, 2015 at 12:22:51PM +0100, Marek Marczykowski-Górecki wrote:
On Thu, Feb 05, 2015 at 02:53:44PM -0700, Jim Fehlig wrote:
Marek Marczykowski-Górecki wrote:
Vfb entries in domain config are used only by PV drivers. Qemu
parameters are build based on b_info struct. So fill it
On Fri, Feb 06, 2015 at 04:32:25PM +0100, Peter Krempa wrote:
From: Luyao Huang lhu...@redhat.com
Export the required helpers and add backend code to hotplug RNG devices.
Signed-off-by: Luyao Huang lhu...@redhat.com
Signed-off-by: Peter Krempa pkre...@redhat.com
---
On Fri, Feb 06, 2015 at 04:32:15PM +0100, Peter Krempa wrote:
When adding devices to the definition it's useful to check whether the
devices don't reside on a conflicting address. This patch adds a helper
that iterates all device info and comapres the addresses with the given
On 02/09/2015 08:19 AM, Ján Tomko wrote:
On Mon, Feb 09, 2015 at 10:58:29AM +0100, Michal Privoznik wrote:
Instead of verbose string to enum conversion (if STREQ() else if
STREQ() else if STREQ() ...) lets use awesome VIR_ENUM_* macros.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
09.02.2015 16:02, Michal Privoznik пишет:
On 30.01.2015 20:58, Maxim Nestratov wrote:
In order to support 'bridge' network adapters in parallels
driver we need to plug our veth devices into corresponding
linux bridges.
We are going to do this by reusing our abstraction of
Virtual Networks in
v2
Michal Privoznik (4):
libvirt_private.syms: Expose virDomainNetTypeFromString
virsh attach-interface: Use enum instead of arbitrary integers
virsh attach-interface: Use virDomainNetType{From,To}String()
virsh attach-interface: Allow macvtap hotplug
src/libvirt_private.syms | 1 +
Instead of verbose string to enum conversion (if STREQ() else if
STREQ() else if STREQ() ...) lets use virDomainNetType{From,To}String.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tools/virsh-domain.c | 32 +++-
1 file changed, 23 insertions(+), 9
On Fri, Feb 06, 2015 at 04:32:14PM +0100, Peter Krempa wrote:
Extension of Luyao's series with changes that were possible due to the prepare
series for memory hotplug.
Luyao Huang (7):
qemu: Add helper to assign RNG device aliases
qemu: refactor qemuBuildRNGDeviceArgs to allow reuse in
On Sat, Feb 07, 2015 at 04:53:46PM +0900, Jihoon Kim wrote:
From: Ji-hoon Kim re...@me.com
Currently libxlMakeNic() does not set ip address when creating NIC,
this patch makes it to set ip address.
Signed-off-by: Ji-hoon Kim re...@me.com
---
src/libxl/libxl_conf.c | 14 ++
Anthony PERARD wrote:
On Mon, Feb 02, 2015 at 05:00:34PM -0700, Jim Fehlig wrote:
This small series fixes some assertions we occasionally see in the
libxl driver when running libvirt-TCK. The assertions were due to
races between destroying per-domain libxl_ctx and receiving fd and
timer
Hi Jan,
On Mon, 2015-02-09 at 10:04 +0100, Ján Tomko wrote:
On Fri, Feb 06, 2015 at 02:28:15PM +0100, Cédric Bosdonnat wrote:
commit a58e1cb4 didn't fix the bug if the security_default_confined is
not set to 1. We now clean up even if there is no seclabel defined or
the default one.
---
On Fri, Feb 06, 2015 at 07:13:24PM +0100, Erik Skultety wrote:
---
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK and pushed.
Jan
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 4251b13..a36dace 100644
--- a/src/conf/domain_conf.c
On Mon, Feb 09, 2015 at 10:28:49 +, Daniel Berrange wrote:
On Fri, Jan 30, 2015 at 02:21:02PM +0100, Peter Krempa wrote:
WIP: TODO: docs
Also forbid the new device in post parse callback in all driver that
implement the callback to warn users right away that the device is not
On Fri, Jan 30, 2015 at 02:21:04PM +0100, Peter Krempa wrote:
Make sure that libvirt has all vital information needed to reliably
represent configuration of guest's memory devices in case of a
migration.
This patch forbids migration in case the required slot number and module
base address
On Fri, Jan 30, 2015 at 02:21:01PM +0100, Peter Krempa wrote:
ACPI Dimm devices are described by the slot and base address. Add a new
address type to be able to describe such address.
} virDomainDeviceAddressType;
@@ -309,6 +310,13 @@ struct _virDomainDeviceISAAddress {
unsigned int
On Fri, Feb 06, 2015 at 07:13:23PM +0100, Erik Skultety wrote:
We do have a check for valid per-domain security model, however we still
do permit an invalid security model for a disk type device.
This patch introduces a new function virSecurityStackCheckDiskLabels
which compares user specified
On Fri, Feb 06, 2015 at 02:28:15PM +0100, Cédric Bosdonnat wrote:
commit a58e1cb4 didn't fix the bug if the security_default_confined is
not set to 1. We now clean up even if there is no seclabel defined or
the default one.
---
src/lxc/lxc_process.c | 8 +++-
1 file changed, 7
This is only tested by domainschematest.
It should be added to either qemuxml2xmltest or qemuxml2argvtest
and squashed in together with the commit adding this check.
Jan
On Fri, Feb 06, 2015 at 07:13:27PM +0100, Erik Skultety wrote:
---
.../qemuxml2argv-seclabel-device-multiple.xml | 35
I've just wanted to hotplug a macvtap device into a running
guest. I was too lazy to write an XML, and I've found out that
virsh attach-interface doesn't know how to plug macvtaps.
Michal Privoznik (3):
virsh attach-interface: Use enum instead of arbitrary integers
virsh: Use VIR_ENUM* macros
On Fri, Jan 30, 2015 at 02:20:57PM +0100, Peter Krempa wrote:
!! this series applies on top of the cleanup series posted earlier !!
Hi,
this is my try to implement memory hotplug in libvirt (for the qemu) driver.
This series is almost code-complete but is lacking tests and docs as I wanted
On Fri, Feb 06, 2015 at 06:07:35PM +0100, Peter Krempa wrote:
On Thu, Feb 05, 2015 at 20:54:11 -0700, Eric Blake wrote:
On 01/30/2015 06:20 AM, Peter Krempa wrote:
Add a XML element that will allow to specify maximum supportable memory
s/a XML/an XML/
and the count of memory slots
Instead of verbose string to enum conversion (if STREQ() else if
STREQ() else if STREQ() ...) lets use awesome VIR_ENUM_* macros.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tools/virsh-domain.c | 28 ++--
1 file changed, 18 insertions(+), 10 deletions(-)
Our hotplug code supports macvtap insertion to guests. However, we
somehow forgot about 'attach-interface' (which tries to build XML from
passed arguments and use virDomainAttachDeviceFlags()).
New type is accessible under 'direct' type, to keep the same type as
used in domain XML.
Signed-off-by:
The type of interface to attach is held in the variable 'typ'.
Depending on interface type selected by user, the variable is set
either to 1 (network), or 2 (bridge). Lets use an enum instead.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tools/virsh-domain.c | 15 ++-
1
On Fri, Jan 30, 2015 at 02:21:06PM +0100, Peter Krempa wrote:
When adding devices to the definition it's useful to check whether the
devices don't reside on a conflicting address. This patch adds a helper
that iterates all device info and comapres the addresses with the given
info.
---
On Mon, Feb 09, 2015 at 10:24:04 +, Daniel Berrange wrote:
On Fri, Jan 30, 2015 at 02:21:04PM +0100, Peter Krempa wrote:
Make sure that libvirt has all vital information needed to reliably
represent configuration of guest's memory devices in case of a
migration.
This patch forbids
On Fri, Feb 06, 2015 at 09:09:56PM +0100, Marek Marczykowski-Górecki wrote:
On Fri, Feb 06, 2015 at 08:03:43PM +, Daniel P. Berrange wrote:
On Fri, Feb 06, 2015 at 07:11:40PM +0100, Marek Marczykowski-Górecki wrote:
On Fri, Feb 06, 2015 at 05:36:40PM +, Daniel P. Berrange wrote:
09.02.2015 16:02, Michal Privoznik пишет:
On 30.01.2015 20:58, Maxim Nestratov wrote:
After 55ea7be7, failures of parallelsLoadNetworks and parallelsStorageOpen
started to fail establishing a new connection to parallels driver.
Before this patch we simply ignored such errors.
This patch
On Fri, Jan 30, 2015 at 02:21:00PM +0100, Peter Krempa wrote:
To enable memory hotplug the maximum memory size and slot count need to
be specified. As qemu supports now other units than mebibytes when
specifying memory, use the new interface in this case.
---
docs/formatdomain.html.in
On Mon, Feb 09, 2015 at 10:39:35AM +0100, Michal Privoznik wrote:
On 05.02.2015 16:36, Lin Ma wrote:
Daniel P. Berrange berra...@redhat.com 2015-2-4 下午 17:17
On Mon, Feb 02, 2015 at 10:08:21PM +0800, Lin Ma wrote:
It constructs a temporary static config of the network, Obtains all of
On 05.02.2015 16:36, Lin Ma wrote:
Daniel P. Berrange berra...@redhat.com 2015-2-4 下午 17:17
On Mon, Feb 02, 2015 at 10:08:21PM +0800, Lin Ma wrote:
It constructs a temporary static config of the network, Obtains all of
attached interfaces information through netcf, Then removes the config.
On Fri, Jan 30, 2015 at 02:21:02PM +0100, Peter Krempa wrote:
WIP: TODO: docs
Also forbid the new device in post parse callback in all driver that
implement the callback to warn users right away that the device is not
supported with their hypervisor.
---
docs/schemas/domaincommon.rng
On Fri, Feb 06, 2015 at 07:13:26PM +0100, Erik Skultety wrote:
In our RNG schema we do allow multiple seclabels per-domain, bu don't
allow this for devices, yet we neither have a check in our XML parser,
nor in a post-parse callback. As one of my previous patches in this
series added that
On Mon, Feb 09, 2015 at 10:58:30 +0100, Michal Privoznik wrote:
Our hotplug code supports macvtap insertion to guests. However, we
somehow forgot about 'attach-interface' (which tries to build XML from
passed arguments and use virDomainAttachDeviceFlags()).
New type is accessible under
On Mon, Feb 09, 2015 at 10:58:29AM +0100, Michal Privoznik wrote:
Instead of verbose string to enum conversion (if STREQ() else if
STREQ() else if STREQ() ...) lets use awesome VIR_ENUM_* macros.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tools/virsh-domain.c | 28
On Wed, Feb 04, 2015 at 03:00:08PM +0100, Stefan Zimmermann wrote:
Adding ccw bus address support to the optional address parameter of virsh
attach-disk. The format used is ccw:cssid. ssid.devno, e.g.
ccw:0xfe.0x0.0x0201
Virtio-ccw devices must have their cssid set to 0xfe.
Signed-off-by:
On Wed, Feb 04, 2015 at 03:00:09PM +0100, Stefan Zimmermann wrote:
Change the wording in the device-address-part of the docmunentation since
the ccw bus address support added to the optional address parameter of
virsh attach-disk for S390.
Signed-off-by: Stefan Zimmermann
On 01/30/2015 08:20 AM, Peter Krempa wrote:
!! this series applies on top of the cleanup series posted earlier !!
Hi,
this is my try to implement memory hotplug in libvirt (for the qemu) driver.
This series is almost code-complete but is lacking tests and docs as I wanted
to agree on
On 30.01.2015 20:58, Maxim Nestratov wrote:
From: Mikhail Feoktistov mfeoktis...@parallels.com
Otherwise exporting existing domain config and defining a new one like this:
virsh -c parallels:///system dumpxml instance01 my.xml
virsh -c parallels:///system define my.xml
leads to an error
On 30.01.2015 20:58, Maxim Nestratov wrote:
After 55ea7be7, failures of parallelsLoadNetworks and parallelsStorageOpen
started to fail establishing a new connection to parallels driver.
Before this patch we simply ignored such errors.
This patch restores the ability to connect to parallels
On 30.01.2015 20:58, Maxim Nestratov wrote:
In order to support 'bridge' network adapters in parallels
driver we need to plug our veth devices into corresponding
linux bridges.
We are going to do this by reusing our abstraction of
Virtual Networks in terms of PCS. On a domain creation, we
On Mon, Feb 09, 2015 at 10:58:29 +0100, Michal Privoznik wrote:
Instead of verbose string to enum conversion (if STREQ() else if
STREQ() else if STREQ() ...) lets use awesome VIR_ENUM_* macros.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tools/virsh-domain.c | 28
On Mon, Feb 09, 2015 at 10:58:28 +0100, Michal Privoznik wrote:
The type of interface to attach is held in the variable 'typ'.
Depending on interface type selected by user, the variable is set
either to 1 (network), or 2 (bridge). Lets use an enum instead.
Signed-off-by: Michal Privoznik
On 30.01.2015 18:52, John Ferlan wrote:
In the event we're falling into the code that tries to create the file
in a forked environment (VIR_FILE_OPEN_FORK) we pass different mode bits,
but those are never set because the virFileOpenForceOwnerMode has a check
if the OPEN_FORCE_MODE bit is set
On Mon, Feb 09, 2015 at 08:38:52 -0500, John Ferlan wrote:
On 01/30/2015 08:20 AM, Peter Krempa wrote:
!! this series applies on top of the cleanup series posted earlier !!
Hi,
this is my try to implement memory hotplug in libvirt (for the qemu) driver.
This series is almost
On 30.01.2015 18:52, John Ferlan wrote:
Rather than have a dummy waitpid loop and return of the failure status
from recvfd, adjust the logic to save the recvfd error fd and then
in priority order:
- if waitpid failed, use that errno value
- waitpid succeeded, but if the child exited
On Mon, Jan 26, 2015 at 12:08 AM, Nehal J Wani nehaljw.k...@gmail.com
wrote:
This feature has been requested for a very long time. Since qemu guest
agent and leaseshelper give us reliable results, now the wait is over.
The RFC was first proposed by Michal Privoznik:
60 matches
Mail list logo
