Re: [libvirt] [RFC] Memory hotplug naming [Was: [PATCHv2 3/7] conf: Replace access to def->mem.max_balloon with accessor functions]

2015-03-08 Thread Martin Kletzander
On Wed, Mar 04, 2015 at 03:25:31PM +0100, Peter Krempa wrote: Adding Dan && Eric to cc I already did that in my mail, but since the subject didn't start with "Re:" and they have de-duplication turned on, you can't see them here (thank the mailman, I guess). On Thu, Feb 26, 2015 at 14:06:55 +

[libvirt] [PATCH v4 4/4] migration: Expose 'cancelling' status to user

2015-03-08 Thread zhanghailiang
'cancelling' status was introduced by commit 51cf4c1a, mainly to avoid a possible start of a new migration process while the previous one still exists. But we didn't expose this status to user, instead we returned the 'active' state. Here, we expose it to the user (such as libvirt), 'cancelling'

[libvirt] Applying for GSoC project 'Introducing job control to the storage driver' in libvirt

2015-03-08 Thread Taowei Luo
Hello, everyone. I'm Taowei Luo. A participator in Google Summer of Code last year for the project rewriting vbox driver in libvirt. I am so glad that my project isn't found in this year's GSoC project list :) Having a nice experience last year, libvirt is my top option to join the GSoC 2015. And

Re: [libvirt] [PATCHv2 2/4] conf: introduce new family attribute in graphics listen for chose IP family

2015-03-08 Thread lhuang
On 03/09/2015 07:50 AM, John Ferlan wrote: On 02/28/2015 04:08 AM, Luyao Huang wrote: If a interface or network have both ipv6 and ipv4 address which can be used, we do not know use which be a listen address. So introduce a new attribute to help us chose this. graphics XML will like this afte

Re: [libvirt] [PATCH] libvirt-domain.h: changing some unsigned int parameters to the respective enum type.

2015-03-08 Thread Julio Faracco
Hi guys! I'm really don't know the reason of keeping 'unsigned int' instead 'enum' types. I asked it at IRC, but no response. =( Is it need a clean up or it is designed this way? Thanks! -- *Julio Cesar Faracco* -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/

[libvirt] [PATCH] libvirt-domain.h: changing some unsigned int parameters to the respective enum type.

2015-03-08 Thread Julio Faracco
Recently, some code were cleaned ups. Now, some parameters are being converted to its respective enum type. For example, there are many functions that are using int or unsigned int types instead enum types. So, this kind of cleaning up can be necessary. Signed-off-by: Julio Faracco --- include/l

Re: [libvirt] [PATCHv2 3/4] network: rework networkGetNetworkAddress to make it can get IPv6 address

2015-03-08 Thread lhuang
On 03/09/2015 07:50 AM, John Ferlan wrote: $SUBJ: network: Allow networkGetNetworkAddress to return IPv6 address On 02/28/2015 04:08 AM, Luyao Huang wrote: Export the required helpers and rework networkGetNetworkAddress to make it can get IPv6 address. Signed-off-by: Luyao Huang --- v2: re

Re: [libvirt] [PATCHv2 4/4] qemu: fix a error coverd issue in 2 place

2015-03-08 Thread lhuang
On 03/09/2015 07:51 AM, John Ferlan wrote: On 02/28/2015 04:08 AM, Luyao Huang wrote: we already set a more clearly error in networkGetNetworkAddress, so this error will cover our error in networkGetNetworkAddress. Signed-off-by: Luyao Huang --- src/qemu/qemu_command.c | 14 --

Re: [libvirt] [PATCH v3 4/4] migration: Expose 'cancelling' status to user

2015-03-08 Thread zhanghailiang
On 2015/3/7 0:24, Eric Blake wrote: On 03/04/2015 07:09 AM, zhanghailiang wrote: 'cancelling' status is introduced by commit 51cf4c1a, which is mainly avoid s/is introduced/was introduced/ s/which is mainly avoid/mainly to avoid a/ possible starting a new migration process while the previous

Re: [libvirt] [PATCHv2 4/4] qemu: fix a error coverd issue in 2 place

2015-03-08 Thread John Ferlan
On 02/28/2015 04:08 AM, Luyao Huang wrote: > we already set a more clearly error in networkGetNetworkAddress, > so this error will cover our error in networkGetNetworkAddress. > > Signed-off-by: Luyao Huang > --- > src/qemu/qemu_command.c | 14 -- > 1 file changed, 4 insertions(+),

Re: [libvirt] [PATCHv2 3/4] network: rework networkGetNetworkAddress to make it can get IPv6 address

2015-03-08 Thread John Ferlan
$SUBJ: network: Allow networkGetNetworkAddress to return IPv6 address On 02/28/2015 04:08 AM, Luyao Huang wrote: > Export the required helpers and rework networkGetNetworkAddress to > make it can get IPv6 address. > > Signed-off-by: Luyao Huang > --- > v2: rework the code and make networkGetN

Re: [libvirt] [PATCHv2 2/4] conf: introduce new family attribute in graphics listen for chose IP family

2015-03-08 Thread John Ferlan
On 02/28/2015 04:08 AM, Luyao Huang wrote: > If a interface or network have both ipv6 and ipv4 address which can be used, > we do not know use which be a listen address. So introduce a new attribute > to help us chose this. > > graphics XML will like this after this commit: > > >fa

Re: [libvirt] [PATCHv2 1/4] util: introduce 2 new helpers for get interface IPv6 address

2015-03-08 Thread John Ferlan
On 02/28/2015 04:08 AM, Luyao Huang wrote: > Introduce virNetDevGetIfaddrsAddress to help to get interface IPv6 > and IPv4 address. > > Introduce virNetDevGetIPAddress to use virNetDevGetIfaddrsAddress > and virNetDevGetIPv4Address to get IP address. > > Signed-off-by: Luyao Huang > --- > v2: a

Re: [libvirt] [PATCH 0/6] Follow-up patches for IOThread API/display

2015-03-08 Thread Ján Tomko
On Fri, Mar 06, 2015 at 01:47:06PM -0500, John Ferlan wrote: > Based on jtomko's review of the IOThread series and my foray into the > libvirt-perl bindings, these patches make the following adjustments: > > Patch 1 - Found while generating the virsh iothreadpin description, the > vcpup

Re: [libvirt] [PATCH 5/6] qemu: Change qemuDomainGetVcpuPinInfo bitmap manipulation

2015-03-08 Thread Ján Tomko
On Fri, Mar 06, 2015 at 01:47:11PM -0500, John Ferlan wrote: > Follow-up to the IOThread review on CPU affinity map manipulation: > > http://www.redhat.com/archives/libvir-list/2015-March/msg00294.html > > indicates that the GetVcpuPinInfo could use similar algorithm adjustments > which is what t