[libvirt] [PATCH v4 0/7] bridge network support enhancement and other network fixes

2015-03-18 Thread Maxim Nestratov
v2-v4 change: Addressed Michal Privoznik's comments Maxim Nestratov (7): parallels: introduce and use string constants for network types and names parallels: fix parallelsLoadNetworks parallels: better bridge network interface support parallels: set correct network adapter device

[libvirt] [PATCH v4 2/7] parallels: fix parallelsLoadNetworks

2015-03-18 Thread Maxim Nestratov
Don't fail initialization of parallels driver if parallelsLoadNetwork fails for optional networks. This can happen when some of them are added manually and configured incompletely. PCS requires only two networks created automatically (named Host-Only and Bridged), others are optional and their

[libvirt] [PATCH v4 5/7] parallels: make E1000 network adapter model default

2015-03-18 Thread Maxim Nestratov
and set adapter model specified in xml Signed-off-by: Maxim Nestratov mnestra...@parallels.com --- src/parallels/parallels_driver.c |7 ++- src/parallels/parallels_sdk.c| 15 +++ 2 files changed, 21 insertions(+), 1 deletions(-) diff --git

[libvirt] [PATCH v4 7/7] parallels: don't prevent domain define if VIR_DOMAIN_NET_TYPE_BRIDGE

2015-03-18 Thread Maxim Nestratov
network adapter is used --- src/parallels/parallels_sdk.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c index 3140757..1a448f1 100644 --- a/src/parallels/parallels_sdk.c +++ b/src/parallels/parallels_sdk.c

[libvirt] [PATCH v4 6/7] parallels: switch off offline management feature

2015-03-18 Thread Maxim Nestratov
which is on by default when a new VM/CT is created. We should do this because this feature can't be controlled by libvirt now and it sets up some iptables rules. So it's better to do this to avoid potential conflict of different set of rules or to avoid unexpected behavior. Signed-off-by: Maxim

[libvirt] [PATCH v4 3/7] parallels: better bridge network interface support

2015-03-18 Thread Maxim Nestratov
In order to support 'bridge' network adapters in parallels driver we need to plug our veth devices into corresponding linux bridges. We are going to do this by reusing our abstraction of Virtual Networks in terms of PCS. On a domain creation, we create a new Virtual Network naming it with the same

[libvirt] [PATCH v4 4/7] parallels: set correct network adapter device state

2015-03-18 Thread Maxim Nestratov
when a new network adapter device is added Signed-off-by: Maxim Nestratov mnestra...@parallels.com --- src/parallels/parallels_sdk.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c index 58c52a8..d699613

[libvirt] [PATCH v4 1/7] parallels: introduce and use string constants for network types and names

2015-03-18 Thread Maxim Nestratov
Signed-off-by: Maxim Nestratov mnestra...@parallels.com --- src/parallels/parallels_network.c |6 +++--- src/parallels/parallels_sdk.c |6 +++--- src/parallels/parallels_utils.h |8 +++- 3 files changed, 13 insertions(+), 7 deletions(-) diff --git

Re: [libvirt] [PATCH] libvirt: move default nwfilters to datadir.

2015-03-18 Thread Dimitri John Ledkov
On 17 March 2015 at 19:04, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Mar 17, 2015 at 06:52:31PM +, Dimitri John Ledkov wrote: libvirt runs correctly without any configuration files, as sensible defaults are used throughout. This commit introduces a layer for nwfilter

[libvirt] Domain XML isn't dumping full backing chain

2015-03-18 Thread Deepak Shetty
Hi, I am using libvirt version 1.2.9.2 on F21 and i am unable to get the complete backing chain info in the virsh dumpxml output. Details below : *My backing chain per qemu-img :* [stack@devstack-f21 test]$ qemu-img info --backing-chain snap4.qcow2 image: snap4.qcow2 file format: qcow2 virtual

Re: [libvirt] [libvirt-test-API][PATCH v2 0/2] Add test cases for setTime and getTime

2015-03-18 Thread hongming
On 03/12/2015 04:10 PM, hujianwei wrote: On 12/03/15 11:11, Jincheng Miao wrote: create some test cases for libvirt-python API setTime and getTime v2: user should pass 'seconds' to set_guest_time, and 'nseconds' is optional. Jincheng Miao (2): Add guest setTime and getTime testing

Re: [libvirt] [PATCH v3 0/7] bridge network support enhancement and other network fixes

2015-03-18 Thread Maxim Nestratov
18.03.2015 10:20, Maxim Nestratov пишет: v3 change: Addressed Michal Privoznik's comments Maxim Nestratov (7): parallels: introduce and use string constants for network types and names parallels: fix parallelsLoadNetworks parallels: better bridge network interface support

Re: [libvirt] [PATCH] tests: Add tests for virCgroupDetectMounts

2015-03-18 Thread Jiri Denemark
On Tue, Mar 17, 2015 at 11:57:20 -0600, Eric Blake wrote: On 03/17/2015 06:39 AM, Jiri Denemark wrote: Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/libvirt_private.syms | 1 + src/util/vircgroup.c | 19 ++-- src/util/vircgrouppriv.h

[libvirt] [PATCH] qemu: Fix two issues in qemuDomainSetVcpus error handling

2015-03-18 Thread John Ferlan
Issue #1 - A call to virBitmapNew did not check if the allocation failed which could lead to a NULL dereference Issue #2 - When deleting the pin entries from the config file, the code loops from the number of elements down to the new vcpu count; however, the pin id values are numbered 0..n-1 not

Re: [libvirt] [PATCH] Use PAUSED state for domains that are starting up

2015-03-18 Thread Jiri Denemark
On Wed, Mar 11, 2015 at 14:20:02 -0600, Jim Fehlig wrote: Jiri Denemark wrote: When libvirt is starting a domain, it reports the state as SHUTOFF until it's RUNNING. This is not ideal because domain startup may take a long time (usually because of some configuration issues, firewalls

Re: [libvirt] [PATCH] libvirt: move default nwfilters to datadir.

2015-03-18 Thread Daniel P. Berrange
On Wed, Mar 18, 2015 at 10:09:53AM +, Dimitri John Ledkov wrote: On 17 March 2015 at 19:04, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Mar 17, 2015 at 06:52:31PM +, Dimitri John Ledkov wrote: libvirt runs correctly without any configuration files, as sensible defaults are

Re: [libvirt] [PATCH] update documentation for command cd

2015-03-18 Thread Michal Privoznik
On 15.03.2015 18:15, swat wrote: Updated the documentation for command cd The documentation for command cd did not have information about the command. Added the required information. --- source/cd.xml | 36 +--- 1 file changed, 33 insertions(+), 3

[libvirt] [PATCH v11] Expose virDomainInterfacesAddresses to python binding

2015-03-18 Thread Daniel P. Berrange
From: Nehal J Wani nehaljw.k...@gmail.com examples/Makefile.am: * Add new file domipaddrs.py examples/README: * Add documentation for the python example libvirt-override-api.xml: * Add new symbol for virDomainInterfacesAddresses libvirt-override.c: * Hand written python api Example:

Re: [libvirt] [PATCH] util: vhost user: support for bootindex

2015-03-18 Thread zhang bo
On 2015/3/13 17:17, zhang bo wrote: Problem Description: When we set boot order for a vhost-user network interface, we found the boot index doesn't work. Cause of the Problem: In the function qemuBuildVhostuserCommandLine(), it forcely set the arg bootindex of function

Re: [libvirt] [test-API][PATCH] Add connection_security_model test case

2015-03-18 Thread hongming
On 03/17/2015 11:49 AM, lcheng wrote: The connection_security_model.py uses getSecurityModel() to validate new API virNodeGetSecurityModel of libvirt. --- cases/linux_domain.conf| 4 ++ repos/virconn/connection_security_model.py | 101 + 2

[libvirt] [PATCH 1/2] conf: parse integers into long long, instead of long

2015-03-18 Thread Daniel P. Berrange
When parsing integer values, we only used 'long' data type in the virConfValue struct. This is insufficiently large to deal with things like guest memory sizes on 32-bit platforms which are using PAE for addressing 4 GB of RAM. --- daemon/libvirtd-config.c | 6 +--

Re: [libvirt] [PATCH] doc: Fix doc for backingStore

2015-03-18 Thread Eric Blake
On 03/18/2015 03:47 AM, Deepak Shetty wrote: I spent quite some time figuring that backingStore info isn't included in the dom xml, unless guest is up and running. Hopefully putting that in the doc should help. This patch adds that info to the doc. Signed-off-by: Deepak C Shetty

[libvirt] [PATCH 2/2] qemu: add a max_core setting to qemu.conf for core dump size

2015-03-18 Thread Daniel P. Berrange
Currently the QEMU processes inherit their core dump rlimit from libvirtd, which is really suboptimal. This change allows their limit to be directly controller from qemu.conf instead. --- src/libvirt_private.syms | 2 ++ src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf

[libvirt] [PATCH 0/2] Support core file limit settings for QEMU

2015-03-18 Thread Daniel P. Berrange
Currently QEMU inherits core size limits from libvirtd which is rather inconvenient Daniel P. Berrange (2): conf: parse integers into long long, instead of long qemu: add a max_core setting to qemu.conf for core dump size daemon/libvirtd-config.c | 6 +--

Re: [libvirt] [PATCH 7/7] parallels: don't prevent domain define if VIR_DOMAIN_NET_TYPE_BRIDGE

2015-03-18 Thread Dmitry Guryanov
On 03/17/2015 05:14 PM, Michal Privoznik wrote: On 13.03.2015 16:52, Maxim Nestratov wrote: network adapter is used --- src/parallels/parallels_sdk.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c index

Re: [libvirt] Domain XML isn't dumping full backing chain

2015-03-18 Thread Shanzhi Yu
- Original Message - | From: Deepak Shetty dpkshe...@gmail.com | To: libvir-list@redhat.com | Sent: Wednesday, March 18, 2015 7:19:05 PM | Subject: [libvirt] Domain XML isn't dumping full backing chain | Hi, | I am using libvirt version 1.2.9.2 on F21 and i am unable to get the complete

Re: [libvirt] [PATCH] qemu: Fix two issues in qemuDomainSetVcpus error handling

2015-03-18 Thread Martin Kletzander
On Wed, Mar 18, 2015 at 07:25:29AM -0400, John Ferlan wrote: Issue #1 - A call to virBitmapNew did not check if the allocation failed which could lead to a NULL dereference Issue #2 - When deleting the pin entries from the config file, the code loops from the number of elements down to the new

Re: [libvirt] Domain XML isn't dumping full backing chain

2015-03-18 Thread Deepak Shetty
Hmm interesting, so without adding backing_fmt, if i enable the below in /etc/libvirt/qemu.conf, will it work ? # If allow_disk_format_probing is enabled, libvirt will probe disk # images to attempt to identify their format, when not otherwise # specified in the XML. This is disabled by default.

Re: [libvirt] Domain XML isn't dumping full backing chain

2015-03-18 Thread Eric Blake
On 03/18/2015 07:03 AM, Deepak Shetty wrote: [please don't top-post on technical lists] Hmm interesting, so without adding backing_fmt, if i enable the below in /etc/libvirt/qemu.conf, will it work ? # If allow_disk_format_probing is enabled, libvirt will probe disk # images to attempt to

[libvirt] [PATCH] Add vircgroupdata dir to tests/Makefile.am

2015-03-18 Thread Nehal J Wani
The folder vircgroupdata was introduced in commit 2dbfa716 as part of the test suite for virCgroupDetectMounts --- tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index 9277c13..27cee63 100644 --- a/tests/Makefile.am +++

Re: [libvirt] Domain XML isn't dumping full backing chain

2015-03-18 Thread Kashyap Chamarthy
On Wed, Mar 18, 2015 at 07:21:22AM -0600, Eric Blake wrote: On 03/18/2015 07:03 AM, Deepak Shetty wrote: [please don't top-post on technical lists] Hmm interesting, so without adding backing_fmt, if i enable the below in /etc/libvirt/qemu.conf, will it work ? # If

[libvirt] [PATCH] maint: Distribute tests/vircgroupdata

2015-03-18 Thread Jiri Denemark
My commit 2dbfa71 added test data for vircgrouptest but forgot to distribute the new directory. Signed-off-by: Jiri Denemark jdene...@redhat.com --- Pushed as a build-breaker. tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index

Re: [libvirt] [PATCH v4 2/7] parallels: fix parallelsLoadNetworks

2015-03-18 Thread Michal Privoznik
On 18.03.2015 09:33, Maxim Nestratov wrote: Don't fail initialization of parallels driver if parallelsLoadNetwork fails for optional networks. This can happen when some of them are added manually and configured incompletely. PCS requires only two networks created automatically (named

Re: [libvirt] [PATCH v4 3/7] parallels: better bridge network interface support

2015-03-18 Thread Michal Privoznik
On 18.03.2015 09:33, Maxim Nestratov wrote: In order to support 'bridge' network adapters in parallels driver we need to plug our veth devices into corresponding linux bridges. We are going to do this by reusing our abstraction of Virtual Networks in terms of PCS. On a domain creation, we

Re: [libvirt] [PATCH v4 5/7] parallels: make E1000 network adapter model default

2015-03-18 Thread Michal Privoznik
On 18.03.2015 09:33, Maxim Nestratov wrote: and set adapter model specified in xml Signed-off-by: Maxim Nestratov mnestra...@parallels.com --- src/parallels/parallels_driver.c |7 ++- src/parallels/parallels_sdk.c| 15 +++ 2 files changed, 21 insertions(+), 1

Re: [libvirt] [PATCH] util: vhost user: support for bootindex

2015-03-18 Thread Michal Privoznik
On 13.03.2015 10:17, zhang bo wrote: Problem Description: When we set boot order for a vhost-user network interface, we found the boot index doesn't work. Cause of the Problem: In the function qemuBuildVhostuserCommandLine(), it forcely set the arg bootindex of function

[libvirt] [PATCH] util: more verbose error when failing to create macvtap device

2015-03-18 Thread Laine Stump
Investigation of a problem with creating passthrough macvtap devices (https://bugzilla.redhat.com/show_bug.cgi?id=1185501) has shown that this slightly more verbose failure message is useful. In particular, the mac address can be used to determine the domain. You could also figure this out by

[libvirt] qemu_migration: Precreate missing storage breaks with network drives

2015-03-18 Thread Noel Burton-Krahn
Hi Michal, We're testing libvirt-1.2.13 and found it failed to live migrate domains with attached network drives. The change to libvirt was made in commit cf54c606, announced here: https://www.redhat.com/archives/libvir-list/2014-November/msg01053.html It's not necessary to precreate network

[libvirt] [PATCH v3 0/7] bridge network support enhancement and other network fixes

2015-03-18 Thread Maxim Nestratov
v3 change: Addressed Michal Privoznik's comments Maxim Nestratov (7): parallels: introduce and use string constants for network types and names parallels: fix parallelsLoadNetworks parallels: better bridge network interface support parallels: set correct network adapter device state

[libvirt] [PATCH 2/7] parallels: fix parallelsLoadNetworks

2015-03-18 Thread Maxim Nestratov
Don't fail initialization of parallels driver if parallelsLoadNetwork fails for optional networks. This can happen when some of them are added manually and configured incompletely. PCS requires only two networks created automatically (named Host-Only and Bridged), others are optional and their

[libvirt] [PATCH 3/7] parallels: better bridge network interface support

2015-03-18 Thread Maxim Nestratov
In order to support 'bridge' network adapters in parallels driver we need to plug our veth devices into corresponding linux bridges. We are going to do this by reusing our abstraction of Virtual Networks in terms of PCS. On a domain creation, we create a new Virtual Network naming it with the same

[libvirt] [PATCH 1/7] parallels: introduce and use string constants for network types and names

2015-03-18 Thread Maxim Nestratov
Signed-off-by: Maxim Nestratov mnestra...@parallels.com --- src/parallels/parallels_network.c |6 +++--- src/parallels/parallels_sdk.c |6 +++--- src/parallels/parallels_utils.h |8 +++- 3 files changed, 13 insertions(+), 7 deletions(-) diff --git

[libvirt] [PATCH 4/7] parallels: set correct network adapter device state

2015-03-18 Thread Maxim Nestratov
when a new network adapter device is added Signed-off-by: Maxim Nestratov mnestra...@parallels.com --- src/parallels/parallels_sdk.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c index 58c52a8..d699613

[libvirt] [PATCH 7/7] parallels: don't prevent domain define if VIR_DOMAIN_NET_TYPE_BRIDGE

2015-03-18 Thread Maxim Nestratov
network adapter is used --- src/parallels/parallels_sdk.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c index 465cc41..fb75d2d 100644 --- a/src/parallels/parallels_sdk.c +++ b/src/parallels/parallels_sdk.c

[libvirt] [PATCH 5/7] parallels: make E1000 network adapter model default

2015-03-18 Thread Maxim Nestratov
and set adapter model specified in xml Signed-off-by: Maxim Nestratov mnestra...@parallels.com --- src/parallels/parallels_driver.c |7 ++- src/parallels/parallels_sdk.c| 17 + 2 files changed, 23 insertions(+), 1 deletions(-) diff --git

[libvirt] [PATCH 6/7] parallels: switch off offline management feature

2015-03-18 Thread Maxim Nestratov
which is on by default when a new VM/CT is created. We should do this because this feature can't be controlled by libvirt now and it sets up some iptables rules. So it's better to do this to avoid potential conflict of different set of rules or to avoid unexpected behavior. Signed-off-by: Maxim

Re: [libvirt] [PATCH 5/7] parallels: make E1000 network adapter model default

2015-03-18 Thread Maxim Nestratov
18.03.2015 10:20, Maxim Nestratov пишет: and set adapter model specified in xml Signed-off-by: Maxim Nestratov mnestra...@parallels.com --- src/parallels/parallels_driver.c |7 ++- src/parallels/parallels_sdk.c| 17 + 2 files changed, 23 insertions(+), 1

[libvirt] [PATCH] libxl: use xenlight pkgconfig file if present

2015-03-18 Thread Jim Fehlig
xen.git commit babeca32 added a pkgconfig file for libxenlight, allowing libxl apps to determine the location of Xen binaries such as firmware blobs, device emulator, etc. This patch adds support for xenlight.pc in the libxl driver, falling back to the previous configure logic if not found. It

Re: [libvirt] qemu_migration: Precreate missing storage breaks with network drives

2015-03-18 Thread Nick Bartos
Actually I messed that up slightly on the case. My C is a bit rusty: diff -U3 -r libvirt-1.2.13.orig/src/qemu/qemu_migration.c libvirt-1.2.13/src/qemu/qemu_migration.c --- libvirt-1.2.13.orig/src/qemu/qemu_migration.c 2015-02-23 22:04:12.0 -0800 +++

[libvirt] [PATCH] libxl: Don't overwrite errors from xenconfig

2015-03-18 Thread Jim Fehlig
When converting domXML from native, the libxl driver was overwriting useful errors from the xenconfig parsing code with a useless, generic error. E.g. internal error: parsing xm config failed vs internal error: config value usbdevice was malformed. Remove the redundant (and useless) error

Re: [libvirt] [PATCH] libxl: Don't overwrite errors from xenconfig

2015-03-18 Thread Eric Blake
On 03/18/2015 04:21 PM, Jim Fehlig wrote: When converting domXML from native, the libxl driver was overwriting useful errors from the xenconfig parsing code with a useless, generic error. E.g. internal error: parsing xm config failed vs internal error: config value usbdevice was malformed.

[libvirt] [PATCH] qemu: fix sometimes error overwrite when we fail to start/migrate/restore

2015-03-18 Thread Luyao Huang
https://bugzilla.redhat.com/show_bug.cgi?id=1196934 When start/migrate/restore a vm failed, libvirt will try to catch the log in /var/log/libvirt/qemu/vm.log and output them before. However we add a check in qemuDomainObjExitMonitor after commit dc2fd51f, this will overwrite the error set in

Re: [libvirt] [PATCH] libxl: Don't overwrite errors from xenconfig

2015-03-18 Thread Jim Fehlig
Eric Blake wrote: On 03/18/2015 04:21 PM, Jim Fehlig wrote: When converting domXML from native, the libxl driver was overwriting useful errors from the xenconfig parsing code with a useless, generic error. E.g. internal error: parsing xm config failed vs internal error: config value

Re: [libvirt] [PATCH] util: more verbose error when failing to create macvtap device

2015-03-18 Thread Michal Privoznik
On 18.03.2015 19:30, Laine Stump wrote: Investigation of a problem with creating passthrough macvtap devices (https://bugzilla.redhat.com/show_bug.cgi?id=1185501) has shown that this slightly more verbose failure message is useful. In particular, the mac address can be used to determine the

Re: [libvirt] [PATCH v4 0/7] bridge network support enhancement and other network fixes

2015-03-18 Thread Michal Privoznik
On 18.03.2015 09:33, Maxim Nestratov wrote: v2-v4 change: Addressed Michal Privoznik's comments Maxim Nestratov (7): parallels: introduce and use string constants for network types and names parallels: fix parallelsLoadNetworks parallels: better bridge network interface

Re: [libvirt] [PATCH v4 4/7] parallels: set correct network adapter device state

2015-03-18 Thread Michal Privoznik
On 18.03.2015 09:33, Maxim Nestratov wrote: when a new network adapter device is added s/device/link/ in $SUBJ. Signed-off-by: Maxim Nestratov mnestra...@parallels.com --- src/parallels/parallels_sdk.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH v4 0/7] bridge network support enhancement and other network fixes

2015-03-18 Thread Maxim Nestratov
18.03.2015 20:34, Michal Privoznik пишет: I've fixed all the nits I've found, ACKed and pushed whole series. Thank you! One more thing though, look at the rest of our commit messages. They usually consist of small subject, and start freshly with new sentence. For some reason we don't like if

Re: [libvirt] [PATCH] Add vircgroupdata dir to tests/Makefile.am

2015-03-18 Thread Eric Blake
On 03/18/2015 08:04 AM, Nehal J Wani wrote: The folder vircgroupdata was introduced in commit 2dbfa716 as part of the test suite for virCgroupDetectMounts --- tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) NACK; it was already added several lines later (after virsh-uriprecedence)

[libvirt] [libvirt-cmdref PATCH] Adding Documentation for cd

2015-03-18 Thread Swaathi Ramesh
The documentation for command cd did not have information about the command. Added the required information. --- source/cd.xml | 38 ++ 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/source/cd.xml b/source/cd.xml index 78a13df..d15c74c 100644

Re: [libvirt] [PATCH v2] doc: Fix doc for backingStore

2015-03-18 Thread Eric Blake
On 03/18/2015 07:48 AM, Deepak Shetty wrote: I spent quite some time figuring that backingStore info isn't included in the dom xml, unless guest is up and running. Hopefully putting that in the doc should help. This patch adds that info to the doc. Signed-off-by: Deepak C Shetty

Re: [libvirt] [PATCH] qemu: track 'cancelling' migration state

2015-03-18 Thread Eric Blake
On 03/09/2015 03:07 AM, Jiri Denemark wrote: On Fri, Mar 06, 2015 at 09:34:59 -0700, Eric Blake wrote: In qemu 2.3, the migration status will include 'cancelling' in the window between when an asynchronous cancel has been requested and when the migration is actually halted. Previously, qemu