Hi All,
This patch needs some rework as the Makefile.am change would result in
build failures
on virhostdev.h and virclosecallbacks.h. It didnt fail for me earlier
as the autogen was run
prior to the changes.
I'll be sending a v2 with the fixes for build failures.
Thanks,
Shiva
On Wed, Mar 11,
On 03/17/2015 10:19 AM, Peter Krempa wrote:
Add support to start qemu instance with 'pc-dimm' device. Thanks to the
refactors we are able to reuse the existing function to determine the
parameters.
---
Notes:
Version 2:
- dropped the ACPI naming
src/qemu/qemu_command.c
On 03/17/2015 10:20 AM, Peter Krempa wrote:
Add code to hot-add memory devices to running qemu instances.
---
Notes:
Version 3:
- added comment to clarify that @mem is always consumed by
qemuDomainAttachMemory
Version 2:
- no change
Version 2:
- no
On 03/11/2015 08:39 AM, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/libvirt_private.syms | 2 ++
src/util/vircgroup.c | 42 +-
src/util/vircgroup.h | 5 -
3 files changed, 47 insertions(+), 2
On 03/17/2015 10:19 AM, Peter Krempa wrote:
This version includes review feedback changes from John and also fixes the
memory element documentation and code that calculates it to support
possible
non-NUMA configs with memory hotplug if any hypervisor would support that in
the
future.
On 03/18/2015 01:51 AM, Zhu Guihua wrote:
On 03/17/2015 10:19 PM, Peter Krempa wrote:
Add a few helpers that allow to operate with memory device definitions
on the domain config and use them to implement memory device coldplug in
the qemu driver.
---
Notes:
Version 2:
- no
Michal Privoznik wrote:
On 18.03.2015 23:25, Jim Fehlig wrote:
xen.git commit babeca32 added a pkgconfig file for libxenlight,
allowing libxl apps to determine the location of Xen binaries
such as firmware blobs, device emulator, etc.
This patch adds support for xenlight.pc in the libxl
On 03/19/2015 05:11 PM, John Ferlan wrote:
+int
+virCgroupSetCpusetMemoryMigrate(virCgroupPtr group, bool migrate)
+{
+return virCgroupSetValueStr(group,
+VIR_CGROUP_CONTROLLER_CPUSET,
+cpuset.memory_migrate,
+
On 03/11/2015 08:39 AM, Martin Kletzander wrote:
We've never set the cpuset.memory_migrate value to anything, keeping it
on default. However, we allow changing cpuset.mems on live domain.
That setting, however, don't have any consequence on a domain unless
it's going to allocate new memory.
On 03/19/2015 01:42 PM, Steven Walter wrote:
Presently attaching a host device to the pcie-root controller fails, even if
the host device is actually a PCIe device. With this change, the attachment
succeeds, QEMU is happy, and the guest correctly sees the host device as a
child of the PCIe
On 03/19/2015 05:27 PM, Ján Tomko wrote:
On Thu, Mar 19, 2015 at 11:14:39AM +0800, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1196934
Adding a comment in the bugzilla saying you posted a patch (with a link
to libvir-list archives) can be helpful. Otherwise they might send
On Wed, Mar 18, 2015 at 5:33 PM, Shanzhi Yu s...@redhat.com wrote:
--
*From: *Deepak Shetty dpkshe...@gmail.com
*To: *libvir-list@redhat.com
*Sent: *Wednesday, March 18, 2015 7:19:05 PM
*Subject: *[libvirt] Domain XML isn't dumping full backing chain
Hi,
I
On Fri, 13 Mar 2015, Michael Chapman wrote:
Commit cf54c60699833b3791a5d0eb3eb5a1948c267f6b introduced the ability
to create missing storage volumes during migration. For network disks,
however, we may not necessarily be able to detect whether they already
exist -- there is no straight-forward
On Thu, Mar 19, 2015 at 11:14:39AM +0800, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1196934
Adding a comment in the bugzilla saying you posted a patch (with a link
to libvir-list archives) can be helpful. Otherwise they might send the
exact same patch - if your was not
5bba61f introduce a issue : when start a vm with numa settings and
restart libvirtd, numa settings will disappear. Because when parse the
vm states file, there is no node in /domain/cpu/numa this place.
Change to use ./cpu/numa instead of /domain/cpu/numa.
Signed-off-by: Luyao Huang
Hello,
according to libvirt documentation, when using hostdev with USB device
...the user is responsible to call virNodeDeviceDettach (or virsh
nodedev-detach)
before starting the guest In libvirt-1.2.13-1.el7.x86_64, this leads to
virsh nodedev-detach usb_usb1
error: Failed to detach
On Thu, Mar 19, 2015 at 06:12:44AM -0400, Martin Polednik wrote:
Hello,
according to libvirt documentation, when using hostdev with USB device
...the user is responsible to call virNodeDeviceDettach (or virsh
nodedev-detach)
before starting the guest In libvirt-1.2.13-1.el7.x86_64,
On 18.03.2015 22:00, Nick Bartos wrote:
Actually I messed that up slightly on the case. My C is a bit rusty:
diff -U3 -r libvirt-1.2.13.orig/src/qemu/qemu_migration.c
libvirt-1.2.13/src/qemu/qemu_migration.c
--- libvirt-1.2.13.orig/src/qemu/qemu_migration.c2015-02-23
22:04:12.0
PCS doesn't store domain config in managed save state file.
It's forbidden to change config for VMs in this state.
It's possible to change config for containers, but after
restoring domain will have that new config, not a config,
which domain had at the moment of virDomainManagedSave.
So we need
This patch series is intended to implement all needed code, so
that suspend/resume in openstack nova will work.
It implements .domainHasManagedSaveImage, .domainManagedSave
and .domainManagedSaveRemove functions. Also it adds
workaround to parallelsDomainDefineXMLFlags to skip
applying
Call virDomainDefAddImplicitControllers to add disk
controllers, so virDomainDef, filled by this function
will look exactly like the one returned by virDomainDefParseString.
Signed-off-by: Dmitry Guryanov dgurya...@parallels.com
---
src/parallels/parallels_sdk.c | 3 +++
1 file changed, 3
When retriving list of domains from PCS, set
readonly flag for cdrom devices.
Signed-off-by: Dmitry Guryanov dgurya...@parallels.com
---
src/parallels/parallels_sdk.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/parallels/parallels_sdk.c
Implement virDomainManagedSave api function. In PCS
this feature called suspend. You can suspend VM or
CT while it is in running or paused state. And after
resuming (or starting) it will have the same state, as
before suspend.
Signed-off-by: Dmitry Guryanov dgurya...@parallels.com
---
Return value of functions prlsdkStart/Kill/Stop e.t.c.
is PRL_RESULT in parallels_sdk.c and int in parallels_sdk.h.
PRL_RESULT is int, so compiler didn't report errors.
Let's fix the difference.
Signed-off-by: Dmitry Guryanov dgurya...@parallels.com
---
src/parallels/parallels_sdk.h | 10
Split function prlsdkDomainChangeState into
prlsdkDomainChangeStateLocked and prlsdkDomainChangeState.
So it can be used from places, where virDomainObj already
found and locked.
Signed-off-by: Dmitry Guryanov dgurya...@parallels.com
---
src/parallels/parallels_sdk.c | 35
On 03/20/2015 06:39 AM, John Ferlan wrote:
On 03/18/2015 01:51 AM, Zhu Guihua wrote:
On 03/17/2015 10:19 PM, Peter Krempa wrote:
Add a few helpers that allow to operate with memory device definitions
on the domain config and use them to implement memory device coldplug in
the qemu driver.
-Original Message-
From: Richard Weinberger [mailto:rich...@nod.at]
Sent: Friday, March 20, 2015 1:41 AM
To: Daniel P. Berrange
Cc: Chen, Hanxiao/陈 晗霄; libvir-list@redhat.com
Subject: Re: [libvirt] [PATCH] LXC: create a bind mount for sysfs when enable
userns
but disable netns
Am 11.03.2015 um 10:36 schrieb Richard Weinberger:
Am 11.03.2015 um 03:30 schrieb Chen, Hanxiao:
@@ -826,8 +829,25 @@ static int lxcContainerMountBasicFS(bool
userns_enabled)
bool bindOverReadonly;
virLXCBasicMountInfo const *mnt = lxcBasicMounts[i];
+/* When
Impending IOThread setting patches would copy the code anyway, so create
and generalize the adding of pindef for the vcpu into its own API
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/qemu/qemu_driver.c | 104 +
1 file changed, 62
On Thu, Mar 19, 2015 at 06:04:57PM +0100, Richard Weinberger wrote:
Am 19.03.2015 um 17:58 schrieb Daniel P. Berrange:
On Thu, Mar 19, 2015 at 05:54:32PM +0100, Richard Weinberger wrote:
Am 11.03.2015 um 10:36 schrieb Richard Weinberger:
Am 11.03.2015 um 03:30 schrieb Chen, Hanxiao:
@@
On Mon, Mar 16, 2015 at 10:24:51AM +, Daniel P. Berrange wrote:
On Fri, Mar 13, 2015 at 04:09:57PM -0300, Eduardo Habkost wrote:
With the Intel microcode update that removed HLE and RTM, there will be
different kinds of Haswell and Broadwell CPUs out there: some that still
have the HLE
2015-02-27 16:38 GMT+03:00 Vasiliy Tolstov v.tols...@selfip.ru:
If a user specify ehernet device create it via libvirt and run
script if it provided. After this commit user does not need to
run external script to create tap device or add root to qemu
process.
Signed-off-by: Vasiliy Tolstov
Hello,
It's not possible to start LXC container inside user namespace with root
filesystem on loop device, because it tries to mount root FS from
container's user namespace (lxcContainerSetupPivotRoot) and gets EPERM:
2015-03-19 12:48:18.545+: 1: debug : lxcContainerChild:2278 :
Tearing
From: Nehal J Wani nehaljw.k...@gmail.com
examples/Makefile.am:
* Add new file domipaddrs.py
examples/README:
* Add documentation for the python example
libvirt-override-api.xml:
* Add new symbol for virDomainInterfacesAddresses
libvirt-override.c:
* Hand written python api
Example:
On Wed, Mar 18, 2015 at 10:32:54AM +, Daniel P. Berrange wrote:
From: Nehal J Wani nehaljw.k...@gmail.com
examples/Makefile.am:
* Add new file domipaddrs.py
examples/README:
* Add documentation for the python example
libvirt-override-api.xml:
* Add new symbol for
Add the necessary remote plumbing
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/remote/remote_driver.c | 1 +
src/remote/remote_protocol.x | 16 +++-
src/remote_protocol-structs | 6 ++
3 files changed, 22 insertions(+), 1 deletion(-)
diff --git
Impending IOThread setting patches would copy the code anyway, so create
and generalize a delete cgroup and pindef for the vcpu into its own API.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/qemu/qemu_driver.c | 40
1 file changed, 28
Impending IOThread setting patches would copy the code anyway, so create
and generalize the add the vcpu to a cgroup into its own API.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/qemu/qemu_driver.c | 69 +++---
1 file changed, 48
Am 19.03.2015 um 18:28 schrieb Daniel P. Berrange:
On Thu, Mar 19, 2015 at 06:04:57PM +0100, Richard Weinberger wrote:
Am 19.03.2015 um 17:58 schrieb Daniel P. Berrange:
On Thu, Mar 19, 2015 at 05:54:32PM +0100, Richard Weinberger wrote:
Am 11.03.2015 um 10:36 schrieb Richard Weinberger:
Am
Presently attaching a host device to the pcie-root controller fails, even if
the host device is actually a PCIe device. With this change, the attachment
succeeds, QEMU is happy, and the guest correctly sees the host device as a
child of the PCIe root.
---
src/qemu/qemu_command.c | 7 +++
1
Am 19.03.2015 um 17:58 schrieb Daniel P. Berrange:
On Thu, Mar 19, 2015 at 05:54:32PM +0100, Richard Weinberger wrote:
Am 11.03.2015 um 10:36 schrieb Richard Weinberger:
Am 11.03.2015 um 03:30 schrieb Chen, Hanxiao:
@@ -826,8 +829,25 @@ static int lxcContainerMountBasicFS(bool
https://bugzilla.redhat.com/show_bug.cgi?id=1161617
Add command to allow adding and removing IOThreads from the domain including
the configuration and live domain.
$ virsh setiothreads --help
NAME
setiothreads - change number of IOThreads
SYNOPSIS
setiothreads domain count
Add virDomainIOThreadsSet to allow setting the number of IOThreads for
a domain.
The API supports updating both the --live domain and the --config data.
Signed-off-by: John Ferlan jfer...@redhat.com
---
include/libvirt/libvirt-domain.h | 3 ++
src/driver-hypervisor.h | 6
Add qemuDomainSetIOThreads in order to adjust the live and config IOThread
values for the domain similar to the qemuDomainSetVcpus implementation.
The qemuDomainHotplugIOThread will more or less mirror qemuDomainHotplugVcpus
including usage of the recently extracted API's to manage the cgroup and
On Thu, Mar 19, 2015 at 05:54:32PM +0100, Richard Weinberger wrote:
Am 11.03.2015 um 10:36 schrieb Richard Weinberger:
Am 11.03.2015 um 03:30 schrieb Chen, Hanxiao:
@@ -826,8 +829,25 @@ static int lxcContainerMountBasicFS(bool
userns_enabled)
bool bindOverReadonly;
These patches will implement the Set IOThreads command to complete
the IOThreads family of calls/settings. There are 3 patches in the
middle (3, 4, 5) which are just refactoring the SetVcpus code so
that the SetIOThreads code can make use of the same functionality
rather than cut-n-paste
John
On Thu, Mar 19, 2015 at 03:02:27PM -0300, Eduardo Habkost wrote:
On Mon, Mar 16, 2015 at 10:24:51AM +, Daniel P. Berrange wrote:
On Fri, Mar 13, 2015 at 04:09:57PM -0300, Eduardo Habkost wrote:
With the Intel microcode update that removed HLE and RTM, there will be
different kinds of
If, by any reason, parallelsNetworkOpen fails it dereferences
newly allocated privconn-networks via virObjectUnref, which in
turn deallocates its memory.
Subsequent call of parallelsNetworkClose calls virObjectUnref
that leads to double memory free. To prevent this we should zero
privconn-networks
On Wed, Mar 18, 2015 at 04:25:41PM -0600, Jim Fehlig wrote:
xen.git commit babeca32 added a pkgconfig file for libxenlight,
allowing libxl apps to determine the location of Xen binaries
such as firmware blobs, device emulator, etc.
This patch adds support for xenlight.pc in the libxl driver,
If, by any reason, parallelsNetworkClose fails it dereferences
newly allocated privconn-networks via virObjectUnref, which in
turn deallocates its memory.
Subsequent call of parallelsNetworkClose calls virObjectUnref
that leads to double memory free. To prevent this we should zero
On 03/19/2015 01:08 PM, John Ferlan wrote:
Impending IOThread setting patches would copy the code anyway, so create
and generalize the adding of pindef for the vcpu into its own API
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/qemu/qemu_driver.c | 104
The IKeyboard COM object is needed to implement virDomainSendKey and is
available in all supported VBOX versions.
---
src/vbox/vbox_tmpl.c | 27 +++
src/vbox/vbox_uniformed_api.h | 8
2 files changed, 35 insertions(+)
diff --git a/src/vbox/vbox_tmpl.c
Since the holdtime is not supported by VBOX SDK, it's being simulated
by sleeping before sending the key-up codes. The key-up codes are
auto-generated based on XT codeset rules (adding of 0x80 to key-down)
which results in the same behavior as for QEMU implementation.
---
src/vbox/vbox_common.c |
Hello,
Those small patches implement virDomainSendKey support in VBOX driver. However,
the VBOX SDK does not support holdtime so I used usleep to wait for that time
before sending key-up scancodes. This makes it behave similarly to QEMU
driver, however I'm not sure if that way of handling this
On 18.03.2015 23:25, Jim Fehlig wrote:
xen.git commit babeca32 added a pkgconfig file for libxenlight,
allowing libxl apps to determine the location of Xen binaries
such as firmware blobs, device emulator, etc.
This patch adds support for xenlight.pc in the libxl driver, falling
back to the
On 19.03.2015 16:29, Nick Bartos wrote:
That sounds like a reasonable option. How far back is the shared disk
type supported? As of Icehouse (the oldest supported version I
believe), the minimum supported libvirt version is 0.9.6. It would be
simpler if it could be a simple change that
On 19.03.2015 15:36, Maxim Nestratov wrote:
If, by any reason, parallelsNetworkClose fails it dereferences
newly allocated privconn-networks via virObjectUnref, which in
turn deallocates its memory.
Subsequent call of parallelsNetworkClose calls virObjectUnref
that leads to double memory
On 19.03.2015 15:43, Maxim Nestratov wrote:
If, by any reason, parallelsNetworkOpen fails it dereferences
newly allocated privconn-networks via virObjectUnref, which in
turn deallocates its memory.
Subsequent call of parallelsNetworkClose calls virObjectUnref
that leads to double memory free.
Since we haven't implemented balloon parameters tuning
we can just return amount of memory in this function.
Signed-off-by: Dmitry Guryanov dgurya...@parallels.com
---
src/parallels/parallels_driver.c | 19 +++
1 file changed, 19 insertions(+)
diff --git
That sounds like a reasonable option. How far back is the shared disk type
supported? As of Icehouse (the oldest supported version I believe), the
minimum supported libvirt version is 0.9.6. It would be simpler if it
could be a simple change that doesn't have to be if/else'd for different
That does sound like the best option then. Would you mind proposing a nova
patch?
On Thu, Mar 19, 2015 at 8:37 AM, Michal Privoznik mpriv...@redhat.com
wrote:
On 19.03.2015 16:29, Nick Bartos wrote:
That sounds like a reasonable option. How far back is the shared disk
type supported? As
Right. I sent this by a mistake and then asked to ignore it.
Thank you.
Maxim
-Original Message-
From: Michal Privoznik [mailto:mpriv...@redhat.com]
Sent: Thursday, March 19, 2015 6:41 PM
To: Maxim Nestratov; libvir-list@redhat.com
Subject: Re: [libvirt] [PATCH] parallels: fix
62 matches
Mail list logo
