On 28.03.2015 12:49, John Ferlan wrote:
> Signed-off-by: John Ferlan
> ---
> Changes | 1 +
> Virt.xs | 1 +
> lib/Sys/Virt/Error.pm | 4
> 3 files changed, 6 insertions(+)
>
> diff --git a/Changes b/Changes
> index 7a2bc51..1849668 100644
> --- a/Changes
> +++ b
On 27.03.2015 10:56, Luyao Huang wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1206479
>
>>From our manual of virsh and qemu side code, we know this
> value must be power of 2, so instead of let qemu output error,
> we can add a check when we file this value in qemuDomainBlockCopy.
>
> Sig
On 28.03.2015 19:31, Cole Robinson wrote:
> ---
> diff --git a/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem
> b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0/subsystem
> new file mode 12
> index 000..758c291
> --- /dev/null
> +++ b/tests/nodeinfodata/linux-f21-mustang/cpu/cpu0
On 04/01/2015 04:12 PM, Michal Privoznik wrote:
On 27.03.2015 10:56, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1206479
>From our manual of virsh and qemu side code, we know this
value must be power of 2, so instead of let qemu output error,
we can add a check when we file
The 7c3c7f217ebae5 commit introduced a nodeinfo test. In order to do
that, some parts of sysfs had to be copied. However, sysfs is full of
symlinks, so during copying some symlinks broke. Remove them, as on
different systems they can point to different files or be broken.
Signed-off-by: Michal Pri
On Mon, Mar 30, 2015 at 09:01:37PM +0200, Peter Krempa wrote:
From: Luyao Huang
qemuDomainSetMemoryFlags() would allow to set the initial memory greater
than the field. While the configuration would not work as
memory hotplug requires NUMA to be enabled and the
qemuDomainSetMemoryFlags() API d
When we shutdown/reboot a guest using agent-mode, if the guest itself blocks
infinitely,
libvirt would block in qemuAgentShutdown() forever.
Thus, we set a timeout for shutdown/reboot, from our experience, 60 seconds
would be fine.
Signed-off-by: Zhang Bo
Signed-off-by: Wang Yufei
---
include
On 31.03.2015 14:39, Matthias Gatto wrote:
> On Tue, Mar 17, 2015 at 8:25 PM, Matthias Gatto
> wrote:
>> The purpose of these patches is to introduce quorum for libvirt
>> I've try to follow this proposal:
>> http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html
>>
>> This feature ask
HI,
Does anyone hit this issue when compiling libvirt?
CCLD libvirt.la
CC libvirt_qemu_la-libvirt-qemu.lo
CCLD libvirt-qemu.la
CC libvirt_lxc_la-libvirt-lxc.lo
CCLD libvirt-lxc.la
CC lockd_la-lock_driver_lockd.lo
CC lockd_la-lock_protocol.lo
CCL
On Wed, Mar 25, 2015 at 02:08:34PM -0600, Jim Fehlig wrote:
Let callers of libxlDomainStart decide when it is appropriate to
acquire a job on the associated virDomainObj.
This makes sense, I see many bugs this fixes, but how come
libxlDomainShutdownThread(), libxlDomainRestoreFlags() and
libxl
On Thu, Mar 26, 2015 at 03:29:51PM -0600, Jim Fehlig wrote:
Konrad Rzeszutek Wilk wrote:
On Wed, Mar 25, 2015 at 02:08:35PM -0600, Jim Fehlig wrote:
A job should be acquired at the beginning of a domain destroy operation,
not at the end when cleaning up the domain. Fix two occurances of this
---
src/libvirt-domain.c | 13 +++--
src/libvirt.c| 4 ++--
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index f1608dc..4a45b9e 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -2613,7 +2613,7 @@ virDomai
On 01.04.2015 12:13, Noella Ashu wrote:
>
We tend to do different formatting of commit messages. If you do 'git log'
you'll immediately get a picture.
> ---
> src/libvirt-domain.c | 13 +++--
> src/libvirt.c| 4 ++--
> 2 files changed, 9 insertions(+), 8 deletions(-)
>
> diff
Hello,
>
> We tend to do different formatting of commit messages. If you do 'git log'
> you'll immediately get a picture.
I see, forgot to check the previous commits first before doing mine. My
bad, will do better next time.
>
> The idea of the bug report is to do something like this:
>
> dif
The nodedev-detach can report the name of the domain using the device
just the way nodedev-reattach does it.
Signed-off-by: Shivaprasad G Bhat
---
src/util/virhostdev.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c
index 23365a3..55eb
The error output of snapshot-revert should be more friendly. There is no
need to show up virDomainRevertToSnapshot to user. virError already includes
__FUNCTION__ information in a separate member of the struct, so repeating
it in the message is redundant and leads to situations where higher level
On Wed, Apr 01, 2015 at 11:01:11AM +0200, Michal Privoznik wrote:
The 7c3c7f217ebae5 commit introduced a nodeinfo test. In order to do
that, some parts of sysfs had to be copied. However, sysfs is full of
symlinks, so during copying some symlinks broke. Remove them, as on
different systems they c
On 01.04.2015 15:02, Martin Kletzander wrote:
> On Wed, Apr 01, 2015 at 11:01:11AM +0200, Michal Privoznik wrote:
>> The 7c3c7f217ebae5 commit introduced a nodeinfo test. In order to do
>> that, some parts of sysfs had to be copied. However, sysfs is full of
>> symlinks, so during copying some syml
On 03/31/2015 07:57 AM, Ján Tomko wrote:
> On Mon, Mar 30, 2015 at 07:16:34PM -0400, John Ferlan wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1171933
>>
>> After processing all the LU's and find no "real" LU's - check if perhaps
>> the cause of that was a poorly formed 'target.path'. The
On Wed, Apr 01, 2015 at 03:30:50PM +0200, Michal Privoznik wrote:
On 01.04.2015 15:02, Martin Kletzander wrote:
On Wed, Apr 01, 2015 at 11:01:11AM +0200, Michal Privoznik wrote:
The 7c3c7f217ebae5 commit introduced a nodeinfo test. In order to do
that, some parts of sysfs had to be copied. Howe
The 7c3c7f217ebae5 and f5c2d6 commits introduced a nodeinfo test.
In order to do that, some parts of sysfs had to be copied.
However, sysfs is full of symlinks, so during copying some
symlinks broke. Remove them, as on different systems they can
point to different files or be broken. At the same ti
On 04/01/2015 10:12 AM, Michal Privoznik wrote:
> The 7c3c7f217ebae5 and f5c2d6 commits introduced a nodeinfo test.
> In order to do that, some parts of sysfs had to be copied.
> However, sysfs is full of symlinks, so during copying some
> symlinks broke. Remove them, as on different systems they c
On Wed, Apr 01, 2015 at 04:12:18PM +0200, Michal Privoznik wrote:
The 7c3c7f217ebae5 and f5c2d6 commits introduced a nodeinfo test.
In order to do that, some parts of sysfs had to be copied.
However, sysfs is full of symlinks, so during copying some
symlinks broke. Remove them, as on different sy
No longer needed after commit dd47723
---
daemon/libvirtd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 55acee2..107b88d 100644
--- a/daemon/libvirtd.c
+++ b/daemon/libvirtd.c
@@ -105,7 +105,6 @@
#include "configmake.h"
#include "virdbus.h"
-#
Unused since commit bc2f42a0.
Move it under the WITHOUT_DRIVER_MODULES #ifdef
and start using it again.
---
src/driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/driver.c b/src/driver.c
index db03438..2985538 100644
--- a/src/driver.c
+++ b/src/driver.c
@@ -35,1
First two patches are a result of compiling with -Wunused-macros.
They reduce the number of infractions from 111 to 82.
The remaining cases are:
* unused VIR_FROM_THIS
* copies of other headers
* in drivers I'm not familiar with enough
The next two were found randomly, which lead me to look
into v
After splitting out most of virsh command, some includes
are no longer needed.
Some files have the libXML includes despite not needing them.
---
tools/virsh-network.c | 6 --
tools/virsh-nodedev.c | 6 --
tools/virsh-nwfilter.c | 6 --
tools/virsh-pool.c | 6 --
tools/vi
Include them in the files that need them instead.
---
tools/virsh-domain.c | 1 +
tools/virsh-network.c | 1 +
tools/virsh-nodedev.c | 1 +
tools/virsh-snapshot.c | 1 +
tools/virsh.h | 2 --
5 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/v
In the order of appearance:
* MAX_LISTEN - never used
added by 23ad665c (qemud) and addec57 (lock daemon)
* NEXT_FREE_CLASS_ID - never used, added by 07d1b6b
* virLockError - never used, added by eb8268a4
* OPENVZ_MAX_ARG, CMDBUF_LEN, CMDOP_LEN
unused since the removal of ADD_ARG_LIT in d8b
* "verify.h" from gnulib is included in internal.h
* is no longer needed
added by commit da196338 to use fd_set in virExec prototype
---
src/util/virutil.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/util/virutil.h b/src/util/virutil.h
index 25524e2..55a3bd6 100644
--- a/src/util/v
On 2015年03月31日 17:46, Martin Kletzander wrote:
On Thu, Mar 26, 2015 at 10:23:47PM +0800, Huanle Han wrote:
Fix for such a case:
1. Domain A and B xml contain the same SRIOV net hostdev( with same pci address).
2. virsh start A (Successfully, and configure the SRIOV net with
custom mac)
3. virsh s
On 04/01/2015 03:38 AM, Zhi Yong Wu wrote:
> HI,
>
> Does anyone hit this issue when compiling libvirt?
>
> CCLD libvirt.la
> CC libvirt_qemu_la-libvirt-qemu.lo
> CCLD libvirt-qemu.la
> CC libvirt_lxc_la-libvirt-lxc.lo
> CCLD libvirt-lxc.la
> CC lockd_la-
(CCing libvir-list and Jiri Denemark for libvirt-related discussion
about -cpu host/none, and live-migration safety expectations)
On Wed, Apr 01, 2015 at 06:31:23PM +0200, Michael Mueller wrote:
> On Wed, 1 Apr 2015 10:01:13 -0300
> Eduardo Habkost wrote:
>
> > On Tue, Mar 31, 2015 at 10:09:09PM
Recent testing on large memory systems revealed a bug in the Xen xl
tool's freemem() function. When autoballooning is enabled, freemem()
is used to ensure enough memory is available to start a domain,
ballooning dom0 if necessary. When ballooning large amounts of memory
from dom0, freemem() would
We need to check that qemu supports block jobs in multiple places. Add a
helper to do the check.
---
src/qemu/qemu_domain.c | 30 ++
src/qemu/qemu_domain.h | 2 ++
2 files changed, 32 insertions(+)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 707
Sacrifice a few lines of code in favor of the code being more readable.
---
src/qemu/qemu_driver.c | 213 +--
src/qemu/qemu_migration.c| 8 +-
src/qemu/qemu_monitor.c | 18
src/qemu/qemu_monitor.h | 6 +-
src/qemu/qemu_monitor_j
Change few variable names and refactor the code flow. As an additional
bonus the function now fails if the event state is not as expected.
---
src/qemu/qemu_driver.c | 108 -
1 file changed, 52 insertions(+), 56 deletions(-)
diff --git a/src/qemu/qe
In some cases where the function does not need to access the private
data this helper may be used to retrieve the monitor object.
---
src/qemu/qemu_domain.c | 13 +
src/qemu/qemu_domain.h | 2 ++
2 files changed, 15 insertions(+)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_do
Since it now handles only block pull code paths we can refactor it and
remove tons of cruft.
---
src/qemu/qemu_driver.c | 86
src/qemu/qemu_monitor.c | 30
src/qemu/qemu_monitor.h | 17 -
src/qemu/qemu_monitor_js
Support for drive-reopen was never present in the upstream code so we
don't need to pause the VM when doing the block pivot. Kill all the
code related to this semi-upstream artifact.
---
src/qemu/qemu_driver.c | 48 +---
1 file changed, 5 insertions(+),
Refactor the function to use the new helpers.
---
src/qemu/qemu_driver.c | 20 ++--
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index becf415..6a2b58d 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
qemuDomainBlockJobImpl become an unmaintainable mess over the years of
adding new stuff to it. This patch starts splitting up individual
functions from it until it can be killed entirely.
In bulk this will add lines of code rather than delete them but it will
be traded for maintainability.
---
sr
At the expense of adding 113 lines of code, kill the ugly qemuBlockJobImpl
method and spread it's guts into separate functions.
This series additionally fixes a issue with failed drive pivot and the abort
function now returns errors if the returned event contained failure.
Peter Krempa (11):
qe
There are two leftover unused variables. Remove them and clean up the
fallout of the change.
---
src/qemu/qemu_driver.c | 5 +
src/qemu/qemu_monitor.c | 21 +
src/qemu/qemu_monitor.h | 6 ++
src/qemu/qemu_monitor_json.c | 5 ++---
src/qemu/qemu_monito
QEMU does not abandon the mirror. The job carries on in the synchronised
phase and it might be either pivoted again or cancelled. The commit
hints that the described behavior was happening in a downstream version.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1202704
---
Notes:
I've s
My intention is to split qemuMonitorJSONBlockJob() into simpler separate
functions for every block job type. Since the error handling code is the
same for all block jobs, this patch extracts the code into a separate
function that will later be reused in more places.
---
src/qemu/qemu_monitor_json.
Martin Kletzander wrote:
> On Wed, Mar 25, 2015 at 02:08:34PM -0600, Jim Fehlig wrote:
>> Let callers of libxlDomainStart decide when it is appropriate to
>> acquire a job on the associated virDomainObj.
>>
>
> This makes sense, I see many bugs this fixes, but how come
> libxlDomainShutdownThread()
v1 here:
http://www.redhat.com/archives/libvir-list/2015-March/msg01562.html
changes:
1/6: Removed the virGetLastError() == NULL check
2/6: New - reading more closely showed an error path without a goto
3/6: New - Adjust return for virStorageBackendSCSINewLun to be able
to differentiat
Adjust the processLU error returns to be a bit more logical. Currently,
the calling code cannot determine the difference between a non disk/lun
volume and a processed/found disk/lun. It can also not differentiate
between perhaps real/fatal error and one that won't necessarily stop
the code from fin
https://bugzilla.redhat.com/show_bug.cgi?id=1171933
If a non stable path is provided for the pool's target path, check to
see if the directory exists before allowing pool startup; otherwise,
later in the processLU calls to find LUN's all that happens is the
volume target.path will get the strdup'd
Don't supercede the error message virStorageBackendSCSIFindLUs as the
message such as "error: Failed to find LUs on host 60: ..." is not overly
clear as to what the real problem might be.
Signed-off-by: John Ferlan
---
src/storage/storage_backend_iscsi.c | 5 +
1 file changed, 1 insertion(+)
If the call to virStorageBackendISCSIGetHostNumber failed, we set
retval = -1, but yet still called virStorageBackendSCSIFindLUs.
Need to add a goto cleanup - while at it, adjust the logic to
initialize retval to -1 and only changed to 0 (zero) on success.
Signed-off-by: John Ferlan
---
src/stor
Add a return -2 to differentiate that the failure was a result of a non
stable device path found or some other real error which would be messaged
in some manner.
Signed-off-by: John Ferlan
---
src/storage/storage_backend_scsi.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
On Wed, Apr 01, 2015 at 17:32:28 +0200, Ján Tomko wrote:
> In the order of appearance:
>
> * MAX_LISTEN - never used
> added by 23ad665c (qemud) and addec57 (lock daemon)
>
> * NEXT_FREE_CLASS_ID - never used, added by 07d1b6b
>
> * virLockError - never used, added by eb8268a4
>
> * OPENVZ_MA
Seems to be a remnant that was never cleaned up from original submit...
Signed-off-by: John Ferlan
---
src/storage/storage_backend_scsi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/storage/storage_backend_scsi.c
b/src/storage/storage_backend_scsi.c
index 6def373..e085da2 100644
-
On Wed, Apr 01, 2015 at 17:32:32 +0200, Ján Tomko wrote:
> After splitting out most of virsh command, some includes
> are no longer needed.
>
> Some files have the libXML includes despite not needing them.
> ---
> tools/virsh-network.c | 6 --
> tools/virsh-nodedev.c | 6 --
> tools/v
On Wed, Apr 01, 2015 at 17:32:33 +0200, Ján Tomko wrote:
> Include them in the files that need them instead.
> ---
> tools/virsh-domain.c | 1 +
> tools/virsh-network.c | 1 +
> tools/virsh-nodedev.c | 1 +
> tools/virsh-snapshot.c | 1 +
> tools/virsh.h | 2 --
> 5 files changed, 4 i
On Wed, Apr 01, 2015 at 17:32:29 +0200, Ján Tomko wrote:
> Unused since commit bc2f42a0.
>
> Move it under the WITHOUT_DRIVER_MODULES #ifdef
> and start using it again.
> ---
> src/driver.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
ACK after release.
Peter
signature.asc
Desc
On 01.04.2015 11:13, zhang bo wrote:
> When we shutdown/reboot a guest using agent-mode, if the guest itself blocks
> infinitely,
> libvirt would block in qemuAgentShutdown() forever.
> Thus, we set a timeout for shutdown/reboot, from our experience, 60 seconds
> would be fine.
>
> Signed-off-by
On Wed, Apr 01, 2015 at 17:32:31 +0200, Ján Tomko wrote:
> * "verify.h" from gnulib is included in internal.h
> * is no longer needed
> added by commit da196338 to use fd_set in virExec prototype
> ---
> src/util/virutil.h | 2 --
> 1 file changed, 2 deletions(-)
ACK,
Peter
signature.asc
De
On 04/01/2015 12:15 PM, Huanle Han wrote:
>
>
> On 2015年03月31日 17:46, Martin Kletzander wrote:
>> On Thu, Mar 26, 2015 at 10:23:47PM +0800, Huanle Han wrote:
>>> Fix for such a case:
>>> 1. Domain A and B xml contain the same SRIOV net hostdev(>> type='hostdev' /> with same pci address).
>>> 2. vir
On Wed, Apr 01, 2015 at 17:32:30 +0200, Ján Tomko wrote:
> No longer needed after commit dd47723
> ---
> daemon/libvirtd.c | 1 -
> 1 file changed, 1 deletion(-)
ACK,
Peter
signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/ma
On Wed, 1 Apr 2015 13:59:05 -0300
Eduardo Habkost wrote:
> > Not directly invalid as "-cpu none" will be the same as omitting the -cpu
> > option.
> > KVM will setup the vcpu properties withou any QEMU control to whatever the
> > hosting
> > machine and the kvm kernel code offers. That will all
On Wed, 1 Apr 2015 21:05:31 +0200
Michael Mueller wrote:
> And cpu model "none" just means that QEMU does not manage the cpu model.
> That's also
> the reason why I initially returned an empty "[]" model and not "none". This
> somewhat
> convinces me to go back to this approach...
And for quer
QEMU does not abandon the mirror. The job carries on in the synchronised
phase and it might be either pivoted again or cancelled. The commit
hints that the described behavior was happening in a downstream version.
If the command returns false there are two possible options:
1) qemu did not reach t
A job should be acquired at the beginning of a domain destroy operation,
not at the end when cleaning up the domain. Fix two occurrences of this
late job acquisition in the libxl driver. Doing so renders
libxlDomainCleanupJob unused, so it is removed.
Signed-off-by: Jim Fehlig
---
V2:
Don't ac
V2 of a small series to fix issues wrt domain destroy
https://www.redhat.com/archives/libvir-list/2015-March/msg01337.html
Comments from Konrad and Martin are addressed in this version.
Jim Fehlig (3):
libxl: Move job acquisition in libxlDomainStart to callers
libxl: acquire a job when destr
Let callers of libxlDomainStart decide when it is appropriate to
acquire a job on the associated virDomainObj.
Signed-off-by: Jim Fehlig
---
V2:
Don't call virDomainObjListRemove() on persistent domain
src/libxl/libxl_domain.c | 24 -
src/libxl/libxl_driver.c | 55 +
A destroy operation can take considerable time on large memory
domains due to scrubbing the domain' memory. The operation is
running in the context of a job, so unlocking the domain and
allowing query operations is safe.
Signed-off-by: Jim Fehlig
---
V2:
Unchanged
src/libxl/libxl_domain.c | 4
Martin Kletzander wrote:
> On Thu, Mar 26, 2015 at 03:29:51PM -0600, Jim Fehlig wrote:
>> Konrad Rzeszutek Wilk wrote:
>>> On Wed, Mar 25, 2015 at 02:08:35PM -0600, Jim Fehlig wrote:
>>>
A job should be acquired at the beginning of a domain destroy
operation,
not at the end when clea
On Wed, Apr 01, 2015 at 09:05:31PM +0200, Michael Mueller wrote:
> On Wed, 1 Apr 2015 13:59:05 -0300
> Eduardo Habkost wrote:
>
> > > Not directly invalid as "-cpu none" will be the same as omitting the -cpu
> > > option.
> > > KVM will setup the vcpu properties withou any QEMU control to whatev
got fixed, thanks.
On Thu, Apr 2, 2015 at 12:16 AM, Eric Blake wrote:
> On 04/01/2015 03:38 AM, Zhi Yong Wu wrote:
>> HI,
>>
>> Does anyone hit this issue when compiling libvirt?
>>
>> CCLD libvirt.la
>> CC libvirt_qemu_la-libvirt-qemu.lo
>> CCLD libvirt-qemu.la
>> CC
72 matches
Mail list logo
