This change from configDir
+int virStoragePoolSaveState(const char *stateFile,
+virStoragePoolDefPtr def);
+int virStoragePoolSaveConfig(const char *configFile,
to configFile should be in a separate commit.
(You can just push it under the trivial rule)
Your previous patch 3/7 had a better commit message:
Introduce virStoragePoolSaveStatus to properly format the status XML in
the same manner as virStoragePoolDefFormat, except for adding a
poolstatus ... /poolstatus around the definition. This is similar to
virNetworkObjFormat used to save
ACK with one nit:
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index b070448..a8e9876 100644
--- a/src/conf/storage_conf.c
+++ b/src/conf/storage_conf.c
@@ -1150,76 +1150,90 @@ virStoragePoolSourceFormat(virBufferPtr buf,
--- 8 ---
-virBufferAdjustIndent(buf,
On Thu, Apr 02, 2015 at 12:10:35PM +0200, Erik Skultety wrote:
When modifying config/status XML, it might be handy to include some
additional XML elements (e.g. poolstatus). In order to do so,
introduce new formatting function virStoragePoolDefFormatBuf and make
virStoragePoolDefFormat call
Just a minor change which might be a little confusing for someone
looking only at the API.
---
Pushed as trivial.
src/conf/storage_conf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/storage_conf.h b/src/conf/storage_conf.h
index edcdaed..da378b7 100644
---
On Thu, Apr 02, 2015 at 12:24:40PM -0400, John Ferlan wrote:
Future IOThread setting patches would copy the code anyway, so create
and generalize the add the vcpu to a cgroup into its own API.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/qemu/qemu_driver.c | 69
On Thu, Apr 02, 2015 at 12:10:37PM +0200, Erik Skultety wrote:
Properly format storage pool state XML.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1177733
---
src/conf/storage_conf.c | 35 +++
src/conf/storage_conf.h | 4 +++-
All of print function use vshPrintExtra in cmdDomIfAddr, this will
make domifaddr no output in quiet mode, after this patch, quiet mode
output will be:
# virsh -q domifaddr test3 --source agent
lo 00:00:00:00:00:00ipv4 127.0.0.1/8
- -ipv6
On 03.04.2015 11:41, Luyao Huang wrote:
All of print function use vshPrintExtra in cmdDomIfAddr, this will
make domifaddr no output in quiet mode, after this patch, quiet mode
output will be:
# virsh -q domifaddr test3 --source agent
lo 00:00:00:00:00:00ipv4
This patch introduces new virStorageDriverState element stateDir.
Also adds necessary changes to storageStateInitialize, so that
directories initialization becomes more generic.
---
src/conf/storage_conf.h | 1 +
src/storage/storage_driver.c | 108
Hello +Michal,
I will make the corrections and re send the patch. Sorry for the errors.
Thanks,
Noella
On Fri, Apr 3, 2015 at 10:19 AM, Michal Privoznik mpriv...@redhat.com
wrote:
On 01.04.2015 14:46, Noella Ashu wrote:
The error output of snapshot-revert should be more friendly. There is
There are two bugs in this function:
1. cannot start a vm with cpuset but without numatune settings
# virsh -c lxc:/// start helloworld
error: Failed to start domain helloworld
error: internal error: guest failed to start: Invalid value '1-3' for
'cpuset.mems': Invalid argument
we don't
The error output of snapshot-revert should be more friendly. There is no
need to show up virDomainRevertToSnapshot to user. virError already includes
__FUNCTION__ information in a separate member of the struct, so repeating
it in the message is redundant and leads to situations where higher level
Problem Description:
Live-migrate a guest, which has a tap device and continuously sends and
receives ARP packets, it would mistakenly think there's another guest with the
same IP, immedially after migration.
The steps to reproduce the problem:
1 define and start a domain with its network
On 09.03.2015 16:54, Dawid Zamirski wrote:
This patch is intended to make ESX driver behave more consistently.
When calling virNodeGetFreeMemory, it would return the free bytes
from a cluster when using vpx connection or ESX host when using esx
connection. However, virGetNodeInfo always
On 03.04.2015 12:33, Noella Ashu wrote:
The error output of snapshot-revert should be more friendly. There is no
need to show up virDomainRevertToSnapshot to user. virError already includes
__FUNCTION__ information in a separate member of the struct, so repeating
it in the message is
On Thu, Apr 02, 2015 at 09:34:25AM -0600, Jim Fehlig wrote:
Ján Tomko wrote:
Commit cd5dc30 added this test, but it fails if
LIBXL_HAVE_BUILDINFO_USBDEVICE_LIST is not defined:
Opps, sorry. I tested back to Xen 4.3 where I thought this was
undefined. But looking at that machine
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
Pushed as trivial.
tools/virsh.pod | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index 79d50f9..d642a69 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -2458,7 +2458,7 @@ Likewise,
On Fri, Apr 03, 2015 at 08:25:56AM +0800, Daniel Veillard wrote:
On Thu, Apr 02, 2015 at 06:51:35PM +0200, Guido Günther wrote:
Hi,
On Tue, Mar 31, 2015 at 09:01:33AM +0800, Daniel Veillard wrote:
So I have just tagged in git and pushed the 1.2.14 candidate release
2, it is available
This is yet another test for check of basic functionality of our
NIC state handling code.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/libvirt_private.syms | 1 +
src/util/virnetdev.c | 4 +-
src/util/virnetdev.h
On 01.04.2015 14:46, Noella Ashu wrote:
The error output of snapshot-revert should be more friendly. There is no
need to show up virDomainRevertToSnapshot to user. virError already includes
__FUNCTION__ information in a separate member of the struct, so repeating
it in the message is
Hello +Michal,
I have sent a new patch to the mailing list with the whitespaces removed.
This should work fine now. Please just let me know if you have any other
issues.
Thanks,
Noella
On Fri, Apr 3, 2015 at 11:04 AM, Noella Ashu ashu.noella...@gmail.com
wrote:
Hello +Michal,
I will make
ACK with the slight adjustments.
If you want to post a v3 inline/as a response to patch 4 - that's fine
John
Thank you, I sent v3 of patch 4/6, fixed the slight adjustments in 5 and
6. I'll push them once I have an ACK for 4/6.
Erik
--
libvir-list mailing list
libvir-list@redhat.com
Jim Fehlig wrote:
V2 of a small series to fix issues wrt domain destroy
https://www.redhat.com/archives/libvir-list/2015-March/msg01337.html
Comments from Konrad and Martin are addressed in this version.
Jim Fehlig (3):
libxl: Move job acquisition in libxlDomainStart to callers
libxl:
Due to a bug report by someone trying to add two cd drives to a Q35
domain in virt-manager (which assumes all CD drives are IDE), I've
learned that libvirt doesn't support adding a piix3-ide controller
when there is no ide controller for the domain (or when there are more
than 4 disk devices that
Let callers of libxlDomainStart decide when it is appropriate to
acquire a job on the associated virDomainObj.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
Job handling in the migration code is currently broken/incomplete,
so fixing it is deferred to a follow-up series I'm working on.
V3 of a small series to fix issues wrt domain destroy
V1:
https://www.redhat.com/archives/libvir-list/2015-March/msg01337.html
V2:
https://www.redhat.com/archives/libvir-list/2015-April/msg00072.html
In this version, patch 3 is changed a bit to provide a wrapper for
unlocking, destroying, and
A destroy operation can take considerable time on large memory
domains due to scrubbing the domain's memory. Unlock the
virDomainObj while libxl_domain_destroy is executing.
Implement libxlDomainDestroyInternal wrapper to handle unlocking,
calling destroy, and locking. Change all callers of
A job should be acquired at the beginning of a domain destroy operation,
not at the end when cleaning up the domain. Fix two occurrences of this
late job acquisition in the libxl driver. Doing so renders
libxlDomainCleanupJob unused, so it is removed.
Signed-off-by: Jim Fehlig jfeh...@suse.com
29 matches
Mail list logo
