Use the same pattern for all machine types on all archs and same archs
for hvm and exe types.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
docs/schemas/domaincommon.rng | 182 ++
1 file changed, 23 insertions(+), 159 deletions(-)
diff --git
On Tue, Apr 14, 2015 at 13:28:50 +0200, Ján Tomko wrote:
These cannot be represented in XML.
We have been stripping them, but only if the string had
characters that needed escaping: '
Extend the strcspn check to include control codes, and strip
them even if we don't do any escaping.
On 04/15/2015 05:51 AM, Michal Privoznik wrote:
Throughout the code, we have several places need to construct a path
somewhere in /sys/class/net/... They are not consistent and nearly
each code piece invents its own way how to do it. So unify this by:
1) use virNetDevSysfsFile() wherever
On Wed, Apr 15, 2015 at 12:18:15PM +0200, Ján Tomko wrote:
On Mon, Apr 13, 2015 at 04:53:53PM +0200, Martin Kletzander wrote:
Use the same pattern for all OS types.
Did you mean to do it for all architectures for os type='hvm'?
Because I only see that this patch touches hvm and exe OS types.
On 04/14/2015 12:05 PM, Peter Krempa wrote:
Among all the monitor APIs some where checking if mon is NULL and some
were not. Since it's possible to have mon equal to NULL in case a second
call is attempted once entered the monitor. This requires that every
single API checks for the monitor.
On Tue, Apr 14, 2015 at 13:28:48 +0200, Ján Tomko wrote:
Including them in the XML makes them unparsable.
https://bugzilla.redhat.com/show_bug.cgi?id=1184131
---
src/node_device/node_device_udev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/node_device/node_device_udev.c
On Wed, Apr 15, 2015 at 02:54:12PM +0200, Peter Krempa wrote:
All the called functions already report an error.
---
src/node_device/node_device_udev.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/src/node_device/node_device_udev.c
If a virAsprintf() within the function fails, we call VIR_FREE()
over @rundir variable and jump onto cleanup label, where it is
freed again. It doesn't hurt, but not make much sense too.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
Pushed as trivial.
src/util/virpidfile.c | 5 +
On Wed, Apr 15, 2015 at 10:24:10 +0200, Jiri Denemark wrote:
On Tue, Apr 14, 2015 at 18:05:11 +0200, Peter Krempa wrote:
Among all the monitor APIs some where checking if mon is NULL and some
were not. Since it's possible to have mon equal to NULL in case a second
call is attempted once
On 04/15/2015 05:51 AM, Michal Privoznik wrote:
In one of my previous commits (49ed6cff9) I've introduced a test
among with some files stored under virnetdevtestdata folder.
While this works perfectly within a git tree, the folder was not
getting into .tar.gz and therefore the dist-check
On Tue, Apr 14, 2015 at 08:15:52PM -0600, Jim Fehlig wrote:
Konrad Rzeszutek Wilk wrote:
It is unhealthy. If the device is not doing any DMA operations
it would work - but if you are saving and there are DMA operations
happening the chance of corruption (outstanding DMAs) increase.
As
On Wed, Apr 15, 2015 at 04:25:11PM +0530, Prerna Saxena wrote:
On Monday 13 April 2015 07:50 PM, Daniel P. Berrange wrote:
On Mon, Apr 13, 2015 at 04:14:53PM +0200, Martin Kletzander wrote:
Use the same pattern as there is for x86 machines.
Signed-off-by: Martin Kletzander
Most of the types in datatypes.[hc] depend on virObject and virClass,
but they were specified separatedly from that. We were lucky enough for
this to work because wherever the datatypes files were used, that
file (binary/shared object) was linked to libvirt_util as well.
Fixing this comes up as
On Wed, Apr 15, 2015 at 02:19:04PM +0100, Daniel P. Berrange wrote:
On Wed, Apr 15, 2015 at 02:29:52PM +0200, Martin Kletzander wrote:
Most of the types in datatypes.[hc] depend on virObject and virClass,
but they were specified separatedly from that. We were lucky enough for
this to work
On Tue, Apr 14, 2015 at 13:28:49 +0200, Ján Tomko wrote:
To prevent generating invalid XML.
https://bugzilla.redhat.com/show_bug.cgi?id=1066564
---
src/storage/storage_backend_fs.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/storage/storage_backend_fs.c
All the called functions already report an error.
---
src/node_device/node_device_udev.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/src/node_device/node_device_udev.c
b/src/node_device/node_device_udev.c
index 8c39e5f..1025e80 100644
---
On Wed, Apr 15, 2015 at 11:17:29AM +0100, Ian Campbell wrote:
On Tue, 2015-04-14 at 10:37 +0100, Daniel P. Berrange wrote:
On Tue, Apr 14, 2015 at 10:33:45AM +0100, Ian Campbell wrote:
On Tue, 2015-04-14 at 02:27 +, osstest service user wrote:
flight 50401 libvirt real [real]
On Wed, Apr 15, 2015 at 02:29:52PM +0200, Martin Kletzander wrote:
Most of the types in datatypes.[hc] depend on virObject and virClass,
but they were specified separatedly from that. We were lucky enough for
this to work because wherever the datatypes files were used, that
file
On 15.04.2015 15:07, John Ferlan wrote:
On 04/15/2015 05:51 AM, Michal Privoznik wrote:
Throughout the code, we have several places need to construct a path
somewhere in /sys/class/net/... They are not consistent and nearly
each code piece invents its own way how to do it. So unify this
On Wed, Apr 15, 2015 at 10:22:03 -0400, John Ferlan wrote:
Commit id 'b77ce18a2' added a new bitmap, but neglected to virBitmapFree it
Signed-off-by: John Ferlan jfer...@redhat.com
---
tests/virbitmaptest.c | 1 +
1 file changed, 1 insertion(+)
ACK,
Peter
signature.asc
Description:
On Wed, Apr 15, 2015 at 04:31:01PM +0200, Peter Krempa wrote:
On Wed, Apr 15, 2015 at 16:02:45 +0200, Martin Kletzander wrote:
On Wed, Apr 15, 2015 at 02:19:04PM +0100, Daniel P. Berrange wrote:
On Wed, Apr 15, 2015 at 02:29:52PM +0200, Martin Kletzander wrote:
Most of the types in
On Wed, Apr 15, 2015 at 16:02:45 +0200, Martin Kletzander wrote:
On Wed, Apr 15, 2015 at 02:19:04PM +0100, Daniel P. Berrange wrote:
On Wed, Apr 15, 2015 at 02:29:52PM +0200, Martin Kletzander wrote:
Most of the types in datatypes.[hc] depend on virObject and virClass,
but they were
On 04/15/2015 08:22 AM, John Ferlan wrote:
Commit id 'b77ce18a2' added a new bitmap, but neglected to virBitmapFree it
Signed-off-by: John Ferlan jfer...@redhat.com
---
tests/virbitmaptest.c | 1 +
1 file changed, 1 insertion(+)
ACK
diff --git a/tests/virbitmaptest.c
Michal,
On Wed, Apr 15, 2015 at 10:54 AM, Michal Privoznik mpriv...@redhat.com
wrote:
On 26.03.2015 15:48, Pavel Boldin wrote:
Dear Libvirt Developers,
I'm working to implement feature request [1]. The feature request
proposes
to enhance `libvirt' code so the API caller can specify
Commit id 'b77ce18a2' added a new bitmap, but neglected to virBitmapFree it
Signed-off-by: John Ferlan jfer...@redhat.com
---
tests/virbitmaptest.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/virbitmaptest.c b/tests/virbitmaptest.c
index 9a84e4c..a6e9a38 100644
---
On 04/15/2015 04:48 AM, Ján Tomko wrote:
On Tue, Apr 14, 2015 at 04:24:13PM -0600, Eric Blake wrote:
Commit a0670ae caused a regression in 'virsh event' and
'virsh qemu-monitor-event' - if a user tries to filter the
command to a specific domain, an error message is printed:
$ virsh event dom
Among all the monitor APIs some where checking if mon is NULL and some
were not. Since it's possible to have mon equal to NULL in case a second
call is attempted once entered the monitor. This requires that every
single API checks for the monitor.
This patch adds a macro that helps checking the
On Wed, Apr 15, 2015 at 12:00:51PM +0200, Peter Krempa wrote:
On Tue, Apr 14, 2015 at 13:28:47 +0200, Ján Tomko wrote:
Add virStringHasControlChars that checks if the string has
any control characters other than \t\r\n,
and virStringStripControlChars that removes them in-place.
---
On 15.04.2015 16:38, Pavel Boldin wrote:
Michal,
On Wed, Apr 15, 2015 at 10:54 AM, Michal Privoznik mpriv...@redhat.com
wrote:
On 26.03.2015 15:48, Pavel Boldin wrote:
Dear Libvirt Developers,
I'm working to implement feature request [1]. The feature request
proposes
to enhance
On Wed, Apr 15, 2015 at 6:43 PM, Michal Privoznik mpriv...@redhat.com
wrote:
On 15.04.2015 16:38, Pavel Boldin wrote:
Michal,
On Wed, Apr 15, 2015 at 10:54 AM, Michal Privoznik mpriv...@redhat.com
wrote:
On 26.03.2015 15:48, Pavel Boldin wrote:
Dear Libvirt Developers,
I'm
On 04/14/2015 12:59 PM, Michal Privoznik wrote:
The inbound/ element to bandwidth/ has several attributes from
which two are mandatory. Well, from two at least one has to be
present: @average or @floor or both. Instead of inventing crazy RNG
schema, let's make all the attributes optional there
Rather than erroring out make the best attempt to retrieve other data if
disks are inaccessible or missing. The failure will still be logged
though.
Since the bulk stats API is called on multiple domains an error like
this makes the API unusable. This regression was introduced by commit
On 04/15/2015 10:19 AM, Peter Krempa wrote:
Rather than erroring out make the best attempt to retrieve other data if
disks are inaccessible or missing. The failure will still be logged
though.
Since the bulk stats API is called on multiple domains an error like
this makes the API unusable.
On 04/14/2015 12:59 PM, Michal Privoznik wrote:
The comment is describing arguments passed to the function.
However, there's no @ifmac argument. In 955af4d4 it was replaced
with @ifmac_ptr. Unfortunately, the comment wasn't updated.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
Fix for such a case:
1. Domain A and B xml contain the same SRIOV net hostdev(interface
type='hostdev' / with same pci address).
2. virsh start A (Successfully, and configure the SRIOV net with
custom mac)
3. virsh start B (Fail because of the hostdev used by domain A or other
reason.)
In step 3,
On 04/10/2015 01:47 PM, Laine Stump wrote:
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1113474
When we set the MAC address of a network device as a part of setting
up macvtap passthrough mode (where the domain has an emulated netdev
connected to a host macvtap device that has
On 04/02/2015 12:21 PM, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1200149
Even though we have a mutex mechanism so that two clients don't spawn
two daemons, it's not strong enough. It can happen that while one
client is spawning the daemon, the other one fails to
The scsi host example in https://libvirt.org/formatdomain.html does not
make it clear what adapter name='scsi_host0'/ refers to. It implies
that any host #0 will be used. Since the index numbers for each host are
dynamic an unexpected device may be used by libvirt.
The reason I'm looking at this
On 04/13/2015 01:44 PM, Laine Stump wrote:
A further fix for:
https://bugzilla.redhat.com/show_bug.cgi?id=1113474
Since there is no possibility that any type of macvtap will work if
the parent physdev it's attached to is offline, we should bring the
physdev online at the same time as
re-sending, thank you Erik!
On Wed, Apr 15, 2015 at 9:48 PM, Eric Blake ebl...@redhat.com wrote:
On 04/15/2015 01:38 PM, Laszlo Hornyak wrote:
The added details are required in order to upload to maven central
Signed-off-by: Laszlo Hornyak laszlo.horn...@gmail.com
---
pom.xml.in | 14
The added details are required in order to upload to maven central
Signed-off-by: Laszlo Hornyak laszlo.horn...@gmail.com
---
pom.xml.in | 14 ++
1 file changed, 14 insertions(+)
diff --git a/pom.xml.in b/pom.xml.in
index 4f49a3a..2ac8822 100644
--- a/pom.xml.in
+++ b/pom.xml.in
@@
gcc 4.1.2 (hello RHEL 5) on 32-bit platforms complains:
vircgrouptest.c: In function 'testCgroupGetPercpuStats':
vircgrouptest.c:627: warning: integer constant is too large for 'long' type
vircgrouptest.c:628: warning: this decimal constant is unsigned only in ISO C90
vircgrouptest.c:634:
The added details are required in order to upload to maven central
Signed-off-by: Laszlo Hornyak laszlo.horn...@gmail.com
---
pom.xml.in | 14 ++
1 file changed, 14 insertions(+)
diff --git a/pom.xml.in b/pom.xml.in
index 4f49a3a..2ac8822 100644
--- a/pom.xml.in
+++ b/pom.xml.in
@@
On 01/22/2015 04:26 AM, Ján Tomko wrote:
Per-cpu stats are only shown for present CPUs in the cgroups,
but we were only parsing the largest CPU number from
/sys/devices/system/cpu/present and looking for stats even for
non-present CPUs.
This resulted in:
internal error: cpuacct parse error
On 04/15/2015 01:38 PM, Laszlo Hornyak wrote:
The added details are required in order to upload to maven central
Signed-off-by: Laszlo Hornyak laszlo.horn...@gmail.com
---
pom.xml.in | 14 ++
1 file changed, 14 insertions(+)
I'm not qualified to review the patch proper; but
On Mon, Apr 13, 2015 at 16:33:49 +0200, Martin Kletzander wrote:
We were lucky enough for this to work because the datatypes files were
linked to in the resulting binary, but the dependency really is already
in libvirt_util.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
On Mon, Apr 13, 2015 at 16:33:48 +0200, Martin Kletzander wrote:
The first two were a bit off.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
configure.ac | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
ACK,
Peter
signature.asc
Description: Digital signature
--
On Mon, Apr 13, 2015 at 16:33:50 +0200, Martin Kletzander wrote:
Luckily we are allocating structs as clean memory and
PTHREAD_MUTEX_INITIALIZER is { 0 }, so nothing happened, but it should
still be created as lockable object.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
On Mon, Apr 13, 2015 at 17:21:06 -0400, John Ferlan wrote:
Split out the nhost == 1 and hosts[0].name logic into a separate routine
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/conf/storage_conf.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
ACK,
Peter
On Tue, Apr 14, 2015 at 13:28:46 +0200, Ján Tomko wrote:
For reuse with other Strip* functions.
---
tests/virstringtest.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
ACK,
Peter
signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
On Mon, Apr 13, 2015 at 16:33:52 +0200, Martin Kletzander wrote:
Two non-static functions in virjson.c were missing their export info in
libvirt_private.syms, so they couldn't be used anywhere it the code (and
that's about to get changed).
They both are used in the libvirt_leaseshelper
On Mon, Apr 13, 2015 at 17:21:05 -0400, John Ferlan wrote:
Create a separate iSCSI Source matching subroutine. Makes the calling
code a bit cleaner as well as sets up for future patches which need to
do better source hosts[0].name processing/checking.
As part of the effort the logic will be
On Mon, Apr 13, 2015 at 16:33:51 +0200, Martin Kletzander wrote:
It already had a virMutex inside, so this is just a cleanup.
It also probably fixes a potential deadlock too.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/datatypes.c | 12 ++--
src/datatypes.h
On Mon, Apr 13, 2015 at 17:21:10 -0400, John Ferlan wrote:
Check the proposed pool source host XML definition against existing sheepdog
pools to ensure the incoming definition doesn't use the same source host XML
definition as an existing pool.
Signed-off-by: John Ferlan jfer...@redhat.com
On Tue, Apr 14, 2015 at 18:05:09 +0200, Peter Krempa wrote:
Add the attribute and remove the check.
---
src/qemu/qemu_monitor.c | 4 ++--
src/qemu/qemu_monitor.h | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
ACK
Jirka
--
libvir-list mailing list
libvir-list@redhat.com
On Tue, Apr 14, 2015 at 18:05:10 +0200, Peter Krempa wrote:
Commit f6563bc3 introduced HMP impl of the function (so that a different
uglier function could be removed). Before the HMP code is called there's
a leftover check that the monitor is JSON which inhibits the code from
working.
---
It was the privacy extension enabled on the windows hosts.
So it was sending out from addresses the KVM HOST is not member of the
multicast group.
disabled it with netsh interface ipv6 set privacy state=disabled
Stefan
--
libvir-list mailing list
libvir-list@redhat.com
On 26.03.2015 15:48, Pavel Boldin wrote:
Dear Libvirt Developers,
I'm working to implement feature request [1]. The feature request proposes
to enhance `libvirt' code so the API caller can specify which block devices
are to be migrated using e.g. parameters in the `virDomainMigrateToURI3'
On Mon, Apr 13, 2015 at 17:21:07 -0400, John Ferlan wrote:
In virStoragePoolSourceMatchSingleHost, add a comparison for port number
being different prior to checking the 'name' field.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/conf/storage_conf.c | 3 +++
1 file changed, 3
On Mon, Apr 13, 2015 at 17:21:08 -0400, John Ferlan wrote:
Rather than have duplicate code doing the same check, have the netfs
matching processing code use the new virStoragePoolSourceMatchSingleHost.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/conf/storage_conf.c | 6 +++---
1
On Tue, Apr 14, 2015 at 10:28:23AM -0600, Eric Blake wrote:
On 04/14/2015 10:24 AM, Martin Kletzander wrote:
That works with the following change:
ACK with that squashed in, no need to resend it ;)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index
On 04/15/2015 03:57 AM, Peter Krempa wrote:
On Mon, Apr 13, 2015 at 17:21:11 -0400, John Ferlan wrote:
Check the proposed pool source host XML definition against existing gluster
pools to ensure the incoming definition doesn't use the same source host XML
definition as an existing pool.
On Tue, Apr 14, 2015 at 04:24:13PM -0600, Eric Blake wrote:
Commit a0670ae caused a regression in 'virsh event' and
'virsh qemu-monitor-event' - if a user tries to filter the
command to a specific domain, an error message is printed:
$ virsh event dom --loop
error: internal error: virsh
*** BLURB HERE ***
Michal Privoznik (2):
tests: Add virnetdevtestdata to EXTRA_DIST
Cleanup /sys/class/net usage
src/Makefile.am | 4 ++--
src/parallels/parallels_network.c | 3 +--
src/util/virnetdev.c | 5 ++---
src/util/virnetdev.h | 2 ++
In one of my previous commits (49ed6cff9) I've introduced a test
among with some files stored under virnetdevtestdata folder.
While this works perfectly within a git tree, the folder was not
getting into .tar.gz and therefore the dist-check would fail.
Signed-off-by: Michal Privoznik
Throughout the code, we have several places need to construct a path
somewhere in /sys/class/net/... They are not consistent and nearly
each code piece invents its own way how to do it. So unify this by:
1) use virNetDevSysfsFile() wherever possible
2) At least use common macro SYSFS_NET_DIR
On Wed, Apr 15, 2015 at 09:29:39AM +0200, Peter Krempa wrote:
On Mon, Apr 13, 2015 at 16:33:50 +0200, Martin Kletzander wrote:
Luckily we are allocating structs as clean memory and
PTHREAD_MUTEX_INITIALIZER is { 0 }, so nothing happened, but it should
still be created as lockable object.
On Mon, Apr 13, 2015 at 17:21:12 -0400, John Ferlan wrote:
Check proposed pool definitions to ensure they aren't trying to use the
same devices as currently defined definitions - disallow the duplicate
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/conf/storage_conf.c | 2 +-
1
On Mon, Apr 13, 2015 at 17:21:09 -0400, John Ferlan wrote:
So that we can cover all the cases.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/conf/storage_conf.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
ACK if I've not acked it in the previous version.
Peter
On Mon, Apr 13, 2015 at 17:21:11 -0400, John Ferlan wrote:
Check the proposed pool source host XML definition against existing gluster
pools to ensure the incoming definition doesn't use the same source host XML
definition as an existing pool.
Signed-off-by: John Ferlan jfer...@redhat.com
I could narrow down the problem. Win7Prof and Windows 10 is having this
issue.
Win Client is member of the multicast group and is listening on
ff02::1:ffdf:fe88
Traffic from router - client - captured on router:
07:41:23.104567 IP6 fe80::12fe:edff:fee6:cfa ff02::1:ffdf:fe88: ICMP6,
neighbor
On Tue, Apr 14, 2015 at 18:05:11 +0200, Peter Krempa wrote:
Among all the monitor APIs some where checking if mon is NULL and some
were not. Since it's possible to have mon equal to NULL in case a second
call is attempted once entered the monitor. This requires that every
single API checks for
On Tue, Apr 14, 2015 at 18:05:05 +0200, Peter Krempa wrote:
Fix line spacing between functions, ensure that function return type is
on a separate line and reflow arguments for VIR_DEBUG statements.
---
src/qemu/qemu_monitor.c | 836
1 file
On Tue, Apr 14, 2015 at 18:05:08 +0200, Peter Krempa wrote:
Quite a lot places set the 'ret' variable just once right before
returning it's value. Remove such usage.
---
src/qemu/qemu_monitor.c | 465
+---
1 file changed, 167 insertions(+), 298
On Tue, Apr 14, 2015 at 18:05:07 +0200, Peter Krempa wrote:
---
src/qemu/qemu_monitor.c | 6 +++---
src/qemu/qemu_monitor.h | 3 ++-
src/qemu/qemu_process.c | 6 ++
3 files changed, 11 insertions(+), 4 deletions(-)
ACK
Jirka
--
libvir-list mailing list
libvir-list@redhat.com
On Tue, Apr 14, 2015 at 18:05:06 +0200, Peter Krempa wrote:
---
src/qemu/qemu_monitor.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index 398c236..fcdd41d 100644
--- a/src/qemu/qemu_monitor.c
+++
On Wed, Apr 15, 2015 at 09:26:45AM +0200, Peter Krempa wrote:
On Mon, Apr 13, 2015 at 16:33:49 +0200, Martin Kletzander wrote:
We were lucky enough for this to work because the datatypes files were
linked to in the resulting binary, but the dependency really is already
in libvirt_util.
On Tue, 2015-04-14 at 10:37 +0100, Daniel P. Berrange wrote:
On Tue, Apr 14, 2015 at 10:33:45AM +0100, Ian Campbell wrote:
On Tue, 2015-04-14 at 02:27 +, osstest service user wrote:
flight 50401 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/50401/
On Mon, Apr 13, 2015 at 04:53:53PM +0200, Martin Kletzander wrote:
Use the same pattern for all OS types.
Did you mean to do it for all architectures for os type='hvm'?
Because I only see that this patch touches hvm and exe OS types.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
On Tue, Apr 14, 2015 at 13:28:47 +0200, Ján Tomko wrote:
Add virStringHasControlChars that checks if the string has
any control characters other than \t\r\n,
and virStringStripControlChars that removes them in-place.
---
src/libvirt_private.syms | 2 ++
src/util/virstring.c | 39
On Monday 13 April 2015 07:50 PM, Daniel P. Berrange wrote:
On Mon, Apr 13, 2015 at 04:14:53PM +0200, Martin Kletzander wrote:
Use the same pattern as there is for x86 machines.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
docs/schemas/domaincommon.rng | 4 +++-
1 file
...snip...
I have not been able to try this patch, it fails with this error :
There's a v2 :
http://www.redhat.com/archives/libvir-list/2015-April/msg00503.html
Although it appears that it too has a RNG issue according to what Jan
just posted.
John
error: internal error: Unable to parse
Apparently, files in /usr/lib/sysctl.d are usually prefixed with numbers
for easier ordering. Let's be consistent with this. I chose 60 for
libvirtd so that it goes after 50-default.conf.
https://bugzilla.redhat.com/show_bug.cgi?id=1084876
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
On Wed, Apr 15, 2015 at 06:47:43 -0400, John Ferlan wrote:
On 04/15/2015 03:57 AM, Peter Krempa wrote:
On Mon, Apr 13, 2015 at 17:21:11 -0400, John Ferlan wrote:
Check the proposed pool source host XML definition against existing gluster
pools to ensure the incoming definition doesn't
On 04/14/2015 01:27 PM, Ján Tomko wrote:
Only for devices that have an alias.
---
v2: only set the alias when ret == 0 and emit the event before
the alias can disappear
mention that AttachMemory emits the event
src/qemu/qemu_driver.c | 42
85 matches
Mail list logo
