On 04/20/2015 09:53 AM, Michal Privoznik wrote:
On 18.04.2015 03:45, Cole Robinson wrote:
If no ostype was specified:
before: unknown OS type no OS type
after : xml error: an os type must be specified
If an ostype is specified that's not in our capabiliities data:
before: unknown OS
On 04/20/2015 09:52 AM, Michal Privoznik wrote:
On 18.04.2015 03:45, Cole Robinson wrote:
First two patches are straight bug fixes.
The rest is a bunch of internal cleanup I felt compelled to do. Summary is
- Switch caps and domain to use an enum for os.type value (hvm, xen, exe,
...)
-
On 04/14/2015 12:59 PM, Michal Privoznik wrote:
So, as partly explained in previous commit, there is an issue
with NATed networks on a guest originated MAC change. When user
sets @floor in inbound/ under bandwidth/ it results in a QoS
hierarchy being built on the corresponding bridge (yes,
On 04/17/2015 03:15 PM, Laine Stump wrote:
On 04/15/2015 02:59 PM, John Ferlan wrote:
On 04/13/2015 01:44 PM, Laine Stump wrote:
A further fix for:
https://bugzilla.redhat.com/show_bug.cgi?id=1113474
Since there is no possibility that any type of macvtap will work if
the parent physdev
On 04/17/2015 04:51 AM, Michal Privoznik wrote:
On 16.04.2015 19:25, Laine Stump wrote:
On 04/14/2015 12:59 PM, Michal Privoznik wrote:
Not only this simplifies the code a bit, it prepares the
environment for upcoming patches. The new
virNetDevBandwidthManipulateFilter() function is capable
On 04/16/2015 01:00 PM, Laine Stump wrote:
On 04/14/2015 12:59 PM, Michal Privoznik wrote:
After a360912179 the formatting of virDomainActualNetDefPtr was
changed a bit. However, during the function rewrite, iface's class_id
is not formatted as frequently as it could be. In fact, after rewrite
On 04/20/2015 10:31 AM, Peter Krempa wrote:
On Sun, Apr 19, 2015 at 20:49:11 -0400, John Ferlan wrote:
In order to assist with existing pool source hostname validation against
an incoming pool source definition, we need a way to validate that the
resolved hostname provided for the pool
On 04/20/2015 10:04 PM, Ján Tomko wrote:
On Fri, Apr 03, 2015 at 06:11:15PM +0800, Luyao Huang wrote:
There are two bugs in this function:
1. cannot start a vm with cpuset but without numatune settings
# virsh -c lxc:/// start helloworld
error: Failed to start domain helloworld
error:
Hello!
I haven't done much testing of the resulting project, but
the ./autobuild.sh script is able to cross-build for mingw when run on
a Fedora system, if you have enough of the mingw-* packages installed
on Fedora. This includes mingw64-portablexdr (I have no idea if the
mingw project
Hi
On Tue, Apr 14, 2015 at 6:07 PM, Eric Blake ebl...@redhat.com wrote:
+{ machine, vmport, QEMU_CAPS_MACHINE_VMPORT_OPT },
Ouch. qemu commit 0a7cf21 fixes what would have been a regression in
2.3 at exposing mem-merge through query-command-line-options, but it
does NOT expose vmport,
19.03.2015 18:39, Dmitry Guryanov пишет:
Since we haven't implemented balloon parameters tuning
we can just return amount of memory in this function.
Signed-off-by: Dmitry Guryanov dgurya...@parallels.com
---
src/parallels/parallels_driver.c | 19 +++
1 file changed, 19
On Sun, Apr 19, 2015 at 20:49:07 -0400, John Ferlan wrote:
Ensure that the pool that's being started has a source pool hostname
that can be resolved before trying to start an iSCSI session.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/storage/storage_backend_iscsi.c | 7 +++
On Mon, Apr 20, Ian Campbell wrote:
If what you said were true then an assert would be a rather harsh
overreaction to an application coding error.
Currently both libxl and libvirt are coded that way. Since the sdl code
path in libvirt was never executed the crash in libxlMakeVfbList was not
On Mon, Apr 20, Ian Campbell wrote:
It makes no sense to do that at init time, the whole purpose of a
defbool is to allow the calling application to choose a value or to
explicitly leave it as a request to for the default (which might vary
depending on other selections).
Yes, and thats why
Can somebody add missed functions to libvirt php api binding to
download,resize and upload volume?
--
Vasiliy Tolstov,
e-mail: v.tols...@selfip.ru
jabber: v...@selfip.ru
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Sun, Apr 19, 2015 at 20:49:06 -0400, John Ferlan wrote:
Similar to virGetHostname, but this time taking a parameter which is a
hostname or ipaddress from a source ... host name ='%s'.../... /
XML property and validating that the name can be resolved.
Return true or false depending on
On 04/17/2015 03:10 PM, Ján Tomko wrote:
On Fri, Apr 17, 2015 at 01:31:09PM +0200, Erik Skultety wrote:
According to docs, using 'lun' as a value for device attribute is only valid
with disk types 'block' and 'network'. However current RNG schema also allows
a combination type='file'
it might be worth having sgio attribute defined in a separate block the same way
as rawio attribute.
---
As Jan suggested, I moved unrelated hunks into a separate commit and then
pushed it as trivial.
Erik
docs/schemas/domaincommon.rng | 22 ++
1 file changed, 10
On 18.04.2015 16:34, Kash Pande wrote:
On 18/04/15 04:25 AM, Michal Novotny wrote:
Hi Kash,
there were no patches for libvirt-php for a long time. Are you sure
this is libvirt-php related and not a bug in libvirt itself?
Thanks,
Michal
I've just started using libvirt-php this week but
Hi Jamie,
On Thu, 2015-04-09 at 20:29 -0500, Jamie Strandboge wrote:
On 04/09/2015 04:25 AM, Cédric Bosdonnat wrote:
SLES 11 has legacy qemu-kvm package, /usr/bin/qemu-kvm and
/usr/share/qemu-kvm need to be accessed by domains.
---
examples/apparmor/libvirt-qemu | 9 +
1 file
On Mon, Apr 20, Ian Campbell wrote:
On Fri, 2015-04-17 at 13:40 -0600, Jim Fehlig wrote:
On 04/17/2015 11:19 AM, Olaf Hering wrote:
If the domU configu has sdl enabled libvirtd crashes:
libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion
On Thu, Apr 16, 2015 at 3:43 PM, John Ferlan jfer...@redhat.com wrote:
On 03/17/2015 03:25 PM, Matthias Gatto wrote:
The purpose of these patches is to introduce quorum for libvirt
I've try to follow this proposal:
http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html
Before
So, in the example the cpu stats are collected within a function
called do_top. At the beginning of the function we ask the daemon for
how much vCPUs can we get stats, and how many stats for a vCPU can we
get. This is because it's how our API works - users are required to
preallocate a chunk of
For block devices SDK friendly name do not
refer to block device path but rather some
description while system name refer to
device path.
For ploop devices both names refer to
image path.
Thus system name is better choice.
Signed-off-by: Nikolay Shirokovskiy nshirokovs...@parallels.com
---
On Fri, 2015-04-17 at 13:40 -0600, Jim Fehlig wrote:
On 04/17/2015 11:19 AM, Olaf Hering wrote:
If the domU configu has sdl enabled libvirtd crashes:
libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion
`!libxl_defbool_is_default(db)' failed.
The assertion seems harsh
For block devices SDK friendly name do not
refer to block device path but rather some
description while system name refer to
device path.
For ploop devices both names refer to
image path.
Thus system name is better choice.
Signed-off-by: Nikolay Shirokovskiy nshirokovs...@parallels.com
---
On Mon, 2015-04-20 at 12:32 +0200, Olaf Hering wrote:
On Mon, Apr 20, Ian Campbell wrote:
It makes no sense to do that at init time, the whole purpose of a
defbool is to allow the calling application to choose a value or to
explicitly leave it as a request to for the default (which might
On Mon, 2015-04-20 at 12:20 +0200, Olaf Hering wrote:
On Mon, Apr 20, Ian Campbell wrote:
If what you said were true then an assert would be a rather harsh
overreaction to an application coding error.
Currently both libxl and libvirt are coded that way. Since the sdl code
path in
20.04.2015 9:26, Nikolay Shirokovskiy пишет:
For block devices SDK friendly name do not
refer to block device path but rather some
description while system name refer to
device path.
For ploop devices both names refer to
image path.
Thus system name is better choice.
Signed-off-by: Nikolay
On Mon, 2015-04-20 at 11:32 +0200, Olaf Hering wrote:
On Mon, Apr 20, Ian Campbell wrote:
On Fri, 2015-04-17 at 13:40 -0600, Jim Fehlig wrote:
On 04/17/2015 11:19 AM, Olaf Hering wrote:
If the domU configu has sdl enabled libvirtd crashes:
libvirtd[5158]: libvirtd: libxl.c:343:
On 18.04.2015 03:45, Cole Robinson wrote:
This needs to specified in way too many places for a simple validation
check. The ostype/arch/virttype validation checks later in
DomainDefParseXML should catch most of the cases that this was covering.
---
src/bhyve/bhyve_driver.c | 5 ---
On Mon, Apr 20, 2015 at 15:40:32 +0200, Peter Krempa wrote:
On Sun, Apr 19, 2015 at 20:49:06 -0400, John Ferlan wrote:
Similar to virGetHostname, but this time taking a parameter which is a
hostname or ipaddress from a source ... host name ='%s'.../... /
XML property and validating that the
On 04/20/2015 10:34 AM, Peter Krempa wrote:
On Mon, Apr 20, 2015 at 15:40:32 +0200, Peter Krempa wrote:
On Sun, Apr 19, 2015 at 20:49:06 -0400, John Ferlan wrote:
Similar to virGetHostname, but this time taking a parameter which is a
hostname or ipaddress from a source ... host name
On Sun, Apr 19, 2015 at 08:49:06PM -0400, John Ferlan wrote:
Similar to virGetHostname, but this time taking a parameter which is a
hostname or ipaddress from a source ... host name ='%s'.../... /
XML property and validating that the name can be resolved.
Return true or false depending on
On 18.04.2015 03:45, Cole Robinson wrote:
If no ostype was specified:
before: unknown OS type no OS type
after : xml error: an os type must be specified
If an ostype is specified that's not in our capabiliities data:
before: unknown OS type: $type
after : unsupported configuration:
On Fri, Apr 03, 2015 at 06:11:15PM +0800, Luyao Huang wrote:
There are two bugs in this function:
1. cannot start a vm with cpuset but without numatune settings
# virsh -c lxc:/// start helloworld
error: Failed to start domain helloworld
error: internal error: guest failed to start:
On 02.04.2015 10:02, Luyao Huang wrote:
We introduce a check for numa cpu total count in 5f7b71,
But seems this check cannot work well. There are some scenarioes:
1. one of cpu id is out of maxvcpus, can set success(cpu count = 5 10):
vcpu placement='static'10/vcpu
cell id='0'
On Sun, Apr 19, 2015 at 20:49:09 -0400, John Ferlan wrote:
Prior to attempting to open the gluster connection, let's make sure we
can resolve the source pool hostname.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/storage/storage_backend_gluster.c | 3 +++
1 file changed, 3
On Sun, Apr 19, 2015 at 20:49:12 -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1171984
Use the new virIsSameHostnameInfo API to determine whether the proposed
storage pool definition matches the existing storage pool definition
Signed-off-by: John Ferlan
On 18.04.2015 03:45, Cole Robinson wrote:
First two patches are straight bug fixes.
The rest is a bunch of internal cleanup I felt compelled to do. Summary is
- Switch caps and domain to use an enum for os.type value (hvm, xen, exe, ...)
- Switch caps to use VIR_DOMAIN_VIRT* internally
-
On Sun, Apr 19, 2015 at 08:49:12PM -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1171984
Use the new virIsSameHostnameInfo API to determine whether the proposed
storage pool definition matches the existing storage pool definition
Signed-off-by: John Ferlan
On 18.04.2015 03:45, Cole Robinson wrote:
This is a helper function to look up all capabilities data for all
the OS bits that are relevant to domain. This is
- os type
- arch
- domain type
- emulator
- machine type
This will be used to replace several functions in later commits.
---
On 18.04.2015 03:45, Cole Robinson wrote:
But the internal API stays the same, and we just convert the value as
needed. Not useful yet, but this is the beginning step of using an enum
for ostype throughout the code.
---
src/conf/capabilities.c | 74
On 18.04.2015 03:45, Cole Robinson wrote:
Rather than an opencoded string. This should be a no-op
---
src/bhyve/bhyve_capabilities.c | 2 +-
src/conf/capabilities.c | 11 ++-
src/conf/capabilities.h | 2 +-
src/esx/esx_driver.c | 4 ++--
On 18.04.2015 03:45, Cole Robinson wrote:
---
src/conf/capabilities.c | 55 ---
src/conf/capabilities.h | 10 ++--
src/conf/domain_audit.c | 2 +-
src/conf/domain_conf.c | 115
+++
On Sun, Apr 19, 2015 at 20:49:11 -0400, John Ferlan wrote:
In order to assist with existing pool source hostname validation against
an incoming pool source definition, we need a way to validate that the
resolved hostname provided for the pool doesn't match some existing
pool; otherwise, we'd
On 20 April 2015 at 13:39, Marc-André Lureau marcandre.lur...@gmail.com wrote:
Hi
On Tue, Apr 14, 2015 at 6:07 PM, Eric Blake ebl...@redhat.com wrote:
+{ machine, vmport, QEMU_CAPS_MACHINE_VMPORT_OPT },
Ouch. qemu commit 0a7cf21 fixes what would have been a regression in
2.3 at
On 04/15/2015 02:34 AM, Martin Kletzander wrote:
But this will break on qemu 2.3, unless something changes there. I
don't want to do a version check, but I also don't want something that
works by accident in qemu 2.2 start failing with qemu 2.3.
I'm failing to find any compromise here.
On 04/19/2015 06:38 PM, John Ferlan wrote:
For virStorageBackendStablePath, in order to make decisions in other code
split out the checks regarding whether the pool's target is empty, using /dev,
using /dev/, or doesn't start with /dev
Signed-off-by: John Ferlan jfer...@redhat.com
---
On 04/20/2015 05:41 AM, Michal Privoznik wrote:
So, in the example the cpu stats are collected within a function
called do_top. At the beginning of the function we ask the daemon for
how much vCPUs can we get stats, and how many stats for a vCPU can we
get. This is because it's how our API
...
+/* Check if the pool is using a stable target path. The call to
+ * virStorageBackendStablePath will fail if the pool target path
+ * isn't stable and just return the strdup'd 'devpath' anyway.
+ * This would be indistinguishable to failing to find the stable
+ *
On 04/20/2015 12:56 PM, Nikolay Shirokovskiy wrote:
For block devices SDK friendly name do not
refer to block device path but rather some
description while system name refer to
device path.
For ploop devices both names refer to
image path.
Thus system name is better choice.
Signed-off-by:
On 04/20/2015 12:23 PM, Eric Blake wrote:
On 04/19/2015 06:38 PM, John Ferlan wrote:
For virStorageBackendStablePath, in order to make decisions in other code
split out the checks regarding whether the pool's target is empty, using
/dev,
using /dev/, or doesn't start with /dev
On 04/20/2015 09:25 AM, Nikolay Shirokovskiy wrote:
In Parallels we do not support device name hints
aka target dev=../ option and full-fledged device
disk device addressing through
address type=.. controller=.. bus=.. target=.. unit=../
and have only one index instead.
In this situation to be
On 04/20/2015 09:24 AM, Nikolay Shirokovskiy wrote:
We should return VIR_DRV_OPEN_ERROR in case
if we handle scheme in query but some
error occur. Previously we sometimes
return VIR_DRV_OPEN_DECLINE.
Signed-off-by: Nikolay Shirokovskiy nshirokovs...@parallels.com
---
Commit 70f446631f142ae92b4d4eb349fcf11408171556 (from 2008) introduced
some functions for testing whether xend was returning correct sound
models. Those functions have long gone, but the function prototypes
remain. This commit removes the unused prototypes.
Signed-off-by: Richard W.M. Jones
s/valid/stable/ in the subject
On Sun, Apr 19, 2015 at 08:38:33PM -0400, John Ferlan wrote:
For virStorageBackendStablePath, in order to make decisions in other code
split out the checks regarding whether the pool's target is empty, using /dev,
using /dev/, or doesn't start with /dev
On Sun, Apr 19, 2015 at 08:38:34PM -0400, John Ferlan wrote:
Use virStorageBackendPoolUseDevPath API to determine whether creation of
stable target path is possible for the volume.
This will differentiate a failed virStorageBackendStablePath which won't
need to be fatal. Thus, we'll add a -2
On 04/20/2015 11:11 AM, Ján Tomko wrote:
On Sun, Apr 19, 2015 at 08:49:12PM -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1171984
Use the new virIsSameHostnameInfo API to determine whether the proposed
storage pool definition matches the existing storage pool
On Sun, Apr 19, 2015 at 08:38:35PM -0400, John Ferlan wrote:
Rather than passing/returning a pointer to a boolean to indicate that
perhaps we should try again - adjust the return of the call to return
the count of LU's found during processing, then let the caller decide
what to do with that
As a hindsight from reviewing 6/7. This function should also be in
virsocketaddr.c
hmmm.. yes I see.. Guess I got hung up on virSocketAddr... and didn't
focus as closely on the implementation where virSocketAddrParse can take
NULL as the first parameter... Guess, that means patches
On 04/20/2015 09:41 AM, Peter Krempa wrote:
On Sun, Apr 19, 2015 at 20:49:07 -0400, John Ferlan wrote:
Ensure that the pool that's being started has a source pool hostname
that can be resolved before trying to start an iSCSI session.
Signed-off-by: John Ferlan jfer...@redhat.com
---
On 04/20/2015 09:45 AM, Peter Krempa wrote:
On Sun, Apr 19, 2015 at 20:49:09 -0400, John Ferlan wrote:
Prior to attempting to open the gluster connection, let's make sure we
can resolve the source pool hostname.
Signed-off-by: John Ferlan jfer...@redhat.com
---
In Parallels we do not support device name hints
aka target dev=../ option and full-fledged device
disk device addressing through
address type=.. controller=.. bus=.. target=.. unit=../
and have only one index instead.
In this situation to be consistent we can only take
one-to-one mapping from
We should return VIR_DRV_OPEN_ERROR in case
if we handle scheme in query but some
error occur. Previously we sometimes
return VIR_DRV_OPEN_DECLINE.
Signed-off-by: Nikolay Shirokovskiy nshirokovs...@parallels.com
---
src/parallels/parallels_network.c |2 +-
src/parallels/parallels_storage.c |
For block devices SDK friendly name do not
refer to block device path but rather some
description while system name refer to
device path.
For ploop devices both names refer to
image path.
Thus system name is better choice.
Signed-off-by: Nikolay Shirokovskiy nshirokovs...@parallels.com
---
66 matches
Mail list logo
