[libvirt] [PATCH] qemu: cgroup: Fix priorities when setting emulatorpin

2015-04-23 Thread Peter Krempa
Use the custom emulator pin setting with the highest priority same as with vcpupin. --- src/qemu/qemu_cgroup.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index e83342d..bf0621f 100644 --- a/src/qemu/qemu_cgroup.c +++

[libvirt] [PATCH] build: avoid obsolete index()

2015-04-23 Thread Eric Blake
Commit 2a530a3e5 is not portable to mingw, which intentionally avoids declaring the obsolete index(). See also: https://bugzilla.redhat.com/show_bug.cgi?id=1214605 * src/util/virstring.c (virStringStripControlChars): Use strchr. Signed-off-by: Eric Blake ebl...@redhat.com --- Pushing under the

Re: [libvirt] [PATCH v4 8/9] qemu: Add support to Add/Delete IOThreads

2015-04-23 Thread John Ferlan
On 04/23/2015 09:22 AM, Peter Krempa wrote: On Tue, Apr 21, 2015 at 19:31:29 -0400, John Ferlan wrote: Add qemuDomainAddIOThread and qemuDomainDelIOThread in order to add or remove an IOThread to/from the host either for live or config optoins The implementation for the 'live' option will

Re: [libvirt] [RFC 0/7] Live Migration with Pass-through Devices proposal

2015-04-23 Thread Laine Stump
On 04/23/2015 04:34 AM, Chen Fan wrote: On 04/20/2015 06:29 AM, Laine Stump wrote: On 04/17/2015 04:53 AM, Chen Fan wrote: - on destination side, check whether need to hotplug new NIC according to specified XML. usually, we use migrate --xml command option to specify the destination

Re: [libvirt] [PATCH v4 4/9] Move iothreadspin information into iothreadids

2015-04-23 Thread John Ferlan
... + +if (!(iothrid = virDomainIOThreadIDFind(def, iothreadid))) { +if (!(iothrid = virDomainIOThreadIDAdd(def, iothreadid))) Why are you adding a iothread definition here? This code is executed after the iothread info should already be parsed so adding a thread here doesn't

Re: [libvirt] [RFC 0/7] Live Migration with Pass-through Devices proposal

2015-04-23 Thread Laine Stump
On 04/22/2015 12:22 AM, Chen Fan wrote: Hi Laine, Thanks for your review for my patches. and do you know that solarflare's patches have made some update version since https://www.redhat.com/archives/libvir-list/2012-November/msg01324.html ? if not, I hope to go on to complete this

Re: [libvirt] [PATCH v4 1/9] conf: Add new domain XML element 'iothreadids'

2015-04-23 Thread John Ferlan
... @@ -3298,6 +3325,21 @@ virDomainDefPostParseInternal(virDomainDefPtr def, return -1; } +/* Fully populate the IOThread ID list */ +if (def-iothreads def-iothreads != def-niothreadids) { +unsigned int iothread_id = 1; +while

[libvirt] [PATCH 0/2] parallels: implement domainDetachDevice and domainDetachDeviceFlags

2015-04-23 Thread Maxim Nestratov
Maxim Nestratov (2): parallels: add prlsdkDelDisk and prlsdkGetDiskIndex functions parallels: implement domainDetachDevice and domainDetachDeviceFlags -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 2/2] parallels: implement domainDetachDevice and domainDetachDeviceFlags

2015-04-23 Thread Maxim Nestratov
New functions utilize previosly added prlsdkDelDisk and prlsdkGetDiskIndex Signed-off-by: Maxim Nestratov mnestra...@parallels.com --- src/parallels/parallels_driver.c | 71 ++ src/parallels/parallels_sdk.c| 30

[libvirt] [PATCH 1/2] parallels: add prlsdkDelDisk and prlsdkGetDiskIndex functions

2015-04-23 Thread Maxim Nestratov
Signed-off-by: Maxim Nestratov mnestra...@parallels.com --- src/parallels/parallels_sdk.c | 65 + 1 files changed, 65 insertions(+), 0 deletions(-) diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c index d54f894..5e6e21c 100644

[libvirt] [PATCH 3/4] tests: Add virtTestCompareToFile

2015-04-23 Thread Cole Robinson
Replaces a common pattern used in many test files --- tests/bhyvexml2argvtest.c| 41 ++-- tests/bhyvexml2xmltest.c | 9 + tests/cputest.c | 11 +-- tests/domaincapstest.c | 9 +

[libvirt] [PATCH 1/4] tests: Add VIR_TEST_DEBUG and VIR_TEST_VERBOSE

2015-04-23 Thread Cole Robinson
To remove a bunch of TestGetDebug()/TestGetVerbose() checks --- tests/cputest.c | 34 - tests/jsontest.c | 48 + tests/nodeinfotest.c | 2 +- tests/qemuargv2xmltest.c | 15 ++-- tests/qemuhelptest.c | 6 +-

[libvirt] [PATCH 2/4] tests: Use *DefParseFile more

2015-04-23 Thread Cole Robinson
--- tests/bhyvexml2xmltest.c | 9 ++--- tests/domainconftest.c | 7 +-- tests/lxcxml2xmltest.c | 8 ++-- tests/networkxml2conftest.c| 7 +-- tests/networkxml2xmltest.c | 6 +- tests/networkxml2xmlupdatetest.c | 6 +-

[libvirt] [PATCH 0/4] tests: Cleanups and improvements

2015-04-23 Thread Cole Robinson
First 3 patches are uninteresting cleanups, removing a bunch of boiler plate code. The last patch adds a way to easily regenerate test output, like when adding a new test case (plop in the qemu XML, use the env var and the test suite will create foo.args for you), or when a code changes causes

[libvirt] [PATCH 5/5] virDomainObjList: Introduce yet another hash table

2015-04-23 Thread Michal Privoznik
This hash table will contain the same data as already existing one. The only difference is that while the first table uses domain uuid as key, the new table uses domain name. This will allow much faster (and lockless) lookups by domain name. Signed-off-by: Michal Privoznik mpriv...@redhat.com ---

[libvirt] [PATCH 3/5] Introduce virDomainObjEndAPI

2015-04-23 Thread Michal Privoznik
This is basically turning qemuDomObjEndAPI into a more general function. Other drivers which gets a reference to domain objects may benefit from this function too. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/conf/domain_conf.c | 22 ++ src/conf/domain_conf.h

Re: [libvirt] [Qemu-devel] [RFC 0/7] Live Migration with Pass-through Devices proposal

2015-04-23 Thread Laine Stump
On 04/22/2015 01:20 PM, Dr. David Alan Gilbert wrote: * Daniel P. Berrange (berra...@redhat.com) wrote: On Wed, Apr 22, 2015 at 06:12:25PM +0100, Dr. David Alan Gilbert wrote: * Daniel P. Berrange (berra...@redhat.com) wrote: On Wed, Apr 22, 2015 at 06:01:56PM +0100, Dr. David Alan Gilbert

[libvirt] [PATCH v2] parallels: fix crash in prlsdkAddNet in case of CT definition

2015-04-23 Thread Maxim Nestratov
Since net-model is not defined for containers we shouldn't touch it. In case network adapter model is defined, a warning about ignoring it is shown. Signed-off-by: Maxim Nestratov mnestra...@parallels.com --- src/parallels/parallels_sdk.c | 29 ++--- 1 files changed, 18

Re: [libvirt] [PATCH v4 0/9] Implement Add/Del IOThreads

2015-04-23 Thread John Ferlan
So obviously I messed something up with the threading on the responses - thought I had it right, but not quite I guess. Oh well - I think it's obvious what I was trying to do ;-) v5 updates: Patch 1/10 (forgot to edit the 10) * Fixes the syntax check * Moves the PostParse autofill of

[libvirt] [PATCH v2 6/9] sheepdog: Check for validity of pool source hostname

2015-04-23 Thread John Ferlan
If there is a pool source hostname provided, let's make sure the name can be resolved before trying to connect to it via a virCommand sequence. Signed-off-by: John Ferlan jfer...@redhat.com --- src/storage/storage_backend_sheepdog.c | 38 +- 1 file changed, 24

[libvirt] [PATCH v2 2/9] socketaddr: Introduce virSocketAddrParseName

2015-04-23 Thread John Ferlan
Add a new function virSocketAddrParseName which unlike virSocketAddrParse will be capable of processing a network address that needs to be looked up and resolved. Signed-off-by: John Ferlan jfer...@redhat.com --- src/libvirt_private.syms | 1 + src/util/virsocketaddr.c | 52

[libvirt] [PATCH 2/2] network: check for bridge name conflict with existing devices

2015-04-23 Thread Laine Stump
Since some people use the same naming convention as libvirt for bridge devices they create outside the context of libvirt, it is much nicer if we check for those devices when looking for a bridge device name to auto-assign to a new network. --- src/network/bridge_driver.c | 25

[libvirt] [PATCH 0/2] skip names of devices already existing on host when auto-assigning bridge name

2015-04-23 Thread Laine Stump
Shivaprasad Bhat earlier sent patches to fix this problem which added a call to virNetDevExists() in the conf directory: https://www.redhat.com/archives/libvir-list/2015-March/msg00397.html (V1) https://www.redhat.com/archives/libvir-list/2015-March/msg00569.html (V2)

[libvirt] [PATCH 1/2] network: move auto-assign of bridge name from XML parser to net driver

2015-04-23 Thread Laine Stump
We already check that any auto-assigned bridge device name for a virtual network (e.g. virbr1) doesn't conflict with the bridge name for any existing libvirt network (via virNetworkSetBridgeName() in conf/network_conf.c). We also want to check that the name doesn't conflict with any bridge device

[libvirt] [PATCH v2 8/9] virsocketaddr: Introduce virSocketAddrIsSameTCPHost

2015-04-23 Thread John Ferlan
Add new API to be able to compare two TCP host name strings or numeric IP Addresses in order to determine if the resolved and translated names match. Signed-off-by: John Ferlan jfer...@redhat.com --- src/libvirt_private.syms | 1 + src/util/virsocketaddr.c | 62

[libvirt] [PATCH v2 9/9] storage: Check for duplicate resolved host name at pool create

2015-04-23 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1171984 During storage pool Create or CreateXML add a call prior to the backend startPool that will compare the resolved source host name of the network storage pool to be started against the active, network storage pools resolved host name to ensure

[libvirt] [PATCH v2 7/9] virsockaddr: Split up functionality of virSocketAddrFormatFull

2015-04-23 Thread John Ferlan
Create a local API virSocketAddrGetNumericHost which can be used by a future patch in order to obtain the numeric host nameinfo data Signed-off-by: John Ferlan jfer...@redhat.com --- src/util/virsocketaddr.c | 60 ++-- 1 file changed, 38 insertions(+),

[libvirt] [PATCH v2 1/9] socketaddr: Add isNumeric flag to virSocketAddrParseInternal

2015-04-23 Thread John Ferlan
Adjust virSocketAddrParseInternal to take a boolean 'isNumeric' in order to determine whether to set ai_flags = AI_NUMERICHOST; - IOW - expect a numeric IP Address of sorts in the 'val' to be resolved. Signed-off-by: John Ferlan jfer...@redhat.com --- src/util/virsocketaddr.c | 10 ++ 1

[libvirt] [PATCH v2 5/9] gluster: Check for validity of pool source hostname

2015-04-23 Thread John Ferlan
Prior to attempting to open the gluster connection, let's make sure we can resolve the source pool hostname. Signed-off-by: John Ferlan jfer...@redhat.com --- src/storage/storage_backend_gluster.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH v2 0/9] Additional host name check for network storage pools

2015-04-23 Thread John Ferlan
v1 here: http://www.redhat.com/archives/libvir-list/2015-April/msg00873.html Essentially a rewrite of v1 changing to use virsocketaddr.* rather than virutil.* Also making check for hostname duplication prior to startPool rather than during XML processing John Ferlan (9): socketaddr: Add

[libvirt] [PATCH v2 3/9] iscsi: Check for validity of pool source hostname

2015-04-23 Thread John Ferlan
Ensure that the pool that's being started has a source pool hostname that can be resolved before trying to start an iSCSI session. Signed-off-by: John Ferlan jfer...@redhat.com --- src/storage/storage_backend_iscsi.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH v2 4/9] netfs: Check for validity of pool source hostname

2015-04-23 Thread John Ferlan
Before attempting to mount the netfs pool, ensure the source pool hostname can be resolved to something this host knows. Signed-off-by: John Ferlan jfer...@redhat.com --- src/storage/storage_backend_fs.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH v5 04/9] Move iothreadspin information into iothreadids

2015-04-23 Thread John Ferlan
Remove the iothreadspin array from cputune and replace with a cpumask to be stored in the iothreadids list. Adjust the test output because our printing goes in order of the iothreadids list now. Signed-off-by: John Ferlan jfer...@redhat.com --- docs/formatdomain.html.in

Re: [libvirt] [PATCH 2/4] tests: Use *DefParseFile more

2015-04-23 Thread Laine Stump
On 04/23/2015 02:19 PM, Cole Robinson wrote: --- tests/bhyvexml2xmltest.c | 9 ++--- tests/domainconftest.c | 7 +-- tests/lxcxml2xmltest.c | 8 ++-- tests/networkxml2conftest.c| 7 +-- tests/networkxml2xmltest.c | 6

Re: [libvirt] [PATCH] qemu: cgroup: Fix priorities when setting emulatorpin

2015-04-23 Thread John Ferlan
On 04/23/2015 10:19 AM, Peter Krempa wrote: Use the custom emulator pin setting with the highest priority same as with vcpupin. --- src/qemu/qemu_cgroup.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ACK - John (FWIW: I'll adjust my code to follow) -- libvir-list

[libvirt] [PATCH v5 01/10] conf: Add new domain XML element 'iothreadids'

2015-04-23 Thread John Ferlan
Adding a new XML element 'iothreadids' in order to allow defining specific IOThread ID's rather than relying on the algorithm to assign IOThread ID's starting at 1 and incrementing to iothreads count. This will allow future patches to be able to add new IOThreads by a specific iothread_id and of

[libvirt] [PATCH v5 8/9] qemu: Add support to Add/Delete IOThreads

2015-04-23 Thread John Ferlan
Add qemuDomainAddIOThread and qemuDomainDelIOThread in order to add or remove an IOThread to/from the host either for live or config optoins The implementation for the 'live' option will use the iothreadpids list in order to make decision, while the 'config' option will use the iothreadids list.

[libvirt] [PATCH v5 7.5/9] domain: Introduce virDomainIOThreadSchedDelId

2015-04-23 Thread John Ferlan
We're about to allow IOThreads to be deleted, but an iothreadid may be included in some domain thread sched, so add a new API to allow removing an iothread from some entry. Then during the writing of the threadsched data and an additional check to determine whether the bitmap is all clear before

Re: [libvirt] [PATCH 3/4] tests: Add virtTestCompareToFile

2015-04-23 Thread Laine Stump
On 04/23/2015 02:19 PM, Cole Robinson wrote: Replaces a common pattern used in many test files --- tests/bhyvexml2argvtest.c| 41 ++-- tests/bhyvexml2xmltest.c | 9 + tests/cputest.c | 11 +--

[libvirt] [PATCH v5 05/9] conf: Adjust the iothreadsched expectations

2015-04-23 Thread John Ferlan
With iothreadid's allowing any 'id' value for an iothread_id, the iothreadsched code needs a slight adjustment to allow for any unsigned int value in order to create the bitmap of ids that will have scheduler adjustments. Adjusted the doc description as well. Signed-off-by: John Ferlan

Re: [libvirt] [PATCH 1/4] tests: Add VIR_TEST_DEBUG and VIR_TEST_VERBOSE

2015-04-23 Thread Laine Stump
On 04/23/2015 02:19 PM, Cole Robinson wrote: To remove a bunch of TestGetDebug()/TestGetVerbose() checks --- tests/cputest.c | 34 - tests/jsontest.c | 48 + tests/nodeinfotest.c | 2 +- tests/qemuargv2xmltest.c |

Re: [libvirt] [PATCH 4/4] tests: Add VIR_TEST_REGENERATE_OUTPUT

2015-04-23 Thread Laine Stump
On 04/23/2015 02:20 PM, Cole Robinson wrote: If this enviroment variable is set, the virTestCompareToFile helper will overwrite the file content we are comparing against, if the file doesn't exist or it doesn't match the expected input. This is useful when adding new test cases, or making

[libvirt] [PATCH] tests: qemu: Couple aarch64 CPU tests

2015-04-23 Thread Cole Robinson
- Make sure aarch64 host-passthrough works correctly - Make sure libvirt doesn't choke on cpu model=host, which is what virt-install/virt-manager were incorrectly specifying up until recently. --- .../qemuxml2argv-aarch64-cpu-model-host.args | 1 +

Re: [libvirt] [PATCH 4/4] tests: Add VIR_TEST_REGENERATE_OUTPUT

2015-04-23 Thread Cole Robinson
On 04/23/2015 03:46 PM, Laine Stump wrote: On 04/23/2015 02:20 PM, Cole Robinson wrote: If this enviroment variable is set, the virTestCompareToFile helper will overwrite the file content we are comparing against, if the file doesn't exist or it doesn't match the expected input. This is

[libvirt] [PATCH 2/5] virDomainObjListNew: Use virObjectFreeHashData

2015-04-23 Thread Michal Privoznik
There's no point in duplicating virObjectFreeHashData() in a separate function. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/conf/domain_conf.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

[libvirt] [PATCH 1/5] virDomainObjListAddLocked: s/false/NULL/ for @oldDef

2015-04-23 Thread Michal Privoznik
It's a pointer after all. We should initialize it to NULL instead of false. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9aad782..ccd3bdf

[libvirt] [PATCH 4/5] virDomainObjListFindByName: Return referenced object

2015-04-23 Thread Michal Privoznik
Every domain that grabs a domain object to work over should reference it to make sure it won't disappear meanwhile. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/bhyve/bhyve_driver.c | 3 +- src/conf/domain_conf.c | 1 + src/libxl/libxl_driver.c | 10

[libvirt] [PATCH 0/5] Make virDomainObjListFindByName run in O(1)

2015-04-23 Thread Michal Privoznik
As discussed here: https://www.redhat.com/archives/libvir-list/2015-April/msg01135.html Michal Privoznik (5): virDomainObjListAddLocked: s/false/NULL/ for @oldDef virDomainObjListNew: Use virObjectFreeHashData Introduce virDomainObjEndAPI virDomainObjListFindByName: Return referenced

[libvirt] [PATCH 4/4] tests: Add VIR_TEST_REGENERATE_OUTPUT

2015-04-23 Thread Cole Robinson
If this enviroment variable is set, the virTestCompareToFile helper will overwrite the file content we are comparing against, if the file doesn't exist or it doesn't match the expected input. This is useful when adding new test cases, or making changes that generate a lot of output churn. ---

[libvirt] [PATCH 0/4] qemu: Fix issues with socket/nvram directories

2015-04-23 Thread Cole Robinson
Couple cleanups and bug fixes dealing with qemu directory creation and permissions. Cole Robinson (4): qemu: conf: Clarify paths that are relative to libDir qemu: chown autoDumpPath on driver startup qemu: Build channel autosocket directory at driver startup qemu: Build nvram directory at

Re: [libvirt] [PATCH] parallels: implement .domainGetMaxMemory

2015-04-23 Thread Maxim Nestratov
20.04.2015 14:43, Maxim Nestratov пишет: 19.03.2015 18:39, Dmitry Guryanov пишет: Since we haven't implemented balloon parameters tuning we can just return amount of memory in this function. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c | 19

Re: [libvirt] [PATCH v4 4/9] Move iothreadspin information into iothreadids

2015-04-23 Thread John Ferlan
On 04/23/2015 08:02 AM, Peter Krempa wrote: On Tue, Apr 21, 2015 at 19:31:25 -0400, John Ferlan wrote: Remove the iothreadspin array from cputune and replace with a cpumask to be stored in the iothreadids list Signed-off-by: John Ferlan jfer...@redhat.com --- docs/formatdomain.html.in |

Re: [libvirt] [PATCH] parallels: implement .domainGetMaxMemory

2015-04-23 Thread Dmitry Guryanov
On 04/23/2015 03:55 PM, Maxim Nestratov wrote: 20.04.2015 14:43, Maxim Nestratov пишет: 19.03.2015 18:39, Dmitry Guryanov пишет: Since we haven't implemented balloon parameters tuning we can just return amount of memory in this function. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com

[libvirt] [libvirt-test-API][PATCH 2/3] Modify the case to cover two new APIs

2015-04-23 Thread jiahu
Test below 2 APIs in this case: networkLookupByUUIDString/networkLookupByUUID --- repos/network/network_uuid.py | 68 --- 1 file changed, 58 insertions(+), 10 deletions(-) diff --git a/repos/network/network_uuid.py b/repos/network/network_uuid.py index

[libvirt] [libvirt-test-API][PATCH 1/3] Add two testing cases to test_connection.conf

2015-04-23 Thread jiahu
Below 4 new APIs will be tested networkLookupByUUIDString/networkLookupByUUID storagePoolLookupByUUIDString/storagePoolLookupByUUID --- cases/test_connection.conf | 8 1 file changed, 8 insertions(+) diff --git a/cases/test_connection.conf b/cases/test_connection.conf index

Re: [libvirt] [PATCH] qemu: lock: unlock vm during qemuBuildCommandLine

2015-04-23 Thread Peter Krempa
On Thu, Apr 23, 2015 at 11:44:49 +0800, zhang bo wrote: The function qemuBuildCommandLine() may take a long time, for example if we configure tens of vifs for the guest, each may cost hundrands of milliseconds to create tap dev, senconds in total. Thus, unlock vm before calling it.

[libvirt] [PATCH] util: string: Avoid use of deprecated function index()

2015-04-23 Thread Peter Krempa
--- src/util/virstring.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/util/virstring.c b/src/util/virstring.c index 1cd4987..e48c29a 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -976,6 +976,21 @@ static const char control_chars[] =

Re: [libvirt] [PATCH] util: string: Avoid use of deprecated function index()

2015-04-23 Thread Daniel P. Berrange
On Thu, Apr 23, 2015 at 10:48:06AM +0200, Peter Krempa wrote: --- src/util/virstring.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/util/virstring.c b/src/util/virstring.c index 1cd4987..e48c29a 100644 --- a/src/util/virstring.c +++

Re: [libvirt] [PATCH 0/4] Introduce parallelsDomObjFromDomain()

2015-04-23 Thread Maxim Nestratov
22.04.2015 19:35, Michal Privoznik пишет: We have such wrapper in other drivers too: qemu, lxc, network, ... Michal Privoznik (4): struct _parallelsConn: Mark @domains as immutable pointer parallels: Introduce parallelsDomObjFromDomain() parallels_driver: Utilize

[libvirt] [libvirt-test-API][PATCH 3/3] Modify the case to cover two new APIs

2015-04-23 Thread jiahu
Check two new APIs in this case: storagePoolLookupByUUIDString/storagePoolLookupByUUID --- repos/storage/pool_uuid.py | 49 +- 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/repos/storage/pool_uuid.py b/repos/storage/pool_uuid.py index

[libvirt] [PATCH 2/2] Apparmor: allow reading block-rbd.so

2015-04-23 Thread Cédric Bosdonnat
--- examples/apparmor/libvirt-qemu | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/apparmor/libvirt-qemu b/examples/apparmor/libvirt-qemu index 4f0bb1b..c80ece7 100644 --- a/examples/apparmor/libvirt-qemu +++ b/examples/apparmor/libvirt-qemu @@ -114,6 +114,7 @@

[libvirt] [PATCH 0/2] Apparmor PCI passthrough fixes

2015-04-23 Thread Cédric Bosdonnat
Hi all, These two simple patches intend to fix apparmor profiles for PCI passthrough with the qemu driver. Cédric Bosdonnat (2): Allow access to vendor and device file for PCI device passthrough Apparmor: allow reading block-rbd.so examples/apparmor/libvirt-qemu | 1 + src/util/virpci.c

[libvirt] [PATCH 1/2] Allow access to vendor and device file for PCI device passthrough

2015-04-23 Thread Cédric Bosdonnat
For some devices, the $PCIDIR/vendor and $PCIDIR/device need to be read. Iterate over them to get them as well in the the generated apparmor profile. --- src/util/virpci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virpci.c b/src/util/virpci.c index

[libvirt] [PATCH] bhyve: fix build in tests

2015-04-23 Thread Roman Bogorodskiy
Commit 835cf84 dropped expectedVirtTypes argument for virDomainDefParse*() functions, however bhyve tests still try to pass that to virDomainDefParseFile(), therefore build fails. Fix build by fixing virDomainDefParseFile() usage. --- tests/bhyvexml2argvtest.c | 1 - tests/bhyvexml2xmltest.c |

Re: [libvirt] [PATCH] qemu: Don't fail to reboot domains with unresponsive agent

2015-04-23 Thread Michal Privoznik
On 23.04.2015 05:40, zhang bo wrote: just as what b8e25c35d7f80a2fadc0e51e95318e39db3d1687 did, we fall back to the ACPI method when the guest agent is unresponsive in qemuDomainReboot. Signed-off-by: YueWenyuan yueweny...@huawei.com Signed-off-by: Zhang Bo oscar.zhan...@huawei.com ---

Re: [libvirt] [PATCH v4 3/9] conf: Move virDomainPinIsDuplicate and make static

2015-04-23 Thread Peter Krempa
On Tue, Apr 21, 2015 at 19:31:24 -0400, John Ferlan wrote: Since it's only ever referenced in domain_conf.c, make the function static, but also will need to move it to somewhere before it's referenced rather than forward referencing it. Signed-off-by: John Ferlan jfer...@redhat.com ---

Re: [libvirt] [PATCH 0/2] Apparmor PCI passthrough fixes

2015-04-23 Thread Michal Privoznik
On 23.04.2015 09:38, Cédric Bosdonnat wrote: Hi all, These two simple patches intend to fix apparmor profiles for PCI passthrough with the qemu driver. Cédric Bosdonnat (2): Allow access to vendor and device file for PCI device passthrough Apparmor: allow reading block-rbd.so

Re: [libvirt] [RFC 0/7] Live Migration with Pass-through Devices proposal

2015-04-23 Thread Chen Fan
On 04/20/2015 06:29 AM, Laine Stump wrote: On 04/17/2015 04:53 AM, Chen Fan wrote: backgrond: Live migration is one of the most important features of virtualization technology. With regard to recent virtualization techniques, performance of network I/O is critical. Current network I/O

[libvirt] [PATCH] migration: Usable time statistics without requiring NTP

2015-04-23 Thread Jiri Denemark
virDomainGetJobStats is able to report statistics of a completed migration, however to get usable downtime and total time statistics both hosts have to keep synchronized time. To provide at least some estimation of the times even when NTP daemons are not running on both hosts we can just ignore

[libvirt] [libvirt-test-API][PATCH 0/3] Modify the existing cases to cover 4 new APIs

2015-04-23 Thread jiahu
Modify the existing cases to cover below 4 new APIs: networkLookupByUUIDString/networkLookupByUUID storagePoolLookupByUUIDString/storagePoolLookupByUUID jiahu (3): Add two testing cases to test_connection.conf Modify the case to cover two new APIs Modify the case to cover two new APIs

Re: [libvirt] [PATCH] bhyve: fix build in tests

2015-04-23 Thread Peter Krempa
On Thu, Apr 23, 2015 at 10:55:12 +0400, Roman Bogorodskiy wrote: Commit 835cf84 dropped expectedVirtTypes argument for virDomainDefParse*() functions, however bhyve tests still try to pass that to virDomainDefParseFile(), therefore build fails. Fix build by fixing virDomainDefParseFile()

Re: [libvirt] [PATCH] bhyve: fix build in tests

2015-04-23 Thread Roman Bogorodskiy
Peter Krempa wrote: On Thu, Apr 23, 2015 at 10:55:12 +0400, Roman Bogorodskiy wrote: Commit 835cf84 dropped expectedVirtTypes argument for virDomainDefParse*() functions, however bhyve tests still try to pass that to virDomainDefParseFile(), therefore build fails. Fix build by

Re: [libvirt] [PATCH] qemu: lock: unlock vm during qemuBuildCommandLine

2015-04-23 Thread Michal Privoznik
On 23.04.2015 10:30, Peter Krempa wrote: On Thu, Apr 23, 2015 at 11:44:49 +0800, zhang bo wrote: The function qemuBuildCommandLine() may take a long time, for example if we configure tens of vifs for the guest, each may cost hundrands of milliseconds to create tap dev, senconds in total. Thus,

Re: [libvirt] [PATCH] qemu: lock: unlock vm during qemuBuildCommandLine

2015-04-23 Thread Daniel P. Berrange
On Thu, Apr 23, 2015 at 11:19:34AM +0200, Michal Privoznik wrote: On 23.04.2015 10:30, Peter Krempa wrote: On Thu, Apr 23, 2015 at 11:44:49 +0800, zhang bo wrote: The function qemuBuildCommandLine() may take a long time, for example if we configure tens of vifs for the guest, each may cost

Re: [libvirt] [PATCH] qemu: lock: unlock vm during qemuBuildCommandLine

2015-04-23 Thread Peter Krempa
On Thu, Apr 23, 2015 at 11:19:34 +0200, Michal Privoznik wrote: On 23.04.2015 10:30, Peter Krempa wrote: On Thu, Apr 23, 2015 at 11:44:49 +0800, zhang bo wrote: The function qemuBuildCommandLine() may take a long time, for example if we configure tens of vifs for the guest, each may cost

Re: [libvirt] [PATCH] migration: Usable time statistics without requiring NTP

2015-04-23 Thread Michal Privoznik
On 23.04.2015 11:18, Jiri Denemark wrote: virDomainGetJobStats is able to report statistics of a completed migration, however to get usable downtime and total time statistics both hosts have to keep synchronized time. To provide at least some estimation of the times even when NTP daemons are

Re: [libvirt] [PATCH] qemu: lock: unlock vm during qemuBuildCommandLine

2015-04-23 Thread Michal Privoznik
On 23.04.2015 11:32, Peter Krempa wrote: On Thu, Apr 23, 2015 at 11:19:34 +0200, Michal Privoznik wrote: On 23.04.2015 10:30, Peter Krempa wrote: On Thu, Apr 23, 2015 at 11:44:49 +0800, zhang bo wrote: The function qemuBuildCommandLine() may take a long time, for example if we configure tens

Re: [libvirt] [PATCH] qemu: lock: unlock vm during qemuBuildCommandLine

2015-04-23 Thread zhang bo
On 2015/4/23 17:46, Michal Privoznik wrote: On 23.04.2015 11:32, Peter Krempa wrote: On Thu, Apr 23, 2015 at 11:19:34 +0200, Michal Privoznik wrote: On 23.04.2015 10:30, Peter Krempa wrote: On Thu, Apr 23, 2015 at 11:44:49 +0800, zhang bo wrote: The function qemuBuildCommandLine() may take a

Re: [libvirt] [PATCH] qemu: lock: unlock vm during qemuBuildCommandLine

2015-04-23 Thread Daniel P. Berrange
On Thu, Apr 23, 2015 at 07:00:21PM +0800, zhang bo wrote: The reason for the problem is that: 1 guestA locks vm while creating each tapDev(virNetDevTapCreate) in qemuBuildCommandLine(), for 10seconds 2 guestB calls qemuMigrationPrepareAny-*virDomainObjListAdd* to get its vm object, which

[libvirt] [PATCH v5 6/9] virstoragefile: Add quorum in virstoragefile

2015-04-23 Thread Matthias Gatto
Add VIR_STORAGE_TYPE_QUORUM in virStorageType. Add VIR_STORAGE_FILE_QUORUM in virStorageFileFormat. Add threshold value in _virStorageSource Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- docs/formatdomain.html.in | 23 --- docs/schemas/domaincommon.rng

[libvirt] [PATCH v5 8/9] qemu: Add quorum support in qemuBuildDriveDevStr

2015-04-23 Thread Matthias Gatto
Allow to libvirt to build the quorum string used by quemu. Add 2 static functions: qemuBuildQuorumStr and qemuBuildAndAppendDriveStrToVirBuffer. qemuBuildQuorumStr is made because a quorum can have another quorum as a child, so we may need to call qemuBuildQuorumStr recursively.

[libvirt] [PATCH v5 2/9] virstoragefile: Always use virStorageSourceGetBackingStore to get backing store

2015-04-23 Thread Matthias Gatto
Uniformize backing store usage by calling virStorageSourceGetBackingStore instead of setting backing store manually. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/domain_conf.c| 7 ---

[libvirt] [PATCH v5 7/9] domain_conf: Read and Write quorum config

2015-04-23 Thread Matthias Gatto
Add the capabiltty to libvirt to parse and format the quorum syntax as described here: http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/conf/domain_conf.c | 164 +++-- 1

[libvirt] [PATCH v5 3/9] virstoragefile: Add virStorageSourceSetBackingStore

2015-04-23 Thread Matthias Gatto
As explained for virStorageSourceGetBackingStore, quorum allows multiple backing store, this make the operation to set bs complex because we have to check if the backingStore is used as an array or a pointer, and set it differently in both case. In order to help the manipulation of backing store,

[libvirt] [PATCH v5 0/9] qemu: Add quorum support to libvirt

2015-04-23 Thread Matthias Gatto
The purpose of these patches is to introduce quorum for libvirt I've try to follow this proposal: http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html This feature ask for 6 task: 1) Allow a _virStorageSource to contain more than one backing store. Because all the actual libvirt

[libvirt] [PATCH v5 1/9] virstoragefile: Add virStorageSourceGetBackingStore

2015-04-23 Thread Matthias Gatto
Create virStorageSourceGetBackingStore function in preparation for quorum: Actually, if we want to get a backing store inside a virStorageSource we have to do it manually(src-backingStore = backingStore). The problem is that with a quorum, a virStorageSource can contain multiple backing stores,

[libvirt] [PATCH v5 4/9] virstoragefile: Always use virStorageSourceSetBackingStore to set backing store

2015-04-23 Thread Matthias Gatto
Replace the parts of the code where a backing store is set manually with virStorageSourceSetBackingStore Signed-off-by: Matthias Gatto matthias.ga...@outscale.com Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/domain_conf.c| 3 ++- src/conf/storage_conf.c

[libvirt] [PATCH v5 9/9] virstoragefile: Add node-name

2015-04-23 Thread Matthias Gatto
Add nodename inside virstoragefile During xml backingStore parsing, look for a nodename attribute in the disk declaration if this one is a quorum, if a nodename is found, add it to the virStorageSource otherwise create a new one with a random name. Take inspiration from this patch to create the

[libvirt] [PATCH v5 5/9] virstoragefile: change backingStore to backingStores.

2015-04-23 Thread Matthias Gatto
The backingStore field was a virStorageSourcePtr. because a quorum can contain more that one backingStore at the same level it's now a 'virStorageSourcePtr *'. This patch rename src-backingStore to src-backingStores, add a static function virStorageSourceExpandBackingStore

Re: [libvirt] [PATCH 1/2] parallels: fix crash in prlsdkAddNet in case of CT definition

2015-04-23 Thread Dmitry Guryanov
On 04/22/2015 10:49 PM, Maxim Nestratov wrote: Since net-model is not defined for containers we shouldn't touch it Signed-off-by: Maxim Nestratov mnestra...@parallels.com --- src/parallels/parallels_sdk.c | 27 +++ 1 files changed, 15 insertions(+), 12 deletions(-)

Re: [libvirt] [PATCH 0/4] Introduce parallelsDomObjFromDomain()

2015-04-23 Thread Dmitry Guryanov
On 04/22/2015 07:35 PM, Michal Privoznik wrote: We have such wrapper in other drivers too: qemu, lxc, network, ... Michal Privoznik (4): struct _parallelsConn: Mark @domains as immutable pointer parallels: Introduce parallelsDomObjFromDomain() parallels_driver: Utilize

Re: [libvirt] [PATCH 0/4] Introduce parallelsDomObjFromDomain()

2015-04-23 Thread Michal Privoznik
On 23.04.2015 11:33, Maxim Nestratov wrote: 22.04.2015 19:35, Michal Privoznik пишет: We have such wrapper in other drivers too: qemu, lxc, network, ... Michal Privoznik (4): struct _parallelsConn: Mark @domains as immutable pointer parallels: Introduce parallelsDomObjFromDomain()

Re: [libvirt] [PATCH 2/2] parallels: fix IS_CT macro

2015-04-23 Thread Dmitry Guryanov
On 04/22/2015 10:49 PM, Maxim Nestratov wrote: CT stands for containers, i.e. def-os.type should be compared with VIR_DOMAIN_OSTYPE_EXE rather than VIR_DOMAIN_OSTYPE_HVM Signed-off-by: Maxim Nestratov mnestra...@parallels.com --- src/parallels/parallels_utils.h |2 +- 1 files changed, 1

Re: [libvirt] [PATCH 1/2] parallels: fix crash in prlsdkAddNet in case of CT definition

2015-04-23 Thread Maxim Nestratov
23.04.2015 15:44, Dmitry Guryanov пишет: On 04/22/2015 10:49 PM, Maxim Nestratov wrote: Since net-model is not defined for containers we shouldn't touch it Signed-off-by: Maxim Nestratov mnestra...@parallels.com --- src/parallels/parallels_sdk.c | 27 +++ 1 files

Re: [libvirt] [PATCH v2] parallels: implement .domainGetMaxMemory

2015-04-23 Thread Daniel P. Berrange
On Thu, Apr 23, 2015 at 04:21:27PM +0300, Dmitry Guryanov wrote: Since we haven't implemented balloon parameters tuning we can just return amount of memory in this function. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c | 15 +++ 1

Re: [libvirt] [PATCH] migration: Usable time statistics without requiring NTP

2015-04-23 Thread Jiri Denemark
On Thu, Apr 23, 2015 at 11:40:11 +0200, Michal Privoznik wrote: On 23.04.2015 11:18, Jiri Denemark wrote: virDomainGetJobStats is able to report statistics of a completed migration, however to get usable downtime and total time statistics both hosts have to keep synchronized time. To

[libvirt] [PATCH v2] parallels: implement .domainGetMaxMemory

2015-04-23 Thread Dmitry Guryanov
Since we haven't implemented balloon parameters tuning we can just return amount of memory in this function. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c | 15 +++ 1 file changed, 15 insertions(+) Changes in v2: use

Re: [libvirt] [PATCH v4 8/9] qemu: Add support to Add/Delete IOThreads

2015-04-23 Thread Peter Krempa
On Tue, Apr 21, 2015 at 19:31:29 -0400, John Ferlan wrote: Add qemuDomainAddIOThread and qemuDomainDelIOThread in order to add or remove an IOThread to/from the host either for live or config optoins The implementation for the 'live' option will use the iothreadpids list in order to make

Re: [libvirt] [PATCH v4 4/9] Move iothreadspin information into iothreadids

2015-04-23 Thread Peter Krempa
On Thu, Apr 23, 2015 at 08:58:26 -0400, John Ferlan wrote: On 04/23/2015 08:02 AM, Peter Krempa wrote: On Tue, Apr 21, 2015 at 19:31:25 -0400, John Ferlan wrote: Remove the iothreadspin array from cputune and replace with a cpumask to be stored in the iothreadids list Signed-off-by:

Re: [libvirt] [PATCH v4 1/9] conf: Add new domain XML element 'iothreadids'

2015-04-23 Thread Peter Krempa
On Tue, Apr 21, 2015 at 19:31:22 -0400, John Ferlan wrote: Adding a new XML element 'iothreadids' in order to allow defining specific IOThread ID's rather than relying on the algorithm to assign IOThread ID's starting at 1 and incrementing to iothreads count. This will allow future patches

  1   2   >