On Fri, Apr 24, 2015 at 09:16:05AM +0200, Michal Privoznik wrote:
On 24.04.2015 07:40, zhang bo wrote:
On 2015/4/24 1:14, Michal Privoznik wrote:
As discussed here:
https://www.redhat.com/archives/libvir-list/2015-April/msg01135.html
Michal Privoznik (5):
On Thu, Apr 23, 2015 at 19:14:56 +0200, Michal Privoznik wrote:
This is basically turning qemuDomObjEndAPI into a more general
function. Other drivers which gets a reference to domain objects may
benefit from this function too.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
On 24.04.2015 12:25, Vasiliy Tolstov wrote:
2015-04-20 13:36 GMT+03:00 Vasiliy Tolstov v.tols...@selfip.ru:
Can somebody add missed functions to libvirt php api binding to
download,resize and upload volume?
Does this means that libvirt php binding not maintained andnot have
actual
Thanks for the patches Laine. I agree pretty much with both the patches.
also had a chance to try these out.
Only scenario I see a trouble is,
net-create without bridge name in the xml, followed by net-define
using the same xml file.
The live and --inactive xmls both show different bridge names,
On Fri, Apr 24, 2015 at 12:03:37 +0200, Jiri Denemark wrote:
==26726==by 0x673CD67: __vasprintf_chk (vasprintf_chk.c:80)
==26726==by 0x5673605: UnknownInlinedFun (stdio2.h:210)
==26726==by 0x5673605: virVasprintfInternal (virstring.c:476)
==26726==by 0x56736EE:
On 23.04.2015 19:14, Michal Privoznik wrote:
As discussed here:
https://www.redhat.com/archives/libvir-list/2015-April/msg01135.html
Michal Privoznik (5):
virDomainObjListAddLocked: s/false/NULL/ for @oldDef
virDomainObjListNew: Use virObjectFreeHashData
Introduce
On 24.04.2015 11:15, Peter Krempa wrote:
On Fri, Apr 24, 2015 at 10:24:14 +0200, Michal Privoznik wrote:
ListFindByID() still requires to step through items in the hash table
(in the worst case scenario through all of them), lock each one and
compare whether we've found what we're looking for.
Like in previous commit, lets use FindByUUID() instead of
ListFindByID(). The latter is suboptimal as it needs to iterate over
each item in the domain object list, lock it and compare the IDs. If
an object is already locked, we must wait until it's unlocked. During
this wait, we keep the whole
This should go on the top of [1] so that both virDomainObjListFindByUUID and
virDomainObjListFindByName are both O(1). Then, the only function left that is
more time complex is virDomainObjListFindByID. Unfortunately, we can't drop it
completely, but we can use it less.
1:
ListFindByID() still requires to step through items in the hash table
(in the worst case scenario through all of them), lock each one and
compare whether we've found what we're looking for. This is suboptimal
as locking a domain object means we need to wait for the current API
running over the
On Thu, Apr 23, 2015 at 16:12:16 -0400, John Ferlan wrote:
Add new API to be able to compare two TCP host name strings or numeric IP
Addresses in order to determine if the resolved and translated names match.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/libvirt_private.syms | 1 +
On Fri, Apr 24, 2015 at 10:24:14 +0200, Michal Privoznik wrote:
ListFindByID() still requires to step through items in the hash table
(in the worst case scenario through all of them), lock each one and
compare whether we've found what we're looking for. This is suboptimal
as locking a domain
On 24.04.2015 12:03, Jiri Denemark wrote:
==26726==by 0x673CD67: __vasprintf_chk (vasprintf_chk.c:80)
==26726==by 0x5673605: UnknownInlinedFun (stdio2.h:210)
==26726==by 0x5673605: virVasprintfInternal (virstring.c:476)
==26726==by 0x56736EE: virAsprintfInternal
On Thu, Apr 23, 2015 at 19:14:58 +0200, Michal Privoznik wrote:
This hash table will contain the same data as already existing one.
The only difference is that while the first table uses domain uuid as
key, the new table uses domain name. This will allow much faster (and
lockless) lookups by
On 04/23/2015 04:23 PM, Daniel P. Berrange wrote:
On Thu, Apr 23, 2015 at 04:21:27PM +0300, Dmitry Guryanov wrote:
Since we haven't implemented balloon parameters tuning
we can just return amount of memory in this function.
Signed-off-by: Dmitry Guryanov dgurya...@parallels.com
---
2015-04-20 13:36 GMT+03:00 Vasiliy Tolstov v.tols...@selfip.ru:
Can somebody add missed functions to libvirt php api binding to
download,resize and upload volume?
Does this means that libvirt php binding not maintained andnot have
actual functions that provided by libvirt?
--
Vasiliy
On Fri, Apr 24, 2015 at 01:25:42PM +0300, Vasiliy Tolstov wrote:
2015-04-20 13:36 GMT+03:00 Vasiliy Tolstov v.tols...@selfip.ru:
Can somebody add missed functions to libvirt php api binding to
download,resize and upload volume?
Maybe you can be that person? Personally, I have no experience
On 22/04/15 21:00, Luyao Huang wrote:
It is hard to check if the free memory for each node is right, because
memory change too fast in most machine (even machine in low load).
Get this free memory 1000 times and get the Standard Deviation via
get_standard_deviation().
177 is a expectations get
On 23.04.2015 15:25, Jiri Denemark wrote:
On Thu, Apr 23, 2015 at 11:40:11 +0200, Michal Privoznik wrote:
On 23.04.2015 11:18, Jiri Denemark wrote:
virDomainGetJobStats is able to report statistics of a completed
migration, however to get usable downtime and total time statistics both
hosts
On Thu, Apr 23, 2015 at 19:14:57 +0200, Michal Privoznik wrote:
Every domain that grabs a domain object to work over should
reference it to make sure it won't disappear meanwhile.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/bhyve/bhyve_driver.c | 3 +-
==26726==by 0x673CD67: __vasprintf_chk (vasprintf_chk.c:80)
==26726==by 0x5673605: UnknownInlinedFun (stdio2.h:210)
==26726==by 0x5673605: virVasprintfInternal (virstring.c:476)
==26726==by 0x56736EE: virAsprintfInternal (virstring.c:497)
==26726==by 0x5680C37:
On 24.04.2015 02:42, Cole Robinson wrote:
Couple cleanups and bug fixes dealing with qemu directory creation
and permissions.
Cole Robinson (4):
qemu: conf: Clarify paths that are relative to libDir
qemu: chown autoDumpPath on driver startup
qemu: Build channel autosocket directory
On 04/24/2015 04:25 AM, Peter Krempa wrote:
On Thu, Apr 23, 2015 at 16:12:16 -0400, John Ferlan wrote:
Add new API to be able to compare two TCP host name strings or numeric IP
Addresses in order to determine if the resolved and translated names match.
Signed-off-by: John Ferlan
On Fri, Apr 24, 2015 at 11:53:46 +0200, Michal Privoznik wrote:
On 23.04.2015 15:25, Jiri Denemark wrote:
On Thu, Apr 23, 2015 at 11:40:11 +0200, Michal Privoznik wrote:
On 23.04.2015 11:18, Jiri Denemark wrote:
virDomainGetJobStats is able to report statistics of a completed
migration,
Upping an interface for no reason and not configuring it is a cardinal sin.
With the default addrgenmode if eui64 it sticks a link-local address to the
interface. That is not good, as NetworkManager would see an address configured,
assume the interface is already configured and won't touch it
Commit 1268820a removed obsolete index() function and replaced it by
strchr. Few versions of gcc has a bug and reports a warning about
strchr:
../../src/util/virstring.c:1006: error: logical '' with non-zero
constant will always evaluate as true [-Wlogical-op]
Signed-off-by: Pavel Hrdina
This patch adds support for detect-zeroes feature in QEMU. It's intented to be
used by libguestfs in virt-sparsify tool.
Relates to: RHBZ#1130506
Maros Zatko (1):
qemu: add support for detect-zeroes feature
docs/schemas/domaincommon.rng | 12
src/conf/domain_conf.c| 19
On 23.04.2015 23:07, Cole Robinson wrote:
- Make sure aarch64 host-passthrough works correctly
- Make sure libvirt doesn't choke on cpu model=host, which is what
virt-install/virt-manager were incorrectly specifying up until recently.
---
.../qemuxml2argv-aarch64-cpu-model-host.args
On 24.04.2015 14:38, Maros Zatko wrote:
---
docs/schemas/domaincommon.rng | 12
src/conf/domain_conf.c| 19 +++
src/conf/domain_conf.h| 10 ++
src/libvirt_private.syms | 1 +
src/qemu/qemu_capabilities.c | 6 +-
---
docs/schemas/domaincommon.rng | 12
src/conf/domain_conf.c| 19 +++
src/conf/domain_conf.h| 10 ++
src/libvirt_private.syms | 1 +
src/qemu/qemu_capabilities.c | 6 +-
src/qemu/qemu_capabilities.h | 1 +
On Fri, Apr 24, 2015 at 13:34:25 +0200, Michal Privoznik wrote:
On 24.04.2015 12:03, Jiri Denemark wrote:
...
- error:
+ cleanup:
if (lockfd != -1) {
unlink(lockpath);
VIR_FORCE_CLOSE(lockfd);
}
VIR_FREE(lockpath);
VIR_FREE(rundir);
-
Add new API to be able to compare two TCP host name strings or numeric IP
Addresses in order to determine if the resolved and translated names match.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/libvirt_private.syms | 1 +
src/util/virsocketaddr.c | 52
On 04/24/2015 06:58 AM, Shivaprasad bhat wrote:
Thanks for the patches Laine. I agree pretty much with both the patches.
also had a chance to try these out.
Only scenario I see a trouble is,
net-create without bridge name in the xml, followed by net-define
using the same xml file.
The live
On 04/23/2015 04:21 PM, Dmitry Guryanov wrote:
Since we haven't implemented balloon parameters tuning
we can just return amount of memory in this function.
Signed-off-by: Dmitry Guryanov dgurya...@parallels.com
---
src/parallels/parallels_driver.c | 15 +++
1 file changed, 15
Since the code is now separated into the common helper, we can reuse it
instead of maintaining two copies.
---
src/qemu/qemu_agent.c | 73 ++-
1 file changed, 2 insertions(+), 71 deletions(-)
diff --git a/src/qemu/qemu_agent.c
Add qemuDomainAddIOThread and qemuDomainDelIOThread in order to add or
remove an IOThread to/from the host either for live or config optoins
The implementation for the 'live' option will use the iothreadpids list
in order to make decision, while the 'config' option will use the
iothreadids list.
Add remote support for the add/delete IOThread API's
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/remote/remote_driver.c | 2 ++
src/remote/remote_protocol.x | 30 +-
src/remote_protocol-structs | 12
3 files changed, 43 insertions(+), 1
https://bugzilla.redhat.com/show_bug.cgi?id=1161617
Add command to allow adding and removing IOThreads from the domain including
the configuration and live domain.
$ virsh iothreadadd --help
NAME
iothreadadd - add an IOThread to the guest domain
SYNOPSIS
iothreadadd domain id
If someone has updated a network to change its bridge name, but the
network is still active (so that bridge name hasn't taken effect yet),
we still want to disallow another network from taking that new name.
---
As suggested by Shivaprasad following his tests of patches 1 and 2...
On 04/24/2015 09:36 AM, Michal Privoznik wrote:
On 23.04.2015 23:07, Cole Robinson wrote:
- Make sure aarch64 host-passthrough works correctly
- Make sure libvirt doesn't choke on cpu model=host, which is what
virt-install/virt-manager were incorrectly specifying up until recently.
---
On 04/24/2015 09:22 AM, Michal Privoznik wrote:
On 24.04.2015 02:42, Cole Robinson wrote:
Couple cleanups and bug fixes dealing with qemu directory creation
and permissions.
Cole Robinson (4):
qemu: conf: Clarify paths that are relative to libDir
qemu: chown autoDumpPath on driver
Rearrange code so that the local variable is always initialized and
disposed.
Signed-off-by: Olaf Hering o...@aepfle.de
Cc: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_driver.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/src/libxl/libxl_driver.c
Both attach and detach functions get called only if the type matches.
Signed-off-by: Olaf Hering o...@aepfle.de
Cc: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_driver.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index
v4 here:
http://www.redhat.com/archives/libvir-list/2015-April/msg01008.html
I was asked to post a complete series by Peter, so rather than repeat
v5 changes described here:
http://www.redhat.com/archives/libvir-list/2015-April/msg01192.html
John Ferlan (10):
conf: Add new domain XML element
Remove the iothreadspin array from cputune and replace with a cpumask
to be stored in the iothreadids list.
Adjust the test output because our printing goes in order of the iothreadids
list now.
Signed-off-by: John Ferlan jfer...@redhat.com
---
docs/formatdomain.html.in
With iothreadid's allowing any 'id' value for an iothread_id, the
iothreadsched code needs a slight adjustment to allow for any
unsigned int value in order to create the bitmap of ids that will
have scheduler adjustments. Adjusted the doc description as well.
Signed-off-by: John Ferlan
We're about to allow IOThreads to be deleted, but an iothreadid may be
included in some domain thread sched, so add a new API to allow removing
an iothread from some entry.
Then during the writing of the threadsched data and an additional check
to determine whether the bitmap is all clear before
When the guest agent channel gets hotplugged to a VM, libvirt would
still report that QEMU guest agent is not configured rather than
stating that the connection was not established yet.
Currently the code won't be able to connect to the agent after hotplug
but that will change in a later patch.
Add 'thread_id' to the virDomainIOThreadIDDef as a means to store the
'thread_id' as returned from the live qemu monitor data.
Remove the iothreadpids list from _qemuDomainObjPrivate and replace with
the new iothreadids 'thread_id' element.
Rather than use the default numbering scheme of
Since it's only ever referenced in domain_conf.c, make the function
static, but also will need to move it to somewhere before it's referenced
rather than forward referencing it.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/conf/domain_conf.c | 38 +++---
Adding a new XML element 'iothreadids' in order to allow defining
specific IOThread ID's rather than relying on the algorithm to assign
IOThread ID's starting at 1 and incrementing to iothreads count.
This will allow future patches to be able to add new IOThreads by
a specific iothread_id and of
The API didn't use virDomainObjEndAPI to release the domain object thus
it leaked a reference to it.
---
src/qemu/qemu_driver.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 989c20c..7d2c5ed 100644
---
---
src/qemu/qemu_driver.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 7d2c5ed..ce38e36 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -19750,27 +19750,11 @@
Clean up some parts of the agent code, fix a recently added bug and add support
for guest agent hotplug, all this while removing more lines than adding.
Peter Krempa (5):
qemu: agent: Reuse virJSONValueObjectCreateVArgs in
qemuAgentMakeCommand
qemu: Fix domain object leak in
On 24.04.2015 16:52, Peter Krempa wrote:
If a user hot-attaches the guest agent channel libvirt would ignore it
until the restart of libvirtd or shutdown/destroy and start of the VM
itself.
This patch adds code that opens or closes the guest agent connection
according to the state of the
On 24.04.2015 16:52, Peter Krempa wrote:
Clean up some parts of the agent code, fix a recently added bug and add
support
for guest agent hotplug, all this while removing more lines than adding.
Peter Krempa (5):
qemu: agent: Reuse virJSONValueObjectCreateVArgs in
Add libvirt API's to manage adding and deleting IOThreads to/from the
domain
Signed-off-by: John Ferlan jfer...@redhat.com
---
include/libvirt/libvirt-domain.h | 6 ++
src/driver-hypervisor.h | 12
src/libvirt-domain.c | 118 +++
Commit ca32929 caused build errors in bhyvexml2argvtest.c because of
some undefined variables.
Pushing under the build breaker rule.
---
tests/bhyvexml2argvtest.c | 4
1 file changed, 4 deletions(-)
diff --git a/tests/bhyvexml2argvtest.c b/tests/bhyvexml2argvtest.c
index 1cce2aa..1c7bc31
On 04/15/2015 01:29 PM, Huanle Han wrote:
Fix for such a case:
1. Domain A and B xml contain the same SRIOV net hostdev(interface
type='hostdev' / with same pci address).
2. virsh start A (Successfully, and configure the SRIOV net with
custom mac)
3. virsh start B (Fail because of the
On 04/22/2015 08:02 AM, John Ferlan wrote:
On 04/15/2015 01:29 PM, Huanle Han wrote:
Fix for such a case:
1. Domain A and B xml contain the same SRIOV net hostdev(interface
type='hostdev' / with same pci address).
2. virsh start A (Successfully, and configure the SRIOV net with
custom mac)
commit id '1e13eff4' didn't init found when changed from a bool to
an int in virStoragePoolFCRefreshThread and Coverity...
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/storage/storage_backend_scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
If a user hot-attaches the guest agent channel libvirt would ignore it
until the restart of libvirtd or shutdown/destroy and start of the VM
itself.
This patch adds code that opens or closes the guest agent connection
according to the state of the guest agent channel according to
Michal Privoznik wrote:
Like in previous commit, lets use FindByUUID() instead of
ListFindByID(). The latter is suboptimal as it needs to iterate over
each item in the domain object list, lock it and compare the IDs. If
an object is already locked, we must wait until it's unlocked. During
On 04/23/2015 08:35 PM, Maxim Nestratov wrote:
Since net-model is not defined for containers we shouldn't touch it.
In case network adapter model is defined, a warning about ignoring
it is shown.
Signed-off-by: Maxim Nestratov mnestra...@parallels.com
---
src/parallels/parallels_sdk.c | 29
=
CALL FOR PAPERS
10th Workshop on Virtualization in High-Performance Cloud Computing (VHPC
'15)
held in conjunction with Euro-Par 2015, August 24-28, Vienna, Austria
(Springer LNCS)
On 24.04.2015 07:40, zhang bo wrote:
On 2015/4/24 1:14, Michal Privoznik wrote:
As discussed here:
https://www.redhat.com/archives/libvir-list/2015-April/msg01135.html
Michal Privoznik (5):
virDomainObjListAddLocked: s/false/NULL/ for @oldDef
virDomainObjListNew: Use
On Thu, Apr 23, 2015 at 19:14:55 +0200, Michal Privoznik wrote:
There's no point in duplicating virObjectFreeHashData() in a separate
function.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/conf/domain_conf.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
On Thu, Apr 23, 2015 at 19:14:54 +0200, Michal Privoznik wrote:
It's a pointer after all. We should initialize it to NULL instead of
false.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK,
Peter
Olaf Hering wrote:
On Fri, Apr 17, Jim Fehlig wrote:
On 04/17/2015 11:19 AM, Olaf Hering wrote:
+libxl_defbool_set(x_vfb-vnc.enable, 0);
Not shown here, but just before the switch is
libxl_device_vfb_init(x_vfb);
which IIUC (looking at the impl in
Olaf Hering wrote:
Rearrange code so that the local variable is always initialized and
disposed.
Signed-off-by: Olaf Hering o...@aepfle.de
Cc: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_driver.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
ACK and pushed.
Commit bf32462b missed initializing sdl.opengl. Without the
initialization, libvirtd will be terminated by an assert from libxl:
Assertion `!libxl_defbool_is_default(db)' failed.
Reported-by: Olaf Hering o...@aepfle.de
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
Perhaps bending the trivial
Olaf Hering wrote:
On Fri, Apr 17, Olaf Hering wrote:
If the domU configu has sdl enabled libvirtd crashes:
libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion
`!libxl_defbool_is_default(db)' failed.
Initialize the relevant defbool variables in libxl_device_vfb.
Olaf Hering wrote:
Both attach and detach functions get called only if the type matches.
Signed-off-by: Olaf Hering o...@aepfle.de
Cc: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_driver.c | 6 --
1 file changed, 6 deletions(-)
ACK. I think callers will always check the
73 matches
Mail list logo
