On Tue, Apr 28, 2015 at 07:29:17AM -0400, John Ferlan wrote:
Add support for the new IOThread APIs
Signed-off-by: John Ferlan jfer...@redhat.com
---
Changes| 1 +
Virt.xs| 20
lib/Sys/Virt/Domain.pm | 12
3 files changed,
On 2015-04-26 13:28, r...@openmailbox.org wrote:
Hi. I am trying to get a virtual smartcard attached to a vm but I want
it to use GPG instead of NSS. RedHat focuses on NSS becuase of PKCS#11
requirements and FIPS approval, but for most of the community its GPG
that matters for smartcards.
Is is
Add support for the new IOThread APIs
Signed-off-by: John Ferlan jfer...@redhat.com
---
Changes| 1 +
Virt.xs| 20
lib/Sys/Virt/Domain.pm | 12
3 files changed, 33 insertions(+)
diff --git a/Changes b/Changes
index
On Mon, Apr 27, 2015 at 16:48:41 -0400, Cole Robinson wrote:
The current code attempts to handle this, but it only catches mkdir
failing with EEXIST. However if say trying to build /tmp for an
unprivileged qemu:///session, mkdir will fail with EPERM.
Rather than catch any errors, just don't
On 04/28/2015 08:23 AM, Nehal J Wani wrote:
The repository link for libvirt-cim at
http://libvirt.org/CIM/downloads.html seems outdated. Shouldn't it be:
git clone git://libvirt.org/libvirt-cim
instead of
hg clone http://libvirt.org/hg/libvirt-cim
yes, those instructions are really out
On Tue, Apr 28, 2015 at 08:53:28AM -0400, John Ferlan wrote:
On 04/28/2015 07:58 AM, Michal Privoznik wrote:
There's no need to mark a function as inline in the function
declaration. In fact, it causes a compilation error:
CC xmlgen.lo
In file included from
On 04/28/2015 08:07 AM, Ján Tomko wrote:
On Mon, Apr 27, 2015 at 10:44:54AM -0400, Cole Robinson wrote:
First patch fixes a regression introduced with pool state patches
Last 3 patches help fix other issues with the state tracking
Cole Robinson (4):
storage: Fix autostart dir for
On 04/28/2015 07:50 AM, Ján Tomko wrote:
The summary says 'EPERM', but the code checks for EACCES.
On Mon, Apr 27, 2015 at 11:57:53AM -0400, Cole Robinson wrote:
Trying to use qemu:///session to create a storage pool pointing at
/tmp will usually fail with something like:
$ virsh
On Tue, Apr 28, 2015 at 11:24:37 +0200, Michal Privoznik wrote:
On 28.04.2015 11:06, Pavel Boldin wrote:
Well, actually that seems to be quite a different bug in there.
I will start a new thread.
In short: migration seems to be broken by commit
On 04/28/2015 07:58 AM, Michal Privoznik wrote:
There's no need to mark a function as inline in the function
declaration. In fact, it causes a compilation error:
CC xmlgen.lo
In file included from acl_parsing.h:29:0,
from xmlgen.h:26,
from
On Mon, Apr 27, 2015 at 16:48:44 -0400, Cole Robinson wrote:
Only set directory permissions at pool build time, if:
- User explicitly requested a mode via the XML
- The directory needs to be created
- We need to do the crazy NFS root-squash workaround
This allows qemu:///session to call
On 28.04.2015 13:15, Martin Kletzander wrote:
Signed-off-by: Pavel Fedin p.fe...@samsung.com
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
This was a part of commit 9dc57ce2, but separable; plus the library
should be in LIBADD and not LDFLAGS. Depends on my
Replace with just VIR_FREE.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/qemu/qemu_driver.c | 6 +++---
src/qemu/qemu_monitor.c | 9 -
src/qemu/qemu_monitor.h | 2 --
src/qemu/qemu_monitor_json.c | 2 +-
src/qemu/qemu_process.c | 2 +-
Rather than have a separate routine to parse the alias of an iothread
returned from qemu in order to get the iothread_id value, parse the alias
when returning and just return the iothread_id in qemuMonitorIOThreadInfoPtr
This set of patches removes the function, changes the char *name to
unsigned
v1 here:
http://www.redhat.com/archives/libvir-list/2015-April/msg01382.html
v2 changes:
Patch 1 - Add a !STRPREFIX(tmp, iothread) of the returned iothreads
to ignore anything that doesn't start with iothread.
Patch 2 - already ACKed, just difficult to extract.
Patch 3 - NEW: remove
If we received zero iothreads from the monitor, but were perhaps
expecting to receive something, then the code was skipping the check
to ensure what's in the monitor matches our expectations. So invert
the checks to check that what we get back matches expectations and
then check there are zero
Historically I have taken care of everything related to the Sys::Virt
Perl binding for libvirt. Recently a couple of adventurous people
have started sending patches too. Perl may have a reputation for being
scary, but at this point extending the Sys::Virt binding when new APIs
or constants are
This can cause permissions failures if qemu.conf user/group is changed.
Fix this by filling in the VNC auto socket path in the same code area
that we fill in default listen address, ports, etc.
https://bugzilla.redhat.com/show_bug.cgi?id=1151762
---
src/qemu/qemu_command.c | 10 ++
On 04/28/2015 09:23 AM, Peter Krempa wrote:
On Mon, Apr 27, 2015 at 16:48:43 -0400, Cole Robinson wrote:
The XML parser sets a default mode if none is explicitly passed in.
This is then used at pool/vol creation time, and unconditionally reported
in the XML.
The problem with this approach is
On 04/28/2015 06:46 PM, Cole Robinson wrote:
Ping... I think this should be safe for the release, since the AIX value has
never been exposed to the user
ACK, and indeed worth having in the release
- Cole
On 04/22/2015 10:47 AM, Cole Robinson wrote:
The phyp driver stuffed it into a
On 04/28/2015 09:36 AM, Peter Krempa wrote:
On Mon, Apr 27, 2015 at 16:48:44 -0400, Cole Robinson wrote:
Only set directory permissions at pool build time, if:
- User explicitly requested a mode via the XML
- The directory needs to be created
- We need to do the crazy NFS root-squash
Ping... I think this should be safe for the release, since the AIX value has
never been exposed to the user
- Cole
On 04/22/2015 10:47 AM, Cole Robinson wrote:
The phyp driver stuffed it into a DomainDefPtr during its attachdevice
routine, but the value is never advertised via capabilities so
On 04/28/2015 08:06 AM, Peter Krempa wrote:
On Mon, Apr 27, 2015 at 16:48:40 -0400, Cole Robinson wrote:
This means pool XML actually reports accurate user/group/mode/label.
This uses UpdateVolTargetInfoFD in a bit of a hackish way, but it works
---
src/storage/storage_backend_fs.c | 58
On 04/28/2015 09:36 AM, Peter Krempa wrote:
On Mon, Apr 27, 2015 at 16:48:44 -0400, Cole Robinson wrote:
Only set directory permissions at pool build time, if:
- User explicitly requested a mode via the XML
- The directory needs to be created
- We need to do the crazy NFS root-squash
On 04/28/2015 05:51 PM, Cole Robinson wrote:
Many users, who admin their own machines, want to be able to access
system libvirtd via tools like virt-manager without having to enter
a root password. Just google 'virt-manager without password' and
you'll find many hits. I've read at least 5 blog
Many users, who admin their own machines, want to be able to access
system libvirtd via tools like virt-manager without having to enter
a root password. Just google 'virt-manager without password' and
you'll find many hits. I've read at least 5 blog posts over the years
describing slightly
On 04/28/2015 08:19 AM, Peter Krempa wrote:
On Mon, Apr 27, 2015 at 16:48:41 -0400, Cole Robinson wrote:
The current code attempts to handle this, but it only catches mkdir
failing with EEXIST. However if say trying to build /tmp for an
unprivileged qemu:///session, mkdir will fail with EPERM.
On 04/27/2015 10:08 PM, Shanzhi Yu wrote:
Should libvirt post error when try a shallow blockcopy of file without
backing file, just as shallow blockcommit?
I cannot reproduce the error above, could you please post steps to do
that? or perhaps debug log from libvirt?
It is easy to reproduce.
On 04/28/2015 07:58 AM, Michal Privoznik wrote:
There's no need to mark a function as inline in the function
declaration. In fact, it causes a compilation error:
CC xmlgen.lo
In file included from acl_parsing.h:29:0,
from xmlgen.h:26,
from
On Mon, Apr 27, 2015 at 16:48:43 -0400, Cole Robinson wrote:
The XML parser sets a default mode if none is explicitly passed in.
This is then used at pool/vol creation time, and unconditionally reported
in the XML.
The problem with this approach is that it's impossible for other code
to
On Tue, Apr 28, 2015 at 06:40:32 -0400, John Ferlan wrote:
Replace with just VIR_FREE.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/qemu/qemu_driver.c | 6 +++---
src/qemu/qemu_monitor.c | 9 -
src/qemu/qemu_monitor.h | 2 --
src/qemu/qemu_monitor_json.c
Signed-off-by: Pavel Fedin p.fe...@samsung.com
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
This was a part of commit 9dc57ce2, but separable; plus the library
should be in LIBADD and not LDFLAGS. Depends on my previous cleanup [2]
[1]
On Tue, Apr 28, 2015 at 11:40:02AM +0300, Pavel Fedin wrote:
Hello!
I have checked. For some reason, $(virnetserverclientmock_la_LDADDS)
does not take part anywhere. Here are generated rules:
It has to be virnetserverclientmock_la_LIBADD instead. I have tested, works
fine.
I just wrote
On Mon, Apr 27, 2015 at 16:48:40 -0400, Cole Robinson wrote:
This means pool XML actually reports accurate user/group/mode/label.
This uses UpdateVolTargetInfoFD in a bit of a hackish way, but it works
---
src/storage/storage_backend_fs.c | 58
++--
1
The repository link for libvirt-cim at
http://libvirt.org/CIM/downloads.html seems outdated. Shouldn't it be:
git clone git://libvirt.org/libvirt-cim
instead of
hg clone http://libvirt.org/hg/libvirt-cim
--
Nehal J Wani
--
libvir-list mailing list
libvir-list@redhat.com
On Tue, Apr 28, 2015 at 06:40:31 -0400, John Ferlan wrote:
If we received zero iothreads from the monitor, but were perhaps
expecting to receive something, then the code was skipping the check
to ensure what's in the monitor matches our expectations. So invert
the checks to check that what we
On Mon, Apr 27, 2015 at 10:44:54AM -0400, Cole Robinson wrote:
First patch fixes a regression introduced with pool state patches
Last 3 patches help fix other issues with the state tracking
Cole Robinson (4):
storage: Fix autostart dir for qemu:///session
storage: Don't leave stale
On Tue, Apr 28, 2015 at 07:23:02 -0400, John Ferlan wrote:
On 04/28/2015 06:40 AM, John Ferlan wrote:
v1 here:
http://www.redhat.com/archives/libvir-list/2015-April/msg01382.html
v2 changes:
Patch 1 - Add a !STRPREFIX(tmp, iothread) of the returned iothreads
to
On Mon, Apr 27, 2015 at 16:48:42 -0400, Cole Robinson wrote:
Currently we try to chown any directory passed to virDirCreate,
even if the user didn't request any explicit owner/group via the
pool/vol XML.
This causes issues with qemu:///session: try to build a pool of
a root owned directory
On 04/28/2015 06:40 AM, John Ferlan wrote:
v1 here:
http://www.redhat.com/archives/libvir-list/2015-April/msg01382.html
v2 changes:
Patch 1 - Add a !STRPREFIX(tmp, iothread) of the returned iothreads
to ignore anything that doesn't start with iothread.
Patch 2 - already
There's no need to mark a function as inline in the function
declaration. In fact, it causes a compilation error:
CC xmlgen.lo
In file included from acl_parsing.h:29:0,
from xmlgen.h:26,
from capability_parsing.c:37:
list_util.h:67:21: error: inline
The summary says 'EPERM', but the code checks for EACCES.
On Mon, Apr 27, 2015 at 11:57:53AM -0400, Cole Robinson wrote:
Trying to use qemu:///session to create a storage pool pointing at
/tmp will usually fail with something like:
$ virsh pool-start tmp
error: Failed to start pool tmp
On 28.04.2015 14:53, John Ferlan wrote:
On 04/28/2015 07:58 AM, Michal Privoznik wrote:
There's no need to mark a function as inline in the function
declaration. In fact, it causes a compilation error:
CC xmlgen.lo
In file included from acl_parsing.h:29:0,
from
On Tue, Apr 28, 2015 at 08:53:28AM -0400, John Ferlan wrote:
FWIW:
libvirt-cim patches have been sent to the libvirt-cim list
@libvirt-...@redhat.com and not libvir-list...
Given that the libvirt CIM project is in maint mode only aat
this point, with little to no feature work, I'm not sure
On Tue, Apr 28, 2015 at 06:40:30 -0400, John Ferlan wrote:
Rather than have a separate routine to parse the alias of an iothread
returned from qemu in order to get the iothread_id value, parse the alias
when returning and just return the iothread_id in qemuMonitorIOThreadInfoPtr
This set of
On Tue, Apr 28, 2015 at 11:28:38AM +0200, Marc-André Lureau wrote:
Hi Martin
On Mon, Apr 27, 2015 at 4:20 PM, Martin Kletzander mklet...@redhat.com
wrote:
ACK series with two things to consider mentioned in-line (not hard
requirements, but it would be nice to have).
It seems we missed
Replace all occurrences of stream write to differences to
with stream to write differences to.
---
tests/testutils.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/testutils.c b/tests/testutils.c
index 6a8fe6a..89026c6 100644
--- a/tests/testutils.c
+++
While qemu would reject the configuration we can check whether it makes
sense to plug the device upfront.
---
src/qemu/qemu_command.c | 8
src/qemu/qemu_driver.c | 6 ++
src/qemu/qemu_hotplug.c | 6 ++
3 files changed, 20 insertions(+)
diff --git a/src/qemu/qemu_command.c
If the added memory device would exceed the maximum memory size, reject
it.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1216046
---
src/conf/domain_conf.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
Add sanity checks for some unsupported/invalid configs of memory devices.
Peter Krempa (3):
qemu: conf: Reject memory device if it would exceed configured max
size
qemu: command: Validate that memory devices slot ID is in range
qemu: Validate available slot count for memory devices
slot id, if specified, has to be less than the slots count.
---
src/qemu/qemu_command.c | 11 ++-
src/qemu/qemu_command.h | 1 +
src/qemu/qemu_hotplug.c | 2 +-
3 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index
The documentation states that for shallow block copy the image has to
have the same guest visible content as backing file of the current
image if the file is being reused. This condition can be achieved also
with a raw file (or a qcow without a backing file) so remove the
condition that would
On 04/28/2015 09:53 AM, Peter Krempa wrote:
The documentation states that for shallow block copy the image has to
have the same guest visible content as backing file of the current
image if the file is being reused. This condition can be achieved also
with a raw file (or a qcow without a
This patch add to libvirt php binding libvirt stream support
Also provide resize/upload/download for libvirt volume
Signed-off-by: Vasiliy Tolstov v.tols...@selfip.ru
---
configure.ac | 3 +-
src/libvirt-php.c | 382 +-
src/libvirt-php.h
2015-04-24 14:40 GMT+03:00 Michal Privoznik mpriv...@redhat.com:
Yeah, it's not as actively developed as libvirt. And it not uncommon for
our bindings to not have an API implemented. The best would be to post a
patch to the list and CC Michal Novotny who has done the majority of
work there.
On 04/23/2015 09:37 PM, Maxim Nestratov wrote:
New functions utilize previosly added prlsdkDelDisk and prlsdkGetDiskIndex
Signed-off-by: Maxim Nestratov mnestra...@parallels.com
---
src/parallels/parallels_driver.c | 71 ++
src/parallels/parallels_sdk.c
On 04/23/2015 09:37 PM, Maxim Nestratov wrote:
Signed-off-by: Maxim Nestratov mnestra...@parallels.com
---
src/parallels/parallels_sdk.c | 65 +
1 files changed, 65 insertions(+), 0 deletions(-)
diff --git a/src/parallels/parallels_sdk.c
libvirt 1.2.9.3 is now available. This is a maintenance release of
libvirt 1.2.9 with additional bugfixes that have accumulated
upstream since the initial release.
This release can be downloaded at:
http://libvirt.org/sources/stable_updates/libvirt-1.2.9.3.tar.gz
Changes in this version:
*
libvirt 1.2.13.1 is now available. This is a maintenance release of
libvirt 1.2.13 with additional bugfixes that have accumulated
upstream since the initial release.
This release can be downloaded at:
http://libvirt.org/sources/stable_updates/libvirt-1.2.13.1.tar.gz
Changes in this version:
*
This patch add to libvirt php binding libvirt stream support
Also provide resize/upload/download for libvirt volume
Signed-off-by: Vasiliy Tolstov v.tols...@selfip.ru
---
configure.ac | 3 +-
src/libvirt-php.c | 382 +-
src/libvirt-php.h
Jim Fehlig wrote:
Provide integration with libvirt's lock manager in the libxl driver.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
V3 of
https://www.redhat.com/archives/libvir-list/2015-April/msg01006.html
In V3, call virDomainLockProcessStart() with 'paused' parameter
set to 'true'
On Mon, Apr 27, 2015 at 16:48:39 -0400, Cole Robinson wrote:
virDirCreate will give us fine grained details about what actually failed.
---
src/storage/storage_backend_fs.c | 4
1 file changed, 4 deletions(-)
ACK,
Peter
signature.asc
Description: Digital signature
--
libvir-list
Hello!
I have checked. For some reason, $(virnetserverclientmock_la_LDADDS)
does not take part anywhere. Here are generated rules:
It has to be virnetserverclientmock_la_LIBADD instead. I have tested, works
fine.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center
On Mon, Apr 27, 2015 at 14:51:04 -0400, John Ferlan wrote:
Rather than have a separate routine to parse the alias of an iothread
returned from qemu in order to get the iothread_id value, parse the alias
when returning and just return the iothread_id in qemuMonitorIOThreadInfoPtr
This set of
On Mon, Apr 27, 2015 at 14:51:05 -0400, John Ferlan wrote:
If we received zero iothreads from the monitor, but were perhaps
expecting to receive something, then the code was skipping the check
to ensure what's in the monitor matches our expectations. So invert
the checks to check that what we
On Mon, Apr 27, 2015 at 15:08:42 -0400, John Ferlan wrote:
Resolve some Coverity errors with IOThread changes
Signed-off-by: John Ferlan jfer...@redhat.com
---
I ran my Coverity checker too, but I looked at the wrong results
tab when I went to check the results... I looked at a previous
Peter Krempa wrote:
On Tue, Apr 28, 2015 at 08:30:30 +0400, Roman Bogorodskiy wrote:
Build with clang fails with:
CC conf/libvirt_conf_la-domain_conf.lo
conf/domain_conf.c:13377:9: error: variable 'cpumask' is used
uninitialized whenever 'if' condition is true
Well, actually that seems to be quite a different bug in there.
I will start a new thread.
In short: migration seems to be broken by commit
1a92c719101e5bfa6fe2b78006ad04c7f075ea28. This is because introduced job
_MODIFY waits while MIGRATION_OUT is finished to change `mirrorState'
variable.
On Tue, Apr 28, 2015 at 17:37:42 +0200, Peter Krempa wrote:
Add sanity checks for some unsupported/invalid configs of memory devices.
Peter Krempa (3):
qemu: conf: Reject memory device if it would exceed configured max
size
qemu: command: Validate that memory devices slot ID is in
This uses the API version of the proposed vscsi support in libxl (v4):
http://lists.xenproject.org/archives/html/xen-devel/2015-04/msg01949.html
Is there anything else that needs to be done in libvirt? Right now libvirt scsi
support is very simple minded, no support at all to describe host
Hello!
If it works, feel free to close the BZ or reply if it doesn't.
It doesn't seem to work. And the error is, indeed:
--- cut ---
CCLD virnetserverclientmock.la
.libs/virnetserverclientmock_la-virnetserverclientmock.o: In function
`virNetSocketGetSELinuxContext':
Hello!
If it works, feel free to close the BZ or reply if it doesn't.
I have checked. For some reason, $(virnetserverclientmock_la_LDADDS) does
not take part anywhere. Here are generated rules:
--- cut ---
virnetserverclientmock_la_LINK = $(LIBTOOL) $(AM_V_lt) --tag=CC \
On Tue, Apr 28, 2015 at 08:30:30 +0400, Roman Bogorodskiy wrote:
Build with clang fails with:
CC conf/libvirt_conf_la-domain_conf.lo
conf/domain_conf.c:13377:9: error: variable 'cpumask' is used
uninitialized whenever 'if' condition is true
[-Werror,-Wsometimes-uninitialized]
On 28.04.2015 11:06, Pavel Boldin wrote:
Well, actually that seems to be quite a different bug in there.
I will start a new thread.
In short: migration seems to be broken by commit
1a92c719101e5bfa6fe2b78006ad04c7f075ea28. This is because introduced job
_MODIFY waits while MIGRATION_OUT
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
Changes| 1 +
Virt.xs| 1 +
lib/Sys/Virt/Domain.pm | 6 ++
3 files changed, 8 insertions(+)
diff --git a/Changes b/Changes
index 7a7ba4c..ead8f8e 100644
--- a/Changes
+++ b/Changes
@@ -5,6 +5,7 @@
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
Virt.xs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Virt.xs b/Virt.xs
index d01cf05..4b3ba9a 100644
--- a/Virt.xs
+++ b/Virt.xs
@@ -2946,8 +2946,8 @@ PREINIT:
callback =
In order to match the newish things in libvirt.
Michal Privoznik (4):
domain_event_register_any: Align the code
Add support for VIR_DOMAIN_EVENT_ID_DEVICE_ADDED
Add JOB_DOWNTIME_NET constant
Add JOB_TIME_ELAPSED_NET constant
Changes| 5 -
Virt.xs| 48
Hi Martin
On Mon, Apr 27, 2015 at 4:20 PM, Martin Kletzander mklet...@redhat.com
wrote:
ACK series with two things to consider mentioned in-line (not hard
requirements, but it would be nice to have).
It seems we missed 1.2.15, so I updated doc comment about version
availability, and I
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
Changes| 3 ++-
Virt.xs| 42 ++
lib/Sys/Virt/Domain.pm | 4
t/030-api-coverage.t | 1 +
4 files changed, 49 insertions(+), 1 deletion(-)
diff --git a/Changes
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
Changes| 1 +
Virt.xs| 1 +
lib/Sys/Virt/Domain.pm | 6 ++
3 files changed, 8 insertions(+)
diff --git a/Changes b/Changes
index a299dc7..7a7ba4c 100644
--- a/Changes
+++ b/Changes
@@ -4,6 +4,7 @@
On Tue, Apr 28, 2015 at 11:54:05AM +0200, Michal Privoznik wrote:
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
Changes| 3 ++-
Virt.xs| 42 ++
lib/Sys/Virt/Domain.pm | 4
t/030-api-coverage.t | 1 +
On Tue, Apr 28, 2015 at 11:54:04AM +0200, Michal Privoznik wrote:
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
Virt.xs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Virt.xs b/Virt.xs
index d01cf05..4b3ba9a 100644
--- a/Virt.xs
+++ b/Virt.xs
@@
On Tue, Apr 28, 2015 at 11:54:06AM +0200, Michal Privoznik wrote:
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
Changes| 1 +
Virt.xs| 1 +
lib/Sys/Virt/Domain.pm | 6 ++
3 files changed, 8 insertions(+)
ACK
Regards,
Daniel
--
|:
On Tue, Apr 28, 2015 at 11:54:07AM +0200, Michal Privoznik wrote:
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
Changes| 1 +
Virt.xs| 1 +
lib/Sys/Virt/Domain.pm | 6 ++
3 files changed, 8 insertions(+)
ACK
Regards,
Daniel
--
|:
Thanks Peter,
It looks good but I did no deep introspection of the code.
Should I rebase my patch [1] on that? I can test your code as well then.
[1] https://github.com/paboldin/libvirt/commits/master
Pavel
On Tue, Apr 28, 2015 at 4:42 PM, Peter Krempa pkre...@redhat.com wrote:
On Tue, Apr
Upcoming changes for vscsi will use libxlutil.so to prepare the
configuration for libxl. The helpers needs a xlu struct for logging.
Provide one and reuse the existing output as log target.
Signed-off-by: Olaf Hering o...@aepfle.de
Cc: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_conf.c | 6
On 28.04.2015 03:16, Zhang Bo wrote:
the free callback should be qemuMonitorChardevInfoFree rather than just 'free'
when virHashCreate'ing the chardevInfo hash.
Zhang Bo (2):
qemu: make qemuMonitorChardevInfoFree non-static
tests: free ChardevInfo correctly in qemumonitorjsontest
87 matches
Mail list logo
