Re: [libvirt] [RFC PATCH] network: add an option to disable dnsmasq's bind-dynamic

2015-05-07 Thread Michal Privoznik
On 06.05.2015 15:29, Cédric Bosdonnat wrote: When building vlans on top of veth networks, dnsmasq doesn't catch DNS requests on the vlans interfaces. Allowing to disable the bind-dynamic helps this use case. --- src/conf/network_conf.c | 12 src/conf/network_conf.h |

Re: [libvirt] [Xen-devel] [PATCH] libxl: include a XLU_Config in _libxlDriverConfig

2015-05-07 Thread Wei Liu
On Thu, May 07, 2015 at 10:20:23AM +0200, Olaf Hering wrote: On Wed, May 06, Wei Liu wrote: On Wed, May 06, 2015 at 10:58:11AM +0200, Olaf Hering wrote: On Wed, May 06, Olaf Hering wrote: Since libvirtd runs forever there is very little code to undo most things. But I will see

Re: [libvirt] [PATCH] processSerialChangedEvent: Close agent monitor early

2015-05-07 Thread Michal Privoznik
On 06.05.2015 18:27, Eric Blake wrote: On 05/06/2015 02:46 AM, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=890648 So, imagine you've issued an API that involves guest agent. For instance, you want to query guest's IP addresses. So the API acquires QUERY_JOB, locks the

[libvirt] [PATCH v2] libxl: include a XLU_Config in _libxlDriverConfig

2015-05-07 Thread Olaf Hering
Upcoming changes for vscsi will use libxlutil.so to prepare the configuration for libxl. The helpers needs a xlu struct for logging. Provide one and reuse the existing output as log target. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Jim Fehlig jfeh...@suse.com --- v2: - call xlu_cfg_destroy,

[libvirt] [PATCH v2] processSerialChangedEvent: Close agent monitor early

2015-05-07 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=890648 So, imagine you've issued an API that involves guest agent. For instance, you want to query guest's IP addresses. So the API acquires QUERY_JOB, locks the guest agent and issues the agent command. However, for some reason, guest agent replies to

Re: [libvirt] [PATCH] processSerialChangedEvent: Close agent monitor early

2015-05-07 Thread Michal Privoznik
On 06.05.2015 18:33, Daniel P. Berrange wrote: On Wed, May 06, 2015 at 10:27:50AM -0600, Eric Blake wrote: On 05/06/2015 02:46 AM, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=890648 So, imagine you've issued an API that involves guest agent. For instance, you want to

[libvirt] Plans for supporting smbios type 2 ( baseboard/module info ) in libvirt

2015-05-07 Thread Soumik Bhattacharya
Hi Experts, Just wondering if there are plans to implement smbios type 2 parameters in libvirt ? I am trying to pass a couple of critical parameters ( especially 'location' ) to qemu via libvirt but it's failing ( silently ignored ) currently due to libvirt not supporting smbios type 2 ( yet

Re: [libvirt] [Xen-devel] [PATCH] libxl: include a XLU_Config in _libxlDriverConfig

2015-05-07 Thread Olaf Hering
On Wed, May 06, Wei Liu wrote: On Wed, May 06, 2015 at 10:58:11AM +0200, Olaf Hering wrote: On Wed, May 06, Olaf Hering wrote: Since libvirtd runs forever there is very little code to undo most things. But I will see if there is any unload function, did not actively look for such

[libvirt] [PATCH] Assign virtio-serial addresses after coldplugging a device

2015-05-07 Thread Ján Tomko
Otherwise we might allow coldplugging a device that uses an address that is already occupied, creating an unstartable domain. https://bugzilla.redhat.com/show_bug.cgi?id=1076708#c10 --- src/qemu/qemu_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH] parallels: remove connection wide wait timeout

2015-05-07 Thread Nikolay Shirokovskiy
We have a lot of passing arguments code just to pass connection object cause it holds jobTimeout. Taking into account that right now this value is defined at compile time let's just get rid of it and make arguments list more clear in many places. In case we later need some runtime configurable

[libvirt] [PATCH v1] update snapshot api

2015-05-07 Thread Vasiliy Tolstov
* add constants from libvirt to snapshots api * add flags to snapshot functions Signed-off-by: Vasiliy Tolstov v.tols...@selfip.ru --- src/libvirt-php.c | 87 ++- 1 file changed, 61 insertions(+), 26 deletions(-) diff --git a/src/libvirt-php.c

Re: [libvirt] [PATCH] caps: Don't default to i686 of KVM on x86_64

2015-05-07 Thread Richard W.M. Jones
On Wed, May 06, 2015 at 06:59:46PM -0400, Cole Robinson wrote: My commit 747761a79 (v1.2.15 only) dropped this bit of logic when filling in a default arch in the XML: -/* First try to find one matching host arch */ -for (i = 0; i caps-nguests; i++) { -if

Re: [libvirt] storage volume download/upload

2015-05-07 Thread Vasiliy Tolstov
No suggestions ? 2015-05-05 16:18 GMT+03:00 Vasiliy Tolstov v.tols...@selfip.ru: As i see in some cases, for example in case of lvm storage pool libvirt spawns libvirt_iohelper to upload or download data to volume. But in case of big data contains zeroes this is wast bw of network. May be we

Re: [libvirt] [PATCH] caps: Don't default to i686 of KVM on x86_64

2015-05-07 Thread Daniel P. Berrange
On Wed, May 06, 2015 at 06:59:46PM -0400, Cole Robinson wrote: My commit 747761a79 (v1.2.15 only) dropped this bit of logic when filling in a default arch in the XML: -/* First try to find one matching host arch */ -for (i = 0; i caps-nguests; i++) { -if

Re: [libvirt] [RFC PATCH] network: add an option to disable dnsmasq's bind-dynamic

2015-05-07 Thread Laine Stump
On 05/07/2015 05:58 AM, Michal Privoznik wrote: On 06.05.2015 15:29, Cédric Bosdonnat wrote: When building vlans on top of veth networks, dnsmasq doesn't catch DNS requests on the vlans interfaces. Allowing to disable the bind-dynamic helps this use case. --- /* using

Re: [libvirt] storage volume download/upload

2015-05-07 Thread Vasiliy Tolstov
2015-05-07 17:06 GMT+03:00 Michal Privoznik mpriv...@redhat.com: The main benefit of using iohelper is that we have aligned reads from disks and thus can use O_DIRECT flag. So if anything, any compression must be put in between iohelper and the daemon which then resends data to clients. but

Re: [libvirt] storage volume download/upload

2015-05-07 Thread Michal Privoznik
On 07.05.2015 16:14, Vasiliy Tolstov wrote: 2015-05-07 17:06 GMT+03:00 Michal Privoznik mpriv...@redhat.com: The main benefit of using iohelper is that we have aligned reads from disks and thus can use O_DIRECT flag. So if anything, any compression must be put in between iohelper and the

Re: [libvirt] [PATCH v2] processSerialChangedEvent: Close agent monitor early

2015-05-07 Thread Martin Kletzander
On Thu, May 07, 2015 at 11:33:58AM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=890648 So, imagine you've issued an API that involves guest agent. For instance, you want to query guest's IP addresses. So the API acquires QUERY_JOB, locks the guest agent and issues

Re: [libvirt] storage volume download/upload

2015-05-07 Thread Michal Privoznik
On 05.05.2015 15:18, Vasiliy Tolstov wrote: As i see in some cases, for example in case of lvm storage pool libvirt spawns libvirt_iohelper to upload or download data to volume. But in case of big data contains zeroes this is wast bw of network. May be we can use gzip or lz4 for compression

Re: [libvirt] [PATCH] tests: Remove redundant aarch64 tests

2015-05-07 Thread Cole Robinson
On 05/07/2015 11:48 AM, Laine Stump wrote: On 05/07/2015 11:30 AM, Cole Robinson wrote: My commit 7b9de914 added some aarch64 CPU test cases. I wanted to test two different code paths but inadvertently added two of the same test cases. The second code path (using cpumodelhost/model/cpu)

[libvirt] [PATCH 0/4] Enable support for s390 crypto key mgmt operations

2015-05-07 Thread akrowiak
From: Tony Krowiak akrow...@linux.vnet.ibm.com The IBM System z Central Processor Assist for Cryptographic Functions (CPACF) hardware provides a set of CPU instructions for use in clear-key encryption, pseudo random number generation, hash functions, and protected-key encryption. The CPACF

Re: [libvirt] [PATCH] tests: Remove redundant aarch64 tests

2015-05-07 Thread Laine Stump
On 05/07/2015 11:30 AM, Cole Robinson wrote: My commit 7b9de914 added some aarch64 CPU test cases. I wanted to test two different code paths but inadvertently added two of the same test cases. The second code path (using cpumodelhost/model/cpu) isn't easily exercised via the qemu tests

Re: [libvirt] RFC Parallels driver renaming

2015-05-07 Thread Daniel P. Berrange
On Thu, May 07, 2015 at 06:13:27PM +0300, Maxim Nestratov wrote: Hi all, You probably already know that our Parallels business devision responsible for Parallels Cloud Server, which is supported currently in libvirt as a parallels driver, was recently renamed to Odin [1]. As a part of this

[libvirt] [PATCH 3/4] libvirt: qemu: enable/disable protected key management ops

2015-05-07 Thread akrowiak
From: Tony Krowiak aekro...@us.ibm.com Introduces two new -machine option parameters to the QEMU command to enable/disable the CPACF protected key management operations for a guest: aes-key-wrap='on|off' dea-key-wrap='on|off' The QEMU code maps the corresponding domain configuration

[libvirt] [PATCH 4/4] libvirt: tests: test protected key mgmt ops support

2015-05-07 Thread akrowiak
From: Tony Krowiak aekro...@us.ibm.com Test the support for enabling/disabling CPACF protected key management operations for a guest. Signed-off-by: Tony Krowiak akrow...@linux.vnet.ibm.com Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com Reviewed-by: Boris Fiuczynski

[libvirt] [PATCH 1/4] libvirt: docs: XML to enable/disable protected key mgmt ops

2015-05-07 Thread akrowiak
From: Tony Krowiak akrow...@linux.vnet.ibm.com Two new domain configuration XML elements have been added to enable/disable the protected key management operations for a guest: domain ... keywrap cipher name='aes|dea' state='on|off'/ /keywrap ... /domain

Re: [libvirt] [PATCH 0/2] Introduce pci-serial

2015-05-07 Thread Gerd Hoffmann
On Mi, 2015-05-06 at 18:36 +0200, Michal Privoznik wrote: It's very similar to usb-serial. You wouldn't guess the difference :-P Both are hotpluggable. Looks like the patches don't cover that ... Intentional? Does libvirt support hotplugging chardevs (which would pretty much required to make

Re: [libvirt] [PATCH v2] processSerialChangedEvent: Close agent monitor early

2015-05-07 Thread Michal Privoznik
On 07.05.2015 16:07, Martin Kletzander wrote: On Thu, May 07, 2015 at 11:33:58AM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=890648 So, imagine you've issued an API that involves guest agent. For instance, you want to query guest's IP addresses. So the API

Re: [libvirt] [libvirt-php] [PATCH v1] update snapshot api

2015-05-07 Thread Vasiliy Tolstov
2015-05-07 17:21 GMT+03:00 Vasiliy Tolstov v.tols...@selfip.ru: * add constants from libvirt to snapshots api * add flags to snapshot functions This is for php libvirt binding -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru jabber: v...@selfip.ru -- libvir-list mailing list

[libvirt] RFC Parallels driver renaming

2015-05-07 Thread Maxim Nestratov
Hi all, You probably already know that our Parallels business devision responsible for Parallels Cloud Server, which is supported currently in libvirt as a parallels driver, was recently renamed to Odin [1]. As a part of this change our Parallels Cloud Server product name was also changed to

Re: [libvirt] [PATCH] cpu_conf: properly escape characters for model and vendor

2015-05-07 Thread Pavel Hrdina
On Wed, May 06, 2015 at 02:28:04PM -0400, John Ferlan wrote: On 05/05/2015 11:04 AM, Pavel Hrdina wrote: We should escape strings for those two elements to be consistent along the whole XML. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1197580 The bz mentions two other

[libvirt] [PATCH] tests: Remove redundant aarch64 tests

2015-05-07 Thread Cole Robinson
My commit 7b9de914 added some aarch64 CPU test cases. I wanted to test two different code paths but inadvertently added two of the same test cases. The second code path (using cpumodelhost/model/cpu) isn't easily exercised via the qemu tests anyways, I'll need to look elsewhere. Regardless,

[libvirt] [PATCH v2] caps: Fix regression defaulting to host arch

2015-05-07 Thread Cole Robinson
My commit 747761a79 (v1.2.15 only) dropped this bit of logic when filling in a default arch in the XML: -/* First try to find one matching host arch */ -for (i = 0; i caps-nguests; i++) { -if (caps-guests[i]-ostype == ostype) { -for (j = 0; j

Re: [libvirt] RFC Parallels driver renaming

2015-05-07 Thread Maxim Nestratov
07.05.2015 18:53, Daniel P. Berrange пишет: So for the URI, we need to keep compatibility with existing syntax. That doesn't mean we can't rename the URI to have a vz:// prefix, but the code would have to still permit the old parallels:// prefix forever. Also, anywhere in the XML which refers

Re: [libvirt] RFC Parallels driver renaming

2015-05-07 Thread Maxim Nestratov
07.05.2015 19:45, Daniel P. Berrange пишет: On Thu, May 07, 2015 at 07:34:09PM +0300, Maxim Nestratov wrote: 07.05.2015 18:53, Daniel P. Berrange пишет: So for the URI, we need to keep compatibility with existing syntax. That doesn't mean we can't rename the URI to have a vz:// prefix, but the

[libvirt] [PATCH 2/4] libvirt: conf: parse XML for protected key management ops

2015-05-07 Thread akrowiak
From: Tony Krowiak akrow...@linux.vnet.ibm.com Parse the domain configuration XML elements that enable/disable access to the protected key management operations for a guest: domain ... keywrap cipher name='aes|dea' state='on|off'/ /keywrap ... /domain

[libvirt] [PATCH] conf: Ignore panic device on pSeries.

2015-05-07 Thread Andrea Bolognani
The guest firmware already provides the same functionality, so we can just safely drop the panic/ element from the domain definition. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1182388 --- src/conf/domain_conf.c | 17 +++-

Re: [libvirt] RFC Parallels driver renaming

2015-05-07 Thread Daniel P. Berrange
On Thu, May 07, 2015 at 07:34:09PM +0300, Maxim Nestratov wrote: 07.05.2015 18:53, Daniel P. Berrange пишет: So for the URI, we need to keep compatibility with existing syntax. That doesn't mean we can't rename the URI to have a vz:// prefix, but the code would have to still permit the old