The variable 'now' is useless in qemuMigrationPrepareAny(), so I clear it.
Signed-off-by: Wang Yufei
Signed-off-by: Zhang Bo
---
src/qemu/qemu_migration.c | 4
1 file changed, 4 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index c1af704..4dcba7a 100644
-
On 05/12/2015 11:14 PM, Michal Privoznik wrote:
On 12.05.2015 15:55, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1220809
When cold-plug a rng device and get failed in qemuDomainAssignAddresses,
we will double free the rng device. Free the pointer after we Insert the
device s
On 05/11/2015 10:08 PM, Martin Kletzander wrote:
On Mon, May 11, 2015 at 08:59:37PM +0800, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1220265
Pass the return value to an enum directly is not safe.
When pass a invalid @ioeventfd and virTristateSwitchTypeFromString
return -1
my main goal is to add support migration with host NIC
passthrough devices and keep the network connectivity.
this series patch base on Shradha's patches on
https://www.redhat.com/archives/libvir-list/2012-November/msg01324.html
which is add migration support for host passthrough devices.
1) unp
the ephemeral flag helps support migration with PCI-passthrough.
An ephemeral hostdev is automatically unplugged before migration
and replugged (if one is available on the destination) after
migration.
Signed-off-by: Chen Fan
---
docs/schemas/domaincommon.rng | 10 ++
we should save the XML information to image head before we
hotunplug the ephemeral devices. so here we handle XML
ahead.
Signed-off-by: Chen Fan
---
src/qemu/qemu_driver.c | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/src/qemu/qemu
add migration support for ephemeral host devices, introduce
two 'detach' and 'restore' functions to unplug/plug host devices
during migration.
Signed-off-by: Chen Fan
---
src/qemu/qemu_migration.c | 171 --
src/qemu/qemu_migration.h | 9 +++
src/qemu
currently, we only support PCI host devices with ephemeral flag.
and USB already supports migration. so maybe in the near future we
can support SCSI.
Signed-off-by: Chen Fan
---
src/qemu/qemu_command.c | 10 ++
src/qemu/qemu_migration.c | 11 +++
2 files changed, 17 insertions(
Signed-off-by: Chen Fan
---
src/qemu/qemu_driver.c | 8
src/qemu/qemu_process.c | 3 ++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 86d93d2..112acb1 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
after migration we should restore the ephemeral devices.
so we save them to qemuDomainObjPrivate.
Signed-off-by: Chen Fan
---
src/qemu/qemu_domain.c | 5 +
src/qemu/qemu_domain.h | 3 +++
2 files changed, 8 insertions(+)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index d8a
On 2015/5/12 16:56, Daniel P. Berrange wrote:
> On Tue, May 12, 2015 at 04:14:37PM +0800, zhang bo wrote:
>> So, Is there any other better solution? thanks in advance.
>
> Simply don't change the system time by massive deltas. Libvirt is not going
> to be the only app to be affected. As you ment
Konrad Rzeszutek Wilk wrote:
> On Fri, May 08, 2015 at 04:31:02PM -0600, Jim Fehlig wrote:
>
>> For HVM domains, vfb info must be populated in the libxl_domain_build_info
>> stuct. Currently this is done in the libxlMakeVfbList function, but IMO
>>
>
> struct
>
Thanks. I've fixed the
Martin Kletzander wrote:
> On Fri, May 08, 2015 at 04:44:14PM -0600, Jim Fehlig wrote:
>> While implementing support for SPICE, noticed VNC passwd was never
>
> s/, n/, I n/ ?
>
>> copied to libxl_device_vfb's vnc.passwd field.
>>
>
> ACK
Thanks! I fixed the nit and pushed.
Regards,
Jim
>
>> Si
https://bugzilla.redhat.com/show_bug.cgi?id=976387
For a domain configured using the host cdrom, we should taint the domain
due to problems encountered when the host and guest try to control the tray.
Signed-off-by: John Ferlan
---
src/conf/domain_conf.c | 3 ++-
src/conf/domain_conf.h | 1 +
s
On 05/12/2015 11:16 AM, Laine Stump wrote:
> On 05/08/2015 08:05 PM, John Ferlan wrote:
>>
>> On 05/05/2015 02:03 PM, Laine Stump wrote:
>>> The commandline generator for a virtio-serial device had a hardcoded
>>> printf of "virtio-serial%d" as the id of the virtio-serial
>>> controller. This pat
On 05/12/2015 10:23 AM, Michal Privoznik wrote:
> Due to a commit in kernel (155597223) it's 'processor' rather than
> 'Processor'. Fix our parser too.
Shouldn't we be parsing this string case-insensitively, to work with
kernels that pre-date that kernel commit?
>
> Signed-off-by: Michal Privozn
On 05/12/2015 10:23 AM, Michal Privoznik wrote:
> VIR_STRDUP plays nicely with NULLs. Theres no need to guard its
> call with check for non-NULL.
>
> Signed-off-by: Michal Privoznik
> ---
> src/util/virsysinfo.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
ACK
>
> diff --git a/sr
In the XML we have the vnc port number, but QEMU takes on command line
a vnc screen number, it's port-5900. We should fail with error message
that only ports in range [5900,65535] are valid.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1164966
Signed-off-by: Pavel Hrdina
---
src/qemu/
On Tue, May 12, 2015 at 11:14:09AM +0200, Martin Kletzander wrote:
> On Tue, May 12, 2015 at 05:27:34PM +1000, Tony Breeds wrote:
> >On Mon, May 11, 2015 at 01:14:58PM +0200, Martin Kletzander wrote:
> >
> >>Determining this by version might not be reliable, but more
> >>importantly working around
VIR_STRDUP plays nicely with NULLs. Theres no need to guard its
call with check for non-NULL.
Signed-off-by: Michal Privoznik
---
src/util/virsysinfo.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c
index 4edce66..8bb17f0 10064
I've just tried sysinfo on my RPi, and found some bugs there.
Michal Privoznik (2):
virSysinfoParseProcessor: Drop useless check for NULL
sysinfo: Fix reports on arm
src/util/virsysinfo.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--
2.3.6
--
libvir-list mailing list
libvi
Due to a commit in kernel (155597223) it's 'processor' rather than
'Processor'. Fix our parser too.
Signed-off-by: Michal Privoznik
---
src/util/virsysinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c
index 8bb17f0..fb8cb2c 1
On Thu, Apr 23, 2015 at 14:41:20 +0200, Matthias Gatto wrote:
> Allow to libvirt to build the quorum string used by quemu.
>
> Add 2 static functions: qemuBuildQuorumStr and
> qemuBuildAndAppendDriveStrToVirBuffer.
> qemuBuildQuorumStr is made because a quorum can have another quorum
> as a child,
On 04/27/2015 05:57 PM, akrow...@linux.vnet.ibm.com wrote:
From: Tony Krowiak
The IBM System z Central Processor Assist for Cryptographic Functions (CPACF)
hardware provides a set of CPU instructions for use in clear-key encryption,
pseudo random number generation, hash functions, and protected
On 05/08/2015 08:05 PM, John Ferlan wrote:
>
> On 05/05/2015 02:03 PM, Laine Stump wrote:
>> The commandline generator for a virtio-serial device had a hardcoded
>> printf of "virtio-serial%d" as the id of the virtio-serial
>> controller. This patch changes it to use the alias of the controller
>>
On 12.05.2015 15:55, Luyao Huang wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1220809
>
> When cold-plug a rng device and get failed in qemuDomainAssignAddresses,
> we will double free the rng device. Free the pointer after we Insert the
> device success to fix this issue.
>
> ...
> 5 0x
On 12.05.2015 04:23, John Ferlan wrote:
> Only a v3 because the first two series "Addition host name check for
> network storage pools" were not well received. If someone wants to
> pick up/use the the hostname checking code from the v2, then have at it.
> Patch 1, 2, 7, & 8 use the virSocketAddr c
On Thu, Apr 23, 2015 at 14:41:19 +0200, Matthias Gatto wrote:
> Add the capabiltty to libvirt to parse and format the quorum syntax
> as described here:
> http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html
>
> Signed-off-by: Matthias Gatto
> ---
> src/conf/domain_conf.c | 164
> +
https://bugzilla.redhat.com/show_bug.cgi?id=1220527
This type of information defines attributes of a system
baseboard. With one caveat: in qemu they call it family, while
in the specification it's referred to as type. I'm sticking with
the latter.
Signed-off-by: Michal Privoznik
---
docs/forma
Move all the bios_* fields into a separate struct. Not only this
simplifies the code a bit it also helps us to identify whether BIOS
info is present. We don't have to check all the four variables for
being not-NULL, but we can just check the pointer to the struct.
Signed-off-by: Michal Privoznik
Move all the system_* fields into a separate struct. Not only this
simplifies the code a bit it also helps us to identify whether BIOS
info is present. We don't have to check all the four variables for
being not-NULL, but we can just check the pointer to the struct.
Signed-off-by: Michal Privoznik
The specification is here:
http://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.0.0.pdf
The first two patches rework the code a bit, and the last one adds something
useful.
Michal Privoznik (3):
virSysinfoDef: Exempt BIOS variables
virSysinfoDef: Exempt SYSTEM variables
vi
On Thu, Apr 23, 2015 at 14:41:17 +0200, Matthias Gatto wrote:
> The backingStore field was a virStorageSourcePtr.
> because a quorum can contain more that one backingStore at the same level
> it's now a 'virStorageSourcePtr *'.
>
> This patch rename src->backingStore to src->backingStores,
> add
https://bugzilla.redhat.com/show_bug.cgi?id=1220809
When cold-plug a rng device and get failed in qemuDomainAssignAddresses,
we will double free the rng device. Free the pointer after we Insert the
device success to fix this issue.
...
5 0x7fb7d180ac8a in virFree at util/viralloc.c:582
6 0x
On Thu, Apr 23, 2015 at 14:41:21 +0200, Matthias Gatto wrote:
> Add nodename inside virstoragefile
> During xml backingStore parsing, look for a nodename attribute in the disk
> declaration if this one is a quorum, if a nodename is found, add it to
> the virStorageSource otherwise create a new one
On Tue, May 12, 2015 at 13:53:20 +0100, Daniel P. Berrange wrote:
> On Tue, May 12, 2015 at 02:37:09PM +0200, Jiri Denemark wrote:
> > Instead of redoing the same filtering over and over everytime we need to
> > walk through all disks which are being migrated.
> >
> > Signed-off-by: Jiri Denemark
On Mon, Apr 27, 2015 at 03:49:35PM +0200, Martin Kletzander wrote:
In order not to bring in any link dependencies, bridge driver doesn't
use the usual stubs as other conditionally-built code does. However,
having the function as a macro imposes a problem with possibly unused
variables if just de
On Tue, May 12, 2015 at 02:37:09PM +0200, Jiri Denemark wrote:
> Instead of redoing the same filtering over and over everytime we need to
> walk through all disks which are being migrated.
>
> Signed-off-by: Jiri Denemark
> ---
> src/conf/domain_conf.h| 2 ++
> src/qemu/qemu_migration.c | 2
On Tue, May 12, 2015 at 15:07:31 +0300, Pavel Boldin wrote:
> Implement a `migrate_disks' parameters for the QEMU driver. This multi-
> value parameter can be used to explicitly specify what block devices
> are to be migrated using the NBD server. Tunnelled migration using NBD
> is to be done.
>
.
When cancelling drive mirror, always try to do that for all disks even
if it fails for some of them. Report the first error we saw.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_migrat
Jiri Denemark (2):
qemu: Keep track of what disks are being migrated
qemu: Don't give up on first error in qemuMigrationCancelDriverMirror
src/conf/domain_conf.h| 2 ++
src/qemu/qemu_migration.c | 36 +---
2 files changed, 19 insertions(+), 19 deletions(-)
Instead of redoing the same filtering over and over everytime we need to
walk through all disks which are being migrated.
Signed-off-by: Jiri Denemark
---
src/conf/domain_conf.h| 2 ++
src/qemu/qemu_migration.c | 23 ++-
2 files changed, 8 insertions(+), 17 deletions(-)
On Tue, May 12, 2015 at 14:05:36 +0200, Ján Tomko wrote:
> The commit summary says logging twice.
I've dropped the first instance ...
>
> On Tue, May 12, 2015 at 01:58:11PM +0200, Peter Krempa wrote:
> > Similarly to other error codes that notify the user that the object does
> > not exist lower
The `virTypedParamsValidate' function now can be instructed to allow
multiple entries for some of the keys. For this flag the type with
the `VIR_TYPED_PARAM_MULTIPLE' flag.
Add unit tests for this new behaviour.
Signed-off-by: Pavel Boldin
---
include/libvirt/libvirt-host.h | 8 ++
src/util/v
The `virTypedParamsPackStrings' function provides interface to pack
multiple string values under the same key to the `virTypedParameter'
array.
Signed-off-by: Pavel Boldin
---
include/libvirt/libvirt-host.h | 6 +++
src/libvirt_public.syms| 1 +
src/util/virtypedparam.c | 94
The patchset represented in the mail thread implements the selective block
device migration for the QEMU driver. This closes the referenced bug [1].
First the supplementary API implemented allowing for multiple key-values pair
in the virTypedParameter arrays. This is used to pass the list of block
Implement a `migrate_disks' parameters for the QEMU driver. This multi-
value parameter can be used to explicitly specify what block devices
are to be migrated using the NBD server. Tunnelled migration using NBD
is to be done.
Signed-off-by: Pavel Boldin
---
include/libvirt/libvirt-domain.h |
The commit summary says logging twice.
On Tue, May 12, 2015 at 01:58:11PM +0200, Peter Krempa wrote:
> Similarly to other error codes that notify the user that the object does
> not exist lower the priority of VIR_ERR_NO_DOMAIN_METADATA to
> VIR_LOG_DEBUG when writing the log entry.
> ---
> daemo
Add multikey APIs for virTypedParams*:
* virTypedParamsPick that returns all the parameters with the
specified name and type.
* virTypedParamsPickStrings that returns a NULL-terminated `const char**'
list with all the values for specified name and string type.
Signed-off-by: Pavel Boldin
Add `virsh migrate' option `--migratedisks' that allows CLI user to
explicitly specify block devices to migrate.
Signed-off-by: Pavel Boldin
---
tools/virsh-domain.c | 43 +++
1 file changed, 43 insertions(+)
diff --git a/tools/virsh-domain.c b/tools/virs
Similarly to other error codes that notify the user that the object does
not exist lower the priority of VIR_ERR_NO_DOMAIN_METADATA to
VIR_LOG_DEBUG when writing the log entry.
---
daemon/libvirtd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 107
On Fri, May 08, 2015 at 04:44:14PM -0600, Jim Fehlig wrote:
While implementing support for SPICE, noticed VNC passwd was never
s/, n/, I n/ ?
copied to libxl_device_vfb's vnc.passwd field.
ACK
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_conf.c | 2 ++
1 file changed, 2 insertions(+)
d
On Tue, May 12, 2015 at 07:26:11PM +0800, Zhang Bo wrote:
> From: YueWenyuan
>
> remove unused functions virTimeFieldsNow() and virTimeFieldsNowRaw()
Removing unused functions like this is really a non-goal. They are general
utility functions in libvirt that may or may not be used at a single
po
From: YueWenyuan
remove unused function virTimeFieldsNowRaw() in src/libvirt_private.syms,
src/util/virtime.c and src/util/virtime.h
Signed-off-by: YueWenyuan
Signed-off-by: Zhang Bo
---
src/libvirt_private.syms | 1 -
src/util/virtime.c | 22 --
src/util/virtime.h
From: YueWenyuan
remove unused function virTimeFieldsNow() in src/libvirt_private.syms,
src/util/virtime.c and src/util/virtime.h
Signed-off-by: YueWenyuan
Signed-off-by: Zhang Bo
---
src/libvirt_private.syms | 1 -
src/util/virtime.c | 21 -
src/util/virtime.h
From: YueWenyuan
remove unused functions virTimeFieldsNow() and virTimeFieldsNowRaw()
YueWenyuan (2):
remove unused function virTimeFieldsNow
remove unused function virTimeFieldsNowRaw
src/libvirt_private.syms | 2 --
src/util/virtime.c | 43 -
On Tue, May 12, 2015 at 10:07:21AM +0200, Ján Tomko wrote:
> On Mon, May 11, 2015 at 06:17:26PM +0200, Pavel Hrdina wrote:
> > There is a lot of places, were it's pretty ease for user to enter some
> > characters that we need to escape to create a valid XML description.
> >
> > Resolves: https://b
On Tue, May 12, 2015 at 09:51:24AM +0100, Daniel P. Berrange wrote:
> I think this is something distros should really fix in their libvirt
> packages - backporting this kind of fix is exactly the kind job of
> maintainers should be doing.
>
> Particularly since it only affects TCG mode, I don't t
On Tue, May 12, 2015 at 11:14:09AM +0200, Martin Kletzander wrote:
> 1.2.13 has the commit already in the release and 1.2.12-maint has it
> as a first back-port right after release. The problem is that there
> was no maintenance release of 1.2.12 yet. Maybe they would use
> 1.2.12.1 if it existe
On Tue, May 12, 2015 at 05:27:34PM +1000, Tony Breeds wrote:
On Mon, May 11, 2015 at 01:14:58PM +0200, Martin Kletzander wrote:
Determining this by version might not be reliable, but more
importantly working around bug in underlying software is something
that shouldn't be done at all IMHO. Let
On Tue, May 12, 2015 at 04:14:37PM +0800, zhang bo wrote:
> event poll may become un-triggerable after changing system clock.
>
> The steps to reproduce the problem:
> 1 run event-test
> 1 define and start a domain with name vm1.
> 2 destroy vm1
> 3 change system time to 1 hour before when timer.
On Mon, May 11, 2015 at 09:30:06PM +0100, Richard W.M. Jones wrote:
> On the s/390x architecture, libvirt may already return 0 in the
> node_info->mhz field (see src/nodeinfo.c:linuxNodeInfoCPUPopulate).
>
> We may also want to return this on aarch64 in future, because
> calculating the proper val
On Tue, May 12, 2015 at 05:27:34PM +1000, Tony Breeds wrote:
> On Mon, May 11, 2015 at 01:14:58PM +0200, Martin Kletzander wrote:
>
> > Determining this by version might not be reliable, but more
> > importantly working around bug in underlying software is something
> > that shouldn't be done at a
event poll may become un-triggerable after changing system clock.
The steps to reproduce the problem:
1 run event-test
1 define and start a domain with name vm1.
2 destroy vm1
3 change system time to 1 hour before when timer.expiresAt has been set in
virEventPollUpdateTimeout
(and before virE
On Mon, May 11, 2015 at 06:17:26PM +0200, Pavel Hrdina wrote:
> There is a lot of places, were it's pretty ease for user to enter some
> characters that we need to escape to create a valid XML description.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1197580
>
> Signed-off-by: Pavel
On Mon, May 11, 2015 at 01:14:58PM +0200, Martin Kletzander wrote:
> Determining this by version might not be reliable, but more
> importantly working around bug in underlying software is something
> that shouldn't be done at all IMHO. Let the maintainers backport
> whatever needs to be done.
I
66 matches
Mail list logo
