Re: [libvirt] [PATCH] Taint domains using cdrom-passthrough

2015-05-20 Thread John Ferlan
ping... Was this all you were looking for? Tks - John On 05/13/2015 08:07 AM, John Ferlan wrote: On 05/13/2015 03:37 AM, Peter Krempa wrote: On Tue, May 12, 2015 at 16:03:33 -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=976387 For a domain configured using the

Re: [libvirt] [libvirt-glib] storage-pool: API to get/set autostart flag

2015-05-20 Thread Zeeshan Ali (Khattak)
Ping! I forgot to mention, this is likely needed to fix: https://bugzilla.gnome.org/show_bug.cgi?id=748160 On Mon, May 18, 2015 at 3:11 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: Add binding for virStoragePoolGetAutostart virStoragePoolSetAutostart. ---

Re: [libvirt] [PATCH/RFC] Add missing delta from Ubuntu to apparmor profiles

2015-05-20 Thread Stefan Bader
On 19.05.2015 11:54, intrigeri wrote: Hi Stefan, any news on what follows? Now that Ubuntu 15.04 has been released, perhaps you'll be able to allocate some cycles to it? :) Hm was there not something which I was waiting for feedback from you? Though I forgot what exactly that was. And after

Re: [libvirt] [PATCH] Taint domains using cdrom-passthrough

2015-05-20 Thread Peter Krempa
On Wed, May 20, 2015 at 06:34:39 -0400, John Ferlan wrote: ping... Was this all you were looking for? Um yes, but as I've stated before, rather than sending a squash in that usually can't be applied anyways it's better just re-send the patch with the change since most mail clients just fubar

Re: [libvirt] [PATCH 2/2] qemuDomainGetNumaParameters: Don't report spurious info

2015-05-20 Thread Michal Privoznik
On 19.05.2015 19:15, Martin Kletzander wrote: On Tue, May 19, 2015 at 01:33:11PM +0200, Michal Privoznik wrote: This API does not work well on domains without numatune/. It blindly reports misleading info on a shutoff domain: # virsh numatune rhel7 numa_mode : strict numa_nodeset

Re: [libvirt] [PATCH 3/3] virSysinfo: Introduce SMBIOS type 2 support

2015-05-20 Thread Michal Privoznik
On 18.05.2015 20:48, John Ferlan wrote: On 05/12/2015 10:56 AM, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1220527 This type of information defines attributes of a system baseboard. With one caveat: in qemu they call it family, while in the specification it's

Re: [libvirt] [PATCH] conf: Catch memory size overflow earlier

2015-05-20 Thread Michal Privoznik
On 19.05.2015 17:05, Peter Krempa wrote: virDomainParseMemory parses the size and then rounds up while converting it to kibibytes. Since the number is limit-checked before the rounding it's possible to use a number that would be correctly parsed the first time, but not the second time. For

Re: [libvirt] [PATCH 2/3] parallels: move up updating autostart parameter in prlsdkLoadDomain

2015-05-20 Thread Daniel P. Berrange
On Mon, May 18, 2015 at 05:44:19PM +0300, Maxim Nestratov wrote: It is better to get all necessary parameters and check them on newly created configuration before actually creating a domain with them or applying them to an existing domain. Signed-off-by: Maxim Nestratov

Re: [libvirt] [PATCH 1/3] parallels: fix prlsdkAddDomain

2015-05-20 Thread Daniel P. Berrange
On Mon, May 18, 2015 at 05:44:18PM +0300, Maxim Nestratov wrote: Don't forget to unlock domain on error path Signed-off-by: Maxim Nestratov mnestra...@parallels.com --- src/parallels/parallels_sdk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[libvirt] [RFC PATCH 0/2] Clear capabilities cache options

2015-05-20 Thread John Ferlan
Posting this as an RFC since I'm trying to get upstream feedback on whether either approach is better or whether perhaps both approaches should be used. The problem occurred primarily for downstream installations where it seems the order of the build libvirtd caused issues regarding whether

[libvirt] [RFC PATCH 2/2] qemu: Force capabilities cache read if libvirtd date is different

2015-05-20 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1195882 Original commit id 'cbde3589' indicates that the cache file would be discarded if either the QEMU binary or libvirtd 'ctime' changes; however, the code only discarded if the QEMU binary time didn't match or if the new libvirtd ctime was later

Re: [libvirt] [RFC PATCH 1/2] spec: Remove capabilities cache during %post install

2015-05-20 Thread Daniel P. Berrange
On Wed, May 20, 2015 at 08:52:56AM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1195882 Force re-reading of the capabilities cache upon new installations. Since re-reading of the capabilities is based on the 'ctime' of either the QEMU binary or if the new libvirtd

Re: [libvirt] [PATCH 1/3] Introduce virDomainSetUserPassword API

2015-05-20 Thread Daniel P. Berrange
On Mon, May 18, 2015 at 02:43:48PM +0200, Ján Tomko wrote: For setting passwords of users inside the domain. With the VIR_DOMAIN_PASSWORD_CRYPTED flag set, the password is assumed to be already encrypted by crypt(3). https://bugzilla.redhat.com/show_bug.cgi?id=1174177 ---

Re: [libvirt] [PATCH v3 3/4] qemuDomainAttachChrDevice: Fix chardev hotplug

2015-05-20 Thread Daniel P. Berrange
On Thu, May 14, 2015 at 10:33:05AM +0200, Michal Privoznik wrote: Not every chardev is plugged onto virtio-serial bus. However, the code introduced in 89e991a2aa36b04 assumes that. Incorrectly. With previous patches we have three options where a chardev can be plugged: virtio-serial, USB and

Re: [libvirt] [PATCH v3 2/4] qemu: Implement pci-serial

2015-05-20 Thread Daniel P. Berrange
On Thu, May 14, 2015 at 10:33:04AM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=998813 Implementation is pretty straight-forward. Of course, not all qemus out there supports the device, so new capability is introduced and checked prior each use of the device.

Re: [libvirt] [PATCH v3 4/4] qemuDomainDetachChrDevice: Fix chardev hot-unplug

2015-05-20 Thread Daniel P. Berrange
On Thu, May 14, 2015 at 10:33:06AM +0200, Michal Privoznik wrote: Not every chardev is plugged onto virtio-serial bus. However, the code introduced in 89e991a2aa36b04 assumes that. Incorrectly. With previous patches we have three options where a chardev can be plugged: virtio-serial, USB and

Re: [libvirt] [PATCH 02/13] Move daemon-related parts of virNetServer to virNetDaemon

2015-05-20 Thread Daniel P. Berrange
On Tue, May 19, 2015 at 10:19:36PM -0700, Martin Kletzander wrote: This allows to have more servers in one daemon which helps isolating some resources. Signed-off-by: Martin Kletzander mklet...@redhat.com --- daemon/libvirtd.c | 101 ++--- docs/internals.html.in

Re: [libvirt] [RFC PATCH 2/2] qemu: Force capabilities cache read if libvirtd date is different

2015-05-20 Thread Daniel P. Berrange
On Wed, May 20, 2015 at 08:52:57AM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1195882 Original commit id 'cbde3589' indicates that the cache file would be discarded if either the QEMU binary or libvirtd 'ctime' changes; however, the code only discarded if the QEMU

Re: [libvirt] [libvirt-python 2/3] Simplify sorting

2015-05-20 Thread Daniel P. Berrange
On Tue, May 19, 2015 at 12:53:13AM +0200, Guido Günther wrote: funcs.keys() can't be None, only the empty array --- generator.py | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) ACK Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :|

Re: [libvirt] [libvirt-python 1/3] Sort dictionary keys

2015-05-20 Thread Daniel P. Berrange
On Tue, May 19, 2015 at 12:53:12AM +0200, Guido Günther wrote: In order to achive reproducible builds[0] we want functions and enums always generated in the same order. [0] https://wiki.debian.org/ReproducibleBuilds/About --- generator.py | 8 1 file changed, 4 insertions(+), 4

Re: [libvirt] [libvirt-python 3/3] Sort tuples on both items

2015-05-20 Thread Daniel P. Berrange
On Tue, May 19, 2015 at 12:53:14AM +0200, Guido Günther wrote: In order to achieve reproducible builds[0] we want the items within enums always generated in the same order so sort on both items in the tuple. [0] https://wiki.debian.org/ReproducibleBuilds/About --- generator.py | 6 +++---

Re: [libvirt] [PATCH 3/3] parallels: fix possible crash in case of errors in prlsdkLoadDomain

2015-05-20 Thread Daniel P. Berrange
On Mon, May 18, 2015 at 05:44:20PM +0300, Maxim Nestratov wrote: Cleanup code in prlsdkLoadDomain doesn't take into account the fact if private domain freeing function is assigned or not. In case it is, we shouldn't call it manually because virDomainObjListRemove calls it. Also, allocated def

Re: [libvirt] [PATCH v3 1/4] Introduce pci-serial

2015-05-20 Thread Daniel P. Berrange
On Thu, May 14, 2015 at 10:33:03AM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=998813 Like usb-serial, the pci-serial device allows a serial device to be attached to PCI bus. An example XML looks like this: serial type='dev' source path='/dev/ttyS2'/

[libvirt] [RFC PATCH 1/2] spec: Remove capabilities cache during %post install

2015-05-20 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1195882 Force re-reading of the capabilities cache upon new installations. Since re-reading of the capabilities is based on the 'ctime' of either the QEMU binary or if the new libvirtd is greater than what created the cache file, it's possible that

Re: [libvirt] RFC: exposing qemu's block-set-write-threshold

2015-05-20 Thread Daniel P. Berrange
On Mon, May 18, 2015 at 02:28:09PM -0600, Eric Blake wrote: I'm trying to wire up libvirt to do event reporting based on qemu 2.3's BLOCK_WRITE_THRESHOLD event. Doing this will allow management applications to do event-based notification on when to enlarge LVM (or other) storage underlying a

Re: [libvirt] [PATCH] conf: Catch memory size overflow earlier

2015-05-20 Thread Peter Krempa
On Wed, May 20, 2015 at 14:20:04 +0200, Michal Privoznik wrote: On 19.05.2015 17:05, Peter Krempa wrote: virDomainParseMemory parses the size and then rounds up while converting it to kibibytes. Since the number is limit-checked before the rounding it's possible to use a number that would

Re: [libvirt] [PATCH 2/3] virsh: add set-user-password command

2015-05-20 Thread Daniel P. Berrange
On Mon, May 18, 2015 at 02:43:49PM +0200, Ján Tomko wrote: Expose the virDomainSetUserPassword API in virsh: virsh set-user-password dom 123456 user For root, the username can be omitted: virsh set-user-password dom 123456 --- tools/virsh-domain.c | 76

Re: [libvirt] [PATCH 01/13] util: add virJSONValueCopy

2015-05-20 Thread Daniel P. Berrange
On Tue, May 19, 2015 at 10:19:35PM -0700, Martin Kletzander wrote: Faster version of virJSONValueFromString(virJSONValueToString()). Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/libvirt_private.syms | 1 + src/util/virjson.c | 65 ++-

Re: [libvirt] [PATCH 3/3] parallels: fix possible crash in case of errors in prlsdkLoadDomain

2015-05-20 Thread Maxim Nestratov
20.05.2015 15:32, Daniel P. Berrange пишет: On Mon, May 18, 2015 at 05:44:20PM +0300, Maxim Nestratov wrote: Cleanup code in prlsdkLoadDomain doesn't take into account the fact if private domain freeing function is assigned or not. In case it is, we shouldn't call it manually because

Re: [libvirt] [RFC PATCH 2/2] qemu: Force capabilities cache read if libvirtd date is different

2015-05-20 Thread John Ferlan
On 05/20/2015 09:28 AM, Daniel P. Berrange wrote: On Wed, May 20, 2015 at 08:52:57AM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1195882 Original commit id 'cbde3589' indicates that the cache file would be discarded if either the QEMU binary or libvirtd 'ctime'

Re: [libvirt] [RFC PATCH 2/2] qemu: Force capabilities cache read if libvirtd date is different

2015-05-20 Thread Ján Tomko
s/read/refresh/ in the commit message? On Wed, May 20, 2015 at 08:52:57AM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1195882 Original commit id 'cbde3589' indicates that the cache file would be discarded if either the QEMU binary or libvirtd 'ctime' changes;

Re: [libvirt] [PATCH 06/13] Add admin error domain

2015-05-20 Thread Michal Privoznik
On 20.05.2015 07:19, Martin Kletzander wrote: Just the addition of VIR_FROM_ADMIN to the enum of error domains. Signed-off-by: Martin Kletzander mklet...@redhat.com --- include/libvirt/virterror.h | 3 ++- src/util/virerror.c | 1 + 2 files changed, 3 insertions(+), 1 deletion(-)

Re: [libvirt] [libvirt-python 3/3] Sort tuples on both items

2015-05-20 Thread Guido Günther
On Wed, May 20, 2015 at 01:23:32PM +0100, Daniel P. Berrange wrote: On Tue, May 19, 2015 at 12:53:14AM +0200, Guido Günther wrote: In order to achieve reproducible builds[0] we want the items within enums always generated in the same order so sort on both items in the tuple. [0]

Re: [libvirt] [PATCH 02/13] Move daemon-related parts of virNetServer to virNetDaemon

2015-05-20 Thread Daniel P. Berrange
On Wed, May 20, 2015 at 06:11:14PM +0200, Michal Privoznik wrote: On 20.05.2015 07:19, Martin Kletzander wrote: This allows to have more servers in one daemon which helps isolating some resources. Signed-off-by: Martin Kletzander mklet...@redhat.com --- daemon/libvirtd.c

Re: [libvirt] [PATCH 05/13] Build client headers for admin protocol

2015-05-20 Thread Michal Privoznik
On 20.05.2015 07:19, Martin Kletzander wrote: Signed-off-by: Martin Kletzander mklet...@redhat.com --- .gitignore | 1 + cfg.mk | 5 - src/Makefile.am | 9 - 3 files changed, 13 insertions(+), 2 deletions(-) ACK Michal -- libvir-list mailing list

Re: [libvirt] [PATCH 02/13] Move daemon-related parts of virNetServer to virNetDaemon

2015-05-20 Thread Michal Privoznik
On 20.05.2015 07:19, Martin Kletzander wrote: This allows to have more servers in one daemon which helps isolating some resources. Signed-off-by: Martin Kletzander mklet...@redhat.com --- daemon/libvirtd.c | 101 ++--- docs/internals.html.in | 4 +-

Re: [libvirt] [PATCH 03/13] Teach gendispatch how to handle admin dispatching files

2015-05-20 Thread Michal Privoznik
On 20.05.2015 07:19, Martin Kletzander wrote: Since this is just a new option for gendispatch, it looks more like a cleanup. The only differences handled by it are connect pointers, private pointers and API naming customs. Signed-off-by: Martin Kletzander mklet...@redhat.com ---

Re: [libvirt] [PATCH 04/13] Add admin protocol

2015-05-20 Thread Michal Privoznik
On 20.05.2015 07:19, Martin Kletzander wrote: For now there are only CONNECT_OPEN and CONNECT_CLOSE procedures. Signed-off-by: Martin Kletzander mklet...@redhat.com --- .gitignore | 1 + src/Makefile.am| 13 +- src/admin/admin_protocol.x | 65

Re: [libvirt] [RFC PATCH 2/2] qemu: Force capabilities cache read if libvirtd date is different

2015-05-20 Thread John Ferlan
On 05/20/2015 10:22 AM, Ján Tomko wrote: s/read/refresh/ in the commit message? On Wed, May 20, 2015 at 08:52:57AM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1195882 Original commit id 'cbde3589' indicates that the cache file would be discarded if either the

Re: [libvirt] [PATCH 02/13] Move daemon-related parts of virNetServer to virNetDaemon

2015-05-20 Thread Martin Kletzander
On Wed, May 20, 2015 at 05:16:04PM +0100, Daniel P. Berrange wrote: On Wed, May 20, 2015 at 06:11:14PM +0200, Michal Privoznik wrote: On 20.05.2015 07:19, Martin Kletzander wrote: This allows to have more servers in one daemon which helps isolating some resources. Signed-off-by: Martin

Re: [libvirt] [PATCH 04/13] Add admin protocol

2015-05-20 Thread Martin Kletzander
On Wed, May 20, 2015 at 06:11:04PM +0200, Michal Privoznik wrote: On 20.05.2015 07:19, Martin Kletzander wrote: For now there are only CONNECT_OPEN and CONNECT_CLOSE procedures. Signed-off-by: Martin Kletzander mklet...@redhat.com --- .gitignore | 1 + src/Makefile.am

[libvirt] [PATCH] virsh: fix a typos issue cause error not right

2015-05-20 Thread Luyao Huang
Signed-off-by: Luyao Huang lhu...@redhat.com --- tools/virsh-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index a72fd05..e939dac 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -500,7 +500,7 @@

Re: [libvirt] [PATCH 2/2] qemuDomainGetNumaParameters: Don't report spurious info

2015-05-20 Thread Martin Kletzander
On Wed, May 20, 2015 at 01:53:14PM +0200, Michal Privoznik wrote: On 19.05.2015 19:15, Martin Kletzander wrote: On Tue, May 19, 2015 at 01:33:11PM +0200, Michal Privoznik wrote: This API does not work well on domains without numatune/. It blindly reports misleading info on a shutoff domain:

[libvirt] [PATCH] conf: fix forget restore ctxt-node when parse memory device success

2015-05-20 Thread Luyao Huang
https://bugzilla.redhat.com/show_bug.cgi?id=1223631 When set a memory device in the xml, sysinfo in xml will be lost. Because we forgot restore ctxt-node to the oldnode after parse memory device, this will make the parse function after virDomainMemoryDefParseXML cannot find a node they need when

Re: [libvirt] [PATCH 04/13] Add admin protocol

2015-05-20 Thread Michal Privoznik
On 20.05.2015 20:42, Martin Kletzander wrote: On Wed, May 20, 2015 at 06:11:04PM +0200, Michal Privoznik wrote: On 20.05.2015 07:19, Martin Kletzander wrote: For now there are only CONNECT_OPEN and CONNECT_CLOSE procedures. Signed-off-by: Martin Kletzander mklet...@redhat.com ---