[libvirt] Entering freeze for libvirt 1.2.16

2015-05-26 Thread Daniel Veillard
I'm one day late but I have tagged the release candidate 1 in git and pushed signed tarballs and rpms to the usual place: ftp://libvirt.org/libvirt/ we have a bit less than 160 commits so far since 1.2.15. I tried it with my usual limited testing and it looks fine, https://ci.centos.org/ see

[libvirt] [PATCH] conf: improve the address check for dimm type

2015-05-26 Thread Luyao Huang
When hot-plug/cold-plug a memory device, we use memcmp() function to check if there is a memory device have the same address with the memory device we want hot-pluged. But qemu forbid use/hot-plug 2 memory device with same slot *or* the same base(qemu side this elemnt named addr). Signed-off-by: L

[libvirt] [PATCH] maint: update to latest gnulib

2015-05-26 Thread Eric Blake
Incorporates fixes for cross-compiling to mingw on rawhide, where gcc 5.1 changes detection of how to properly determine PRIdMAX. * .gnulib: Update to latest, for mingw. Signed-off-by: Eric Blake --- I've missed the freeze for rc1, but confirmed that this update is rather minimal and should onl

Re: [libvirt] Libvirt now using Zanata for translation

2015-05-26 Thread zhang bo
On 2015/3/6 21:20, Daniel P. Berrange wrote: > As of current GIT master, libvirt is fully using Zanata for po file > translation > > After some trouble with the zanata python client, I have now successfully > refreshed & pushed the current libvirt.pot file, and synchronized all > the translation

Re: [libvirt] [PATCH] util: improve the sysinfo element XML format

2015-05-26 Thread John Ferlan
On 05/22/2015 05:26 AM, Luyao Huang wrote: > When set sysinfo element without sub-elements, > libvirt will format it as: > > > > > After improve the format: > > > > Signed-off-by: Luyao Huang > --- > src/util/virsysinfo.c | 33 ++--- > 1 file changed, 22

Re: [libvirt] [PATCH] conf: do not format redirfilter element if it do not have sub-element

2015-05-26 Thread John Ferlan
On 05/22/2015 05:26 AM, Luyao Huang wrote: > When set a redirfilter element without sub-element, libvirt will > format it like this: > > > > > Just drop this element if it do not have any sub-element. > > Signed-off-by: Luyao Huang > --- > src/conf/domain_conf.c | 4 > 1 file

[libvirt] [PATCH 0/3] Better error reporting of bad IP address ranges

2015-05-26 Thread Laine Stump
This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=985653 Laine Stump (3): network: validate DHCP ranges are completely within defined network network: cleanup range loop in networkDnsmasqConfContents util: report all address range errors in virSocketAddrGetRange() src/conf/network

[libvirt] [PATCH 3/3] util: report all address range errors in virSocketAddrGetRange()

2015-05-26 Thread Laine Stump
There are now many more reasons that virSocketAddrGetRange() could fail, so it is much more informative to report the error there instead of in the caller. (one of the two callers was previously assuming success, which is almost surely safe based on the parsing that has already happened to the conf

[libvirt] [PATCH 2/3] network: cleanup range loop in networkDnsmasqConfContents

2015-05-26 Thread Laine Stump
This loop had automatic variable definitions mixed with code. This patch moves the definitions to the top of the function and puts cleanup for them at the bottom. No functional change. --- src/network/bridge_driver.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a

[libvirt] [PATCH 1/3] network: validate DHCP ranges are completely within defined network

2015-05-26 Thread Laine Stump
virSocketAddrGetRange() has been updated to take the network address and prefix, and now checks that both the start and end of the range are within that network, thus validating that the entire range of addresses is in the network. For IPv4, it also checks that ranges to not start with the "network

[libvirt] [PATCH 7/8] parallels: recommend to connect to vz:///system when connection fails

2015-05-26 Thread Maxim Nestratov
Though parallels:///system is still accepted we will encourage users to use vz:///system instead. Signed-off-by: Maxim Nestratov --- src/parallels/parallels_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_dri

[libvirt] [PATCH 4/8] parallels: accept vz as a driver uri and name

2015-05-26 Thread Maxim Nestratov
If 'parallels:///system' uri is specified then connection is made to 'Parallels' driver and domain type will be VIR_DOMAIN_VIRT_PARALLELS. In case of 'vz:///system' connection is established to 'vz' driver and domain type will be VIR_DOMAIN_VIRT_VZ. Signed-off-by: Maxim Nestratov --- src/paralle

[libvirt] [PATCH 8/8] parallels: set virtType depending on driver name

2015-05-26 Thread Maxim Nestratov
We remember driver name in a new field 'drivername' within private parallels connection structure. When a new domain is defined we use this name to set corresponding virtType. We set VIR_DOMAIN_VIRT_VZ for 'vz' driver and VIR_DOMAIN_VIRT_PARALLELS for 'Parallels'. Signed-off-by: Maxim Nestratov -

[libvirt] [PATCH 2/8] parallels: use newly introduced VIR_DOMAIN_VIRT_VZ

2015-05-26 Thread Maxim Nestratov
As soon as we keep backward compatibility we treat this constant as synonym to VIR_DOMAIN_VIRT_PARALLELS. Signed-off-by: Maxim Nestratov --- src/conf/domain_conf.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.

[libvirt] [PATCH 0/8 v3] parallels: add vz driver

2015-05-26 Thread Maxim Nestratov
v2-v3 change: * Patch "parallels: set virtType depending on driver name" reworked. Implemented ability to set virtType depending on driver name. v1-v2 change: * Only "parallels: accept vz as a driver uri and name" patch is changed. Fixed ability to connect to 'parallels' driver and deal wi

[libvirt] [PATCH 1/8] parallels: introduce vz driver constant and string

2015-05-26 Thread Maxim Nestratov
This new name and constant will be used as substitutions for parallels driver one. Signed-off-by: Maxim Nestratov --- src/conf/domain_conf.c | 3 ++- src/conf/domain_conf.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

[libvirt] [PATCH 5/8] parallels: add a new vz connection driver and hypervisor structures

2015-05-26 Thread Maxim Nestratov
We add this connection driver just as an exact copy with different name to keep backward compatibility. Vz stands for Virtuozzo, which is a new name of Parallels Cloud Server. Signed-off-by: Maxim Nestratov --- src/parallels/parallels_driver.c | 20 1 file changed, 16 insert

[libvirt] [PATCH 6/8] parallels: increment the number of connection drivers

2015-05-26 Thread Maxim Nestratov
We need to do this because we have just added a vz driver. Signed-off-by: Maxim Nestratov --- src/libvirt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt.c b/src/libvirt.c index c8a5834..fe62faa 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -109,7 +109,7 @@

[libvirt] [PATCH 3/8] parallels: add new guest capabilities assigned to vz driver

2015-05-26 Thread Maxim Nestratov
Signed-off-by: Maxim Nestratov --- src/parallels/parallels_driver.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c index 4b87213..b2ce2ef 100644 --- a/src/parallels/parallels_driver.c +++ b/src/p

Re: [libvirt] [PATCH] parallels: suppress console output from parallels SDK

2015-05-26 Thread Daniel P. Berrange
On Tue, May 26, 2015 at 08:04:25PM +0300, Maxim Nestratov wrote: > 26.05.2015 18:01, Daniel P. Berrange пишет: > >On Tue, May 26, 2015 at 05:57:41PM +0300, Maxim Nestratov wrote: > >>It is necessary to have unpolluted screen when connecting to > >>parallels driver via virsh. > >>Otherwise a lot of

Re: [libvirt] [PATCH] parallels: suppress console output from parallels SDK

2015-05-26 Thread Maxim Nestratov
26.05.2015 18:01, Daniel P. Berrange пишет: On Tue, May 26, 2015 at 05:57:41PM +0300, Maxim Nestratov wrote: It is necessary to have unpolluted screen when connecting to parallels driver via virsh. Otherwise a lot of unexpected output one will get on the console. Signed-off-by: Maxim Nestratov

Re: [libvirt] [virt-tools-list] ANNOUNCE: virt-manager 1.2.0 released

2015-05-26 Thread Xiaodai Wang
Hi Cole, Great news for virt-manager 1.2.0 released. I downloaded and tried the new --disk type=network feature in fedora 21, but it doesn't work, the err info is "ERRORUnknown options ['type']". I checked the suboption of --disk and can't find "type". Could you help me to check if this fe

[libvirt] [PATCH] maint: update to latest gnulib

2015-05-26 Thread Eric Blake
Time to update to new gnulib before a release. gcc 5.1 introduced a new -Wformat-signedness, and new gnulib now turns it on by default. However, it is still rather lame at the moment, because it warns for enums, even though there is no way to control the signeness of an enum which does not use an

Re: [libvirt] [PATCH 2/2] qemu: Add libvirt version check to refresh capabilities algorithm

2015-05-26 Thread Daniel P. Berrange
On Sat, May 23, 2015 at 10:33:31AM -0400, John Ferlan wrote: > Rather than an algorithm based solely on libvirtd ctime to refresh the > capabilities add the element of the libvirt build version into the equation. > Since that version wouldn't be there prior to this code being run - don't > fail on

[libvirt] [PATCH v2] virsh: Fix to list online cpus using virsh capabilities

2015-05-26 Thread Kothapally Madhu Pavan
Virsh capabilities will list offline cpus as online when libvirt is compiled with numactl option disabled. This fix will list correct set of online cpus. --- src/nodeinfo.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/src/nodeinfo.c b/src/nodei

Re: [libvirt] [PATCH] qemu: Only issue the rtc-reset-reinjection QMP command on x86.

2015-05-26 Thread Andrea Bolognani
On Tue, 2015-05-26 at 13:28 +0200, Peter Krempa wrote: > > The implementer of the check might remember more reasons for arguing > > on this, let him shed the light into this discussion. Michal? > > > > Anyway, this is broken all the way because the command also makes > > sense only with some par

[libvirt] [PATCH 0/8 v2] parallels: add vz driver

2015-05-26 Thread Maxim Nestratov
v1-v2 change: * Only "parallels: accept vz as a driver uri and name" patch is changed. Fixed ability to connect to 'parallels' driver and deal with 'Paralells' domain virt type. Maxim Nestratov (8): parallels: introduce vz driver constant and string parallels: use newly introduced VIR_DOM

[libvirt] [PATCH v2] qemu: Limit rtc-reset-reinjection requirement to x86 only.

2015-05-26 Thread Andrea Bolognani
The QMP command, like the interrupt reinjection logic it's connected to, is only implemented in QEMU when TARGET_I386 is defined, so checking for its availability on any other architecture is pointless. On the other hand, when we're on x86, we shouldn still make sure that rtc-reset-reinjection is

Re: [libvirt] [virt-tools-list] ANNOUNCE: virt-manager 1.2.0 released

2015-05-26 Thread Cole Robinson
On 05/26/2015 07:26 AM, Xiaodai Wang wrote: > Hi Cole, > > Great news for virt-manager 1.2.0 released. I downloaded and tried the new > --disk type=network feature in fedora 21, but it doesn't work, the err info > is "ERRORUnknown options ['type']". > I checked the suboption of --disk and c

Re: [libvirt] [PATCH] Allow PCI virtio on ARM "virt" machine

2015-05-26 Thread Cole Robinson
On 05/26/2015 03:19 AM, Pavel Fedin wrote: > Hi! > >> I think you'll need to add a new qemu capabilities flag >> like QEMU_CAPS_AARCH64_VIRT_PCI that's enabled for qemu 2.3.0 or later... if >> it's available, then we default to PCI. > > How could i check for this ? Actually qemu already has PCI

Re: [libvirt] [PATCH 1/2] qemu: Force capabilities cache refresh if libvirtd date is different

2015-05-26 Thread Daniel P. Berrange
On Sat, May 23, 2015 at 10:33:30AM -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1195882 > > Original commit id 'cbde3589' indicates that the cache file would be > discarded if either the QEMU binary or libvirtd 'ctime' changes; however, > the code only discarded if the Q

[libvirt] [PATCH v2 3/3] storage: Fix problem with disk backend pool allocation calculation

2015-05-26 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1224018 The disk pool recalculates the pool allocation, capacity, and available values each time through processing a newly created disk partition. This created an issue with the allocation setting since the code used is shared with the refresh path. Eac

[libvirt] [PATCH v2 1/3] Revert "storage: Don't duplicate efforts of backend driver"

2015-05-26 Thread John Ferlan
This reverts commit 2ac0e647bdd33d93a374e7ef3eadf2a253c7bf79. Signed-off-by: John Ferlan --- src/storage/storage_driver.c | 30 ++ 1 file changed, 6 insertions(+), 24 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index ac4a74a.

[libvirt] [PATCH v2 0/3] storage: Fix problem with disk backend pool allocation calculation

2015-05-26 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1224018 v1 here: http://www.redhat.com/archives/libvir-list/2015-May/msg00865.html This series adjusts the patches in order to first revert patches for https://bugzilla.redhat.com/show_bug.cgi?id=1206521 and rework the patch to be specific to/for the

[libvirt] [PATCH v2 2/3] storage: Don't adjust pool alloc/avail values for disk backend

2015-05-26 Thread John Ferlan
Commit id '2ac0e647' for https://bugzilla.redhat.com/show_bug.cgi?id=1206521 was meant to be a generic check for the CreateVol, CreateVolFrom, and DeleteVol paths to check if the storage backend's changed the pool's view of allocation or available values. Unfortunately as it turns out this caused

[libvirt] [PATCH 5/8] parallels: add a new vz connection driver and hypervisor structures

2015-05-26 Thread Maxim Nestratov
We add this connection driver just as an exact copy with different name to keep backward compatibility. Vz stands for Virtuozzo, which is a new name of Parallels Cloud Server. Signed-off-by: Maxim Nestratov --- src/parallels/parallels_driver.c | 20 1 file changed, 16 insert

[libvirt] [PATCH 7/8] parallels: recommend to connect to vz:///system when connection fails

2015-05-26 Thread Maxim Nestratov
Though parallels:///system is still accepted we will encourage users to use vz:///system instead. Signed-off-by: Maxim Nestratov --- src/parallels/parallels_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_dri

[libvirt] [PATCH 8/8] parallels: set VIR_DOMAIN_VIRT_VZ virtType for new domains

2015-05-26 Thread Maxim Nestratov
When a new domain is defined we use VIR_DOMAIN_VIRT_VZ instead of VIR_DOMAIN_VIRT_PARALLELS despite the fact it remains supported. Signed-off-by: Maxim Nestratov --- src/parallels/parallels_sdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/parallels/parallels_sdk.c b/

[libvirt] [PATCH 2/8] parallels: use newly introduced VIR_DOMAIN_VIRT_VZ

2015-05-26 Thread Maxim Nestratov
As soon as we keep backward compatibility we treat this constant as synonym to VIR_DOMAIN_VIRT_PARALLELS. Signed-off-by: Maxim Nestratov --- src/conf/domain_conf.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.

[libvirt] [PATCH 3/8] parallels: add new guest capabilities assigned to vz driver

2015-05-26 Thread Maxim Nestratov
Signed-off-by: Maxim Nestratov --- src/parallels/parallels_driver.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c index 4b87213..b2ce2ef 100644 --- a/src/parallels/parallels_driver.c +++ b/src/p

[libvirt] [PATCH 1/8] parallels: introduce vz driver constant and string

2015-05-26 Thread Maxim Nestratov
This new name and constant will be used as substitutions for parallels driver one. Signed-off-by: Maxim Nestratov --- src/conf/domain_conf.c | 3 ++- src/conf/domain_conf.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

[libvirt] [PATCH 6/8] parallels: increment the number of connection drivers

2015-05-26 Thread Maxim Nestratov
We need to do this because we have just added a vz driver. Signed-off-by: Maxim Nestratov --- src/libvirt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt.c b/src/libvirt.c index c8a5834..fe62faa 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -109,7 +109,7 @@

[libvirt] [PATCH 4/8] parallels: accept vz as a driver uri and name

2015-05-26 Thread Maxim Nestratov
If 'parallels:///system' uri is specified then connection is made to 'Parallels' driver and domain type will be VIR_DOMAIN_VIRT_PARALLELS. In case of 'vz:///system' connection is established to 'vz' driver and domain type will be VIR_DOMAIN_VIRT_VZ. Signed-off-by: Maxim Nestratov --- src/paralle

Re: [libvirt] [PATCH v2] qemu: Fix compilation error when enum variable size differs from 'int'

2015-05-26 Thread Eric Blake
On 05/26/2015 02:31 AM, Peter Krempa wrote: > Since commit bcd9a564b631aa virDomainNumatuneGetMode returns the value > via a pointer rather than in the return value. The change triggered > problems with platforms where the compiler decides to use a data type of > size different than integer at the

Re: [libvirt] [PATCH] po: fix translation error for "caller" in zh_CN.po

2015-05-26 Thread Eric Blake
On 05/26/2015 02:34 AM, zhang bo wrote: > > I registered an account on zanata.org, and found the website: > https://fedora.zanata.org/app/#/libvirt/master/translate/libvirt/zh-CN/?id=2094492&selected=true > But when I finished translation, and tried to click 'save as translated', the > words I j

Re: [libvirt] [PATCH] parallels: suppress console output from parallels SDK

2015-05-26 Thread Daniel P. Berrange
On Tue, May 26, 2015 at 05:57:41PM +0300, Maxim Nestratov wrote: > It is necessary to have unpolluted screen when connecting to > parallels driver via virsh. > Otherwise a lot of unexpected output one will get on the console. > > Signed-off-by: Maxim Nestratov > --- > src/parallels/parallels_sdk

[libvirt] [PATCH] parallels: suppress console output from parallels SDK

2015-05-26 Thread Maxim Nestratov
It is necessary to have unpolluted screen when connecting to parallels driver via virsh. Otherwise a lot of unexpected output one will get on the console. Signed-off-by: Maxim Nestratov --- src/parallels/parallels_sdk.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/parallels/paralle

Re: [libvirt] [RFC PATCH] threshold: new API virDomainBlockSetWriteThreshold

2015-05-26 Thread Peter Krempa
On Tue, May 26, 2015 at 08:22:23 -0600, Eric Blake wrote: > On 05/26/2015 04:25 AM, Daniel P. Berrange wrote: > > On Mon, May 25, 2015 at 11:11:14AM +0200, Peter Krempa wrote: > >> On Sat, May 23, 2015 at 21:45:56 -0600, Eric Blake wrote: ... > >> Double? Your last proposal used unsigned long lon

Re: [libvirt] [PATCH] zfs: fix storagepoolxml2xml test

2015-05-26 Thread Cole Robinson
On 05/26/2015 12:30 AM, Roman Bogorodskiy wrote: > Commit 7c2d65d dropped setting default mode. > > Update zfs tests accordingly. > --- > tests/storagepoolxml2xmlout/pool-zfs-sourcedev.xml | 3 --- > tests/storagepoolxml2xmlout/pool-zfs.xml | 3 --- > 2 files changed, 6 deletions(-) >

Re: [libvirt] [RFC PATCH] threshold: new API virDomainBlockSetWriteThreshold

2015-05-26 Thread Eric Blake
On 05/26/2015 04:25 AM, Daniel P. Berrange wrote: > On Mon, May 25, 2015 at 11:11:14AM +0200, Peter Krempa wrote: >> On Sat, May 23, 2015 at 21:45:56 -0600, Eric Blake wrote: >>> qemu 2.3 added a new QMP command block-set-write-threshold, >>> which allows callers to get an interrupt when a file hit

[libvirt] [PATCH] docs: update github project name

2015-05-26 Thread Daniel P. Berrange
The github project was renamed from libvirtproject to libvirt --- docs/downloads.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Pushed as a trivial docs fix diff --git a/docs/downloads.html.in b/docs/downloads.html.in index 73599d6..13a6db1 100644 --- a/docs/downloads.html.in +++

Re: [libvirt] GITHUB readonly mirror site

2015-05-26 Thread Daniel P. Berrange
On Tue, May 26, 2015 at 11:21:06AM +0100, Daniel P. Berrange wrote: > On Fri, May 22, 2015 at 05:15:22PM -0400, Cole Robinson wrote: > > On 05/22/2015 10:55 AM, Daniel P. Berrange wrote: > > > FYI, further to the previous discussion I have created a libvirt > > > organization on github and populate

Re: [libvirt] GITHUB readonly mirror site

2015-05-26 Thread Daniel P. Berrange
On Fri, May 22, 2015 at 03:55:45PM +0100, Daniel P. Berrange wrote: > FYI, further to the previous discussion I have created a libvirt > organization on github and populated the repositories we have. They > are setup in read-only mode and are synced from main libvirt repo > automagically. > > ht

[libvirt] [PATCH v3 2/9] qemuMigrationBeginPhase: Fix function header indentation

2015-05-26 Thread Michal Privoznik
This function is returning a string (domain XML). Since d3ce7363 when it was first introduced, it was indented incorrectly: static char *qemuMigrationBeginPhase(..) Signed-off-by: Michal Privoznik --- src/qemu/qemu_migration.c | 16 1 file changed, 8 insertions(+), 8 deletions(

[libvirt] [PATCH v3 3/9] qemuMigrationDriveMirror: Pass disk format to qemu

2015-05-26 Thread Michal Privoznik
When playing with disk migration lately, I've noticed this warning in domain logs: WARNING: Image format was not specified for 'nbd://masina:49153/drive-virtio-disk0' and probing guessed raw. Automatically detecting the format is dangerous for raw images, write operations on block 0 wil

[libvirt] [PATCH v3 6/9] util: virTypedParams{Filter,PickStrings}

2015-05-26 Thread Michal Privoznik
From: Pavel Boldin Add multikey API: * virTypedParamsFilter that returns all the parameters with specified name. * virTypedParamsPickStrings that returns a list with all the values for specified name and string type. Signed-off-by: Pavel Boldin Signed-off-by: Michal Privoznik --- includ

[libvirt] [PATCH v3 9/9] virsh: selective block device migration

2015-05-26 Thread Michal Privoznik
From: Pavel Boldin Add `virsh migrate' option `--migratedisks' that allows CLI user to explicitly specify block devices to migrate. Signed-off-by: Pavel Boldin Signed-off-by: Michal Privoznik --- tools/virsh-domain.c | 23 +++ tools/virsh.pod | 21

[libvirt] [PATCH v3 5/9] util: multi-value parameters in virTypedParamsAdd*

2015-05-26 Thread Michal Privoznik
From: Pavel Boldin Allow multi-value parameters to be build using virTypedParamsAdd* functions by removing check for duplicates. Signed-off-by: Pavel Boldin Signed-off-by: Michal Privoznik --- src/util/virtypedparam.c | 16 1 file changed, 16 deletions(-) diff --git a/src/ut

[libvirt] [PATCH v3 8/9] qemu: migration: selective block device migration

2015-05-26 Thread Michal Privoznik
From: Pavel Boldin Implement a `migrate_disks' parameters for the QEMU driver. This multi- value parameter can be used to explicitly specify what block devices are to be migrated using the NBD server. Tunnelled migration using NBD is to be done. Signed-off-by: Pavel Boldin Signed-off-by: Michal

[libvirt] [PATCH v3 1/9] virDomainDiskGetSource: Mark passed disk as 'const'

2015-05-26 Thread Michal Privoznik
The disk is not changed anywhere in the function. Mark this fact in the function header too. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 2 +- src/conf/domain_conf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_c

[libvirt] [PATCH v3 7/9] util: add virTypedParamsAddStringList

2015-05-26 Thread Michal Privoznik
From: Pavel Boldin The `virTypedParamsAddStringList' function provides interface to add a NULL-terminated array of string values as a multi-value to the params. Signed-off-by: Pavel Boldin Signed-off-by: Michal Privoznik --- include/libvirt/libvirt-host.h | 6 ++ src/libvirt_public.syms

[libvirt] [PATCH v3 4/9] util: multi-value virTypedParameter

2015-05-26 Thread Michal Privoznik
From: Pavel Boldin The `virTypedParamsValidate' function now can be instructed to allow multiple entries for some of the keys. For this flag the type with the `VIR_TYPED_PARAM_MULTIPLE' flag. Add unit tests for this new behaviour. Signed-off-by: Pavel Boldin Signed-off-by: Michal Privoznik --

[libvirt] [PATCH v3 0/9] Selective block device migration implementation

2015-05-26 Thread Michal Privoznik
I've taken Pavel's patches, reworked them a bit, added something and sending v3. The original patches can be found here: https://www.redhat.com/archives/libvir-list/2015-May/msg00697.html Michal Privoznik (3): virDomainDiskGetSource: Mark passed disk as 'const' qemuMigrationBeginPhase: Fix fu

[libvirt] [PATCH] storage: Report error when using metadata prealloc with non-qcow2 volumes

2015-05-26 Thread Erik Skultety
We already report error from backend (virStorageBackendCreateRaw, virStorageBackendCreateBlockFrom), but we should also report the same error (applies to raw formated volumes and block type volumes as well) when creating a volume from a XML, not only from an existing volume. --- src/storage/storag

Re: [libvirt] [PATCH] storage: Fix problem with disk backend pool allocation calculation

2015-05-26 Thread John Ferlan
On 05/26/2015 07:15 AM, Ján Tomko wrote: > On Sat, May 23, 2015 at 09:39:58AM -0400, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1224018 >> >> The disk pool recalculates the pool allocation, capacity, and available >> values each time through processing a newly created disk

Re: [libvirt] Strange test build failure

2015-05-26 Thread Daniel P. Berrange
On Tue, May 26, 2015 at 11:54:38AM +0100, Dimitri John Ledkov wrote: > On 23 May 2015 at 18:14, Roman Bogorodskiy wrote: > > Daniel P. Berrange wrote: > > > >> On Fri, May 22, 2015 at 05:59:49PM +0200, Michal Privoznik wrote: > >> > On 22.05.2015 16:39, Dimitri John Ledkov wrote: > >> > > On 22

Re: [libvirt] [PATCH] qemu: Only issue the rtc-reset-reinjection QMP command on x86.

2015-05-26 Thread Peter Krempa
On Tue, May 26, 2015 at 10:53:53 +0200, Martin Kletzander wrote: > On Tue, May 26, 2015 at 10:08:58AM +0200, Peter Krempa wrote: > >On Mon, May 25, 2015 at 17:43:05 +0200, Martin Kletzander wrote: > >> On Mon, May 25, 2015 at 05:26:01PM +0200, Peter Krempa wrote: > >> >On Mon, May 25, 2015 at 16:59

Re: [libvirt] [RFC PATCH] threshold: new API virDomainBlockSetWriteThreshold

2015-05-26 Thread Daniel P. Berrange
On Mon, May 25, 2015 at 11:11:14AM +0200, Peter Krempa wrote: > On Sat, May 23, 2015 at 21:45:56 -0600, Eric Blake wrote: > > qemu 2.3 added a new QMP command block-set-write-threshold, > > which allows callers to get an interrupt when a file hits a > > write threshold, rather than the current appr

Re: [libvirt] GITHUB readonly mirror site

2015-05-26 Thread Daniel P. Berrange
On Fri, May 22, 2015 at 05:15:22PM -0400, Cole Robinson wrote: > On 05/22/2015 10:55 AM, Daniel P. Berrange wrote: > > FYI, further to the previous discussion I have created a libvirt > > organization on github and populated the repositories we have. They > > are setup in read-only mode and are syn

Re: [libvirt] [PATCH] storage: Fix problem with disk backend pool allocation calculation

2015-05-26 Thread Ján Tomko
On Sat, May 23, 2015 at 09:39:58AM -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1224018 > > The disk pool recalculates the pool allocation, capacity, and available > values each time through processing a newly created disk partition. > However, there were two issues with

Re: [libvirt] Strange test build failure

2015-05-26 Thread Dimitri John Ledkov
On 23 May 2015 at 18:14, Roman Bogorodskiy wrote: > Daniel P. Berrange wrote: > >> On Fri, May 22, 2015 at 05:59:49PM +0200, Michal Privoznik wrote: >> > On 22.05.2015 16:39, Dimitri John Ledkov wrote: >> > > On 22 May 2015 at 13:53, Michal Privoznik wrote: >> > >> On 22.05.2015 14:18, Daniel P

Re: [libvirt] [PATCH 01/10] util: Introduce thread queues

2015-05-26 Thread Daniel P. Berrange
On Mon, May 25, 2015 at 04:04:37PM +0200, Jiri Denemark wrote: > On Fri, May 22, 2015 at 14:28:05 +0200, Jiri Denemark wrote: > > On Fri, May 22, 2015 at 13:09:17 +0100, Daniel P. Berrange wrote: > > > On Fri, May 22, 2015 at 12:42:34AM +0200, Jiri Denemark wrote: > > > > Our usage of pthread condi

Re: [libvirt] [PATCH] qemu: Only issue the rtc-reset-reinjection QMP command on x86.

2015-05-26 Thread Martin Kletzander
On Tue, May 26, 2015 at 10:08:58AM +0200, Peter Krempa wrote: On Mon, May 25, 2015 at 17:43:05 +0200, Martin Kletzander wrote: On Mon, May 25, 2015 at 05:26:01PM +0200, Peter Krempa wrote: >On Mon, May 25, 2015 at 16:59:08 +0200, Andrea Bolognani wrote: >> The command is only defined in QEMU for

Re: [libvirt] [PATCH] po: fix translation error for "caller" in zh_CN.po

2015-05-26 Thread zhang bo
On 2015/5/26 10:43, Eric Blake wrote: > On 05/25/2015 08:28 PM, zhang bo wrote: >> IME-Version: 1.0 >> Content-Type: text/plain; charset=UTF-8 >> Content-Transfer-Encoding: 8bit >> >> caller should be translated to "璋冪敤绋嬪簭" rather than "璋冨害绋嬪簭", which in fact >> refers to "scheduler" in English. >

[libvirt] [PATCH v2] qemu: Fix compilation error when enum variable size differs from 'int'

2015-05-26 Thread Peter Krempa
Since commit bcd9a564b631aa virDomainNumatuneGetMode returns the value via a pointer rather than in the return value. The change triggered problems with platforms where the compiler decides to use a data type of size different than integer at the point where we typecast it. Work around the issue b

Re: [libvirt] [PATCH] qemu: Fix compilation error when enum variable size differs from 'int'

2015-05-26 Thread Peter Krempa
On Mon, May 25, 2015 at 18:28:42 +0200, Michal Privoznik wrote: > On 25.05.2015 17:47, Peter Krempa wrote: > > On Mon, May 25, 2015 at 17:35:19 +0200, Michal Privoznik wrote: > >> On 25.05.2015 17:18, Peter Krempa wrote: > >>> Since commit bcd9a564b631aa virDomainNumatuneGetMode returns the value >

Re: [libvirt] [PATCH] qemu: Only issue the rtc-reset-reinjection QMP command on x86.

2015-05-26 Thread Peter Krempa
On Mon, May 25, 2015 at 17:43:05 +0200, Martin Kletzander wrote: > On Mon, May 25, 2015 at 05:26:01PM +0200, Peter Krempa wrote: > >On Mon, May 25, 2015 at 16:59:08 +0200, Andrea Bolognani wrote: > >> The command is only defined in QEMU for TARGET_I386, so issuing it on > >> any other architecture

Re: [libvirt] [PATCH] qemu: Only issue the rtc-reset-reinjection QMP command on x86.

2015-05-26 Thread Andrea Bolognani
On Mon, 2015-05-25 at 17:43 +0200, Martin Kletzander wrote: > But on x86 we don't even want to call the SetTime command when we > cannot reset the rtc reinjection. On ppc there is no reinjection > being done, hence nothing to reset. Exactly. I think we want to keep the checks as they are for x86

Re: [libvirt] [PATCHv2 0/6] Selective block device migration implementation

2015-05-26 Thread Michal Privoznik
On 26.05.2015 01:16, Pavel Boldin wrote: > Thank you. > > I will go through your comments just in case I'm going to push any other > changes. Yeah, more eyes more see. > > Sorry for the inconvenience from my patches :-/. No, it's okay. In fact your patches were good given that this would be yo

Re: [libvirt] [PATCH] Allow PCI virtio on ARM "virt" machine

2015-05-26 Thread Pavel Fedin
Hi! > I think you'll need to add a new qemu capabilities flag > like QEMU_CAPS_AARCH64_VIRT_PCI that's enabled for qemu 2.3.0 or later... if > it's available, then we default to PCI. How could i check for this ? Actually qemu already has PCI for both 32 and 64-bit virt board for quite some tim