On 17.04.2015 10:53, Chen Fan wrote:
via initialize callback to create bond device.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu_agent.c | 118
src/qemu/qemu_agent.h | 10
src/qemu/qemu_domain.c | 70
Hi,
When I use the Live migration through the oVirt Administration Portal,
everything works fine without any errors, but When I want to migrate VMs using
the command virsh migrate, it doesn't work at all.
The connexion works fine :
[root@unc-srv-hyp2 ~]$ virsh -c
It's tagged in git, and signed tarball and rpms are at the
usual place:
ftp://libvirt.org/libvirt/
So this includes at least one patchset from Jim :-)
I didn't noticed anything bad in my own limited testing,
but others need to give it a try to check on different
environments and
On 28.05.2015 23:08, Jim Fehlig wrote:
On 05/28/2015 05:33 AM, Michal Privoznik wrote:
On 27.05.2015 20:45, Jim Fehlig wrote:
On 05/23/2015 07:22 AM, Daniel Veillard wrote:
Hi everybody,
if we want to get it by next month, we should probably freeze on
Tuesday
for an 1.2.16 on June
On 01.05.2015 20:56, Jim Fehlig wrote:
Commit 198cc1d3 introduced libxl-lockd and libxl-sanlock config
files but forgot to add them to the spec file. Follow-up commit
62b18d98 added the files to daemon-driver-libxl, but missed adding
them to the daemon package when configuring libvirt
On Thu, May 28, 2015 at 08:51:37PM -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1224088
commit id 'bd00e00e' neglected to add the new adapter source options
into the if condition that allowed printing the source XML fields.
The adapter type='fc_host'.../ doesn't
On 05/26/2015 09:01 AM, Michal Privoznik wrote:
When playing with disk migration lately, I've noticed this warning in
domain logs:
WARNING: Image format was not specified for
'nbd://masina:49153/drive-virtio-disk0' and probing guessed raw.
Automatically detecting the format is
On 05/26/2015 09:01 AM, Michal Privoznik wrote:
From: Pavel Boldin pbol...@mirantis.com
The `virTypedParamsValidate' function now can be instructed to allow
multiple entries for some of the keys. For this flag the type with
the `VIR_TYPED_PARAM_MULTIPLE' flag.
Add unit tests for this
From: Zhang Bo oscar.zhan...@huawei.com
when we run the command 'virsh dommemstat xxx',
althrough memballoon's model is set 'none' in vm's XML,
it still reports an error in libvirtd.log.
error : qemuMonitorFindBalloonObjectPath:1042 : internal error: Cannot
determine balloon device path
[CC'ing libvirt-lxc folks]
Am 28.05.2015 um 23:32 schrieb Eric W. Biederman:
Richard Weinberger rich...@nod.at writes:
Am 28.05.2015 um 21:57 schrieb Eric W. Biederman:
FWIW, it breaks also libvirt-lxc:
Error: internal error: guest failed to start: Failed to re-mount /proc/sys
on
On Fri, May 29, 2015 at 17:17:07 +0800, Wang Yufei wrote:
From: Zhang Bo oscar.zhan...@huawei.com
when we run the command 'virsh dommemstat xxx',
althrough memballoon's model is set 'none' in vm's XML,
it still reports an error in libvirtd.log.
error : qemuMonitorFindBalloonObjectPath:1042
When attempting to hotplug a virtio-serial console to a domain
that had no virtio-serial controllers (not even those that
are added by libvirt when some devices need them) at daemon startup,
report a user-friendly error:
error: Failed to attach device from console.xml
error: internal error: no
On Fri, May 29, 2015 at 15:11:35 +0200, Ján Tomko wrote:
Use xmlFreeDoc instead of plain xmlFree.
4 bytes in 1 blocks are definitely lost in loss record 9 of 1,084
at 0x4C29F80: malloc (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x70730D6: xmlStrndup (in
On 27.05.2015 20:05, Shivaprasad G Bhat wrote:
Console devices have their pty devices assigned when the qemu is actually
started. The libvirt spends considerable amount of time to start the qemu if
the guest has multiple passthrough devices. If time is spent during the
hostdev preparation,
On Fri, May 29, 2015 at 15:11:22 +0200, Ján Tomko wrote:
The Subject conveys the most information of this commit message.
I'd probably mention something like:
By removing the check priv-vioserailaddrs gets always allocated ...
When attempting to hotplug a virtio-serial console to a domain
Libxl's vcpu pinning would work only if the vcpu array was ordered and
was not sparse. Remove the condition and iterate the pinning array
properly.
---
src/libxl/libxl_domain.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/src/libxl/libxl_domain.c
Document the top level function rather than both bottom level ones. It
makes looking the docs up quicker.
---
src/qemu/qemu_monitor.c | 4
src/qemu/qemu_monitor_json.c | 9 +++--
src/qemu/qemu_monitor_text.c | 9 +++--
3 files changed, 10 insertions(+), 12 deletions(-)
diff
Get rid of the unnecessary allocation and copying of the bitmap and
clean up some unnecesary temporary variables.
---
src/qemu/qemu_driver.c | 20 +++-
1 file changed, 3 insertions(+), 17 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index
---
src/qemu/qemu_monitor.c | 8 ++--
src/qemu/qemu_monitor.h | 2 +-
src/qemu/qemu_monitor_json.c | 12 +---
src/qemu/qemu_monitor_json.h | 2 +-
src/qemu/qemu_monitor_text.c | 12 +---
src/qemu/qemu_monitor_text.h | 2 +-
6 files changed, 19 insertions(+), 19
In case when vcpu ... cpuset= is not specified, the vcpupin array is
not guaranteed to be allocated to def-vcpus. This would cause a crash
for TCG since it does not report thread IDs for vCPUs.
---
src/qemu/qemu_process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This reverts commit 01692bb167f7ab81213921ba1116d46a4651ef0e.
Quoting the original commit message:
Not sure if it's the correct way to add cputune xml for xend driver...
It is not. The defition created that is converted from the internal xend
structures would also be leaked since it isn't used
---
src/libxl/libxl_domain.c | 21 -
1 file changed, 4 insertions(+), 17 deletions(-)
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index c7f0ed9..89782c3 100644
--- a/src/libxl/libxl_domain.c
+++ b/src/libxl/libxl_domain.c
@@ -797,34 +797,21 @@
---
src/qemu/qemu_driver.c | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 5a01514..e7382ea 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -9197,10 +9197,10 @@
---
src/qemu/qemu_driver.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 1c76a1f..d729e6c 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -2434,10 +2434,10 @@ static int
After libvirt issues the balloon resize command, the current balloon
size needs to be changed to the maximum memory size since the vCPUs were
not started and thus the balloon driver could not return the memory.
Since GetXMLDesc and other APIs return the balloon size without updating
it in case
---
src/qemu/qemu_driver.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 1dfba58..9c0f7d3 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -5268,13 +5268,13 @@
---
src/qemu/qemu_driver.c | 41 +
1 file changed, 17 insertions(+), 24 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index e7382ea..2aa754d 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -5012,7 +5012,8 @@
---
src/qemu/qemu_driver.c | 22 --
1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index ea4e75b..18169c5 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -4833,11 +4833,11 @@
On 05/26/2015 09:01 AM, Michal Privoznik wrote:
From: Pavel Boldin pbol...@mirantis.com
The `virTypedParamsAddStringList' function provides interface to add a
NULL-terminated array of string values as a multi-value to the params.
Signed-off-by: Pavel Boldin pbol...@mirantis.com
Since the monitor code now supports ullongs when setting balloon size,
drop the legacy code with overflow checking.
Additionally the comment mentioning that the job is treated as a sync
job does not make sense any more since the monitor is entered
asynchronously.
---
src/qemu/qemu_process.c | 38
Since some functions can be optimized by reusing the buffers that they
already have instead of allocating and copying new ones, lets split
virBitmapToData to two functions where one only converts the data and
the second one is a wrapper that allocates the buffer if necessary.
---
Reuse the function so that we can get rid of a lot of temporary
allocations.
---
src/qemu/qemu_driver.c | 33 -
1 file changed, 12 insertions(+), 21 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index e34cb6c..f6107b7 100644
---
On 28.05.2015 22:58, Jim Fehlig wrote:
The generated AUTHORS file contains many duplicates. If an author
has N commits, there will be N entries for the author in AUTHORS.
Check if an author already exists in the list before appending.
While at it, add a .mailmap (derived from libivrt's
Use xmlFreeDoc instead of plain xmlFree.
4 bytes in 1 blocks are definitely lost in loss record 9 of 1,084
at 0x4C29F80: malloc (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x70730D6: xmlStrndup (in /usr/lib64/libxml2.so.2.9.2)
by 0x701E3DC: xmlNewDoc (in
Add a macro that will allow to simplify overflow checks and make them
more universal in case data types change.
---
src/util/virutil.h | 11 +++
tests/utiltest.c | 30 ++
2 files changed, 41 insertions(+)
diff --git a/src/util/virutil.h b/src/util/virutil.h
These are preliminary refactors that will simplify the code base. The ultimate
goal of this refactoring is to aggregate all vCPU information
(pinning, scheduler,...) into a separate structure rather than storing them in
multiple places. This will then in turn help in making a saner implementation
While we probably won't see machines with more than 65536 cpus for a
while lets store the cpu count as an integer so that we can avoid quite
a lot of overflow checks in our code.
---
src/conf/domain_conf.c | 50 ++
src/conf/domain_conf.h | 4 ++--
Store the emulator pinning cpu mask as a pure virBitmap rather than the
virDomainPinDef since it stores only the bitmap and refactor
qemuDomainPinEmulator to do the same operations in a much saner way.
As a side effect virDomainEmulatorPinAdd and virDomainEmulatorPinDel can
be removed since they
On 05/26/2015 09:01 AM, Michal Privoznik wrote:
From: Pavel Boldin pbol...@mirantis.com
Add multikey API:
* virTypedParamsFilter that returns all the parameters with specified name.
* virTypedParamsPickStrings that returns a list with all the values for
specified name and string
Reuse the approach in qemuDomainGetVcpuPinInfo.
---
src/libxl/libxl_driver.c | 48 +++-
1 file changed, 23 insertions(+), 25 deletions(-)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index c297d12..9be89f2 100644
---
The vCPU pinning definition gets removed when the domain definition is
being freed later. If there is no next configuration it would remove the
configured pinning.
---
src/libxl/libxl_domain.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/src/libxl/libxl_domain.c
---
src/qemu/qemu_driver.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index f6107b7..3fdc448 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -5508,8 +5508,6 @@
Since the returned structure uses unsigned long for memory sizes add a
few overflow checks to notify the user in case we are not able to
represent given values.
---
src/qemu/qemu_driver.c | 41 -
1 file changed, 24 insertions(+), 17 deletions(-)
diff --git
---
src/qemu/qemu_driver.c | 23 +++
1 file changed, 7 insertions(+), 16 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index b799d6e..c1dca36 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -5792,8 +5792,8 @@
In the pre-NUMA ages pinning a vCPU to all pCPUs was eaqual to deleting
the pinning info. Now it does not entirely work that way. Pinning a vCPU
to all pCPUs might be a desired operation. Additionally removal of the
pinning will result into using the default pinning information at the
next boot
---
src/qemu/qemu_driver.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index d729e6c..5969f5c 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -5514,8 +5514,8 @@
---
src/qemu/qemu_driver.c | 31 ---
1 file changed, 12 insertions(+), 19 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 96fc0d4..1c76a1f 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -2304,10 +2304,10 @@ static
---
src/qemu/qemu_driver.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 5969f5c..b799d6e 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -5756,7 +5756,6 @@
---
src/conf/domain_conf.h | 58 ++
1 file changed, 30 insertions(+), 28 deletions(-)
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index c36dfd1..a0f68ea 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -1926,24
---
src/qemu/qemu_driver.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 9c0f7d3..ea4e75b 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -5398,14 +5398,13 @@
When qemu does not support the balloon event the current memory size
needs to be queried. Since there are two places that implement the same
logic, split it out into a function and reuse.
---
src/qemu/qemu_domain.c | 64 ++
src/qemu/qemu_domain.h | 3 ++
---
src/qemu/qemu_driver.c | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index c1dca36..5a01514 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -6151,32 +6151,22 @@
Internal structures use unsigned int, so there's no need for this legacy
check that was copied from the vCPU pinning api.
---
src/libvirt-domain.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 05990c7..7e6d749 100644
---
---
src/qemu/qemu_driver.c | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 2aa754d..1dfba58 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -5198,13 +5198,11 @@
virDomainLiveConfigHelperMethod that is used for this job now does
modify the flags but still requires the callers to extract the correct
definition objects.
In addition coverity and other static analyzers are usually unhappy as
they don't grasp the fact that @flags are upadted according to the
Hi dear!
Today I came across a problem, the following is a log and software versions.
soft version:
os:centos 6.5
libvirt:0.10.29
qemu:0.12.415
2015-05-28 03:28:58.001+: 20919: error : qemuDomainObjBeginJobInternal:843
: Timed out during operation: cannot acquire state change lock
On 26.05.2015 21:48, Laine Stump wrote:
This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=985653
Laine Stump (3):
network: validate DHCP ranges are completely within defined network
network: cleanup range loop in networkDnsmasqConfContents
util: report all address range
On 05/26/2015 09:01 AM, Michal Privoznik wrote:
From: Pavel Boldin pbol...@mirantis.com
Add `virsh migrate' option `--migratedisks' that allows CLI user to
explicitly specify block devices to migrate.
Signed-off-by: Pavel Boldin pbol...@mirantis.com
Signed-off-by: Michal Privoznik
On 05/26/2015 03:48 PM, Laine Stump wrote:
virSocketAddrGetRange() has been updated to take the network address
and prefix, and now checks that both the start and end of the range
are within that network, thus validating that the entire range of
addresses is in the network. For IPv4, it also
It is possible to attach volumes to containers but since they are
added they are reported erroneously as filesystems. It is fixed
in this patch. And as soon as bus type has no meaning for containers
we always report SATA for such disks.
In case a container is created with the only disk based on
On 05/29/2015 01:31 AM, Michal Privoznik wrote:
On 01.05.2015 20:56, Jim Fehlig wrote:
Commit 198cc1d3 introduced libxl-lockd and libxl-sanlock config
files but forgot to add them to the spec file. Follow-up commit
62b18d98 added the files to daemon-driver-libxl, but missed adding
them to the
On 05/26/2015 09:01 AM, Michal Privoznik wrote:
From: Pavel Boldin pbol...@mirantis.com
Implement a `migrate_disks' parameters for the QEMU driver. This multi-
value parameter can be used to explicitly specify what block devices
are to be migrated using the NBD server. Tunnelled migration
On Thu, May 21, 2015 at 3:12 PM, Christophe Fergeau cferg...@redhat.com wrote:
On Mon, May 18, 2015 at 03:11:07PM +0100, Zeeshan Ali (Khattak) wrote:
Add binding for virStoragePoolGetAutostart virStoragePoolSetAutostart.
---
libvirt-gobject/libvirt-gobject-storage-pool.c | 52
Martin Kletzander wrote:
On Thu, May 28, 2015 at 11:11:06AM +0400, Roman Bogorodskiy wrote:
Jim Fehlig wrote:
On 05/27/2015 09:06 AM, Martin Kletzander wrote:
On Sun, May 24, 2015 at 06:45:02PM +0300, Roman Bogorodskiy wrote:
The libxl tries to check if it's running in dom0 by
Richard Weinberger rich...@nod.at writes:
[CC'ing libvirt-lxc folks]
Am 28.05.2015 um 23:32 schrieb Eric W. Biederman:
Richard Weinberger rich...@nod.at writes:
Am 28.05.2015 um 21:57 schrieb Eric W. Biederman:
FWIW, it breaks also libvirt-lxc:
Error: internal error: guest failed to
From: Zhang Bo oscar.zhan...@huawei.com
when we run the command 'virsh dommemstat xxx',
althrough memballoon's model is set 'none' in vm's XML,
it still reports an error in libvirtd.log.
error : qemuMonitorFindBalloonObjectPath:1042 : internal error: Cannot
determine balloon device path
On 2015/5/29 19:16, Peter Krempa wrote:
On Fri, May 29, 2015 at 17:17:07 +0800, Wang Yufei wrote:
From: Zhang Bo oscar.zhan...@huawei.com
when we run the command 'virsh dommemstat xxx',
althrough memballoon's model is set 'none' in vm's XML,
it still reports an error in libvirtd.log.
error
On 05/29/2015 12:30 PM, John Ferlan wrote:
On 05/26/2015 03:48 PM, Laine Stump wrote:
virSocketAddrGetRange() has been updated to take the network address
and prefix, and now checks that both the start and end of the range
are within that network, thus validating that the entire range of
On 05/29/2015 06:49 AM, Michal Privoznik wrote:
On 28.05.2015 22:58, Jim Fehlig wrote:
The generated AUTHORS file contains many duplicates. If an author
has N commits, there will be N entries for the author in AUTHORS.
Check if an author already exists in the list before appending.
While at
69 matches
Mail list logo
