Re: [libvirt] [RFC] libvirt support multi-thread compression for live migration

2015-06-04 Thread Feng, Shaohe
-Original Message- From: Qiao, Liyong Sent: Wednesday, June 3, 2015 7:49 AM To: Eric Blake; Feng, Shaohe; libvir-list@redhat.com Cc: Bhandaru, Malini K; Ding, Jian-feng; Chylinski, Arek; Koniszewski, Pawel; Li, Liang Z; berra...@redhat.com; veill...@redhat.com Subject: Re: [RFC]

Re: [libvirt] [RFC] libvirt support multi-thread compression for live migration

2015-06-04 Thread Qiao,Liyong
On 2015年06月04日 20:09, Jiri Denemark wrote: On Tue, Jun 02, 2015 at 11:02:27 -0600, Eric Blake wrote: On 06/02/2015 07:56 AM, Qiao, Liyong wrote: Hi Eric Thanks for replying the mail, replied in lines. +virdomainMigrateGetParameters(virDomainPtr domain, +

Re: [libvirt] [RFC] libvirt support multi-thread compression for live migration

2015-06-04 Thread Qiao,Liyong
On 2015年06月04日 20:01, Jiri Denemark wrote: On Wed, Jun 03, 2015 at 15:13:17 +, Feng, Shaohe wrote: Eric, Thank you for reply. Is it necessary to expose these two APIs to user application? + virdomainMigrateSetCapabilities + virdomainMigrateGetCapabilities For qemu , the migration

[libvirt] [PATCH] remote: fix odd comma operator

2015-06-04 Thread Eric Blake
Commit 1882c0bd accidentally used ',' instead of ';'; oddly enough, the result was still syntactically valid (yes, C is a fun language). But it made me do a double take; it's better to use idiomatic syntax. * daemon/remote.c (remoteRelayDomainEventDeviceAdded): Fix harmless typo. Signed-off-by:

Re: [libvirt] [RFC] libvirt support multi-thread compression for live migration

2015-06-04 Thread Eric Blake
On 06/04/2015 06:31 PM, Qiao,Liyong wrote: On 2015年06月04日 20:01, Jiri Denemark wrote: On Wed, Jun 03, 2015 at 15:13:17 +, Feng, Shaohe wrote: Eric, Thank you for reply. Is it necessary to expose these two APIs to user application? + virdomainMigrateSetCapabilities +

Re: [libvirt] [RFC] libvirt support multi-thread compression for live migration

2015-06-04 Thread Li, Liang Z
On 2015年06月04日 20:01, Jiri Denemark wrote: On Wed, Jun 03, 2015 at 15:13:17 +, Feng, Shaohe wrote: Eric, Thank you for reply. Is it necessary to expose these two APIs to user application? + virdomainMigrateSetCapabilities + virdomainMigrateGetCapabilities For qemu , the

Re: [libvirt] [PATCH v2 3/4] qemu: Add capability for vhost-user multiqueue

2015-06-04 Thread Martin Kletzander
On Thu, Jun 04, 2015 at 07:04:15PM +0200, Martin Kletzander wrote: The support for this was added in QEMU with commit 830d70db692e374b5f4407f96a1ceefdcc97. Unfortunately we have to do another ugly version-based capability check. The other option would be not to check for the capability at

[libvirt] [PATCH v2 4/5] rpc: Don't use unrelated value as privateData of client

2015-06-04 Thread Martin Kletzander
From: Daniel P. Berrange berra...@redhat.com Append privateData of the client only if there are any, otherwise the previous value (socket data) will get there again. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/rpc/virnetserverclient.c | 13 +++-- 1 file changed, 7

Re: [libvirt] [PATCH 4/4] qemu: add multiqueue vhost-user support

2015-06-04 Thread Martin Kletzander
On Thu, Jun 04, 2015 at 05:54:17PM +0200, Maxime Leroy wrote: On Thu, Jun 4, 2015 at 3:43 PM, Martin Kletzander mklet...@redhat.com wrote: From: Maxime Leroy maxime.le...@6wind.com This patch adds the support of queues attribute of the driver element for vhost-user interface type. Example:

[libvirt] [PATCH v2 0/5] RPC JSON (de)serialization and fixes

2015-06-04 Thread Martin Kletzander
I took the liberty of changing Daniel's version and fix it up a bit. I've split it into multiple patches, removed unneeded functions, and fixed it for building without avahi. First version here: https://www.redhat.com/archives/libvir-list/2015-May/msg00812.html Daniel P. Berrange (4): rpc:

[libvirt] [PATCH v2 3/5] rpc: Make virNetServerAddClient function dynamic

2015-06-04 Thread Martin Kletzander
From: Daniel P. Berrange berra...@redhat.com As opposed to 'static'; by exporting it (privately). Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/libvirt_remote.syms | 1 + src/rpc/virnetserver.c | 4 ++-- src/rpc/virnetserver.h | 3 +++ 3 files changed, 6 insertions(+), 2

[libvirt] [PATCH v2 4/4] qemu: add multiqueue vhost-user support

2015-06-04 Thread Martin Kletzander
From: Maxime Leroy maxime.le...@6wind.com This patch adds the support of queues attribute of the driver element for vhost-user interface type. Example: interface type='vhostuser' mac address='52:54:00:ee:96:6d'/ source type='unix' path='/tmp/vhost2.sock' mode='client'/ model

[libvirt] [PATCH v2 0/4] Add support for vhost-user with multi-queue

2015-06-04 Thread Martin Kletzander
Also some tiny clean-up. Martin Kletzander (2): conf: Ignore multiqueue with one queue. qemu: Add capability for vhost-user multiqueue Maxime Leroy (2): docs: Clarify that attribute name is not used for vhostuser qemu: add multiqueue vhost-user support docs/formatdomain.html.in

[libvirt] [PATCH v2 2/5] rpc: add testing of RPC JSON (de)serialization

2015-06-04 Thread Martin Kletzander
From: Daniel P. Berrange berra...@redhat.com The virNetServer class has the ability to serialize its state to a JSON file, and then re-load that data after an in-place execve() call to re-connect to active file handles. This data format is critical ABI that must have compatibility across

[libvirt] [PATCH v2 5/5] rpc: Fix reference counting around virNetSocketAddIOCallback

2015-06-04 Thread Martin Kletzander
From: Daniel P. Berrange berra...@redhat.com Ref service passed as a parameter to the callback. And don't unref the socket that is part of the service being passed at another point in code. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/rpc/virnetserverservice.c | 6 -- 1

[libvirt] [PATCH v2 1/5] mdns: Set error when failing due to missing avahi

2015-06-04 Thread Martin Kletzander
When building without avahi support, we used VIR_DEBUG() to note that to the user. However, functions that fail because of that (return NULL/-1) did not set the error message. This was the only file that forgot to do such thing. Signed-off-by: Martin Kletzander mklet...@redhat.com ---

Re: [libvirt] [libvirt-glib v2] storage-pool: API to get/set autostart flag

2015-06-04 Thread Christophe Fergeau
Looks good, ACK. Christophe On Wed, Jun 03, 2015 at 09:46:35PM +0100, Zeeshan Ali (Khattak) wrote: Add binding for virStoragePoolGetAutostart virStoragePoolSetAutostart. --- libvirt-gobject/libvirt-gobject-storage-pool.c | 51 ++

[libvirt] [PATCH v2 2/4] docs: Clarify that attribute name is not used for vhostuser

2015-06-04 Thread Martin Kletzander
From: Maxime Leroy maxime.le...@6wind.com Signed-off-by: Maxime Leroy maxime.le...@6wind.com Signed-off-by: Martin Kletzander mklet...@redhat.com --- docs/formatdomain.html.in | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index

Re: [libvirt] [PATCH 4/4] qemu: add multiqueue vhost-user support

2015-06-04 Thread Maxime Leroy
On Thu, Jun 4, 2015 at 3:43 PM, Martin Kletzander mklet...@redhat.com wrote: From: Maxime Leroy maxime.le...@6wind.com This patch adds the support of queues attribute of the driver element for vhost-user interface type. Example: interface type='vhostuser' mac

Re: [libvirt] [PATCH 3/4] qemu: Add capability for vhost-user multiqueue

2015-06-04 Thread Martin Kletzander
On Thu, Jun 04, 2015 at 05:56:20PM +0200, Maxime Leroy wrote: On Thu, Jun 4, 2015 at 3:43 PM, Martin Kletzander mklet...@redhat.com wrote: The support for this was added in QEMU with commit 830d70db692e374b5f4407f96a1ceefdcc97. Unfortunately we have to do another ugly version-based

[libvirt] [PATCH v2 3/4] qemu: Add capability for vhost-user multiqueue

2015-06-04 Thread Martin Kletzander
The support for this was added in QEMU with commit 830d70db692e374b5f4407f96a1ceefdcc97. Unfortunately we have to do another ugly version-based capability check. The other option would be not to check for the capability at all and leave that to qemu as it's doen with multiqueue tap devices.

[libvirt] [PATCH v2 1/4] conf: Ignore multiqueue with one queue.

2015-06-04 Thread Martin Kletzander
Multi != One. And indeed, libvirt behaves the same way for queues='1' as without such setting. Let's make it clear in the XML. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/conf/domain_conf.c | 3 ++-

Re: [libvirt] [PATCH 3/4] qemu: Add capability for vhost-user multiqueue

2015-06-04 Thread Maxime Leroy
On Thu, Jun 4, 2015 at 3:43 PM, Martin Kletzander mklet...@redhat.com wrote: The support for this was added in QEMU with commit 830d70db692e374b5f4407f96a1ceefdcc97. Unfortunately we have to do another ugly version-based capability check. The other option would be not to check for the

Re: [libvirt] [PATCH 0/4] Add support for vhost-user with multi-queue

2015-06-04 Thread Maxime Leroy
Hi Martin, On Thu, Jun 4, 2015 at 3:43 PM, Martin Kletzander mklet...@redhat.com wrote: Also some tiny clean-up. Martin Kletzander (2): conf: Ignore multiqueue with one queue. qemu: Add capability for vhost-user multiqueue Maxime Leroy (2): docs: Clarify that attribute name is not

Re: [libvirt] [PATCH v5 8/9] qemu: Add quorum support in qemuBuildDriveDevStr

2015-06-04 Thread Matthias Gatto
On Tue, May 12, 2015 at 5:38 PM, Peter Krempa pkre...@redhat.com wrote: On Thu, Apr 23, 2015 at 14:41:20 +0200, Matthias Gatto wrote: Allow to libvirt to build the quorum string used by quemu. Add 2 static functions: qemuBuildQuorumStr and qemuBuildAndAppendDriveStrToVirBuffer.

[libvirt] [PATCH 04/10] Add endjob label to qemuDomainMemoryStats

2015-06-04 Thread Ján Tomko
Reduce the indentation level. --- src/qemu/qemu_driver.c | 35 +++ 1 file changed, 19 insertions(+), 16 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e031a17..818862b 100644 --- a/src/qemu/qemu_driver.c +++

Re: [libvirt] [PATCH 4/4] qemu: add multiqueue vhost-user support

2015-06-04 Thread Martin Kletzander
On Thu, Jun 04, 2015 at 03:43:54PM +0200, Martin Kletzander wrote: From: Maxime Leroy maxime.le...@6wind.com This patch adds the support of queues attribute of the driver element for vhost-user interface type. Example: interface type='vhostuser' mac address='52:54:00:ee:96:6d'/

[libvirt] [PATCH 06/10] Only call qemuMonitorGetMemoryStats for virtio memballoon

2015-06-04 Thread Ján Tomko
There is nothing to get from the monitor for model='none'. --- src/qemu/qemu_driver.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 50eebf9..4690406 100644 --- a/src/qemu/qemu_driver.c +++

Re: [libvirt] [PATCH] maint: document use of zanata for translations

2015-06-04 Thread Eric Blake
ping On 05/27/2015 08:43 AM, Eric Blake wrote: Based on recent list questions on how to contribute a translation fix. Signed-off-by: Eric Blake ebl...@redhat.com --- Should be safe for freeze, but as I have never contributed a translation fix, I'll wait for review. HACKING

Re: [libvirt] [PATCHv3] qemu: fix unsuitable error report when get memory stats

2015-06-04 Thread Ján Tomko
On Wed, Jun 03, 2015 at 09:07:49AM +0800, Wang Yufei wrote: From: Zhang Bo oscar.zhan...@huawei.com when we run the command 'virsh dommemstat xxx', althrough memballoon's model is set 'none' in vm's XML, it still reports an error in libvirtd.log. error :

[libvirt] [PATCH 09/10] Do not access the domain definition in qemuMonitorFindBalloonObjectPath

2015-06-04 Thread Ján Tomko
The monitor code does not hold the virDomainObjPtr lock and should not access the defitinion. --- src/qemu/qemu_monitor.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 9add05c..6947b08 100644 --- a/src/qemu/qemu_monitor.c

[libvirt] [PATCH 03/10] Remove path argument from qemuMonitorJSONFindLinkPath

2015-06-04 Thread Ján Tomko
All the callers use / anyway. --- src/qemu/qemu_monitor.c | 11 +-- src/qemu/qemu_monitor_json.c | 3 +-- src/qemu/qemu_monitor_json.h | 1 - 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 4a5e13c..9add05c

[libvirt] [PATCH 01/10] Move qemuMonitorFindObjectPath to qemu_monitor_json

2015-06-04 Thread Ján Tomko
This function is specific to the JSON monitor. --- src/qemu/qemu_monitor.c | 76 ++-- src/qemu/qemu_monitor_json.c | 72 + src/qemu/qemu_monitor_json.h | 4 +++ 3 files changed, 78 insertions(+), 74 deletions(-)

[libvirt] [PATCH] parallels: implement attach/detach network.

2015-06-04 Thread Mikhail Feoktistov
Support nova commands interface-attach and interface-detach. For containers only. --- src/parallels/parallels_driver.c | 16 src/parallels/parallels_sdk.c| 144 +- src/parallels/parallels_sdk.h|4 + 3 files changed, 161 insertions(+), 3

[libvirt] [PATCH 10/10] Turn qemuMonitorFindBalloonObjectPath into a void function

2015-06-04 Thread Ján Tomko
We were efectively ignoring its errors anyway. --- src/qemu/qemu_monitor.c | 29 ++--- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 6947b08..33600f0 100644 --- a/src/qemu/qemu_monitor.c +++

[libvirt] [PATCH 08/10] Only call SetMemoryStatsPeriod for virtio memballoon

2015-06-04 Thread Ján Tomko
--- src/qemu/qemu_process.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 7f154f0..64ee049 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -5517,7 +5517,9 @@ int qemuProcessAttach(virConnectPtr

[libvirt] [PATCH 05/10] Invert the condition in qemuDomainMemoryStats

2015-06-04 Thread Ján Tomko
It only makes sense if qemuMonitorGetMemoryStats is called, but the following patch will make that call conditional. --- src/qemu/qemu_driver.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[libvirt] [PATCH 02/10] Introduce qemuMonitorJSONFindLinkPath

2015-06-04 Thread Ján Tomko
When traversing through the QOM tree, we're looking for a link to a device, e.g.: linkvirtio-balloon-pci Introduce a helper that will format the link name at the start, instead of doing it every time while recursing through the tree. --- src/qemu/qemu_monitor.c | 4 ++--

[libvirt] [PATCH 00/10] qemu: balloon QOM-path related cleanups

2015-06-04 Thread Ján Tomko
While reviewing the patch adding virtio-balloon-ccw, I found that we are not reporting errors consistently. This turned out to be on purpose. This series * moves the object path search into qemu_monitor_json * reduces the number of allocations during search (more a cosmetic chagne than

[libvirt] [PATCH 07/10] Check for balloon model in qemuDomainSetMemoryStatsPeriod

2015-06-04 Thread Ján Tomko
There's no point in calling the monitor if there is no balloon. --- src/qemu/qemu_driver.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 4690406..bfd59a9 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c

Re: [libvirt] [PATCH] util: Fix coverity warings in virProcessGetAffinity

2015-06-04 Thread Peter Krempa
On Thu, Jun 04, 2015 at 08:34:00 -0400, John Ferlan wrote: On 06/04/2015 08:15 AM, Peter Krempa wrote: Refactor the code flow a bit more to clear coverity errors. Store the cpu count in an intermediate variable and reuse it rather than caluclating the index. ---

Re: [libvirt] [PATCH] util: Fix coverity warings in virProcessGetAffinity

2015-06-04 Thread John Ferlan
On 06/04/2015 11:13 AM, Peter Krempa wrote: On Thu, Jun 04, 2015 at 08:34:00 -0400, John Ferlan wrote: On 06/04/2015 08:15 AM, Peter Krempa wrote: Refactor the code flow a bit more to clear coverity errors. Store the cpu count in an intermediate variable and reuse it rather than

Re: [libvirt] [PATCH 1/4] storage: Remove extraneous @conn from function comments

2015-06-04 Thread Erik Skultety
On 06/03/2015 01:44 PM, John Ferlan wrote: Over time the parameters changed, but the comment wasn't updated Signed-off-by: John Ferlan jfer...@redhat.com --- src/storage/storage_backend_fs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/storage/storage_backend_fs.c

Re: [libvirt] [PATCH] parallels: add block device statistics to driver

2015-06-04 Thread Nikolay Shirokovskiy
On 03.06.2015 15:16, Dmitry Guryanov wrote: On 05/22/2015 10:42 AM, Nikolay Shirokovskiy wrote: Statistics provided through PCS SDK. As we have only async interface in SDK we need to be subscribed to statistics in order to get it. Trivial solution on every stat request to subscribe, wait

Re: [libvirt] [PATCH 35/35] qemu: Refactor qemuDomainSetVcpusFlags by reusing virDomainObjGetDefs

2015-06-04 Thread Peter Krempa
On Wed, Jun 03, 2015 at 16:12:40 +0200, Ján Tomko wrote: On Fri, May 29, 2015 at 03:33:56PM +0200, Peter Krempa wrote: --- src/qemu/qemu_driver.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) ACK to patches 31-35 I've fixed patches 16 and 17 according

Re: [libvirt] [PATCH 23/35] conf: Add new helpers to resolve virDomainModificationImpact to domain defs

2015-06-04 Thread John Ferlan
On 05/29/2015 09:33 AM, Peter Krempa wrote: virDomainLiveConfigHelperMethod that is used for this job now does modify the flags but still requires the callers to extract the correct definition objects. In addition coverity and other static analyzers are usually unhappy as they don't grasp

[libvirt] [libvirt-php PATCH] docs: remove reference to Red Hat

2015-06-04 Thread Ján Tomko
--- docs/index.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/index.html.in b/docs/index.html.in index da40d7a..bb03d65 100644 --- a/docs/index.html.in +++ b/docs/index.html.in @@ -4,7 +4,7 @@ h1Libvirt-php/h1 plibvirt-php, originally called

Re: [libvirt] [PATCH v5 7/9] domain_conf: Read and Write quorum config

2015-06-04 Thread Matthias Gatto
On Tue, May 12, 2015 at 5:04 PM, Peter Krempa pkre...@redhat.com wrote: On Thu, Apr 23, 2015 at 14:41:19 +0200, Matthias Gatto wrote: Add the capabiltty to libvirt to parse and format the quorum syntax as described here: http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html

Re: [libvirt] [PATCH] maint: remove redundant apostrophes from 'its'

2015-06-04 Thread Ján Tomko
On Wed, Jun 03, 2015 at 11:04:08AM -0600, Eric Blake wrote: On 06/03/2015 06:48 AM, Ján Tomko wrote: s/redundant/incorrect/ They would only be redundant if having them was correct but optional; but in all cases you touched, they were grammatically wrong: there is no optional ', it is

Re: [libvirt] [PATCH] docs: php: remove reference to Red Hat

2015-06-04 Thread Ján Tomko
On Wed, Jun 03, 2015 at 03:13:02PM +0200, Erik Skultety wrote: On 06/03/2015 02:48 PM, Ján Tomko wrote: Also remove the redudant apostrophe from it's. --- docs/php.html.in | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/php.html.in b/docs/php.html.in

Re: [libvirt] [PATCH] qemu: Check for qemu capability when calling virDomainGetBlockIoTune()

2015-06-04 Thread Martin Kletzander
ping On Thu, May 28, 2015 at 08:18:31PM +0200, Martin Kletzander wrote: When getting block device I/O tuning data there is no check for whether QEMU supports such options and the call fails on qemuMonitorGetBlockIoThrottle() when getting the particular throttle data. So try reporting a better

Re: [libvirt] [PATCH] maint: remove redundant apostrophes from 'its'

2015-06-04 Thread Ján Tomko
On Wed, Jun 03, 2015 at 03:46:17PM +0200, Andrea Bolognani wrote: On Wed, 2015-06-03 at 14:48 +0200, Ján Tomko wrote: --- docs/formatnode.html.in | 2 +- src/conf/storage_conf.c | 2 +- src/esx/esx_driver.c| 2 +- src/esx/esx_network_driver.c

Re: [libvirt] [PATCH] qemu: Check for qemu capability when calling virDomainGetBlockIoTune()

2015-06-04 Thread Ján Tomko
On Thu, May 28, 2015 at 08:18:31PM +0200, Martin Kletzander wrote: When getting block device I/O tuning data there is no check for whether QEMU supports such options and the call fails on qemuMonitorGetBlockIoThrottle() when getting the particular throttle data. So try reporting a better

Re: [libvirt] [PATCH] parallels: simplify event types discrimination

2015-06-04 Thread Nikolay Shirokovskiy
On 04.06.2015 12:56, Maxim Nestratov wrote: 04.06.2015 12:50, Nikolay Shirokovskiy пишет: Use issue type instead of event type to group vm related events. This saves us from explicit enumeration of all vm even types in prlsdkHandleVmEvent. s/issue/issuer --- ok -- libvir-list mailing

[libvirt] [PATCH] parallels: simplify event types discrimination

2015-06-04 Thread Nikolay Shirokovskiy
Use issue type instead of event type to group vm related events. This saves us from explicit enumeration of all vm even types in prlsdkHandleVmEvent. --- src/parallels/parallels_sdk.c | 15 +-- 1 files changed, 5 insertions(+), 10 deletions(-) diff --git

Re: [libvirt] [PATCH] parallels: simplify event types discrimination

2015-06-04 Thread Maxim Nestratov
04.06.2015 12:50, Nikolay Shirokovskiy пишет: Use issue type instead of event type to group vm related events. This saves us from explicit enumeration of all vm even types in prlsdkHandleVmEvent. s/issue/issuer --- src/parallels/parallels_sdk.c | 15 +-- 1 files changed, 5

Re: [libvirt] [PATCH 23/35] conf: Add new helpers to resolve virDomainModificationImpact to domain defs

2015-06-04 Thread Peter Krempa
On Thu, Jun 04, 2015 at 07:02:00 -0400, John Ferlan wrote: On 05/29/2015 09:33 AM, Peter Krempa wrote: virDomainLiveConfigHelperMethod that is used for this job now does modify the flags but still requires the callers to extract the correct definition objects. In addition coverity

[libvirt] [PATCH v2] parallels: add block device statistics to driver

2015-06-04 Thread Nikolay Shirokovskiy
Statistics provided through PCS SDK. As we have only async interface in SDK we need to be subscribed to statistics in order to get it. Trivial solution on every stat request to subscribe, wait event and then unsubscribe will lead to significant delays in case of a number of successive requests, as

[libvirt] [PATCH v2] parallels: simplify event types discrimination

2015-06-04 Thread Nikolay Shirokovskiy
Use issuer type instead of event type to group vm related events. This saves us from explicit enumeration of all vm event types in prlsdkHandleVmEvent. --- src/parallels/parallels_sdk.c | 15 +-- 1 files changed, 5 insertions(+), 10 deletions(-) diff --git

Re: [libvirt] [RFC] libvirt support multi-thread compression for live migration

2015-06-04 Thread Jiri Denemark
On Wed, Jun 03, 2015 at 15:13:17 +, Feng, Shaohe wrote: Eric, Thank you for reply. Is it necessary to expose these two APIs to user application? + virdomainMigrateSetCapabilities + virdomainMigrateGetCapabilities For qemu , the migration capabilities are xbzrle, rdma-pin-all,

[libvirt] [PATCHv2 0/2] Fix code after the vcpupin series

2015-06-04 Thread Peter Krempa
Both patches are pushed as trivial. Peter Krempa (2): conf: Fix mistakes in pointer usage in virDomainObjGetDefs qemu: Update balloon info only if job is allowed src/conf/domain_conf.c | 4 ++-- src/qemu/qemu_domain.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) -- 2.4.1 --

Re: [libvirt] [PATCH v2] parallels: add block device statistics to driver

2015-06-04 Thread Nikolay Shirokovskiy
On 04.06.2015 14:45, Nikolay Shirokovskiy wrote: Statistics provided through PCS SDK. As we have only async interface in SDK we need to be subscribed to statistics in order to get it. Trivial solution on every stat request to subscribe, wait event and then unsubscribe will lead to

Re: [libvirt] [RFC] libvirt support multi-thread compression for live migration

2015-06-04 Thread Jiri Denemark
On Tue, Jun 02, 2015 at 11:02:27 -0600, Eric Blake wrote: On 06/02/2015 07:56 AM, Qiao, Liyong wrote: Hi Eric Thanks for replying the mail, replied in lines. +virdomainMigrateGetParameters(virDomainPtr domain, + int *level, +

[libvirt] [PATCH v3] parallels: add block device statistics to driver

2015-06-04 Thread Nikolay Shirokovskiy
Statistics provided through PCS SDK. As we have only async interface in SDK we need to be subscribed to statistics in order to get it. Trivial solution on every stat request to subscribe, wait event and then unsubscribe will lead to significant delays in case of a number of successive requests, as

[libvirt] [PATCH] util: Fix coverity warings in virProcessGetAffinity

2015-06-04 Thread Peter Krempa
Refactor the code flow a bit more to clear coverity errors. Store the cpu count in an intermediate variable and reuse it rather than caluclating the index. --- src/util/virprocess.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/util/virprocess.c

Re: [libvirt] [PATCH] util: Fix coverity warings in virProcessGetAffinity

2015-06-04 Thread John Ferlan
On 06/04/2015 08:15 AM, Peter Krempa wrote: Refactor the code flow a bit more to clear coverity errors. Store the cpu count in an intermediate variable and reuse it rather than caluclating the index. --- src/util/virprocess.c | 11 +++ 1 file changed, 7 insertions(+), 4

Re: [libvirt] [PATCH 16/35] qemu: Add helper to update domain balloon size and refactor usage places

2015-06-04 Thread John Ferlan
On 06/03/2015 09:16 AM, Ján Tomko wrote: On Fri, May 29, 2015 at 03:33:37PM +0200, Peter Krempa wrote: When qemu does not support the balloon event the current memory size needs to be queried. Since there are two places that implement the same logic, split it out into a function and reuse.

Re: [libvirt] [libvirt-php PATCH] docs: remove reference to Red Hat

2015-06-04 Thread Erik Skultety
ACK Erik On 06/04/2015 09:59 AM, Ján Tomko wrote: --- docs/index.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/index.html.in b/docs/index.html.in index da40d7a..bb03d65 100644 --- a/docs/index.html.in +++ b/docs/index.html.in @@ -4,7 +4,7 @@

Re: [libvirt] [PATCH 16/35] qemu: Add helper to update domain balloon size and refactor usage places

2015-06-04 Thread Peter Krempa
On Thu, Jun 04, 2015 at 07:10:58 -0400, John Ferlan wrote: On 06/03/2015 09:16 AM, Ján Tomko wrote: On Fri, May 29, 2015 at 03:33:37PM +0200, Peter Krempa wrote: When qemu does not support the balloon event the current memory size needs to be queried. Since there are two places that

Re: [libvirt] [PATCH] conf: Fix invalid pointer check in virDomainObjGetDefs

2015-06-04 Thread Peter Krempa
On Thu, Jun 04, 2015 at 07:44:20 -0400, John Ferlan wrote: On 06/04/2015 07:28 AM, Peter Krempa wrote: Coverity rightfully determined that in commit 3d021381c71221e563182f03 I made a mistake in the first check if @persDef is not NULL is dereferencing it rather than checking. ---

[libvirt] [PATCH 1/2] conf: Fix mistakes in pointer usage in virDomainObjGetDefs

2015-06-04 Thread Peter Krempa
Coverity rightfully determined that in commit 3d021381c71221e563182f03 I made a mistake in the first check if @persDef is not NULL is dereferencing it rather than checking. Additionally if the vm is online the code would set @liveDef twice rather than modifying @persDef. Fix both mistakes. ---

[libvirt] [PATCH] conf: Fix invalid pointer check in virDomainObjGetDefs

2015-06-04 Thread Peter Krempa
Coverity rightfully determined that in commit 3d021381c71221e563182f03 I made a mistake in the first check if @persDef is not NULL is dereferencing it rather than checking. --- Pushed as trivial. src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH] conf: Fix invalid pointer check in virDomainObjGetDefs

2015-06-04 Thread John Ferlan
On 06/04/2015 07:28 AM, Peter Krempa wrote: Coverity rightfully determined that in commit 3d021381c71221e563182f03 I made a mistake in the first check if @persDef is not NULL is dereferencing it rather than checking. --- Pushed as trivial. src/conf/domain_conf.c | 2 +- 1 file

Re: [libvirt] [PATCH] conf: Fix invalid pointer check in virDomainObjGetDefs

2015-06-04 Thread Peter Krempa
On Thu, Jun 04, 2015 at 07:44:20 -0400, John Ferlan wrote: On 06/04/2015 07:28 AM, Peter Krempa wrote: Coverity rightfully determined that in commit 3d021381c71221e563182f03 I made a mistake in the first check if @persDef is not NULL is dereferencing it rather than checking. ---

[libvirt] [PATCH 2/2] qemu: Update balloon info only if job is allowed

2015-06-04 Thread Peter Krempa
In qemuDomainUpdateCurrentMemorySize I misplaced the actual update of the balloon size to a place where it may not be initialized. Move it a few lines above. --- src/qemu/qemu_domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.c

Re: [libvirt] [PATCHv2 0/2] Fix code after the vcpupin series

2015-06-04 Thread John Ferlan
On 06/04/2015 08:06 AM, Peter Krempa wrote: Both patches are pushed as trivial. Peter Krempa (2): conf: Fix mistakes in pointer usage in virDomainObjGetDefs qemu: Update balloon info only if job is allowed src/conf/domain_conf.c | 4 ++-- src/qemu/qemu_domain.c | 4 ++-- 2 files

[libvirt] [PATCH 1/4] conf: Ignore multiqueue with one queue.

2015-06-04 Thread Martin Kletzander
Multi != One. And indeed, libvirt behaves the same way for queues='1' as without such setting. Let's make it clear in the XML. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/conf/domain_conf.c | 3 ++-

[libvirt] [PATCH 0/4] Add support for vhost-user with multi-queue

2015-06-04 Thread Martin Kletzander
Also some tiny clean-up. Martin Kletzander (2): conf: Ignore multiqueue with one queue. qemu: Add capability for vhost-user multiqueue Maxime Leroy (2): docs: Clarify that attribute name is not used for vhostuser qemu: add multiqueue vhost-user support docs/formatdomain.html.in

[libvirt] [PATCH 3/4] qemu: Add capability for vhost-user multiqueue

2015-06-04 Thread Martin Kletzander
The support for this was added in QEMU with commit 830d70db692e374b5f4407f96a1ceefdcc97. Unfortunately we have to do another ugly version-based capability check. The other option would be not to check for the capability at all and leave that to qemu as it's doen with multiqueue tap devices.

[libvirt] [PATCH 4/4] qemu: add multiqueue vhost-user support

2015-06-04 Thread Martin Kletzander
From: Maxime Leroy maxime.le...@6wind.com This patch adds the support of queues attribute of the driver element for vhost-user interface type. Example: interface type='vhostuser' mac address='52:54:00:ee:96:6d'/ source type='unix' path='/tmp/vhost2.sock' mode='client'/ model

[libvirt] [PATCH 2/4] docs: Clarify that attribute name is not used for vhostuser

2015-06-04 Thread Martin Kletzander
From: Maxime Leroy maxime.le...@6wind.com Signed-off-by: Maxime Leroy maxime.le...@6wind.com Signed-off-by: Martin Kletzander mklet...@redhat.com --- docs/formatdomain.html.in | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index