On 7/14/2015 at 05:42 AM, in message
CALFpzo551ioR=w5asf7jxmtp8egqsp2au_o6awmyofz9mfg...@mail.gmail.com, Marcus
shadow...@gmail.com wrote:
Oh, I almost forgot to mention the versions:
libvirt 1.2.8-16.0.1.el7_1.2.x86_64
qemu 2.1.2-23.el7_1.1.x86_64
Just FYI, tested on my machine,
I tracked it down. Found it was introduced in 1.7.0 and patched recently in
qemu-kvm. Your version might have the fix backported, qemu-kvm-ev 2.1.2
from redhat/centos/fedora doesn't.
Libvirt sends a 'delvm snapshotid' to the qemu monitor via HMP, and Qemu,
instead of looping over all disks,
well, not *that* recently, I guess...
On Wed, Jul 15, 2015 at 10:51 PM, Marcus shadow...@gmail.com wrote:
I tracked it down. Found it was introduced in 1.7.0 and patched recently
in qemu-kvm. Your version might have the fix backported, qemu-kvm-ev 2.1.2
from redhat/centos/fedora doesn't.
On Tue, Jul 14, 2015 at 16:37:01 +0200, Michal Privoznik wrote:
There's this condition:
flags VIR_DOMAIN_AFFECT_CURRENT virDomainIsActive(dom)
which can never be true since VIR_DOMAIN_AFFECT_CURRENT has hardcoded
value of zero. Therefore virDomainIsActive() is a dead code. However,
the
Knock-knock!!!
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
-Original Message-
From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com]
On Behalf Of Pavel
Fedin
Sent: Thursday, July 09, 2015 12:11 PM
To:
On Wed, Jul 15, 2015 at 09:08:45 +0200, Peter Krempa wrote:
On Tue, Jul 14, 2015 at 16:37:01 +0200, Michal Privoznik wrote:
There's this condition:
flags VIR_DOMAIN_AFFECT_CURRENT virDomainIsActive(dom)
which can never be true since VIR_DOMAIN_AFFECT_CURRENT has hardcoded
value of
The virDomainObjListRemove() function unlocks a domain that it's given
due to legacy code. And because of that code, which should be
refactored, that last virObjectUnlock() cannot be just removed. So
instead, lock it right back for qemu for now. All calls to
qemuDomainRemoveInactive() are
On 07/15/2015 08:17 AM, Martin Kletzander wrote:
On Tue, Jul 14, 2015 at 09:03:59AM -0400, John Ferlan wrote:
On 07/10/2015 05:07 AM, Martin Kletzander wrote:
Commit ed8155eafbff5c5ca0bdfe84a8388f58b718c2f9 documented that
mhz field in virNodeInfo might be 0 if the frequency is unknown.
On Tue, Jul 14, 2015 at 09:03:59AM -0400, John Ferlan wrote:
On 07/10/2015 05:07 AM, Martin Kletzander wrote:
Commit ed8155eafbff5c5ca0bdfe84a8388f58b718c2f9 documented that
mhz field in virNodeInfo might be 0 if the frequency is unknown. Modify
virsh to know about that.
While 0 may be
On Tue, Jul 07, 2015 at 05:30:40PM +0200, Boris Fiuczynski wrote:
Adding support and a test for virtio-9p-ccw.
Changing the default from virtio-9p-pci to virtio-9p-ccw for
s390-ccw-virtio machines.
Boris Fiuczynski (3):
qemu: Support for virtio-9p-ccw
qemu: Make virtio-9p-ccw the
Please wait the next version of the patchset. I was not very comfortable with
this
patch as it is a kind of hack. Eventually vz migration is direct migration in
terms of libvirt and forcing it to follow 5-staged way of managed migration for
getting an authZ token from destination is not good.
s/priviledged/privileged/
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
Pushed under trivial and who-cares rules.
daemon/libvirtd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 654e7f4..71db4a0 100644
---
On 07/15/2015 11:06 AM, Ján Tomko wrote:
On Mon, Jun 22, 2015 at 05:05:03PM -0400, John Ferlan wrote:
If a SCSI subsystem hostdev element is provided with an address,
then enforce that the address type is 'drive'. If not provided,
a 'drive' element was created by
https://bugzilla.redhat.com/show_bug.cgi?id=1124841
When the daemon is running under unprivileged user, that is under
qemu:///session, there are plenty of operations we can't do. What
we can do is to go with best effort. One of such cases is
relabeling domain resources (be it disks, sockets,
On Mon, Jun 22, 2015 at 05:05:03PM -0400, John Ferlan wrote:
If a SCSI subsystem hostdev element is provided with an address,
then enforce that the address type is 'drive'. If not provided,
a 'drive' element was created by virDomainHostdevAssignAddress
which uses
This series refactors the block job command code so that it is handled by
separate functions rather than one mega-method. Additionally this series then
fixes the routine for waiting for a block job.
As it's perhaps obvious from the patches the API design for the block job APIs
is rather
cmdBlockJob will be converted to a hub that will call into the
individual executor functions.
---
tools/virsh-domain.c | 91 +++-
1 file changed, 55 insertions(+), 36 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index
Use the VSH_EXCLUSIVE_OPTIONS to exclude combinations of --pivot and
--keep-overlay and refactor the enforcing of the --wait option and other
flags that imply --wait.
---
tools/virsh-domain.c | 35 ---
1 file changed, 24 insertions(+), 11 deletions(-)
diff --git
Similarly to the refactor of cmdBlockCommit in a previous commit this
does the same change for cmdBlockCopy.
---
tools/virsh-domain.c | 119 ++-
1 file changed, 31 insertions(+), 88 deletions(-)
diff --git a/tools/virsh-domain.c
Put all argument parsing together and refactor the argument checking
code.
---
tools/virsh-domain.c | 77 ++--
1 file changed, 44 insertions(+), 33 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 43eff4f..8716a09 100644
---
tools/virsh-domain.c | 50 --
1 file changed, 28 insertions(+), 22 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 98b6870..4f58caa 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -1665,7 +1665,6 @@
Final cleanup to get rid of the hub function.
---
tools/virsh-domain.c | 94 +++-
1 file changed, 35 insertions(+), 59 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 4f58caa..8b354bb 100644
--- a/tools/virsh-domain.c
Reuse the vshBlockJobWait infrastructure to refactor cmdBlockCommit to
use the common code. This additionally fixes a bug when working with
new qemus, where when doing an active commit with --pivot the pivoting
would fail, since qemu reaches 100% completion but the job doesn't
switch to
Use the VSH_EXCLUSIVE_OPTIONS_VAR to interlock incompatible options
---
tools/virsh-domain.c | 33 +++--
1 file changed, 19 insertions(+), 14 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 7a18204..24f53ea 100644
--- a/tools/virsh-domain.c
Few parts of the code looked at the current progress of and assumed that
a two phase blockjob is in the _READY state as soon as the progress
reached 100% (info.cur == info.end). In current versions of qemu this
assumption is invalid and qemu exposes a new flag 'ready' in the
query-block-jobs
---
tools/virsh-domain.c | 33 -
1 file changed, 24 insertions(+), 9 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 24f53ea..e3f7220 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -1666,7 +1666,6 @@
---
tools/virsh-domain.c | 34 ++
1 file changed, 22 insertions(+), 12 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index e3f7220..98b6870 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -1665,7 +1665,6 @@
Put all argument parsing together and refactor the argument checking
code.
---
tools/virsh-domain.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 8716a09..ed7782e 100644
--- a/tools/virsh-domain.c
+++
Introduce helper function that will provide logic for waiting for block
job completion so the 3 open coded places can be unified and improved.
This patch introduces the whole logic and uses it to fix
cmdBlockJobPull. The vshBlockJobWait funtion provides common logic for
block job waiting that
29 matches
Mail list logo
