Re: [libvirt] [PATCH 3/6] storage: fs: Don't attempt directory creation if it already exists

2015-07-16 Thread tzheng
On 07/16/2015 07:39 PM, Christophe Fergeau wrote: On Thu, Jul 16, 2015 at 02:02:39PM +0800, tzheng wrote: Hi,Cole After this patch is included in libvirt on rhel7.2,virt-manager can not create dir pool with existing directory. There is no default pool created in a fresh rhel7.2 system,so if I

[libvirt] [PATCH 3/3] libxl: acquire a job when receiving a migrating domain

2015-07-16 Thread Jim Fehlig
Commit f86ae403 moved acquiring a job from libxlDomainStart() to its callers. One spot missed was in libxlDoMigrateReceive(). Acquire a job in libxlDoMigrateReceive() before calling libxlDomainStart(). Signed-off-by: Jim Fehlig --- src/libxl/libxl_migration.c | 20 +--- 1 file ch

[libvirt] [PATCH 1/3] libxl: fix ref counting of libxlMigrationDstArgs

2015-07-16 Thread Jim Fehlig
This patch fixes some flawed logic around ref counting the libxlMigrationDstArgs object. First, when adding sockets to the event loop with virNetSocketAddIOCallback(), the generic virObjectFreeCallback() was registered as a free function, with libxlMigrationDstArgs as its parameter. A reference wa

[libvirt] [PATCH 2/3] libxl: don't attempt to resume domain when suspend fails

2015-07-16 Thread Jim Fehlig
Failure of libxl_domain_suspend() does not leave the domain in a suspended state, so no need to call libxl_domain_resume(), which btw will fail with "domain not suspended". Signed-off-by: Jim Fehlig --- AFAICT, the xl migration code does not call libxl_domain_resume() when libxl_domain_suspend()

[libvirt] [PATCH 0/3] libxl: a few small migration fixes

2015-07-16 Thread Jim Fehlig
This series fixes a few issues found while testing migration with latest Xen and libvirt. See the individual patches for details. Jim Fehlig (3): libxl: fix ref counting of libxlMigrationDstArgs libxl: don't attempt to resume domain when suspend fails libxl: acquire a job when receiving a m

Re: [libvirt] [PATCH] docs: Document how libvirt handles companion controllers

2015-07-16 Thread Eric Blake
On 07/16/2015 05:46 AM, Martin Kletzander wrote: > The information on companion controllers we give in our documentation is > rather sparse. For example, it looks like any controller can be used as > a companion one. Also, when using ich9-uhci2, for example, we are able > to set some sensible def

Re: [libvirt] [PATCH] rbd: Use RBD format 2 by default when creating images.

2015-07-16 Thread John Ferlan
> > Seems like a sane approach to me. Less if-statements and the code > still works just fine. > > You can apply my patch and fix this afterwards? Or do you want a new > patch from me? > > Wido > I'll take care of it as a followup patch which I'll push shortly... John -- libvir-list mailing

Re: [libvirt] [PATCH] rbd: Use RBD format 2 by default when creating images.

2015-07-16 Thread Wido den Hollander
On 16-07-15 18:28, John Ferlan wrote: > > > On 07/14/2015 04:13 PM, Josh Durgin wrote: >> On 07/14/2015 12:42 PM, John Ferlan wrote: >>> >>> >>> On 07/14/2015 04:15 AM, Wido den Hollander wrote: We used to look at the librbd code version and depending on that we would invoke rbd_cre

Re: [libvirt] [PATCH] rbd: Use RBD format 2 by default when creating images.

2015-07-16 Thread John Ferlan
On 07/14/2015 04:13 PM, Josh Durgin wrote: > On 07/14/2015 12:42 PM, John Ferlan wrote: >> >> >> On 07/14/2015 04:15 AM, Wido den Hollander wrote: >>> We used to look at the librbd code version and depending on that >>> we would invoke rbd_create3() or rbd_create(). >>> >>> Since librbd version 0

Re: [libvirt] [PATCH 5/5] conf: Check for hostdev conflicts when assign default disk address

2015-07-16 Thread John Ferlan
On 07/16/2015 08:23 AM, Ján Tomko wrote: > On Mon, Jun 22, 2015 at 05:05:07PM -0400, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1210587 (completed) >> >> When generating the default drive address for a SCSI device, >> check the generated address to ensure it doesn't confl

Re: [libvirt] [PATCH 4/5] conf: Refactor virDomainDiskDefParseXML to pass vmdef

2015-07-16 Thread John Ferlan
On 07/16/2015 08:03 AM, Ján Tomko wrote: > On Mon, Jun 22, 2015 at 05:05:06PM -0400, John Ferlan wrote: >> Rather than passing the def->seclabels and def->nseclabels, refactor >> the API to pass the entire domain definition. This will be used in a >> future patch as well. > > I think it would b

Re: [libvirt] [PATCH 2/5] conf: Add 'bus' and 'target' to SCSI address conflict checks

2015-07-16 Thread John Ferlan
On 07/16/2015 08:31 AM, Ján Tomko wrote: > On Mon, Jun 22, 2015 at 05:05:04PM -0400, John Ferlan wrote: >> Modify virDomainDriveAddressIsUsedBy{Disk|Hostdev} and >> virDomainSCSIDriveAddressIsUsed to take 'bus' and 'target' >> parameters. Will be used by future patches for more complete >> addre

[libvirt] [PATCH] cgroup: Drop resource partition from virSystemdMakeScopeName

2015-07-16 Thread Peter Krempa
The scope name, even according to our docs is "machine-$DRIVER\x2d$VMNAME.scope" virSystemdMakeScopeName would use the resource partition name instead of "machine-" if it was specified thus creating invalid scope paths. This makes libvirt drop cgroups for a VM that uses custom resource partition u

Re: [libvirt] [libvirt-python][PATCH v2] examples: Introduce nodestats example

2015-07-16 Thread Martin Kletzander
On Thu, Jul 16, 2015 at 02:38:09PM +0200, Michal Privoznik wrote: So, this is an exercise to show libvirt capabilities. Firstly, for each host NUMA nodes some statistics are printed out, i.e. total memory and free memory. Then, for each running domain, that has memory strictly bound to certain ho

[libvirt] [PATCH 0.5/5] conf: Remove extraneous check in virDomainHostdevAssignAddress

2015-07-16 Thread John Ferlan
Since the only way virDomainHostdevAssignAddress can be called is from within virDomainHostdevDefParseXML when hostdev->source.subsys.type is VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI, thus there's no need for redundancy. Signed-off-by: John Ferlan --- src/conf/domain_conf.c | 3 --- 1 file changed, 3

[libvirt] [libvirt-python][PATCH v2] examples: Introduce nodestats example

2015-07-16 Thread Michal Privoznik
So, this is an exercise to show libvirt capabilities. Firstly, for each host NUMA nodes some statistics are printed out, i.e. total memory and free memory. Then, for each running domain, that has memory strictly bound to certain host nodes, a small statistics of how much memory it takes is printed

Re: [libvirt] [PATCH 2/5] conf: Add 'bus' and 'target' to SCSI address conflict checks

2015-07-16 Thread Ján Tomko
On Mon, Jun 22, 2015 at 05:05:04PM -0400, John Ferlan wrote: > Modify virDomainDriveAddressIsUsedBy{Disk|Hostdev} and > virDomainSCSIDriveAddressIsUsed to take 'bus' and 'target' > parameters. Will be used by future patches for more complete > address conflict checks > Are all of the address com

Re: [libvirt] [PATCH 5/5] conf: Check for hostdev conflicts when assign default disk address

2015-07-16 Thread Ján Tomko
On Mon, Jun 22, 2015 at 05:05:07PM -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1210587 (completed) > > When generating the default drive address for a SCSI device, > check the generated address to ensure it doesn't conflict with a SCSI > address. The address generat

Re: [libvirt] [PATCH 4/5] conf: Refactor virDomainDiskDefParseXML to pass vmdef

2015-07-16 Thread Ján Tomko
On Mon, Jun 22, 2015 at 05:05:06PM -0400, John Ferlan wrote: > Rather than passing the def->seclabels and def->nseclabels, refactor > the API to pass the entire domain definition. This will be used in a > future patch as well. I think it would be nicer to separate XML parsing (which would just re

Re: [libvirt] [PATCH 1/5] conf: Enforce SCSI hostdev address type

2015-07-16 Thread Ján Tomko
On Wed, Jul 15, 2015 at 04:05:06PM -0400, John Ferlan wrote: > > > On 07/15/2015 11:06 AM, Ján Tomko wrote: > > On Mon, Jun 22, 2015 at 05:05:03PM -0400, John Ferlan wrote: > >> If a SCSI subsystem element is provided with an , > >> then enforce that the address type is 'drive'. If not provided

[libvirt] [PATCH] docs: Document how libvirt handles companion controllers

2015-07-16 Thread Martin Kletzander
The information on companion controllers we give in our documentation is rather sparse. For example, it looks like any controller can be used as a companion one. Also, when using ich9-uhci2, for example, we are able to set some sensible defaults, but it might get confusing for the user as we don'

Re: [libvirt] [PATCH 3/6] storage: fs: Don't attempt directory creation if it already exists

2015-07-16 Thread Christophe Fergeau
On Thu, Jul 16, 2015 at 02:02:39PM +0800, tzheng wrote: > Hi,Cole > > After this patch is included in libvirt on rhel7.2,virt-manager can not > create dir pool with existing directory. > There is no default pool created in a fresh rhel7.2 system,so if I try to > create default pool,the below error

Re: [libvirt] [PATCH v2] virsh: Don't output node frequency if unknown

2015-07-16 Thread John Ferlan
On 07/16/2015 05:57 AM, Martin Kletzander wrote: > Commit ed8155eafbff5c5ca0bdfe84a8388f58b718c2f9 documented that mhz > field in virNodeInfo might be 0 if the frequency is unknown. Modify > virsh to know about that. > > Signed-off-by: Martin Kletzander > --- > v2: > - added info into manual

Re: [libvirt] [PATCH v2 0/3] driver level connection close event

2015-07-16 Thread Nikolay Shirokovskiy
Guys, please take a look. On 25.06.2015 14:31, nshirokovs...@virtuozzo.com wrote: > Notify of connection close event from parallels driver (possibly) wrapped in > the remote driver. > > Changes from v1: > 1. fix comment style issues > 2. remove spurious whitespaces > 3. move rpc related part from

[libvirt] [PATCH v2] virsh: Don't output node frequency if unknown

2015-07-16 Thread Martin Kletzander
Commit ed8155eafbff5c5ca0bdfe84a8388f58b718c2f9 documented that mhz field in virNodeInfo might be 0 if the frequency is unknown. Modify virsh to know about that. Signed-off-by: Martin Kletzander --- v2: - added info into manual and reworded that a bit tools/virsh-host.c | 3 ++- tools/virsh.p

Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

2015-07-16 Thread Christophe Fergeau
On Mon, Jul 13, 2015 at 02:45:21PM +0100, Zeeshan Ali (Khattak) wrote: > On Fri, Jul 10, 2015 at 5:04 PM, Christophe Fergeau > wrote: > > Patches of yours broke the build, you have a strong opinion on the right way > > to fix it, in such situations I usually go the extra mile to > > convince othe