Re: [libvirt] Libvirt Application Development Guide

2015-07-28 Thread Kevin Walker
Hi All I am currently getting up to speed with the libvirt api, but have noticed there are some big gaps in the Application Development Guide available on the libvirt website. Is there a more recent version of this document available? Kind regards Kevin Walker +968 97651742 -- libvir-l

[libvirt] ambiguous ret of qemuDomainDetachVirtioDiskDevice

2015-07-28 Thread zhang bo
static int qemuDomainDetachVirtioDiskDevice(virQEMUDriverPtr driver, virDomainObjPtr vm, virDomainDiskDefPtr detach) { ... rc = qemuDomainWaitForDeviceRemoval(vm); if (rc == 0 || rc == 1) ret = qemuDomainRemoveDi

Re: [libvirt] ambiguous ret of qemuDomainDetachVirtioDiskDevice

2015-07-28 Thread Ján Tomko
On Tue, Jul 28, 2015 at 04:25:13PM +0800, zhang bo wrote: > static int > qemuDomainDetachVirtioDiskDevice(virQEMUDriverPtr driver, > virDomainObjPtr vm, > virDomainDiskDefPtr detach) > { > ... > > rc = qemuDomainWaitForDevic

Re: [libvirt] [PATCH 0/4] manage the shmem device source

2015-07-28 Thread Marc-André Lureau
On Mon, Jul 27, 2015 at 6:05 PM, Daniel P. Berrange wrote: >> > Is it enough if ivshmem-server is started by libvirt to solve the selinux >> > issue? >> > >> > What's missing to get started to support it with libvirt? >> >> The complexity arises when multiple QEMUs want to connect to the same >>

Re: [libvirt] [PATCH 1/2] Caps: Disable floppy disk for PowerPC VM

2015-07-28 Thread Ján Tomko
On Fri, Jul 24, 2015 at 03:30:14PM -0400, Kothapally Madhu Pavan wrote: > PowerPC pseries based VMs do not support a floppy disk controller. > This prohibits libvirt from adding floppy disk for a PowerPC pseries VM. > > Signed-off-by: Kothapally Madhu Pavan > --- > src/conf/domain_conf.c |

Re: [libvirt] [PATCH 2/2] Avoid starting a PowerPC VM with floppy disk

2015-07-28 Thread Ján Tomko
On Fri, Jul 24, 2015 at 03:30:49PM -0400, Kothapally Madhu Pavan wrote: > PowerPC pseries based VMs do not support a floppy disk controller. > This prohibits libvirt from creating qemu command with floppy device. > > Signed-off-by: Kothapally Madhu Pavan > --- > src/qemu/qemu_command.c | 47 >

Re: [libvirt] [sandbox PATCH 02/11] Fix virt-sandbox-image

2015-07-28 Thread Cedric Bosdonnat
Hi Eren, As a fix of the PoC, this commit could introduce the man page for the new command. Regards, -- Cedric On Thu, 2015-07-23 at 15:57 +, Eren Yagdiran wrote: > Authentication fix for Docker REST API. > --- > virt-sandbox-image/virt-sandbox-image.py | 10 ++ > 1 file changed, 6

Re: [libvirt] [PATCHv2] conf: more useful error message when pci function is out of range

2015-07-28 Thread Ján Tomko
On Thu, Jul 23, 2015 at 04:37:05PM -0400, Laine Stump wrote: > If a pci address had a function number out of range, the error message > would be: > > Insufficient specification for PCI address > > which is logged by virDevicePCIAddressParseXML() after > virDevicePCIAddressIsValid returns a fail

[libvirt] [PATCH] virsh: Remove when changing cdrom media source

2015-07-28 Thread Peter Krempa
Since the code is changing the source image path by modifying the existing XML snippet the element does not get dropped. The element is ignored though but it might start being used in the future. Before this patch, you'd get: $ virsh change-media --eject --print-xml 10 hdc

[libvirt] [PATCH] qemu: Adjust VM id allocation

2015-07-28 Thread Erik Skultety
Our atomic increment (virAtomicIntInc) uses (if available) gcc __sync_add_and_fetch builtin. In qemu driver though, we'd profit more from __sync_fetch_and_add builtin. To keep it simplistic, this patch adjusts qemu driver initialization rather than adding a new atomic increment macro. --- src/qemu

Re: [libvirt] [PATCH] qemu: Adjust VM id allocation

2015-07-28 Thread Daniel P. Berrange
On Tue, Jul 28, 2015 at 05:41:25PM +0200, Erik Skultety wrote: > Our atomic increment (virAtomicIntInc) uses (if available) gcc > __sync_add_and_fetch builtin. In qemu driver though, we'd profit more > from __sync_fetch_and_add builtin. To keep it simplistic, this patch > adjusts qemu driver initia

Re: [libvirt] [PATCH v7] autocreate tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

2015-07-28 Thread Michal Privoznik
On 26.07.2015 21:26, Vasiliy Tolstov wrote: > 2015-07-24 12:33 GMT+03:00 Vasiliy Tolstov : >> 2015-07-24 12:10 GMT+03:00 Vasiliy Tolstov : >>> If a user specify ehernet device create it via libvirt and run >>> script if it provided. After this commit user does not need to >>> run external script to

[libvirt] [PATCH] lxc: Don't accidentaly reset autostart flag in virLXCProcessCleanup

2015-07-28 Thread Peter Krempa
virDomainDeleteConfig is meant to delete the persistent config and thus it resets vm->autostart. Copy parts of qemuProcessRemoveDomainStatus to a new helper to avoid using the incorrect function. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1230071 --- src/lxc/lxc_process.c | 19

Re: [libvirt] [PATCH] lxc: Don't accidentaly reset autostart flag in virLXCProcessCleanup

2015-07-28 Thread Daniel P. Berrange
On Tue, Jul 28, 2015 at 06:28:58PM +0200, Peter Krempa wrote: > virDomainDeleteConfig is meant to delete the persistent config and thus > it resets vm->autostart. Copy parts of qemuProcessRemoveDomainStatus to > a new helper to avoid using the incorrect function. > > Resolves: https://bugzilla.red

Re: [libvirt] [PATCH] conf: Split virDomainObjList into a separate file

2015-07-28 Thread John Ferlan
On 07/17/2015 05:27 AM, Michal Privoznik wrote: > Our domain_conf.* files are big enough. Not only they contain XML > parsing code, but they served as a storage of all functions whose > name is virDomain prefixed. This is just wrong as it gathers not > related functions (and modules) into one big

Re: [libvirt] [PATCH] lxc: Don't accidentaly reset autostart flag in virLXCProcessCleanup

2015-07-28 Thread Peter Krempa
On Tue, Jul 28, 2015 at 17:44:43 +0100, Daniel Berrange wrote: > On Tue, Jul 28, 2015 at 06:28:58PM +0200, Peter Krempa wrote: > > virDomainDeleteConfig is meant to delete the persistent config and thus > > it resets vm->autostart. Copy parts of qemuProcessRemoveDomainStatus to > > a new helper to

Re: [libvirt] Development Examples

2015-07-28 Thread Kevin Walker
Hi All I am trying to get up to speed with developing with libvirt. Can anyone provide some good examples in C of how to gather statistics from domains, network and storage? The dev guide just has TBD for these items Kind regards Kevin Walker -- libvir-list mailing list libvir-list@redh

Re: [libvirt] [PATCH 0/4] manage the shmem device source

2015-07-28 Thread lhuang
On 07/28/2015 12:05 AM, Daniel P. Berrange wrote: On Mon, Jul 27, 2015 at 03:40:36PM +0100, Daniel P. Berrange wrote: On Mon, Jul 27, 2015 at 04:09:01PM +0200, Marc-André Lureau wrote: Hi Luyao On Thu, Jul 23, 2015 at 12:13 PM, Luyao Huang wrote: But the problem is we cannot change the runn