Re: [libvirt] [PATCH] virsh: fix no error when pass a count <= 0 to setvcpus

On Thu, 2015-07-30 at 10:57 +0800, Luyao Huang wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1248277 > > When count <= 0, the client exit without set an error. > > Signed-off-by: Luyao Huang > --- > tools/virsh-domain.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > di

[libvirt] [python PATCH] iothread: Fix crash if virDomainGetIOThreadInfo returns error

The cleanup portion of libvirt_virDomainGetIOThreadInfo would try to clean the returned structures but the count of iothreads was set to -1. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1248295 --- libvirt-override.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH] virsh: fix no error when pass a count <= 0 to setvcpus

On Thu, Jul 30, 2015 at 09:29:15 +0200, Andrea Bolognani wrote: > On Thu, 2015-07-30 at 10:57 +0800, Luyao Huang wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1248277 > > > > When count <= 0, the client exit without set an error. > > > > Signed-off-by: Luyao Huang > > --- > > tools/vir

Re: [libvirt] [python PATCH] iothread: Fix crash if virDomainGetIOThreadInfo returns error

On 30/07/15 09:36, Peter Krempa wrote: > The cleanup portion of libvirt_virDomainGetIOThreadInfo would try to > clean the returned structures but the count of iothreads was set to -1. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1248295 > --- > libvirt-override.c | 6 -- > 1 fi

Re: [libvirt] [PATCH] virsh: fix no error when pass a count <= 0 to setvcpus

On Thu, 2015-07-30 at 09:45 +0200, Peter Krempa wrote: > > Since we know that here we are trying to set 0 cpus which is wrong we > can also say that explicitly in the error message rather than copying > the generic one. Using the generic one means we don't have to add yet another translatable str

Re: [libvirt] [python PATCH] iothread: Fix crash if virDomainGetIOThreadInfo returns error

On Thu, Jul 30, 2015 at 09:49:51 +0200, Erik Skultety wrote: > > > On 30/07/15 09:36, Peter Krempa wrote: > > The cleanup portion of libvirt_virDomainGetIOThreadInfo would try to > > clean the returned structures but the count of iothreads was set to -1. > > > > Resolves: https://bugzilla.redhat

Re: [libvirt] [PATCH] virsh: fix no error when pass a count <= 0 to setvcpus

On Thu, Jul 30, 2015 at 09:51:15 +0200, Andrea Bolognani wrote: > On Thu, 2015-07-30 at 09:45 +0200, Peter Krempa wrote: > > > > Since we know that here we are trying to set 0 cpus which is wrong we > > can also say that explicitly in the error message rather than copying > > the generic one. > >

Re: [libvirt] [PATCH] virsh: fix no error when pass a count <= 0 to setvcpus

On 07/30/2015 03:29 PM, Andrea Bolognani wrote: On Thu, 2015-07-30 at 10:57 +0800, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1248277 When count <= 0, the client exit without set an error. Signed-off-by: Luyao Huang --- tools/virsh-domain.c | 6 +- 1 file changed,

[libvirt] Build failed in Jenkins: libvirt-syntax-check #3732

See -- Started by upstream project "libvirt-build" build number 4256 Building on master in workspace [workspace] $ /bin/sh -xe /tmp/hud

Re: [libvirt] [PATCH] virsh: fix no error when pass a count <= 0 to setvcpus

On Thu, 2015-07-30 at 10:05 +0200, Peter Krempa wrote: > On Thu, Jul 30, 2015 at 09:51:15 +0200, Andrea Bolognani wrote: > > On Thu, 2015-07-30 at 09:45 +0200, Peter Krempa wrote: > > > > > > Since we know that here we are trying to set 0 cpus which is > > > wrong we > > > can also say that expli

Re: [libvirt] Build failed in Jenkins: libvirt-syntax-check #3732

On Thu, 2015-07-30 at 10:18 +0200, Jenkins CI wrote: > See > > -- > Started by upstream project "libvirt-build" build number 4256 > Building on master in workspace >

[libvirt] Jenkins build is back to normal : libvirt-syntax-check #3733

See -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v11 0/5] nodeinfo: Add support for subcores

Only patch 1/5 has been updated, all the other patches are the same as v8: 2/5 https://www.redhat.com/archives/libvir-list/2015-July/msg01045.html 3/5 https://www.redhat.com/archives/libvir-list/2015-July/msg01048.html 4/5 https://www.redhat.com/archives/libvir-list/2015-July/msg01049.html

[libvirt] [PATCH v11 1/5] nodeinfo: Fix output on PPC64 KVM hosts

From: Shivaprasad G Bhat The nodeinfo is reporting incorrect number of cpus and incorrect host topology on PPC64 KVM hosts. The KVM hypervisor on PPC64 needs only the primary thread in a core to be online, and the secondaries offlined. While scheduling a guest in, the kvm scheduler wakes up the s

Re: [libvirt] ambiguous ret of qemuDomainDetachVirtioDiskDevice

On 2015/7/28 16:33, Ján Tomko wrote: > On Tue, Jul 28, 2015 at 04:25:13PM +0800, zhang bo wrote: >> static int >> qemuDomainDetachVirtioDiskDevice(virQEMUDriverPtr driver, >> virDomainObjPtr vm, >> virDomainDiskDefPtr detach) >> { >

Re: [libvirt] [PATCH v10 1/5] nodeinfo: Fix output on PPC64 KVM hosts

On Wed, 2015-07-29 at 22:30 -0400, John Ferlan wrote: > > > +online_cpus = nodeGetOnlineCPUBitmap(sysfs_prefix); > > +if (online_cpus == NULL) > > +goto cleanup; > > + > > +nonline_cpus = virBitmapSize(online_cpus); > > + > > +for (cpu = 0; cpu < nonline_cpus; cpu++) { > >

Re: [libvirt] [PATCH 1/4] conf: introduce seclabels in shmem device element

On Thu, Jul 23, 2015 at 06:13:46PM +0800, Luyao Huang wrote: > Introduce a new element in shmem device element, this > could help users to change the shm label to a specified > label. > > Signed-off-by: Luyao Huang > --- > docs/formatdomain.html.in | 7 ++ > docs/schemas/domaincommon.rn

Re: [libvirt] [PATCH 2/4] security: add security part for shmem device

On Thu, Jul 23, 2015 at 06:13:47PM +0800, Luyao Huang wrote: > A new api to help set/restore the shmem deivce dac/selinux label. s/deivce/device/ > Signed-off-by: Luyao Huang > --- > src/libvirt_private.syms| 2 ++ > src/security/security_dac.c | 67

Re: [libvirt] [PATCH 2/4] security: add security part for shmem device

On Thu, Jul 23, 2015 at 06:13:47PM +0800, Luyao Huang wrote: > A new api to help set/restore the shmem deivce dac/selinux label. > > Signed-off-by: Luyao Huang > --- > src/libvirt_private.syms| 2 ++ > src/security/security_dac.c | 67 +++ > src/s

Re: [libvirt] [PATCH 3/4] util: introduce new helpers to manage shmem device

On Thu, Jul 23, 2015 at 06:13:48PM +0800, Luyao Huang wrote: > Signed-off-by: Luyao Huang > --- > configure.ac | 10 + > po/POTFILES.in | 3 +- > src/Makefile.am | 5 +- > src/libvirt_private.syms | 16 ++ > src/util/virshm.c| 623 > ++

Re: [libvirt] [PATCH 4/4] qemu: call the helpers in virshm.c to manage shmem device

On Thu, Jul 23, 2015 at 06:13:49PM +0800, Luyao Huang wrote: > Signed-off-by: Luyao Huang > --- > src/qemu/qemu_conf.h| 3 + > src/qemu/qemu_driver.c | 4 ++ > src/qemu/qemu_process.c | 158 > > 3 files changed, 165 insertions(+) > > dif

Re: [libvirt] [PATCH 4/4] qemu: call the helpers in virshm.c to manage shmem device

On Thu, Jul 23, 2015 at 06:13:49PM +0800, Luyao Huang wrote: > Signed-off-by: Luyao Huang > --- > src/qemu/qemu_conf.h| 3 + > src/qemu/qemu_driver.c | 4 ++ > src/qemu/qemu_process.c | 158 > > 3 files changed, 165 insertions(+) > > +s

Re: [libvirt] [PATCH 1/4] conf: introduce seclabels in shmem device element

On Thu, Jul 23, 2015 at 06:13:46PM +0800, Luyao Huang wrote: > Introduce a new element in shmem device element, this > could help users to change the shm label to a specified > label. > > Signed-off-by: Luyao Huang > --- > docs/formatdomain.html.in | 7 ++ > docs/schemas/domaincommon.rn

Re: [libvirt] [sandbox PATCH 02/11] Fix virt-sandbox-image

On Thu, Jul 23, 2015 at 03:57:28PM +, Eren Yagdiran wrote: > Authentication fix for Docker REST API. > --- > virt-sandbox-image/virt-sandbox-image.py | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/virt-sandbox-image/virt-sandbox-image.py > b/virt-sandbox-

Re: [libvirt] [sandbox PATCH 01/11] Add virt-sandbox-image

On Thu, Jul 23, 2015 at 03:57:27PM +, Eren Yagdiran wrote: > From: Daniel P Berrange > > virt-sandbox-image.py is a python script that lets you download Docker > images easily. It is a proof of concept code and consumes Docker Rest API. > --- > po/POTFILES.in | 1

Re: [libvirt] [sandbox PATCH 02/11] Fix virt-sandbox-image

On Tue, Jul 28, 2015 at 02:43:44PM +0200, Cedric Bosdonnat wrote: > Hi Eren, > > As a fix of the PoC, this commit could introduce the man page for the > new command. I think it is fine to introduce the manpage as a separate commit at the end of the series, not least because the rest of the series

Re: [libvirt] [sandbox PATCH 04/11] Image: Add download function

On Thu, Jul 23, 2015 at 03:57:30PM +, Eren Yagdiran wrote: > Refactor download function from virt-sandbox-image to use > the newly introduced Source abstract class. The docker-specific > download code is moved to a new DockerSource class. > --- > virt-sandbox-image/sources/DockerSource.py | 19

Re: [libvirt] [sandbox PATCH 05/11] Image: Refactor create function

On Thu, Jul 23, 2015 at 03:57:31PM +, Eren Yagdiran wrote: > Move the docker-related code to the DockerSource and use > the Source mechanism > --- > virt-sandbox-image/sources/DockerSource.py | 95 > ++ > virt-sandbox-image/sources/Source.py | 5 ++ > virt-s

Re: [libvirt] [sandbox PATCH 03/11] Image: Add Hooking Mechanism

On Thu, Jul 23, 2015 at 03:57:29PM +, Eren Yagdiran wrote: > Any custom source provider can be added to virt-sandbox-image as a source > --- > virt-sandbox-image/sources/Source.py | 8 > virt-sandbox-image/virt-sandbox-image.py | 30 +- > 2 files chang

Re: [libvirt] [PATCH 2/2] Avoid starting a PowerPC VM with floppy disk

On 07/28/2015 05:32 PM, Ján Tomko wrote: On Fri, Jul 24, 2015 at 03:30:49PM -0400, Kothapally Madhu Pavan wrote: PowerPC pseries based VMs do not support a floppy disk controller. This prohibits libvirt from creating qemu command with floppy device. Signed-off-by: Kothapally Madhu Pavan ---

Re: [libvirt] [PATCH 0/2] Disable floppy disk for PowerPC VMs

On 07/29/2015 06:25 PM, Andrea Bolognani wrote: On Fri, 2015-07-24 at 15:29 -0400, Kothapally Madhu Pavan wrote: This is an attempt to fix: Libvirt BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1180486 Libvirt currently assumes ISA_based floppy disks to be available across all architectures

[libvirt] [PATCH v2 1/3] Caps: Disable floppy disk for PowerPC VM

PowerPC pseries based VMs do not support a floppy disk controller. This prohibits libvirt from adding floppy disk for a PowerPC pseries VM. Signed-off-by: Kothapally Madhu Pavan --- src/qemu/qemu_capabilities.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git

[libvirt] [PATCH v2 2/3] Avoid starting a PowerPC VM with floppy disk

PowerPC pseries based VMs do not support a floppy disk controller. This prohibits libvirt from creating qemu command with floppy device. Signed-off-by: Kothapally Madhu Pavan --- src/qemu/qemu_command.c |8 1 file changed, 8 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/

[libvirt] [PATCH v2 3/3] test: Introduce test case to disallow floppy disk on PowerPC VM

PowerPC pseries based VMs do not support a floppy disk controller. This test case fails if libvirt allows a floppy disk on pseries VMs. Signed-off-by: Kothapally Madhu Pavan --- .../qemuxml2argv-disk-floppy-pseries.args |6 +++ .../qemuxml2argv-disk-floppy-pseries.xml |

[libvirt] [PATCH v2 0/3] Disable floppy disk for PowerPC VMs

This is an attempt to fix: Libvirt BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1180486 Libvirt currently assumes ISA_based floppy disks to be available across all architectures and machine types. However, PowerPC Book 3S compatible ('ie pseries) virtual machines do not support Floppy disks.

Re: [libvirt] [PATCH] Inherit namespace feature

On Wed, Jul 01, 2015 at 11:07:07PM +0530, ik.nitk wrote: > This patch adds feature for lxc containers to inherit namespaces. This is > very similar to what > lxc-tools or docker provides. Look for "man lxc-start" and you will find > that you can pass command args as > [ --share-[net|ipc|uts] na

[libvirt] [PATCH] qemu: Reject migration with memory-hotplug if destination doesn't support it

If destination libvirt doesn't support memory hotplug since all the support was introduced by adding new elements the destination would attempt to start qemu with an invalid configuration. The worse part is that qemu might hang in such situation. Fix this by sending a required migration feature ca

[libvirt] [PATCH] qemu: Properly check for incoming migration job

In addition to checking the current asynchronous job qemuMigrationJobIsActive reports an error if the current job does not match the one we asked for. Let's just check the job directly since we are not interested in the error in qemuProcessHandleMonitorEOF. Signed-off-by: Jiri Denemark --- src/q

Re: [libvirt] libvirt 1.2.17 fails

On Mon, Jul 27, 2015 at 2:46 PM, Jason Helfman wrote: > Hello All, > > I am getting build failures on the latest build, and it is currently > blocking my commit of the update. Looks like xhtml, is a new build > requirement. I added it to the list of dependencies, however it is failing > to build

Re: [libvirt] ambiguous ret of qemuDomainDetachVirtioDiskDevice

On 2015/7/30 17:41, zhang bo wrote: > On 2015/7/28 16:33, Ján Tomko wrote: > >> On Tue, Jul 28, 2015 at 04:25:13PM +0800, zhang bo wrote: >>> static int >>> qemuDomainDetachVirtioDiskDevice(virQEMUDriverPtr driver, >>> virDomainObjPtr vm, >>>

[libvirt] [python PATCH] examples: small fix for nodestats.py example

Add nodestats.py in MANIFEST.in and add a small description for nodestats.py in README Signed-off-by: Luyao Huang --- MANIFEST.in | 1 + examples/README | 3 +++ 2 files changed, 4 insertions(+) diff --git a/MANIFEST.in b/MANIFEST.in index b5ba783..0d66f9c 100644 --- a/MANIFEST.in +++ b/MAN

Re: [libvirt] [PATCH 1/4] conf: introduce seclabels in shmem device element

Hi Marc-André On 07/27/2015 11:42 PM, Marc-André Lureau wrote: Hi On Thu, Jul 23, 2015 at 12:13 PM, Luyao Huang wrote: Introduce a new element in shmem device element, this could help users to change the shm label to a specified label. Signed-off-by: Luyao Huang --- docs/formatdomain.html

Re: [libvirt] [PATCH 1/4] conf: introduce seclabels in shmem device element

On 07/30/2015 05:48 PM, Daniel P. Berrange wrote: On Thu, Jul 23, 2015 at 06:13:46PM +0800, Luyao Huang wrote: Introduce a new element in shmem device element, this could help users to change the shm label to a specified label. Signed-off-by: Luyao Huang --- docs/formatdomain.html.in |