[libvirt] [PATCH 2/2] netlink: add support for multi-part netlink messages.

2015-07-31 Thread Maxim Perevedentsev
Such messages do not have NLMSG_ERROR or NLMSG_DONE type but they are valid responses. We test 'multi-partness' by looking for NLM_F_MULTI flag. --- src/util/virnetlink.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index 0052

[libvirt] [PATCH 1/2] network: added waiting for DAD to finish for bridge address.

2015-07-31 Thread Maxim Perevedentsev
This is a fix for commit db488c79173b240459c7754f38c3c6af9b432970 dnsmasq main process exits without waiting for DAD, this is dnsmasq daemon's task. So we periodically poll the kernel using netlink and check whether there are any IPv6 addresses assigned to bridge which have 'tentative' state. After

[libvirt] [PATCH 0/2] Added waiting for DAD to finish for bridge address.

2015-07-31 Thread Maxim Perevedentsev
This is a fix for commit db488c79173b240459c7754f38c3c6af9b432970 dnsmasq main process which is relied on when waiting for DAD to complete exits without actually waiting for DAD. This is dnsmasq daemon's task. It seems to be a race that DAD finished before dnsmasq main process exited. The above co

[libvirt] [PATCH 1/2] network: added waiting for DAD to finish for bridge address.

2015-07-31 Thread Maxim Perevedentsev
This is a fix for commit db488c79173b240459c7754f38c3c6af9b432970 dnsmasq main process exits without waiting for DAD, this is dnsmasq daemon's task. So we periodically poll the kernel using netlink and check whether there are any IPv6 addresses assigned to bridge which have 'tentative' state. After

[libvirt] [PATCH 2/2] netlink: add support for multi-part netlink messages.

2015-07-31 Thread Maxim Perevedentsev
Such messages do not have NLMSG_ERROR or NLMSG_DONE type but they are valid responses. We test 'multi-partness' by looking for NLM_F_MULTI flag. --- src/util/virnetlink.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index 0052

[libvirt] [PATCH 0/2] Added waiting for DAD to finish for bridge address.

2015-07-31 Thread Maxim Perevedentsev
This is a fix for commit db488c79173b240459c7754f38c3c6af9b432970 dnsmasq main process which is relied on when waiting for DAD to complete exits without actually waiting for DAD. This is dnsmasq daemon's task. It seems to be a race that DAD finished before dnsmasq main process exited. The above co

Re: [libvirt] Replace AF_LOCAL with AF_PACKET

2015-07-31 Thread Ben Gray
Thanks Daniel, It does indeed work for us, we use both a NAT based network config and an Isolated network config. So far we haven't seen any negative impacts. For reference this is the very simple patch I did --- a/src/util/virnetdev.c2015-07-31 15:46:58.925705063 +0100 +++ b/src

[libvirt] [PATCH 2/2] qemu: ppc64: Align memory sizes to 256MiB

2015-07-31 Thread Peter Krempa
Since qemu upstream commit TBD [1] the memory size for numa nodes, memory devices and the total size needs to be aligned to multiples of 256MiB. Otherwise qemu refuses to start with the following message: qemu-kvm: Can't support memory configuration where RAM size 0x7d00 or maxmem size 0x7d000

[libvirt] [PATCH 0/2] qemu: Improve memory alignment handling and fix upcoming powerpc

2015-07-31 Thread Peter Krempa
Peter Krempa (2): qemu: Make memory alignment helper more universal qemu: ppc64: Align memory sizes to 256MiB src/qemu/qemu_domain.c | 33 -- src/qemu/qemu_domain.h | 3 +- src/qemu/qemu_hotplug.c

[libvirt] [PATCH 1/2] qemu: Make memory alignment helper more universal

2015-07-31 Thread Peter Krempa
Extract the size determination into a separate function and reuse it across the memory device alignment functions. Since later we will need to decide the alignment size according to architecture let's pass def to the functions. --- src/qemu/qemu_domain.c | 26 ++ src/qemu/

Re: [libvirt] Replace AF_LOCAL with AF_PACKET

2015-07-31 Thread Daniel P. Berrange
On Fri, Jul 31, 2015 at 03:10:24PM +0100, Ben Gray wrote: > Hi, > > I've a question on whether it's 'safe' to change the socket type used in > virNetxxx calls from AF_PACKET to AF_LOCAL ? > > The reason I ask is that we're using libvirt-lxc with a couple of bridge > interfaces, and we've

[libvirt] Replace AF_LOCAL with AF_PACKET

2015-07-31 Thread Ben Gray
Hi, I've a question on whether it's 'safe' to change the socket type used in virNetxxx calls from AF_PACKET to AF_LOCAL ? The reason I ask is that we're using libvirt-lxc with a couple of bridge interfaces, and we've found that the socket close call on AF_PACKET type sockets takes be

Re: [libvirt] [PATCH 0/4] cpu: Rename {powerpc,ppc} => ppc64

2015-07-31 Thread Jiri Denemark
On Mon, Jul 20, 2015 at 15:47:48 +0200, Andrea Bolognani wrote: > The naming of files and symbols belonging to the ppc64 CPU > driver was all over the place: this series brings > inner-peace-inducing consistency to that corner of libvirt > via a series of straightforward string replacements. > > M

Re: [libvirt] [PATCH] qemu: Reject migration with memory-hotplug if destination doesn't support it

2015-07-31 Thread Peter Krempa
On Fri, Jul 31, 2015 at 14:20:09 +0200, Jiri Denemark wrote: > On Thu, Jul 30, 2015 at 16:47:02 +0200, Peter Krempa wrote: > > If destination libvirt doesn't support memory hotplug since all the > > support was introduced by adding new elements the destination would > > attempt to start qemu with a

Re: [libvirt] [PATCH v2] qemu: Do not reset labels when migration fails

2015-07-31 Thread Peter Krempa
On Fri, Jul 31, 2015 at 14:58:57 +0200, Jiri Denemark wrote: > When stopping a domain on the destination host after a failed migration, > we need to avoid reseting security labels since the domain is still > running on the source host. While we were correctly doing so in some > cases, there were st

[libvirt] [PATCH v2] qemu: Do not reset labels when migration fails

2015-07-31 Thread Jiri Denemark
When stopping a domain on the destination host after a failed migration, we need to avoid reseting security labels since the domain is still running on the source host. While we were correctly doing so in some cases, there were still some paths which did this wrong. https://bugzilla.redhat.com/sho

Re: [libvirt] [PATCH] qemu: Do not reset labels when migration fails

2015-07-31 Thread Jiri Denemark
On Fri, Jul 31, 2015 at 14:39:13 +0200, Peter Krempa wrote: > On Fri, Jul 31, 2015 at 13:57:29 +0200, Jiri Denemark wrote: > > When stopping a domain on the destination host after a failed migration, > > we need to avoid reseting security labels since the domain is still > > running on the source h

Re: [libvirt] [PATCH] qemu: Do not reset labels when migration fails

2015-07-31 Thread Peter Krempa
On Fri, Jul 31, 2015 at 13:57:29 +0200, Jiri Denemark wrote: > When stopping a domain on the destination host after a failed migration, > we need to avoid reseting security labels since the domain is still > running on the source host. While we were correctly doing so in some > cases, there were st

Re: [libvirt] [PATCH] There is no virDomainFindBy{ID, Name, UUID} anymore

2015-07-31 Thread Martin Kletzander
On Wed, Jul 29, 2015 at 05:11:20PM +0800, Cao jin wrote: s/virDomainFindBy/virDomainObjListFindBy/ Signed-off-by: Cao jin --- src/qemu/THREADS.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ACK after release, I'm adding it to my after-release queue. diff --git a/src/qemu/THREADS.

Re: [libvirt] [PATCH] qemu: fix some api cannot work when disable cpuset in conf

2015-07-31 Thread Martin Kletzander
On Mon, Jul 20, 2015 at 05:18:37PM +0800, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1244664 If user disable cpuset in qemu.conf, we shouldn't try to use it, also shouldn't make some command which can work without cpuset cannot work. Fix these case: 1. start guest with stric

Re: [libvirt] [PATCH] qemu: Properly check for incoming migration job

2015-07-31 Thread Peter Krempa
On Thu, Jul 30, 2015 at 17:00:11 +0200, Jiri Denemark wrote: > In addition to checking the current asynchronous job > qemuMigrationJobIsActive reports an error if the current job does not > match the one we asked for. Let's just check the job directly since we > are not interested in the error in q

Re: [libvirt] [PATCH] qemu: Reject migration with memory-hotplug if destination doesn't support it

2015-07-31 Thread Jiri Denemark
On Thu, Jul 30, 2015 at 16:47:02 +0200, Peter Krempa wrote: > If destination libvirt doesn't support memory hotplug since all the > support was introduced by adding new elements the destination would > attempt to start qemu with an invalid configuration. The worse part is > that qemu might hang in

[libvirt] [PATCH] qemu: Do not reset labels when migration fails

2015-07-31 Thread Jiri Denemark
When stopping a domain on the destination host after a failed migration, we need to avoid reseting security labels since the domain is still running on the source host. While we were correctly doing so in some cases, there were still some paths which did this wrong. https://bugzilla.redhat.com/sho

Re: [libvirt] [sandbox PATCH 01/11] Add virt-sandbox-image

2015-07-31 Thread Daniel P. Berrange
On Fri, Jul 31, 2015 at 12:00:40PM +0200, Guido Günther wrote: > On Fri, Jul 31, 2015 at 09:42:16AM +0100, Daniel P. Berrange wrote: > > On Fri, Jul 31, 2015 at 09:15:13AM +0200, Guido Günther wrote: > > > On Thu, Jul 23, 2015 at 03:57:27PM +, Eren Yagdiran wrote: > > > [..snip..] > > > > +def

Re: [libvirt] [sandbox PATCH 01/11] Add virt-sandbox-image

2015-07-31 Thread Guido Günther
On Fri, Jul 31, 2015 at 09:42:16AM +0100, Daniel P. Berrange wrote: > On Fri, Jul 31, 2015 at 09:15:13AM +0200, Guido Günther wrote: > > On Thu, Jul 23, 2015 at 03:57:27PM +, Eren Yagdiran wrote: > > [..snip..] > > > +def get_url(server, path, headers): > > > +url = "https://"; + server + p

[libvirt] Availability of libvirt-1.2.18-rc2

2015-07-31 Thread Daniel Veillard
I'm a day late but I tagged rc2 in git and pushed signed tarballs and rpms to thenusual place at: ftp://libvirt.org/libvirt/ Seems to work just fine with my limited testing, and not hearing about big issue I will push 1.2.18 on Monday morning. Everything seems fine in ci.centos.org (except

Re: [libvirt] [sandbox PATCH 01/11] Add virt-sandbox-image

2015-07-31 Thread Daniel P. Berrange
On Fri, Jul 31, 2015 at 09:15:13AM +0200, Guido Günther wrote: > On Thu, Jul 23, 2015 at 03:57:27PM +, Eren Yagdiran wrote: > [..snip..] > > +def get_url(server, path, headers): > > +url = "https://"; + server + path > > +debug(" Fetching %s..." % url) > > + > > +req = urllib2.

Re: [libvirt] [sandbox PATCH 01/11] Add virt-sandbox-image

2015-07-31 Thread Guido Günther
On Thu, Jul 23, 2015 at 03:57:27PM +, Eren Yagdiran wrote: [..snip..] > +def get_url(server, path, headers): > +url = "https://"; + server + path > +debug(" Fetching %s..." % url) > + > +req = urllib2.Request(url=url) This does not seem to do any certificate validation (just i

Re: [libvirt] [libvirt-test-api][PATCH] Introduce new test case for setMemoryStatsPeriod

2015-07-31 Thread hongming
On 07/02/2015 05:25 PM, Luyao Huang wrote: Signed-off-by: Luyao Huang --- cases/linux_domain.conf | 6 +++ repos/domain/set_memory_period.py | 84 +++ 2 files changed, 90 insertions(+) create mode 100644 repos/domain/set_memory_period.py diff