Hello!
> This reverts commit ede34470fde19c0f326cdb0dfca39fa86fd9ec16, which
> was apparently written based on testing performed before commits
> 1e15be1 and 9a12b6 were pushed upstream. Once those two patches are in
> place, commit ede34470 is redundant, and can even cause
> incorrect/unexpected
Hello!
> I was a bit confused about the patches that landed; I see now that they only
> add a PCI controller for modern -M virt, but don't change the virtio defaults
> to use it.
Yes, because in first versions i changed the default and was criticized for
it, because it broke
backwards compatib
Commit 6983d6d2 tried to improve parseRateStr but broke the build
instead for compilers that were not able to properly introspect the for
loop indexed by the enum resulting into the following error:
virsh-domain.c: In function 'parseRateStr':
virsh-domain.c:916:13: error: 'field_name' may be used
Peter Krempa (2):
virsh: Refactor parseRateStr to avoid false-positive uninitialized
variable
virsh: Properly reject 'floor' settings in cmdAttachInterface
tools/virsh-domain.c | 96 ++--
1 file changed, 41 insertions(+), 55 deletions(-)
--
cmdAttachInterface doesn't support the 'floor' field that was added in
d7f5c88961b52 but that commit didn't properly reject it from
cmdAttachInterface where it's unused.
---
tools/virsh-domain.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/virsh-domain.c b/tool
Hi Daniel,
"Daniel P. Berrange" writes:
> On Tue, Aug 11, 2015 at 04:57:15PM +0530, Nikunj A Dadhania wrote:
>> The default resource partition is created in the domain start path if it
>> is not existing. Even when libvirtd is stopped after shutting down all
>> domains, the resource partition st
On 08/11/2015 10:13 PM, Alex Williamson wrote:
> On Tue, 2015-08-11 at 19:26 -0400, Laine Stump wrote:
>> (Alex - I cc'ed you because I addressed a question or two your way down
>> towards the bottom).
>>
>> On 08/11/2015 02:52 AM, Pavel Fedin wrote:
>>> Hello!
>>>
The original patches to sup
Hi,
The problem was solved.
The rpm package have to be built under the non-root account only.
Thanks very much!
On Tue, 11/08/2015 at 16:43 +0200, Martin Kletzander wrote:
> On Tue, Aug 11, 2015 at 06:38:32PM +0600, Dmitriy Slachshyov wrote:
> > Hi,
> >
> > While building the libvirt version
On Tue, 2015-08-11 at 19:26 -0400, Laine Stump wrote:
> (Alex - I cc'ed you because I addressed a question or two your way down
> towards the bottom).
>
> On 08/11/2015 02:52 AM, Pavel Fedin wrote:
> > Hello!
> >
> >> The original patches to support pcie-root severely restricted what could
> >> p
(Alex - I cc'ed you because I addressed a question or two your way down
towards the bottom).
On 08/11/2015 02:52 AM, Pavel Fedin wrote:
> Hello!
>
>> The original patches to support pcie-root severely restricted what could
>> plug into what because in real hardware you can't plug a PCI device int
This reverts commit ede34470fde19c0f326cdb0dfca39fa86fd9ec16, which
was apparently written based on testing performed before commits
1e15be1 and 9a12b6 were pushed upstream. Once those two patches are in
place, commit ede34470 is redundant, and can even cause
incorrect/unexpected behavior when auto
On 08/11/2015 05:32 PM, John Ferlan wrote:
>
>
> On 08/11/2015 05:28 PM, Cole Robinson wrote:
>> On 08/11/2015 05:25 PM, John Ferlan wrote:
>>>
>>>
>>> On 08/10/2015 07:33 PM, Cole Robinson wrote:
If you pass XML to UpdateDevice, and the original device
didn't have a block, libvirtd c
On 08/11/2015 05:24 PM, Moshe Levi wrote:
>
>> Laine's patch is now pushed - I assume at least parts of this will be
>> necessary
>> since there are reports of different GFEATURE_SIZE values...
> Ok, Do you want me to rebase my patch on top on this
> http://libvirt.org/git/?p=libvirt.git;a=commit
On 08/11/2015 05:28 PM, Cole Robinson wrote:
> On 08/11/2015 05:25 PM, John Ferlan wrote:
>>
>>
>> On 08/10/2015 07:33 PM, Cole Robinson wrote:
>>> If you pass XML to UpdateDevice, and the original device
>>> didn't have a block, libvirtd crashes trying to read the original
>>> NULL serial stri
On 08/11/2015 05:24 PM, Moshe Levi wrote:
>
>
>> -Original Message-
>> From: John Ferlan [mailto:jfer...@redhat.com]
>> Sent: Wednesday, August 12, 2015 12:01 AM
>> To: Moshe Levi; Laine Stump; libvir-list@redhat.com
>> Subject: Re: [libvirt] [PATCH] nodedev: Fix gfeature size to be acc
On 08/11/2015 05:25 PM, John Ferlan wrote:
>
>
> On 08/10/2015 07:33 PM, Cole Robinson wrote:
>> If you pass XML to UpdateDevice, and the original device
>> didn't have a block, libvirtd crashes trying to read the original
>> NULL serial string.
>>
>> Use _NULLABLE string comparisons to avoid t
On 08/10/2015 07:33 PM, Cole Robinson wrote:
> If you pass XML to UpdateDevice, and the original device
> didn't have a block, libvirtd crashes trying to read the original
> NULL serial string.
>
> Use _NULLABLE string comparisons to avoid the crash. A couple other
> properties needed the chan
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Wednesday, August 12, 2015 12:01 AM
> To: Moshe Levi; Laine Stump; libvir-list@redhat.com
> Subject: Re: [libvirt] [PATCH] nodedev: Fix gfeature size to be according to
> running kernel
>
>
>
> On 08/11/2015 0
On 08/11/2015 03:28 AM, Moshe Levi wrote:
>
>
>> -Original Message-
>> From: sendmail [mailto:justsendmailnothinge...@gmail.com] On Behalf Of
>> Laine Stump
>> Sent: Tuesday, August 11, 2015 9:27 AM
>> To: libvir-list@redhat.com
>> Cc: Moshe Levi
>> Subject: Re: [libvirt] [PATCH] nodede
On 08/11/2015 03:57 PM, John Ferlan wrote:
>
> On 08/11/2015 03:03 PM, Laine Stump wrote:
>> Commit e8d5517 updated the domain post-parse to automatically add
>> pcie-root et al for certain ARM "virt" machinetypes, but didn't update
>> the function qemuDomainSupportsPCI() which is called later on w
On Tue, Aug 11, 2015 at 01:22:39PM +0100, Daniel P. Berrange wrote:
> On Tue, Aug 11, 2015 at 01:46:44PM +0200, Guido Günther wrote:
> > When running the test suite using "unshare -n" we might have IPv6 but no
> > configured addresses. Due to AI_ADDRCONFIG getaddrinfo then fails with
> > EAI_NONAME
On 08/11/2015 03:03 PM, Laine Stump wrote:
> Commit e8d5517 updated the domain post-parse to automatically add
> pcie-root et al for certain ARM "virt" machinetypes, but didn't update
> the function qemuDomainSupportsPCI() which is called later on when we
> are auto-assigning PCI addresses and de
Otherwise we're leaking some 30+ symbols like
virAdmConnectClass
virAdmConnectNew
virConnectClass
virConnectCloseCallbackDataClass
virDomainClass
...
I marked the one symbol needed by the deamon as
LIBVIRT_ADMIN_PRIVATE_ for now.
---
There's likely a better solution for xdr_adm
On 08/11/2015 02:05 PM, Laine Stump wrote:
> This fixes the crash described here:
>
> https://www.redhat.com/archives/libvir-list/2015-August/msg00162.html
>
> In short, we were calling ioctl(SIOCETHTOOL) pointing to a too-short
> object that was a local on the stack, resulting in the memory p
Commit e8d5517 updated the domain post-parse to automatically add
pcie-root et al for certain ARM "virt" machinetypes, but didn't update
the function qemuDomainSupportsPCI() which is called later on when we
are auto-assigning PCI addresses and default settings for the PCI
controller and attribute
On 08/11/2015 01:51 PM, Cole Robinson wrote:
> On 07/17/2015 07:27 AM, Pavel Fedin wrote:
>> Virt machine in qemu since v2.3.0 has PCI generic host controller, and
>> can use PCI devices. This provides performance improvement as well as
>> vhost-net with irqfd support for virtio-net. However libvir
I just posted a much simplified V2 of this patch that *only* fixes the
crash, doesn't make any other cleanups:
https://www.redhat.com/archives/libvir-list/2015-August/msg00162.html
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
This fixes the crash described here:
https://www.redhat.com/archives/libvir-list/2015-August/msg00162.html
In short, we were calling ioctl(SIOCETHTOOL) pointing to a too-short
object that was a local on the stack, resulting in the memory past the
end of the object being overwritten. This was bec
On 07/17/2015 07:27 AM, Pavel Fedin wrote:
> Virt machine in qemu since v2.3.0 has PCI generic host controller, and
> can use PCI devices. This provides performance improvement as well as
> vhost-net with irqfd support for virtio-net. However libvirt currently
> does not allow ARM virt machine to h
On 8/10/15 1:28 AM, Laine Stump wrote:
On 08/07/2015 06:14 PM, Jonathan Toppins wrote:
Adds a new interface type using UDP sockets, this seems only applicable
to QEMU but have edited tree-wide to support the new interface type.
The interface type required the addition of a "destaddr" (destinati
On 8/10/15 11:06 AM, Ján Tomko wrote:
Signed-off-by: Jonathan Toppins
---
docs/formatdomain.html.in| 17
src/conf/domain_conf.c | 56 +---
src/conf/domain_conf.h | 3 +++
src/conf/netdev_bandwidth_conf.h | 1 +
On 08/11/2015 07:41 AM, Ján Tomko wrote:
> [reducing the cc-list]
>
> On Tue, Aug 11, 2015 at 02:47:09AM -0400, Laine Stump wrote:
>> This started out as a fix for a crash reported in IRC and on libvir-list:
>>
>> https://www.redhat.com/archives/libvir-list/2015-August/msg00162.html
>>
>> but as I
On Tue, 2015-08-11 at 17:59 +0200, Michal Privoznik wrote:
> On 11.08.2015 17:53, Andrea Bolognani wrote:
> > Commit adb865d introduced some changes in ppc64DriverNodeData()
> > that cause libvirtd to crash on startup unless this patch is
> > applied as well.
> > ---
> > src/cpu/cpu_ppc64.c | 2 +-
On 11.08.2015 17:53, Andrea Bolognani wrote:
> Commit adb865d introduced some changes in ppc64DriverNodeData()
> that cause libvirtd to crash on startup unless this patch is
> applied as well.
> ---
> src/cpu/cpu_ppc64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src
Commit adb865d introduced some changes in ppc64DriverNodeData()
that cause libvirtd to crash on startup unless this patch is
applied as well.
---
src/cpu/cpu_ppc64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c
index 33fec8b..85aa5bc
On Tue, Aug 11, 2015 at 06:38:32PM +0600, Dmitriy Slachshyov wrote:
Hi,
While building the libvirt version 1.2.18 on CentOS7 and also Fedora 22
with the latest updates I have got an error.
I also tried to build version 1.2.17 and had the same result.
Please, help to resolve this problem
Regur
Hi,
While building the libvirt version 1.2.18 on CentOS7 and also Fedora 22
with the latest updates I have got an error.
I also tried to build version 1.2.17 and had the same result.
Please, help to resolve this problem
Regurds,
Dmitriy==
libvirt 1.2.1
On 11.08.2015 15:16, Martin Kletzander wrote:
> Commit a6f9af8292b6 added checking for address colisions between
> starting and ending addresses of forwarding addresses, but forgot that
> there might be no addresses set at all.
>
> Signed-off-by: Martin Kletzander
> ---
> src/conf/network_conf.c
On Mon, 2015-08-10 at 10:55 +0200, Andrea Bolognani wrote:
> Patches 01-07 are cleanups, 08-10 are bug fixes and 11-20
> improve the driver.
>
> Changes in v3:
>
> * Fix a bug spotted by John thanks to Coverity
>
> Changes in v2:
>
> * Implement compatibility with guests defined on older
>
On Tue, 2015-08-11 at 15:17 +0200, Jiri Denemark wrote:
>
> > +/* Convert a legacy CPU definition by transforming
> > + * model names to generation names:
> > + * POWER7_v2.1 => POWER7
> > + * POWER7_v2.3 => POWER7
> > + * POWER7+_v2.1 => POWER7
> > + * POWER8_v1.0 => POWER8 */
> > +sta
On 08/11/2015 09:21 AM, Martin Kletzander wrote:
> On Tue, Aug 11, 2015 at 03:16:16PM +0200, Martin Kletzander wrote:
>> Commit a6f9af8292b6 added checking for address colisions between
>> starting and ending addresses of forwarding addresses, but forgot that
>> there might be no addresses set at a
On Tue, 2015-08-11 at 10:26 +0200, Jiri Denemark wrote:
>
> > +if (!virXPathBoolean("boolean(./@value)", ctxt) ||
> > +virXPathULongHex("string(./@value)", ctxt, &pvr) < 0)
> > {
> > +virReportError(VIR_ERR_INTERNAL_ERROR,
> > + _(
On Tue, Aug 11, 2015 at 03:16:16PM +0200, Martin Kletzander wrote:
Commit a6f9af8292b6 added checking for address colisions between
starting and ending addresses of forwarding addresses, but forgot that
there might be no addresses set at all.
Signed-off-by: Martin Kletzander
---
src/conf/networ
On Mon, Aug 10, 2015 at 10:56:01 +0200, Andrea Bolognani wrote:
> Now that all the changes have been implemented we can run the
> test cases once again, after updating them to reflect the new
> behaviour.
ACK
Jirka
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman
On Mon, Aug 10, 2015 at 10:55:53 +0200, Andrea Bolognani wrote:
> The upcoming commits will make heavy modifications to the ppc64
> driver, split so that it's easier to review the changes.
>
> Instead of updating the test cases so that they pass, possibly
> only to update them again with the follo
On Mon, Aug 10, 2015 at 10:55:59 +0200, Andrea Bolognani wrote:
> All previously recognized CPU models (POWER7_v2.1, POWER7_v2.3,
> POWER7+_v2.1 and POWER8_v1.0) are internally converted to the
> corrisponding generation name so that existing guests don't stop
> working.
> ---
> src/cpu/cpu_ppc64.
On 08/11/2015 08:12 AM, Martin Kletzander wrote:
>
> Me and Michal are looking at it, but after this patch I miss the
> default network after the daemon is restarted. Reverting fixes it, I
> know nothing more right now. Will update you later on.
Bah. I see the problem - if there is a element bu
Commit a6f9af8292b6 added checking for address colisions between
starting and ending addresses of forwarding addresses, but forgot that
there might be no addresses set at all.
Signed-off-by: Martin Kletzander
---
src/conf/network_conf.c| 22 +++---
...
The numad hint stored in priv->autoNodeset is information that gets lost
during daemon restart. And because we would like to use that
information in the future, we also need to save it in the status XML.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_domain.c | 32 ++
First two patches just prepare the ground for the third one that
explains what needs to be fixed and ho it's done.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1162947
v2:
- Added more info to commit message of patch 2/3
- Changed the commit subject of patch 3/3
Martin Kletzander (3)
On Mon, Aug 10, 2015 at 10:56:02 +0200, Andrea Bolognani wrote:
> The test cases cover the cpuCompare(), cpuBaseline() and
> cpuNodeData() implementation.
ACK
Jirka
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Pinning information returned for emulatorpin and vcpupin calls is being
returned from our data without querying cgroups for some time. However,
not all the data were utilized. When automatic placement is used the
information is not returned for the calls mentioned above. Since the
numad hint in
This needs a reorder of XML option definitions. It might come in handy
one day.
Signed-off-by: Martin Kletzander
---
src/conf/domain_conf.c | 2 +-
src/conf/domain_conf.h | 17 +
src/libxl/libxl_domain.c | 3 ++-
src/lxc/lxc_domain.c | 3 ++-
src/qemu/qemu_domain.c
On Mon, Aug 10, 2015 at 10:55:56 +0200, Andrea Bolognani wrote:
> Use multiple PVRs per CPU model to reduce the number of models we
> need to keep track of.
>
> Remove specific CPU models (eg. POWER7+_v2.1): the corresponding
> generic CPU model (eg. POWER7) should be used instead to ensure
> the
On Tue, Aug 11, 2015 at 01:46:44PM +0200, Guido Günther wrote:
> When running the test suite using "unshare -n" we might have IPv6 but no
> configured addresses. Due to AI_ADDRCONFIG getaddrinfo then fails with
> EAI_NONAME which we should then treat as IPv6 unavailable.
> ---
> src/rpc/virnetsock
When running the test suite using "unshare -n" we might have IPv6 but no
configured addresses. Due to AI_ADDRCONFIG getaddrinfo then fails with
EAI_NONAME which we should then treat as IPv6 unavailable.
---
src/rpc/virnetsocket.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
On Mon, Aug 10, 2015 at 02:02:50PM +0200, Ján Tomko wrote:
On Sat, Aug 08, 2015 at 06:04:00PM -0400, Laine Stump wrote:
This patch modifies virSocketAddrGetRange() to function properly when
the containing network/prefix of the address range isn't known, for
example in the case of the NAT range o
On Mon, Aug 10, 2015 at 05:37:30PM +0200, Frank Schreuder wrote:
> Hot-unplugging a disk from a guest that supports hot-unplugging generates an
> error
> in the libvirt log when running QEMU with the "-msg timestamp=on" flag.
>
> 2015-08-06 10:48:59.945+: 11662: error : qemuMonitorTextDriveDe
[reducing the cc-list]
On Tue, Aug 11, 2015 at 02:47:09AM -0400, Laine Stump wrote:
> This started out as a fix for a crash reported in IRC and on libvir-list:
>
> https://www.redhat.com/archives/libvir-list/2015-August/msg00162.html
>
> but as I examined the existing code I found so many small
On Tue, Aug 11, 2015 at 04:57:15PM +0530, Nikunj A Dadhania wrote:
> The default resource partition is created in the domain start path if it
> is not existing. Even when libvirtd is stopped after shutting down all
> domains, the resource partition still exists.
>
> The patch adds code to removes
On Mon, Aug 10, 2015 at 05:01:22PM +0100, Daniel P. Berrange wrote:
> On Mon, Aug 10, 2015 at 04:49:03PM +0100, Stefan Hajnoczi wrote:
> > On Mon, Aug 10, 2015 at 4:37 PM, Frank Schreuder
> > wrote:
> > > Hot-unplugging a disk from a guest that supports hot-unplugging generates
> > > an error
>
On Mon, Aug 10, 2015 at 10:56:00 +0200, Andrea Bolognani wrote:
> Unlike what happens on x86, on ppc64 you can't mix and match CPU
> features to obtain the guest CPU you want regardless of the host
> CPU, so the concept of model fallback doesn't apply.
>
> Make sure CPU definitions emitted by the
The default resource partition is created in the domain start path if it
is not existing. Even when libvirtd is stopped after shutting down all
domains, the resource partition still exists.
The patch adds code to removes the default resource partition in the
cgroup removal path of the domain. If t
On 08/11/2015 04:14 AM, Simon Kelley wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
>
>
> On 10/08/15 22:29, Laine Stump wrote:
>> On 08/10/2015 01:08 PM, Maxim Perevedentsev wrote:
>>> This is a fix for commit
>>> db488c79173b240459c7754f38c3c6af9b432970 dnsmasq main process
>>> exit
Hello!
> I liked the idea of adding all this
> if user supplies e.g.
IMHO there would be a usability problem with this:
a) Too much excessive typing.
b) It is not intuitively understood that you have to define the controller
explicitly. Especially
because if you run qemu by hands, this is not
On 08/11/2015 06:08 AM, Michal Privoznik wrote:
> On 11.08.2015 03:25, John Ferlan wrote:
>>
>>
>> On 08/03/2015 02:39 AM, Michal Privoznik wrote:
>>> We have a function parseRateStr() that parses --inbound and
>>> --outbound arguments to both attach-interface and domiftune.
>>> Now that we have
On Tue, Aug 11, 2015 at 09:28:21AM +0100, Daniel P. Berrange wrote:
On Mon, Aug 10, 2015 at 12:08:02PM -0400, Laine Stump wrote:
On 08/10/2015 11:09 AM, Daniel P. Berrange wrote:
> On Thu, Aug 06, 2015 at 07:46:58PM +0200, Martin Kletzander wrote:
>> On Thu, Aug 06, 2015 at 06:37:41PM +0200, Mar
On 11.08.2015 02:49, John Ferlan wrote:
>
>
> On 08/03/2015 02:39 AM, Michal Privoznik wrote:
>> This is no functional change. It's just that later in the series we
>> will need to pass class_id as an integer.
>>
>> Signed-off-by: Michal Privoznik
>> ---
>> src/network/bridge_driver.c | 4 ++
On 11.08.2015 03:09, John Ferlan wrote:
>
>
> On 08/03/2015 02:39 AM, Michal Privoznik wrote:
>> The function is used to parse a tuple delimited by commas into
>> virNetDevBandwidth structure. So far only three out of fore
>> fields are supported: average, peak and burst. The single missing
>> fi
On 11.08.2015 03:06, John Ferlan wrote:
>
>
> On 08/03/2015 02:39 AM, Michal Privoznik wrote:
>> As sketched in previous commits, imagine the following scenario:
>>
>> virsh # domiftune gentoo vnet0
>> inbound.average: 100
>> inbound.peak : 0
>> inbound.burst : 0
>> outbound.average:
On 11.08.2015 03:31, John Ferlan wrote:
>
>
> On 08/03/2015 02:39 AM, Michal Privoznik wrote:
>> Well, there are just two places that needs adjustment:
>>
>> qemuDomainGetInterfaceParameters - to report the @floor
>> qemuDomainSetInterfaceParameters - now that the function has been
>> fixed, we c
On 11.08.2015 03:25, John Ferlan wrote:
>
>
> On 08/03/2015 02:39 AM, Michal Privoznik wrote:
>> We have a function parseRateStr() that parses --inbound and
>> --outbound arguments to both attach-interface and domiftune.
>> Now that we have all virTypedParams macros needed for QoS,
>> lets parse
On 08/11/2015 12:15 AM, Laine Stump wrote:
On 08/10/2015 01:08 PM, Maxim Perevedentsev wrote:
Such messages do not have NLMSG_ERROR or NLMSG_DONE type
but they are valid responses. We test 'multi-partness'
by looking for NLM_F_MULTI flag.
---
src/util/virnetlink.c | 4 +++-
1 file changed,
On 08/11/2015 11:14 AM, Simon Kelley wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 10/08/15 22:29, Laine Stump wrote:
On 08/10/2015 01:08 PM, Maxim Perevedentsev wrote:
This is a fix for commit
db488c79173b240459c7754f38c3c6af9b432970 dnsmasq main process
exits without waiting
On Tue, Aug 11, 2015 at 09:59:01AM +0200, Erik Skultety wrote:
Not to be actually pushed since majority of this example will be merged
into virt-admin once it's ready, i.e. virsh splitting series is merged,
but might be good to just see the API's working.
---
I would say "please note in the sub
On Tue, Aug 11, 2015 at 09:59:00AM +0200, Erik Skultety wrote:
This is the first API to the admin interface. This particular API is
a convenience API, i.e. when managing clients connected to daemon's servers,
we should know (convenience) which server the specific client is connected to.
This impl
On 11/08/15 10:22, Martin Kletzander wrote:
> On Tue, Aug 11, 2015 at 09:58:58AM +0200, Erik Skultety wrote:
>> This is a public library, it shouldn't include anything that is
>> internal. Including the library in it's current state to an example
>> application fails the preprocessor phase.
>> ---
Hi!
> The only negative impact it would have is that
> if someone has old QEMU installed at define time and later upgrades to
> a QEMU with PCI support before starting the guest, they'll lack the
> PCI controller.
This won't actually happen, because together with the missing controller
he/she
On Mon, Aug 10, 2015 at 10:55:58 +0200, Andrea Bolognani wrote:
> This is yet another variation of POWER8. The PVR information comes
> from arch/powerpc/kernel/cputable.c in the Linux kernel tree.
> ---
> src/cpu/cpu_map.xml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/cpu/cpu_map
On Mon, Aug 10, 2015 at 10:55:57 +0200, Andrea Bolognani wrote:
> Instead of relying on a hard-coded mask value, read it from the CPU
> map XML and use it when looking up models by PVR.
ACK
Jirka
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-li
On Tue, Aug 11, 2015 at 10:25:19AM +0200, Peter Krempa wrote:
> On Tue, Aug 11, 2015 at 09:18:23 +0100, Daniel Berrange wrote:
> > On Mon, Aug 10, 2015 at 12:49:55PM -0600, Jim Fehlig wrote:
> > > This reverts commit 1ce7c1d20cfd5afb26d2dbc88201085d52415d0e,
> > > which introduced a significant sem
On Mon, Aug 10, 2015 at 12:08:02PM -0400, Laine Stump wrote:
> On 08/10/2015 11:09 AM, Daniel P. Berrange wrote:
> > On Thu, Aug 06, 2015 at 07:46:58PM +0200, Martin Kletzander wrote:
> >> On Thu, Aug 06, 2015 at 06:37:41PM +0200, Martin Kletzander wrote:
> >>> On Fri, Jul 17, 2015 at 02:27:45PM +0
On Mon, Aug 10, 2015 at 10:55:55 +0200, Andrea Bolognani wrote:
> This will allow us to perform PVR matching more broadly, eg. consider
> both POWER8 and POWER8E CPUs to be the same even though they have
> different PVR values.
> ---
> src/cpu/cpu_ppc64.c | 72
> +
On Mon, Aug 10, 2015 at 07:23:07PM -0400, Cole Robinson wrote:
> On 08/10/2015 11:09 AM, Daniel P. Berrange wrote:
> > On Thu, Aug 06, 2015 at 07:46:58PM +0200, Martin Kletzander wrote:
> >> On Thu, Aug 06, 2015 at 06:37:41PM +0200, Martin Kletzander wrote:
> >>> On Fri, Jul 17, 2015 at 02:27:45PM
On Tue, Aug 11, 2015 at 09:18:23 +0100, Daniel Berrange wrote:
> On Mon, Aug 10, 2015 at 12:49:55PM -0600, Jim Fehlig wrote:
> > This reverts commit 1ce7c1d20cfd5afb26d2dbc88201085d52415d0e,
> > which introduced a significant semantic change to the
> > virDomainGetInfo() API. Additionally, the chan
On Tue, Aug 11, 2015 at 09:58:59AM +0200, Erik Skultety wrote:
This change is merely because admin_server would contain all the code
from dispatchers and helpers to the actual APIs. Admin should have
similar structure to the daemon-side remote driver - dispatchers and
helpers in a separate module
On Tue, Aug 11, 2015 at 09:58:58AM +0200, Erik Skultety wrote:
This is a public library, it shouldn't include anything that is
internal. Including the library in it's current state to an example
application fails the preprocessor phase.
---
include/libvirt/libvirt-admin.h | 2 --
1 file changed, 2
On Tue, Aug 11, 2015 at 09:58:57AM +0200, Erik Skultety wrote:
By adding these elements, we'll be able to represent the servers on
client side. This is merely because when listing clients or managing
clients, it would be convenient to know which server they're connected
to. Also reflect this chan
On Mon, Aug 10, 2015 at 12:49:55PM -0600, Jim Fehlig wrote:
> This reverts commit 1ce7c1d20cfd5afb26d2dbc88201085d52415d0e,
> which introduced a significant semantic change to the
> virDomainGetInfo() API. Additionally, the change was only
> made to 2 of the 15 virt drivers.
>
> Conflicts:
>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 10/08/15 22:29, Laine Stump wrote:
> On 08/10/2015 01:08 PM, Maxim Perevedentsev wrote:
>> This is a fix for commit
>> db488c79173b240459c7754f38c3c6af9b432970 dnsmasq main process
>> exits without waiting for DAD, this is dnsmasq daemon's task.
On Tue, Aug 11, 2015 at 09:58:56AM +0200, Erik Skultety wrote:
JSON data that are used to initialize tests in virnetdaemontest should
be in a consistent format, i.e. not using tabs for indentation, those
should be replaced by spaces.
---
.../virnetdaemondata/input-data-admin-nomdns.json | 244 ++
On Mon, Aug 10, 2015 at 10:55:54 +0200, Andrea Bolognani wrote:
> Use a typedef instead of the plain struct and heap allocation. This
> will make it easier to extend the ppc64 specific CPU data later on.
ACK
Jirka
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/
On Mon, Aug 10, 2015 at 10:55:52 +0200, Andrea Bolognani wrote:
> This ensures comparison of two CPU definitions will be consistent
> regardless of the fact that it is performed using cpuCompare() or
> cpuGuestData(). The x86 driver uses the same exact code.
ACK
Jirka
--
libvir-list mailing list
This change is merely because admin_server would contain all the code
from dispatchers and helpers to the actual APIs. Admin should have
similar structure to the daemon-side remote driver - dispatchers and
helpers in a separate module, APIs in a separate module.
---
daemon/Makefile.am| 4 +-
Not to be actually pushed since majority of this example will be merged
into virt-admin once it's ready, i.e. virsh splitting series is merged,
but might be good to just see the API's working.
---
.gitignore | 1 +
Makefile.am | 2 +-
configure.ac
This is the first API to the admin interface. This particular API is
a convenience API, i.e. when managing clients connected to daemon's servers,
we should know (convenience) which server the specific client is connected to.
This implies a client-side representation of a server along with a basic
A
JSON data that are used to initialize tests in virnetdaemontest should
be in a consistent format, i.e. not using tabs for indentation, those
should be replaced by spaces.
---
.../virnetdaemondata/input-data-admin-nomdns.json | 244 ++---
1 file changed, 122 insertions(+), 122 dele
This is a public library, it shouldn't include anything that is
internal. Including the library in it's current state to an example
application fails the preprocessor phase.
---
include/libvirt/libvirt-admin.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/libvirt/libvirt-admin.h b/i
I'll send virt-admin list call once the virsh split series is merged.
Erik Skultety (6):
test: Replace tabs with spaces in input-data-admin-nomdns.json
rpc: Introduce new elements 'id' and 'name' to virnetserver structure
admin: Drop 'internal.h' include from libvirt-admin.h
admin: Move ad
By adding these elements, we'll be able to represent the servers on
client side. This is merely because when listing clients or managing
clients, it would be convenient to know which server they're connected
to. Also reflect this change in virnetdaemontest as well.
---
daemon/libvirtd.c
1 - 100 of 104 matches
Mail list logo
