On Tue, 2015-08-18 at 06:53 +, Eren Yagdiran wrote:
Run an already-built template
If there is no execution command specified by user, source.get_command will
find the command to invoke
---
virt-sandbox-image/virt-sandbox-image.py | 25 +
1 file changed, 25
Create capabilities cache using neq qemuTestMakeCapsCache() before
parsing XML files
Signed-off-by: Pavel Fedin p.fe...@samsung.com
---
tests/qemuagenttest.c| 9 -
tests/qemuargv2xmltest.c | 5 +
tests/qemuhotplugtest.c | 23 +++
tests/qemuxml2argvtest.c |
libvirt enforces at least one NUMA node for memory hotplug support on
all architectures. While it might be required for some x86 guest,
PowerPC can hotplug memory on non-NUMA system.
The generic checks are replaced with arch specific check and xml
validation too does not enforce node for non-x86
On Tue, 2015-08-18 at 06:53 +, Eren Yagdiran wrote:
Provide a way to know which disk image to use for the sandbox depending on
the used source
DockerSource will need to locate the topmost disk image among all the layers
images
---
virt-sandbox-image/sources/DockerSource.py | 18
On Tue, 2015-08-18 at 06:53 +, Eren Yagdiran wrote:
Add the config gobject to store custom environment variables.
This will allow creating custom environment variables on a sandbox
with a parameter formatted like --env key1=val1
---
libvirt-sandbox/Makefile.am | 2 +
---
bin/Makefile.am| 5 ++
bin/virt-sandbox-image.pod | 172 +
2 files changed, 177 insertions(+)
create mode 100644 bin/virt-sandbox-image.pod
diff --git a/bin/Makefile.am b/bin/Makefile.am
index df4c7dc..5d7ff8a 100644
---
On Tue, 2015-08-18 at 06:53 +, Eren Yagdiran wrote:
These helper functions are for selecting right directories according
to running user privileges
---
virt-sandbox-image/virt-sandbox-image.py | 27 ++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git
Since commit e8d55172544c1fafe31a9e09346bdebca4f0d6f9 qemu driver checks
emulator capabilities during domain XML post-parse. However, test suite
does not initialize it, therefore a condition to skip all checks if there
is no cache supplied was added. This is actually a hack, whose sole
purpose is
Since test suite now correctly creates capabilities cache, the hack is not
needed any more.
Signed-off-by: Pavel Fedin p.fe...@samsung.com
---
src/qemu/qemu_domain.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index
On Tue, 2015-08-18 at 06:53 +, Eren Yagdiran wrote:
Volumes let user to map host-paths into guest. Docker containers need volumes
because its
filesystem read-only by default.
Please reword that wrong commit message... docker file system isn't
read-only by default.
--
Cedric
---
V3 Changes:
* License syntax fixed
* Source abstract method get_env fixed
* Discarding byte code generation now resides into a new commit
* Template_dir and storage_dir refactored and runtime resolver is added for
checking permissions
* -f,--format parameter is refactored. Default is qcow2.
* Ssl
Commandline parameters for running a template
---
virt-sandbox-image/virt-sandbox-image.py | 13 +
1 file changed, 13 insertions(+)
diff --git a/virt-sandbox-image/virt-sandbox-image.py
b/virt-sandbox-image/virt-sandbox-image.py
index 1da5150..d6b682f 100755
---
make check now includes testcase for environment variables
---
libvirt-sandbox/tests/test-config.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/libvirt-sandbox/tests/test-config.c
b/libvirt-sandbox/tests/test-config.c
index da05187..ac10bab 100644
---
Run an already-built template
If there is no execution command specified by user, source.get_command will
find the command to invoke
---
virt-sandbox-image/virt-sandbox-image.py | 25 +
1 file changed, 25 insertions(+)
diff --git a/virt-sandbox-image/virt-sandbox-image.py
Refactor download function from virt-sandbox-image to use
the newly introduced Source abstract class. The docker-specific
download code is moved to a new DockerSource class.
---
virt-sandbox-image/Makefile.am | 1 +
virt-sandbox-image/sources/DockerSource.py | 214
Move the docker-related code to the DockerSource and use
the Source mechanism
---
virt-sandbox-image/sources/DockerSource.py | 100 +
virt-sandbox-image/sources/Source.py | 4 ++
virt-sandbox-image/virt-sandbox-image.py | 76 +-
3 files
These helper functions are for selecting right directories according
to running user privileges
---
virt-sandbox-image/virt-sandbox-image.py | 27 ++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/virt-sandbox-image/virt-sandbox-image.py
Virt-sandbox-image will pass exact network arguments to virt-sandbox
---
virt-sandbox-image/virt-sandbox-image.py | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/virt-sandbox-image/virt-sandbox-image.py
b/virt-sandbox-image/virt-sandbox-image.py
index
Volumes let user to map host-paths into guest. Docker containers need volumes
because its
filesystem read-only by default.
---
virt-sandbox-image/sources/DockerSource.py | 12
virt-sandbox-image/sources/Source.py | 4
virt-sandbox-image/virt-sandbox-image.py | 22
Add the config gobject to store custom environment variables.
This will allow creating custom environment variables on a sandbox
with a parameter formatted like --env key1=val1
---
libvirt-sandbox/Makefile.am | 2 +
libvirt-sandbox/libvirt-sandbox-config-all.h | 1 +
Provide a way to know which disk image to use for the sandbox depending on the
used source
DockerSource will need to locate the topmost disk image among all the layers
images
---
virt-sandbox-image/sources/DockerSource.py | 18 ++
virt-sandbox-image/sources/Source.py | 4
Authentication fix for Docker REST API.
---
virt-sandbox-image/virt-sandbox-image.py | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/virt-sandbox-image/virt-sandbox-image.py
b/virt-sandbox-image/virt-sandbox-image.py
index 4f5443b..a9cb0ff 100644
---
From: Daniel P Berrange berra...@redhat.com
virt-sandbox-image.py is a python script that lets you download Docker
images easily. It is a proof of concept code and consumes Docker Rest API.
---
po/POTFILES.in | 1 +
virt-sandbox-image/virt-sandbox-image.py | 394
Common-init reads config file and export custom environment
variables from config file and apply them to the running sandbox.
---
libvirt-sandbox/libvirt-sandbox-init-common.c | 30 +++
1 file changed, 30 insertions(+)
diff --git
Any custom source provider can be added to virt-sandbox-image as a source
---
.gitignore | 1 +
bin/Makefile.am | 16
bin/virt-sandbox-image.in| 3 +++
configure.ac | 2 ++
Conflicts:
virt-sandbox-image/virt-sandbox-image.py
---
virt-sandbox-image/virt-sandbox-image.py | 8
1 file changed, 8 insertions(+)
diff --git a/virt-sandbox-image/virt-sandbox-image.py
b/virt-sandbox-image/virt-sandbox-image.py
index fa9e1c8..55aea6a 100755
---
---
virt-sandbox-image/virt-sandbox-image.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/virt-sandbox-image/virt-sandbox-image.py
b/virt-sandbox-image/virt-sandbox-image.py
index 55aea6a..9e98bf2 100755
--- a/virt-sandbox-image/virt-sandbox-image.py
+++
Any custom key=value pair can be used as a custom environment variable
in virt-sandbox-image.
e.g virt-sandbox-image run ubuntu /var/lib/libvirt/templates -c lxc:/// -i
/bin/bash -e key1=val1
---
virt-sandbox-image/sources/DockerSource.py | 10 ++
virt-sandbox-image/sources/Source.py
Check if user-specified connect argument is valid
---
virt-sandbox-image/virt-sandbox-image.py | 6 ++
1 file changed, 6 insertions(+)
diff --git a/virt-sandbox-image/virt-sandbox-image.py
b/virt-sandbox-image/virt-sandbox-image.py
index d6b682f..c46abd4 100755
---
Allow users to add custom environment variables to their sandbox.
---
bin/virt-sandbox.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c
index 195515f..e90b698 100644
--- a/bin/virt-sandbox.c
+++ b/bin/virt-sandbox.c
@@ -64,6 +64,7 @@
Refactoring delete function from virt-sandbox-image to DockerSource. Delete
function
can delete templates by name.
---
virt-sandbox-image/sources/DockerSource.py | 53 +++
virt-sandbox-image/sources/Source.py | 4 +++
virt-sandbox-image/virt-sandbox-image.py | 58
Provide a way to know how a template can be started depending on the used source
DockerSource will need to parse the topmost config file in order to find the
igniter command
---
virt-sandbox-image/sources/DockerSource.py | 14 ++
virt-sandbox-image/sources/Source.py | 4
Fix the name inconsistency between func comments and parameter
of virConfGetValue/virConfSetValue
Signed-off-by: Cao jin caoj.f...@cn.fujitsu.com
---
src/util/virconf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/virconf.c b/src/util/virconf.c
index
On 17/08/15 11:56, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1254152
When we use some virsh cmd which need specify domain
name/id/uuid, if the command get failure we will get error
like this:
# virsh domif-setlink 123 vnet1 up
error: interface (target: vnet1) not
On 08/03/2015 10:50 AM, Martin Kletzander wrote:
Since now they were not needed, but I sense they will be in a short
while.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/libvirt_private.syms | 5 +
src/util/vircgroup.c | 277
On 14.08.2015 08:59, Luyao Huang wrote:
Just like commit 704cf06, the error already will be set in
virCgroup* function, and virCgroupAddTask will return -1,
so We will always report error Operation not permitted
in this place.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
Reworded the
On 13.08.2015 17:00, John Ferlan wrote:
As a result of the review of a related issue for virDomainAddIOThread
it was noted that it's only our implementation for qemu that doesn't
want an iothread_id == 0, see:
http://www.redhat.com/archives/libvir-list/2015-August/msg00310.html
On 08/03/2015 10:50 AM, Martin Kletzander wrote:
We were blindly setting blkiotune values for devices, but kernel can
throw some of them away. This series reworks the logic the same
wayother tuning values are updated. That is, after the value gets
set, it is read back again to make sure
On 08/14/2015 02:59 AM, Luyao Huang wrote:
Just like commit 704cf06, the error already will be set in
virCgroup* function, and virCgroupAddTask will return -1,
so We will always report error Operation not permitted
in this place.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
Well, yet again one case of 'goto cleanup' while 'goto endjob'
was needed. Sorry.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
Pushed as trivial.
src/qemu/qemu_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c
On 08/12/2015 09:53 PM, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1253107
Update the weight in vm def to fix this.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_driver.c | 2 ++
1 file changed, 2 insertions(+)
Considering the series I recently
On Tue, Aug 18, 2015 at 03:35:11PM +0530, Nikunj A Dadhania wrote:
libvirt enforces at least one NUMA node for memory hotplug support on
all architectures. While it might be required for some x86 guest,
PowerPC can hotplug memory on non-NUMA system.
The generic checks are replaced with arch
On 18.08.2015 14:38, Cao jin wrote:
Fix the name inconsistency between func comments and parameter
of virConfGetValue/virConfSetValue
Signed-off-by: Cao jin caoj.f...@cn.fujitsu.com
---
src/util/virconf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
ACKed and pushed.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_driver.c | 16
1 file changed, 16 insertions(+)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 99a3817ff5ab..16061a51d4a7 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
Signed-off-by: Tomas Meszaros e...@tty.sk
---
src/libvirt-domain.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 5c8bf2b..60e0def 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -8783,6 +8783,11 @@
On 08/19/2015 01:40 AM, John Ferlan wrote:
On 08/14/2015 02:59 AM, Luyao Huang wrote:
Just like commit 704cf06, the error already will be set in
virCgroup* function, and virCgroupAddTask will return -1,
so We will always report error Operation not permitted
in this place.
Signed-off-by:
On 08/19/2015 02:17 AM, Michal Privoznik wrote:
On 14.08.2015 08:59, Luyao Huang wrote:
Just like commit 704cf06, the error already will be set in
virCgroup* function, and virCgroupAddTask will return -1,
so We will always report error Operation not permitted
in this place.
Signed-off-by:
Fix inconsistency between function description and actual
parameter name.
Signed-off-by: Cao jin caoj.f...@cn.fujitsu.com
---
src/util/virconf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virconf.c b/src/util/virconf.c
index ab98c5c..9f2d116 100644
---
https://bugzilla.redhat.com/show_bug.cgi?id=1253107
Call virCgroupGetBlkioWeight to re-read blkio.weight right
after it are set in order to keep our internal structures
up-to-date.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_driver.c | 3 ++-
1 file changed, 2 insertions(+),
On 08/19/2015 01:32 AM, John Ferlan wrote:
On 08/12/2015 09:53 PM, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1253107
Update the weight in vm def to fix this.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_driver.c | 2 ++
1 file changed, 2
This patch remove the logging of errors of ioctl api and instead
let the caller to choose what errors to log
---
src/util/virnetdev.c | 56 ++---
1 files changed, 16 insertions(+), 40 deletions(-)
diff --git a/src/util/virnetdev.c
This patch introduces qemuTestMakeCapsCache() function, which creates
capability cache containing predefined set of capabilities associated
with predefined binary.
For simplicity of integration binary name is deduced from test name,
which follows a simple scheme of being prefixed with
While the check is appropriate for eg. the x86 and generic drivers,
there are some valid ppc64 guest configurations where the CPU
model is supposed to be NULL.
Moving this check from the generic code to the drivers makes it
possible to accomodate both use cases.
Resolves:
Not all combinations of host CPU models and compatibility modes
are valid, so we need to make sure we don't try to do something
that QEMU will reject.
Moreover, we need to apply a different logic to guests using
host-model and host-passthrough modes when testing them for host
compatibility.
If a guest CPU is defined using
cpu mode='host-model'/
the model sub-element will contain the compatibility mode to use.
That means we can't just copy the host CPU model on cpuUpdate(),
otherwise we'll overwrite that information and migration of such
guests will fail.
Resolves:
Hi Michal
On 08/19/2015 01:51 AM, Michal Privoznik wrote:
On 18.08.2015 14:38, Cao jin wrote:
Fix the name inconsistency between func comments and parameter
of virConfGetValue/virConfSetValue
Signed-off-by: Cao jin caoj.f...@cn.fujitsu.com
---
src/util/virconf.c | 4 ++--
1 file changed, 2
This series fixes an issue that prevented save / restore from
working when using compatibility modes; it also introduces
some new checks to make sure the requested compability
configuration is actually supported and a few test cases.
Cheers.
Andrea Bolognani (4):
cpu: Don't update host-model
---
tests/cputest.c| 14 ++
tests/cputestdata/ppc64-guest-compat-incompatible.xml | 3 +++
tests/cputestdata/ppc64-guest-compat-invalid.xml | 3 +++
tests/cputestdata/ppc64-guest-compat-none.xml | 1 +
On 08/12/2015 05:27 PM, John Ferlan wrote:
Since iothreadid = 0 is invalid, we need to check for it when attempting
to add a disk; otherwise, someone would think/believe their attempt to
add an IOThread to the disk would succeed. Luckily other code ignored
things when -iothread == 0...
On Tue, Aug 18, 2015 at 01:15:43PM -0400, John Ferlan wrote:
On 08/03/2015 10:50 AM, Martin Kletzander wrote:
Since now they were not needed, but I sense they will be in a short
while.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/libvirt_private.syms | 5 +
On 08/18/2015 08:56 PM, Erik Skultety wrote:
On 17/08/15 11:56, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1254152
When we use some virsh cmd which need specify domain
name/id/uuid, if the command get failure we will get error
like this:
# virsh domif-setlink 123 vnet1
David Gibson da...@gibson.dropbear.id.au writes:
On Tue, Aug 18, 2015 at 03:35:11PM +0530, Nikunj A Dadhania wrote:
libvirt enforces at least one NUMA node for memory hotplug support on
all architectures. While it might be required for some x86 guest,
PowerPC can hotplug memory on non-NUMA
62 matches
Mail list logo
