[libvirt] [PATCH 1/2] daemon: Use $(NULL) for libvird_admin's flags

2015-08-19 Thread Guido Günther
This makes it consistent with the other FLAGS in this file and reduced clutter in the diff when adding new entries. --- daemon/Makefile.am | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index 59bc4d4..be1b5a9 100644 ---

[libvirt] [PATCH 2/2] libvirt-admin: Generate symbols file

2015-08-19 Thread Guido Günther
Since we're linking this into libvirtd we need some symbols to be public but not part of the public API so mark them as LIBVIRT_ADMIN_PRIVATE_VERSION as we do with libvirt. Making all other symbols local makes sure we don't accidentally leak unwanted ones. --- configure.ac | 2

Re: [libvirt] [PATCH] util: Remove empty resource partition created by libvirt

2015-08-19 Thread Nikunj A Dadhania
Daniel P. Berrange berra...@redhat.com writes: On Wed, Aug 12, 2015 at 11:09:12AM +0530, Nikunj A Dadhania wrote: Hi Daniel, Daniel P. Berrange berra...@redhat.com writes: On Tue, Aug 11, 2015 at 04:57:15PM +0530, Nikunj A Dadhania wrote: The default resource partition is created in

[libvirt] [PATCH] docs: Drop unused rule for internals/%.html.tmp target

2015-08-19 Thread Guido Günther
We're using the %.html.tmp for all html files now so drop the unused one and rather make sure the needed directory exists. This fixes build failures as described in https://www.redhat.com/archives/libvir-list/2015-August/msg00603.html --- configure.ac | 1 + docs/Makefile.am | 9

Re: [libvirt] [PATCH] virConfWalk: fix the inconsistent name

2015-08-19 Thread Michal Privoznik
On 19.08.2015 04:36, Cao jin wrote: Fix inconsistency between function description and actual parameter name. Signed-off-by: Cao jin caoj.f...@cn.fujitsu.com --- src/util/virconf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virconf.c

Re: [libvirt] [libvirt-php PATCH] added missing libvirt 1.2.8 constants

2015-08-19 Thread Michal Privoznik
On 15.08.2015 13:50, Eric Schultz wrote: --- src/libvirt-php.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index f0a2167..8588128 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -1216,6

Re: [libvirt] [PATCH] virconf: correct code format

2015-08-19 Thread Ján Tomko
On Mon, Aug 17, 2015 at 08:42:03PM +0800, Cao jin wrote: Signed-off-by: Cao jin caoj.f...@cn.fujitsu.com --- src/util/virconf.c | 4 ++-- src/util/virconf.h | 33 - 2 files changed, 18 insertions(+), 19 deletions(-) ACK and pushed. Jan signature.asc

[libvirt] [virtio-pci] unbind port from virtio-pci causes kernel crash

2015-08-19 Thread Clarylin L
I am running kvm based virtual guest. The guest has two virtio-based ports. Now I am trying to unbind ports from their current drivers (by echo :00:06.0 /sys/bus/pci/drivers/virtio-pci/unbind) and getting kernel crash. Don't know how to move forward. Any suggestions are highly appreciated. [

Re: [libvirt] [PATCH v3] lxc: Inherit namespace feature

2015-08-19 Thread Michal Privoznik
On 14.08.2015 14:09, Daniel P. Berrange wrote: From: Imran Khan ik.n...@gmail.com This patch adds feature for lxc containers to inherit namespaces. This is very similar to what lxc-tools or docker provides. Look for man lxc-start and you will find that you can pass command args as [

Re: [libvirt] [PATCH V2 1/3] libxl: fix ref counting of libxlMigrationDstArgs

2015-08-19 Thread Michal Privoznik
On 07.08.2015 19:53, Jim Fehlig wrote: This patch fixes some flawed logic around ref counting the libxlMigrationDstArgs object. First, when adding sockets to the event loop with virNetSocketAddIOCallback(), the generic virObjectFreeCallback() was registered as a free function, with

Re: [libvirt] [PATCH V2 3/3] libxl: acquire a job when receiving a migrating domain

2015-08-19 Thread Michal Privoznik
On 07.08.2015 19:53, Jim Fehlig wrote: Commit f86ae403 moved acquiring a job from libxlDomainStart() to its callers. One spot missed was in libxlDoMigrateReceive(). Acquire a job in libxlDoMigrateReceive() before calling libxlDomainStart(). Signed-off-by: Jim Fehlig jfeh...@suse.com ---

Re: [libvirt] [PATCH V2 2/3] libxl: don't attempt to resume domain when suspend fails

2015-08-19 Thread Michal Privoznik
On 07.08.2015 19:53, Jim Fehlig wrote: Failure of libxl_domain_suspend() does not leave the domain in a suspended state, so no need to call libxl_domain_resume(), which btw will fail with domain not suspended. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_migration.c | 14

Re: [libvirt] [PATCH 2/2] libvirt-admin: Generate symbols file

2015-08-19 Thread Michal Privoznik
On 19.08.2015 14:39, Guido Günther wrote: Since we're linking this into libvirtd we need some symbols to be public but not part of the public API so mark them as LIBVIRT_ADMIN_PRIVATE_VERSION as we do with libvirt. Making all other symbols local makes sure we don't accidentally leak

Re: [libvirt] [PATCH] docs: Drop unused rule for internals/%.html.tmp target

2015-08-19 Thread Michal Privoznik
On 19.08.2015 14:40, Guido Günther wrote: We're using the %.html.tmp for all html files now so drop the unused one and rather make sure the needed directory exists. This fixes build failures as described in https://www.redhat.com/archives/libvir-list/2015-August/msg00603.html ---

Re: [libvirt] [PATCH] qemu: Report better error message when renaming to existing domain name

2015-08-19 Thread Erik Skultety
On 18/08/15 21:05, Martin Kletzander wrote: Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/qemu/qemu_driver.c | 16 1 file changed, 16 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 99a3817ff5ab..16061a51d4a7 100644 ---