Re: [libvirt] [PATCH] docs: Drop unused rule for internals/%.html.tmp target

2015-08-20 Thread Guido Günther
On Thu, Aug 20, 2015 at 03:12:36AM +0200, Michal Privoznik wrote: On 19.08.2015 14:40, Guido Günther wrote: We're using the %.html.tmp for all html files now so drop the unused one and rather make sure the needed directory exists. This fixes build failures as described in

[libvirt] [PATCH] util: fix build without cgroup

2015-08-20 Thread Roman Bogorodskiy
Commit 89c509a0 added getters for cgroup block device I/O throttling, however stub versions of these functions have not matching function prototypes that result in compilation fail on platforms not supporting cgroup. Fix build by correcting prototypes of the stubbed functions. Pushing under

Re: [libvirt] [PATCH 2/2] libvirt-admin: Generate symbols file

2015-08-20 Thread Guido Günther
On Thu, Aug 20, 2015 at 02:46:18AM +0200, Michal Privoznik wrote: On 19.08.2015 14:39, Guido Günther wrote: Since we're linking this into libvirtd we need some symbols to be public but not part of the public API so mark them as LIBVIRT_ADMIN_PRIVATE_VERSION as we do with libvirt.

[libvirt] libvirt 1.2.16 unable to set link state for ethernet network type

2015-08-20 Thread Vasiliy Tolstov
I can't set link state for network=ethernet, in older versions all works fine. As i see in qemu_hotplug.c: case VIR_DOMAIN_NET_TYPE_ETHERNET: if (STRNEQ_NULLABLE(olddev-data.ethernet.dev, newdev-data.ethernet.dev) || olddev-nips

[libvirt] [PATCH] Add generated libvirt_admin.syms into .gitignore

2015-08-20 Thread Martin Kletzander
Commit a2c5d16a70a6161449c687be74db2813b362cf5e switched to generating libvirt_admin.syms, but forgot to add the generated file into .gitignore, hence causing tree pollution post-build. Signed-off-by: Martin Kletzander mklet...@redhat.com --- Pushed as trivial .gitignore | 1 + 1 file changed,

[libvirt] [PATCH] virt-aa-helper: add NVRAM store file for read/write

2015-08-20 Thread Peter Kieser
Some UEFI firmwares may want to use a non-volatile memory to store some variables. If AppArmor is enabled, and NVRAM store file is set currently virt-aa-helper does not add the NVRAM store file to the template. Add this file for read/write when this functionality is defined in domain XML.

[libvirt] [PATCH v4] lxc: Inherit namespace feature

2015-08-20 Thread ik.nitk
This patch adds feature for lxc containers to inherit namespaces. This is very similar to what lxc-tools or docker provides. Look for man lxc-start and you will find that you can pass command args as [ --share-[net|ipc|uts] name|pid ]. Or check out docker networking option in which you can give

Re: [libvirt] [PATCH] conf: Check for attach disk usage of iothread=0

2015-08-20 Thread Martin Kletzander
On Wed, Aug 12, 2015 at 05:27:48PM -0400, John Ferlan wrote: Since iothreadid = 0 is invalid, we need to check for it when attempting to add a disk; otherwise, someone would think/believe their attempt to add an IOThread to the disk would succeed. Luckily other code ignored things when -iothread

[libvirt] syntax-check Argument list too long problems

2015-08-20 Thread Roman Bogorodskiy
Hi, Not so long ago I've started encountering issues with syntax-check, for example: trailing_blank /bin/sh: grep: Argument list too long When I'm running it with SHELL='sh -x' I can see that it's indeed trying to run grep with really long list of files, e.g.: + grep -nE '\error

Re: [libvirt] syntax-check Argument list too long problems

2015-08-20 Thread Eric Blake
[adding bug-gnulib] On 08/20/2015 08:30 AM, Roman Bogorodskiy wrote: Hi, Not so long ago I've started encountering issues with syntax-check, for example: trailing_blank /bin/sh: grep: Argument list too long When I'm running it with SHELL='sh -x' I can see that it's indeed trying to

Re: [libvirt] syntax-check Argument list too long problems

2015-08-20 Thread Martin Kletzander
On Thu, Aug 20, 2015 at 06:30:12PM +0300, Roman Bogorodskiy wrote: Hi, Not so long ago I've started encountering issues with syntax-check, for example: trailing_blank /bin/sh: grep: Argument list too long When I'm running it with SHELL='sh -x' I can see that it's indeed trying to run grep