Re: [libvirt] [PATCH libvirt master v2] interface type: add udp socket support

2015-08-31 Thread Guido Günther
Hi, On Mon, Aug 31, 2015 at 04:06:18PM -0400, Jonathan Toppins wrote: > On 08/31/2015 03:25 PM, Guido Günther wrote: > >Hi, > >On Sat, Aug 29, 2015 at 04:19:10PM -0400, Jonathan Toppins wrote: > >>Adds a new interface type using UDP sockets, this seems only applicable > >>to QEMU but have edited tr

Re: [libvirt] [PATCH libvirt master v2] interface type: add udp socket support

2015-08-31 Thread Jonathan Toppins
On 08/31/2015 03:25 PM, Guido Günther wrote: Hi, On Sat, Aug 29, 2015 at 04:19:10PM -0400, Jonathan Toppins wrote: Adds a new interface type using UDP sockets, this seems only applicable to QEMU but have edited tree-wide to support the new interface type. The interface type required the additio

Re: [libvirt] [PATCH 0/3] Couple of src/Makefile.am fixes

2015-08-31 Thread Guido Günther
On Mon, Aug 31, 2015 at 12:51:14PM +0200, Michal Privoznik wrote: > I've noticed that 'make distcheck' is failing. While investigating that issue > I've came up with some other checks too. > > Preferably, I'd like to get these into the current release (the fix 2/3 at > least). > > Michal Privozn

Re: [libvirt] [PATCH libvirt master v2] interface type: add udp socket support

2015-08-31 Thread Guido Günther
Hi, On Sat, Aug 29, 2015 at 04:19:10PM -0400, Jonathan Toppins wrote: > Adds a new interface type using UDP sockets, this seems only applicable > to QEMU but have edited tree-wide to support the new interface type. > > The interface type required the addition of a "localaddr" (local > address), th

[libvirt] [PATCH] qemu: Need to check for machine.os when using ADDRESS_TYPE_CCW

2015-08-31 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1258361 When attaching a disk or rng when providing an address type ccw, we need to ensure the machine.os is valid for the target guest. Checks are made when the address type is not provided, but if provided the os.machine check is bypassed. For an inac

Re: [libvirt] [PATCH] docs: Drop unused rule for internals/%.html.tmp target

2015-08-31 Thread Guido Günther
On Mon, Aug 31, 2015 at 05:22:23PM +0200, Martin Kletzander wrote: > On Thu, Aug 20, 2015 at 10:50:54AM +0200, Guido Günther wrote: > >On Thu, Aug 20, 2015 at 03:12:36AM +0200, Michal Privoznik wrote: > >>On 19.08.2015 14:40, Guido Günther wrote: > >>> We're using the %.html.tmp for all html files

Re: [libvirt] [PATCH] domain-conf: escape string for socket attribute

2015-08-31 Thread Martin Kletzander
On Mon, Aug 31, 2015 at 03:37:01PM +0200, Pavel Hrdina wrote: Commit d091518b tried to escape all strings in produced XML, but missed this one. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/

Re: [libvirt] [PATCH] docs: Drop unused rule for internals/%.html.tmp target

2015-08-31 Thread Martin Kletzander
On Thu, Aug 20, 2015 at 10:50:54AM +0200, Guido Günther wrote: On Thu, Aug 20, 2015 at 03:12:36AM +0200, Michal Privoznik wrote: On 19.08.2015 14:40, Guido Günther wrote: > We're using the %.html.tmp for all html files now so drop the unused one > and rather make sure the needed directory exists

Re: [libvirt] [Qemu-devel] [PATCH] target-i386: Enable "check" mode by default

2015-08-31 Thread Eduardo Habkost
On Mon, Aug 31, 2015 at 02:20:54PM +0200, Igor Mammedov wrote: > On Wed, 26 Aug 2015 13:50:25 -0300 > Eduardo Habkost wrote: > > Current default behavior of QEMU is to silently disable features that > > are not supported by the host when a CPU model is requested in the > > command-line. This means

[libvirt] [PATCH] domain-conf: escape string for socket attribute

2015-08-31 Thread Pavel Hrdina
Commit d091518b tried to escape all strings in produced XML, but missed this one. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c5e9653..56f9460 100644 --- a/src

Re: [libvirt] [PATCH 0/3] Couple of src/Makefile.am fixes

2015-08-31 Thread Pavel Hrdina
On Mon, Aug 31, 2015 at 12:51:14PM +0200, Michal Privoznik wrote: > I've noticed that 'make distcheck' is failing. While investigating that issue > I've came up with some other checks too. > > Preferably, I'd like to get these into the current release (the fix 2/3 at > least). > > Michal Privozni

[libvirt] [PATCH] qemu: Default to virtio network devices on ppc64

2015-08-31 Thread Andrea Bolognani
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1254044 --- src/qemu/qemu_domain.c | 3 ++- .../qemuxml2argvdata/qemuxml2argv-pseries-net-default.args | 6 ++ .../qemuxml2argvdata/qemuxml2argv-pseries-net-default.xml | 14 ++ tests/qemux

Re: [libvirt] [Qemu-devel] [PATCH] target-i386: Enable "check" mode by default

2015-08-31 Thread Igor Mammedov
On Wed, 26 Aug 2015 13:50:25 -0300 Eduardo Habkost wrote: > Current default behavior of QEMU is to silently disable features that > are not supported by the host when a CPU model is requested in the > command-line. This means that in addition to risking breaking guest ABI > by default, we are sil

Re: [libvirt] [PATCH libvirt master v2] interface type: add udp socket support

2015-08-31 Thread Stanley Karunditu
>From my testing, the v2 patch works. I can create a new interface with the udp tunnel interface in a fresh domain configuration, or use virsh attach-device to add a new udp tunnel interface to an existing domain config. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mai

[libvirt] [PATCH 2/3] src: Cleanup libvirt_admin.syms

2015-08-31 Thread Michal Privoznik
It's a generated file, so after 'distclean' it should be gone. But it isn't yet. Signed-off-by: Michal Privoznik --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 186006e..90292d0 100644 --- a/src/Makefile.am +++ b/src

[libvirt] [PATCH 3/3] src: Check for symbols ordering in ADMIN_SYM_FILES

2015-08-31 Thread Michal Privoznik
Like we are checking for the correct order in SYM_FILES, we should do the same for ADMIN_SYM_FILES. Signed-off-by: Michal Privoznik --- src/Makefile.am | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 90292d0..4291375 100644 --- a/sr

[libvirt] [PATCH 1/3] src: Check libvirt_admin.syms for exported symbols

2015-08-31 Thread Michal Privoznik
We have this check rule in src/Makefile: check-symfile that should check if all symbols we wanted to export are exported. Moreover, if we are not exporting something more. Do the same with libvirt_admin.syms. Signed-off-by: Michal Privoznik --- src/Makefile.am | 6 +- 1 file changed, 5 inser

[libvirt] [PATCH 0/3] Couple of src/Makefile.am fixes

2015-08-31 Thread Michal Privoznik
I've noticed that 'make distcheck' is failing. While investigating that issue I've came up with some other checks too. Preferably, I'd like to get these into the current release (the fix 2/3 at least). Michal Privoznik (3): src: Check libvirt_admin.syms for exported symbols src: Cleanup libvi

Re: [libvirt] [PATCH] migration: remove direct migration dependency on version1 of driver

2015-08-31 Thread Nikolay Shirokovskiy
On 31.08.2015 12:05, Michal Privoznik wrote: > On 31.08.2015 10:42, Nikolay Shirokovskiy wrote: >> >> >> On 28.08.2015 19:04, Michal Privoznik wrote: >>> On 28.08.2015 11:29, Nikolay Shirokovskiy wrote: On 28.08.2015 08:54, Michal Privoznik wrote: > On 27.08.2015 12:23, Nikolay

Re: [libvirt] [PATCH] virsh: Enhance the detailed output of domblklist for networked source

2015-08-31 Thread Vasiliy Tolstov
2015-08-31 6:13 GMT+03:00 Lin Ma : > Format & Output more detailed information about networked source > > e.g: The output without the patch: > $ virsh domblklist $DOMAIN --details > Type Device Target Source > > networkdisk vd

Re: [libvirt] [PATCH] migration: remove direct migration dependency on version1 of driver

2015-08-31 Thread Michal Privoznik
On 31.08.2015 10:42, Nikolay Shirokovskiy wrote: > > > On 28.08.2015 19:04, Michal Privoznik wrote: >> On 28.08.2015 11:29, Nikolay Shirokovskiy wrote: >>> >>> >>> On 28.08.2015 08:54, Michal Privoznik wrote: On 27.08.2015 12:23, Nikolay Shirokovskiy wrote: > From: Nikolay Shirokovskiy >

Re: [libvirt] [PATCH v3 2/5] vz: add migration backbone code

2015-08-31 Thread Nikolay Shirokovskiy
On 28.08.2015 19:37, Daniel P. Berrange wrote: > On Fri, Aug 28, 2015 at 12:18:30PM +0300, Nikolay Shirokovskiy wrote: >> >> >> On 27.08.2015 13:34, Daniel P. Berrange wrote: >>> On Tue, Aug 25, 2015 at 12:04:14PM +0300, nshirokovs...@virtuozzo.com wrote: From: Nikolay Shirokovskiy >>>

Re: [libvirt] [PATCH] migration: remove direct migration dependency on version1 of driver

2015-08-31 Thread Nikolay Shirokovskiy
On 28.08.2015 19:04, Michal Privoznik wrote: > On 28.08.2015 11:29, Nikolay Shirokovskiy wrote: >> >> >> On 28.08.2015 08:54, Michal Privoznik wrote: >>> On 27.08.2015 12:23, Nikolay Shirokovskiy wrote: From: Nikolay Shirokovskiy >>> nshirokovs...@virtuozzo.com> Direct migration sh