[libvirt] [PATCH v2] domain-conf: escape string for socket attribute

Commit d091518b tried to escape all strings in produced XML, but missed this one. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

Re: [libvirt] [PATCH] remoteClientCloseFunc: Don't mangle connection object refcount

On Thu, Sep 03, 2015 at 12:31:46PM +0200, Michal Privoznik wrote: > Well, in 8ad126e6 we tried to fix a memory corruption problem. > However, the fix was not as good as it could be. I mean, the > commit has one line more than it should. I've noticed this output > just recently: > > # ./run

Re: [libvirt] [PATCH] domain-conf: escape string for socket attribute

On Mon, Aug 31, 2015 at 05:25:35PM +0200, Martin Kletzander wrote: > On Mon, Aug 31, 2015 at 03:37:01PM +0200, Pavel Hrdina wrote: > >Commit d091518b tried to escape all strings in produced XML, but missed > >this one. > > > >Signed-off-by: Pavel Hrdina > >--- > >

Re: [libvirt] [PATCH v4 1/6] vz: save session uuid on login

On Wed, Sep 02, 2015 at 03:09:22PM +0300, Nikolay Shirokovskiy wrote: > This session uuid acts as authN token for different multihost vz operations > one > of which is migration. Unfortunately we can't get it from server at any time > thus we need to save it at login. > > Signed-off-by: Nikolay

Re: [libvirt] [PATCH v4 2/6] vz: add migration backbone code

On Wed, Sep 02, 2015 at 03:09:23PM +0300, Nikolay Shirokovskiy wrote: > From: nshirokovs...@virtuozzo.com > > This patch makes basic vz migration possible. For example by virsh: > > virsh -c vz:///system migrate $NAME vz+ssh://$DST/system --p2p > > Vz migration is

[libvirt] [PATCH v2 1/2] qemu: Introduce qemuDomainMachineIsS390CCW

Rather than have different usages of STR function in order to determine whether the domain is s390-ccw or s390-ccw-virtio, make a single API which will check the machine.os prefix. Then use the function. Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 4 ++--

[libvirt] [PATCH v2 2/2] qemu: Need to check for machine.os when using ADDRESS_TYPE_CCW

https://bugzilla.redhat.com/show_bug.cgi?id=1258361 When attaching a disk, controller, or rng using an address type ccw or s390, we need to ensure the support is provided by both the machine.os and the emulator capabilities (corollary to unconditional setting when address was not provided for the

[libvirt] [PATCH v2 0/2] Need to perform address checks for ccw/s390

Assumptions were made that if someone provided an address type ccw or s390 that it would occur only if using an enabled emulator. Turns out that premise isn't necessarily true and it leads to libvirtd crashing for hotplugs and qemu start errors for config paths. These patches will make the

Re: [libvirt] [sandbox] Add ext4 module to QEMU initrd

On Thu, Sep 03, 2015 at 05:57:57PM +0200, Cédric Bosdonnat wrote: > Some distros don't have ext4 built in their kernel, but as a module. > Make sure the ext4 module is loaded or we will fail loading root > host-images on those distros. > --- > libvirt-sandbox/libvirt-sandbox-builder-machine.c | 7

Re: [libvirt] [PATCH] libxl: report correct errno from virNetSocketNewConnectTCP on migration

On 09/03/2015 10:26 AM, Jim Fehlig wrote: Agreed. How about the following patch? >From a30c493bd9e20c9a7a423789a202c444a5eba344 Mon Sep 17 00:00:00 2001 From: Jim Fehlig Date: Thu, 3 Sep 2015 10:14:20 -0600 Subject: [PATCH] libxl: don't overwrite error from

Re: [libvirt] Release of libvirt-1.2.19

On 09/01/2015 11:18 PM, Daniel Veillard wrote: Features: - Big improvements on ppc64 support (Andrea Bolognani) - New virDomainRename API (Tomas Meszaros) - Support for QEMU new pci emulations (Laine Stump) Uh, that would be "PCI Express controllers" :-) -- libvir-list mailing list

Re: [libvirt] [PATCH] libxl: report correct errno from virNetSocketNewConnectTCP on migration

On 09/03/2015 06:58 AM, Michal Privoznik wrote: On 03.09.2015 12:14, Ian Campbell wrote: saved_errno is never written to in this function after it is initialised and it is only used to log the failure from virNetSocketNewConnectTCP masking the real errno from that function. Drop saved_errno

[libvirt] [PATCH V2] libxl: don't overwrite error from virNetSocketNewConnectTCP()

Remove redundant error reporting in libxlDomainMigrationPerform(). virNetSocketNewConnectTCP() is perfectly capable of reporting sensible errors. Signed-off-by: Jim Fehlig --- V2: Actually try to compile the code and find saved_errno is no longer used - remove it.

[libvirt] [sandbox] Add ext4 module to QEMU initrd

Some distros don't have ext4 built in their kernel, but as a module. Make sure the ext4 module is loaded or we will fail loading root host-images on those distros. --- libvirt-sandbox/libvirt-sandbox-builder-machine.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [libvirt] [PATCH] libxl: report correct errno from virNetSocketNewConnectTCP on migration

On Thu, 2015-09-03 at 10:26 -0600, Jim Fehlig wrote: > From a30c493bd9e20c9a7a423789a202c444a5eba344 Mon Sep 17 00:00:00 2001 > From: Jim Fehlig > Date: Thu, 3 Sep 2015 10:14:20 -0600 > Subject: [PATCH] libxl: don't overwrite error from > virNetSocketNewConnectTCP() > > Remove

Re: [libvirt] [PATCH v4 5/6] vz: support misc migration options

On Wed, Sep 02, 2015 at 03:09:26PM +0300, Nikolay Shirokovskiy wrote: > From: nshirokovs...@virtuozzo.com > > Migration API has a lot of options. This patch intention is to provide > support for those options that can be trivially supported and give > estimation for

Re: [libvirt] [PATCH] libxl: report correct errno from virNetSocketNewConnectTCP on migration

On 09/03/2015 10:26 AM, Jim Fehlig wrote: Agreed. How about the following patch? >From a30c493bd9e20c9a7a423789a202c444a5eba344 Mon Sep 17 00:00:00 2001 From: Jim Fehlig Date: Thu, 3 Sep 2015 10:14:20 -0600 Subject: [PATCH] libxl: don't overwrite error from

Re: [libvirt] [PATCH v2] domain-conf: escape string for socket attribute

On Thu, Sep 03, 2015 at 05:42:37PM +0200, Pavel Hrdina wrote: Commit d091518b tried to escape all strings in produced XML, but missed this one. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [libvirt] [PATCH v4 4/6] vz: support migration uri

On Wed, Sep 02, 2015 at 03:09:25PM +0300, Nikolay Shirokovskiy wrote: > Signed-off-by: Nikolay Shirokovskiy > --- > src/vz/vz_driver.c | 58 --- > 1 files changed, 54 insertions(+), 4 deletions(-) This should really

Re: [libvirt] [PATCH v2 2/2] virsh: Enhance the detailed output of domblklist for networked source

On 09/02/2015 11:58 AM, Michal Privoznik wrote: > From: Lin Ma > > Format & output more detailed information about networked source > > e.g: The output without the patch: > $ virsh domblklist $DOMAIN --details > Type Device Target Source >

Re: [libvirt] [PATCH V2] libxl: don't overwrite error from virNetSocketNewConnectTCP()

On 09/03/2015 01:40 PM, Jim Fehlig wrote: > Remove redundant error reporting in libxlDomainMigrationPerform(). > virNetSocketNewConnectTCP() is perfectly capable of reporting > sensible errors. > > Signed-off-by: Jim Fehlig > --- > > V2: > Actually try to compile the code

Re: [libvirt] [PATCH v2 2/2] qemu: Default to virtio-net where available

On Wed, 2015-09-02 at 16:08 -0400, Laine Stump wrote: > >* change the default for all architectures (except arm) > > instead of just ppc64 > > Are we certain we want to do this even for x86 guests? I don't think > it's a good idea - it makes the default into something for which no >

Re: [libvirt] [PATCH v2 2/2] qemu: Default to virtio-net where available

On Thu, 2015-09-03 at 09:53 +0100, Daniel P. Berrange wrote: > I think we should just do nothing. If people/apps care about optimal > defaults, nothing libvirt changes will make them happy. Apps need to > be just using libosinfo to get the sensible defaults on a per OS > basis. This is not about

Re: [libvirt] [PATCH v2 6/9] admin: Move admin_server.{h, c} to admin.{h, c}

On Fri, Aug 21, 2015 at 08:04:07PM +0200, Erik Skultety wrote: This change is merely because admin_server would contain all the code from dispatchers and helpers to the actual APIs. Admin should have similar structure to the daemon-side remote driver - dispatchers and helpers in a separate

Re: [libvirt] [PATCH v2 2/2] qemu: Default to virtio-net where available

On Thu, Sep 03, 2015 at 11:12:23AM +0200, Andrea Bolognani wrote: > On Thu, 2015-09-03 at 09:53 +0100, Daniel P. Berrange wrote: > > I think we should just do nothing. If people/apps care about optimal > > defaults, nothing libvirt changes will make them happy. Apps need to > > be just using

Re: [libvirt] [PATCH v2 7/9] admin: Introduce virAdmServer structure

On Fri, Aug 21, 2015 at 08:04:08PM +0200, Erik Skultety wrote: This is the key structure of all management operations performed on the daemon/clients. An admin client needs to be able to identify another client (either admin or non-privileged client) to perform an action on it. This

Re: [libvirt] [PATCH v2 2/2] qemu: Default to virtio-net where available

On Thu, Sep 03, 2015 at 10:48:58AM +0200, Andrea Bolognani wrote: > On Wed, 2015-09-02 at 16:08 -0400, Laine Stump wrote: > > >* change the default for all architectures (except arm) > > > instead of just ppc64 > > > > Are we certain we want to do this even for x86 guests? I don't think

Re: [libvirt] [PATCH v2 2/2] qemu: Default to virtio-net where available

On Wed, Sep 02, 2015 at 04:08:52PM -0400, Laine Stump wrote: > On 09/02/2015 12:14 PM, Andrea Bolognani wrote: > >This applies to all architectures except for ARM, which already > >has its own logic to pick the best default. > > > >Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1254044 >

Re: [libvirt] [PATCH v2 2/2] qemu: Default to virtio-net where available

On Thu, Sep 03, 2015 at 09:53:26AM +0100, Daniel P. Berrange wrote: On Thu, Sep 03, 2015 at 10:48:58AM +0200, Andrea Bolognani wrote: On Wed, 2015-09-02 at 16:08 -0400, Laine Stump wrote: > >* change the default for all architectures (except arm) > > instead of just ppc64 > > Are we

Re: [libvirt] [RFC PATCH 0/3] Implement mockup capabilities cache in QEMU tests

Hello! > The current xmlopt structure has two callbacks in parser > configuration, one for post-parsing of the whole domain XML and one > for device XML. We could add new (optional) callback in this > structure that would be called before other post-parse callbacks, but > still after the xml is

Re: [libvirt] [PATCH v2 2/2] qemu: Default to virtio-net where available

On Thu, Sep 03, 2015 at 09:36:47AM +0100, Daniel P. Berrange wrote: > On Wed, Sep 02, 2015 at 04:08:52PM -0400, Laine Stump wrote: > > On 09/02/2015 12:14 PM, Andrea Bolognani wrote: > > >This applies to all architectures except for ARM, which already > > >has its own logic to pick the best

[libvirt] [PATCH v2] lxc: fuse mount for /proc/cpuinfo

We already have a fuse mount to reflect the cgroup memory restrictions in the container. This commit adds the same for the number of available CPUs. Only the CPUs listed by virProcessGetAffinity are shown in the container's cpuinfo. --- src/lxc/lxc_container.c | 42 ---

Re: [libvirt] [PATCH v2 7/9] admin: Introduce virAdmServer structure

On Thu, Sep 03, 2015 at 11:26:06AM +0200, Martin Kletzander wrote: > On Fri, Aug 21, 2015 at 08:04:08PM +0200, Erik Skultety wrote: > >This is the key structure of all management operations performed on the > >daemon/clients. An admin client needs to be able to identify > >another client (either

Re: [libvirt] [PATCH v2 9/9] admin: Usage example of the new server listing API (not to be pushed)

On Fri, Aug 21, 2015 at 08:04:10PM +0200, Erik Skultety wrote: Not to be actually pushed since majority of this example will be merged into virt-admin once it's ready, i.e. virsh splitting series is merged, but might be good to just see the API's working. --- .gitignore | 1 +

Re: [libvirt] [PATCH v2 7/9] admin: Introduce virAdmServer structure

On Thu, Sep 03, 2015 at 11:19:02AM +0100, Daniel P. Berrange wrote: On Thu, Sep 03, 2015 at 11:26:06AM +0200, Martin Kletzander wrote: On Fri, Aug 21, 2015 at 08:04:08PM +0200, Erik Skultety wrote: >This is the key structure of all management operations performed on the >daemon/clients. An

[libvirt] [PATCH] libxl: report correct errno from virNetSocketNewConnectTCP on migration

saved_errno is never written to in this function after it is initialised and it is only used to log the failure from virNetSocketNewConnectTCP masking the real errno from that function. Drop saved_errno and use errno itself. Signed-off-by: Ian Campbell ---

Re: [libvirt] [PATCH v2 8/9] admin: Introduce adminDaemonConnectListServers API

On Fri, Aug 21, 2015 at 08:04:09PM +0200, Erik Skultety wrote: This is the first API to the admin interface. This particular API is a convenience API, i.e. when managing clients connected to daemon's servers, we should know (convenience) which server the specific client is connected to. This

[libvirt] [PATCH] remoteClientCloseFunc: Don't mangle connection object refcount

Well, in 8ad126e6 we tried to fix a memory corruption problem. However, the fix was not as good as it could be. I mean, the commit has one line more than it should. I've noticed this output just recently: # ./run valgrind --leak-check=full --show-reachable=yes ./tools/virsh domblklist gentoo

Re: [libvirt] [PATCH v2 2/2] qemu: Default to virtio-net where available

On Thu, 2015-09-03 at 10:17 +0100, Daniel P. Berrange wrote: > > This happens because we assume rtl8139 will be available, but > > that's not the case eg. on RHEL ppc64. > > Right, but changing upstream to default to virtio, just because RHEL > downstream disabled other devices is not right.

Re: [libvirt] [PATCH libvirt-java] Require at least Java 8

At Wed, 2 Sep 2015 17:38:03 +0200, Wido den Hollander wrote: > > > > > The current code doesn't compile under Java 7, but Java 7 is also EOL. > > > > > > That should not be the case. Can you provide the error messages or > > simply point to the place where Java 8 classes are used? > > >

Re: [libvirt] [PATCHv2 0/2] macvtap: don't use netlink to save/set mac for macvtap+passthrough+802.1Qbh

On 01.09.2015 20:32, Laine Stump wrote: > These two patches are the v2 of a single patch that I sent last > week: > > https://www.redhat.com/archives/libvir-list/2015-August/msg00889.html > > At the time I sent that patch, I had no hardware to test it on, but > was operating on a misunderstood

Re: [libvirt] [PATCH] vshInit: Don't leak @histsize_env

On Thu, Sep 03, 2015 at 02:45:35PM +0200, Michal Privoznik wrote: > Caller is responsible for freeing the result of virStringJoin() > when no longer needed: > > ==10701== 1 bytes in 1 blocks are definitely lost in loss record 1 of 806 > ==10701==at 0x4C29F80: malloc (in >

Re: [libvirt] [RFC PATCH 0/3] Implement mockup capabilities cache in QEMU tests

On Thu, Sep 03, 2015 at 09:51:11AM +0300, Pavel Fedin wrote: Hello! The current xmlopt structure has two callbacks in parser configuration, one for post-parsing of the whole domain XML and one for device XML. We could add new (optional) callback in this structure that would be called before

[libvirt] [PATCH] vshInit: Don't leak @histsize_env

Caller is responsible for freeing the result of virStringJoin() when no longer needed: ==10701== 1 bytes in 1 blocks are definitely lost in loss record 1 of 806 ==10701==at 0x4C29F80: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==10701==by 0xAADB679: strdup (in

[libvirt] [PATCH 3/3] Removed unneeded check

Since test suite now correctly creates capabilities cache, the hack is not needed any more. Signed-off-by: Pavel Fedin --- src/qemu/qemu_domain.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index

[libvirt] [PATCH 0/3] Implement mockup capabilities cache in QEMU tests

Since commit e8d55172544c1fafe31a9e09346bdebca4f0d6f9 qemu driver checks emulator capabilities during domain XML post-parse. However, test suite does not initialize it, therefore a condition to skip all checks if there is no cache supplied was added. This is actually a hack, whose sole purpose is

[libvirt] [PATCH 1/3] Implement infrastracture for mocking up QEMU capabilities cache

The main purpose of this patch is to introduce test mode to virQEMUCapsCacheLookup(). This is done by adding a global variable, which effectively overrides binary name. This variable is supposed to be set by test suite. The second addition is qemuTestCapsCacheInsert() function which allows the

[libvirt] [PATCH 2/3] Use mockup cache

Use the new API in order to correctly add capability sets to the cache before parsing XML files Signed-off-by: Pavel Fedin --- tests/qemuagenttest.c| 18 +- tests/qemuargv2xmltest.c | 19 +-- tests/qemuhotplugtest.c | 32

Re: [libvirt] [PATCH] virsh: Enhance the detailed output of domblklist for networked source

在 2015年09月02日 23:59, Michal Privoznik 写道: On 31.08.2015 05:13, Lin Ma wrote: Format & Output more detailed information about networked source e.g: The output without the patch: $ virsh domblklist $DOMAIN --details Type Device Target Source

Re: [libvirt] [PATCH] libxl: report correct errno from virNetSocketNewConnectTCP on migration

On 03.09.2015 12:14, Ian Campbell wrote: > saved_errno is never written to in this function after it is > initialised and it is only used to log the failure from > virNetSocketNewConnectTCP masking the real errno from that function. > > Drop saved_errno and use errno itself. > > Signed-off-by:

Re: [libvirt] [PATCH v2 2/2] virsh: Enhance the detailed output of domblklist for networked source

在 2015年09月04日 04:47, John Ferlan 写道: On 09/02/2015 11:58 AM, Michal Privoznik wrote: From: Lin Ma Format & output more detailed information about networked source e.g: The output without the patch: $ virsh domblklist $DOMAIN --details Type Device Target Source

Re: [libvirt] [PATCH V2] libxl: don't overwrite error from virNetSocketNewConnectTCP()

On 09/03/2015 02:55 PM, John Ferlan wrote: On 09/03/2015 01:40 PM, Jim Fehlig wrote: Remove redundant error reporting in libxlDomainMigrationPerform(). virNetSocketNewConnectTCP() is perfectly capable of reporting sensible errors. Signed-off-by: Jim Fehlig --- V2: