Re: [libvirt] [libvirt-php] free xml resources in get_string_from_xpath

30 сент. 2015 г. 16:23 пользователь "Michal Privoznik" написал: > > On 30.09.2015 00:23, Vasiliy Tolstov wrote: > > free as much as possible on return from get_string_from_xpath > > > > Signed-off-by: Vasiliy Tolstov > > --- > > src/libvirt-php.c | 13

[libvirt] [PATCH] tests: qemu: Add aarch64 virtio pci tests

- qemuxml2argv-aarch64-mmio-default-pci: Verify that we still default to virtio-mmio even if qemu is new enough to support PCI - qemuxml2argv-aarch64-virtio-pci: Check generated arm virtio PCI args --- .../qemuxml2argv-aarch64-mmio-default-pci.args | 17

Re: [libvirt] [PATCH v2 0/3] Add support for gic-version machine option

On 09/30/2015 07:04 AM, Pavel Fedin wrote: > qemu now supports gic-version option for the virt machine. This patchset > allows to use it in libvirt. > This isn't specifically related to your patch, but I'm curious: Can you explain what this setting actually does? When would apps like

Re: [libvirt] [PATCH v3 02/14] migration: refactor: reuse p2p url check

On 25.09.2015 17:12, Jiri Denemark wrote: > On Fri, Sep 18, 2015 at 18:05:40 +0300, Nikolay Shirokovskiy wrote: >> Refactor dconnuri local server URI check to common API. >> >> Signed-off-by: Nikolay Shirokovskiy >> --- >> src/libvirt-domain.c | 44

[libvirt] Release candidate 2 of libvirt-1.2.20

I have tagged rc2 in git and pushed signed tarball and rpms to the usual place : ftp://libvirt.org/libvirt/ this seems to work fine in my limited testing, but other people need to give it a good try especially on other systems or platforms. Goal is to push the final release on Friday,

Re: [libvirt] [PATCH 3/3] kvm-all: notice KVM of vcpu's TSC rate after migration

On Wed, Sep 30, 2015 at 08:32:26AM +0800, Haozhong Zhang wrote: > > [...] > > > > Or maybe we shouldn't treat this as VM state, but as configuration, and > > > > let management configure the TSC frequency explicitly if the user really > > > > needs it to stay the same during migration. > > > > > >

[libvirt] [PATCH v2 2/3] qemu: Add support for gic-version machine option

Support for GICv3 has been recently introduced in qemu using gic-version option for the 'virt' machine. The option can actually take values of '2', '3' and 'host', however, since in libvirt this is a numeric parameter, we limit it only to 2 and 3. Value of 2 is not added to the command line in

[libvirt] [PATCH v2 3/3] qemu: Add test cases for gic-version option

These tests make sure that we can use this option only when the capability is set. Signed-off-by: Pavel Fedin --- .../qemuxml2argv-aarch64-gicv3.args| 6 + .../qemuxml2argv-aarch64-gicv3.xml | 26 ++

[libvirt] [PATCH v2 0/3] Add support for gic-version machine option

qemu now supports gic-version option for the virt machine. This patchset allows to use it in libvirt. v1 => v2: - Added capability flag Pavel Fedin (3): qemu: Introduce QEMU_CAPS_MACH_VIRT_GIC_VERSION capability qemu: Add support for gic-version machine option qemu: Add test cases for

[libvirt] [PATCH v2 1/3] qemu: Introduce QEMU_CAPS_MACH_VIRT_GIC_VERSION capability

Unfortunately qemu currently doesn't offer introspection for machine types, so we have to rely on version number, similar to QEMU_CAPS_MACHINE_USB_OPT. Signed-off-by: Pavel Fedin --- src/qemu/qemu_capabilities.c | 5 + src/qemu/qemu_capabilities.h | 1 + 2 files

Re: [libvirt] [libvirt-php] free xml resources in get_string_from_xpath

On 30.09.2015 00:23, Vasiliy Tolstov wrote: > free as much as possible on return from get_string_from_xpath > > Signed-off-by: Vasiliy Tolstov > --- > src/libvirt-php.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git

Re: [libvirt] [PATCH v3 09/14] migration: refactor: refactor parameter compatibility checks

On Fri, Sep 18, 2015 at 18:05:47 +0300, Nikolay Shirokovskiy wrote: > Move virDomainMigrateUnmanagedProto* expected params list check into > function itself and use common virTypedParamsCheck for this purpose. > > Signed-off-by: Nikolay Shirokovskiy > --- >

Re: [libvirt] [PATCH] qemuDomainAttachDeviceLive: Check provided disk address

On 09/30/2015 12:43 AM, Martin Kletzander wrote: > On Tue, Sep 29, 2015 at 05:27:58PM -0400, John Ferlan wrote: [...] >> >> NOTE: The change to the test is because the failure now occurs during >> parse rather than at run (e.g. earlier, where I think it should). > > I agree, and this sounds

[libvirt] Cannot write data: Broken pipe when accesing libvirt from a forked process

Hi all, I am trying to add vagrant-libvirt support for landrush plugin[0] and found out that libvirt fails for me with: Call to virConnectNumOfNetworks failed: Cannot write data: Broken pipe (Libvirt::RetrieveError) I created a minimal reproducer that causes this: ``` #!/usr/bin/ruby

Re: [libvirt] [PATCH v3 08/14] migration: refactor: extract parameter adaption functions

On Fri, Sep 18, 2015 at 18:05:46 +0300, Nikolay Shirokovskiy wrote: > Extract parameter adaptation and checking which is protocol dependent into > designated functions. Leave only branching and common checks in > virDomainMigrateUnmanagedParams. > > Signed-off-by: Nikolay Shirokovskiy

Re: [libvirt] [PATCH v3 10/14] migration: merge all proto branches into single function

On Fri, Sep 18, 2015 at 18:05:48 +0300, Nikolay Shirokovskiy wrote: > Finally on this step we get what we were aimed for - toURI{1, 2} (and > migration{*} APIs too) now can work thru V3_PARAMS protocol. Execution path > goes thru unchanged virDomainMigrateUnmanaged adapter function which is called

Re: [libvirt] [PATCH v3 12/14] migration: reuse parameters check in toURI2 and toURI3

On Fri, Sep 18, 2015 at 18:05:50 +0300, Nikolay Shirokovskiy wrote: > It is *not* a pure refactoring patch as it introduces offline check for older > versions. Looks like it must be done that way and no one will be broken too. > > Signed-off-by: Nikolay Shirokovskiy

Re: [libvirt] [PATCH v3 14/14] migration: check dconnuri in p2p mode

On Fri, Sep 18, 2015 at 18:05:52 +0300, Nikolay Shirokovskiy wrote: > Check dconnuri is not null or we will catch nullpointer later. > I hope this makes Coverity happy. > > Signed-off-by: Nikolay Shirokovskiy > --- > src/libvirt-domain.c |8 ++-- > 1 files

Re: [libvirt] [PATCH v3 13/14] migration: refactor: one return in forURI family functions

On Fri, Sep 18, 2015 at 18:05:51 +0300, Nikolay Shirokovskiy wrote: > May be a matter of a taste but this version with one return point in every > function looks simplier to understand and to extend too. Anyway after such > a heavy refactoring a little cleanup will not hurt. > > Signed-off-by:

Re: [libvirt] [PATCH v3 11/14] migration: refactor: introduce parameter checking function

On Fri, Sep 18, 2015 at 18:05:49 +0300, Nikolay Shirokovskiy wrote: > virDomainMigrateUnmanagedParams is not a good candidate for this functionality > as it is used by migrate family functions too and its have its own checks that > are superset of extracted and we don't need to check twice. > >

Re: [libvirt] [PATCH 2/3] tests: eventtest: Open code virtTestResult

On 09/30/2015 01:38 AM, Martin Kletzander wrote: > On Tue, Sep 29, 2015 at 07:56:46PM -0400, Cole Robinson wrote: >> These event tests aren't run synchronously, so there isn't an obvious >> function to pass to virtTestRun. Instead, open code roughly what >> virtTestResult did before: printing an

Re: [libvirt] [PATCH v3 02/14] migration: refactor: reuse p2p url check

On Wed, Sep 30, 2015 at 10:20:23 +0300, Nikolay Shirokovskiy wrote: > > > On 25.09.2015 17:12, Jiri Denemark wrote: > > On Fri, Sep 18, 2015 at 18:05:40 +0300, Nikolay Shirokovskiy wrote: > >> Refactor dconnuri local server URI check to common API. > >> > >> Signed-off-by: Nikolay Shirokovskiy

Re: [libvirt] [PATCH] qemuDomainAttachDeviceLive: Check provided disk address

On Wed, Sep 30, 2015 at 09:44:27AM -0400, John Ferlan wrote: On 09/30/2015 12:43 AM, Martin Kletzander wrote: On Tue, Sep 29, 2015 at 05:27:58PM -0400, John Ferlan wrote: [...] NOTE: The change to the test is because the failure now occurs during parse rather than at run (e.g. earlier,

Re: [libvirt] Cannot write data: Broken pipe when accesing libvirt from a forked process

On Wed, Sep 30, 2015 at 01:06:48PM +0200, Josef Stribny wrote: > Hi all, > > I am trying to add vagrant-libvirt support for landrush plugin[0] and found > out that libvirt fails for me with: > > > Call to virConnectNumOfNetworks failed: Cannot write data: Broken pipe > (Libvirt::RetrieveError)

Re: [libvirt] [PATCH v2 0/3] Add support for gic-version machine option

On Wed, Sep 30, 2015 at 02:04:08PM +0300, Pavel Fedin wrote: qemu now supports gic-version option for the virt machine. This patchset allows to use it in libvirt. v1 => v2: - Added capability flag ACK series after release with my diff squashed in in case the original author agrees. Pavel

Re: [libvirt] [PATCH v2 2/3] qemu: Add support for gic-version machine option

On Wed, Sep 30, 2015 at 02:04:10PM +0300, Pavel Fedin wrote: Support for GICv3 has been recently introduced in qemu using gic-version option for the 'virt' machine. The option can actually take values of '2', '3' and 'host', however, since in libvirt this is a numeric parameter, we limit it only

Re: [libvirt] [PATCH v2] Close the source fd if the destination qemu exits during tunnelled migration

On 09/29/2015 10:06 AM, Shivaprasad bhat wrote: [...] >> Perhaps I should clarify my query-migrate has no timeout comment... It >> seems based on what I've read so far, the 'query-migrate' command >> started successfully, because if it hadn't we would have received a >> failure (as shown