Re: [libvirt] [PATCH] qemu_agent: fix deadlock in qemuProcessHandleAgentEOF

On 2015/10/2 20:17, John Ferlan wrote: > > > On 09/26/2015 08:18 AM, Wang Yufei wrote: >> We shutdown a VM A by qemu agent,meanwhile an agent EOF >> of VM A happened, there's a chance that deadlock occurred: >> >> qemuProcessHandleAgentEOF in main thread >> A) priv->agent = NULL; //A happened

Re: [libvirt] [RFC PATCH 7/8] qemu: Prepare basic APIs to handle invalid defs

On 22.09.2015 14:15, Martin Kletzander wrote: > In order for the user to be able to fix broken domains function > qemuDomainGetXMLDesc() needs to be able to lookup invalid domain > definitions and handle them properly. When redefined, function > qemuDomainDefineXMLFlags() must clear the 'invalid

Re: [libvirt] [RFC PATCH 5/8] conf: Optionally keep domains with invalid XML

On 22.09.2015 14:15, Martin Kletzander wrote: > Add new parameter to virDomainObjListLoadConfig() and > virDomainObjListLoadAllConfigs() that controls whether domains with > invalid XML (which could not be parsed) should be kept in order not to > lose track of them. For now, the parameter is set

Re: [libvirt] [RFC PATCH 0/8] Make loading domains with invalid XML possible

On 22.09.2015 14:15, Martin Kletzander wrote: > We always had to deal with new parsing errors in a weird way. All of > them needed to go into functions starting the domains. That messes up > the code, it's confusing to newcomers and so on. > > I once had an idea that we can handle this stuff.

[libvirt] [PATCH 9/9] virt-admin: Provide a man page for virt-admin

--- tools/Makefile.am| 8 +- tools/virt-admin.pod | 297 +++ 2 files changed, 304 insertions(+), 1 deletion(-) create mode 100644 tools/virt-admin.pod diff --git a/tools/Makefile.am b/tools/Makefile.am index e68fe84..d8cc1e7 100644 ---

[libvirt] [PATCH 1/9] libvirt: Export libvirt config getters by moving them to util

virConnectGetConfig and virConnectGetConfigPath were static libvirt methods, merely because there hasn't been any need for having them internally exported yet. Since libvirt-admin also needs to reference libvirt config file, 'xGetConfig' should be exported. Besides moving, this patch also renames

Re: [libvirt] [libvirt-users] virsh can't support VM offline blockcommit

On Tue, Oct 13, 2015 at 10:39:58AM +0800, justlibv...@gmail.com wrote: > Hi everyone! Hi, Firstly, please don't post the same message multiple times in a row. If someone hasn't responded, they're either busy, or haven't noticed this message. > I use the libvirt(version: 1.2.2) and

[libvirt] [PATCH 0/9] Introduce virt-admin client

Erik Skultety (9): libvirt: Export libvirt config getters by moving them to util virt-admin: Introduce first working skeleton admin: Do not generate remoteAdminConnect{Open,Close} admin: Add support for connection close callbacks admin: Introduce virAdmConnectGetLibVersion admin: Add

[libvirt] [PATCH 5/9] admin: Introduce virAdmConnectGetLibVersion

Introduce a new API to get libvirt version. It is worth noting, that libvirt-admin and libvirt share the same version number. Unfortunately, our existing API isn't generic enough to be used with virAdmConnectPtr as well. Also this patch wires up this API to the virt-admin client as a generic

[libvirt] [PATCH 8/9] virt-admin: Register async IO event polling

In order to be able to react to upcoming daemon events (disconnect, keepalive, ...), we need to register asynchronous polling so that our event loop can detect events on a file descriptor. --- src/libvirt-admin.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/libvirt-admin.c

[libvirt] [PATCH 6/9] admin: Add URI support and introduce virAdmGetDefaultURI

Since virt-admin should be able to connect to various admin servers on hosted different daemons, we need to provide URI support to libvirt-admin. --- include/libvirt/libvirt-admin.h | 2 + src/datatypes.c | 2 + src/datatypes.h | 1 + src/libvirt-admin.c

[libvirt] [PATCH 4/9] admin: Add support for connection close callbacks

As we need a client disconnect handler, we need a mechanism to register such handlers for a client. --- include/libvirt/libvirt-admin.h | 19 ++ src/datatypes.c | 22 +++ src/datatypes.h | 14 +++- src/libvirt-admin.c | 142

[libvirt] [PATCH 7/9] virt-admin: Introduce vshAdmCatchDisconnect handler

Since close callback and URI support was introduced in the earlier patches, it is now the right time to implement the disconnect handler itself and switch the dummy NULL reference in virAdmConnectRegisterCloseCallback for this new handler. The handler itself is the same as the one used in virsh,

[libvirt] [PATCH 2/9] virt-admin: Introduce first working skeleton

This patch introduces virt-admin client which is based on virsh client, but had to reimplement several methods to meet virt-admin specific needs or remove unnecessary virsh specific logic. --- .gitignore | 1 + daemon/libvirtd.c | 3 +-

[libvirt] [PATCH 3/9] admin: Do not generate remoteAdminConnect{Open, Close}

As we plan to add more and more logic to remote connecting methods, these cannot be generated from admin_protocol.x anymore. Instead, this patch implements these to methods explicitly. --- src/admin/admin_protocol.x | 4 ++-- src/libvirt-admin.c| 45

Re: [libvirt] [PATCH 05/12] storage: On error unlink created file in virFileOpen{As|Forked}

On Fri, Oct 09, 2015 at 09:34:04 -0400, John Ferlan wrote: > After a successful creation of a file, if some other call results > in returning a failure, let's unlink the file we created to prevent > another round trip or confusion in the caller. In particular, this > function can be called during

Re: [libvirt] [PATCH 03/12] storage: Fix a resource leak in storageVolCreateXML

On Fri, Oct 09, 2015 at 09:34:02 -0400, John Ferlan wrote: > Commit id '1b5685da' refactored the code to move buildvoldef inside > the buildVol conditional; however, the VIR_FREE of the memory was > left only when 'buildret' failed, thus we're leaking memory. > > Signed-off-by: John Ferlan

Re: [libvirt] [PATCH] libvirt-domain: Drop virDomainMigrateCheckNotLocal attribute

On Mon, Oct 12, 2015 at 17:19:18 +0200, Michal Privoznik wrote: > On 12.10.2015 17:06, Laine Stump wrote: > > On 10/12/2015 10:41 AM, Michal Privoznik wrote: ... > > (I have a fairly low opinion of ATTRIBUTE_NONNULL - at first glance it > > *appears* that it should be doing something to

Re: [libvirt] [PATCH v3] Close the source fd if the destination qemu exits during tunnelled migration

On Mon, Oct 12, 2015 at 8:03 PM, Jiri Denemark wrote: > On Thu, Oct 08, 2015 at 17:59:07 +0530, Shivaprasad G Bhat wrote: >> Tunnelled migration can hang if the destination qemu exits despite all the >> ABI checks. This happens whenever the destination qemu exits before the

Re: [libvirt] [RFC] Automatically sync time on domain resume?

On Tue, Oct 13, 2015 at 01:13:04PM +0200, Michal Privoznik wrote: > So I came across this bug: > > https://bugzilla.redhat.com/show_bug.cgi?id=1156194 > > There's a request for us to automatically sync guest time on domain > resume (e.g. bare virDomainResume(), or virDomainRestore() or after >

Re: [libvirt] [PATCH 10/12] storage: Pull volume removal from pool in storageVolDeleteInternal

On Fri, Oct 09, 2015 at 09:34:09 -0400, John Ferlan wrote: > Move the code that removes the volume from the pool into it's own API It's more of a helper than an API ... > > Signed-off-by: John Ferlan > --- > src/storage/storage_driver.c | 31 ---

Re: [libvirt] [PATCH 06/12] storage: On error rmdir created directory in virDirCreate[NoFork]

On Fri, Oct 09, 2015 at 09:34:05 -0400, John Ferlan wrote: > After a successful creation of a directory, if some other call results > in returning a failure, let's remove the directory we created to > prevent another round trip or confusion in the caller. In particular, this > function can be

Re: [libvirt] [PATCH 01/12] storage: Remove duplicitous refreshVol in RBD buildVol

On Fri, Oct 09, 2015 at 09:34:00 -0400, John Ferlan wrote: > As of commit id '155ca616' a 'refreshVol' is called after the buildVol > succeeds in storageVolCreateXML, thus the volStorageBackendRBDRefreshVolInfo > call in virStorageBackendRBDBuildVol is no longer necessary. > > Signed-off-by: John

Re: [libvirt] [PATCH 09/12] storage: Cleanup failures in virStorageBackendCreateRaw

On Fri, Oct 09, 2015 at 09:34:08 -0400, John Ferlan wrote: > If the volume target path doesn't exist prior to calling virFileOpenAs and > we have a successful call, then we know we've had a successful creation. > For any other failures in the function we should clean up after ourselves > by using

Re: [libvirt] [PATCH 08/12] storage: Cleanup failures virStorageBackendCreateExecCommand

On Fri, Oct 09, 2015 at 09:34:07 -0400, John Ferlan wrote: > After a successful qemu-img/qcow-create of the backing file, if we > fail to stat the file, change it owner/group, or mode, then the > cleanup path should delete the file. > > Also moved the virCommandSetUID/virCommandSetGID inside the

Re: [libvirt] crash in virDomainNumaGetMemorySize

On Fri, Sep 18, 2015 at 17:10:20 +0200, Olaf Hering wrote: > With current master (56945e1), while toying around with a WS2008R2 Hyper-V > host: Hi, thanks for reporting this. I've (hopefully) fixed the issue with: commit 403e86067d5cb3a6fd8583cb5b08121151bd4d9f Author: Peter Krempa

Re: [libvirt] [PATCH RFC 5/7] libxl: implement virConnectGetAllDomainStats

On 10/12/2015 11:20 PM, Jim Fehlig wrote: > Joao Martins wrote: >> Introduce support for connectGetAllDomainStats call that >> allow us to _all_ domain(s) statistics including network, block, >> cpus and memory. Changes are rather mechanical and mostly >> take care of the format to export the

Re: [libvirt] [PATCH 04/12] storage: Track successful creation of LV for removal

On Fri, Oct 09, 2015 at 09:34:03 -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1233003 > > Track when the logical volume was successfully created in order to > properly handle the call to virStorageBackendLogicalDeleteVol. It's > possible that the failure to create was

Re: [libvirt] [PATCH 11/12] Revert "storage: Prior to creating a volume, refresh the pool"

On Fri, Oct 09, 2015 at 09:34:10 -0400, John Ferlan wrote: > This reverts commit fdda37608a6e22406fbdfe4ac0c573a96a8d0417. > > This commit only manages a symptom of finding a buildRet failure > where a volume was not listed in the pool, but someone created the > volume outside of libvirt in the

[libvirt] [RFC] Automatically sync time on domain resume?

So I came across this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1156194 There's a request for us to automatically sync guest time on domain resume (e.g. bare virDomainResume(), or virDomainRestore() or after migration). I'd like to explore our options here and what would be acceptable

Re: [libvirt] [PATCH 12/12] storage: On 'buildVol' failure don't delete the volume

On Fri, Oct 09, 2015 at 09:34:11 -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1233003 > > Commit id 'fdda3760' only managed a symptom where it was possible to > create a file in a pool without libvirt's knowledge, so it was reverted. > > The real fix is to have all the

Re: [libvirt] [PATCH 07/12] storage: Rework error paths for virStorageBackendCreateExecCommand

On Fri, Oct 09, 2015 at 09:34:06 -0400, John Ferlan wrote: > Rework the code in order to use the "ret = -1;" and goto cleanup; > coding style. > > Signed-off-by: John Ferlan > --- > src/storage/storage_backend.c | 15 ++- > 1 file changed, 10 insertions(+), 5

Re: [libvirt] [PATCH 02/12] storage: Remove duplicitous refreshVol in Sheepdog buildVol

On Fri, Oct 09, 2015 at 09:34:01 -0400, John Ferlan wrote: > As of commit id '155ca616' a 'refreshVol' is called after a buildVol > succeeds in storageVolCreateXML, thus a > volStorageBackendSheepdogRefreshVolInfo > call in virStorageBackendSheepdogBuildVol is no longer necessary. > >

Re: [libvirt] [RFC PATCH 7/8] qemu: Prepare basic APIs to handle invalid defs

On Tue, Oct 13, 2015 at 12:10:05PM +0200, Michal Privoznik wrote: On 22.09.2015 14:15, Martin Kletzander wrote: In order for the user to be able to fix broken domains function qemuDomainGetXMLDesc() needs to be able to lookup invalid domain definitions and handle them properly. When redefined,

Re: [libvirt] [PATCH 3/3] util: add backing store parser support for gluster protocol

On Mon, Oct 12, 2015 at 09:14:33 -0400, Prasanna Kumar Kalever wrote: (Missing reply header?) > > > On Thu, Oct 08, 2015 at 17:25:53 +0530, Prasanna Kumar Kalever wrote: (I'd like to strongly suggest that you trim down the responses to the relevant portions only ... ) [...] > > > On the other

Re: [libvirt] [RFC PATCH 7/8] qemu: Prepare basic APIs to handle invalid defs

On 13.10.2015 15:08, Martin Kletzander wrote: > On Tue, Oct 13, 2015 at 12:10:05PM +0200, Michal Privoznik wrote: >> On 22.09.2015 14:15, Martin Kletzander wrote: >>> In order for the user to be able to fix broken domains function >>> qemuDomainGetXMLDesc() needs to be able to lookup invalid

Re: [libvirt] [RFC] Automatically sync time on domain resume?

On 10/13/2015 06:20 AM, Daniel P. Berrange wrote: >> There's of course the obvious solution - not change anything and have >> mgmt apps calling two separate APIs - like they oughtta be doing today. > > That's the right solution IMHO > >> What's your view? > > I see no compelling reason to add

Re: [libvirt] [RFC] Automatically sync time on domain resume?

On Tue, Oct 13, 2015 at 08:46:13AM -0600, Eric Blake wrote: > On 10/13/2015 06:20 AM, Daniel P. Berrange wrote: > > >> There's of course the obvious solution - not change anything and have > >> mgmt apps calling two separate APIs - like they oughtta be doing today. > > > > That's the right

[libvirt] gem install ruby-libvirt fails on FreeBSD 10.2

Hi, Installing the ruby-libvirt gem fails on FreeBSD 10.2 since it can't locate the lib and include dir. Installing with: gem install ruby-libvirt -- --with-libvirt-include=/usr/local/include/libvirt --with-libvirt-lib=/usr/local/lib/libvirt.so works fine. It would be great if this worked out

[libvirt] [PATCH 4/4] conf: Optimize the iothreadid initialization

https://bugzilla.redhat.com/show_bug.cgi?id=1264008 The existing algorithm assumed that someone was making small, incremental changes; however, it is possible to change iothreads from 0 (or relatively small number) to some really large number and the algorithm would possibly spin its wheels doing

[libvirt] [PATCH 0/4] Fix a couple of iothread bugs

Details in the patches. John Ferlan (4): qemu: During startup need more QEMU_CAPS_OBJECT_IOTHREAD checks qemu: Check QEMU_CAPS_OBJECT_IOTHREAD for qemuDomainPinIOThread conf: Refactor the iothreadid initialization conf: Optimize the iothreadid initialization src/conf/domain_conf.c | 83

[libvirt] [PATCH 1/4] qemu: During startup need more QEMU_CAPS_OBJECT_IOTHREAD checks

During qemu process startup (qemuProcessStart), the call to qemuProcessDetectIOThreadPIDs will not attempt to fill in the ->thread_id values if the binary doesn't support IOThreads. However, subsequent calls to setup the IOThread cgroups, affinity, and scheduler parameters had no such check, thus

[libvirt] [PATCH 3/4] conf: Refactor the iothreadid initialization

Create a separate local API that will fill in the iothreadid array entries that were not defined by entries in the XML. Signed-off-by: John Ferlan --- src/conf/domain_conf.c | 47 +++ 1 file changed, 31 insertions(+), 16

[libvirt] [PATCH 2/4] qemu: Check QEMU_CAPS_OBJECT_IOTHREAD for qemuDomainPinIOThread

https://bugzilla.redhat.com/show_bug.cgi?id=1249981 When trying to pin the thread to the live process in qemuDomainPinIOThread, there was no check whether the binary supported IOThreads, thus thread_id = 0 (eg current) would be erroneously used. Follow qemuDomainChgIOThread and only check for

Re: [libvirt] [RFC] Automatically sync time on domain resume?

On Tue, Oct 13, 2015 at 13:13:04 +0200, Michal Privoznik wrote: ... > 1) Invent new flag to all APIs in question and let mgmt applications > call it. If the flag is set we would sync the guest time too. However, > this masks two different operations under single API. What should be > reported if

Re: [libvirt] [PATCH 3/4] conf: Refactor the iothreadid initialization

On Tue, Oct 13, 2015 at 11:47:09 -0400, John Ferlan wrote: > Create a separate local API that will fill in the iothreadid array > entries that were not defined by entries in the XML. > > Signed-off-by: John Ferlan > --- > src/conf/domain_conf.c | 47

Re: [libvirt] [PATCH 2/4] qemu: Check QEMU_CAPS_OBJECT_IOTHREAD for qemuDomainPinIOThread

On Tue, Oct 13, 2015 at 11:47:08 -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1249981 > > When trying to pin the thread to the live process in qemuDomainPinIOThread, > there was no check whether the binary supported IOThreads, thus thread_id = 0 > (eg current) would be

Re: [libvirt] [PATCH 1/4] qemu: During startup need more QEMU_CAPS_OBJECT_IOTHREAD checks

On Tue, Oct 13, 2015 at 11:47:07 -0400, John Ferlan wrote: > During qemu process startup (qemuProcessStart), the call to > qemuProcessDetectIOThreadPIDs will not attempt to fill in the > ->thread_id values if the binary doesn't support IOThreads. > However, subsequent calls to setup the IOThread

Re: [libvirt] [PATCH 4/4] conf: Optimize the iothreadid initialization

On Tue, Oct 13, 2015 at 11:47:10 -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1264008 > > The existing algorithm assumed that someone was making small, incremental > changes; however, it is possible to change iothreads from 0 (or relatively > small number) to some

Re: [libvirt] [PATCH 09/12] storage: Cleanup failures in virStorageBackendCreateRaw

On 10/13/2015 08:43 AM, Peter Krempa wrote: > On Fri, Oct 09, 2015 at 09:34:08 -0400, John Ferlan wrote: >> If the volume target path doesn't exist prior to calling virFileOpenAs and >> we have a successful call, then we know we've had a successful creation. >> For any other failures in the

Re: [libvirt] [PATCH 08/12] storage: Cleanup failures virStorageBackendCreateExecCommand

On 10/13/2015 08:50 AM, Peter Krempa wrote: > On Fri, Oct 09, 2015 at 09:34:07 -0400, John Ferlan wrote: >> After a successful qemu-img/qcow-create of the backing file, if we >> fail to stat the file, change it owner/group, or mode, then the >> cleanup path should delete the file. >> >> Also

Re: [libvirt] [PATCH 1/4] qemu: During startup need more QEMU_CAPS_OBJECT_IOTHREAD checks

On 10/13/2015 12:08 PM, Peter Krempa wrote: > On Tue, Oct 13, 2015 at 11:47:07 -0400, John Ferlan wrote: >> During qemu process startup (qemuProcessStart), the call to >> qemuProcessDetectIOThreadPIDs will not attempt to fill in the >> ->thread_id values if the binary doesn't support IOThreads.

Re: [libvirt] [PATCH 4/4] conf: Optimize the iothreadid initialization

On 10/13/2015 12:29 PM, Peter Krempa wrote: > On Tue, Oct 13, 2015 at 11:47:10 -0400, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1264008 >> >> The existing algorithm assumed that someone was making small, incremental >> changes; however, it is possible to change iothreads

[libvirt] [PATCH] build: include xdr cflags for libvirt-admin

Without this, building on cygwin fails with: CC libvirt_admin_la-libvirt-admin.lo libvirt-admin.c:25:21: fatal error: rpc/rpc.h: No such file or directory #include ^ Reported by Yaakov Selkowitz Signed-off-by: Eric Blake

[libvirt] [PATCH] build: disable vbox on cygwin

Cygwin cannot build the vbox driver yet: CC vbox/libvirt_driver_vbox_impl_la-vbox_glue.lo In file included from vbox/vbox_glue.c:27:0: vblox/vbox_XPCOMCGlue.c:63:3: error: #error "Port me" # error "Port me" ^ In file included from vbox/vbox_XPCOMCGlue.c:45:0, from

[libvirt] [PATCH] build: get further on cygwin 'make check'

Based on how we generate protocol-structs files for checking that our protocol changes are backwards-compatible, we end up compiling lxc and lockd protocol files on all platforms during 'make check', even though we may never link those files into a final library or executable. For this to work on

Re: [libvirt] [PATCH RFC 6/7] libxl: implement virDomainGetJobInfo

Joao Martins wrote: > Introduce support for domainGetJobInfo to get info about the > ongoing job. If the job is active it will update the > timeElapsed which is computed with the "started" field added to > struct libxlDomainJobObj. For now we support just the very basic > info and all jobs have

Re: [libvirt] [PATCH 12/12] storage: On 'buildVol' failure don't delete the volume

On 10/13/2015 08:39 AM, Peter Krempa wrote: > On Fri, Oct 09, 2015 at 09:34:11 -0400, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1233003 >> >> Commit id 'fdda3760' only managed a symptom where it was possible to >> create a file in a pool without libvirt's knowledge, so it

Re: [libvirt] [PATCH 08/12] storage: Cleanup failures virStorageBackendCreateExecCommand

On 10/13/2015 03:11 PM, John Ferlan wrote: > > > On 10/13/2015 08:50 AM, Peter Krempa wrote: >> On Fri, Oct 09, 2015 at 09:34:07 -0400, John Ferlan wrote: >>> After a successful qemu-img/qcow-create of the backing file, if we >>> fail to stat the file, change it owner/group, or mode, then the

Re: [libvirt] [PATCH RFC 7/7] libxl: implement virDomainGetJobStats

Joao Martins wrote: > Introduces support for domainGetJobStats which has the same > info as domainGetJobInfo but in a slightly different format. > Another difference is that virDomainGetJobStats can also > retrieve info on the most recently completed job. Though so > far this is only used in the

Re: [libvirt] [PATCH 1/4] qemu: During startup need more QEMU_CAPS_OBJECT_IOTHREAD checks

On 10/13/2015 12:08 PM, Peter Krempa wrote: > On Tue, Oct 13, 2015 at 11:47:07 -0400, John Ferlan wrote: >> During qemu process startup (qemuProcessStart), the call to >> qemuProcessDetectIOThreadPIDs will not attempt to fill in the >> ->thread_id values if the binary doesn't support IOThreads.

Re: [libvirt] [PATCH 00/12] Have 'buildVol' callers to clean up after themselves

On 10/09/2015 09:33 AM, John Ferlan wrote: > NOTE: Although one may consider this a v2 of : > > http://www.redhat.com/archives/libvir-list/2015-October/msg00196.html > > It's more tackling the same problem a different way... > > Rather than pass a 'created' boolean around, this series

Re: [libvirt] [PATCH 2/4] qemu: Check QEMU_CAPS_OBJECT_IOTHREAD for qemuDomainPinIOThread

On 10/13/2015 12:10 PM, Peter Krempa wrote: > On Tue, Oct 13, 2015 at 11:47:08 -0400, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1249981 >> >> When trying to pin the thread to the live process in qemuDomainPinIOThread, >> there was no check whether the binary supported