Re: [libvirt] [PATCH] tests: Fix virnetdaemontest to be skipped in non-yajl environment

2015-10-26 Thread Prerna
Ping ! Do you want me to resend the patch including this error in the commit msg ? Regards, Prerna On Fri, Oct 23, 2015 at 9:49 PM, Prerna wrote: > Here is the more verbose failure snippet : > > ..[snip] > TEST: virnetdaemontest > 1) ExecRestart initial-nomdns

Re: [libvirt] [PATCH 00/10] Allow memory hotplug without NUMA on ppc64

2015-10-26 Thread Peter Krempa
On Fri, Oct 23, 2015 at 23:14:55 +0530, Shivaprasad bhat wrote: > Hi Peter, > > Went through the series and gave a try. The series looks good. > > One thing I wonder, should we allow the dimms without targetNode info > in the xml be hotplugged when > the guest is actually configured with NUMA nod

Re: [libvirt] [PATCH] qemu: Resolve agent deadlock

2015-10-26 Thread Peter Krempa
On Mon, Oct 26, 2015 at 17:28:57 -0400, John Ferlan wrote: > > > On 10/26/2015 11:37 AM, Peter Krempa wrote: > > On Mon, Oct 26, 2015 at 11:06:21 -0400, John Ferlan wrote: > >> If we have a shutdown of a VM by a qemu agent while an agent EOF occurs > >> at relatively the same time, it's possible

Re: [libvirt] [PATCH v2 0/5] qemu: hostdev: Unify naming

2015-10-26 Thread John Ferlan
On 10/26/2015 08:58 AM, Andrea Bolognani wrote: > Changes in v2: > > * make new names consistent with virHostdev (thanks John) > * rename virHostdevUpdateDomainActiveDevices() as well > - this was the only function in virHostdev that didn't > conform to the module's naming conventi

Re: [libvirt] [PATCH] rbd: Remove snapshots if the DELETE_WITH_SNAPSHOTS flag has been provided

2015-10-26 Thread John Ferlan
On 10/23/2015 10:33 AM, Wido den Hollander wrote: > When a RBD volume has snapshots it can not be removed. > > This patch introduces a new flag to force volume removal, > VIR_STORAGE_VOL_DELETE_WITH_SNAPSHOTS. > > With this flag any existing snapshots will be removed prior to > removing the vol

Re: [libvirt] [PATCH] qemu: Resolve agent deadlock

2015-10-26 Thread John Ferlan
On 10/26/2015 11:37 AM, Peter Krempa wrote: > On Mon, Oct 26, 2015 at 11:06:21 -0400, John Ferlan wrote: >> If we have a shutdown of a VM by a qemu agent while an agent EOF occurs >> at relatively the same time, it's possible that a deadlock occurs depending >> on what happens first. >> >> Assume

[libvirt] [PATCH] domain-conf: reorder usb controllers so the master is first

2015-10-26 Thread Pavel Hrdina
USB controllers can share the same 'index' which indicates, that there is some sort of master-companion relationship. Reorder the controllers in XML in to place the master controller before its companions. This is required by QEMU to not fail with error message: error: internal error: process ex

Re: [libvirt] [PATCH 0/4] HACKING: Improve handling

2015-10-26 Thread Andrea Bolognani
On Mon, 2015-10-26 at 16:25 +0100, Michal Privoznik wrote: > On 26.10.2015 16:03, Andrea Bolognani wrote: > > Generate the HACKING file at dist time like we're already doing for > > NEWS, AUTHORS and ChangeLog. > > > > The file shouldn't be tracked by git as it's not a source file but > > rather a

Re: [libvirt] [PATCH] bhyve: implement domainGetOSType

2015-10-26 Thread Michal Privoznik
On 20.10.2015 19:37, Roman Bogorodskiy wrote: > --- > src/bhyve/bhyve_driver.c | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c > index d44cf2c..efba0ae 100644 > --- a/src/bhyve/bhyve_driver.c > +++ b/src/bhyve/bh

Re: [libvirt] [PATCH] qemu: Resolve agent deadlock

2015-10-26 Thread Peter Krempa
On Mon, Oct 26, 2015 at 11:06:21 -0400, John Ferlan wrote: > If we have a shutdown of a VM by a qemu agent while an agent EOF occurs > at relatively the same time, it's possible that a deadlock occurs depending > on what happens first. > > Assume qemuProcessHandleAgentEOF runs first, with the vm->

Re: [libvirt] [PATCH 0/4] HACKING: Improve handling

2015-10-26 Thread Michal Privoznik
On 26.10.2015 16:03, Andrea Bolognani wrote: > Generate the HACKING file at dist time like we're already doing for > NEWS, AUTHORS and ChangeLog. > > The file shouldn't be tracked by git as it's not a source file but > rather a generated one; because of this, it should also be generated > in $(bui

[libvirt] [PATCH] qemu: Resolve agent deadlock

2015-10-26 Thread John Ferlan
If we have a shutdown of a VM by a qemu agent while an agent EOF occurs at relatively the same time, it's possible that a deadlock occurs depending on what happens first. Assume qemuProcessHandleAgentEOF runs first, with the vm->lock it clears priv->agent, then clears the vm->lock. After some age

Re: [libvirt] [PATCH] qemu_agent: fix deadlock in qemuProcessHandleAgentEOF

2015-10-26 Thread John Ferlan
On 10/23/2015 10:17 PM, Wang Yufei wrote: > On 2015/10/23 23:32, John Ferlan wrote: > >> >> >> On 10/13/2015 02:36 AM, Wang Yufei wrote: >>> On 2015/10/2 20:17, John Ferlan wrote: >>> On 09/26/2015 08:18 AM, Wang Yufei wrote: > We shutdown a VM A by qemu agent,meanwhile an age

[libvirt] [PATCH 2/4] HACKING: Remove generated copy

2015-10-26 Thread Andrea Bolognani
It doesn't make sense to track both the source and the generated file in the repository, so drop the latter. --- HACKING | 1008 --- 1 file changed, 1008 deletions(-) delete mode 100644 HACKING diff --git a/HACKING b/HACKING deleted fil

[libvirt] [PATCH 1/4] HACKING: Generate inside the build directory

2015-10-26 Thread Andrea Bolognani
Ideally, the build process shouldn't touch the source directory when doing VPATH builds. Let's take a small step in that direction. --- Makefile.am | 2 +- cfg.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 6f217bc..47865f7 100644 ---

[libvirt] [PATCH 0/4] HACKING: Improve handling

2015-10-26 Thread Andrea Bolognani
Generate the HACKING file at dist time like we're already doing for NEWS, AUTHORS and ChangeLog. The file shouldn't be tracked by git as it's not a source file but rather a generated one; because of this, it should also be generated in $(builddir) as opposed to $(top_srcdir). Cheers. Andrea Bol

[libvirt] [PATCH 4/4] HACKING: Include in EXTRA_DIST

2015-10-26 Thread Andrea Bolognani
This ensures it will be built as part of the release process and included in the distribution archive. Don't generate it during syntax-check. --- Makefile.am | 1 + cfg.mk | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 47865f7..8f928f4

[libvirt] [PATCH 3/4] HACKING: Add to ignore file

2015-10-26 Thread Andrea Bolognani
Since we're no longer tracking changes to the generated file, add it to the ignore patterns to avoid pointless noise when performing builds inside the source directory. --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 2d52a8f..36d3458 100644 --- a/.g

[libvirt] [PATCH v2 3/5] qemu: hostdev: Unify naming for qemuHostdevReAttach*Devices()

2015-10-26 Thread Andrea Bolognani
Adopt the same names used for virHostdevReAttach*Devices() for consistency's sake and to make it easier to jump between the two. No functional changes. --- src/qemu/qemu_hostdev.c | 40 src/qemu/qemu_hostdev.h | 30 +++--- src/qemu/

Re: [libvirt] [PATCH 1/4] virsh-domain: use correct base for virStrToLong_ui

2015-10-26 Thread Laine Stump
On 10/26/2015 05:53 AM, Pavel Hrdina wrote: The current situation is not ideal, it's not documented anywhere and for users you can only try the command and see what happens. Yes, it can and probably will break some scripts for some users, but I think we should make it somehow consistent and docu

Re: [libvirt] [PATCH 3/4] virsh-domain: update attach-interface to support type=hostdev

2015-10-26 Thread Pavel Hrdina
On Mon, Oct 26, 2015 at 04:05:28AM -0400, Laine Stump wrote: > On 10/21/2015 08:22 AM, Pavel Hrdina wrote: > > Adding this feature will allow users to easily attach a hostdev network > > interface using PCI passthrough. > > > > The interface can be attached using --type=hostdev and PCI address or >

Re: [libvirt] [PATCH 1/4] qemu: hostdev: Unify naming for qemuPrepareHost*Devices()

2015-10-26 Thread Andrea Bolognani
On Thu, 2015-10-22 at 11:19 +0200, Andrea Bolognani wrote: > John's use case is very compelling IMHO, plus personally > something like > > qemuHostdevPreparePCIDevices() > > feels way more natural than > > qemuHostdevPCIPrepareDevices() > > so I'd go with his suggestion if that's okay with

[libvirt] [PATCH v2 1/5] hostdev: Rename virHostdevUpdateDomainActiveDevices()

2015-10-26 Thread Andrea Bolognani
The new name, virHostdevUpdateActiveDomainDevices(), follows the same naming conventions used by the rest of the module. No functional changes. --- src/libvirt_private.syms | 2 +- src/libxl/libxl_driver.c | 2 +- src/util/virhostdev.c| 2 +- src/util/virhostdev.h| 2 +- 4 files changed,

[libvirt] [PATCH v2 4/5] qemu: hostdev: Unify naming for qemuHostdevUpdateActive*Devices()

2015-10-26 Thread Andrea Bolognani
Adopt the same names used for virHostdevUpdateActive*Devices() for consistency's sake and to make it easier to jump between the two. No functional changes. --- src/qemu/qemu_hostdev.c | 12 ++-- src/qemu/qemu_hostdev.h | 13 +++-- src/qemu/qemu_process.c | 6 +++--- 3 files chang

[libvirt] [PATCH v2 5/5] qemu: hostdev: Introduce qemuHostdevUpdateActiveDomainDevices()

2015-10-26 Thread Andrea Bolognani
This calls the PCI-, USB- and SCSI-specific functions just like qemuHostdev{Prepare,ReAttach}DomainDevices() already do, and was the missing piece for the qemuHostdev API to nicely mirror the virHostdev API. Update qemuProcessReconnect() to use the new function. --- src/qemu/qemu_hostdev.c | 18 +

[libvirt] [PATCH v2 0/5] qemu: hostdev: Unify naming

2015-10-26 Thread Andrea Bolognani
Changes in v2: * make new names consistent with virHostdev (thanks John) * rename virHostdevUpdateDomainActiveDevices() as well - this was the only function in virHostdev that didn't conform to the module's naming conventions Cheers. Andrea Bolognani (5): hostdev: Rename virHost

[libvirt] [PATCH v2 2/5] qemu: hostdev: Unify naming for qemuHostdevPrepare*Devices()

2015-10-26 Thread Andrea Bolognani
Adopt the same names used for virHostdevPrepare*Devices() for consistency's sake and to make it easier to jump between the two. No functional changes. --- src/qemu/qemu_hostdev.c | 38 +++--- src/qemu/qemu_hostdev.h | 24 src/qemu/qemu_hotp

[libvirt] [PATCH 0/2] Hyper-v crash feature support

2015-10-26 Thread Dmitry Andreev
A new Hyper-V cpu feature 'hv_crash' was added to QEMU. The feature will become available in v2.5.0. This patch adds support for this feature. Dmitry Andreev (2): conf: add crash to hyperv features qemu: add hv_crash support docs/formatdomain.html.in | 7 +++ do

[libvirt] [PATCH 1/2] conf: add crash to hyperv features

2015-10-26 Thread Dmitry Andreev
Add crash CPU feature for Hyper-V. Hyper-V crash MSR's can be used by Hyper-V based guests to notify about occurred guest crash. XML: --- docs/formatdomain.html.in | 7 +++ docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c| 6 +- src/conf/domain_conf

[libvirt] [PATCH 2/2] qemu: add hv_crash support

2015-10-26 Thread Dmitry Andreev
XML: QEMU command line: qemu -cpu ,hv_crash --- src/qemu/qemu_command.c| 2 ++ tests/qemuxml2argvdata/qemuxml2argv-hyperv-off.xml | 1 + tests/qemuxml2argvdata/qemuxml2argv-hyperv.args| 4 ++-- tests/qemuxml2argvdata/qemuxml2argv-hyperv.xml | 1 +

Re: [libvirt] [PATCH 1/4] virsh-domain: use correct base for virStrToLong_ui

2015-10-26 Thread Pavel Hrdina
On Fri, Oct 23, 2015 at 12:48:07PM -0400, Laine Stump wrote: > On 10/23/2015 03:59 AM, Pavel Hrdina wrote: > > On Fri, Oct 23, 2015 at 09:33:49AM +0200, Peter Krempa wrote: > >> On Thu, Oct 22, 2015 at 11:24:02 -0400, Laine Stump wrote: > >>> On 10/21/2015 08:22 AM, Pavel Hrdina wrote: > While

Re: [libvirt] [PATCH 3/4] virsh-domain: update attach-interface to support type=hostdev

2015-10-26 Thread Laine Stump
On 10/21/2015 08:22 AM, Pavel Hrdina wrote: Adding this feature will allow users to easily attach a hostdev network interface using PCI passthrough. The interface can be attached using --type=hostdev and PCI address or network device name as --source. This command also allows you to tell, wheth