Re: [libvirt] [PATCH] qemu: process: Fix automatic setting of locked memory limit for VFIO

2015-11-05 Thread Peter Krempa
On Thu, Nov 05, 2015 at 08:41:46 -0700, Alex Williamson wrote: > On Thu, 2015-11-05 at 16:27 +0100, Peter Krempa wrote: > > On Wed, Nov 04, 2015 at 17:16:53 -0700, Alex Williamson wrote: [...] > The power devs will need to speak to what their locked memory > requirements are and maybe we can come

Re: [libvirt] [PATCH 0/7] Drop support for QEMU < 0.12.0

2015-11-05 Thread Peter Krempa
On Thu, Nov 05, 2015 at 17:33:52 +, Daniel Berrange wrote: > The patches for introducing virtlogd will be significantly > simplified if we don't need to worry about parsing stderr > during startup. This is required prior to QEMU 0.11 so > that we can get the dyanamically allocated /dev/pty/NNN

Re: [libvirt] [PATCH 0/7] Drop support for QEMU < 0.12.0

2015-11-05 Thread John Ferlan
On 11/05/2015 12:33 PM, Daniel P. Berrange wrote: > The patches for introducing virtlogd will be significantly > simplified if we don't need to worry about parsing stderr > during startup. This is required prior to QEMU 0.11 so > that we can get the dyanamically allocated /dev/pty/NNN > paths. >

Re: [libvirt] [PATCH 6/7] qemu: assume -drive argument is always available

2015-11-05 Thread John Ferlan
On 11/05/2015 12:33 PM, Daniel P. Berrange wrote: > As of QEMU 0.9.1 the -drive argument can be used to configure > all disks, so the QEMU driver can assume it is always available > and drop support for -hda/-cdrom/etc. > > Many of the tests need updating because a great many were > running with

Re: [libvirt] [PATCH 5/7] qemu: assume -no-reboot is always available

2015-11-05 Thread John Ferlan
On 11/05/2015 12:33 PM, Daniel P. Berrange wrote: > The -no-reboot arg was added in QEMU 0.9.0, so the QEMU driver > can now assume it is always present. > > Signed-off-by: Daniel P. Berrange > --- > src/qemu/qemu_capabilities.c | 3 --- > src/qemu/qemu_capabilities.h

Re: [libvirt] [PATCH 3/7] qemu: assume -vnc arg always takes a ':'

2015-11-05 Thread John Ferlan
On 11/05/2015 12:33 PM, Daniel P. Berrange wrote: > As of QEMU 0.9.0 the -vnc option accepts a ':' to separate port > from listen address, so the QEMU driver can assume that support > for listen addresses is always available. > > Signed-off-by: Daniel P. Berrange > --- > src/qemu/qemu_capabili

Re: [libvirt] [PATCH 2/7] qemu: remove all support for kQEMU

2015-11-05 Thread John Ferlan
On 11/05/2015 12:33 PM, Daniel P. Berrange wrote: > The kQEMU accelerator was deleted in QEMU 0.12, so we no > longer need to support it in the QEMU driver. > > Signed-off-by: Daniel P. Berrange > --- > src/qemu/qemu_capabilities.c | 18 -- > src/qemu/qemu_capabilities.h | 4 +

Re: [libvirt] [PATCH 7/7] qemu: assume -name is always available

2015-11-05 Thread John Ferlan
On 11/05/2015 12:33 PM, Daniel P. Berrange wrote: > The -name arg was added in QEMU 0.9.1, so the QEMU driver can > assume it is always available. > > Signed-off-by: Daniel P. Berrange After dealing with merge conflicts (which I used 'git add' and of course won't have diffs), there were more l

Re: [libvirt] [PATCH 6/7] qemu: assume -drive argument is always available

2015-11-05 Thread John Ferlan
On 11/05/2015 12:33 PM, Daniel P. Berrange wrote: > As of QEMU 0.9.1 the -drive argument can be used to configure > all disks, so the QEMU driver can assume it is always available > and drop support for -hda/-cdrom/etc. > > Many of the tests need updating because a great many were > running with

Re: [libvirt] [PATCH 4/7] qemu: assume 'info chardev' is always available

2015-11-05 Thread John Ferlan
On 11/05/2015 12:33 PM, Daniel P. Berrange wrote: > As of QEMU 0.11.0 the 'info chardev' monitor command can be > used to report on allocated chardev paths, so we can drop > support for parsing QEMU stderr to locate the PTY paths. > > Signed-off-by: Daniel P. Berrange > --- > src/qemu/qemu_pro

Re: [libvirt] [PATCH 6/7] qemu: assume -drive argument is always available

2015-11-05 Thread John Ferlan
[...] Ran the series through the Coverity checks... > diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c > index 79d1692..7676237 100644 > --- a/src/qemu/qemu_capabilities.c > +++ b/src/qemu/qemu_capabilities.c > @@ -1104,29 +1104,27 @@ virQEMUCapsComputeCmdFlags(const cha

Re: [libvirt] [PATCH 4/7] qemu: assume 'info chardev' is always available

2015-11-05 Thread John Ferlan
On 11/05/2015 12:33 PM, Daniel P. Berrange wrote: > As of QEMU 0.11.0 the 'info chardev' monitor command can be > used to report on allocated chardev paths, so we can drop > support for parsing QEMU stderr to locate the PTY paths. > > Signed-off-by: Daniel P. Berrange > --- > src/qemu/qemu_pro

Re: [libvirt] [PATCH 0/2] Fix spurious error when migrating with memory hotplug

2015-11-05 Thread Jiri Denemark
On Thu, Nov 05, 2015 at 15:38:41 +0100, Peter Krempa wrote: > Peter Krempa (2): > qemu: migration: Properly parse memory hotplug migration flag > qemu: migration: Actually error out on unsupported migration flag > > src/qemu/qemu_migration.c | 4 +++- > 1 file changed, 3 insertions(+), 1 dele

Re: [libvirt] [PATCH 0/7] Drop support for QEMU < 0.12.0

2015-11-05 Thread Eric Blake
On 11/05/2015 10:47 AM, Cole Robinson wrote: > On 11/05/2015 12:33 PM, Daniel P. Berrange wrote: >> The patches for introducing virtlogd will be significantly >> simplified if we don't need to worry about parsing stderr >> during startup. This is required prior to QEMU 0.11 so >> that we can get th

Re: [libvirt] [PATCH 0/7] Drop support for QEMU < 0.12.0

2015-11-05 Thread Cole Robinson
On 11/05/2015 12:33 PM, Daniel P. Berrange wrote: > The patches for introducing virtlogd will be significantly > simplified if we don't need to worry about parsing stderr > during startup. This is required prior to QEMU 0.11 so > that we can get the dyanamically allocated /dev/pty/NNN > paths. > >

Re: [libvirt] [PATCH 0/7] Drop support for QEMU < 0.12.0

2015-11-05 Thread Daniel P. Berrange
On Thu, Nov 05, 2015 at 12:47:41PM -0500, Cole Robinson wrote: > On 11/05/2015 12:33 PM, Daniel P. Berrange wrote: > > The patches for introducing virtlogd will be significantly > > simplified if we don't need to worry about parsing stderr > > during startup. This is required prior to QEMU 0.11 so

[libvirt] [PATCH 1/7] qemu: mandate QEMU version 0.12.0 or newer

2015-11-05 Thread Daniel P. Berrange
Check the QEMU version and refuse to work with QEMU versions older than 0.12.0. This is approximately the vintage of QEMU that is available in RHEL-6 era distros. Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_capabilities.c | 7 ++ tests/qemuhelpdata/kvm-74 | 111 -

[libvirt] [PATCH 3/7] qemu: assume -vnc arg always takes a ':'

2015-11-05 Thread Daniel P. Berrange
As of QEMU 0.9.0 the -vnc option accepts a ':' to separate port from listen address, so the QEMU driver can assume that support for listen addresses is always available. Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_capabilities.c | 4 - src/qemu/qemu_capabilities.h

[libvirt] [PATCH 5/7] qemu: assume -no-reboot is always available

2015-11-05 Thread Daniel P. Berrange
The -no-reboot arg was added in QEMU 0.9.0, so the QEMU driver can now assume it is always present. Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_capabilities.c | 3 --- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c

[libvirt] [PATCH 2/7] qemu: remove all support for kQEMU

2015-11-05 Thread Daniel P. Berrange
The kQEMU accelerator was deleted in QEMU 0.12, so we no longer need to support it in the QEMU driver. Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_capabilities.c | 18 -- src/qemu/qemu_capabilities.h | 4 ++-- src/qemu/qemu_command.c | 23 ++- 3

[libvirt] [PATCH 0/7] Drop support for QEMU < 0.12.0

2015-11-05 Thread Daniel P. Berrange
The patches for introducing virtlogd will be significantly simplified if we don't need to worry about parsing stderr during startup. This is required prior to QEMU 0.11 so that we can get the dyanamically allocated /dev/pty/NNN paths. The QEMU 0.12.1 release was shipped in RHEL-6 vintage distros a

[libvirt] [PATCH 4/7] qemu: assume 'info chardev' is always available

2015-11-05 Thread Daniel P. Berrange
As of QEMU 0.11.0 the 'info chardev' monitor command can be used to report on allocated chardev paths, so we can drop support for parsing QEMU stderr to locate the PTY paths. Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_process.c | 193 1 f

Re: [libvirt] [PATCH] qemu: process: Fix automatic setting of locked memory limit for VFIO

2015-11-05 Thread Alex Williamson
On Thu, 2015-11-05 at 16:27 +0100, Peter Krempa wrote: > On Wed, Nov 04, 2015 at 17:16:53 -0700, Alex Williamson wrote: > > On Wed, 2015-11-04 at 16:54 +0100, Peter Krempa wrote: > > > On Wed, Nov 04, 2015 at 08:43:34 -0700, Alex Williamson wrote: > > > > On Wed, 2015-11-04 at 16:14 +0100, Peter Kr

Re: [libvirt] [PATCH] qemu: process: Fix automatic setting of locked memory limit for VFIO

2015-11-05 Thread Peter Krempa
On Wed, Nov 04, 2015 at 17:16:53 -0700, Alex Williamson wrote: > On Wed, 2015-11-04 at 16:54 +0100, Peter Krempa wrote: > > On Wed, Nov 04, 2015 at 08:43:34 -0700, Alex Williamson wrote: > > > On Wed, 2015-11-04 at 16:14 +0100, Peter Krempa wrote: [...] > > Additionally if users wish to impose a

[libvirt] [PATCH 0/2] Fix spurious error when migrating with memory hotplug

2015-11-05 Thread Peter Krempa
Peter Krempa (2): qemu: migration: Properly parse memory hotplug migration flag qemu: migration: Actually error out on unsupported migration flag src/qemu/qemu_migration.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.6.2 -- libvir-list mailing list libvir-list@redhat.com h

[libvirt] [PATCH 1/2] qemu: migration: Properly parse memory hotplug migration flag

2015-11-05 Thread Peter Krempa
Since the flag was not enabled when 'eating' the migration cookie, libvirt reported a bogus error when memory hotplug was enabled: unsupported migration cookie feature memory-hotplug The error was ignored though due to a bug in the code so it slipped through testing. Resolves: https://bugzilla.

[libvirt] [PATCH 2/2] qemu: migration: Actually error out on unsupported migration flag

2015-11-05 Thread Peter Krempa
The code reported that a migration flag is unsupported but didn't jump to the error label. Probably an oversight in commit f88af9dc that introduced the flag checking. --- src/qemu/qemu_migration.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migrati

Re: [libvirt] [PATCH 1/2] conf: add crash to hyperv features

2015-11-05 Thread Paolo Bonzini
On 05/11/2015 14:54, Dmitry Andreev wrote: >> >>> Add crash CPU feature for Hyper-V. Hyper-V crash MSR's can be used >>> by Hyper-V based guests to notify about occurred guest crash. >>> >>> XML: >>> >>> >>> >>> >>> >> Sounds like this is related to an existing panic device we alr

Re: [libvirt] Libvirt management daemon issue

2015-11-05 Thread Eric Blake
[re-adding the list with permission - conversations like this should be held in public, because others may benefit from the archives] [please don't top-post on technical lists] On 11/04/2015 09:42 PM, Bilal Arif wrote: > One thing I found about binaries when i apply my patch on Qemu the results >

Re: [libvirt] [PATCH 1/2] conf: add crash to hyperv features

2015-11-05 Thread Dmitry Andreev
On 05.11.2015 14:06, Jiri Denemark wrote: On Mon, Oct 26, 2015 at 13:23:32 +0300, Dmitry Andreev wrote: Add crash CPU feature for Hyper-V. Hyper-V crash MSR's can be used by Hyper-V based guests to notify about occurred guest crash. XML: Sounds like this is related to an exis

Re: [libvirt] [PATCH 5/5] qemu: add support for sending QEMU stdout/stderr to virtlogd

2015-11-05 Thread Daniel P. Berrange
On Thu, Nov 05, 2015 at 10:39:59AM +, Daniel P. Berrange wrote: > On Wed, Nov 04, 2015 at 09:17:00AM +0100, Peter Krempa wrote: > > On Tue, Nov 03, 2015 at 16:04:24 +, Daniel Berrange wrote: > > > Currently the QEMU stdout/stderr streams are written directly to > > > a regular file (eg /var

Re: [libvirt] [PATCH 1/2] conf: add crash to hyperv features

2015-11-05 Thread Jiri Denemark
On Mon, Oct 26, 2015 at 13:23:32 +0300, Dmitry Andreev wrote: > Add crash CPU feature for Hyper-V. Hyper-V crash MSR's can be used > by Hyper-V based guests to notify about occurred guest crash. > > XML: > > > > > Sounds like this is related to an existing panic device we already sup

Re: [libvirt] [PATCH 5/5] qemu: add support for sending QEMU stdout/stderr to virtlogd

2015-11-05 Thread Daniel P. Berrange
On Wed, Nov 04, 2015 at 09:17:00AM +0100, Peter Krempa wrote: > On Tue, Nov 03, 2015 at 16:04:24 +, Daniel Berrange wrote: > > Currently the QEMU stdout/stderr streams are written directly to > > a regular file (eg /var/log/libvirt/qemu/$GUEST.log). While those > > can be rotated by logrotate (

Re: [libvirt] [PATCH 1/5] util: add API for writing to rotating files

2015-11-05 Thread Daniel P. Berrange
On Wed, Nov 04, 2015 at 07:56:37AM +0100, Peter Krempa wrote: > On Tue, Nov 03, 2015 at 16:04:20 +, Daniel Berrange wrote: > > Add a virRotatingFile object which allows writing to a file > > with automation rotation to N backup files when a size limit > > is reached. This is useful for guest lo

Re: [libvirt] [PATCH 2/2] qemu: add hv_crash support

2015-11-05 Thread Dmitry Guryanov
On 10/26/2015 01:23 PM, Dmitry Andreev wrote: XML: QEMU command line: qemu -cpu ,hv_crash ACK from me, but I think someone else should look at these patches. --- src/qemu/qemu_command.c| 2 ++ tests/qemuxml2argvdata/qemuxml2argv-hyperv-off.xml |

Re: [libvirt] [PATCH 1/2] conf: add crash to hyperv features

2015-11-05 Thread Dmitry Guryanov
On 10/26/2015 01:23 PM, Dmitry Andreev wrote: Add crash CPU feature for Hyper-V. Hyper-V crash MSR's can be used by Hyper-V based guests to notify about occurred guest crash. XML: Looks good to me, ACK. By the way, which commit has added this feature to qemu? Is it this one ht

[libvirt] [PATCH] vz: implement memory setting functions in driver

2015-11-05 Thread Nikolay Shirokovskiy
Implement functions for vz containers only. vz VMs memory managment thru libvirt yet to be designed. vz memory management for containers is rather different from other drivers. 1. Whole bunch of memory settings functions change both cur_balloon and maximum memory to the same value. The reason is