[libvirt] [PATCH] doc: extend virDomainSetMemory semantics

2015-11-11 Thread Nikolay Shirokovskiy
virDomainSetMemory is documented to change only runtime configuration of running domain. This can't be implemented for vz driver as it always change persistent state too. Let's extend semantics of this function for changes to be hyperviror specific. As a result 'virsh setmem' without parameters (wh

Re: [libvirt] [PATCH 2/3] qemu: Explain mlock limit size more in detail

2015-11-11 Thread Peter Krempa
On Wed, Nov 11, 2015 at 15:23:55 +0100, Andrea Bolognani wrote: > On Wed, 2015-11-11 at 06:57 +0100, Peter Krempa wrote: > > Based on Alex's explanation [1] in the recent discussion let's update > > the comment explaining the memory lock limit calculation. > > > > [1] > > http://www.redhat.com/arc

Re: [libvirt] Fwd: xen/libvirt freeze while attching network-device to vm´s

2015-11-11 Thread Jim Fehlig
On 11/04/2015 08:29 AM, Eric Blake wrote: > [edited to reduce size to get past moderation] > > > Forwarded Message > > Date: Wed, 4 Nov 2015 15:57:26 +0100 > From: max ustermann > To: libvirt-us...@redhat.com > Subject: xen/libvirt freeze while attching network-device to vm´s > M

Re: [libvirt] libvirt-snmp development

2015-11-11 Thread Charlie Drage
To be honest, there aren't *many* but they are there. Notable examples include the collectd plugin that Richard Jones created in C and hostflow. There's also virt-top, but I don't think it'll provide you with all the information that you'd need. Personally, I ended up creating a crude script in p

Re: [libvirt] [PATCH] libxl: open libxl log stream with libvirtd log_level

2015-11-11 Thread Marek Marczykowski-Górecki
On Wed, Nov 11, 2015 at 04:04:22PM +, Daniel P. Berrange wrote: > On Wed, Nov 11, 2015 at 04:57:59PM +0100, Marek Marczykowski-Górecki wrote: > > On Tue, Sep 15, 2015 at 11:21:00AM -0600, Jim Fehlig wrote: > > > Daniel P. Berrange wrote: > > > > On Tue, Sep 15, 2015 at 10:57:50AM -0600, Jim Feh

Re: [libvirt] [PATCH] libxl: open libxl log stream with libvirtd log_level

2015-11-11 Thread Daniel P. Berrange
On Wed, Nov 11, 2015 at 04:57:59PM +0100, Marek Marczykowski-Górecki wrote: > On Tue, Sep 15, 2015 at 11:21:00AM -0600, Jim Fehlig wrote: > > Daniel P. Berrange wrote: > > > On Tue, Sep 15, 2015 at 10:57:50AM -0600, Jim Fehlig wrote: > > > > > >> Daniel P. Berrange wrote: > > >> > > >>> On

Re: [libvirt] [PATCH] storage: Ignore block devices that fail format detection

2015-11-11 Thread John Ferlan
ping Thanks - John On 10/30/2015 11:13 AM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1276198 > > Prior to commit id '98322052' failure to saferead the block device would > cause an error to be logged and the device to be skipped while attempting > to discover/create a st

Re: [libvirt] [PATCH] libxl: open libxl log stream with libvirtd log_level

2015-11-11 Thread Marek Marczykowski-Górecki
On Tue, Sep 15, 2015 at 11:21:00AM -0600, Jim Fehlig wrote: > Daniel P. Berrange wrote: > > On Tue, Sep 15, 2015 at 10:57:50AM -0600, Jim Fehlig wrote: > > > >> Daniel P. Berrange wrote: > >> > >>> On Tue, Sep 15, 2015 at 09:26:23AM -0600, Jim Fehlig wrote: > >>> > >>> > Inst

Re: [libvirt] [PATCH v2 17/17] qemu: assume various QEMU 0.10 features are always available

2015-11-11 Thread Paolo Bonzini
On 10/11/2015 00:28, John Ferlan wrote: >} else if (STRPREFIX(arg, "-hd") || >STRPREFIX(arg, "-sd") || >STRPREFIX(arg, "-fd") || >STREQ(arg, "-cdrom")) { > WANT_VALUE(); -sd is for sdcards, not SCSI, so it should be

Re: [libvirt] [PATCH] tests: Remove qemuxmlnstest

2015-11-11 Thread Daniel P. Berrange
On Wed, Nov 11, 2015 at 04:46:14PM +0100, Jiri Denemark wrote: > It's just a copy&paste of qemuxml2argv test anyway. We can test most of > them (except for qemuxmlns-qemu-ns-domain.xml which fails to validate > against our schema) by qemuxml2argv test. > > Signed-off-by: Jiri Denemark > --- > te

[libvirt] [PATCH] tests: Remove qemuxmlnstest

2015-11-11 Thread Jiri Denemark
It's just a copy&paste of qemuxml2argv test anyway. We can test most of them (except for qemuxmlns-qemu-ns-domain.xml which fails to validate against our schema) by qemuxml2argv test. Signed-off-by: Jiri Denemark --- tests/Makefile.am | 10 +- .../qemuxml2argv-q

Re: [libvirt] [PATCH] security: Cleanup DAC driver

2015-11-11 Thread Peter Krempa
On Wed, Nov 11, 2015 at 15:26:58 +0100, Jiri Denemark wrote: > Fixes several style issues and removes "DEF" (what is it supposed to > mean anyway?) from debug messages. > > Signed-off-by: Jiri Denemark > --- > src/security/security_dac.c | 22 ++ > 1 file changed, 10 insertio

Re: [libvirt] [PATCH] tests: Add QEMU 2.4.0 capabilities

2015-11-11 Thread Pavel Hrdina
On Wed, Nov 11, 2015 at 03:41:37PM +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > tests/qemucapabilitiesdata/caps_2.4.0-1.caps| 164 + > tests/qemucapabilitiesdata/caps_2.4.0-1.replies | 3953 > +++ > tests/qemucapabilitiestest.c|

Re: [libvirt] [PATCH] qemu: Fix style in qemuProcessStart

2015-11-11 Thread Peter Krempa
On Wed, Nov 11, 2015 at 15:30:10 +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_process.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > ACK signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com https:/

Re: [libvirt] [sandbox] Weird apparmor problems

2015-11-11 Thread Jamie Strandboge
On 10/30/2015 08:27 AM, Cedric Bosdonnat wrote: > On Fri, 2015-10-30 at 09:15 +0900, Daniel P. Berrange wrote: >> So, yes, it is normal for libvirt_lxc to access /dev/ptmx to create >> a new master PTY and to read/write to /dev/pts/NN associated with >> the file descriptor retrieved from /dev/ptmx.

Re: [libvirt] [PATCH] qemuxmlnstest: Remove migrate{From,Fd}

2015-11-11 Thread Jiri Denemark
On Wed, Nov 11, 2015 at 14:40:40 +, Daniel P. Berrange wrote: > On Wed, Nov 11, 2015 at 03:37:23PM +0100, Jiri Denemark wrote: > > They are unused and make no sense in this test. It was most likely a > > result of copy&paste from another test. > > > > Signed-off-by: Jiri Denemark > > --- > >

[libvirt] [PATCH] tests: Add QEMU 2.4.0 capabilities

2015-11-11 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- tests/qemucapabilitiesdata/caps_2.4.0-1.caps| 164 + tests/qemucapabilitiesdata/caps_2.4.0-1.replies | 3953 +++ tests/qemucapabilitiestest.c|1 + 3 files changed, 4118 insertions(+) create mode 100644 tests/qemuca

Re: [libvirt] [PATCH] qemuxmlnstest: Remove migrate{From,Fd}

2015-11-11 Thread Daniel P. Berrange
On Wed, Nov 11, 2015 at 03:37:23PM +0100, Jiri Denemark wrote: > They are unused and make no sense in this test. It was most likely a > result of copy&paste from another test. > > Signed-off-by: Jiri Denemark > --- > tests/qemuxmlnstest.c | 14 +++--- > 1 file changed, 3 insertions(+), 1

[libvirt] [PATCH] qemuxmlnstest: Remove migrate{From,Fd}

2015-11-11 Thread Jiri Denemark
They are unused and make no sense in this test. It was most likely a result of copy&paste from another test. Signed-off-by: Jiri Denemark --- tests/qemuxmlnstest.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/tests/qemuxmlnstest.c b/tests/qemuxmlnstest.c in

[libvirt] [PATCH] qemu: Fix style in qemuProcessStart

2015-11-11 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/qemu/qemu_process.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 69a0f97..4545f77 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -4279,7 +4279,7 @@ int q

[libvirt] [PATCH] security: Cleanup DAC driver

2015-11-11 Thread Jiri Denemark
Fixes several style issues and removes "DEF" (what is it supposed to mean anyway?) from debug messages. Signed-off-by: Jiri Denemark --- src/security/security_dac.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/src/security/security_dac.c b/src/secu

Re: [libvirt] [PATCH] qemu: Fix job entry debug message

2015-11-11 Thread Peter Krempa
On Wed, Nov 11, 2015 at 15:15:56 +0100, Jiri Denemark wrote: > Logging current async job while in BeginJob is useful, but the async job > we want to start is even more interesting. A little confusing on the first read. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_domain.c | 16 ++

Re: [libvirt] [PATCH 2/3] qemu: Explain mlock limit size more in detail

2015-11-11 Thread Andrea Bolognani
On Wed, 2015-11-11 at 06:57 +0100, Peter Krempa wrote: > Based on Alex's explanation [1] in the recent discussion let's update > the comment explaining the memory lock limit calculation. > > [1] > http://www.redhat.com/archives/libvir-list/2015-November/msg00329.html I'd rather have the reference

[libvirt] [PATCH] qemu: Fix job entry debug message

2015-11-11 Thread Jiri Denemark
Logging current async job while in BeginJob is useful, but the async job we want to start is even more interesting. Signed-off-by: Jiri Denemark --- src/qemu/qemu_domain.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu

Re: [libvirt] [PATCH V2 1/9] qemu_migration: Add support for mutil-thread compressed migration enable

2015-11-11 Thread Jiri Denemark
On Sat, Nov 07, 2015 at 15:06:03 +, Feng, Shaohe wrote: > > > However, since we already have VIR_MIGRATE_COMPRESSED flag and I can > > imagine various other hypervisors could support > > their own compression methods, I think using flags for selecting the > > compression method is wrong. So

Re: [libvirt] [PATCH 1/3] qemu: domain: Restructurate control flow in qemuDomainGetMlockLimitBytes

2015-11-11 Thread Andrea Bolognani
On Wed, 2015-11-11 at 06:57 +0100, Peter Krempa wrote: > Break early when hard limit is set so that it's not intermixed by other > logic for determining the limit. > --- >  src/qemu/qemu_domain.c | 12 >  1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/src/qemu/qemu_do

Re: [libvirt] Abstracting device address allocation

2015-11-11 Thread Martin Kletzander
On Wed, Nov 11, 2015 at 12:15:22AM +0530, priyanshu jain wrote: Hello, Hi. I am undergraduate computer science student in india .I am new to opensource and i want to contribute to project abstracting device address allocation . I have good knowledge of c . please suggest me how i contribute

Re: [libvirt] discuss libvirt with lxc don't support network type:ethenet , thanks!

2015-11-11 Thread Martin Kletzander
On Wed, Nov 11, 2015 at 02:19:46AM +, Zhongguocheng wrote: Dear, I find that:current libvirt version with lxc hypervisor don’t support network type :Ethernet For example: xml is: //hypervisor is lxc ………. //network type is ethernet

Re: [libvirt] [PATCH] hypervisor driver for Jailhouse

2015-11-11 Thread Daniel P. Berrange
On Wed, Nov 11, 2015 at 01:07:20PM +0100, Andrea Bolognani wrote: > On Wed, 2015-11-11 at 09:17 +, Daniel P. Berrange wrote: > > > + */ > > > +struct jailhouse_driver { > > > > For naming can you make all structs have  'virJailHouse' as the > > name prefix. so eg virJailHouseDriver > > The pr

Re: [libvirt] [PATCH] hypervisor driver for Jailhouse

2015-11-11 Thread Andrea Bolognani
On Wed, 2015-11-11 at 09:17 +, Daniel P. Berrange wrote: > > + */ > > +struct jailhouse_driver { > > For naming can you make all structs have  'virJailHouse' as the > name prefix. so eg virJailHouseDriver The prefix should be virJailhouse, as that's the way the hypervisor name is styled in th

Re: [libvirt] [PATCH] hypervisor driver for Jailhouse

2015-11-11 Thread Christian Loehle
On 11/11/2015 10:17 AM, Daniel P. Berrange wrote: >> +/* >> + * Check cells for cell and copies UUID if found, otherwise generates a >> new one, this is to preserve UUID in libvirt >> + */ >> +static void setUUID(struct jailhouse_cell *cells, size_t count, struct >> jailhouse_cell* cell) { >> +

Re: [libvirt] strange stale qemu processes after domain shutdown

2015-11-11 Thread Vasiliy Tolstov
2015-10-23 11:57 GMT+03:00 Vasiliy Tolstov : > 2015-10-23 11:37 GMT+03:00 Michal Privoznik : >> That does not matter. We keep state XML for all running domains, >> regardless if they are persistent or transient. But since the daemon >> does not restart, I suspect we have a bug somewhere. >> BTW: yo

Re: [libvirt] [Xen-devel] [vbox-dev] Assert with libvirt + xen hvm

2015-11-11 Thread Ian Jackson
Cole Robinson writes ("Re: [Xen-devel] [libvirt] [vbox-dev] Assert with libvirt + xen hvm"): > I took a cursory look at libxl's sigchld handling... it's intense to say the > least, but there's some driver options that tweak the handling. Maybe there's > a simple fix. Sadly the way that there's a

Re: [libvirt] [PATCH v2 1/2] vz: add memory setting functions to driver

2015-11-11 Thread Dmitry Guryanov
On Wed, 2015-11-11 at 10:11 +0300, Nikolay Shirokovskiy wrote: > Implement functions for vz containers only. vz VMs memory > managment thru libvirt yet to be designed. > > vz memory management for containers is rather different from other > drivers. > > 1. Whole bunch of memory settings functions

Re: [libvirt] [PATCH 1/2] conf: add crash to hyperv features

2015-11-11 Thread Denis V. Lunev
On 11/11/2015 12:30 PM, Daniel P. Berrange wrote: On Wed, Nov 11, 2015 at 12:09:33PM +0300, Denis V. Lunev wrote: On 11/11/2015 11:57 AM, Dmitry Andreev wrote: Adding colleague to CC On 11.11.2015 11:34, Jiri Denemark wrote: On Wed, Nov 11, 2015 at 08:34:02 +0100, Peter Krempa wrote: On Thu,

Re: [libvirt] [PATCH v2 2/2] vz: factor out config update flags checks

2015-11-11 Thread Dmitry Guryanov
On Wed, 2015-11-11 at 10:11 +0300, Nikolay Shirokovskiy wrote: > Signed-off-by: Nikolay Shirokovskiy > --- >  src/vz/vz_driver.c |   86 +-- >  1 files changed, 29 insertions(+), 57 deletions(-) > > diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.

Re: [libvirt] [PATCH 1/2] conf: add crash to hyperv features

2015-11-11 Thread Daniel P. Berrange
On Wed, Nov 11, 2015 at 12:09:33PM +0300, Denis V. Lunev wrote: > On 11/11/2015 11:57 AM, Dmitry Andreev wrote: > >Adding colleague to CC > > > >On 11.11.2015 11:34, Jiri Denemark wrote: > >>On Wed, Nov 11, 2015 at 08:34:02 +0100, Peter Krempa wrote: > >>>On Thu, Nov 05, 2015 at 16:54:02 +0300, Dmi

Re: [libvirt] [PATCH 1/2] conf: add crash to hyperv features

2015-11-11 Thread Jiri Denemark
On Wed, Nov 11, 2015 at 12:09:33 +0300, Denis V. Lunev wrote: > On 11/11/2015 11:57 AM, Dmitry Andreev wrote: > > Adding colleague to CC > > > > On 11.11.2015 11:34, Jiri Denemark wrote: ... > >> Yeah, this what I was thinking about. After all, we already do something > >> similar on Power. The gue

Re: [libvirt] [PATCH 1/2] conf: add crash to hyperv features

2015-11-11 Thread Paolo Bonzini
On 11/11/2015 10:09, Denis V. Lunev wrote: > QEMU accepts this option through HyperV set of CPU options. > Thus your proposal means that in this case we will have to add > this option to CPU part of the command line from devices > part. > > Is this correct? > > And, finally, 'no', this is not a

Re: [libvirt] [PATCH] hypervisor driver for Jailhouse

2015-11-11 Thread Daniel P. Berrange
On Wed, Nov 11, 2015 at 09:39:53AM +0100, Christian Loehle wrote: > diff --git a/configure.ac b/configure.ac > index f481c50..8b68828 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -563,6 +563,10 @@ AC_ARG_WITH([hyperv], >[AS_HELP_STRING([--with-hyperv], > [add Hyper-V support @<:@d

Re: [libvirt] [PATCH 1/2] conf: add crash to hyperv features

2015-11-11 Thread Denis V. Lunev
On 11/11/2015 11:57 AM, Dmitry Andreev wrote: Adding colleague to CC On 11.11.2015 11:34, Jiri Denemark wrote: On Wed, Nov 11, 2015 at 08:34:02 +0100, Peter Krempa wrote: On Thu, Nov 05, 2015 at 16:54:02 +0300, Dmitry Andreev wrote: On 05.11.2015 14:06, Jiri Denemark wrote: On Mon, Oct 26,

Re: [libvirt] [PATCH 1/2] conf: add crash to hyperv features

2015-11-11 Thread Dmitry Andreev
Adding colleague to CC On 11.11.2015 11:34, Jiri Denemark wrote: On Wed, Nov 11, 2015 at 08:34:02 +0100, Peter Krempa wrote: On Thu, Nov 05, 2015 at 16:54:02 +0300, Dmitry Andreev wrote: On 05.11.2015 14:06, Jiri Denemark wrote: On Mon, Oct 26, 2015 at 13:23:32 +0300, Dmitry Andreev wrote:

Re: [libvirt] [PATCH] hypervisor driver for Jailhouse

2015-11-11 Thread Christian Loehle
On 11/11/2015 06:06 AM, Peter Krempa wrote: > On Tue, Nov 10, 2015 at 13:17:41 +0100, Christian Loehle wrote: >> >From README: >> The jailhouse hypervisor driver for the libvirt project aims to provide >> rudimentary support for managing jailhouse with the libvirt library. The >> main advantage of

Re: [libvirt] [PATCH] hypervisor driver for Jailhouse

2015-11-11 Thread Christian Loehle
>From e523057e7068e283b74d78bb8d707d83f6e73c24 Mon Sep 17 00:00:00 2001 From: Christian Loehle Date: Wed, 11 Nov 2015 09:21:54 +0100 Subject: [PATCH] hypervisor driver for Jailhouse --- configure.ac | 21 ++ include/libvirt/virterror.h | 1 + po/POTFILES.in

Re: [libvirt] [PATCH 1/2] conf: add crash to hyperv features

2015-11-11 Thread Jiri Denemark
On Wed, Nov 11, 2015 at 08:34:02 +0100, Peter Krempa wrote: > On Thu, Nov 05, 2015 at 16:54:02 +0300, Dmitry Andreev wrote: > > > > > > On 05.11.2015 14:06, Jiri Denemark wrote: > > > On Mon, Oct 26, 2015 at 13:23:32 +0300, Dmitry Andreev wrote: > > >> Add crash CPU feature for Hyper-V. Hyper-V c

Re: [libvirt] [PATCH] hypervisor driver for Jailhouse

2015-11-11 Thread Daniel P. Berrange
On Tue, Nov 10, 2015 at 01:17:41PM +0100, Christian Loehle wrote: > >From README: > The jailhouse hypervisor driver for the libvirt project aims to provide > rudimentary support for managing jailhouse with the libvirt library. The > main advantage of this is the possibility to use virt-manager as a

Re: [libvirt] libvirt-snmp development

2015-11-11 Thread Daniel P. Berrange
On Tue, Nov 10, 2015 at 09:29:19PM +, Dmitry Mishin wrote: > Hi, > > On 10/11/15 15:09, "libvir-list-boun...@redhat.com on behalf of Maxim > Nestratov" mnestra...@virtuozzo.com> wrote: > > > > >10.11.2015 13:36, Martin Kletzander пишет: > >> On Tue, Nov 10, 2015 at 12:40:36PM +0300, Maxim Ne

Re: [libvirt] [PATCH v2 02/17] qemu: remove all support for kQEMU

2015-11-11 Thread Daniel P. Berrange
On Wed, Nov 11, 2015 at 08:11:16AM +0100, Jiri Denemark wrote: > On Tue, Nov 10, 2015 at 12:06:21 -0700, Eric Blake wrote: > > On 11/09/2015 09:24 AM, Daniel P. Berrange wrote: > > > The kQEMU accelerator was deleted in QEMU 0.12, so we no > > > longer need to support it in the QEMU driver. > > >