Re: [libvirt] [PATCH v2] syntax-check: Add prohibit_space_in_label rule

On Mon, 2015-11-16 at 15:05 +0100, Martin Kletzander wrote: > > +# Allow for up to three spaces before the label: this is to avoid running > > +# into situations where require_space_before_label is not applied, eg. a > > +# line matching ^[a-zA-Z0-9]+ :$ > > +sc_prohibit_space_in_label: > > +

Re: [libvirt] [QEMU PATCH] target-i386: Disable rdtscp on Opteron_G* CPU models

On Mon, Nov 16, 2015 at 10:44:59AM +0100, Paolo Bonzini wrote: > > > On 13/11/2015 20:07, Eduardo Habkost wrote: > > KVM can't virtualize rdtscp on AMD CPUs yet, so there's no point > > in enabling it by default on AMD CPU models, as all we are > > getting are confused users because of the "host

Re: [libvirt] [PATCH v3 08/11] admin: Add support for URI aliases

On Fri, Nov 06, 2015 at 12:46:23PM +0100, Erik Skultety wrote: Now that we introduced URI support in libvirt-admin, we should also support URI aliases during connection establishment phase. After applying this patch, virAdmConnectOpen will also support VIR_CONNECT_NO_ALIASES flag. ---

Re: [libvirt] [PATCH v3 09/11] admin: Add support for connection close callbacks

On Fri, Nov 06, 2015 at 12:46:24PM +0100, Erik Skultety wrote: As we need a client disconnect handler, we also need a mechanism to register such handlers for a client. This patch introduced both the close callbacks and also the client vshAdmCatchDisconnect handler to be registered with it. By

Re: [libvirt] [PATCH v3 01/11] libvirt: Export libvirt config getters by moving them to util

On Fri, Nov 06, 2015 at 12:46:16PM +0100, Erik Skultety wrote: virConnectGetConfig and virConnectGetConfigPath were static libvirt methods, merely because there hasn't been any need for having them internally exported yet. Since libvirt-admin also needs to reference libvirt config file,

Re: [libvirt] [PATCH v3 02/11] virt-admin: Introduce first working skeleton

On Fri, Nov 06, 2015 at 12:46:17PM +0100, Erik Skultety wrote: This patch introduces virt-admin client which is based on virsh client, but had to reimplement several methods to meet virt-admin specific needs or remove unnecessary virsh specific logic. --- .gitignore | 1 +

Re: [libvirt] [PATCH v3 06/11] admin: Add URI support and introduce virAdmGetDefaultURI

On Fri, Nov 06, 2015 at 12:46:21PM +0100, Erik Skultety wrote: Since virt-admin should be able to connect to various admin servers on hosted different daemons, we need to provide URI support to libvirt-admin. --- include/libvirt/libvirt-admin.h | 2 + src/datatypes.c | 2 +

Re: [libvirt] [PATCH v3 10/11] admin: Introduce virAdmConnectGetLibVersion

On Fri, Nov 06, 2015 at 12:46:25PM +0100, Erik Skultety wrote: Introduce a new API to get libvirt version. It is worth noting, that libvirt-admin and libvirt share the same version number. Unfortunately, our existing API isn't generic enough to be used with virAdmConnectPtr as well. Also this

Re: [libvirt] [PATCH v3 02/11] virt-admin: Introduce first working skeleton

On Fri, Nov 06, 2015 at 12:46:17PM +0100, Erik Skultety wrote: This patch introduces virt-admin client which is based on virsh client, but had to reimplement several methods to meet virt-admin specific needs or remove unnecessary virsh specific logic. --- .gitignore | 1 +

Re: [libvirt] [PATCH 19/24] qemu: Introduce qemuProcessLaunch

On Fri, Nov 13, 2015 at 10:17:16 -0500, John Ferlan wrote: > > > On 11/12/2015 01:37 PM, Jiri Denemark wrote: > > Once qemuProcessInit was called, qemuProcessLaunch will launch a new > > QEMU process with stopped virtual CPUs. > > > > Signed-off-by: Jiri Denemark > > --- >

Re: [libvirt] [PATCH v3 03/11] admin: Introduce virAdmConnectIsAlive

On Fri, Nov 06, 2015 at 12:46:18PM +0100, Erik Skultety wrote: Since most of our APIs rely on an acive functional connection to a daemon and we have such a mechanism in libvirt already, there's need to have such a way in libvirt-admin as well. By introducing a new public API, this patch provides

Re: [libvirt] [PATCH v3 07/11] livirt: Move URI alias matching to util

On Fri, Nov 06, 2015 at 12:46:22PM +0100, Erik Skultety wrote: As we need to provide support for URI aliases in libvirt-admin as well, URI alias matching needs to be internally visible. Since virConnectOpenResolveURIAlias does have a compatible signature, it could be easily reused by

Re: [libvirt] [PATCH v3 09/11] admin: Add support for connection close callbacks

On Mon, Nov 16, 2015 at 05:40:07PM +0100, Martin Kletzander wrote: > On Fri, Nov 06, 2015 at 12:46:24PM +0100, Erik Skultety wrote: > >As we need a client disconnect handler, we also need a mechanism to register > >such handlers for a client. This patch introduced both the close callbacks > >and

Re: [libvirt] [PATCH] bhyve: monitor: do not override domain's privateData

On Wed, Nov 04, 2015 at 06:08:00PM +0300, Roman Bogorodskiy wrote: > Current monitor code overrides domain object's privateData, e.g. > in virBhyveProcessStart(): > > vm->privateData = bhyveMonitorOpen(vm, driver); > > where bhyveMonitorPtr() returns bhyveMonitorPtr. > > This is not right

Re: [libvirt] [PATCH v2] syntax-check: Add prohibit_space_in_label rule

On Mon, Nov 02, 2015 at 12:12:22PM +0100, Andrea Bolognani wrote: This guards against code such as cleanup : which is happily accepted by the compiler but does not conform to our style guidelines. --- cfg.mk | 9 + 1 file changed, 9 insertions(+) diff --git a/cfg.mk b/cfg.mk index

[libvirt] [PATCH 1/1] virt-aa-helper: support OVMF

As suggested by Jamie Strandboge in https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1483071 Signed-off-by: Serge Hallyn --- src/security/virt-aa-helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c

Re: [libvirt] [PATCH java] Add support for Libvirt Qemu Library

On 11/15/2015 11:26 PM, Claudio Bley wrote: > At Fri, 13 Nov 2015 14:59:52 +0100, > Wido den Hollander wrote: >> >> >> >> On 12-11-15 23:04, Claudio Bley wrote: >>> Hi. >>> >>> At Mon, 9 Nov 2015 13:48:18 +0100, >>> Wido den Hollander wrote: This allows us to send Qemu Guest Agent

Re: [libvirt] split string into tokens via libvirt

I'm solve, firstly by hands I'm parse from first char to end of word with backslash, after that simply split string via libvirt virStringSplit 16 нояб. 2015 г. 13:06 пользователь "Vasiliy Tolstov" написал: > Hi. I'm need to parse string like "= test\ aaa 3 10 0 0 1336557216

Re: [libvirt] [PATCH RFC] libxl: use libxl_event_wait to process libxl events

Am Fri, 13 Nov 2015 14:36:54 -0700 schrieb Jim Fehlig : Hi, i have tested the patches provide by Jim Fehlig. The setup consist of xen 4.6.0 with libvirt 1.2.19 and the patches. As i describe in my posting in the libvirt-user list

Re: [libvirt] [PATCH v3 3/8] libxl: implement virDomainInterfaceStats

On 11/13/2015 06:14 AM, Joao Martins wrote: > Introduce support for domainInterfaceStats API call for querying > network interface statistics. Consequently it also enables the > use of `virsh domifstat ` command. > > After succesful guest creation we fill the network > interfaces names based on

Re: [libvirt] [PATCH v3 2/8] libxl: implement virDomainMemorystats

On 11/13/2015 06:14 AM, Joao Martins wrote: > Introduce support for domainMemoryStats API call, which > consequently enables the use of `virsh dommemstat` command to > query for memory statistics of a domain. We support > the following statistics: balloon info, available and currently > in use.

Re: [libvirt] [PATCH v3 1/8] libxl: implement virDomainGetCPUStats

On 11/13/2015 06:14 AM, Joao Martins wrote: > Introduce support for domainGetCPUStats API call and consequently > allow us to use `virsh cpu-stats`. The latter returns a more brief > output than the one provided by`virsh vcpuinfo`. > > Signed-off-by: Joao Martins > ---

[libvirt] [PATCH] tpm: adapt sysfs cancel path for new TPM driver

Adapt the sysfs TPM command cancel path for the TPM driver that does not use a miscdevice anymore since Linux 4.0. Support old and new paths. Signed-off-by: Stefan Berger --- src/util/virtpm.c | 21 +++--

[libvirt] split string into tokens via libvirt

Hi. I'm need to parse string like "= test\ aaa 3 10 0 0 1336557216 7c2b27 3 22" I can use virStringSplitCount, but second word contains space and splitting not works right. Does this need i need to parse string by hand via strtok ? -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru -- libvir-list

Re: [libvirt] [PATCH] util: remove unnecessary needSize

On Sat, Nov 14, 2015 at 02:56:06PM +0800, Chen Hanxiao wrote: From: Chen Hanxiao Use toadd->use directly. Signed-off-by: Chen Hanxiao --- src/util/virbuffer.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) ACK, good catch. Although

Re: [libvirt] [PATCH v2] gobject: Add wrapper virDomainSetTime()

On Fri, Nov 13, 2015 at 02:13:35PM -0500, Zeeshan Ali (Khattak) wrote: > Hi, > > >> +guint settime_flags; > >> + > >> +g_return_val_if_fail(GVIR_IS_DOMAIN(dom), FALSE); > >> +g_return_val_if_fail(err == NULL || *err == NULL, FALSE); > > > > I'd keep a g_return_val_if_fail(flags == 0,

Re: [libvirt] [QEMU PATCH] target-i386: Disable rdtscp on Opteron_G* CPU models

On 13/11/2015 20:07, Eduardo Habkost wrote: > KVM can't virtualize rdtscp on AMD CPUs yet, so there's no point > in enabling it by default on AMD CPU models, as all we are > getting are confused users because of the "host doesn't support > requested feature" warnings. > > Disable rdtscp on

Re: [libvirt] [PATCH java] Add support for Libvirt Qemu Library

At Mon, 16 Nov 2015 21:26:57 +0100, Wido den Hollander wrote: > > > > > Since there are no flags currently, simply drop the flags > > parameter. We add flags (as enums) later when the function starts to > > support one. > > > > Good point, I'll come up with a revised patch. > > >

Re: [libvirt] [PATCH 1/1] virt-aa-helper: support OVMF

On Mon, Nov 16, 2015 at 05:59:08PM +, Serge Hallyn wrote: > > As suggested by Jamie Strandboge in > > https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1483071 > > Signed-off-by: Serge Hallyn > --- > src/security/virt-aa-helper.c | 3 ++- > 1 file changed, 2

[libvirt] [PATCH] libvirt-guests: Disable shutdown timeout

Since we can't know at service start how many VMs will be running we can't calculate an apropriate shutdown timeout. So instead of killing off the service just let it use it's own internal timeout mechanism. References: http://bugs.debian.org/803714