[libvirt] [PATCH] Wait for udev events to be handled after removing veth

As per http://www.redhat.com/archives/libvir-list/2013-July/msg01279.html, wait for udev events to be handled after removing a virtual NIC. Any udev rule associated to NIC destroy could happen to run with a new device with the same name that is being created. --- src/util/virnetdevveth.c | 3 +++

Re: [libvirt] [PATCH] lxc: drop sys_admin caps by default

On Wed, 2015-11-25 at 15:22 +, Daniel P. Berrange wrote: > On Wed, Nov 25, 2015 at 03:40:36PM +0100, Cédric Bosdonnat wrote: > > To make sure the container user doesn't play with mounts, like > > changing them from ro to rw, drop the sys_admin capability by default. > > If user really needs to

Re: [libvirt] [PATCH 2/3] virt-aa-helper: don't deny writes to readonly mounts

Hi all, Has that patch been skipped in the review process? -- Cedric On Tue, 2015-11-17 at 15:14 +0100, Cédric Bosdonnat wrote: > There is no need to deny writes on a readonly mount: write still > won't be accepted, even if the user remounts the folder as RW in > the guest as qemu sets the 9p

[libvirt] [PATCHv2 0/4] Implement shared memory device (cold) hot-plug/unplug

v1: https://www.redhat.com/archives/libvir-list/2015-June/msg00830.html These patches implement the hot-plug/hot-unplug and cold-plug/cold-unplug for Inter-VM Shared Memory PCI device. Luyao Huang (4): conf: Add helpers to insert/remove/find shmem devices in domain def qemu: Implement shared

[libvirt] [PATCHv2 1/4] conf: Add helpers to insert/remove/find shmem devices in domain def

The helpers will be useful when implementing hotplug and coldplug of shared memory devices. Signed-off-by: Luyao Huang --- src/conf/domain_conf.c | 66 src/conf/domain_conf.h | 7 + src/libvirt_private.syms | 3 +++ 3

[libvirt] [PATCHv2 2/4] qemu: Implement shared memory device cold (un)plug

Add support for using the attach/detach device APIs on the inactive configuration to add/del shared memory devices. Signed-off-by: Luyao Huang --- src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 21 +++-- 2 files changed, 20 insertions(+), 2

[libvirt] [PATCHv2 4/4] qemu: Implement shared memory device hot-unplug

Signed-off-by: Luyao Huang --- src/qemu/qemu_driver.c | 4 ++- src/qemu/qemu_hotplug.c | 94 - src/qemu/qemu_hotplug.h | 3 ++ 3 files changed, 99 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCHv2 3/4] qemu: Implement share memory device hot-plug

Signed-off-by: Luyao Huang --- src/qemu/qemu_driver.c | 10 - src/qemu/qemu_hotplug.c | 58 + src/qemu/qemu_hotplug.h | 3 +++ 3 files changed, 70 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH] schema: use a better regex for listen addresses

A domain with '::' as the listen address fails to validate. Reuse the 'ipAddr' and 'dnsName' regexes from basictypes instead of reinventing them. https://bugzilla.redhat.com/show_bug.cgi?id=1285665 --- docs/schemas/domaincommon.rng| 7 ---

Re: [libvirt] [PATCH 13/34] conf: Move vcpu count check into helper

On Mon, Nov 23, 2015 at 10:35:34 -0500, John Ferlan wrote: > > > On 11/20/2015 10:22 AM, Peter Krempa wrote: > > --- > > src/conf/domain_conf.c | 14 +++--- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > >

Re: [libvirt] [PATCH] schema: use a better regex for listen addresses

On Thu, Nov 26, 2015 at 10:43:15 +0100, Ján Tomko wrote: > A domain with '::' as the listen address fails to validate. > > Reuse the 'ipAddr' and 'dnsName' regexes from basictypes instead > of reinventing them. > > https://bugzilla.redhat.com/show_bug.cgi?id=1285665 > --- >

Re: [libvirt] [PATCH] Enhance documentation of virDomainDetachDevice

On Wed, Nov 25, 2015 at 16:42:34 +0100, Jiri Denemark wrote: > Link it to virDomainDetachDeviceFlags. > > https://bugzilla.redhat.com/show_bug.cgi?id=1257280 > > Signed-off-by: Jiri Denemark > --- > src/libvirt-domain.c | 15 +++ > 1 file changed, 3

Re: [libvirt] [PATCH] schema: use a better regex for listen addresses

On Thu, Nov 26, 2015 at 10:43:15 +0100, Ján Tomko wrote: > A domain with '::' as the listen address fails to validate. > > Reuse the 'ipAddr' and 'dnsName' regexes from basictypes instead > of reinventing them. > > https://bugzilla.redhat.com/show_bug.cgi?id=1285665 > --- >

Re: [libvirt] [libvirt-glib v5] gobject: Port to GTask API

Hey, Still a couple of comments :( On Wed, Nov 25, 2015 at 09:46:58PM +, Zeeshan Ali (Khattak) wrote: > diff --git a/libvirt-gobject/libvirt-gobject-input-stream.c > b/libvirt-gobject/libvirt-gobject-input-stream.c > index ff1a70c..8ef60d6 100644 > ---

Re: [libvirt] [PATCH 19/34] qemu: Split up vCPU hotplug and hotunplug

On Mon, Nov 23, 2015 at 14:19:58 -0500, John Ferlan wrote: > On 11/20/2015 10:22 AM, Peter Krempa wrote: > > There's only very little common code among the two operations. Split the > > functions so that the internals are easier to understand and refactor > > later. > > --- > >

Re: [libvirt] [PATCH 22/34] qemu: monitor: Remove weird return values from qemuMonitorSetCPU

On Mon, Nov 23, 2015 at 15:07:32 -0500, John Ferlan wrote: > On 11/20/2015 10:22 AM, Peter Krempa wrote: > > Let the function report errors internally and change it to return > > standard return codes. > > --- > > src/qemu/qemu_driver.c | 22 -- > >

Re: [libvirt] [PATCH 24/34] qemu: Refactor qemuDomainHotplugVcpus

On Mon, Nov 23, 2015 at 16:39:54 -0500, John Ferlan wrote: > > > On 11/20/2015 10:22 AM, Peter Krempa wrote: > > Refactor the code flow so that 'exit_monitor:' can be removed. > > > > This patch also moves the auditing and setting of the new vCPU count > > right to the place where the hotplug

[libvirt] [PATCH 4/8] conf: Extract UUID parsing into its own function

Create virDomainDefParseUUID that parses only the UUID from XML definition. This will be used in future patch(es). Signed-off-by: Martin Kletzander --- src/conf/domain_conf.c | 64 +++--- 1 file changed, 45 insertions(+), 19

[libvirt] [PATCH 5/8] conf: Optionally keep domains with invalid XML, but don't allow starting them

Add new parameter to virDomainObjListLoadConfig() and virDomainObjListLoadAllConfigs() that controls whether domains with invalid XML (which could not be parsed) should be kept in order not to lose track of them. For now, the parameter is set to false in all callers. Each driver can switch it to

[libvirt] [PATCH 8/8] qemu: Load domains with invalid XML on start

If we load such domains, we don't need to handle invalid XML checking in qemuProcessStart, but we can move it to qemuDomainDefPostParse() or even into the parsing functions if all goes well. So the only thing we'll need to worry about after this is XML parsing code that would error out for

[libvirt] [PATCH 1/8] conf, virsh: Add new domain shutoff reason

This new reason means the domain is shutoff because parsing of the XML failed while daemon was starting and from user's point of view, there's nothing else to do with it other than re-defining it. Signed-off-by: Martin Kletzander --- include/libvirt/libvirt-domain.h | 2 ++

[libvirt] [PATCH 2/8] qemu: Few whitespace cleanups

Signed-off-by: Martin Kletzander --- src/qemu/qemu_driver.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 65ccf99986af..65437cc749f8 100644 --- a/src/qemu/qemu_driver.c +++

[libvirt] [PATCH 7/8] qemu: Prepare basic APIs to handle invalid defs

In order for the user to be able to fix broken domains function qemuDomainGetXMLDesc() needs to be able to lookup invalid domain definitions and handle them properly. When redefined, function qemuDomainDefineXMLFlags() must clear the 'invalid XML' reason. As a nice addition, qemuDomainGetState()

[libvirt] [PATCH 0/8] Make loading domains with invalid XML possible

The RFC version [1] was ACKed, but I have found out that we could then cause inconsistency by calling virDomainCreateXML() or Restore() calls etc. This series is basically the same apart from the fact that it is rebased on current master and then one simple diff [2] is added to PATCH 5/8. [1]

[libvirt] [PATCH 3/8] conf: Extract name-parsing into its own function

Create virDomainDefParseName that parses only the name from XML definition. This will be used in future patches. Signed-off-by: Martin Kletzander --- src/conf/domain_conf.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git

[libvirt] [PATCH 6/8] qemu: Don't lookup invalid domains unless specified otherwise

Change qemuDomObjFromDomain() to qemuDomObjFromDomainInternal() with additional parameter that controls how to deal with invalid domains. New qemuDomObjFromDomain() then follows the safe path wo we don't have to change its callers from all APIs and qemuDomObjFromDomainInvalid() is added as a new

[libvirt] [PATCH] systemd: Escape machine name for machined

According to the documentation, CreateMachine accepts only 7bit ASCII characters in the machinename parameter, so let's make sure we can start machines with unicode names with systemd. We already have a function for that, we just forgot to use it. Resolves:

[libvirt] [PATCH] virsh: Try to keep printed XML pretty with change-media

When adding a new media with change-media and --print-xml, let's try making it more readable and nice. Before: ... After: ... Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1219719 Signed-off-by: Martin Kletzander ---

Re: [libvirt] [PATCH] virsh: Try to keep printed XML pretty with change-media

On Thu, Nov 26, 2015 at 14:29:20 +0100, Martin Kletzander wrote: > When adding a new media with change-media and --print-xml, let's try > making it more readable and nice. > > Before: > > ... > > > > > After: > > ... > > > > > > Resolves:

Re: [libvirt] [PATCH 27/34] conf: ABI: Split up and improve vcpu info ABI checking

On Mon, Nov 23, 2015 at 17:41:05 -0500, John Ferlan wrote: > > > On 11/20/2015 10:22 AM, Peter Krempa wrote: > > Extract the checking code into a separate function and prepare the > > infrastructure for checking the new structure type. > > --- > > src/conf/domain_conf.c | 41

Re: [libvirt] [PATCH] systemd: Escape machine name for machined

On 26.11.2015 14:24, Martin Kletzander wrote: > According to the documentation, CreateMachine accepts only 7bit ASCII > characters in the machinename parameter, so let's make sure we can start > machines with unicode names with systemd. We already have a function > for that, we just forgot to use

Re: [libvirt] [PATCH] virsh: Try to keep printed XML pretty with change-media

On Thu, Nov 26, 2015 at 02:40:55PM +0100, Peter Krempa wrote: On Thu, Nov 26, 2015 at 14:29:20 +0100, Martin Kletzander wrote: When adding a new media with change-media and --print-xml, let's try making it more readable and nice. Before: ... After: ...

Re: [libvirt] [PATCH 2/3] virt-aa-helper: don't deny writes to readonly mounts

Hi, On Tue, Nov 17, 2015 at 03:14:51PM +0100, Cédric Bosdonnat wrote: > There is no need to deny writes on a readonly mount: write still > won't be accepted, even if the user remounts the folder as RW in > the guest as qemu sets the 9p mount as ro. Wouldn't a security whole in qemu possibly allow

Re: [libvirt] [PATCH] Wait for udev events to be handled after removing veth

On 26.11.2015 09:15, Cédric Bosdonnat wrote: > As per http://www.redhat.com/archives/libvir-list/2013-July/msg01279.html, > wait for udev events to be handled after removing a virtual NIC. > Any udev rule associated to NIC destroy could happen to run with a new > device with the same name that is

Re: [libvirt] [PATCH 2/3] virt-aa-helper: don't deny writes to readonly mounts

On Thu, 2015-11-26 at 15:42 +0100, Guido Günther wrote: > Hi, > On Tue, Nov 17, 2015 at 03:14:51PM +0100, Cédric Bosdonnat wrote: > > There is no need to deny writes on a readonly mount: write still > > won't be accepted, even if the user remounts the folder as RW in > > the guest as qemu sets the

Re: [libvirt] [PATCH] Wait for udev events to be handled after removing veth

On Thu, Nov 26, 2015 at 04:01:31PM +0100, Michal Privoznik wrote: > On 26.11.2015 09:15, Cédric Bosdonnat wrote: > > As per http://www.redhat.com/archives/libvir-list/2013-July/msg01279.html, > > wait for udev events to be handled after removing a virtual NIC. > > Any udev rule associated to NIC

[libvirt] [PATCH] network: selectively disable -Wcast-align in virNetDevParseDadStatus

Commit 0f7436ca54c9 "network: wait for DAD to finish for bridge IPv6 addresses" results in: CC util/libvirt_util_la-virnetdevmacvlan.lo util/virnetdev.c: In function 'virNetDevParseDadStatus': util/virnetdev.c:1319:188: error: cast increases required alignment of target type

[libvirt] libprl_sdk.so.7 library dependancies

In debugging some recent problem I was rather surprised to find that libvirt.so was linked against Qt, X11 and GObject. It turns out that this is due to the VZ driver linking to libprl_sdk.so which pulls in all these libs: $ ldd /usr/lib64/libprl_sdk.so.7.0.26 linux-vdso.so.1

[libvirt] [PATCH v3 0.5/11] libvirt: introduce libvirt/libvirt-common.h.in

As it turned out, we need to share some enums and declarations between libvirt.h and libvirt-admin.h, but since our policy forbids direct includes of libvirt*.h, there has to be some header exempt from this rule. This patch moves the relevant part of code from libvirt.h.in to libvirt-common.h.in.

[libvirt] [PATCH v3 2.5/11] admin: Introduce libvirt-admin.conf

Since libvirt-admin is a separate library, it should also have a separate config file. Available settings are currently the same as for libvirt.conf. --- I'd like add a couple more patches as a reaction to some reviews of this series, namely, adding a new admin configuration file, adding a new

[libvirt] [PATCH v3 1.5/11] admin: introduce virAdmGetVersion

Unfortunately, client side version retrieval API virGetVersion uses one-time initialization (due to the fact we might not have initialized the library by calling connect prior to this) which is not completely compatible with admin initialization. This API is rather simplistic and reimplementing it

Re: [libvirt] [libvirt-glib v5] gobject: Port to GTask API

On Thu, Nov 26, 2015 at 10:20 AM, Christophe Fergeau wrote: > Hey, > > Still a couple of comments :( Fixed and pushed. Thanks for reviews. -- Regards, Zeeshan Ali (Khattak) Befriend GNOME: http://www.gnome.org/friends/ --

[libvirt] Bug in RPC code causes failure to start LXC container using virDomainCreateXMLWithFiles

Hi, Occasionally when trying to start LXC containers with fds I get the following error: virNetMessageDupFD:562 : Unable to duplicate FD -1: Bad file descriptor I tracked it down to the code that handles EAGAIN errors from recvfd. In such cases the

[libvirt] [PATCH LIBVIRT v1 0/2] Support maxvcpus (AKA >1 vcpu on Xen/ARM)

libvirt currently clamps the maximum number of vcpus to MAX_VIRT_CPUS == XEN_LEGACY_MAX_VCPUS, which on ARM is 1 (because all guests are expected to support vcpu info placement). Even on x86 this limitation is a hold over from an older xm interface where the maximum number of vcpus was expressed

[libvirt] [PATCH LIBVIRT v1 1/2] libxl: Correct value for xendConfigVersion to xen{Parse, Format}ConfigCommon

libxlConnectDomainXMLFromNative calls both xenParseXM and xenParseXL with cfg->verInfo->xen_version_major, however AFAICT they both (either inherently, or through there use of xenParseConfigCommon expect a value from xenConfigVersionEnum (which does not correspond to xen_version_major). The

[libvirt] [PATCH LIBVIRT v1 2/2] xen: Handle maxcpus in xl configutation files

This new cfg field was addded in 4.0 by 68a94cf528e6 "xm: Add maxvcpus support" and, more crucially these day, it is what xl supports. This removes the MAX_VIRT_CPUS limitation for such versions of Xen (since maxvcpus is simply a count, not a bit mask) which is particularly crucial on ARM where

Re: [libvirt] libprl_sdk.so.7 library dependancies

26.11.2015 18:19, Daniel P. Berrange пишет: In debugging some recent problem I was rather surprised to find that libvirt.so was linked against Qt, X11 and GObject. It turns out that this is due to the VZ driver linking to libprl_sdk.so which pulls in all these libs: $ ldd

[libvirt] [PATCH] virtlogd: cast maxlen to size_t

Otherwise we fail on 32bit with: CC logging/virtlogd-log_daemon_dispatch.o logging/log_daemon_dispatch.c: In function 'virLogManagerProtocolDispatchDomainReadLogFile': logging/log_daemon_dispatch.c:120:9: error: format '%zu' expects argument of type 'size_t', but argument 7 has type

Re: [libvirt] [PATCH] virtlogd: cast maxlen to size_t

On Thu, Nov 26, 2015 at 06:12:38PM +0100, Guido Günther wrote: > Otherwise we fail on 32bit with: > > CC logging/virtlogd-log_daemon_dispatch.o > logging/log_daemon_dispatch.c: In function > 'virLogManagerProtocolDispatchDomainReadLogFile': > logging/log_daemon_dispatch.c:120:9: error:

Re: [libvirt] [PATCH 2/3] virt-aa-helper: don't deny writes to readonly mounts

On Thu, Nov 26, 2015 at 04:02:03PM +0100, Cedric Bosdonnat wrote: > On Thu, 2015-11-26 at 15:42 +0100, Guido Günther wrote: > > Hi, > > On Tue, Nov 17, 2015 at 03:14:51PM +0100, Cédric Bosdonnat wrote: > > > There is no need to deny writes on a readonly mount: write still > > > won't be accepted,

Re: [libvirt] [PATCH] virtlogd: cast maxlen to size_t

On Thu, Nov 26, 2015 at 05:19:30PM +, Daniel P. Berrange wrote: > On Thu, Nov 26, 2015 at 06:12:38PM +0100, Guido Günther wrote: > > Otherwise we fail on 32bit with: > > > > CC logging/virtlogd-log_daemon_dispatch.o > > logging/log_daemon_dispatch.c: In function > >

[libvirt] [PATCH] virtlogd: use PRIu64 to print 64bit types

Otherwise we fail on 32bit with: CC logging/virtlogd-log_daemon_dispatch.o logging/log_daemon_dispatch.c: In function 'virLogManagerProtocolDispatchDomainReadLogFile': logging/log_daemon_dispatch.c:120:9: error: format '%zu' expects argument of type 'size_t', but argument 7 has type

Re: [libvirt] [PATCH] virtlogd: use PRIu64 to print 64bit types

On Thu, Nov 26, 2015 at 06:46:13PM +0100, Guido Günther wrote: > Otherwise we fail on 32bit with: > > CC logging/virtlogd-log_daemon_dispatch.o > logging/log_daemon_dispatch.c: In function > 'virLogManagerProtocolDispatchDomainReadLogFile': > logging/log_daemon_dispatch.c:120:9: error:

Re: [libvirt] [PATCH] virtlogd: use PRIu64 to print 64bit types

On Thu, Nov 26, 2015 at 05:52:11PM +, Daniel P. Berrange wrote: > On Thu, Nov 26, 2015 at 06:46:13PM +0100, Guido Günther wrote: > > Otherwise we fail on 32bit with: > > > > CC logging/virtlogd-log_daemon_dispatch.o > > logging/log_daemon_dispatch.c: In function > >

Re: [libvirt] [PATCH] virtlogd: use PRIu64 to print 64bit types

On Thu, Nov 26, 2015 at 07:13:40PM +0100, Guido Günther wrote: > On Thu, Nov 26, 2015 at 05:52:11PM +, Daniel P. Berrange wrote: > > On Thu, Nov 26, 2015 at 06:46:13PM +0100, Guido Günther wrote: > > > Otherwise we fail on 32bit with: > > > > > > CC logging/virtlogd-log_daemon_dispatch.o

[libvirt] [PATCH] virtlogd: use %llu to print 64bit types

Otherwise we fail on 32bit with: CC logging/virtlogd-log_daemon_dispatch.o logging/log_daemon_dispatch.c: In function 'virLogManagerProtocolDispatchDomainReadLogFile': logging/log_daemon_dispatch.c:120:9: error: format '%zu' expects argument of type 'size_t', but argument 7 has type

Re: [libvirt] [PATCH] virtlogd: use %llu to print 64bit types

On Thu, Nov 26, 2015 at 07:33:38PM +0100, Guido Günther wrote: > Otherwise we fail on 32bit with: > > CC logging/virtlogd-log_daemon_dispatch.o > logging/log_daemon_dispatch.c: In function > 'virLogManagerProtocolDispatchDomainReadLogFile': > logging/log_daemon_dispatch.c:120:9: error:

Re: [libvirt] [PATCH] virtlogd: use %llu to print 64bit types

On Thu, Nov 26, 2015 at 06:36:10PM +, Daniel P. Berrange wrote: > On Thu, Nov 26, 2015 at 07:33:38PM +0100, Guido Günther wrote: > > Otherwise we fail on 32bit with: > > > > CC logging/virtlogd-log_daemon_dispatch.o > > logging/log_daemon_dispatch.c: In function > >

Re: [libvirt] [PATCH 31/34] qemu: Replace checking for vcpu<->pid mapping availability with a helper

On Mon, Nov 23, 2015 at 18:19:18 -0500, John Ferlan wrote: > On 11/20/2015 10:22 AM, Peter Krempa wrote: > > Add qemuDomainHasVCpuPids to do the checking and replace in place checks > > with it. > > --- > > src/qemu/qemu_cgroup.c | 7 ++- > > src/qemu/qemu_domain.c | 15 +++ > >