Re: [libvirt] [PATCH v2] conf: Split virDomainObjList into a separate file

On 20.11.2015 14:28, Michal Privoznik wrote: > ping? Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] libprl_sdk.so.7 library dependancies

On Fri, Nov 27, 2015 at 07:48:10PM +0300, Maxim Nestratov wrote: > 26.11.2015 20:08, Maxim Nestratov пишет: > >26.11.2015 18:19, Daniel P. Berrange пишет: > >>In debugging some recent problem I was rather surprised to find that > >>libvirt.so was linked against Qt, X11 and GObject. It turns out

[libvirt] [PATCH v2 07/27] conf: Move vcpu count check into helper

--- src/conf/domain_conf.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ab2048b..a2cb894 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -1461,6 +1461,13 @@ int

[libvirt] [PATCH v2 15/27] qemu: monitor: Remove weird return values from qemuMonitorSetCPU

Let the function report errors internally and change it to return standard return codes. --- src/qemu/qemu_driver.c | 22 -- src/qemu/qemu_monitor.c | 3 +++ src/qemu/qemu_monitor_json.c | 8 src/qemu/qemu_monitor_text.c | 23 ++- 4

[libvirt] [PATCH v2 02/27] conf: Use local copy of maxvcpus in virDomainVcpuParse

Use the local variable rather than getting it all the time from the struct. This will simplify further refactors. --- src/conf/domain_conf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 02b5e6d..6a77964 100644 ---

[libvirt] [PATCH v2 03/27] conf: Extract update of vcpu count if maxvcpus is decreased

The code can be unified into the new accessor rather than being scattered accross the drivers. --- src/conf/domain_conf.c | 3 +++ src/libxl/libxl_driver.c | 3 --- src/qemu/qemu_driver.c | 3 --- src/test/test_driver.c | 3 --- src/xen/xm_internal.c| 3 --- 5 files changed, 3

Re: [libvirt] libprl_sdk.so.7 library dependancies

26.11.2015 20:08, Maxim Nestratov пишет: 26.11.2015 18:19, Daniel P. Berrange пишет: In debugging some recent problem I was rather surprised to find that libvirt.so was linked against Qt, X11 and GObject. It turns out that this is due to the VZ driver linking to libprl_sdk.so which pulls in

[libvirt] libvirt-php 0.5.1 uneeded files

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Installing the new 0.5.1 version: libvirt-php.la libvirt-php.so -> libvirt-php.so.0.0.0 libvirt-php.so.0 -> libvirt-php.so.0.0.0 libvirt-php.so.0.0.0 This is not a versioned library but a PHP extension so having those

[libvirt] [PATCH v2 00/27] Prepare for specific vcpu hot(un)plug - part 1

This series is getting rather big. The target is to refactor the way libvirt stores info about vCPUs into a single structure (okay, two structures for the qemu driver. Part 1 is not yet completely there, well, not even halfway. Future work will involve fully allocating priv->vcpupids to the

[libvirt] libvirt-php 0.5.1 - missing arginfo

Hi, arginfo are very important in PHP extensions, useful for users (documentation), and various tools rely on them (through reflection). Attached patch add some. Tell me if ok, and I will continue to add more. Remi. >From c65b6c27101d339f0c01393b47bbd8aaf6dea63d Mon Sep 17 00:00:00 2001

Re: [libvirt] [PATCH] systemd: Escape only needed characters for machined

On Fri, Nov 27, 2015 at 02:05:06PM +, Daniel P. Berrange wrote: On Fri, Nov 27, 2015 at 02:59:51PM +0100, Martin Kletzander wrote: My previous fix in commit e24eda48cfae84a9003456b68eaf753a26123639 was incomplete, or rather more complete than it needed to be. The problem is that even

[libvirt] [PATCH v2 08/27] conf: Replace read accesses to def->vcpus with accessor

--- src/bhyve/bhyve_command.c | 2 +- src/bhyve/bhyve_driver.c | 2 +- src/conf/domain_audit.c| 2 +- src/conf/domain_conf.c | 19 +-- src/conf/domain_conf.h | 1 + src/libvirt_private.syms | 1 + src/libxl/libxl_conf.c | 2 +- src/libxl/libxl_driver.c

[libvirt] [PATCH v2 18/27] qemu: refactor qemuDomainHotunplugVcpus

Refactor the code flow so that 'exit_monitor:' can be removed. This patch moves the auditing functions into places where it's certain that hotunplug was or was not successful and reports errors from qemuMonitorGetCPUInfo properly. --- src/qemu/qemu_driver.c | 50

[libvirt] [PATCH v2 25/27] qemu: Add helper to retrieve vCPU pid

Instead of directly accessing the array add a helper to do this. --- src/qemu/qemu_cgroup.c | 3 ++- src/qemu/qemu_domain.c | 20 src/qemu/qemu_domain.h | 1 + src/qemu/qemu_driver.c | 7 --- src/qemu/qemu_process.c | 5 ++--- 5 files changed, 29 insertions(+), 7

[libvirt] [PATCH v2 20/27] conf: ABI: Split up and improve vcpu info ABI checking

Extract the checking code into a separate function and prepare the infrastructure for checking the new structure type. --- src/conf/domain_conf.c | 41 ++--- 1 file changed, 30 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c

[libvirt] [PATCH v2 16/27] qemu: cpu hotplug: Move loops to qemuDomainSetVcpusFlags

qemuDomainHotplugVcpus/qemuDomainHotunplugVcpus are complex enough in regards of adding one CPU. Additionally it will be desired to reuse those functions later with specific vCPU hotplug. Move the loops for adding vCPUs into qemuDomainSetVcpusFlags so that the helpers can be made simpler and more

[libvirt] [PATCH v2 05/27] conf: Replace read access to def->maxvcpus with accessor

Finalize the refactor by adding the 'virDomainDefGetVCpusMax' getter and reusing it accross libvirt. --- src/conf/domain_conf.c | 22 +++--- src/conf/domain_conf.h | 1 + src/libvirt_private.syms | 1 + src/libxl/libxl_conf.c | 4 ++-- src/libxl/libxl_driver.c |

[libvirt] [PATCH v2 13/27] qemu: Split up vCPU hotplug and hotunplug

There's only very little common code among the two operations. Split the functions so that the internals are easier to understand and refactor later. --- src/qemu/qemu_driver.c | 216 +++-- 1 file changed, 139 insertions(+), 77 deletions(-) diff --git

[libvirt] [PATCH v2 26/27] qemu: driver: Refactor qemuDomainHelperGetVcpus

Change some of the control structures and switch to using the new vcpu structure. --- src/qemu/qemu_driver.c | 77 -- 1 file changed, 43 insertions(+), 34 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[libvirt] [PATCH v2 04/27] conf: Add helper to check whether domain has offline vCPUs

The new helper will simplify checking whether the domain config contains inactive vCPUs. --- src/conf/domain_conf.c | 9 - src/conf/domain_conf.h | 1 + src/libvirt_private.syms | 1 + src/openvz/openvz_driver.c | 2 +- src/qemu/qemu_command.c| 4 ++-- src/vbox/vbox_common.c

[libvirt] [PATCH v2 06/27] conf: Replace writes to def->vcpus with accessor

--- src/conf/domain_conf.c | 20 +--- src/conf/domain_conf.h | 1 + src/hyperv/hyperv_driver.c | 5 - src/libvirt_private.syms | 1 + src/libxl/libxl_driver.c | 14 +- src/lxc/lxc_native.c | 3 ++- src/openvz/openvz_conf.c | 3 ++-

[libvirt] [PATCH v2 14/27] qemu: cpu hotplug: Fix error handling logic

The cpu hotplug helper functions used negative error handling in a part of them, although some code that was added later didn't properly set the error codes in some cases. This would cause improper error messages in cases where we couldn't modify the numa cpu mask and a few other cases. Fix the

[libvirt] [PATCH v2 23/27] qemu: Drop checking vcpu threads in emulator bandwidth getter/setter

The vCPU threads make sense in the counterparts that set the vCPU bandwidth/quota, not in the emulator one. The emulator tunables are set all the time anyways. Drop the extra check and remove the now unneeded vm argument. --- src/qemu/qemu_driver.c | 33 ++--- 1 file

[libvirt] [PATCH v2 12/27] qemu: qemuDomainSetVcpusAgent: re-check agent before calling it the again

With a very unfortunate timing, the agent might vanish before we do the second call while the locks were down. Re-check that the agent is available before attempting it again. --- src/qemu/qemu_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH v2 19/27] conf: turn def->vcpus into a structure

To allow collecting all relevant data at one place let's make def->vcpus a structure and then we can start moving stuff into it. --- src/conf/domain_conf.c | 55 -- src/conf/domain_conf.h | 10 - 2 files changed, 58 insertions(+), 7

[libvirt] [PATCH v2 24/27] qemu: Replace checking for vcpu<->pid mapping availability with a helper

Add qemuDomainHasVCpuPids to do the checking and replace in place checks with it. We no longer need checking whether the thread contains fake data (vcpupids[0] == vm->pid) as in b07f3d821dfb11a118ee75ea275fd6ab737d9500 and 65686e5a81d654d834d338fceeaf0229b2ca4f0d this was removed. ---

[libvirt] [PATCH v2 09/27] conf: Turn def->maxvcpus into size_t

Later on this will also be used to track size of the vcpu data array. Use size_t so that we can utilize the memory allocation helpers. --- src/conf/domain_conf.c | 2 +- src/conf/domain_conf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c

[libvirt] [PATCH v2 22/27] qemu: cgroup: Remove now unreachable check

Since commit 0c04906fa the check for priv->cgroup doesn't make sense as the calls to virCgroupHasController return the same information. Remove it and move it's comment partially to the new check. The already spurious check was also later copied to the iothreads code. --- src/qemu/qemu_cgroup.c

[libvirt] [PATCH v2 11/27] qemu: Extract vCPU onlining/offlining via agent into a separate function

Separate the code so that qemuDomainSetVcpusFlags contains only code relevant to hardware hotplug/unplug. --- src/qemu/qemu_driver.c | 137 +++-- 1 file changed, 77 insertions(+), 60 deletions(-) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH v2 01/27] conf: Replace writes to def->maxvcpus with accessor

To support further refactors replace all write access to def->maxvcpus with a accessor function. --- src/conf/domain_conf.c | 18 -- src/conf/domain_conf.h | 2 ++ src/hyperv/hyperv_driver.c | 5 - src/libvirt_private.syms | 1 + src/libxl/libxl_driver.c | 8

[libvirt] [PATCH v2 21/27] conf: Add helper to get pointer to a certain vCPU definition

Once more stuff will be moved into the vCPU data structure it will be necessary to get a specific one in some ocasions. Add a helper that will simplify this task. --- src/conf/domain_conf.c | 15 +++ src/conf/domain_conf.h | 2 ++ src/libvirt_private.syms | 1 + 3 files changed,

[libvirt] [PATCH v2 17/27] qemu: Refactor qemuDomainHotplugVcpus

Refactor the code flow so that 'exit_monitor:' can be removed. This patch also moves the auditing and setting of the new vCPU count right to the place where the hotplug happens, since it's possible that the hotplug succeeds and adds a cpu while other stuff fails. Lastly, failures of

[libvirt] [PATCH v2 10/27] qemu: domain: Add helper to access vm->privateData->agent

As in commit 88dc7e0c2fb, the helper can be used in cases where the function actually does not access anyting in the private data besides the agent. --- src/qemu/qemu_domain.c | 12 src/qemu/qemu_domain.h | 1 + 2 files changed, 13 insertions(+) diff --git a/src/qemu/qemu_domain.c

[libvirt] [PATCH v2 27/27] qemu: cgroup: Don't use priv->ncpupids to iterate domain vCPUs

Use the proper data structures for the iteration since ncpupids will be made private later. --- src/qemu/qemu_cgroup.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 402940f..c38d760 100644 ---

Re: [libvirt] libprl_sdk.so.7 library dependancies

27.11.2015 20:46, Daniel P. Berrange пишет: On Fri, Nov 27, 2015 at 07:48:10PM +0300, Maxim Nestratov wrote: 26.11.2015 20:08, Maxim Nestratov пишет: 26.11.2015 18:19, Daniel P. Berrange пишет: In debugging some recent problem I was rather surprised to find that libvirt.so was linked against

[libvirt] [PATCH] virtlogd: Fix build without DBus

Signed-off-by: Martin Kletzander --- tests/Makefile.am | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index b449286f1fb3..e2fb3b7f3b67 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -172,7 +172,6 @@

[libvirt] [PATCH v2] virtlogd: Fix build without DBus

The rule for virrotatingfiletest was defined in DBUS-only block even though the test does not use DBus at all. Also DBUS_CFLAGS and DBUS_LIBS are removed from the rules. The original error was: /usr/lib/gcc/x86_64-pc-linux-gnu/5.2.0/../../../../lib64/Scrt1.o: In function `_start': (.text+0x20):

Re: [libvirt] [PATCH] virtlogd: Fix build without DBus

On Fri, Nov 27, 2015 at 12:19:11PM +0100, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander Could do with a commit message that describes the problem seen, particularly since the virotatingfile code doesn't use DBus at all (unless by accident) > --- >

Re: [libvirt] [PATCH] virtlogd: Fix build without DBus

On Fri, Nov 27, 2015 at 11:33:34AM +, Daniel P. Berrange wrote: On Fri, Nov 27, 2015 at 12:19:11PM +0100, Martin Kletzander wrote: Signed-off-by: Martin Kletzander Could do with a commit message that describes the problem seen, particularly since the virotatingfile

[libvirt] Plans for next releases

Seems I forgot to send that mail earlier. I think we should enter freeze now is we want to push on the next week (and I'm away travelling 3-7 unlikely to have much time on this. If I can freeze now I can try to push 1.3.0 on Wed 2nd, otherwise we would have to wait Tuesday 8. On the other hand

[libvirt] [PATCH] logging: remove reference to non-existent augeas files

The libvirt_logd.aug and test_libvirt_logd.aug.in files have never existed so shouldn't be in EXTRA_DIST. It was a copy+paste mistake when closing virtlogd from virtlockd Signed-off-by: Daniel P. Berrange --- Pushed as a "make dist" build-fix src/Makefile.am | 4 +--- 1

Re: [libvirt] [PATCH v2 3/5] qemu: add virtio video device

On 25.11.2015 09:42, Marc-André Lureau wrote: > qemu 2.5 provides virtio video device. It can be used with -device > virtio-vga for primary devices, or -device virtio-gpu for non-vga > devices. However, only the primary device (VGA) is supported with this > patch. > > Reference: >

Re: [libvirt] [PATCH v2 5/5] RFC qemu: add spice opengl support

On 25.11.2015 09:42, Marc-André Lureau wrote: > Add Spice graphics gl attribute. qemu 2.6 should have -spice gl=on > argument to enable opengl rendering context. This is necessary > to actually enable virgl rendering. > > Add a qemuxml2argv test for virtio-gpu + spice with virgl. > >

Re: [libvirt] [PATCH v2 1/5] Replace support{2d, 3d} with accel{2d, 3d}

On 25.11.2015 09:42, Marc-André Lureau wrote: > Following the domain XML naming > > Signed-off-by: Marc-André Lureau > --- > src/conf/domain_conf.c | 44 ++-- > src/conf/domain_conf.h | 4 ++-- > src/vbox/vbox_common.c | 8

Re: [libvirt] [PATCH v2] virtlogd: Fix build without DBus

On Fri, Nov 27, 2015 at 02:05:11PM +0100, Martin Kletzander wrote: > The rule for virrotatingfiletest was defined in DBUS-only block even > though the test does not use DBus at all. Also DBUS_CFLAGS and > DBUS_LIBS are removed from the rules. The original error was: > >

[libvirt] [PATCH] systemd: Escape only needed characters for machined

My previous fix in commit e24eda48cfae84a9003456b68eaf753a26123639 was incomplete, or rather more complete than it needed to be. The problem is that even though machined requires non-ASCII characters to be escaped does not mean that it needs to follow the exact same rules as unit files and

Re: [libvirt] [PATCH] systemd: Escape only needed characters for machined

On Fri, Nov 27, 2015 at 02:59:51PM +0100, Martin Kletzander wrote: > My previous fix in commit e24eda48cfae84a9003456b68eaf753a26123639 was > incomplete, or rather more complete than it needed to be. The problem > is that even though machined requires non-ASCII characters to be escaped > does not

Re: [libvirt] [PATCH v2 2/5] domain: replace bool accel{2d, 3d} with a tristate

On 25.11.2015 09:42, Marc-André Lureau wrote: > Allowing to have the extra undefined/default state. > > Signed-off-by: Marc-André Lureau > --- > src/conf/domain_conf.c | 41 ++--- > src/conf/domain_conf.h | 4 ++-- >

Re: [libvirt] [PATCH v2 4/5] qemu: add virtio-gpu virgl support

On 25.11.2015 09:42, Marc-André Lureau wrote: > Check if virtio-gpu provides virgl option, and add qemu command line > formatter. > > It is enabled with the existing accel3d attribute: > > > > > Signed-off-by: Marc-André Lureau > --- >

Re: [libvirt] [PATCH v2 0/5] Add virtio-gpu & virgl support

On 25.11.2015 09:42, Marc-André Lureau wrote: > The following series allow using virtio-gpu and virgl if qemu support > it. Ths Spice bits are not yet in qemu 2.5, but should make it in 2.6 > and I added the RFC patches that are expected to not change much. > > v1->v2: addressing Ján Tomko review

Re: [libvirt] [PATCH 0/8] qemu: add support for virtio-input devices

On Fri, Nov 20, 2015 at 09:59:35AM +0100, Ján Tomko wrote: > Support virtio-keyboard, virtio-mouse, virtio-tablet and virtio-input-host. > > Requires kernel 4.1+ in the guest. > > https://www.kraxel.org/blog/2015/06/new-member-in-the-virtio-family-input-devices/ >

Re: [libvirt] libprl_sdk.so.7 library dependancies

On Fri, Nov 27, 2015 at 09:08:03PM +0300, Maxim Nestratov wrote: > 27.11.2015 20:46, Daniel P. Berrange пишет: > >On Fri, Nov 27, 2015 at 07:48:10PM +0300, Maxim Nestratov wrote: > >>26.11.2015 20:08, Maxim Nestratov пишет: > >>>26.11.2015 18:19, Daniel P. Berrange пишет: > >So none of the GUI

Re: [libvirt] Plans for next releases

On Fri, Nov 27, 2015 at 08:58:36PM +0800, Daniel Veillard wrote: > > Seems I forgot to send that mail earlier. I think we should enter freeze now > is we want to push on the next week (and I'm away travelling 3-7 unlikely > to have much time on this. > If I can freeze now I can try to push

Re: [libvirt] Plans for next releases

On Fri, Nov 27, 2015 at 03:05:45PM +, Daniel P. Berrange wrote: > On Fri, Nov 27, 2015 at 08:58:36PM +0800, Daniel Veillard wrote: > > > > Seems I forgot to send that mail earlier. I think we should enter freeze > > now > > is we want to push on the next week (and I'm away travelling 3-7

Re: [libvirt] [PATCH v3 1.5/11] admin: introduce virAdmGetVersion

On Thu, Nov 26, 2015 at 04:43:37PM +0100, Erik Skultety wrote: Unfortunately, client side version retrieval API virGetVersion uses one-time initialization (due to the fact we might not have initialized the library by calling connect prior to this) which is not completely compatible with admin

Re: [libvirt] libvirt external snapshot error

24 нояб. 2015 г. 10:17 пользователь "Vasiliy Tolstov" написал: > > > 23 нояб. 2015 г. 15:13 пользователь "Vasiliy Tolstov" написал: > > > > > 2015-11-23 15:10 GMT+03:00 Peter Krempa : > > > The file should not exist prior to the

Re: [libvirt] libvirt-php 0.5.1 uneeded files

Le 27/11/2015 09:33, Remi Collet a écrit : > Notice: I think it will be simpler to switch to the standard PHP > extension build system (phpize; configure; make) See attached patch. This only manage the extension build (not the documentation) TODO: add a --enable-libvirt-debug option to avoid

[libvirt] [PATCH] virtlogd: Rename variable shadowing global declaration

This time the winner is variable named 'daemon'. Signed-off-by: Martin Kletzander --- src/logging/log_daemon.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/logging/log_daemon.c b/src/logging/log_daemon.c index 3fda9ca33c61..cc0559d7ff7b

Re: [libvirt] [PATCH 32/34] qemu: Add helper to retrieve vCPU pid

On Tue, Nov 24, 2015 at 07:25:37 -0500, John Ferlan wrote: > > > On 11/20/2015 10:22 AM, Peter Krempa wrote: > > Instead of directly accessing the array add a helper to do this. > > --- > > src/qemu/qemu_cgroup.c | 3 ++- > > src/qemu/qemu_domain.c | 20 > >

Re: [libvirt] [PATCH 33/34] qemu: driver: Refactor qemuDomainHelperGetVcpus

On Tue, Nov 24, 2015 at 07:56:19 -0500, John Ferlan wrote: > On 11/20/2015 10:22 AM, Peter Krempa wrote: > > Change some of the control structures and switch to using the new vcpu > > structure. > > --- > > src/qemu/qemu_driver.c | 77 > > -- > > 1

[libvirt] libvirt-php 0.5.1 uneeded files

Installing the new 0.5.1 version: libvirt-php.la libvirt-php.so -> libvirt-php.so.0.0.0 libvirt-php.so.0 -> libvirt-php.so.0.0.0 libvirt-php.so.0.0.0 This is not a versioned library but a PHP extension so having those have no sense. Only libvirt-php.so is needed.

[libvirt] libvirt-php 0.5.1 broken build on RHEL-7

RHEL 7 have libvirt 1.2.8 which is the minimum version according to configure check LIBVIRT_REQUIRED=1.2.8 libvirt-php.c: In function 'zm_startup_libvirt': libvirt-php.c:1351:136: error: 'VIR_DOMAIN_BLOCK_JOB_SPEED_BANDWIDTH_BYTES' undeclared (first use in this function)

[libvirt] [PATCH] logging: avoid variables called 'daemon' due to function clash

With some versions of GLibC / GCC, a variable called 'daemon' will result in a warning about clashing with the function also named 'daemon'. Rename it to 'dmn' to avoid the clash. Signed-off-by: Daniel P. Berrange --- Pushed as a broken build fix. src/logging/log_daemon.c

Re: [libvirt] [PATCH] virtlogd: Rename variable shadowing global declaration

On Fri, Nov 27, 2015 at 11:02:04AM +0100, Martin Kletzander wrote: > This time the winner is variable named 'daemon'. > > Signed-off-by: Martin Kletzander > --- > src/logging/log_daemon.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) I already pushed

Re: [libvirt] libvirt-php 0.5.1 uneeded files

More... >From 34c218c01413feffda4a98b9e78bdf7ea83d0fdc Mon Sep 17 00:00:00 2001 From: Remi Collet Date: Fri, 27 Nov 2015 11:35:33 +0100 Subject: [PATCH 2/2] include config.h earlier --- src/config.m4 | 2 -- src/libvirt-php.h | 14 -- 2 files changed,