On 12/11/2015 11:36 AM, Ján Tomko wrote:
> The first patch fixes the return values of virStorageWipe on non-sparse local
> files
> in the case of a partial wipe or a fdatasync error.
>
> The rest reduces the number of parameters of
> virStorageBackendWipe{Extent,}Local.
>
> Ján Tomko (5):
>
On 12/11/2015 11:36 AM, Ján Tomko wrote:
> The only caller always passes 0 for the extent start.
> Drop the 'extent_start' parameter, as well as the mention of extents
> from the function name.
> ---
> src/storage/storage_backend.c | 32 +++-
> 1 file changed, 15
On 12/16/2015 08:44 AM, Ján Tomko wrote:
> On Wed, Dec 16, 2015 at 07:46:18AM -0500, John Ferlan wrote:
>>
>>
>> On 12/16/2015 07:02 AM, Ján Tomko wrote:
>>> On Mon, Dec 07, 2015 at 03:47:58PM -0500, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1025230
Add a new
On 12/16/2015 10:24 AM, Michal Privoznik wrote:
On 10.12.2015 07:34, Leno Hou wrote:
1. When switching CPUs to offline/online in a system more than 128 cpus
2. When using virsh to destroy domain in a system with more interface
All of above happens nl_recv returned with error: No buffer space
On 12/11/2015 09:45 AM, Andrea Bolognani wrote:
> During my testing, I've realized that even with the series applied
> there's still one case in which we're unable to restore the previous
> memory locking limit after removing the last PCI hostdev from the guest.
>
> If an x86 guest contains a
Libvirt Security Notice: LSN-2015-0004
==
Summary: ACL bypass using ../ to access beyond storage pool
Reported on: 20151030
Published on: 20151211
Fixed on: 20151211
Reported by: Ossi Herrala
Commit id '71b803ac' assumed that the storage pool source device path
was required for a 'logical' pool. This resulted in a failure to start
a pool without any device path defined.
So, adjust the virStorageBackendLogicalMatchPoolSource logic to
return success if at least the pool name matches the
On 12/16/2015 07:56 AM, Moshe Levi wrote:
To clean up the VF I use
ip link set dev p4p2 vf 0 mac 0 and it working
Now *that* is interesting...
24: enp3s0f0: mtu 1500 qdisc mq
master ovs-system state UP mode DEFAULT group default qlen 1000
link/ether
On 12/16/2015 12:35 PM, Vlad Yasevich wrote:
(BTW, Cisco's enic driver, on the other hand, doesn't support setting VF MAC
addresses via
a netlink message to the PF *at all* (so libvirt has to make special
accommodations), but
Looking at upstream, it looks like it offers support for setting
On 12/16/2015 12:22 PM, Laine Stump wrote:
> On 12/16/2015 07:56 AM, Moshe Levi wrote:
>>
>> To clean up the VF I use
>>
>> ip link set dev p4p2 vf 0 mac 0 and it working
>>
>
> Now *that* is interesting...
>
>> 24: enp3s0f0: mtu 1500 qdisc mq master
>>
On 10/14/2015 02:08 AM, Daniel P. Berrange wrote:
> On Tue, Oct 13, 2015 at 03:17:27PM -0600, Eric Blake wrote:
>> Cygwin cannot build the vbox driver yet:
>>
>> CC vbox/libvirt_driver_vbox_impl_la-vbox_glue.lo
>> In file included from vbox/vbox_glue.c:27:0:
>>
On 12/10/2015 09:41 AM, Daniel P. Berrange wrote:
> The VIR_DOMAIN_STATS_VCPU flag to virDomainListGetStats
> enables reporting of stats about vCPUs. Currently we
> only report the cumulative CPU running time and the
> execution state.
>
> This adds reporting of the wait time - time the vCPU
>
On 12/16/2015 03:11 AM, Ian Campbell wrote:
> On Wed, 2015-12-16 at 09:45 +, Ian Campbell wrote:
>> On Tue, 2015-12-15 at 14:32 -0700, Jim Fehlig wrote:
>>> Hi All,
>>>
>>> Ian Campbell recently attempted [1] to fix and issue around
>>> MAX_VIRT_VPUS
>>> on ARM that required adding a new
On 12/15/2015 08:39 PM, John Ferlan wrote:
[...]
+if (rc < 0)
+return -1;
+
I know this is a copy of the RemoveRNGDevice; however, this code doesn't
remove an 'obj'. In fact, if !shmem->server.enabled, then we don't enter
the monitor at all.
Thus the following event probably
On Wed, Dec 16, 2015 at 12:09:42 +0300, Dmitry Andreev wrote:
> If config file was changed VIR_DOMAIN_EVENT_DEFINED should be emitted
drop "file" here. The important part is the config itself being changed.
The file is just a implication of that.
Additionally, commit messages here or in the
On Mon, Dec 07, 2015 at 03:47:58PM -0500, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1025230
>
> Add a new helper virStorageBackendLogicalMatchPoolSource to compare the
> pool's source name against the output from a 'pvs' command to list all
> volume group physical volume
On 12/16/2015 04:09 AM, Dmitry Andreev wrote:
> If config file was changed VIR_DOMAIN_EVENT_DEFINED should be emitted
> ---
> src/qemu/qemu_driver.c | 13 +++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
I liked v1 better with a tweak or two
> diff --git
On 25.11.2015 20:11, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=830056
>
> Utilize recently added VIR_STORAGE_POOL_CREATE_WITH_BUILD* flags in
> order to pass the flags along to the virStoragePoolCreateXML and
> virStoragePoolCreate API's.
>
> This affects the 'virsh
On 25.11.2015 20:11, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=830056
>
> Add flags handling to the virStoragePoolCreate and virStoragePoolCreateXML
> API's which will allow the caller to provide the capability for the storage
> pool create API's to also perform a pool
On 25.11.2015 20:11, John Ferlan wrote:
> Rather than continually cut/paste the "pool" option for pool command
> option structures, generate a macro which will commonly define it for
> any command. Then of course use that macro.
>
> Signed-off-by: John Ferlan
> ---
>
On 25.11.2015 20:11, John Ferlan wrote:
> Although not currently used in more than one command, it soon will be
> so create a common macro to be used in the new command location.
>
> Additionally, add the ".flags = 0," for both to match the expections
> of the structure being predefined.
>
>
On 25.11.2015 20:11, John Ferlan wrote:
> Although they both are the same now, a future patch will add new options
> to pool-create-as. So create a common macro to capture commonality, then
> use that in the command specific structure.
>
> Signed-off-by: John Ferlan
> ---
>
On 25.11.2015 20:11, John Ferlan wrote:
> Rather than continually cut/paste the "file" option for pool command
> option structures, generate a macro which will commonly define it for
> any command. Then of course use that macro.
>
> Signed-off-by: John Ferlan
> ---
>
On 12/09/2015 12:08 PM, Ján Tomko wrote:
> We only support hotplugging SCSI controllers,
> USB and virtio-serial related code is useless here.
> ---
> src/conf/domain_addr.c | 21 -
> src/conf/domain_addr.h | 4
> src/libvirt_private.syms | 1 -
>
On Wed, Dec 16, 2015 at 07:28:43 -0500, John Ferlan wrote:
>
>
> On 12/16/2015 07:01 AM, Peter Krempa wrote:
> > On Wed, Dec 16, 2015 at 12:09:42 +0300, Dmitry Andreev wrote:
> >> If config file was changed VIR_DOMAIN_EVENT_DEFINED should be emitted
> >
> > drop "file" here. The important part
On Wed, Dec 16, 2015 at 08:24:43 -0500, John Ferlan wrote:
>
> [...]
>
> >> static const vshCmdOptDef opts_pool_autostart[] = {
> >> -{.name = "pool",
> >> - .type = VSH_OT_DATA,
> >> - .flags = VSH_OFLAG_REQ,
> >> - .help = N_("pool name or uuid")
> >> -},
> >> +
On Wed, Dec 16, 2015 at 14:18:22 +0100, Michal Privoznik wrote:
> On 25.11.2015 20:11, John Ferlan wrote:
> > Although not currently used in more than one command, it soon will be
> > so create a common macro to be used in the new command location.
> >
> > Additionally, add the ".flags = 0," for
On Wed, Nov 25, 2015 at 14:11:08 -0500, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=830056
>
> Utilize recently added VIR_STORAGE_POOL_CREATE_WITH_BUILD* flags in
> order to pass the flags along to the virStoragePoolCreateXML and
> virStoragePoolCreate API's.
>
> This
On Tue, Dec 15, 2015 at 03:03:33PM -0500, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1270709
>
> When a volume wipe is successful, perform a volume refresh afterwards to
> update any volume data that may be used in future volume commands, such as
> volume resize. For a raw
In commit 686eb7a24f7d, the break was not considered part of the
condition, hence breaking after first node when searching.
Signed-off-by: Martin Kletzander
---
Pushed as 'trivial' and also John ACKed it earlier.
src/qemu/qemu_process.c | 5 +++--
1 file changed, 3
On Tue, Dec 15, 2015 at 05:01:39PM +, Peter Maydell wrote:
On 15 December 2015 at 16:57, Andre Przywara wrote:
Even that wouldn't help us, I guess, as you cannot easily check for
GICv3/GICv2 compatibility with a _script_. Having access to ioctl's make
this pretty
[...]
>> static const vshCmdOptDef opts_pool_autostart[] = {
>> -{.name = "pool",
>> - .type = VSH_OT_DATA,
>> - .flags = VSH_OFLAG_REQ,
>> - .help = N_("pool name or uuid")
>> -},
>> +OPT_POOL_COMMON
>> +
>> {.name = "disable",
>> .type = VSH_OT_BOOL,
>>
On Tue, Dec 15, 2015 at 02:18:52PM -0500, John Ferlan wrote:
A closer review of the code shows that for the transition from paused to
running which was supposed to emit the VIR_DOMAIN_EVENT_RESUMED - no event
would be generated. Rather the event is generated when going from running
to running.
On Tue, Dec 15, 2015 at 03:03:33PM -0500, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1270709
When a volume wipe is successful, perform a volume refresh afterwards to
update any volume data that may be used in future volume commands, such as
volume resize. For a raw file
On Wed, Dec 16, 2015 at 07:46:18AM -0500, John Ferlan wrote:
>
>
> On 12/16/2015 07:02 AM, Ján Tomko wrote:
> > On Mon, Dec 07, 2015 at 03:47:58PM -0500, John Ferlan wrote:
> >> https://bugzilla.redhat.com/show_bug.cgi?id=1025230
> >>
> >> Add a new helper virStorageBackendLogicalMatchPoolSource
On 12/16/2015 08:35 AM, Peter Krempa wrote:
> On Wed, Dec 16, 2015 at 14:18:22 +0100, Michal Privoznik wrote:
>> On 25.11.2015 20:11, John Ferlan wrote:
>>> Although not currently used in more than one command, it soon will be
>>> so create a common macro to be used in the new command location.
On Wed, Dec 16, 2015 at 14:28:03 +0100, Martin Kletzander wrote:
> On Tue, Dec 15, 2015 at 03:03:33PM -0500, John Ferlan wrote:
> >https://bugzilla.redhat.com/show_bug.cgi?id=1270709
> >
> >When a volume wipe is successful, perform a volume refresh afterwards to
> >update any volume data that may
On Wed, 2015-12-16 at 10:11 +, Ian Campbell wrote:
> On Tue, 2015-12-15 at 15:20 -0700, Jim Fehlig wrote:
> > From: Ian Campbell
> >
> > xend prior to 4.0 understands vcpus as maxvcpus and vcpu_avail
> > as a bit map of which cpus are online (default is all).
> >
>
To clean up the VF I use
ip link set dev p4p2 vf 0 mac 0 and it working
24: enp3s0f0: mtu 1500 qdisc mq master
ovs-system state UP mode DEFAULT group default qlen 1000
link/ether e4:1d:2d:a5:f1:22 brd ff:ff:ff:ff:ff:ff
vf 0 MAC 00:00:00:00:00:00, spoof
On 12/16/2015 08:48 AM, Ján Tomko wrote:
> On Tue, Dec 15, 2015 at 03:03:33PM -0500, John Ferlan wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1270709
>>
>> When a volume wipe is successful, perform a volume refresh afterwards to
>> update any volume data that may be used in future
On 12/16/2015 08:18 AM, Michal Privoznik wrote:
> On 25.11.2015 20:11, John Ferlan wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=830056
>>
>> Add flags handling to the virStoragePoolCreate and virStoragePoolCreateXML
>> API's which will allow the caller to provide the capability for the
> -Original Message-
> From: sendmail [mailto:justsendmailnothinge...@gmail.com] On Behalf Of
> Laine Stump
> Sent: Wednesday, December 16, 2015 12:31 AM
> To: Libvirt
> Cc: vyase...@redhat.com; Moshe Levi
> Subject: Re: [libvirt] vf
On Wed, Dec 16, 2015 at 08:44:50 -0500, John Ferlan wrote:
>
>
> On 12/16/2015 08:35 AM, Peter Krempa wrote:
> > On Wed, Dec 16, 2015 at 14:18:22 +0100, Michal Privoznik wrote:
> >> On 25.11.2015 20:11, John Ferlan wrote:
> >>> Although not currently used in more than one command, it soon will
[...]
>>
>> So then in your opinion and using the same logic, patch 3 is also nixed?
>> This one will get used in patch 6.
>
> With that use it will result in total 4 uses. I won't object if you fix
> the macro name and remove the comma
>
Hmm. by name change do you mean
On Wed, Dec 16, 2015 at 09:19:07AM -0500, John Ferlan wrote:
>
>
> On 12/16/2015 08:48 AM, Ján Tomko wrote:
> > On Tue, Dec 15, 2015 at 03:03:33PM -0500, John Ferlan wrote:
> >> https://bugzilla.redhat.com/show_bug.cgi?id=1270709
> >>
> >> When a volume wipe is successful, perform a volume
On 10.12.2015 07:34, Leno Hou wrote:
> 1. When switching CPUs to offline/online in a system more than 128 cpus
> 2. When using virsh to destroy domain in a system with more interface
>
> All of above happens nl_recv returned with error: No buffer space available.
> This patch set socket buffer
On 16.12.2015 16:26, Peter Krempa wrote:
On Wed, Dec 16, 2015 at 07:28:43 -0500, John Ferlan wrote:
On 12/16/2015 07:01 AM, Peter Krempa wrote:
On Wed, Dec 16, 2015 at 12:09:42 +0300, Dmitry Andreev wrote:
If config file was changed VIR_DOMAIN_EVENT_DEFINED should be emitted
drop "file"
On 12/16/2015 07:02 AM, Ján Tomko wrote:
> On Mon, Dec 07, 2015 at 03:47:58PM -0500, John Ferlan wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1025230
>>
>> Add a new helper virStorageBackendLogicalMatchPoolSource to compare the
>> pool's source name against the output from a 'pvs'
On 12/09/2015 12:08 PM, Ján Tomko wrote:
> Originally posted as a part of
> https://www.redhat.com/archives/libvir-list/2015-August/msg00521.html
>
> Ján Tomko (3):
> qemu_hotplug: remove qemuDomainAttachDeviceControllerLive
> Remove dead code from qemuDomainAttachControllerDevice
> mark
On 12/16/2015 07:01 AM, Peter Krempa wrote:
> On Wed, Dec 16, 2015 at 12:09:42 +0300, Dmitry Andreev wrote:
>> If config file was changed VIR_DOMAIN_EVENT_DEFINED should be emitted
>
> drop "file" here. The important part is the config itself being changed.
> The file is just a implication of
On 12/16/2015 10:32 AM, John Ferlan wrote:
>
> [...]
>
>>>
>>> So then in your opinion and using the same logic, patch 3 is also nixed?
>>> This one will get used in patch 6.
>>
>> With that use it will result in total 4 uses. I won't object if you fix
>> the macro name and remove the comma
>>
On 12/16/2015 08:42 AM, Peter Krempa wrote:
> On Wed, Nov 25, 2015 at 14:11:08 -0500, John Ferlan wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=830056
>>
>> Utilize recently added VIR_STORAGE_POOL_CREATE_WITH_BUILD* flags in
>> order to pass the flags along to the virStoragePoolCreateXML
This should be emitted whenever a domain is reverted to snapshot.
---
examples/object-events/event-test.c | 2 ++
include/libvirt/libvirt-domain.h| 1 +
tools/virsh-domain.c| 3 ++-
3 files changed, 5 insertions(+), 1 deletion(-)
diff --git
If config file was changed VIR_DOMAIN_EVENT_DEFINED should be emitted
---
src/qemu/qemu_driver.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 783a7cd..1474eaa 100644
--- a/src/qemu/qemu_driver.c
+++
Reverting to snapshot may change domain configuration but
there will be no events about that.
Lack of the event become a problem for virt-manager
https://bugzilla.redhat.com/show_bug.cgi?id=1081148
This patch-set introduces new event and emits it in
qemuDomainRevertToSnapshot.
v2:
[2/2]
It's my fault.
Please, disregard this patch.
Thanks to Michal.
16.12.2015 11:30, Michal Privoznik пишет:
On 09.12.2015 16:48, Mikhail Feoktistov wrote:
---
diff from v1.
Remove call of vzDomainSuspend() in case of VIR_DOMAIN_START_PAUSED flag is
set.
Now we don't support to create
On 16.12.2015 11:13, Michal Privoznik wrote:
On 08.12.2015 15:17, Dmitry Andreev wrote:
Found this message right after I'v sent the patch.
https://www.redhat.com/archives/libvir-list/2015-January/msg00446.html
Right. When I came across this patch set I recalled having some
discussion about it
On Tue, 2015-12-15 at 14:32 -0700, Jim Fehlig wrote:
> Hi All,
>
> Ian Campbell recently attempted [1] to fix and issue around MAX_VIRT_VPUS
> on ARM that required adding a new XEND_CONFIG_VERSION. After some
> discussion [2] we decided to drop support for all of the old xend config
> versions
On 09.12.2015 16:48, Mikhail Feoktistov wrote:
> ---
>
> diff from v1.
> Remove call of vzDomainSuspend() in case of VIR_DOMAIN_START_PAUSED flag is
> set.
> Now we don't support to create instance in stopped state.
>
> src/vz/vz_driver.c | 24
> 1 file changed, 24
On Tue, 2015-12-15 at 13:53 -0500, Laine Stump wrote:
> On 12/15/2015 01:23 PM, Andrea Bolognani wrote:
> > Instead of replicating the information (domain, bus, slot, function)
> > inside the virPCIDevice structure, use the already-existing
> > virPCIDeviceAddress structure.
> >
> > For users of
On 08.12.2015 15:17, Dmitry Andreev wrote:
> Found this message right after I'v sent the patch.
> https://www.redhat.com/archives/libvir-list/2015-January/msg00446.html
Right. When I came across this patch set I recalled having some
discussion about it a long time ago (in fact as it turns out
On Tue, 2015-12-15 at 16:15 -0700, Jim Fehlig wrote:
> On 12/14/2015 04:37 AM, Ian Campbell wrote:
> > On Mon, 2015-12-14 at 11:15 +, Daniel P. Berrange wrote:
> > > On Thu, Dec 10, 2015 at 11:38:36AM +, Ian Campbell wrote:
> > > > Upstream Xen is in the process of splitting the (stable
On Mon, Dec 14, 2015 at 10:57 PM, John Ferlan wrote:
>
>
> On 12/03/2015 09:35 AM, Matthias Gatto wrote:
>> Create virStorageSourceGetBackingStore function in
>> preparation for quorum:
>> Actually, if we want to get a backing store inside a virStorageSource
>> we have to do
On Tue, 2015-12-15 at 15:20 -0700, Jim Fehlig wrote:
> From: Ian Campbell
>
> xend prior to 4.0 understands vcpus as maxvcpus and vcpu_avail
> as a bit map of which cpus are online (default is all).
>
> xend from 4.0 onwards understands maxvcpus as maxvcpus and
> vcpus
On Wed, 2015-12-16 at 09:45 +, Ian Campbell wrote:
> On Tue, 2015-12-15 at 14:32 -0700, Jim Fehlig wrote:
> > Hi All,
> >
> > Ian Campbell recently attempted [1] to fix and issue around
> > MAX_VIRT_VPUS
> > on ARM that required adding a new XEND_CONFIG_VERSION. After some
> > discussion [2]
65 matches
Mail list logo