Re: [libvirt] [PATCH 2/5] util: don't log error in virNetDevVPortProfileGetStatus if instanceId is NULL

Laine Stump wrote on 12/21/2015 12:17:54 PM: > > This does cause a difference in behavior, so I want confirmation from > Cisco and IBM that this behavior change is desired (or at least not > *un*desired) - rather than returning with status unchanged (and thus > always 0, aka

[libvirt] [PATCH 2/3] tools: Include PIE_LDFLAGS at the correct place

This is no functional change, but I find it disturbing that something_LDADD contains PIE_LDFLAGS while something_LDFLAGS doesn't. Signed-off-by: Michal Privoznik --- tools/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/Makefile.am

Re: [libvirt] [PATCH 0/3] several cgroups/cpuset fixes

On Mon, 14 Dec 2015 16:27:54 -0500 John Ferlan wrote: > > > On 11/13/2015 11:56 AM, Henning Schild wrote: > > Hi, > > > > i already explained some of the cgroup problems in some detail so i > > will not do that again. > >

[libvirt] [PATCH] qemu: Add debug message to spice migration

Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 4519aef..2187241 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2505,6

Re: [libvirt] Hot plug multi function PCI devices

On 12/21/2015 08:29 AM, Ziviani . wrote: Hello list! I'm new here and interested in hot-plug multi-function PCI devices. Basically I'd like to know why Libvirt does not support it. I've been through the archives and basically found this thread:

Re: [libvirt] [PATCH 0/3] several cgroups/cpuset fixes

On Mon, 21 Dec 2015 12:44:32 -0500 John Ferlan wrote: > > > On 12/21/2015 03:36 AM, Henning Schild wrote: > > On Mon, 14 Dec 2015 16:27:54 -0500 > > John Ferlan wrote: > > > >> > >> > >> On 11/13/2015 11:56 AM, Henning Schild wrote: > >>> Hi, > >>> >

Re: [libvirt] [PATCH v2 3/6] pci: Introduce virPCIStubDriver enumeration

On Fri, 2015-12-18 at 11:12 -0500, Laine Stump wrote: >  > >> +if (!(drvname = virPCIStubDriverTypeToString(driver)) || > >> +driver == VIR_PCI_STUB_DRIVER_NONE) { >  > You could save a small bit of time by comparing to  > VIR_PCI_STUB_DRIVER_NONE first, and then calling

[libvirt] Hot plug multi function PCI devices

Hello list! I'm new here and interested in hot-plug multi-function PCI devices. Basically I'd like to know why Libvirt does not support it. I've been through the archives and basically found this thread: https://www.redhat.com/archives/libvir-list/2011-May/msg00457.html But Qemu seems to handle

[libvirt] [PATCH 1/3] sysconf: Include unistd.h

The manpage for sysconf() suggest including unistd.h as the function is declared there. Even though we are not hitting any compile issues currently, let's include the correct header file instead of relying on some hidden include chain. Signed-off-by: Michal Privoznik ---

[libvirt] [PATCH 3/3] tools: Disable virt-login-shell on mingw

So, after bec787ee9da we are building virt-login-shell independent of LXC driver. This is nice, but the binary is enabled by default which makes no sense on mingw. In fact, it triggers some compilation errors there: CC virt_login_shell-virt-login-shell.o ../../tools/virt-login-shell.c: In

[libvirt] [PATCH 0/3] Fix mingw build

We have a build failure on mingw platform:4 https://ci.centos.org/job/libvirt-mingw/899/console Michal Privoznik (3): sysconf: Include unistd.h tools: Include PIE_LDFLAGS at the correct place tools: Disable virt-login-shell on mingw m4/virt-login-shell.m4 | 18 +++---

Re: [libvirt] [PATCH] qemu: Add debug message to spice migration

On Mon, 2015-12-21 at 10:43 +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- >  src/qemu/qemu_migration.c | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c > index 4519aef..2187241 100644 > ---

[libvirt] [PATCH 4/4] virsh: Interrupt *event --loop on disconnect

The *event --loop commands would keep running even though a connection to libvirtd is lost. This doesn't make a lot of sense since clearly we won't get any new events from the closed connection. Signed-off-by: Jiri Denemark --- tools/virsh.c | 1 + 1 file changed, 1

[libvirt] [PATCH 2/4] virsh: Add timestamps to events

A new --timestamp option for event virsh command can be used to print timestamp of each event. Signed-off-by: Jiri Denemark --- tools/virsh-domain.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/tools/virsh-domain.c

Re: [libvirt] [PATCH 0/6] Small PCI hostdev improvements and fixes

On Thu, 2015-12-17 at 17:28 +0100, Michal Privoznik wrote: >  > > Andrea Bolognani (6): > >   pci: Remove redundant parameter from virPCIDeviceBindToStub() > >   pci: Remove 'reprobe' parameter from virPCIDeviceUnbind() > >   pci: Introduce virPCIStubDriver enumeration > >   hostdev: Mark PCI

Re: [libvirt] ARM KVM GICv3 Support

On Mon, Dec 21, 2015 at 10:15:13AM +, Daniel P. Berrange wrote: > On Sun, Dec 20, 2015 at 04:49:20PM +0100, Kashyap Chamarthy wrote: > > On Tue, Dec 15, 2015 at 04:42:13PM +, Peter Maydell wrote: > > > On 15 December 2015 at 16:35, Andrew Jones wrote: > > > > This is

Re: [libvirt] [PATCH 4/4] virsh: Interrupt *event --loop on disconnect

On Mon, 2015-12-21 at 11:04 +0100, Jiri Denemark wrote: > The *event --loop commands would keep running even though a connection > to libvirtd is lost. This doesn't make a lot of sense since clearly we > won't get any new events from the closed connection. > > Signed-off-by: Jiri Denemark

Re: [libvirt] [PATCH 1/4] virsh: Refactor event printing

n Mon, 2015-12-21 at 11:04 +0100, Jiri Denemark wrote: > To reduce code duplication. >  > Signed-off-by: Jiri Denemark > --- >  tools/virsh-domain.c | 293 >--- >  1 file changed, 136 insertions(+), 157 deletions(-) Really nice

Re: [libvirt] [PATCH 3/4] virsh: Pass ctl to virshCatchDisconnect

On Mon, 2015-12-21 at 11:04 +0100, Jiri Denemark wrote: > virshCatchDisconnect expects ctl, but we were just passing NULL instead. > > Signed-off-by: Jiri Denemark > --- >  tools/virsh.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [libvirt] [PATCH 2/5] util: don't log error in virNetDevVPortProfileGetStatus if instanceId is NULL

On 21.12.2015 18:17, Laine Stump wrote: > virNetDevVPortProfileGetStatus() would log the following error: > >Could not find netlink response with expected parameters > > anytime a port profile DISASSOCIATE operation was done for 802.1Qbh, > even though the disassociate had been successfully

Re: [libvirt] [PATCH 0/5] logging fixes

On 21.12.2015 18:17, Laine Stump wrote: > These are all related to excessive, misleading, or missing info in > logs when trying to debug problems with SR-IOV network > devices. > > > Patch 2 does change the logging to eliminate an error message when no > error has occurred (or prevent

Re: [libvirt] [PATCH] virStorageVolWipe: Document that wiping journaled FS is useless

2015-12-21 13:39 GMT+03:00 Michal Privoznik : > I'm no expert but I think fstrim is no help here - it merely reclaims > free space on a disk, but raw data is still accessible. At least can be > if disk does not implement DRAT (Deterministic Read After Trim) (read of > zeroes

[libvirt] An AB deadlock and libvirtd crash problem the other day with virsh console

Hi all: I encountered with an AB deadlock and libvirtd crash problem the other day. The process to generate the problems: 1 use the command "virsh create ***.xml" to create a vm 2 after vm is running , use the command "virsh console ***" to connect vm with console 3 after connection,

Re: [libvirt] [PATCH] virStorageVolWipe: Document that wiping journaled FS is useless

2015-12-21 10:18 GMT+03:00 Michal Privoznik : > None that I know of. It's just that I've came across some discussion in > the office about volWipe and it just appeared to me that we ought to > have this documented. May be in this case doing FITRIM ioctl ? As i understand

[libvirt] [PATCH 1/4] virsh: Refactor event printing

To reduce code duplication. Signed-off-by: Jiri Denemark --- tools/virsh-domain.c | 293 --- 1 file changed, 136 insertions(+), 157 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index edbbc34..ba38ed9

[libvirt] [PATCH 0/4] virsh: Some events cleanups and improvements

Jiri Denemark (4): virsh: Refactor event printing virsh: Add timestamps to events virsh: Pass ctl to virshCatchDisconnect virsh: Interrupt *event --loop on disconnect tools/virsh-domain.c | 310 +-- tools/virsh.c| 5 +- 2 files

[libvirt] [PATCH 3/4] virsh: Pass ctl to virshCatchDisconnect

virshCatchDisconnect expects ctl, but we were just passing NULL instead. Signed-off-by: Jiri Denemark --- tools/virsh.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 7484bed..2b53bf7 100644 --- a/tools/virsh.c

Re: [libvirt] ARM KVM GICv3 Support

On Sun, Dec 20, 2015 at 04:49:20PM +0100, Kashyap Chamarthy wrote: > On Tue, Dec 15, 2015 at 04:42:13PM +, Peter Maydell wrote: > > On 15 December 2015 at 16:35, Andrew Jones wrote: > > > This is probably good for guests that happy with both. Guests that > > > need/want a

Re: [libvirt] [PATCH] virStorageVolWipe: Document that wiping journaled FS is useless

On 21.12.2015 11:20, Vasiliy Tolstov wrote: > 2015-12-21 10:18 GMT+03:00 Michal Privoznik : >> None that I know of. It's just that I've came across some discussion in >> the office about volWipe and it just appeared to me that we ought to >> have this documented. > > > May

Re: [libvirt] [PATCH] Revert "admin: Rename virAdmConnect to virAdmDaemon"

On 15/12/15 11:20, Daniel P. Berrange wrote: > On Tue, Dec 15, 2015 at 08:30:41AM +0100, Martin Kletzander wrote: >> On Mon, Dec 14, 2015 at 09:31:33AM +0100, Erik Skultety wrote: >>> On 10/12/15 15:54, Daniel P. Berrange wrote: On Thu, Dec 10, 2015 at 03:46:45PM +0100, Erik Skultety wrote:

Re: [libvirt] [PATCH 3/5] util: improve error reporting in virNetDevVPortProfileGetStatus

On 21.12.2015 18:17, Laine Stump wrote: > The previous error message just indicated that the desired response > couldn't be found, this patch tells what was desired, as well as > listing out the entire table that had been in the netlink response, to > give some kind of idea why it failed. > --- >

Re: [libvirt] Global domain cpu.cfs_quota_us setup

Thank you for help! On 12/21/2015 02:57 PM, Daniel P. Berrange wrote: On Mon, Dec 21, 2015 at 02:47:14PM +0300, Alexander Burluka wrote: Hi! Thank you for answer, Daniel, I should excuse for a long delay before reply. It was caused by long offline discussion in our company . Our business logic

Re: [libvirt] Global domain cpu.cfs_quota_us setup

Hi! Thank you for answer, Daniel, I should excuse for a long delay before reply. It was caused by long offline discussion in our company . Our business logic needs this top level cgroup. Parallels Cloud Server 6 users have use this cgroup for a long time and want similar functionality. Also we

Re: [libvirt] Global domain cpu.cfs_quota_us setup

On Mon, Dec 21, 2015 at 02:47:14PM +0300, Alexander Burluka wrote: > Hi! > Thank you for answer, Daniel, I should excuse for a long delay before reply. > It was caused by long offline discussion in our company . > Our business logic needs this top level cgroup. Parallels Cloud Server 6 > users

[libvirt] [PATCH] qemu: Connect to guest agent iff needed

https://bugzilla.redhat.com/show_bug.cgi?id=1293351 I've came across a bit of a silly scenario, but long story short: after domain was resumed, the virDomainSetTime() API hung for 5 seconds after which it failed with an error. Problem was, that there is no guest agent installed in the domain. But

Re: [libvirt] [PATCH 2/4] virsh: Add timestamps to events

On Mon, 2015-12-21 at 11:04 +0100, Jiri Denemark wrote: >  > @@ -12154,7 +12155,16 @@ virshEventPrint(virshDomEventData *data, >  if (!data->loop && *data->count) >  goto cleanup; >   > -vshPrint(data->ctl, "%s", msg); > +if (data->timestamp) { > +char

[libvirt] [PATCH 4/5] util: reduce debug log in virPCIGetVirtualFunctions()

Due to debug logs like this: virPCIGetDeviceAddressFromSysfsLink:2432 : Attempting to resolve device path from device link '/sys/class/net/eth1/device/virtfn6' logStrToLong_ui:2369 : Converted ':07:00.7' to unsigned int 0 logStrToLong_ui:2369 : Converted '07:00.7' to unsigned int 7

[libvirt] [PATCH 0/5] logging fixes

These are all related to excessive, misleading, or missing info in logs when trying to debug problems with SR-IOV network devices. Patch 2 does change the logging to eliminate an error message when no error has occurred (or prevent overwriting a prior error if a DISASSOCIATE is happening as part

[libvirt] [PATCH 2/5] util: don't log error in virNetDevVPortProfileGetStatus if instanceId is NULL

virNetDevVPortProfileGetStatus() would log the following error: Could not find netlink response with expected parameters anytime a port profile DISASSOCIATE operation was done for 802.1Qbh, even though the disassociate had been successfully completely. Then, due to the fortunate coincidence

[libvirt] [PATCH 1/5] util: report the MAC address that couldn't be set

I noticed in a log file that we had failed to set a MAC address. The log said which interface we were trying to set, but didn't give the offending MAC address, which could have been useful in determining the source of the problem. This patch modifies all three places in the code that set MAC

[libvirt] [PATCH 5/5] docs: update to properly reflect meaning of fields in log filter

The documentation (and comment in libvirtd.conf) says that the text in a log filter is compared to the "source file name", and gives the example of "util/json", but this is not correct (at least not since commit 2835c1e, possibly earlier). It is instead compared to the string given in the

[libvirt] [PATCH 3/5] util: improve error reporting in virNetDevVPortProfileGetStatus

The previous error message just indicated that the desired response couldn't be found, this patch tells what was desired, as well as listing out the entire table that had been in the netlink response, to give some kind of idea why it failed. --- src/util/virnetdevvportprofile.c | 39

Re: [libvirt] [PATCH 0/3] several cgroups/cpuset fixes

On 12/21/2015 03:36 AM, Henning Schild wrote: > On Mon, 14 Dec 2015 16:27:54 -0500 > John Ferlan wrote: > >> >> >> On 11/13/2015 11:56 AM, Henning Schild wrote: >>> Hi, >>> >>> i already explained some of the cgroup problems in some detail so i >>> will not do that again.