Re: [libvirt] [PATCH 1/2] logical: Use correct syntax for thin/sparse pool creation

On 01/11/2016 12:50 PM, Joe Harvell wrote: >> John/Jan: >> >> I actually made a patch similar to this and was about to submit it for >> review. Now I see there is a more thorough version here already >> submitted just over a year ago. I don't see any evidence of this in >> the git repo. Are

[libvirt] [PATCH 0/3] fix qemu:///session startup errors (bz 1271183)

libguestfs and gnome-boxes users have been reporting intermittent qemu:///session launch errors for a while: https://bugzilla.redhat.com/show_bug.cgi?id=1271183 This series fixes it, see individual patches for details Cole Robinson (3): rpc: socket: Minor cleanups rpc: socket: Explicitly

[libvirt] [PATCH 1/3] rpc: socket: Minor cleanups

- Add some debugging - Make the loop dependent only on retries - Make it explicit that connect(2) success exits the loop - Invert the error checking logic --- src/rpc/virnetsocket.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/rpc/virnetsocket.c

Re: [libvirt] [PATCH 2/5] util: don't log error in virNetDevVPortProfileGetStatus if instanceId is NULL

> -Original Message- > From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] > On > Behalf Of Michal Privoznik > Sent: Monday, December 21, 2015 11:56 PM > To: Laine Stump; libvir-list@redhat.com > Cc: stef...@us.ibm.com > Subject: Re: [libvirt] [PATCH 2/5] util:

Re: [libvirt] [PATCH v3 08/14] virsh: Create macro for common "file" option

On 01/11/2016 09:38 AM, Andrea Bolognani wrote: > On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: >> Rather than continually cut-n-paste the strings into each command, >> create a common macro to be used generically. Note that not all >> '{.name = "file",' entries are replaced, just those

Re: [libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

On 01/11/2016 11:26 AM, Andrea Bolognani wrote: > On Mon, 2016-01-11 at 10:55 -0500, John Ferlan wrote: >> >>> The config option for the 'schedinfo' and 'change-media' >>> commands, while it has a slightly different help text, also >>> serves AFAICT the same purpose and as such should IMHO use

[libvirt] [PATCH 3/3] rpc: socket: Don't repeatedly attempt to launch daemon

On every socket connect(2) attempt we were re-launching session libvirtd, up to 100 times in 5 seconds. This understandably caused some weird load races and intermittent qemu:///session startup failures https://bugzilla.redhat.com/show_bug.cgi?id=1271183 --- src/rpc/virnetsocket.c | 9 +++--

[libvirt] [PATCH 2/3] rpc: socket: Explicitly error if we exceed retry count

When we autolaunch libvirtd for session URIs, we spin in a retry loop waiting for the daemon to start and the connect(2) to succeed. However if we exceed the retry count, we don't explicitly raise an error, which can yield a slew of different error messages elsewhere in the code. Explicitly

[libvirt] Entering freeze for libvirt-1.3.1

As suggested this w.e., I just tagged the release candidate 1 in git and pushed signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ This works fine with my limited testing, but obviously more people need to give it some trial especially on other platforms. The output

Re: [libvirt] [PATCH 2/5] util: don't log error in virNetDevVPortProfileGetStatus if instanceId is NULL

On 01/11/2016 04:50 PM, Christian Benvenuti (benve) wrote: -Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] On Behalf Of Michal Privoznik Sent: Monday, December 21, 2015 11:56 PM To: Laine Stump; libvir-list@redhat.com Cc: stef...@us.ibm.com

[libvirt] [PATCH] Xen: use correct domctl version in domaininfolist union

Commmit fd2e3c4c used the domctl version 8 structure for version 9 in the xen_getdomaininfolist union, resulting in insufficient buffer size (and subsequent memory corruption) for the GETDOMAININFOLIST ioctl. Signed-off-by: Jim Fehlig --- src/xen/xen_hypervisor.c | 2 +- 1

Re: [libvirt] [PATCH v3 09/14] virsh: Create macros for common "pool" options

On 01/11/2016 10:39 AM, Andrea Bolognani wrote: > On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: >> Rather than continually cut-n-paste the strings into each command, >> create common macros to be used generically. For virsh-volume, there >> are 3 different types of "pool" options - 2

Re: [libvirt] [PATCH v3 00/14] Use macros for more common virsh command options

On 01/09/2016 08:36 AM, John Ferlan wrote: > v2: > http://www.redhat.com/archives/libvir-list/2015-December/msg00766.html > > Changes since v2: > > Use VIRSH_COMMON_OPT_ for option prefix instead of > VIRSH__OPT_COMMON > > Patches have a few thumbs up already, figured I'd post it one last

Re: [libvirt] [PATCH v2 3/3] Unify int types handling in protocol files

On Mon, Jan 11, 2016 at 03:34:05AM +0300, Roman Bogorodskiy wrote: From: Jasper Lievisse Adriaanse Some of the protocol files already include handing of the missing int types such as xdr_uint64_t, some don't. To fix it everywhere, move out of the appropriate defines to the

[libvirt] [PATCH v3 0/5] Don't blindly connect to qemu-ga

diff to v2: - completely reworked, new approach Michal Privoznik (5): qemu: Set virtio channel state sooner qemu: Rename qemuProcessReconnectRefreshChannelVirtioState qemu: change qemuFindAgentConfig return type qemu: Introduce QEMU_CAPS_VSERPORT_CHANGE qemu: Connect to guest agent iff

Re: [libvirt] [PATCH v3 01/14] virsh: Covert VSH_POOL_ macro to VIRSH_COMMON_OPT_

On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > Commit id's 'cf793b00', 'e178688f', 'f9a6110f', '5372d49', and 'e193735' > added new VSH_POOL_ macros; however, it was pointed out after push that > commit id '834c5720' preferred use of VIRSH_ for the prefix over VSH_. > > So this patch

Re: [libvirt] [PATCH v3] libvirtd: Increase NL buffer size for lots of interface

On Mon, Jan 11, 2016 at 02:59:00PM +0800, Leno Hou wrote: 1. When switching CPUs to offline/online in a system more than 128 cpus 2. When using virsh to destroy domain in a system with more interface All of above happens nl_recv returned with error: No buffer space available. This patch sets

Re: [libvirt] [PATCH v3 03/14] virsh: Create macro for common "domain" option

On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > Rather than continually cut-n-paste the strings into each command, > create a common macro to be used generically.  Note that not all > '{.name = "domain",' entries are replaced, just those that have the > common .help string of "domain name,

[libvirt] [PATCH v3 1/5] qemu: Set virtio channel state sooner

In qemu driver we listen to virtio channel events like an agent connected to or disconnected from the guest part of socket. However, with a little exception - when we find out that the socket in question is the guest agent one, we connect or disconnect guest agent which is done prior setting new

Re: [libvirt] Plans for next release

On Sun, 2016-01-10 at 09:56 +0800, Daniel Veillard wrote: >  So we should push 1.3.1 by the middle of this month (with 1.3.2 for > end of Feb as decided when we planned 1.3.0) which means we should enter > freeze soon. I am suggesting to start the freeze in Tuesday, with rc2 on > Thursday and

[libvirt] [PATCH v3 3/5] qemu: change qemuFindAgentConfig return type

While this is no functional change, whole channel definition is going to be needed very soon. Moreover, while touching this obey const correctness rule in qemuAgentOpen() - so far it was passed regular pointer to channel config even though the function is expected to not change pointee at all.

[libvirt] [PATCH v3 5/5] qemu: Connect to guest agent iff needed

https://bugzilla.redhat.com/show_bug.cgi?id=1293351 Since we already have virtio channel events, we know when guest agent within guest has (dis-)connected. Instead of us blindly connecting to a socket that no one is listening to, we can just follow what qemu-ga does. This has a nice benefit that

[libvirt] [PATCH v3 2/5] qemu: Rename qemuProcessReconnectRefreshChannelVirtioState

This function is going to called from other areas not just reconnect. New name is qemuProcessRefreshChannelState. At the same time expose the function as it's going to be needed very soon. Signed-off-by: Michal Privoznik --- src/qemu/qemu_process.c | 8

Re: [libvirt] [PATCH 0/2] Fix crashing libvirt after my commit

On 08.01.2016 14:26, Martin Kletzander wrote: > The commit was clearing the socket path even when parsing status XML. > This series should fix that. > > > Martin Kletzander (2): > Provide parse flags to PostParse functions > Don't clear libvirt-internal paths when parsing status XML > >

[libvirt] [PATCH v3 4/5] qemu: Introduce QEMU_CAPS_VSERPORT_CHANGE

This capability tells if qemu is capable of vserport_change events. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 3 +++ tests/qemucapabilitiesdata/caps_2.1.1-1.caps | 1 +

Re: [libvirt] Bug in RPC code causes failure to start LXC container using virDomainCreateXMLWithFiles

On Thu, Nov 26, 2015 at 04:10:40PM +, Ben Gray wrote: Hi, Occasionally when trying to start LXC containers with fds I get the following error: Wow, this is here for a while... Sorry for the delay. virNetMessageDupFD:562 : Unable to duplicate FD -1: Bad file descriptor

Re: [libvirt] Entering freeze for libvirt-1.3.1

On 12 Jan 2016, at 01:32, Daniel Veillard wrote: > As suggested this w.e., I just tagged the release candidate 1 in git > and pushed signed tarball and rpms to the usual place: > > ftp://libvirt.org/libvirt/ > > This works fine with my limited testing, but obviously more

Re: [libvirt] Entering freeze for libvirt-1.3.1

Justin Clift wrote: > On 12 Jan 2016, at 01:32, Daniel Veillard wrote: > > As suggested this w.e., I just tagged the release candidate 1 in git > > and pushed signed tarball and rpms to the usual place: > > > > ftp://libvirt.org/libvirt/ > > > > This works fine with

Re: [libvirt] [PATCH 2/3] rpc: socket: Explicitly error if we exceed retry count

On Mon, Jan 11, 2016 at 08:22:33PM -0500, Cole Robinson wrote: When we autolaunch libvirtd for session URIs, we spin in a retry loop waiting for the daemon to start and the connect(2) to succeed. However if we exceed the retry count, we don't explicitly raise an error, which can yield a slew of

Re: [libvirt] [PATCH 0/3] fix qemu:///session startup errors (bz 1271183)

On Mon, Jan 11, 2016 at 08:22:31PM -0500, Cole Robinson wrote: libguestfs and gnome-boxes users have been reporting intermittent qemu:///session launch errors for a while: https://bugzilla.redhat.com/show_bug.cgi?id=1271183 This series fixes it, see individual patches for details We missed

Re: [libvirt] DNS for IPv6 addresses?

On Fri, Jan 08, 2016 at 11:40:09AM +0200, Yaniv Kaul wrote: Is there a way to define DNS for IPv6 addresses? Something like: lago_basic_suite_3_6_storage-iscsi Only for IPv6? I reckon I can't just use an IPv6 address in the 'IP' attribute? Yes you can. Look at

Re: [libvirt] [PATCH] Xen: use correct domctl version in domaininfolist union

On Mon, Jan 11, 2016 at 03:26:23PM -0700, Jim Fehlig wrote: Commmit fd2e3c4c used the domctl version 8 structure for version 9 in the xen_getdomaininfolist union, resulting in insufficient buffer size (and subsequent memory corruption) for the GETDOMAININFOLIST ioctl. Signed-off-by: Jim Fehlig

Re: [libvirt] [PATCH v3] libvirtd: Increase NL buffer size for lots of interface

On Mon, Jan 11, 2016 at 02:32:44PM -0500, Laine Stump wrote: On 01/11/2016 05:44 AM, Martin Kletzander wrote: On Mon, Jan 11, 2016 at 02:59:00PM +0800, Leno Hou wrote: 1. When switching CPUs to offline/online in a system more than 128 cpus 2. When using virsh to destroy domain in a system with

Re: [libvirt] [PATCH 00/21] Support NBD for tunnelled migration

On 08.01.2016 02:30, Jiri Denemark wrote: > On Wed, Nov 18, 2015 at 20:12:58 +0200, Pavel Boldin wrote: >> The provided patchset implements NBD disk migration over a tunnelled >> connection provided by libvirt. >> >> The migration source instructs QEMU to NBD mirror drives into the provided >>

Re: [libvirt] [PATCH] virDomainInterfaceAddresses: Allow API on RO connection too

On 11.01.2016 13:11, Daniel P. Berrange wrote: > On Mon, Jan 11, 2016 at 12:52:36PM +0100, Michal Privoznik wrote: >> This API does not change domain state. It's merely like >> virDomainGetXMLDesc() - and we don't reject RO connections there. >> There's no reason to reject them here. > > This API

Re: [libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

On Mon, 2016-01-11 at 13:21 +0100, Andrea Bolognani wrote: >  > The config option for the 'schedinfo' and 'change-media' > commands, while it has a slightly different help text, also > serves AFAICT the same purpose and as such should IMHO use the > macro you just defined as well. Ignore the bit

Re: [libvirt] [libvirt-php] libvirt_domain_create_xml allow passing flags

2016-01-11 15:45 GMT+03:00 Michal Privoznik : > I prefer space after comma. > >> >> -domain=virDomainCreateXML(conn->conn,xml,0); >> +domain=virDomainCreateXML(conn->conn,xml,flags); >> DPRINTF("%s: virDomainCreateXML(%p, , 0) returned %p\n", PHPFUNC, >>

Re: [libvirt] [PATCH v3 14/14] virsh: Create macro for common "interface" option

On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > Rather than continually cut-n-paste the strings into each command, > create a common macro to be used generically.  Note that not all > '{.name = "interface",' entries are replaced, just those that have the > common .help string of "interface

Re: [libvirt] [PATCH v3 2/5] qemu: Rename qemuProcessReconnectRefreshChannelVirtioState

On Mon, Jan 11, 2016 at 11:31:09AM +0100, Michal Privoznik wrote: > This function is going to called from other areas not just s/going to called/going to be called/ > reconnect. New name is qemuProcessRefreshChannelState. At the > same time expose the function as it's going to be needed very >

Re: [libvirt] [PATCH] virDomainInterfaceAddresses: Allow API on RO connection too

On Mon, Jan 11, 2016 at 12:52:36PM +0100, Michal Privoznik wrote: > This API does not change domain state. It's merely like > virDomainGetXMLDesc() - and we don't reject RO connections there. > There's no reason to reject them here. This API can result in talking to the guest agent IIRC, which

Re: [libvirt] [PATCH v3 07/14] virsh: Create macro for common "current" option

On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > Rather than continually cut-n-paste the strings into each command, > create a common macro to be used generically.  Note that not all > '{.name = "current",' entries are replaced, just those that have the > common .help string of "affect

Re: [libvirt] [PATCH 0/3] several cgroups/cpuset fixes

On 01/11/2016 06:38 AM, Henning Schild wrote: > On Fri, 8 Jan 2016 11:05:59 -0500 > John Ferlan wrote: > >> I'm leaning towards something in the test. I'll check if reverting these changes alters the results. I don't imagine it will. >>> >>> The real question

[libvirt] [PATCH] virDomainInterfaceAddresses: Allow API on RO connection too

This API does not change domain state. It's merely like virDomainGetXMLDesc() - and we don't reject RO connections there. There's no reason to reject them here. Signed-off-by: Michal Privoznik --- src/libvirt-domain.c | 1 - 1 file changed, 1 deletion(-) diff --git

[libvirt] [libvirt-php] libvirt_domain_create_xml allow passing flags

libvirt_domain_create_xml miss ability to pass flags when create domain, fixing it. Signed-off-by: Vasiliy Tolstov --- src/libvirt-php.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index

Re: [libvirt] [PATCH v2 2/2] virDomainGetTime: Deny on RO connections

On Mon, Jan 11, 2016 at 01:38:14PM +0100, Michal Privoznik wrote: > We have a policy that if API may end up talking to a guest agent > it should require RW connection. We don't obey the rule in > virDomainGetTime(). > > Signed-off-by: Michal Privoznik > --- >

Re: [libvirt] [PATCH 0/3] virsh: Implement and document --timeout everywhere

On Fri, Jan 08, 2016 at 13:21:16 +0100, Andrea Bolognani wrote: > Jirka added a new --timestamp option to 'virsh event'[1], so I went > ahead and updated the 'net-event' and 'qemu-monitor-event' virsh > commands to support it as well. > > I've also updated the man page so that the new option is

Re: [libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

On Mon, 2016-01-11 at 13:21 +0100, Andrea Bolognani wrote: > On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > > Rather than continually cut-n-paste the strings into each command, > > create a common macro to be used generically.  Note that not all > > '{.name = "config",' entries are

[libvirt] [PATCH v2 1/2] virDomainInterfaceAddresses: Allow API on RO connection too

This API does not change domain state. However, we have a policy that an API talking to a guest agent requires RW access. But that happens only if source == VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT. Signed-off-by: Michal Privoznik --- src/libvirt-domain.c | 3 ++- 1 file

Re: [libvirt] [PATCH v3 12/14] virsh: have snapshot use common "domain" option

On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > Make use of the common VIRSH_COMMON_OPT_DOMAIN macro for each of the > matching '.name = "domain"' command options. > > Signed-off-by: John Ferlan > --- >  tools/virsh-snapshot.c | 60 >

Re: [libvirt] [PATCH] virDomainInterfaceAddresses: Allow API on RO connection too

On Mon, Jan 11, 2016 at 01:20:38PM +0100, Michal Privoznik wrote: > On 11.01.2016 13:11, Daniel P. Berrange wrote: > > On Mon, Jan 11, 2016 at 12:52:36PM +0100, Michal Privoznik wrote: > >> This API does not change domain state. It's merely like > >> virDomainGetXMLDesc() - and we don't reject RO

[libvirt] [PATCH v2 2/2] virDomainGetTime: Deny on RO connections

We have a policy that if API may end up talking to a guest agent it should require RW connection. We don't obey the rule in virDomainGetTime(). Signed-off-by: Michal Privoznik --- src/libvirt-domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libvirt-domain.c

[libvirt] [PATCH v2 0/2] Couple of RO/RW connection fixes

diff to v1: - After some discussion with Daniel, allow virDomainInterfaceAddresses on RO only if it does not end up talking to guest agent. - Also fix virDomainGetTime Michal Privoznik (2): virDomainInterfaceAddresses: Allow API on RO connection too virDomainGetTime: Deny on RO connections

Re: [libvirt] [PATCH 0/3] several cgroups/cpuset fixes

On Fri, 8 Jan 2016 11:05:59 -0500 John Ferlan wrote: > > >> > >> I'm leaning towards something in the test. I'll check if reverting > >> these changes alters the results. I don't imagine it will. > > > > The real question is which thread it fails on and at what point in > >

Re: [libvirt] [PATCH v3 04/14] virsh: Create macro for common "persistent" option

On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > Rather than continually cut-n-paste the strings into each command, > create a common macro to be used generically.  Note that not all > '{.name = "persistent",' entries are replaced, just those that have the > common .help string of "make

Re: [libvirt] [PATCH v3 06/14] virsh: Create macro for common "live" option

On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > Rather than continually cut-n-paste the strings into each command, > create a common macro to be used generically.  Note that not all > '{.name = "live",' entries are replaced, just those that have the > common .help string of "affect running

Re: [libvirt] [PATCH] virDomainInterfaceAddresses: Allow API on RO connection too

On 11.01.2016 13:26, Daniel P. Berrange wrote: > On Mon, Jan 11, 2016 at 01:20:38PM +0100, Michal Privoznik wrote: >> On 11.01.2016 13:11, Daniel P. Berrange wrote: >>> On Mon, Jan 11, 2016 at 12:52:36PM +0100, Michal Privoznik wrote: This API does not change domain state. It's merely like

Re: [libvirt] [PATCH 0/3] virsh: Implement and document --timeout everywhere

On Mon, 2016-01-11 at 12:28 +0100, Jiri Denemark wrote: > On Fri, Jan 08, 2016 at 13:21:16 +0100, Andrea Bolognani wrote: > > Jirka added a new --timestamp option to 'virsh event'[1], so I went > > ahead and updated the 'net-event' and 'qemu-monitor-event' virsh > > commands to support it as well.

Re: [libvirt] [PATCH v3 02/14] virsh: Move VIRSH_COMMON_OPT_POOL to virsh.h

On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > Since it can be used by other virsh*.c modules, move the macro to virsh.h > and add virsh.h to POTFILES.in (since there are translatable strings). > > Signed-off-by: John Ferlan > --- >  po/POTFILES.in |  1 + >  

Re: [libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > Rather than continually cut-n-paste the strings into each command, > create a common macro to be used generically.  Note that not all > '{.name = "config",' entries are replaced, just those that have the > common .help string of "affect next

Re: [libvirt] [libvirt-php] libvirt_domain_create_xml allow passing flags

On 11.01.2016 13:31, Vasiliy Tolstov wrote: > libvirt_domain_create_xml miss ability to pass flags when create domain, > fixing it. > > Signed-off-by: Vasiliy Tolstov > --- > src/libvirt-php.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff

Re: [libvirt] [PATCH v2 1/2] virDomainInterfaceAddresses: Allow API on RO connection too

On Mon, Jan 11, 2016 at 01:38:13PM +0100, Michal Privoznik wrote: > This API does not change domain state. However, we have a policy > that an API talking to a guest agent requires RW access. But that > happens only if source == VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT. > > Signed-off-by: Michal

Re: [libvirt] [PATCH v3 11/14] virsh: Have domain-monitor use common "domain" option

On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > Make use of the common VIRSH_COMMON_OPT_DOMAIN macro for each of the > matching '.name = "domain"' command options. >  > Signed-off-by: John Ferlan > --- >  tools/virsh-domain-monitor.c | 77

Re: [libvirt] [PATCH v3 13/14] virsh: Create macro for common "network" option

On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > Rather than continually cut-n-paste the strings into each command, > create a common macro to be used generically.  Note that not all > '{.name = "network",' entries are replaced, just those that have the > common .help string of "network

Re: [libvirt] [PATCH v3 5/5] qemu: Connect to guest agent iff needed

On Mon, Jan 11, 2016 at 11:31:12AM +0100, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1293351 Since we already have virtio channel events, we know when guest agent within guest has (dis-)connected. Instead of us blindly connecting to a socket that no one is listening to,

Re: [libvirt] [PATCH 1/2] logical: Use correct syntax for thin/sparse pool creation

John/Jan: I actually made a patch similar to this and was about to submit it for review. Now I see there is a more thorough version here already submitted just over a year ago. I don't see any evidence of this in the git repo. Are there any plans to commit it? --- Joe Harvell --

Re: [libvirt] [PATCH] vmx: Adapt to emptyBackingString for cdrom-image

On Thu, Jan 07, 2016 at 09:59:09AM +0100, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1266088 We are missing this value for cdrom-image device. Honestly, I have no idea whether it can happen for other disk devices too. Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH] vmx: Adapt to emptyBackingString for cdrom-image

2016-01-11 17:03 GMT+01:00 Martin Kletzander : > On Thu, Jan 07, 2016 at 09:59:09AM +0100, Michal Privoznik wrote: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=1266088 >> >> We are missing this value for cdrom-image device. Honestly, I >> have no idea whether it can

Re: [libvirt] [PATCH v2 3/3] Unify int types handling in protocol files

Martin Kletzander wrote: > On Mon, Jan 11, 2016 at 03:34:05AM +0300, Roman Bogorodskiy wrote: > >From: Jasper Lievisse Adriaanse > > > >Some of the protocol files already include handing of the missing int > >types such as xdr_uint64_t, some don't. To fix it everywhere,

Re: [libvirt] [PATCH 0/5] Couple of wireshark fixes

On Mon, Jan 04, 2016 at 12:26:22PM +0100, Michal Privoznik wrote: Well, I've just updated wireshark on my system and encountered couple of compile errors while building libvirt. Here are the fixes. Fortunately, none of them requires us to increase the version number of wireshark that's required.

Re: [libvirt] [PATCH 1/3] build: Kill include/libvirt/Makefile.am

On 01/11/2016 02:47 AM, Martin Kletzander wrote: > On Sun, Jan 10, 2016 at 06:06:21PM -0500, Cole Robinson wrote: >> Move all the logic to include/Makefile.am, simplify it with a wildcard, >> then kill include/libvirt/Makefile.am >> --- >> configure.ac| 2 +- >> include/Makefile.am

Re: [libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

On Mon, 2016-01-11 at 10:55 -0500, John Ferlan wrote: > > > The config option for the 'schedinfo' and 'change-media' > > commands, while it has a slightly different help text, also > > serves AFAICT the same purpose and as such should IMHO use the > > macro you just defined as well. >  > BTW: I

Re: [libvirt] [PATCH 1/2] cgroup: fix including sys/mount.h for OpenBSD

Martin Kletzander wrote: > >That's an interesting question. > > > >A check for sys/mount.h was added with the initial implementation of the > >mount() using code in commit 1da631e. The mount() call currently is used > >only on platforms with cgroups available (i.e. Linux). > > > >Moreover,

Re: [libvirt] [PATCH v3 03/14] virsh: Create macro for common "domain" option

On 01/11/2016 05:57 AM, Andrea Bolognani wrote: > On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: >> Rather than continually cut-n-paste the strings into each command, >> create a common macro to be used generically. Note that not all >> '{.name = "domain",' entries are replaced, just

Re: [libvirt] [PATCH v3 09/14] virsh: Create macros for common "pool" options

On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > Rather than continually cut-n-paste the strings into each command, > create common macros to be used generically.  For virsh-volume, there > are 3 different types of "pool" options - 2 for create, 2 required > for the command, and 10 for

Re: [libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

On 01/11/2016 07:21 AM, Andrea Bolognani wrote: > On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: >> Rather than continually cut-n-paste the strings into each command, >> create a common macro to be used generically. Note that not all >> '{.name = "config",' entries are replaced, just

Re: [libvirt] [PATCH v3 10/14] virsh: Create macros for common "vol" options

On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > Rather than continually cut-n-paste the strings into each command, > create common macros to be used generically.  Replace the more commonly > used "vol" option with a macro. This also adjusts 2 commands that > didn't have the correct helpstr

Re: [libvirt] [PATCH v3 11/14] virsh: Have domain-monitor use common "domain" option

On 01/11/2016 08:07 AM, Andrea Bolognani wrote: > On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: >> Make use of the common VIRSH_COMMON_OPT_DOMAIN macro for each of the >> matching '.name = "domain"' command options. >> >> Signed-off-by: John Ferlan >> --- >>

Re: [libvirt] [PATCH 0/3] several cgroups/cpuset fixes

On Mon, 11 Jan 2016 07:05:11 -0500 John Ferlan wrote: > > > On 01/11/2016 06:38 AM, Henning Schild wrote: > > On Fri, 8 Jan 2016 11:05:59 -0500 > > John Ferlan wrote: > > > >> > > I'm leaning towards something in the test. I'll check if >

Re: [libvirt] [PATCH v3 08/14] virsh: Create macro for common "file" option

On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > Rather than continually cut-n-paste the strings into each command, > create a common macro to be used generically.  Note that not all > '{.name = "file",' entries are replaced, just those that use > VSH_OT_DATA and VSH_OFLAG_REQ. >  >

Re: [libvirt] [PATCH 1/2] logical: Use correct syntax for thin/sparse pool creation

John/Jan: I actually made a patch similar to this and was about to submit it for review. Now I see there is a more thorough version here already submitted just over a year ago. I don't see any evidence of this in the git repo. Are there any plans to commit it? --- Joe Harvell --

Re: [libvirt] [PATCH] qemu: use enum when setting PCI "multi" value, not 0 or 1

On 01/11/2016 01:31 PM, Laine Stump wrote: > From: root > ^^^ If you fix this to something "Use the VIR_TRISTATE_SWITCH_* enums appropriately.", then ACK John > No functional change. > --- > This was suggested by jferlan in an earlier review. > >

Re: [libvirt] [PATCH 2/5] qemu: prefer 00:1D.x and 00:1A.x for USB2 controllers on Q35

On 12/09/2015 08:16 AM, John Ferlan wrote: On 11/19/2015 01:24 PM, Laine Stump wrote: The real Q35 machine puts the first USB controller set (EHCI+(UHCIx4)) on bus 0 slot 0x1D, and the 2nd USB controller set on bus 0 slot 0x1A, so let's attempt to make the virtual machine match that for

[libvirt] [PATCH] qemu: use enum when setting PCI "multi" value, not 0 or 1

From: root No functional change. --- This was suggested by jferlan in an earlier review. src/qemu/qemu_command.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 936a43e..3c9caea 100644

Re: [libvirt] [PATCH 0/5] auto-add USB2 controller set for Q35

On 11/19/2015 01:24 PM, Laine Stump wrote: For just about every other machinetype, libvirt automatically adds a USB controller if there is no controller (including "type='none'") specified in the config. It doesn't do this for the Q35 machinetype, because Q35 hardware would have a USB2

Re: [libvirt] [PATCH 4/5] qemu: define virDomainDevAddUSBController()

On 12/09/2015 09:36 AM, John Ferlan wrote: On 11/19/2015 01:25 PM, Laine Stump wrote: This new function will add a single controller of the given model, except the case of ich9-usb-ehci1 (the master controller for a USB2 controller set) in which case a set of related controllers will be added

Re: [libvirt] [PATCH 3/5] conf: add virDomainDefAddController()

On 12/09/2015 09:01 AM, John Ferlan wrote: On 11/19/2015 01:25 PM, Laine Stump wrote: We need a virDomainDefAddController() that doesn't check for an existing controller at the same index (since USB2 controllers must be added in sets of 4 that are all at the same index), so rather than

Re: [libvirt] [PATCH v3] libvirtd: Increase NL buffer size for lots of interface

On 01/11/2016 05:44 AM, Martin Kletzander wrote: On Mon, Jan 11, 2016 at 02:59:00PM +0800, Leno Hou wrote: 1. When switching CPUs to offline/online in a system more than 128 cpus 2. When using virsh to destroy domain in a system with more interface All of above happens nl_recv returned with