[libvirt] [PATCH] cpu_map.xml: Expose svm flag for nested kvm on AMD CPU model

2016-01-19 Thread Lin Ma
QEMU commit 75d373e disables svm by default since PC machine 2.2. So with PC machine version > 2.1, When a user wants to expose the svm flag to a guest, says: .. .. The svm flag wont be passed to qemu command line, This patch fixes it. Signed-off-by: Lin Ma ---

Re: [libvirt] [PATCH] cpu_map.xml: Expose svm flag for nested kvm on AMD CPU model

2016-01-19 Thread Jiri Denemark
On Tue, Jan 19, 2016 at 17:11:36 +0800, Lin Ma wrote: > QEMU commit 75d373e disables svm by default since PC machine 2.2. > So with PC machine version > 2.1, When a user wants to expose the > svm flag to a guest, says: > > .. > > .. > > The svm flag wont be passed to qemu command

Re: [libvirt] [PATCH 1/6] leaseshelper: store server_duid as an allocated string

2016-01-19 Thread Daniel P. Berrange
On Tue, Jan 19, 2016 at 10:54:00AM +0100, Ján Tomko wrote: > We either use the value from the environment variable, or learn it from > the existing lease file. > > In the second case, the pointer would be pointing into the JSON object > of the first lease with a DUID, owned by leases_array, then

Re: [libvirt] [PATCH 2/6] leaseshelper: split out custom leases file read

2016-01-19 Thread Daniel P. Berrange
On Tue, Jan 19, 2016 at 10:54:01AM +0100, Ján Tomko wrote: > Introduce virLeaseReadCustomLeaseFile which will populate > the new leases array with all the leases, except for expired > ones and the ones matching 'ip_to_delete'. > > This removes five variables from main(). > --- >

Re: [libvirt] [PATCH 3/6] leaseshelper: split out virLeasePrintLeases

2016-01-19 Thread Daniel P. Berrange
On Tue, Jan 19, 2016 at 10:54:02AM +0100, Ján Tomko wrote: > Introduce a function for printing the leases on the 'init' operation. > --- > src/network/leaseshelper.c | 130 > + > 1 file changed, 73 insertions(+), 57 deletions(-) ACK Regards, Daniel

Re: [libvirt] [PATCH 4/6] leaseshelper: remove useless comparison

2016-01-19 Thread Daniel P. Berrange
On Tue, Jan 19, 2016 at 10:54:03AM +0100, Ján Tomko wrote: > We do not care if the mac was specified in the delete section, > we are going to delete the record anyway. > > Also move the comment about adding ipv6 leases to the ADD case. NB best practice is to use separate commits for separate

Re: [libvirt] [PATCH 5/6] leaseshelper: split out virLeaseNewFromArgv

2016-01-19 Thread Daniel P. Berrange
On Tue, Jan 19, 2016 at 10:54:04AM +0100, Ján Tomko wrote: > For the actions ADD and OLD, split out creating the new lease object, > along with processing all the program args and environment variables > that are only needed in this case. > --- > src/network/leaseshelper.c | 156 >

Re: [libvirt] [PATCH 6/6] leaseshelper: reduce indentation level in virLeaseReadCustomLeaseFile

2016-01-19 Thread Daniel P. Berrange
On Tue, Jan 19, 2016 at 10:54:05AM +0100, Ján Tomko wrote: > Instead of nested ifs, jump out early. > > Mostly whitespace changes. > --- > src/network/leaseshelper.c | 120 > +++-- > 1 file changed, 62 insertions(+), 58 deletions(-) ACK Regards, Daniel

Re: [libvirt] [PATCH] leaseshelper: fix crash when no mac is specified

2016-01-19 Thread Daniel P. Berrange
On Thu, Jan 14, 2016 at 03:15:04PM +0100, Ján Tomko wrote: > If dnsmasq specified DNSMASQ_IAID (so we're dealing with an IPv6 > lease) but no DNSMASQ_MAC, we skip creation of the new lease object. > > Also skip adding it to the leases array. > >

Re: [libvirt] [PATCH 02/16] Add public APIs for post-copy migration

2016-01-19 Thread Daniel P. Berrange
On Tue, Jan 19, 2016 at 10:50:07AM +0100, Jiri Denemark wrote: > From: Cristian Klein > > To use post-copy one has to start the migration with > VIR_MIGRATE_POSTCOPY flag and VIR_MIGRATE_POSTCOPY_AFTER_PRECOPY or, > while migration is in progress, call

[libvirt] [PATCH 08/16] qemu: Add flags to qemuMigrationWaitForCompletion

2016-01-19 Thread Jiri Denemark
The function already takes two bool arguments and we'd add a third one. Switching to flags makes it a lot easier to read. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git

[libvirt] [PATCH 06/16] qemu: Add support for VIR_MIGRATE_POSTCOPY flag

2016-01-19 Thread Jiri Denemark
From: Cristian Klein Signed-off-by: Cristian Klein Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c | 76 +++ src/qemu/qemu_migration.h | 3 +- 2 files changed, 78

[libvirt] [PATCH 11/16] virsh: Configurable migrate --timeout action

2016-01-19 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- tools/virsh-domain.c | 63 +--- tools/virsh.pod | 15 - 2 files changed, 65 insertions(+), 13 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index

[libvirt] [PATCH 15/16] qemu: Handle post-copy migration failures

2016-01-19 Thread Jiri Denemark
When migration fails in the post-copy mode, it's impossible to just kill the destination domain and resume the source since the source no longer contains current guest state. Let's mark domains on both sides as VIR_DOMAIN_PAUSED_POSTCOPY_FAILED to let the upper layer decide what to do with them.

[libvirt] [PATCH 12/16] virsh: Add --postcopy-after-precopy option to migrate

2016-01-19 Thread Jiri Denemark
From: Cristian Klein Signed-off-by: Cristian Klein Signed-off-by: Jiri Denemark --- tools/virsh-domain.c | 6 ++ tools/virsh.pod | 9 ++--- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git

[libvirt] [PATCH 10/16] virsh: Add support for post-copy migration

2016-01-19 Thread Jiri Denemark
From: Cristian Klein Signed-off-by: Cristian Klein Signed-off-by: Jiri Denemark --- tools/virsh-domain.c | 55 tools/virsh.pod | 11 ++- 2 files changed, 65

[libvirt] [PATCH 02/16] Add public APIs for post-copy migration

2016-01-19 Thread Jiri Denemark
From: Cristian Klein To use post-copy one has to start the migration with VIR_MIGRATE_POSTCOPY flag and VIR_MIGRATE_POSTCOPY_AFTER_PRECOPY or, while migration is in progress, call virDomainMigrateStartPostCopy() to switch from pre-copy to post-copy. Signed-off-by:

[libvirt] [PATCH 00/16] Implement post-copy migration

2016-01-19 Thread Jiri Denemark
(See "Add public APIs for post-copy migration" patch for more details about post-copy migration.) Post-copy support was originally written by Cristian Klein in 2014, but no one touched the series since then. Some patches in this series are modified versions of the old patches from Cristian, some

[libvirt] [PATCH 09/16] qemu: Add support for VIR_MIGRATE_POSTCOPY_AFTER_PRECOPY flag

2016-01-19 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c | 16 src/qemu/qemu_migration.h | 3 ++- src/qemu/qemu_process.c | 3 +++ 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c

[libvirt] [PATCH 13/16] qemu: Don't kill running migrated domain on daemon restart

2016-01-19 Thread Jiri Denemark
When destination libvirtd is restarted during migration in Finish phase just after the point we started guest CPUs, we should not kill the domain. Signed-off-by: Jiri Denemark --- src/qemu/qemu_process.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff

[libvirt] [PATCH 05/16] qemu: Add QMP functions for post-copy migration

2016-01-19 Thread Jiri Denemark
From: Cristian Klein Signed-off-by: Cristian Klein Signed-off-by: Jiri Denemark --- Notes: The migration capability is called x-postcopy-ram in QEMU, which means it's still considered experimental. The main reason for

[libvirt] [PATCH 07/16] qemu: Implement virDomainMigrateStartPostCopy

2016-01-19 Thread Jiri Denemark
From: Cristian Klein Signed-off-by: Cristian Klein Signed-off-by: Jiri Denemark --- src/qemu/qemu_domain.c| 1 + src/qemu/qemu_domain.h| 1 + src/qemu/qemu_driver.c| 58

[libvirt] [PATCH 16/16] qemu: Refuse to abort migration in post-copy mode

2016-01-19 Thread Jiri Denemark
In post-copy mode none of the hosts has a complete guest state and rolling back migration is impossible. Thus aborting it would be equivalent to destroying the domain. Signed-off-by: Jiri Denemark --- src/qemu/qemu_driver.c | 14 +- 1 file changed, 13

[libvirt] [PATCH 14/16] qemu: Refactor qemuProcessRecoverMigration

2016-01-19 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/qemu/qemu_process.c | 206 ++-- 1 file changed, 110 insertions(+), 96 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 240aa04..d6a67b0 100644 ---

[libvirt] [PATCH 03/16] qemu: Don't explicitly stop CPUs after migration

2016-01-19 Thread Jiri Denemark
With a very old QEMU which doesn't support events we need to explicitly call qemuMigrationSetOffline at the end of migration to update our internal state. On the other hand, if we talk to QEMU using QMP, we should just wait for the STOP event and let the event handler update the state and trigger

[libvirt] [PATCH 01/16] Add event and state details for post-copy

2016-01-19 Thread Jiri Denemark
VIR_DOMAIN_EVENT_SUSPENDED_POSTCOPY and VIR_DOMAIN_PAUSED_POSTCOPY are used on the source host once migration enters post-copy mode (which means the domain gets paused on the source. After the destination host takes over the execution of the domain, its virtual CPUs are resumed and the domain

[libvirt] [PATCH 4/6] leaseshelper: remove useless comparison

2016-01-19 Thread Ján Tomko
We do not care if the mac was specified in the delete section, we are going to delete the record anyway. Also move the comment about adding ipv6 leases to the ADD case. --- src/network/leaseshelper.c | 34 +++--- 1 file changed, 15 insertions(+), 19 deletions(-) diff

[libvirt] [PATCH 6/6] leaseshelper: reduce indentation level in virLeaseReadCustomLeaseFile

2016-01-19 Thread Ján Tomko
Instead of nested ifs, jump out early. Mostly whitespace changes. --- src/network/leaseshelper.c | 120 +++-- 1 file changed, 62 insertions(+), 58 deletions(-) diff --git a/src/network/leaseshelper.c b/src/network/leaseshelper.c index 547e1d8..57e66e9

[libvirt] [PATCH 3/6] leaseshelper: split out virLeasePrintLeases

2016-01-19 Thread Ján Tomko
Introduce a function for printing the leases on the 'init' operation. --- src/network/leaseshelper.c | 130 + 1 file changed, 73 insertions(+), 57 deletions(-) diff --git a/src/network/leaseshelper.c b/src/network/leaseshelper.c index 8bf1c01..94686ee

[libvirt] [PATCH 0/6] Refactor leaseshelper

2016-01-19 Thread Ján Tomko
Split out some functions to make main() more readable. May depend on https://www.redhat.com/archives/libvir-list/2016-January/msg00595.html No functional change intented. Ján Tomko (6): leaseshelper: store server_duid as an allocated string leaseshelper: split out custom leases file read

[libvirt] [PATCH 5/6] leaseshelper: split out virLeaseNewFromArgv

2016-01-19 Thread Ján Tomko
For the actions ADD and OLD, split out creating the new lease object, along with processing all the program args and environment variables that are only needed in this case. --- src/network/leaseshelper.c | 156 ++--- 1 file changed, 91 insertions(+), 65

[libvirt] [PATCH 1/6] leaseshelper: store server_duid as an allocated string

2016-01-19 Thread Ján Tomko
We either use the value from the environment variable, or learn it from the existing lease file. In the second case, the pointer would be pointing into the JSON object of the first lease with a DUID, owned by leases_array, then leases_array_new. Always allocate the string instead, making obvious

[libvirt] [PATCH 2/6] leaseshelper: split out custom leases file read

2016-01-19 Thread Ján Tomko
Introduce virLeaseReadCustomLeaseFile which will populate the new leases array with all the leases, except for expired ones and the ones matching 'ip_to_delete'. This removes five variables from main(). --- src/network/leaseshelper.c | 194 + 1 file

Re: [libvirt] Failed to terminate process 1275 with SIGTERM: Device or resource busy

2016-01-19 Thread Kashyap Chamarthy
On Mon, Jan 18, 2016 at 04:19:58PM +, Richard W.M. Jones wrote: > On Mon, Jan 18, 2016 at 03:33:25PM +, Richard W.M. Jones wrote: > > I tried another workaround which was to get virt-resize to fsync the > > output file before closing the libvirt connection, but that doesn't > > work for

Re: [libvirt] [PATCH 02/16] Add public APIs for post-copy migration

2016-01-19 Thread Jiri Denemark
On Tue, Jan 19, 2016 at 10:23:40 +, Daniel P. Berrange wrote: > On Tue, Jan 19, 2016 at 10:50:07AM +0100, Jiri Denemark wrote: > > From: Cristian Klein > > > > To use post-copy one has to start the migration with > > VIR_MIGRATE_POSTCOPY flag and

Re: [libvirt] [PATCH LIBVIRT] libxl: Support cmdline= in xl config files

2016-01-19 Thread Ian Campbell
I went to ping this but noticed that I had sent it to "jimfehlig" (i.e. no domain), so no wonder there was no reply! To: line fixed here, let me know if you would prefer a resend. Ian. On Wed, 2015-12-16 at 12:09 +, Ian Campbell wrote: > ... and consolidate the cmdline/extra/root parsing to

[libvirt] parsing url with percent sign when user want to use iso disk via http

2016-01-19 Thread Vasiliy Tolstov
I found a strange thing, when i specify url for iso in libvirt xml like: qemu gets invalid url in cmdline i think that problem is qemu/qemu_command.c:3430:ret = virURIFormat(uri); test string looks like https://alukardd.org/data/test?t=1 qemu gets url with percent urlencoded %3F ,

Re: [libvirt] [Libguestfs] [PATCH libguestfs v3] lib: Handle slow USB devices more gracefully.

2016-01-19 Thread Richard W.M. Jones
On Tue, Jan 19, 2016 at 05:00:27PM +, Daniel P. Berrange wrote: > On Tue, Jan 19, 2016 at 04:18:46PM +, Richard W.M. Jones wrote: > > Libvirt has a fixed 15 second timeout for qemu to exit. If qemu is > > writing to a slow USB key, it can hang (in D state) for much longer > > than this -

Re: [libvirt] [Libguestfs] [PATCH libguestfs v3] lib: Handle slow USB devices more gracefully.

2016-01-19 Thread Richard W.M. Jones
On Tue, Jan 19, 2016 at 05:57:17PM +, Richard W.M. Jones wrote: > But I think I should test `check_for_errors' instead, since that flag > basically means did we come from the guestfs_shutdown method -- where > we want to be careful about data integrity -- or did we come from the >

Re: [libvirt] [PATCH 34/34] qemu: iothread: Reuse qemuProcessSetupIOThread in iothread hotplug

2016-01-19 Thread John Ferlan
On 01/14/2016 11:27 AM, Peter Krempa wrote: > Since majority of the steps is shared, the function can be reused to > simplify code. > > Similarly to previous path doing this same for vCPUs this also fixes the > a similar bug (which is not tracked). > --- > src/qemu/qemu_driver.c | 101 >

Re: [libvirt] [PATCH 0/2] Fix problem generating partition names for multipath device

2016-01-19 Thread John Ferlan
On 01/15/2016 10:06 AM, Michal Privoznik wrote: > On 08.01.2016 18:09, John Ferlan wrote: >> Originally posted as an RFC: >> >> http://www.redhat.com/archives/libvir-list/2015-December/msg00200.html > > It hasn't gotten much attention, has it? Sorry. > >> >> I've made further

Re: [libvirt] ARM KVM GICv3 Support

2016-01-19 Thread Eric Blake
On 01/05/2016 05:37 AM, Andrea Bolognani wrote: >> If I misunderstood, how would you like QEMU to report this? > > I'm not 100% sure about the best interface here (hopefully other people > can weigh in) but I imagine there would be some sort of QMP command that > lists the GIC versions supported

Re: [libvirt] [Xen-devel] [PATCH LIBVIRT] libxl: Support cmdline= in xl config files

2016-01-19 Thread Jim Fehlig
On 01/19/2016 05:03 AM, Ian Campbell wrote: > I went to ping this but noticed that I had sent it to "jimfehlig" (i.e. no > domain), so no wonder there was no reply! > > To: line fixed here, let me know if you would prefer a resend. That would be much appreciated, thanks! > > Ian. > > On Wed,

Re: [libvirt] [PATCH 09/34] virsh: cpu-stats: Remove unneeded flags

2016-01-19 Thread Pavel Hrdina
On Thu, Jan 14, 2016 at 05:26:57PM +0100, Peter Krempa wrote: > virDomainGetCPUStats doesn't support flags so there's no need to carry > the 'flags' variable around. Additionally since the API is poorly > designed I doubt that it will be extended. > --- > tools/virsh-domain.c | 11 +-- >

Re: [libvirt] Failed to terminate process 1275 with SIGTERM: Device or resource busy

2016-01-19 Thread Richard W.M. Jones
On Tue, Jan 19, 2016 at 12:31:48PM +0100, Kashyap Chamarthy wrote: > On Mon, Jan 18, 2016 at 04:19:58PM +, Richard W.M. Jones wrote: > > On Mon, Jan 18, 2016 at 03:33:25PM +, Richard W.M. Jones wrote: > > > I tried another workaround which was to get virt-resize to fsync the > > > output

Re: [libvirt] Failed to terminate process 1275 with SIGTERM: Device or resource busy

2016-01-19 Thread Daniel P. Berrange
On Tue, Jan 19, 2016 at 01:39:41PM +, Richard W.M. Jones wrote: > On Tue, Jan 19, 2016 at 12:31:48PM +0100, Kashyap Chamarthy wrote: > > On Mon, Jan 18, 2016 at 04:19:58PM +, Richard W.M. Jones wrote: > > > On Mon, Jan 18, 2016 at 03:33:25PM +, Richard W.M. Jones wrote: > > > > I tried

Re: [libvirt] Failed to terminate process 1275 with SIGTERM: Device or resource busy

2016-01-19 Thread Richard W.M. Jones
On Tue, Jan 19, 2016 at 01:43:58PM +, Daniel P. Berrange wrote: > I don't think it does. Passing GRACEFUL flag means libvirt will try > /less/ hard to kill QEMU, so it is /more/ likely that you will get > the > > "Failed to terminate process 1275 with SIGTERM: Device or resource busy" > >

Re: [libvirt] Failed to terminate process 1275 with SIGTERM: Device or resource busy

2016-01-19 Thread Daniel P. Berrange
On Tue, Jan 19, 2016 at 01:48:10PM +, Richard W.M. Jones wrote: > On Tue, Jan 19, 2016 at 01:43:58PM +, Daniel P. Berrange wrote: > > I don't think it does. Passing GRACEFUL flag means libvirt will try > > /less/ hard to kill QEMU, so it is /more/ likely that you will get > > the > > > >

Re: [libvirt] Failed to terminate process 1275 with SIGTERM: Device or resource busy

2016-01-19 Thread Kashyap Chamarthy
On Tue, Jan 19, 2016 at 01:39:41PM +, Richard W.M. Jones wrote: [...] > The problem with this theory is we are passing the > VIR_DOMAIN_DESTROY_GRACEFUL flag, so that would indicate that this > flag is buggy. > > I think what we need is a test case, so here goes. Note you must run > these

[libvirt] [PATCH 5/7] hostdev: Use common detach code in virHostdevPCINodeDeviceDetach()

2016-01-19 Thread Andrea Bolognani
This ensures the behavior for detach is consistent, no matter how it was triggered (eg. 'virsh nodedev-detach', 'virsh attach-device' or startup of a domain that is configured to use hostdevs). --- src/util/virhostdev.c | 31 ++- 1 file changed, 26 insertions(+), 5

[libvirt] [PATCH 7/7] pci: Add debug messages when unbinding from stub driver

2016-01-19 Thread Andrea Bolognani
Unbinding a PCI device from the stub driver can require several steps, and it can be useful for debugging to be able to trace which of these steps are performed and which are skipped for each device. --- src/util/virpci.c | 22 ++ 1 file changed, 18 insertions(+), 4

[libvirt] [PATCH 2/7] hostdev: Use common reattach code to rollback prepare errors

2016-01-19 Thread Andrea Bolognani
--- src/util/virhostdev.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c index 0f258a5..267aa55 100644 --- a/src/util/virhostdev.c +++ b/src/util/virhostdev.c @@ -795,23 +795,7 @@

[libvirt] [PATCH 1/7] hostdev: Add reattachPCIDevices()

2016-01-19 Thread Andrea Bolognani
This function replaces virHostdevReattachPCIDevice() and handles several PCI devices instead of requiring to be called once for every device. The handling of active and inactive devices is updated and made more explicit, which means virHostdevReAttachPCIDevices() has to be updated as well. ---

[libvirt] [PATCH 4/7] hostdev: Add detachPCIDevices()

2016-01-19 Thread Andrea Bolognani
This function mirrors reattachPCIDevices(). The handling of active and inactive devices is updated and made more explicit, which means virHostdevPreparePCIDevices() has to be updated as well. --- src/util/virhostdev.c | 125 ++ 1 file changed, 76

[libvirt] [PATCH 3/7] hostdev: Use common reattach code in virHostdevPCINodeDeviceReAttach()

2016-01-19 Thread Andrea Bolognani
This ensures the behavior for reattach is consistent, no matter how it was triggered (eg. 'virsh nodedev-reattach', 'virsh detach-device' or shutdown of a domain that is configured to use hostdevs). --- src/util/virhostdev.c | 45 +++-- 1 file changed, 39

[libvirt] [PATCH 0/7] PCI hostdev refactoring

2016-01-19 Thread Andrea Bolognani
This series is part of my ongoing quest to fix Bug 1272300[1]. I had previously posted a mostly complete solution[2], which did however fail to handle devices detached / reattached using virsh's nodedev-* commands. Part of that series has already been merged. This series refactors the PCI

[libvirt] [PATCH 6/7] pci: Phase out virPCIDeviceReattachInit()

2016-01-19 Thread Andrea Bolognani
The name is confusing, and the only use left is in a test case. --- src/libvirt_private.syms | 1 - src/util/virpci.c| 8 src/util/virpci.h| 1 - tests/virpcitest.c | 5 - 4 files changed, 4 insertions(+), 11 deletions(-) diff --git a/src/libvirt_private.syms

Re: [libvirt] [PATCH 04/34] qemu: don't iterate vcpus using priv->nvcpupids in qemuProcessSetSchedParams

2016-01-19 Thread John Ferlan
On 01/15/2016 01:50 PM, John Ferlan wrote: > > > On 01/14/2016 11:26 AM, Peter Krempa wrote: >> This should be the last offender. >> --- >> src/qemu/qemu_process.c | 8 ++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/src/qemu/qemu_process.c

Re: [libvirt] Failed to terminate process 1275 with SIGTERM: Device or resource busy

2016-01-19 Thread Richard W.M. Jones
On Tue, Jan 19, 2016 at 03:39:22PM +0100, Kashyap Chamarthy wrote: > Upstream OpenStack Nova employs a similar suggestion (calling the > virDomainDestroy() API about 3 more times) proposed by Dan in this > thread: > > http://git.openstack.org/cgit/openstack/nova/commit/?id=3907867 -- >

[libvirt] [PATCH libguestfs v3] lib: Handle slow USB devices more gracefully.

2016-01-19 Thread Richard W.M. Jones
Libvirt has a fixed 15 second timeout for qemu to exit. If qemu is writing to a slow USB key, it can hang (in D state) for much longer than this - many minutes usually. The solution is to check specifically for the libvirt EBUSY error when this happens, and retry the virDomainDestroyFlags

Re: [libvirt] ARM KVM GICv3 Support

2016-01-19 Thread Andrew Jones
On Tue, Jan 12, 2016 at 04:48:27PM +0100, Andrea Bolognani wrote: > Would providing a QMP command that returns the list of GIC versions > available on the current host for the current machine type be > acceptable from QEMU's point of view? > Adding qemu-devel. Peter any opinion on this? If it

Re: [libvirt] ARM KVM GICv3 Support

2016-01-19 Thread Peter Maydell
On 19 January 2016 at 16:46, Andrew Jones wrote: > On Tue, Jan 12, 2016 at 04:48:27PM +0100, Andrea Bolognani wrote: >> Would providing a QMP command that returns the list of GIC versions >> available on the current host for the current machine type be >> acceptable from

Re: [libvirt] [Libguestfs] [PATCH libguestfs v3] lib: Handle slow USB devices more gracefully.

2016-01-19 Thread Daniel P. Berrange
On Tue, Jan 19, 2016 at 04:18:46PM +, Richard W.M. Jones wrote: > Libvirt has a fixed 15 second timeout for qemu to exit. If qemu is > writing to a slow USB key, it can hang (in D state) for much longer > than this - many minutes usually. > > The solution is to check specifically for the

Re: [libvirt] [PATCH 31/34] qemu: vcpu: Aggregate code to set vCPU tuning

2016-01-19 Thread John Ferlan
On 01/14/2016 11:27 AM, Peter Krempa wrote: > Rather than iterating 3 times for various settings this function > aggregates all the code into single place. One of the other advantages > is that it can then be reused for properly setting vCPU info on hotplug. > --- > src/qemu/qemu_cgroup.c |

Re: [libvirt] [PATCH 32/34] qemu: vcpu: Reuse qemuProcessSetupVcpu in vcpu hotplug

2016-01-19 Thread John Ferlan
On 01/14/2016 11:27 AM, Peter Krempa wrote: > Since majority of the steps is shared, the function can be reused to > simplify code. > > Additionally this resolves > https://bugzilla.redhat.com/show_bug.cgi?id=1244128 since the cpu > bandwidth limiting with cgroups would not be set on the

Re: [libvirt] [PATCH 33/34] qemu: iothread: Aggregate code to set IOTrhead tuning

2016-01-19 Thread John Ferlan
On 01/14/2016 11:27 AM, Peter Krempa wrote: > Rather than iterating 3 times for various settings this function > aggregates all the code into single place. One of the other advantages > is that it can then be reused for properly setting IOThread info on > hotplug. > --- > src/qemu/qemu_cgroup.c

Re: [libvirt] [Qemu-devel] ARM KVM GICv3 Support

2016-01-19 Thread Laszlo Ersek
On 01/19/16 17:53, Peter Maydell wrote: > On 19 January 2016 at 16:46, Andrew Jones wrote: >> On Tue, Jan 12, 2016 at 04:48:27PM +0100, Andrea Bolognani wrote: >>> Would providing a QMP command that returns the list of GIC versions >>> available on the current host for the