The affected functions are:
virPCIDeviceGetManaged()
virPCIDeviceGetUnbindFromStub()
virPCIDeviceGetRemoveSlot()
virPCIDeviceGetReprobe()
Change their return type from unsigned int to bool: the corresponding
members in struct _virPCIDevice are defined as bool, and even the
corresponding v
By opening a RBD volume in Read-Only we do not register a
watcher on the header object inside the Ceph cluster.
Refreshing a volume only calls rbd_stat() which is a operation
which does not write to a RBD image.
This allows us to use a cephx user which has no write
permissions if we would want to
On Tue, 2016-01-26 at 18:59 -0500, John Ferlan wrote:
>
> On 01/25/2016 11:21 AM, Andrea Bolognani wrote:
> > The name is confusing, and the only use left is in a test case.
> > ---
> > src/libvirt_private.syms | 1 -
> > src/util/virpci.c| 8
> > src/util/virpci.h| 1 -
>
On Wed, Jan 27, 2016 at 12:06:22PM +0100, Michal Privoznik wrote:
> On 27.01.2016 11:56, Stefan Hajnoczi wrote:
> > On Tue, Jan 26, 2016 at 11:13:16AM +0100, Michal Privoznik wrote:
> >> On 25.01.2016 18:28, Stefan Hajnoczi wrote:
> >>> The QEMU wiki page for Google Summer of Code 2016 is now avail
On Tue, 2016-01-26 at 19:00 -0500, John Ferlan wrote:
>
> > -VIR_DEBUG("Found stub driver %s", driver);
> > +VIR_DEBUG("Found stub driver %s for PCI device %s", driver, dev->name);
> > +VIR_DEBUG("Unbinding PCI device %s", dev->name);
>
> Redundant - How about "Found stub driver %s t
On Wed, Jan 27, 2016 at 03:26:12PM -0500, John Ferlan wrote:
> ...
> >>
> >> However, after some more "investigation" of the environment - I think
> >> perhaps there's still a couple of loose ends. Keeping the 'segtype'
> >> field may be necessary/useful... Details follow if interested ;-)
> >
> >
The error paths after fix suppose ret == -1 as at the
beginning of the function.
The better fix would be not to touch 'ret' at all until
the end of the function where it is set to 0. Thus we'd
better introduce some 'rc' variable to hold return
values of called functions.
---
src/qemu/qemu_driver.
On Thu, Jan 28, 2016 at 15:49:48 +0300, Nikolay Shirokovskiy wrote:
> The error paths after fix suppose ret == -1 as at the
> beginning of the function.
>
> The better fix would be not to touch 'ret' at all until
> the end of the function where it is set to 0. Thus we'd
> better introduce some 'rc
On 01/27/2016 12:26 PM, Andrea Bolognani wrote:
> On Tue, 2016-01-26 at 18:55 -0500, John Ferlan wrote:
>>
>> w/r/t: your [0/7] from initial series...
>>
>> As much as you don't want to keep living Groundhog Day - resolution of
>> bugs like this are job security :-)...
>
> Groundhog Day is i
On 28.01.2016 16:27, Jiri Denemark wrote:
> On Thu, Jan 28, 2016 at 15:49:48 +0300, Nikolay Shirokovskiy wrote:
>> The error paths after fix suppose ret == -1 as at the
>> beginning of the function.
>>
>> The better fix would be not to touch 'ret' at all until
>> the end of the function where it
On 01/27/2016 12:39 PM, Andrea Bolognani wrote:
> On Tue, 2016-01-26 at 18:56 -0500, John Ferlan wrote:
>>> +/**
>>> + * virHostdevPCINodeDeviceReAttach:
>>
>> ^^ Oy ReAttach vs. Reattach is an eye test ;-)
>
> Maybe we should standardize on either one or the other? I personally
> consider "Re
On Sat, Jan 16, 2016 at 10:22:13 -0500, John Ferlan wrote:
>
>
> On 01/14/2016 11:26 AM, Peter Krempa wrote:
> > Iterate over all cpus skipping inactive ones.
> > ---
> > src/qemu/qemu_driver.c | 15 ---
> > 1 file changed, 12 insertions(+), 3 deletions(-)
> >
>
> Patch 7 introduce
In our generator for some code we put empty lines in the output
to separate some blocks of code. However, in some cases we put
couple of spaces on the empty line too. It's not bug, it just
isn't nice.
Signed-off-by: Michal Privoznik
---
src/rpc/gendispatch.pl | 2 +-
1 file changed, 1 insertion(
On Thu, Jan 28, 2016 at 15:23:56 +0100, Michal Privoznik wrote:
> In our generator for some code we put empty lines in the output
> to separate some blocks of code. However, in some cases we put
> couple of spaces on the empty line too. It's not bug, it just
> isn't nice.
Too many "some" :-)
>
>
Ping
On 01/27/2016 07:17 PM, Alexander Burluka wrote:
This patchset implements an ability to specify values for domain top level
cpu.cfs_period_us and cpu.cfs_quota_us cgroups. These parameters are opt-in
and named "global_period" and "global_quota".
Introduction of these settings gives managem
Signed-off-by: Vasiliy Tolstov
---
src/libvirt-php.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/libvirt-php.c b/src/libvirt-php.c
index f3b3f9f81e6d..a0c960957edc 100644
--- a/src/libvirt-php.c
+++ b/src/libvirt-php.c
@@ -1238,6 +1238,8 @@ PHP_MINIT_FUNCTION(l
On Thu, Dec 10, 2015 at 08:34:31PM +0800, Qiaowei Ren wrote:
> API agreed on in
> https://www.redhat.com/archives/libvir-list/2015-October/msg00872.html
>
> * include/libvirt/libvirt-domain.h (virDomainGetPerfEvents,
> virDomainSetPerfEvents): New declarations.
> * src/libvirt_public.syms: Export
On Thu, Dec 10, 2015 at 08:34:33PM +0800, Qiaowei Ren wrote:
> This patch implement a set of interfaces for perf event. Based on
> these interfaces, we can implement internal driver API for perf,
> and get the results of perf conuter you care about.
>
> Signed-off-by: Qiaowei Ren
> ---
> include
On Thu, Dec 10, 2015 at 08:34:34PM +0800, Qiaowei Ren wrote:
> This patch implement the internal driver API for perf event into
> qemu driver.
>
> Signed-off-by: Qiaowei Ren
> ---
> include/libvirt/libvirt-domain.h | 1 +
> src/qemu/qemu_domain.h | 3 +
> src/qemu/qemu_driver.c
On Thu, Dec 10, 2015 at 08:34:32PM +0800, Qiaowei Ren wrote:
> Add remote support for perf event.
>
> Signed-off-by: Qiaowei Ren
> ---
> daemon/remote.c | 47
>
> src/remote/remote_driver.c | 39
>
On Thu, Dec 10, 2015 at 08:34:35PM +0800, Qiaowei Ren wrote:
> This patch adds new xml element, and so we can have the option of
> also having perf events enabled immediately at startup.
>
> Signed-off-by: Qiaowei Ren
> ---
> docs/schemas/domaincommon.rng | 27 +++
> src/con
On Thu, Dec 10, 2015 at 08:34:36PM +0800, Qiaowei Ren wrote:
> When libvirtd daemon restart, this patch will reenable those perf
> events previously enabled.
>
> Signed-off-by: Qiaowei Ren
> ---
> src/qemu/qemu_driver.c | 36
> 1 file changed, 36 insertions(+
On 01/28/2016 08:57 AM, Peter Krempa wrote:
> On Sat, Jan 16, 2016 at 10:22:13 -0500, John Ferlan wrote:
>>
>>
>> On 01/14/2016 11:26 AM, Peter Krempa wrote:
>>> Iterate over all cpus skipping inactive ones.
>>> ---
>>> src/qemu/qemu_driver.c | 15 ---
>>> 1 file changed, 12 insertio
On Thu, Dec 10, 2015 at 08:34:37PM +0800, Qiaowei Ren wrote:
> This patch add new perf command to enable/disable perf event
> for a guest domain.
>
> Signed-off-by: Qiaowei Ren
> ---
> tools/virsh-domain.c | 128
> +++
> tools/virsh.pod | 20
On Thu, Dec 10, 2015 at 08:34:38PM +0800, Qiaowei Ren wrote:
> This patch extend domstats command to match extended
> virDomainListGetStats API in previous patch.
>
> Signed-off-by: Qiaowei Ren
> ---
> tools/virsh-domain-monitor.c | 7 +++
> tools/virsh.pod | 7 +--
> 2 file
Add API to read and write PCI hostdev nodes.
---
libvirt-gconfig/Makefile.am| 2 +
.../libvirt-gconfig-domain-hostdev-pci.c | 211 +
.../libvirt-gconfig-domain-hostdev-pci.h | 80
libvirt-gconfig/libvirt-gconfig-domain-hos
---
tests/test-gconfig.c| 30 +
tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 +
2 files changed, 41 insertions(+)
create mode 100644 tests/xml/gconfig-domain-device-pci-hostdev.xml
diff --git a/tests/test-gconfig.c b/tests/test-
Add API to read and write domain/devices/hostdev nodes. This patch only
adds the baseclass and hence is not useful on it's own. A more specific
subclass to represent PCI devices will be added in a following patch.
---
libvirt-gconfig/Makefile.am| 2 +
.../libvirt-gconfig-
In commit 7039bb3c we have removed code that saves uuid to vzDomObj.uuid
So this field is no longer needed.
---
src/vz/vz_sdk.c | 5 -
src/vz/vz_utils.h | 1 -
2 files changed, 6 deletions(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index 8181149..40ab2d9 100644
--- a/src/vz/vz_sdk.c
Patches 1 and 2 make preparation for patch 4
Patch 3 fixes notification subscription
To get domain info we should receive and handle notification from hypervisor
Patch 4 fixes race condition when adding domain to domains list
Race condition:
User calls defineXML to create new instance.
The main t
Bug cause:
Update the domain that is subscribed to hypervisor notification.
LoadDomain() rewrites notifications fields in vzDomObj structure and makes
domain as "unsubscribed".
Fix:
Initialize notification fields in vzDomObj only if we create a new domain.
And do not reinitialize these fields if w
Race condition:
User calls defineXML to create new instance.
The main thread from vzDomainDefineXMLFlags() creates new instance by
prlsdkCreateVm.
Then this thread calls prlsdkAddDomain to add new domain to domains list.
The second thread receives notification from hypervisor that new VM was creat
prlsdkGetDomainIds() returns name and uuid for specified instance.
Now output arguments can be NULL.
It allows to get only necessary info(name or uuid).
---
src/vz/vz_sdk.c | 34 +++---
1 file changed, 19 insertions(+), 15 deletions(-)
diff --git a/src/vz/vz_sdk.c b/sr
ignore this patch
I include it into patch series.
26.01.2016 15:16, Mikhail Feoktistov пишет:
In commit 7039bb3c we have removed code that saves uuid to vzDomObj.uuid
So this field is no longer needed.
---
src/vz/vz_sdk.c | 5 -
src/vz/vz_utils.h | 1 -
2 files changed, 6 deletions(-)
On 01/28/2016 03:21 AM, Andrea Bolognani wrote:
> The affected functions are:
>
> virPCIDeviceGetManaged()
> virPCIDeviceGetUnbindFromStub()
> virPCIDeviceGetRemoveSlot()
> virPCIDeviceGetReprobe()
>
> Change their return type from unsigned int to bool: the corresponding
> members in st
On 01/28/2016 06:30 AM, Pavel Hrdina wrote:
> On Wed, Jan 27, 2016 at 03:26:12PM -0500, John Ferlan wrote:
>> ...
However, after some more "investigation" of the environment - I think
perhaps there's still a couple of loose ends. Keeping the 'segtype'
field may be necessary/us
On Thu, 2016-01-28 at 10:35 -0500, John Ferlan wrote:
>
> On 01/28/2016 03:21 AM, Andrea Bolognani wrote:
> > The affected functions are:
> >
> > virPCIDeviceGetManaged()
> > virPCIDeviceGetUnbindFromStub()
> > virPCIDeviceGetRemoveSlot()
> > virPCIDeviceGetReprobe()
> >
> > Change their
---
src/qemu/qemu_command.c | 16 +---
src/qemu/qemu_command.h | 11 ---
src/qemu/qemu_process.h | 2 --
3 files changed, 13 insertions(+), 16 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 5d3ab3a..8943270 100644
--- a/src/qemu/qemu_command
This allows individual driver tests to hook in their own code before
the def is formatted and compared.
We will eventually use this in the qemuxml2xml
---
tests/bhyvexml2xmltest.c | 3 ++-
tests/genericxml2xmltest.c | 3 ++-
tests/lxcxml2xmltest.c | 3 ++-
tests/qemuxml2xmltest.c| 6 +++
Similar to how we do it for qemuxml2argvtest. This will be used in future
patches.
---
tests/qemuxml2xmltest.c | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index 2400538..0134815 100644
--- a/tes
When we unconditionally enable QEMU_CAPS_DEVICE, these tests need
some massaging, so do it ahead of time to not mix it in with the
big test refresh.
- minimal-s390 is not a real world working config, so drop it
- disk-usb was testing for an old code path that will be removed.
instead use it to t
Clarify the point of some of the test cases by renaming them. Add more
xml2xml tests.
---
...> qemuxml2argv-aarch64-virtio-pci-default.args} | 0
...=> qemuxml2argv-aarch64-virtio-pci-default.xml} | 0
...2argv-aarch64-virtio-pci-manual-addresses.args} | 0
...l2argv-aarch64-virtio-pci-manual-a
To get properly wrapped output
---
tests/testutils.c | 38 +++---
1 file changed, 31 insertions(+), 7 deletions(-)
diff --git a/tests/testutils.c b/tests/testutils.c
index b587f83..10c26648 100644
--- a/tests/testutils.c
+++ b/tests/testutils.c
@@ -433,6 +433,32 @@
Okay, my recent patch series' are kinda all over the place. I'm tableing
the src/qemu/ QEMU_CAPS_DEVICE bits for now. This is just the test
suite changes, which I need as a basis for other patches anyways.
This series does two main things: it conditionally enables QEMU_CAPS_DEVICE
in the test suit
On 01/22/2016 02:30 PM, Cole Robinson wrote:
> This is the second series dropping QEMU_CAPS_DEVICE. It handles
> qemu_command.c and all remaining uses of QEMU_CAPS_DEVICE.
>
> Every qemu binary after v0.12.1 has the -device option, but many
> platforms cannot actually use it, because they are base
If a user manually specifies this XML snippet for aarch64 machvirt:
Libvirt will interpret this to mean that the OS supports virtio-pci,
and will allocate PCI addresses (instead of virtio-mmio) for virtio
devices.
This is a giant hack. Trying to improve it led me into the maze of PCI
address
This was discussed here:
https://www.redhat.com/archives/libvir-list/2015-December/msg00217.html
The summary is that apps/users are in a tough spot WRT aarch64 -M virt
and PCIe support: qemu has all the plumbing, but most distros don't
support it yet. Presently libvirt adds a PCIe controller to t
These patches apply on top of the series I just posted:
[PATCH 0/9] tests: qemu: unconditionally enable QEMU_CAPS_DEVICE
https://www.redhat.com/archives/libvir-list/2016-January/msg01233.html
These specific changers were discussed here:
https://www.redhat.com/archives/libvir-list/2015-Decemb
On 01/26/2016 11:44 AM, Laine Stump wrote:
> On 01/22/2016 02:11 PM, Cole Robinson wrote:
>> On 01/22/2016 02:09 PM, Cole Robinson wrote:
>>> Nowadays we only support qemu 0.12.0+ which provides QEMU_CAPS_DEVICE,
>>> so this is all dead code.
>>> ---
>>> src/qemu/qemu_hotplug.c | 480
>>>
On 01/22/2016 02:09 PM, Cole Robinson wrote:
> libvirt only supports qemu 0.12.0+ nowadays, which means that the
> qemu binary always provides the -device/QEMU_CAPS_DEVICE option. This
> patch series is a step towards dropping support for that flag.
>
> Patch #1 is a test suite improvement, not st
Amongst many other changes, commit id '82c1740a' added a display of the
lvs -o 'stripes' field in order to be able to determine the number of
extents listed in the 'devices' output. This was then used to generate
a regex in order to parse the devices string. As part of the generation
of that regex
v1: http://www.redhat.com/archives/libvir-list/2016-January/msg01023.html
Differences to v1:
Patch 1 is the former patch 2 with the following adjuments:
- Change helper name to be virStorageBackendLogicalParseVolExtents
- Include all 'extent' parsing needs - including fetch/parse of 'stripes'
Since a future patch will start displaying thin logical volumes for a
logical volume group thin-pool, add the ability to display at the name of
the thin-pool name. This is done by adding 'pool_lv' to the list of
regex's and then when a "thin" lv is found, storing that pool name.
The result will en
Modify the regex for the 'devices' (a/k/a 'extents') from "(\\S+)"
(e.g., 1 or more) to "(\\S*)" (e.g., zero or more).
Since a "thin" segtype has no devices, this will result in any "thin" lv
part of some thin-pool within a volume group used as a libvirt pool to be
displayed as a possible volume t
For any "thin" lv's, mark the volume as a sparse volume so that the
volume wipe algorithm doesn't work. Currently thin lv's are ignored
because the regex requires 1 or more 'devices' listed in order to
process. However, a future patch will be changing this.
Signed-off-by: John Ferlan
---
src/st
A thin lv doesn't have any extents defined - rather it uses a concept of
a "thin-pool" in order to describe it's source. In order to allow that to
be displayed properly in a future patch, add a new 'thin_pool' name that
can be used by a future patch to store the name of the source thin_pool
name us
Create a helper routine in order to parse any extents information
including the extent size, length, and the device string contained
within the generated 'lvs' output string.
A future patch would then be able to avoid the code more cleanly
Signed-off-by: John Ferlan
---
src/storage/storage_back
On 28.01.2016 18:38, Mikhail Feoktistov wrote:
> prlsdkGetDomainIds() returns name and uuid for specified instance.
> Now output arguments can be NULL.
> It allows to get only necessary info(name or uuid).
> ---
> src/vz/vz_sdk.c | 34 +++---
> 1 file changed, 19 inse
On 28.01.2016 18:38, Mikhail Feoktistov wrote:
> In commit 7039bb3c we have removed code that saves uuid to vzDomObj.uuid
> So this field is no longer needed.
> ---
> src/vz/vz_sdk.c | 5 -
> src/vz/vz_utils.h | 1 -
> 2 files changed, 6 deletions(-)
>
> diff --git a/src/vz/vz_sdk.c b/src
The nodeinfo output was fixed earlier to reflect the actual cpus available in
KVM mode on PPC64. The earlier fixes covered the aspect of not making a host
look overcommitted when its not. The current fixes are aimed at helping the
users make better decisions on the kind of guest cpu topology that c
On 28.01.2016 18:38, Mikhail Feoktistov wrote:
> Bug cause:
> Update the domain that is subscribed to hypervisor notification.
> LoadDomain() rewrites notifications fields in vzDomObj structure and makes
> domain as "unsubscribed".
> Fix:
> Initialize notification fields in vzDomObj only if we c
Today, the topology displayed by nodeinfo/capabilities is reflecting the host
topology irrespective the subcore_per_core setting.
This is not of much use as user cannot determine what is the maximum
possible threads_per_core value he can use for a guest topology.
For subcore_per_core = 1, the gues
The cpus tag in NUMA cell today explains core's id, socket id and the
siblings list. The sibling list is used by users to pin the vcpus of a guest
from the same guest-core to threads from the same host-core. The host
topology gives a hint of how many max siblings one might expect in the
siblings li
> -Original Message-
> From: Daniel P. Berrange [mailto:berra...@redhat.com]
> Sent: Thursday, January 28, 2016 11:21 PM
> To: Ren, Qiaowei
> Cc: libvir-list@redhat.com; Jiri Denemark
> Subject: Re: [PATCH 6/8] perf: reenable perf events when libvirtd restart
>
> On Thu, Dec 10, 2015 at
64 matches
Mail list logo
