Re: [libvirt] [PATCH v2 0/7] Fix and enhance statistics of a completed job

On Tue, Mar 01, 2016 at 13:55:26 +0100, Jiri Denemark wrote: > Jiri Denemark (7): > qemu: Store completed stats at the very end of migration > qemu: Properly update completed migration stats > qemu: Don't explicitly stop CPUs after migration > qemu: Fix a race when computing migration

Re: [libvirt] [PATCH v2 3/4] lxc, libxl: reuse virDomainObjUpdateModificationImpact

On 01.03.2016 18:46, John Ferlan wrote: > > > On 02/24/2016 03:38 AM, Nikolay Shirokovskiy wrote: >> First fortunately all versions of *_CURRENT, *_CONFIG and *_LIVE flags >> are numerically equal. Second libxl functions that don't use masks >> for flag expansion forbid extra flags via

[libvirt] after update to libvirt >= 1.2.9.3 no connection to libvirtd (time out) - bug 1308736

Hi all, I've reported https://bugzilla.redhat.com/show_bug.cgi?id=1308736 two weeks ago, including the results of a git bisect. It would be greatly appreciated if someone could take a look, otherwise we can't push an update for CVE-2015-5313 for our stable distribution. Kind regards and thanks

[libvirt] Storage Backend - buildVolFrom Semantics

storage_backend_rbd.c uses an RBD clone operation to implement buildVolFrom. If I'm understanding the RBD documentation correctly, you cannot delete the parent until the clone has been deleted: http://docs.ceph.com/docs/master/dev/rbd-layering/ "Before cloning a snapshot, you must mark it as

[libvirt] Storage Backend Error Handling Consistency

These two blocks exist in different storage backends' createVol implementations: if (vol->target.format != VIR_STORAGE_FILE_RAW) { virReportError(VIR_ERR_NO_SUPPORT, "%s", _("only RAW volumes are supported by this storage pool")); return

[libvirt] [PATCH] ZFS: Support sparse volumes

By default, `zfs create -V ...` reserves space for the entire volsize, plus some extra (which attempts to account for overhead). If `zfs create -s -V ...` is used instead, zvols are (fully) sparse. A middle ground (partial allocation) can be achieved with `zfs create -s -o refreservation=... -V

[libvirt] [PATCH] util: Fix missing initializer for agent

In virPolkitAgentCreate neglected to initialize agent to NULL. If there was an error in the pipe, then we jump to error and would have an issue. Found by coverity. Signed-off-by: John Ferlan --- Pushing as trivial src/util/virpolkit.c | 2 +- 1 file changed, 1

[libvirt] Enhancement: Random Clock Offset

For better system anonymity (to decouple VM OS timestamps leaked in traffic from host ones) a feature can be added to the clock offset variable to select randomly from a specified range of seconds from instead of a fixed number of seconds. That way a guest's clock can vary unpredictably from

[libvirt] Libvirt accepted to GSoC

Dear community, let me announce great news: Libvirt applied for this year's Google Summer of Code and got accepted [1]! You may recall that in previous years we created a joint organisation with QEMU/KVM folks and participated that way. However, since the number of libvirt students was growing

Re: [libvirt] [PATCH] Libvirt: Add missing default value for config option max_queued_clients

On 29.02.2016 14:33, Jason J. Herne wrote: > Commit 1199edb1d4e3 added config option max_queued_clients and documented the > default value as 1000 but never actually set that value. This patch sets the > default value. > > This addresses an issue whereby the following error message is reported if

[libvirt] [PATCH] datatypes.c: Replace 'close' with 'closeData'

Older compilers fail to see that 'close' is not used a function rather than a variable and produce the following error: cc1: warnings being treated as errors ../../src/datatypes.c: In function 'virConnectCloseCallbackDataReset': ../../src/datatypes.c:149: error: declaration of 'close' shadows a

Re: [libvirt] [PATCH] docs: Clarify interface/target/@dev docs

On Tue, Mar 01, 2016 at 16:07:18 +0100, Martin Kletzander wrote: > On Tue, Mar 01, 2016 at 12:51:53PM +0100, Jiri Denemark wrote: > >https://bugzilla.redhat.com/show_bug.cgi?id=1313314 > > > >Signed-off-by: Jiri Denemark > >--- > > docs/formatdomain.html.in | 4 ++-- > > 1

Re: [libvirt] [PATCH v2 4/4] libxlDomainPinVcpuFlags: remove check duplicates

On 02/24/2016 03:38 AM, Nikolay Shirokovskiy wrote: > virDomainLiveConfigHelperMethod function checks this > condition already. > > Signed-off-by: Nikolay Shirokovskiy > --- > src/libxl/libxl_driver.c | 6 -- > 1 file changed, 6 deletions(-) > ACK - I've

Re: [libvirt] [PATCH v2 2/4] libxlDomainSetMemoryFlags : reuse virDomainLiveConfigHelperMethod

$subj: Use the "libxl: ..." prefix please That way someone filtering on libxl patches may pick up on this. I can fix this for this one... On 02/24/2016 03:38 AM, Nikolay Shirokovskiy wrote: > Flag expansion is the same as in virDomainObjUpdateModificationImpact > which

Re: [libvirt] [PATCH v2 3/4] lxc, libxl: reuse virDomainObjUpdateModificationImpact

On 02/24/2016 03:38 AM, Nikolay Shirokovskiy wrote: > First fortunately all versions of *_CURRENT, *_CONFIG and *_LIVE flags > are numerically equal. Second libxl functions that don't use masks > for flag expansion forbid extra flags via virCheckFlags before. > > Signed-off-by: Nikolay

Re: [libvirt] [PATCH v2 1/4] virDomainObjUpdateModificationImpact: reduce nesting

On 02/24/2016 03:38 AM, Nikolay Shirokovskiy wrote: > Signed-off-by: Nikolay Shirokovskiy > --- > src/conf/domain_conf.c | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) > ACK - I've adjusted the commit message mainly to give some more context

Re: [libvirt] [PATCH v7 0/6] Global domain cpu.cfs_period_us and cpu.cfs_quota_us setup

Good news, thanks a lot! On 03/01/2016 05:41 PM, Daniel P. Berrange wrote: On Sat, Feb 27, 2016 at 01:47:38PM +0300, Alexander Burluka wrote: On 02/26/2016 08:34 PM, Daniel P. Berrange wrote: On Tue, Feb 16, 2016 at 04:43:32PM +0300, Alexander Burluka wrote: This patchset implements an

Re: [libvirt] [PATCH] qemu: Don't always wait for SPICE to finish migration

On Tue, Mar 01, 2016 at 15:42:02 +0100, Pavel Hrdina wrote: > On Mon, Feb 29, 2016 at 01:30:24PM +0100, Jiri Denemark wrote: > > When SPICE graphics is configured for a domain but we did not ask the > > client to switch to the destination, we should not wait for > > SPICE_MIGRATE_COMPLETED event

Re: [libvirt] [PATCH] Fix formatting in remote_protocol-structs

On Tue, Mar 01, 2016 at 15:58:47 +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/remote_protocol-structs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I pushed this patch as a build-breaker. Jirka -- libvir-list mailing list

Re: [libvirt] [PATCH] qemu: Don't try to fetch migration stats on destination

On Tue, Mar 01, 2016 at 15:18:37 +0100, Pavel Hrdina wrote: > On Mon, Feb 29, 2016 at 01:01:54PM +0100, Jiri Denemark wrote: > > Migration statistics are not available on the destination host and > > starting a query job during incoming migration is not allowed. Trying to > > do that would result

Re: [libvirt] [PATCH] util: Fix build without polkit

On Tue, Mar 01, 2016 at 15:58:26 +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/util/virpolkit.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Already pushed as a build-breaker. Jirka -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] qemu: enalbe hotplugging of macvtap device with multiqueue

On 26.02.2016 08:02, Shanzhi Yu wrote: > in commit 81a110, multiqueue for macvtap is enabled but forget > to support hotplugging enabled > > Signed-off-by: Shanzhi Yu > --- > src/qemu/qemu_hotplug.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [libvirt] [PATCH] docs: Clarify interface/target/@dev docs

On Tue, Mar 01, 2016 at 12:51:53PM +0100, Jiri Denemark wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1313314 Signed-off-by: Jiri Denemark --- docs/formatdomain.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in

[libvirt] [PATCH] Use correct LDFLAGS for leaseshelper

Signed-off-by: Jiri Denemark --- src/Makefile.am | 4 1 file changed, 4 insertions(+) diff --git a/src/Makefile.am b/src/Makefile.am index a316b4d..d57d303 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -2810,6 +2810,10 @@ libvirt_iohelper_CFLAGS = \ if

Re: [libvirt] Wiki account

On Tue, Mar 01, 2016 at 03:54:51PM +0100, Christophe Fergeau wrote: > Hey, > > I thought I already had a wiki account, but after a few failures to > login or retrieve a password, it seems I don't, so I would like to get > one for username 'teuf' Created and passwd sent out of band. Regards,

[libvirt] [PATCH] Fix formatting in remote_protocol-structs

Signed-off-by: Jiri Denemark --- src/remote_protocol-structs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs index 11048b7..6c1cf5d 100644 --- a/src/remote_protocol-structs +++

[libvirt] Wiki account

Hey, I thought I already had a wiki account, but after a few failures to login or retrieve a password, it seems I don't, so I would like to get one for username 'teuf' Thanks, Christophe signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] util: Fix build without polkit

Signed-off-by: Jiri Denemark --- src/util/virpolkit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c index 3bb60a5..3d2be61 100644 --- a/src/util/virpolkit.c +++ b/src/util/virpolkit.c @@ -329,13 +329,13 @@

Re: [libvirt] [PATCH] docs: Clarify interface/target/@dev docs

On Tue, Mar 01, 2016 at 12:51:53PM +0100, Jiri Denemark wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1313314 > > Signed-off-by: Jiri Denemark > --- > docs/formatdomain.html.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) ACK Pavel -- libvir-list

Re: [libvirt] [PATCH v7 0/6] Global domain cpu.cfs_period_us and cpu.cfs_quota_us setup

On Sat, Feb 27, 2016 at 01:47:38PM +0300, Alexander Burluka wrote: > > > On 02/26/2016 08:34 PM, Daniel P. Berrange wrote: > >On Tue, Feb 16, 2016 at 04:43:32PM +0300, Alexander Burluka wrote: > >>This patchset implements an ability to specify values for domain top level > >>cpu.cfs_period_us

Re: [libvirt] [PATCH] qemu: Don't always wait for SPICE to finish migration

On Mon, Feb 29, 2016 at 01:30:24PM +0100, Jiri Denemark wrote: > When SPICE graphics is configured for a domain but we did not ask the > client to switch to the destination, we should not wait for > SPICE_MIGRATE_COMPLETED event (which will never come). > >

Re: [libvirt] [RFC] [libvirt-gconfig] Suggestion about (maybe) re-factoring GVirtConfigDomainGraphics

Hey, On Mon, Feb 29, 2016 at 11:51:26PM +0100, Fabiano Fidêncio wrote: > Howdy! > > I've been trying to use libvirt-gobject and libvirt-gconfig, on > virt-viewer, for accessing VMs and looking at their config, instead of > using libvrit and parsing XML directly and turns out, that >

Re: [libvirt] [PATCH v5 0/10] add close callback for drivers with persistent connection

On Fri, Feb 26, 2016 at 05:53:34PM +, Daniel P. Berrange wrote: > On Wed, Feb 17, 2016 at 03:14:53PM +0300, Nikolay Shirokovskiy wrote: > > Currently close callback API can only inform us of closing the connection > > between remote driver and daemon. But what if a driver running in the > >

Re: [libvirt] [PATCH] qemu: Don't try to fetch migration stats on destination

On Mon, Feb 29, 2016 at 01:01:54PM +0100, Jiri Denemark wrote: > Migration statistics are not available on the destination host and > starting a query job during incoming migration is not allowed. Trying to > do that would result in > > Timed out during operation: cannot acquire state change

Re: [libvirt] [PATCHv2 2/3] qemu_cgroup: put qemu right into emulator sub-cgroup

On Tue, Mar 01, 2016 at 12:34:44PM +0100, Peter Krempa wrote: > On Tue, Mar 01, 2016 at 11:20:18 +, Daniel Berrange wrote: > > On Fri, Feb 26, 2016 at 04:34:23PM +0100, Henning Schild wrote: > > > Move qemuProcessSetupEmulator up under qemuSetupCgroup. That way > > > we move the one main

[libvirt] [PATCH v2 2/7] qemu: Properly update completed migration stats

We should not overwrite all migration statistics on the source with the numbers sent by the destination since the source may have an updated view in some cases (such as post-copy migration). It's safer to update just the timing info we need to get from the destination and be prepared for the

[libvirt] [PATCH v2 4/7] qemu: Fix a race when computing migration downtime

Computing a total downtime during a migration requires us to store a time stamp when guest CPUs get stopped. The value (and all other statistics) is then transferred to the destination to compute the downtime. Because the stopped time stamp is stored by a STOP event handler while the statistics

[libvirt] [PATCH v2 3/7] qemu: Don't explicitly stop CPUs after migration

With a very old QEMU which doesn't support events we need to explicitly call qemuMigrationSetOffline at the end of migration to update our internal state. On the other hand, if we talk to QEMU using QMP, we should just wait for the STOP event and let the event handler update the state and trigger

[libvirt] [PATCH v2 1/7] qemu: Store completed stats at the very end of migration

Statistics for a completed migration only make sense if the migration was successful. Let's don't store them in priv->job.completed until we are sure it was a success. Signed-off-by: Jiri Denemark --- Notes: Version 2: - no change src/qemu/qemu_migration.c | 20

[libvirt] [PATCH v2 0/7] Fix and enhance statistics of a completed job

Jiri Denemark (7): qemu: Store completed stats at the very end of migration qemu: Properly update completed migration stats qemu: Don't explicitly stop CPUs after migration qemu: Fix a race when computing migration downtime qemu: Do not report completed stats until the job finishes

[libvirt] [PATCH v2 6/7] Introduce job completed event

The VIR_DOMAIN_EVENT_ID_JOB_COMPLETED event will be triggered once a job (such as migration) finishes and it will contain statistics for the job as one would get by calling virDomainGetJobStats. Thanks to this event it is now possible to get statistics of a completed migration of a transient

[libvirt] [PATCH v2 7/7] qemu: Add support for job completed event

Signed-off-by: Jiri Denemark --- Notes: Version 2: - remove useless 'type' parameter from the event src/qemu/qemu_domain.c| 24 src/qemu/qemu_domain.h| 2 ++ src/qemu/qemu_migration.c | 7 +-- 3 files changed, 31

[libvirt] [PATCH v2 5/7] qemu: Do not report completed stats until the job finishes

We would happily report and free statistics of a completed migration even before it actually completed (on the source host while migration is in the Finish phase). Signed-off-by: Jiri Denemark --- Notes: Version 2: - no change src/qemu/qemu_driver.c | 4 +++- 1

Re: [libvirt] [PATCH 13/25] qemu: Introduce qemuBuildChannelsCommandLine

On 02/18/2016 12:50 PM, John Ferlan wrote: > Add new function to manage adding the channel device options to the > command line removing that task from the mainline qemuBuildCommandLine. > > Signed-off-by: John Ferlan > --- > src/qemu/qemu_command.c | 159 >

Re: [libvirt] [PATCH 1/2] qemu: process: Move emulator thread setting code into one function

On 02/24/2016 08:45 AM, Peter Krempa wrote: > Similarly to the refactors to iothreads and vcpus, move the code that > initializes the emulator thread settings into single function. > --- > src/qemu/qemu_cgroup.c | 66 - > src/qemu/qemu_cgroup.h | 1 - >

Re: [libvirt] [PATCHv2 2/3] qemu_cgroup: put qemu right into emulator sub-cgroup

On Tue, 1 Mar 2016 12:34:44 +0100 Peter Krempa wrote: > On Tue, Mar 01, 2016 at 11:20:18 +, Daniel Berrange wrote: > > On Fri, Feb 26, 2016 at 04:34:23PM +0100, Henning Schild wrote: > > > Move qemuProcessSetupEmulator up under qemuSetupCgroup. That way > > > we move

[libvirt] [PATCH] docs: Clarify interface/target/@dev docs

https://bugzilla.redhat.com/show_bug.cgi?id=1313314 Signed-off-by: Jiri Denemark --- docs/formatdomain.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index c54b308..df8c06c 100644 ---

Re: [libvirt] [PATCHv2 2/3] qemu_cgroup: put qemu right into emulator sub-cgroup

On Tue, 1 Mar 2016 11:20:18 + "Daniel P. Berrange" wrote: > On Fri, Feb 26, 2016 at 04:34:23PM +0100, Henning Schild wrote: > > Move qemuProcessSetupEmulator up under qemuSetupCgroup. That way > > we move the one main thread right into the emulator cgroup, instead > > of

Re: [libvirt] [PATCHv2 2/3] qemu_cgroup: put qemu right into emulator sub-cgroup

On Tue, Mar 01, 2016 at 11:20:18 +, Daniel Berrange wrote: > On Fri, Feb 26, 2016 at 04:34:23PM +0100, Henning Schild wrote: > > Move qemuProcessSetupEmulator up under qemuSetupCgroup. That way > > we move the one main thread right into the emulator cgroup, instead > > of moving multiple

Re: [libvirt] [PATCHv2 2/3] qemu_cgroup: put qemu right into emulator sub-cgroup

On Fri, Feb 26, 2016 at 04:34:23PM +0100, Henning Schild wrote: > Move qemuProcessSetupEmulator up under qemuSetupCgroup. That way > we move the one main thread right into the emulator cgroup, instead > of moving multiple threads later on. And we do not actually want any > threads running in the

[libvirt] [PATCH 2/3] vz: add virStorageFileFormat to connection structure

Virtuozzo6 supports only ploop disks for containers and virtual machines. Virtuozzo7 supports only qcow2 for virtual machines. In this patch we add virStorageFileFormat variables to connection structure. Each variable contains disk format that we support for virtual machines and containers. In

[libvirt] [PATCH 1/3] vz: add vzInitVersion function

Move code from connectGetVersion callback to vzInitVersion function Move variable contains version number to connection structure. --- src/vz/vz_driver.c | 50 +++--- src/vz/vz_utils.c | 47 +++

[libvirt] [PATCH 0/3] vz: disk format support

Mikhail Feoktistov (3): vz: add vzInitVersion function vz: add virStorageFileFormat to connection structure vz: check supported disk format src/vz/vz_driver.c | 52 +++--- src/vz/vz_sdk.c| 28 --- src/vz/vz_sdk.h| 2 +-

[libvirt] [PATCH 3/3] vz: check supported disk format

In prlsdkAddDisk() we try to check disk format, before adding disk. If disk format is not specified in XML (VIR_STORAGE_FILE_NONE) than we accept this disk. Otherwise we try to find disk format in connection struct. --- src/vz/vz_driver.c | 2 +- src/vz/vz_sdk.c| 28

[libvirt] [PATCH v3 4/7] libvirt.spec.in: Introduce libvirt-nss package

Lets put the NSS module into its own package. Signed-off-by: Michal Privoznik --- libvirt.spec.in | 21 + 1 file changed, 21 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 03e2438..733b347 100644 --- a/libvirt.spec.in +++

[libvirt] [PATCH v3 3/7] Initial support for NSS plugin skeleton

Name Service Switch is a glibc feature responsible for many things. Translating domain names into IP addresses and vice versa is just one of them. However, currently it's the only functionality that this commit is tickling. Well, in this commit the plugin skeleton is introduced. Implementation to

[libvirt] [PATCH v3 2/7] virjson: Resolve const correctness

Plenty of our virJSON*() APIs don't modify passed object. They merely get a value stored in it. Note this fact in their definition and enforce const correctness. Signed-off-by: Michal Privoznik --- src/util/virjson.c | 58

[libvirt] [PATCH v3 5/7] nss: Implement _nss_libvirt_gethostbyname3_r

The implementation is pretty straightforward. Moreover, because of the nature of things, gethostbyname_r and gethostbyname2_r can be implemented at the same time too. Signed-off-by: Michal Privoznik --- config-post.h | 21 +++ src/Makefile.am| 66

[libvirt] [PATCH v3 1/7] Export virLease* functions for leases file handling

These functions are going to be reused very shortly. So instead of duplicating the code, lets move them into utils module. Signed-off-by: Michal Privoznik --- po/POTFILES.in | 1 + src/Makefile.am| 1 + src/libvirt_private.syms | 6 +

[libvirt] [PATCH v3 7/7] nss: Introduce a test

A small test to see how is the nss module working. Signed-off-by: Michal Privoznik --- cfg.mk | 2 +- tests/Makefile.am | 18 + tests/nssdata/virbr0.status | 20 + tests/nssmock.c | 140 +

[libvirt] [PATCH v3 0/7] NSS module for libvirt

v3 of: https://www.redhat.com/archives/libvir-list/2016-February/msg00693.html diff to v2: - don't link against libvirt.la rather than create a separate small lib to link with - teach nsstest to check multiple addresses Note that patches 1..4 have been ACKed already, but I'm sending them

[libvirt] [PATCH v3 6/7] Implement _nss_libvirt_gethostbyname4_r

This function is a different beast compared to previous ones. But yet again, nothing surprising is happening here. Signed-off-by: Michal Privoznik --- tools/nss/libvirt_nss.c| 92 ++ tools/nss/libvirt_nss.h| 4 ++

Re: [libvirt] [RFC] [libvirt-gconfig] Suggestion about (maybe) re-factoring GVirtConfigDomainGraphics

On Mon, Feb 29, 2016 at 11:51:26PM +0100, Fabiano Fidêncio wrote: > Howdy! > > I've been trying to use libvirt-gobject and libvirt-gconfig, on > virt-viewer, for accessing VMs and looking at their config, instead of > using libvrit and parsing XML directly and turns out, that > libvirt-gconfig is

Re: [libvirt] [PATCH v2 2/2] qemu: add spice opengl support

On 22.02.2016 16:28, Michal Privoznik wrote: > On 22.02.2016 16:04, Daniel P. Berrange wrote: >> On Mon, Feb 22, 2016 at 09:49:04AM -0500, Marc-André Lureau wrote: >>> Hi >>> >>> - Original Message - On 19.02.2016 15:30, Marc-André Lureau wrote: > Add Spice graphics gl attribute.