Re: [libvirt] current master failed to compile

Vasiliy Tolstov wrote: > 2016-03-15 14:39 GMT+03:00 Martin Kletzander : > > What version of libgcrypt or gnutls do you use? Or is it something else > > that provides that struct. It works fine for me with libgcrypt-1.6.5 > > and gnutls-3.3.22. There should be some sort

[libvirt] Does the proposed solution belong in KVM input devices?

qemu-discuss doesn't seem the best place to reach the devs. I saw most of the work on KVM input devices was done by Gerd Hoffman and Dan Berrange. Dan do you think the QEMU virtual keyboard is the right place for a solution similar to the one described below?

[libvirt] [PATCH] rpc: wait longer for session daemon to start up

https://bugzilla.redhat.com/show_bug.cgi?id=1271183 We only wait .5 seconds for the session daemon to start up and present its socket, which isn't sufficient for many users. Bump up the sleep interval and retry amount so we wait for a total of 5 seconds. --- danpb suggests dropping the reverting

Re: [libvirt] [PATCH] qemu: Don't overwrite DomainSave errors

On 03/15/2016 03:35 PM, Pavel Hrdina wrote: > On Tue, Mar 15, 2016 at 03:24:44PM -0400, Cole Robinson wrote: >> These functions already report fine grained errors, there's no >> benefit to overwriting the error here. >> --- >> src/qemu/qemu_driver.c | 4 >> 1 file changed, 4 deletions(-) >

Re: [libvirt] [PATCH] qemu: Don't overwrite DomainSave errors

On Tue, Mar 15, 2016 at 03:24:44PM -0400, Cole Robinson wrote: > These functions already report fine grained errors, there's no > benefit to overwriting the error here. > --- > src/qemu/qemu_driver.c | 4 > 1 file changed, 4 deletions(-) ACK Pavel -- libvir-list mailing list

Re: [libvirt] [RFC PATCH] hostdev: add support for "managed='detach'"

On Tue, 15 Mar 2016 14:21:35 -0400 Laine Stump wrote: > On 03/15/2016 01:00 PM, Daniel P. Berrange wrote: > > On Mon, Mar 14, 2016 at 03:41:48PM -0400, Laine Stump wrote: > >> Suggested by Alex Williamson. > >> > >> If you plan to assign a GPU to a virtual machine, but that

Re: [libvirt] [PATCH v5 2/2] qemuDomainRevertToSnapshot: save domain configuration

On 03/12/2016 10:39 AM, Dmitry Andreev wrote: > Reverting to a snapshot may change domain configuration. New > configuration should be saved if domain has persistent flag. > > VIR_DOMAIN_EVENT_DEFINED_FROM_SNAPSHOT is emitted in case of > configuration update. > --- > src/qemu/qemu_driver.c | 9

[libvirt] [PATCH] qemu: Don't overwrite DomainSave errors

These functions already report fine grained errors, there's no benefit to overwriting the error here. --- src/qemu/qemu_driver.c | 4 1 file changed, 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index edf39d9..36c8fb5 100644 --- a/src/qemu/qemu_driver.c +++

Re: [libvirt] [PATCH] domain: Remove controller/net address whitelists

ping On 03/08/2016 11:39 AM, Cole Robinson wrote: > Judging by how the whitelist has skewed quite far from the original > error message, I think it's better to just drop these. > > If someone wants to revive this check I suggest implementing it on > a per-HV driver basis with PostParse

Re: [libvirt] [PATCH 21/24] hostdev: Stop early if unmanaged devices have not been detached

On 03/15/2016 07:54 AM, Andrea Bolognani wrote: > On Sat, 2016-03-12 at 09:23 -0500, John Ferlan wrote: >> On 03/07/2016 12:24 PM, Andrea Bolognani wrote: >>> >>> Unmanaged devices, as the name suggests, are not detached >>> automatically from the host by libvirt before being attached to a >>>

Re: [libvirt] [PATCH 20/24] hostdev: Save netdev configuration of actual device

On 03/14/2016 02:00 PM, Andrea Bolognani wrote: > Word of warning, since this is very likely to get extremely > verbose: I fully expect to slip, here and there, and refer not > to the *current* situation as of this patch, but to the > *desired* situation at the end of the series. I've rebased

Re: [libvirt] [PATCH] qemu migration: assign addresses in xml passed as parameter

On Tue, Feb 09, 2016 at 11:36:32 +0300, Nikolay Shirokovskiy wrote: > Usecase: > > 1. define domain with xml A where addresses are not set > 2. migrate with '--xml A' This use case is incorrect. To make sure the ABI compatibility checks pass, you should take the XML back from libvirt. In

Re: [libvirt] [RFC PATCH] hostdev: add support for "managed='detach'"

On 03/15/2016 01:00 PM, Daniel P. Berrange wrote: On Mon, Mar 14, 2016 at 03:41:48PM -0400, Laine Stump wrote: Suggested by Alex Williamson. If you plan to assign a GPU to a virtual machine, but that GPU happens to be the host system console, you likely want it to start out using the host

Re: [libvirt] [PATCH] nodedev: Shorten match condition

On Tue, 2016-03-15 at 17:35 +0100, Martin Kletzander wrote: > Just a cleanup I stumbled upon in one of my older branches I did when > browsing through some code and forgot to send it. > > Signed-off-by: Martin Kletzander > --- >  src/conf/node_device_conf.c | 41

Re: [libvirt] question about rdma migration

On Fri, Feb 19, 2016 at 23:37:57 +0200, Roy Shterman wrote: > Yes, > > I tried also running it as root user and it also didn't worked. > > Do you know where libvirt (or QEMU) gets the value for process MEMLOCK? > maybe i can change this value in libvirt code? You can change it by specifying

Re: [libvirt] [PATCH v5 6/9] nss: Implement _nss_libvirt_gethostbyname3_r

On Tue, Mar 15, 2016 at 06:05:53PM +0100, Michal Privoznik wrote: > The implementation is pretty straightforward. Moreover, because > of the nature of things, gethostbyname_r and gethostbyname2_r can > be implemented at the same time too. > > Signed-off-by: Michal Privoznik

[libvirt] [PATCH v5 3/9] virsocketaddr: Introduce virSocketAddrSetIPv6Addr

This is a missing counterpart for virSocketAddrSetIPv4Addr() and is going to be needed later in the tests. Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 1 + src/util/virsocketaddr.c | 15 +++ src/util/virsocketaddr.h | 1 + 3 files changed,

[libvirt] [PATCH v5 0/9] NSS module for libvirt

v5 of: https://www.redhat.com/archives/libvir-list/2016-February/msg00693.html diff to v4: - Dropped the virjson const correctness patch - Worked in Martin's review (small nits here and there) - Dropped libxml2 dependency Patches 1, 4, and 5 have been ACKed already, but I'm sending them for

[libvirt] [PATCH v5 8/9] nss: Introduce a test

A small test to see how is the nss module working. Signed-off-by: Michal Privoznik --- cfg.mk | 2 +- tests/Makefile.am | 18 tests/nssdata/virbr0.status | 20 + tests/nssdata/virbr1.status | 20 + tests/nssmock.c

[libvirt] [PATCH v5 1/9] Export virLease* functions for leases file handling

These functions are going to be reused very shortly. So instead of duplicating the code, lets move them into utils module. Signed-off-by: Michal Privoznik --- po/POTFILES.in | 1 + src/Makefile.am| 1 + src/libvirt_private.syms | 6 +

[libvirt] [PATCH v5 5/9] libvirt.spec.in: Introduce libvirt-nss package

Lets put the NSS module into its own package. Signed-off-by: Michal Privoznik --- libvirt.spec.in | 21 + 1 file changed, 21 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 03e2438..a617949 100644 --- a/libvirt.spec.in +++

[libvirt] [PATCH v5 7/9] Implement _nss_libvirt_gethostbyname4_r

This function is a different beast compared to previous ones. But yet again, nothing surprising is happening here. Signed-off-by: Michal Privoznik --- tools/nss/libvirt_nss.c| 92 ++ tools/nss/libvirt_nss.h| 4 ++

[libvirt] [PATCH v5 2/9] virLeaseReadCustomLeaseFile: Allow server_duid to be NULL

This function is going to be used later in such context where the argument makes no sense. Teach this function to cope with that instead of the caller having to deal with passing some dummy argument. Signed-off-by: Michal Privoznik --- src/util/virlease.c | 2 +- 1 file

[libvirt] [PATCH v5 4/9] Initial support for NSS plugin skeleton

Name Service Switch is a glibc feature responsible for many things. Translating domain names into IP addresses and vice versa is just one of them. However, currently it's the only functionality that this commit is tickling. Well, in this commit the plugin skeleton is introduced. Implementation to

[libvirt] [PATCH v5 9/9] tests: Introduce nsslinktest

The only purpose of this test is to catch possible linking problems with libnss_libvirt.so.2. One of the problems I faced was that the NSS plugin was unloaded immediately after it got loaded and the name resolution process continued with next configured option. Without any error. It was very hard

[libvirt] [PATCH v5 6/9] nss: Implement _nss_libvirt_gethostbyname3_r

The implementation is pretty straightforward. Moreover, because of the nature of things, gethostbyname_r and gethostbyname2_r can be implemented at the same time too. Signed-off-by: Michal Privoznik --- config-post.h | 24 src/Makefile.am| 57

Re: [libvirt] [RFC PATCH] hostdev: add support for "managed='detach'"

On Mon, Mar 14, 2016 at 03:41:48PM -0400, Laine Stump wrote: > Suggested by Alex Williamson. > > If you plan to assign a GPU to a virtual machine, but that GPU happens > to be the host system console, you likely want it to start out using > the host driver (so that boot messages/etc will be

Re: [libvirt] [PATCH] Report error when both live and offline flags are used for migration.

On Wed, Mar 09, 2016 at 20:41:45 +0530, Nitesh Konkar wrote: > Hello Jiri, > > On Tue, Mar 8, 2016 at 8:31 PM, Jiri Denemark wrote: > > > On Thu, Mar 03, 2016 at 06:08:20 -0500, Nitesh Konkar wrote: > > > --- > > > src/libvirt-domain.c | 27 +++ > >

Re: [libvirt] [PATCH 2/2] nodedev: Expose PCI header type

On Tue, Mar 15, 2016 at 05:23:30PM +0100, Martin Kletzander wrote: > If we expose this information, which is one byte in every PCI config > file, we let all mgmt apps know whether the device itself is an endpoint > or not so it's easier for them to decide whether such device can be > passed

[libvirt] [PATCH 1/2] nodedev: Indent PCI express for future fix

Best viewed with '-w' as this is just an adjustment for future patch to be readable without that. Signed-off-by: Martin Kletzander --- src/node_device/node_device_udev.c | 38 -- 1 file changed, 20 insertions(+), 18 deletions(-) diff

[libvirt] [PATCH 2/2] nodedev: Expose PCI header type

If we expose this information, which is one byte in every PCI config file, we let all mgmt apps know whether the device itself is an endpoint or not so it's easier for them to decide whether such device can be passed through into a VM (endpoint) or not (*-bridge). Resolves:

[libvirt] [PATCH 0/2] nodedev: Expose PCI header type information

I can squash those two patches together if it's desirable. Martin Kletzander (2): nodedev: Indent PCI express for future fix nodedev: Expose PCI header type docs/schemas/nodedev.rng | 17 ++ src/conf/node_device_conf.c| 37

Re: [libvirt] [PATCH 22/24] hostdev: Streamline device ownership tracking

On Sun, 2016-03-13 at 10:06 -0400, John Ferlan wrote: >  > On 03/07/2016 12:24 PM, Andrea Bolognani wrote: > >  > > After this patch, ownership of virPCIDevice instances is very easy > > to keep track of: for each host PCI device, the only instance that > > actually matters is the one inside one

[libvirt] [PATCH 04/12] qemu_process: introduce qemuProcessPrepareDomain

Move all code that modifies only live XML to this function. The new VIR_QEMU_PROCESS_START_PRETEND flag will be used by qemuXMLToNative and qemuxml2argvtest later in order to reuse the same code as qemuProcessStart uses. Signed-off-by: Pavel Hrdina ---

[libvirt] [PATCH 06/12] qemu: update callers of qemuProcessStartValidate to use virDomainObjPtr

This change is required by following patches. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_driver.c | 33 tests/qemuxml2argvtest.c | 49 +--- 2 files changed, 42 insertions(+), 40 deletions(-)

[libvirt] [PATCH 05/12] qemu_process: introduce qemuProcessPrepareHost

Move all code that modifies host system to this function. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_migration.c | 3 + src/qemu/qemu_process.c | 191 +- src/qemu/qemu_process.h | 4 + 3 files changed, 113 insertions(+),

[libvirt] [PATCH 08/12] qemu_process: move qemuDomainSetPrivatePaths to qemuProcessInit

Signed-off-by: Pavel Hrdina --- src/qemu/qemu_process.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 6265cf5..9894e3c 100644 --- a/src/qemu/qemu_process.c +++

[libvirt] [PATCH 07/12] qemu_process: move checks to qemuProcessStartValidate

Move all code that checks host and domain. Do not check host if we use VIR_QEMU_PROCESS_START_PRETEND flag. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_driver.c| 4 +- src/qemu/qemu_migration.c | 2 +- src/qemu/qemu_process.c | 168

[libvirt] [PATCH 12/12] qemuxml2argvtest: cleanup test

Use qemuProcessCreateCmd instead duplicating required steps from qemuProcessStart. Signed-off-by: Pavel Hrdina --- tests/qemuxml2argvtest.c | 38 +++--- 1 file changed, 3 insertions(+), 35 deletions(-) diff --git a/tests/qemuxml2argvtest.c

[libvirt] [PATCH 03/12] tests: cleanup qemuxml2argvtest

This removes the testFailed magic and makes the code more readable. Signed-off-by: Pavel Hrdina --- tests/qemuxml2argvtest.c | 62 ++-- 1 file changed, 28 insertions(+), 34 deletions(-) diff --git a/tests/qemuxml2argvtest.c

[libvirt] [PATCH 10/12] qemu_driver: cleanup qemuConnectDomainXMLToNative

Use qemuProcessCreateCmd instead duplicating required steps from qemuProcessStart. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_driver.c | 42 ++ 1 file changed, 2 insertions(+), 40 deletions(-) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH 09/12] qemu_process: introduce qemuProcessCreateCmd

This will skip few steps from qemuProcessStart in order to create only qemu CMD. Use a VIR_QEMU_PROCESS_START_PRETEND for all the qemuProcess* functions called by this one to not modify or check host. This new function will be used later on for XMLToNative API and also for qemuxml2argvtest to

[libvirt] [PATCH 11/12] qemuxml2argvtest: use driver.config and priv for qemuDomainSetPrivatePaths

Update testutilsqemu to overwrite libDir and channelTargetDir and set private paths using domain's privateData. This changes is required for following patch. Signed-off-by: Pavel Hrdina --- .../qemuxml2argv-channel-virtio-unix.xml | 2 +-

[libvirt] [PATCH 02/12] nvram: generate it's path in qemuDomainDefPostParse

The postParse callback is the correct place to generate default values that should be present in offline XML. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_domain.c | 10 src/qemu/qemu_process.c | 153 ++-- 2 files changed,

[libvirt] [PATCH 00/12] qemu_process cleanups and test improvement

The first patch is unrelated but I've found it while working on this series. Pavel Hrdina (12): qemu_process: check for correct return value while starting domain nvram: generate it's path in qemuDomainDefPostParse tests: cleanup qemuxml2argvtest qemu_process: introduce

[libvirt] [PATCH 01/12] qemu_process: check for correct return value while starting domain

Function qemuProcessLaunch returns '-2' in case there was an error and we need to cleanup labels. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c

Re: [libvirt] [PATCH lxc_ethernet] lxc:support network type with ethernet

2016-01-10 16:10 GMT+03:00 Martin Kletzander : > This is basically a copy-paste from the bridged interface creation, but > it is not connected anywhere. And the script that should be ran is not > ran at all, so even if I were to route the local part of the veth pair >

Re: [libvirt] current master failed to compile

2016-03-15 15:08 GMT+03:00 Vasiliy Tolstov : >> What version of libgcrypt or gnutls do you use? Or is it something else >> that provides that struct. It works fine for me with libgcrypt-1.6.5 >> and gnutls-3.3.22. There should be some sort of guidance somewhere what >> to

Re: [libvirt] current master failed to compile

2016-03-15 14:39 GMT+03:00 Martin Kletzander : > What version of libgcrypt or gnutls do you use? Or is it something else > that provides that struct. It works fine for me with libgcrypt-1.6.5 > and gnutls-3.3.22. There should be some sort of guidance somewhere what > to use

Re: [libvirt] [PATCH 21/24] hostdev: Stop early if unmanaged devices have not been detached

On Sat, 2016-03-12 at 09:23 -0500, John Ferlan wrote: > On 03/07/2016 12:24 PM, Andrea Bolognani wrote: > >  > > Unmanaged devices, as the name suggests, are not detached > > automatically from the host by libvirt before being attached to a > > guest: it's the user's responsability to detach them

Re: [libvirt] [PATCH v2] qemu: Move last error save/restore to qemuBuildNetCommandLine

On Tue, Mar 15, 2016 at 07:36:44AM -0400, John Ferlan wrote: Commit 'ef2ab8fd' moved just the virDomainConfNWFilterTeardown and left the logic to save/restore the current error essentially doing nothing in the error path for qemuBuildCommandLine. So move it to where it was meant to be.

Re: [libvirt] [PATCH v2] qemu: Move last error save/restore to qemuBuildNetCommandLine

On 03/15/2016 07:36 AM, John Ferlan wrote: > Commit 'ef2ab8fd' moved just the virDomainConfNWFilterTeardown and left > the logic to save/restore the current error essentially doing nothing > in the error path for qemuBuildCommandLine. So move it to where it > was meant to be. > > Although the

Re: [libvirt] current master failed to compile

On Mon, Mar 14, 2016 at 08:26:42PM +0300, Vasiliy Tolstov wrote: libvirt.c:323:15: error: 'gcry_thread_cbs' is deprecated [-Werror=deprecated-declarations] static struct gcry_thread_cbs virTLSThreadImpl = { ^ What version of libgcrypt or gnutls do you use? Or is it something

[libvirt] [PATCH v2] qemu: Move last error save/restore to qemuBuildNetCommandLine

Commit 'ef2ab8fd' moved just the virDomainConfNWFilterTeardown and left the logic to save/restore the current error essentially doing nothing in the error path for qemuBuildCommandLine. So move it to where it was meant to be. Although the original code would reset the filter on command creation

Re: [libvirt] [PATCH v3 00/14] Implement post-copy migration

On Fri, Mar 04, 2016 at 18:20:51 +0100, Jiri Denemark wrote: > On Wed, Mar 02, 2016 at 12:42:21 +0100, Jiri Denemark wrote: > > (See "Add public APIs for post-copy migration" patch for more details > > about post-copy migration.) > > > > Post-copy support was originally written by Cristian Klein

Re: [libvirt] [PATCH 1/3] qemu: Make all SPICE command-line args optional

On Tue, Mar 15, 2016 at 10:20:48AM +0100, Christophe Fergeau wrote: > The goal is to not add -spice port=0,addr=127.0.0.1 to QEMU command line > when no SPICE port is specified in libvirt XML. Misleading, even after the series port=0 is generated. > Before this change, we could rely on port or

Re: [libvirt] [PATCH 2/3] qemu: Omit SPICE address if no port is specified

On Tue, Mar 15, 2016 at 10:20:49AM +0100, Christophe Fergeau wrote: > Currently -spice addr=127.0.0.1 is generated, but spice-server is going > to ignore this as no port is specified. > --- > > This one is more readable with git show -w, it's just > if (port > 0 || tlsPort > 0) { > > } > >

Re: [libvirt] [PATCH 0/2] qemu: Support for QXL heads

On Tue, Mar 15, 2016 at 10:07:42AM +0100, Christophe Fergeau wrote: On Thu, Mar 10, 2016 at 03:52:54PM +0100, Martin Kletzander wrote: I'm not sure how to handle this, but I was under the impression that this can be changed on the fly. If libvirt doesn't support that, then we should enable it.

Re: [libvirt] [PATCH 15/24] hostdev: Remove virHostdevGetActivePCIHostDeviceList()

On Mon, 2016-03-14 at 19:40 -0400, John Ferlan wrote: > > All in all, I believe this is still correct and can be pushed > > along with patches 18 and 19 (after taking care of your > > comments there) before moving on with the more troublesome > > patch 20. Let me know whether you agree :) > >  > I

Re: [libvirt] Block replication driver

Sorry for my late response ... On Mon, Feb 22, 2016 at 22:51:55 +0100, Simon wrote: > On 02/16, Peter Krempa wrote: > > On Fri, Feb 12, 2016 at 13:22:01 -0700, Eric Blake wrote: > > > On 12/02/2015 02:08 AM, Simon Kollberg wrote: > > > > [...] > > > > > > My initial thought was to manually set

[libvirt] [PATCH 1/3] qemu: Make all SPICE command-line args optional

The goal is to not add -spice port=0,addr=127.0.0.1 to QEMU command line when no SPICE port is specified in libvirt XML. Before this change, we could rely on port or tlsPort to always be present, so subsequent args could be unconditionally appended with a leading ','. Now that it's no longer the

[libvirt] [PATCH 3/3] qemu: Don't add -spice port=0 when no port is specified

If a has no port nor tlsPort set, the generated QEMU command line will contain -spice port=0. This is later going to be ignored by spice-server, but it's better not to add it at all in this situation. --- src/qemu/qemu_command.c| 2 +-

[libvirt] [PATCH 0/3] Cosmetic changes to SPICE QEMU commandline

Hey, I've been trying out the recently adding virgl support, which does not need any TCP port/address to be set (it's directly opening a local unix fd). While looking at QEMU command line in configs such as , I've noticed that the QEMU command line gets some 'useless' arguments such as -spice

[libvirt] [PATCH 2/3] qemu: Omit SPICE address if no port is specified

Currently -spice addr=127.0.0.1 is generated, but spice-server is going to ignore this as no port is specified. --- This one is more readable with git show -w, it's just if (port > 0 || tlsPort > 0) { } Christophe src/qemu/qemu_command.c| 65

Re: [libvirt] [PATCH 0/2] qemu: Support for QXL heads

On Thu, Mar 10, 2016 at 03:52:54PM +0100, Martin Kletzander wrote: > I'm not sure how to handle this, but I was under the impression that > this can be changed on the fly. If libvirt doesn't support that, then > we should enable it. From the spice side, this seems to be changeable on the fly.

[libvirt] [PATCH 0/6] vz: add disk and controller check in domainPostParse phase

Mikhail Feoktistov (6): vz: save vz version in connection structure vz: add vzCapabilities to connection structure vz: check supported disk format and bus vz: report correct disk format in domainGetXMLDesc vz: check supported controllers vz: set default SCSI model src/vz/vz_driver.c

[libvirt] [PATCH 3/6] vz: check supported disk format and bus

In DomainPostParse phase we check disk format and bus. If disk format is not specified in XML (VIR_STORAGE_FILE_NONE) than we accept this disk. Otherwise we try to find disk format in vzCapabilities struct. Also we try to find disk bus in vzCapabilities->diskBuses. It contains buses that we

[libvirt] [PATCH 2/6] vz: add vzCapabilities to connection structure

Virtuozzo6 supports only ploop disks for containers and virtual machines on IDE SCSI and SATA buses. Virtuozzo7 supports only qcow2 for virtual machines on IDE and SCSI buses. In this patch we add vzCapabilities structure to connection structure. It contains disk formats and list of buses that we

[libvirt] [PATCH 1/6] vz: save vz version in connection structure

Move code from connectGetVersion callback to vzInitVersion function --- src/vz/vz_driver.c | 50 +++--- src/vz/vz_utils.c | 47 +++ src/vz/vz_utils.h | 3 +++ 3 files changed, 57 insertions(+), 43

[libvirt] [PATCH 4/6] vz: report correct disk format in domainGetXMLDesc

We should report correct disk format, because it depends on virtuozzo version and domain type. Now we support only one disk format for each domain type. So we can take it from vzCapabilities structure. --- src/vz/vz_sdk.c | 29 + 1 file changed, 17 insertions(+), 12

[libvirt] [PATCH 6/6] vz: set default SCSI model

Each version of virtuozzo supports only one type of SCSI controller So if we add disk on SCSI bus, we should set SCSI controller model. We can take it from vzCapabilities structure. --- src/vz/vz_driver.c | 2 +- src/vz/vz_sdk.c| 27 +++ src/vz/vz_sdk.h| 2 +-

[libvirt] [PATCH 5/6] vz: check supported controllers

Virtuozzo6 supports only SCSI(BUSLOGIC) IDE and SATA controllers. Virtuozzo7 supports only SCSI(VIRTIO_SCSI) and IDE. In this patch we add list of supported controllers and scsi models to vzCapabilities structure. In openConnection() callback we get virtuozzo version and select proper

[libvirt] [PATCH 5/6] zfs: Only raw volumes are supported

--- src/storage/storage_backend_zfs.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/storage/storage_backend_zfs.c b/src/storage/storage_backend_zfs.c index 4129aae..077543d 100644 --- a/src/storage/storage_backend_zfs.c +++ b/src/storage/storage_backend_zfs.c @@ -301,6 +301,12 @@

[libvirt] [PATCH 2/6] sheepdog: Use a consistent error message

This also reduces the number of strings to translate. --- src/storage/storage_backend_sheepdog.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c index a3bd78a..001d16f 100644 ---

[libvirt] [PATCH 4/6] logical: Only raw volumes are supported

--- src/storage/storage_backend_logical.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c index 90a194e..39e8b80 100644 --- a/src/storage/storage_backend_logical.c +++ b/src/storage/storage_backend_logical.c

[libvirt] [PATCH 6/6] zfs: Only unencrypted volumes are supported

--- src/storage/storage_backend_zfs.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/storage/storage_backend_zfs.c b/src/storage/storage_backend_zfs.c index 077543d..5238ecc 100644 --- a/src/storage/storage_backend_zfs.c +++ b/src/storage/storage_backend_zfs.c @@ -307,6 +307,13

[libvirt] [PATCH 3/6] storage: Improve code consistency between backends

This improves the code consistency around freeing vol->target.path in createVol implementations. --- src/storage/storage_backend_logical.c | 2 -- src/storage/storage_backend_zfs.c | 6 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/storage/storage_backend_logical.c

[libvirt] [PATCH 1/6] rbd: Use proper error type

--- src/storage/storage_backend_rbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index 7d04b39..3e70a42 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@