Re: [libvirt] [PATCH] qemu: fix build without gnutls installed

2016-04-09 Thread Roman Bogorodskiy
Cole Robinson wrote: > On 04/09/2016 03:13 PM, Roman Bogorodskiy wrote: > > Move including of gnutls/gnutls.h in qemu/qemu_domain.c under the > > "ifdef WITH_GNUTLS" check because otherwise it fails like this: > > > > CC qemu/libvirt_driver_qemu_impl_la-qemu_domain.lo > > qemu/qemu_doma

[libvirt] [PATCH] tools: virsh: Add some example values to attach-disk --help

2016-04-09 Thread Cole Robinson
https://bugzilla.redhat.com/show_bug.cgi?id=982630 --- tools/virsh-domain.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 36d0353..46598bb 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -322,11 +322

Re: [libvirt] [PATCH] build: work around gcc 6.0 warnings

2016-04-09 Thread Cole Robinson
On 04/08/2016 12:27 PM, Andrea Bolognani wrote: > On Mon, 2016-02-29 at 15:41 +0100, Martin Kletzander wrote: >> On Wed, Feb 24, 2016 at 02:29:58PM -0700, Eric Blake wrote: >>> >>> gcc 6.0 added an annoying warning: >>> >>> fdstream.c: In function 'virFDStreamWrite': >>> fdstream.c:390:29: erro

Re: [libvirt] [PATCH] qemu: fix build without gnutls installed

2016-04-09 Thread Cole Robinson
On 04/09/2016 03:13 PM, Roman Bogorodskiy wrote: > Move including of gnutls/gnutls.h in qemu/qemu_domain.c under the > "ifdef WITH_GNUTLS" check because otherwise it fails like this: > > CC qemu/libvirt_driver_qemu_impl_la-qemu_domain.lo > qemu/qemu_domain.c:50:10: fatal error: 'gnutls/gnu

Re: [libvirt] [PATCH] po: fix POTFILES.in file ordering

2016-04-09 Thread Cole Robinson
On 04/09/2016 02:10 PM, Erik Skultety wrote: > When it comes to a situation that a new translatable file needs to be added > into the list of files, an automatically generated patch is proposed during > syntax-check. However, the diff was made against a sorted list of files and > the same sorted li

Re: [libvirt] [PATCH 18/18] qemu_domain: remove all listens if vncAutoUnixSocket is enabled

2016-04-09 Thread Cole Robinson
On 04/09/2016 05:23 PM, Pavel Hrdina wrote: > On Fri, Apr 08, 2016 at 01:40:21PM -0400, Cole Robinson wrote: >> On 04/04/2016 09:20 AM, Pavel Hrdina wrote: >>> If in qemu.conf vncAutoUnixSocket is enabled remove all other listens >>> parsed from XML config. >>> >>> Signed-off-by: Pavel Hrdina >> >

Re: [libvirt] [PATCH 18/18] qemu_domain: remove all listens if vncAutoUnixSocket is enabled

2016-04-09 Thread Pavel Hrdina
On Fri, Apr 08, 2016 at 01:40:21PM -0400, Cole Robinson wrote: > On 04/04/2016 09:20 AM, Pavel Hrdina wrote: > > If in qemu.conf vncAutoUnixSocket is enabled remove all other listens > > parsed from XML config. > > > > Signed-off-by: Pavel Hrdina > > Sorry I should have read further before comme

[libvirt] [PATCH v3] Add macro for handling exponential backoff loops.

2016-04-09 Thread Richard W.M. Jones
v2 was here: https://www.redhat.com/archives/libvir-list/2016-April/thread.html#00355 v2->v3: - Rename virTimeBackOffInit -> Start. - virTimeBackOffStart now returns an error indication. - Remove var->first and var->timeout fields from struct. - Change var->limit field name to limit_t. -

[libvirt] [PATCH v3] Add macro for handling exponential backoff loops.

2016-04-09 Thread Richard W.M. Jones
In a few places in libvirt we busy-wait for events, for example qemu creating a monitor socket. This is problematic because: - We need to choose a sufficiently small polling period so that libvirt doesn't add unnecessary delays. - We need to choose a sufficiently large polling period so tha

[libvirt] [PATCH] qemu: fix build without gnutls installed

2016-04-09 Thread Roman Bogorodskiy
Move including of gnutls/gnutls.h in qemu/qemu_domain.c under the "ifdef WITH_GNUTLS" check because otherwise it fails like this: CC qemu/libvirt_driver_qemu_impl_la-qemu_domain.lo qemu/qemu_domain.c:50:10: fatal error: 'gnutls/gnutls.h' file not found in case if gnutls is not installed o

[libvirt] [PATCH] po: fix POTFILES.in file ordering

2016-04-09 Thread Erik Skultety
When it comes to a situation that a new translatable file needs to be added into the list of files, an automatically generated patch is proposed during syntax-check. However, the diff was made against a sorted list of files and the same sorted list of files + the new file that actually needs to be

[libvirt] [PATCH] nwfilter: fix lock order deadlock

2016-04-09 Thread Maxim Nestratov
Below is backtraces of two deadlocked threads: thread #1: virDomainConfVMNWFilterTeardown virNWFilterTeardownFilter lock updateMutex < _virNWFilterTeardownFilter try to lock interface <-- thread #2: learnIPAddressThread lock interface <--

Re: [libvirt] [libvirt-php PATCH 00/35] Add PHP7 support and unit tests

2016-04-09 Thread Vasiliy Tolstov
2016-04-09 1:08 GMT+03:00 Neal Gompa : > First, I apologize if this was sent twice to anyone. I had an error > in my git send-email configuration. > > This patch set primarily adds support for PHP 7 to libvirt-php, > but also adds the capability for libvirt-php to be built > using the standard PHP

Re: [libvirt] [PATCH] nss: properly include syms files to dist

2016-04-09 Thread Roman Bogorodskiy
Cole Robinson wrote: > On 04/09/2016 01:32 AM, Roman Bogorodskiy wrote: > > Explicitly add Linux and BSD syms files for nss to EXTRA_DIST > > instead of using the LIBVIRT_NSS_SYMBOL_FILE variable, because its value > > will point to either Linux or BSD syms file, but we need to ship both. > > --

Re: [libvirt] [PATCH] nss: properly include syms files to dist

2016-04-09 Thread Cole Robinson
On 04/09/2016 01:32 AM, Roman Bogorodskiy wrote: > Explicitly add Linux and BSD syms files for nss to EXTRA_DIST > instead of using the LIBVIRT_NSS_SYMBOL_FILE variable, because its value > will point to either Linux or BSD syms file, but we need to ship both. > --- > tools/Makefile.am | 5 +++-- >