2016-04-08 23:12 GMT+08:00 Cole Robinson :
> When sending a v2, please give a description of what changed compared to the
> previous patch version, after the --- break so it doesn't show up in the
> commit message. For example:
Nice proposal. Thanks.
>
> On 04/04/2016 06:49 AM, Hui Yiqun wrote:
>>
https://bugzilla.redhat.com/show_bug.cgi?id=1303885
---
src/logging/log_daemon.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/logging/log_daemon.c b/src/logging/log_daemon.c
index 68f0647..f674cbd 100644
--- a/src/logging/log_daemon.c
+++ b/src/logging/log_daemon.c
@@ -1212,6 +1212,8
Finally wire-up the client processing controls APIs into virt-admin client.
Signed-off-by: Erik Skultety
---
tools/virt-admin.c | 182 +
1 file changed, 182 insertions(+)
diff --git a/tools/virt-admin.c b/tools/virt-admin.c
index f0a49a3..3fe4
Enable retrieval of the number of maximum clients connected to all sockets
combined as well as the number of maximum clients waiting for authentication,
in order to be successfully connected. These are the attributes configurable
through libvirtd.conf, however, it could be handy to not only know va
Add some trivial getters for client related attributes to virnetserver before
any admin method can be introduced.
Signed-off-by: Erik Skultety
---
src/rpc/virnetserver.c | 48
src/rpc/virnetserver.h | 5 +
2 files changed, 53 insertions(+)
d
Opposite operation to virAdmServerGetClientProcessingControls. Understandably
though, setting values for current number of clients connected or still waiting
for authentication does not make sense, since changes to these values are event
dependent, i.e. a client connects - counter is increased. Thu
Make all relevant changes to admin interface and admin protocol, in order to
support typed parameters within admin API as well.
Signed-off-by: Erik Skultety
---
cfg.mk | 2 +-
daemon/admin.c | 1 +
daemon/admin_server.c | 1 +
src/admin/admin_protocol.x |
In order for typed params validation to pass on daemon side, we should
encourage users to use our exported constants with typed params to diminish
to avoid any potential problems related to argument validity.
Signed-off-by: Erik Skultety
---
include/libvirt/libvirt-admin.h | 42 +
Commits 0472cef6, 9afc115f, 8cd1d546 exported typed params handlers internally,
but a commit which would move the public definition from libvirt-host to
libvirt-common was missing.
Signed-off-by: Erik Skultety
---
include/libvirt/libvirt-common.h.in | 185 +++
inc
- APIs enable retrieval of values for maximum number of clients allowed to be
connected, maximum number of clients allowed to wait for authentication, as
well as current (dynamic) values for both cases; expectedly, setter only allows
to set the limits available through libvirtd.conf
- until patch "
On 10/04/16 19:33, Pavel Hrdina wrote:
> On Sun, Apr 10, 2016 at 07:11:39PM +0200, Erik Skultety wrote:
>> Commit e72667bd tried to fix the incorrect file ordering in po/POTFILES.in
>> except it didn't, since the sort was run using locale en_US instead of
>> using locale C which is the default in l
On Sun, Apr 10, 2016 at 07:11:39PM +0200, Erik Skultety wrote:
> Commit e72667bd tried to fix the incorrect file ordering in po/POTFILES.in
> except it didn't, since the sort was run using locale en_US instead of
> using locale C which is the default in libvirt. So this patch hopefully fixes
> it f
On 10/04/16 14:03, Pavel Hrdina wrote:
> On Sat, Apr 09, 2016 at 08:10:55PM +0200, Erik Skultety wrote:
>> When it comes to a situation that a new translatable file needs to be added
>> into the list of files, an automatically generated patch is proposed during
>> syntax-check. However, the diff wa
Commit e72667bd tried to fix the incorrect file ordering in po/POTFILES.in
except it didn't, since the sort was run using locale en_US instead of
using locale C which is the default in libvirt. So this patch hopefully fixes
it for good.
Signed-off-by: Erik Skultety
---
po/POTFILES.in | 36 ++
This combines Eric's and Cole's ideas together with configure check for GCC that
is affected by https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69602.
Pavel Hrdina (2):
build: cleanup GCC < 4.6 -Wlogical-op workaround
build: add GCC 6.0 -Wlogical-op workaround
m4/virt-compile-warnings.m4 |
fdstream.c: In function 'virFDStreamWrite':
fdstream.c:390:29: error: logical 'or' of equal expressions [-Werror=logical-op]
if (errno == EAGAIN || errno == EWOULDBLOCK) {
^~
Fedora rawhide now uses gcc 6.0 and there is a bug with -Wlogical-op
producing false wa
Signed-off-by: Pavel Hrdina
---
m4/virt-compile-warnings.m4 | 2 +-
src/internal.h | 10 ++
src/util/virbuffer.c| 11 +++
src/util/virstring.c| 9 +
src/util/virsysinfo.c | 13 ++---
5 files changed, 17 insertions(+), 28 deletio
On 2016-04-08 21:53, Cole Robinson wrote:
I suggest asking on one of the spice mailing lists
- Cole
Thanks. Report filed there:
https://lists.freedesktop.org/archives/spice-devel/2016-April/028133.html
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinf
On Sat, Apr 09, 2016 at 08:10:55PM +0200, Erik Skultety wrote:
> When it comes to a situation that a new translatable file needs to be added
> into the list of files, an automatically generated patch is proposed during
> syntax-check. However, the diff was made against a sorted list of files and
>
On 10/04/16 03:33, Cole Robinson wrote:
> On 04/09/2016 02:10 PM, Erik Skultety wrote:
>> When it comes to a situation that a new translatable file needs to be added
>> into the list of files, an automatically generated patch is proposed during
>> syntax-check. However, the diff was made against
20 matches
Mail list logo
